diff options
| author | Kevin Buettner <kevinb@redhat.com> | 2010-12-15 20:53:06 +0000 |
|---|---|---|
| committer | Kevin Buettner <kevinb@redhat.com> | 2010-12-15 20:53:06 +0000 |
| commit | a879222a9818cc283b15ce90ff45cda33899178f (patch) | |
| tree | 2bef21c6e30b85954c2f97eb8448d89f168f20a3 /gdb/mips-tdep.c | |
| parent | 62d79c9a7841f6de070137b37dc138bfff7d62d4 (diff) | |
| download | gdb-a879222a9818cc283b15ce90ff45cda33899178f.tar.gz | |
* mips-tdep.c (mips_pseudo_register_write): Sign extend 32-bit
cooked values that are being transferred to 64-bit raw registers.
(mips_pseudo_register_read): Revise to preserve symmetry with
mips_pseudo_register_write().
Diffstat (limited to 'gdb/mips-tdep.c')
| -rw-r--r-- | gdb/mips-tdep.c | 22 |
1 files changed, 16 insertions, 6 deletions
diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c index 98e7a3e0566..36d59ddd4ff 100644 --- a/gdb/mips-tdep.c +++ b/gdb/mips-tdep.c @@ -559,11 +559,15 @@ mips_pseudo_register_read (struct gdbarch *gdbarch, struct regcache *regcache, else if (register_size (gdbarch, rawnum) > register_size (gdbarch, cookednum)) { - if (gdbarch_tdep (gdbarch)->mips64_transfers_32bit_regs_p - || gdbarch_byte_order (gdbarch) == BFD_ENDIAN_LITTLE) + if (gdbarch_tdep (gdbarch)->mips64_transfers_32bit_regs_p) regcache_raw_read_part (regcache, rawnum, 0, 4, buf); else - regcache_raw_read_part (regcache, rawnum, 4, 4, buf); + { + enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); + LONGEST regval; + regcache_raw_read_signed (regcache, rawnum, ®val); + store_signed_integer (buf, 4, byte_order, regval); + } } else internal_error (__FILE__, __LINE__, _("bad register size")); @@ -582,11 +586,17 @@ mips_pseudo_register_write (struct gdbarch *gdbarch, else if (register_size (gdbarch, rawnum) > register_size (gdbarch, cookednum)) { - if (gdbarch_tdep (gdbarch)->mips64_transfers_32bit_regs_p - || gdbarch_byte_order (gdbarch) == BFD_ENDIAN_LITTLE) + if (gdbarch_tdep (gdbarch)->mips64_transfers_32bit_regs_p) regcache_raw_write_part (regcache, rawnum, 0, 4, buf); else - regcache_raw_write_part (regcache, rawnum, 4, 4, buf); + { + /* Sign extend the shortened version of the register prior + to placing it in the raw register. This is required for + some mips64 parts in order to avoid unpredictable behavior. */ + enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); + LONGEST regval = extract_signed_integer (buf, 4, byte_order); + regcache_raw_write_signed (regcache, rawnum, regval); + } } else internal_error (__FILE__, __LINE__, _("bad register size")); |