summaryrefslogtreecommitdiff
path: root/gdb/printcmd.c
diff options
context:
space:
mode:
authorJoel Brobecker <brobecker@gnat.com>2012-09-11 21:26:15 +0000
committerJoel Brobecker <brobecker@gnat.com>2012-09-11 21:26:15 +0000
commitf567384da7903ce70ca479aa2a904aae7fbf55b6 (patch)
tree5be9e6e8a4498baa1152bd0d3f42d6444cc14b95 /gdb/printcmd.c
parent3d981902a7c0dd5a0eabc8e2a11463f9f3217e5d (diff)
downloadgdb-f567384da7903ce70ca479aa2a904aae7fbf55b6.tar.gz
Name of symbol missing when printing global variable's address
The build_address_symbolic funnction filters out data symbols if their size is set to zero. But the problem is that the COFF symbol table (for instance) does not provide any size information, leaving the size to its default value of zero, thus always triggering the filter. This shows up when trying to print the address of a global variable when debugging a Windows executable, for instance. gdb/ChangeLog: * symtab.h (struct minimal_symbol) [has_size]: New field. (MSYMBOL_SIZE): Adjust to forbid macro from being used as lvalue. (SET_MSYMBOL_SIZE, MSYMBOL_HAS_SIZE): New macros. * printcmd.c (build_address_symbolic): Only filter out zero-sized minimal symbols if the symbol's size is actually known. * minsyms.c (prim_record_minimal_symbol_full): Adjust setting of msymbol's size field. Add comment. * elfread.c (elf_symtab_read, elf_rel_plt_read): Use SET_MSYMBOL_SIZE to set the minimal symbol size.
Diffstat (limited to 'gdb/printcmd.c')
-rw-r--r--gdb/printcmd.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/gdb/printcmd.c b/gdb/printcmd.c
index d5b5b63122a..9e8cd659cad 100644
--- a/gdb/printcmd.c
+++ b/gdb/printcmd.c
@@ -680,6 +680,7 @@ build_address_symbolic (struct gdbarch *gdbarch,
}
if (msymbol != NULL
+ && MSYMBOL_HAS_SIZE (msymbol)
&& MSYMBOL_SIZE (msymbol) == 0
&& MSYMBOL_TYPE (msymbol) != mst_text
&& MSYMBOL_TYPE (msymbol) != mst_text_gnu_ifunc