diff options
| author | Pedro Alves <palves@redhat.com> | 2013-04-19 15:22:46 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2013-04-19 15:22:46 +0000 |
| commit | 4b42dc673381808a31f0f6cc7ed7eccd3c9043b8 (patch) | |
| tree | 4951ab632a34b777e91dd61b1fc8d1cc1dd80615 /gdb/s390-tdep.c | |
| parent | cea2b1f6f345e375adba8f2eb9861b004d33c1e8 (diff) | |
| download | gdb-4b42dc673381808a31f0f6cc7ed7eccd3c9043b8.tar.gz | |
-Wpointer-sign: s390-tdep.c.
-Wpointer-sign reveals a bunch of:
../../src/gdb/s390-tdep.c:1342:7: error: pointer targets in passing argument 4 of ‘is_rx’ differ in signedness [-Werror=pointer-sign]
../../src/gdb/s390-tdep.c:1038:1: note: expected ‘unsigned int *’ but argument is of type ‘int *’
../../src/gdb/s390-tdep.c:1343:9: error: pointer targets in passing argument 5 of ‘is_rxy’ differ in signedness [-Werror=pointer-sign]
../../src/gdb/s390-tdep.c:1055:1: note: expected ‘unsigned int *’ but argument is of type ‘int *’
../../src/gdb/s390-tdep.c:1344:9: error: pointer targets in passing argument 5 of ‘is_rxy’ differ in signedness [-Werror=pointer-sign]
../../src/gdb/s390-tdep.c:1055:1: note: expected ‘unsigned int *’ but argument is of type ‘int *’
...
../../src/gdb/s390-tdep.c:1363:7: error: pointer targets in passing argument 5 of ‘is_rs’ differ in signedness [-Werror=pointer-sign]
../../src/gdb/s390-tdep.c:966:1: note: expected ‘unsigned int *’ but argument is of type ‘int *’
../../src/gdb/s390-tdep.c:1364:9: error: pointer targets in passing argument 6 of ‘is_rsy’ differ in signedness [-Werror=pointer-sign]
../../src/gdb/s390-tdep.c:983:1: note: expected ‘unsigned int *’ but argument is of type ‘int *’
../../src/gdb/s390-tdep.c:1365:9: error: pointer targets in passing argument 6 of ‘is_rsy’ differ in signedness [-Werror=pointer-sign]
../../src/gdb/s390-tdep.c:983:1: note: expected ‘unsigned int *’ but argument is of type ‘int *’
...
I don't know much about s390, but from reading the code I believe the
right fix is to treat d2 as signed.
gdb/
2013-04-19 Pedro Alves <palves@redhat.com>
* s390-tdep.c (is_rs, is_rsy, is_rx, is_rxy): Change type of 'd2'
parameter to int *.
Diffstat (limited to 'gdb/s390-tdep.c')
| -rw-r--r-- | gdb/s390-tdep.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gdb/s390-tdep.c b/gdb/s390-tdep.c index 50f88771f00..641bc80a368 100644 --- a/gdb/s390-tdep.c +++ b/gdb/s390-tdep.c @@ -964,7 +964,7 @@ is_rre (bfd_byte *insn, int op, unsigned int *r1, unsigned int *r2) static int is_rs (bfd_byte *insn, int op, - unsigned int *r1, unsigned int *r3, unsigned int *d2, unsigned int *b2) + unsigned int *r1, unsigned int *r3, int *d2, unsigned int *b2) { if (insn[0] == op) { @@ -981,7 +981,7 @@ is_rs (bfd_byte *insn, int op, static int is_rsy (bfd_byte *insn, int op1, int op2, - unsigned int *r1, unsigned int *r3, unsigned int *d2, unsigned int *b2) + unsigned int *r1, unsigned int *r3, int *d2, unsigned int *b2) { if (insn[0] == op1 && insn[5] == op2) @@ -1036,7 +1036,7 @@ is_rie (bfd_byte *insn, int op1, int op2, static int is_rx (bfd_byte *insn, int op, - unsigned int *r1, unsigned int *d2, unsigned int *x2, unsigned int *b2) + unsigned int *r1, int *d2, unsigned int *x2, unsigned int *b2) { if (insn[0] == op) { @@ -1053,7 +1053,7 @@ is_rx (bfd_byte *insn, int op, static int is_rxy (bfd_byte *insn, int op1, int op2, - unsigned int *r1, unsigned int *d2, unsigned int *x2, unsigned int *b2) + unsigned int *r1, int *d2, unsigned int *x2, unsigned int *b2) { if (insn[0] == op1 && insn[5] == op2) |