diff options
| author | Pedro Alves <pedro@codesourcery.com> | 2010-02-22 23:35:15 +0000 |
|---|---|---|
| committer | Pedro Alves <pedro@codesourcery.com> | 2010-02-22 23:35:15 +0000 |
| commit | 56e02e3cda921077c89036f7218ba2d7ff6a1924 (patch) | |
| tree | 5995575a28596c00c4bb85494b28fde97f6b3c6f /gdb/target.h | |
| parent | a3e8ea1a16851333fe7edceaee56ac820fe038dc (diff) | |
| download | gdb-56e02e3cda921077c89036f7218ba2d7ff6a1924.tar.gz | |
2010-02-22 Pedro Alves <pedro@codesourcery.com>
PR9605
gdb/
* breakpoint.c (insert_bp_location): If inserting the read
watchpoint failed, fallback to an access watchpoint.
(bpstat_check_watchpoint): Stop for read watchpoint triggers even
if the value changed, if not watching the same memory for writes.
(watchpoint_locations_match): Add comment.
(update_global_location_list): Copy the location's watchpoint type.
* i386-nat.c (i386_length_and_rw_bits): It's an internal error to
handle read watchpoints here.
(i386_insert_watchpoint): Read watchpoints aren't supported.
* remote.c (remote_insert_watchpoint): Return 1 for unsupported
packets.
* target.h (target_insert_watchpoint): Update description.
2010-02-22 Pedro Alves <pedro@codesourcery.com>
PR9605
gdbserver/
* i386-low.c (i386_length_and_rw_bits): Throw a fatal error if
handing a read watchpoint.
(i386_low_insert_watchpoint): Read watchpoints aren't supported.
2010-02-22 Pedro Alves <pedro@codesourcery.com>
PR9605
gdb/testsuite/
* gdb.base/watch-read.c, gdb.base/watch-read.exp: New files.
Diffstat (limited to 'gdb/target.h')
| -rw-r--r-- | gdb/target.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/gdb/target.h b/gdb/target.h index 7103ab26eee..7fd9badacaf 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -1264,9 +1264,10 @@ extern char *normal_pid_to_str (ptid_t ptid); (*current_target.to_region_ok_for_hw_watchpoint) (addr, len) -/* Set/clear a hardware watchpoint starting at ADDR, for LEN bytes. TYPE is 0 - for write, 1 for read, and 2 for read/write accesses. Returns 0 for - success, non-zero for failure. */ +/* Set/clear a hardware watchpoint starting at ADDR, for LEN bytes. + TYPE is 0 for write, 1 for read, and 2 for read/write accesses. + Returns 0 for success, 1 if the watchpoint type is not supported, + -1 for failure. */ #define target_insert_watchpoint(addr, len, type) \ (*current_target.to_insert_watchpoint) (addr, len, type) |