summaryrefslogtreecommitdiff
path: root/gdb/tui
diff options
context:
space:
mode:
authorTom Tromey <tromey@redhat.com>2012-02-02 16:22:08 +0000
committerTom Tromey <tromey@redhat.com>2012-02-02 16:22:08 +0000
commit657b3acdbfd462b48550230b33f8ad0d472acd18 (patch)
tree75dc28a0d338211375de5beb300ccb934dd4f0fb /gdb/tui
parentcf85e18bb52b093ec781c6042f227082c136f611 (diff)
downloadgdb-657b3acdbfd462b48550230b33f8ad0d472acd18.tar.gz
PR gdb/13405:
* tui/tui-win.c (parse_scrolling_args): Don't write to possibly read-only memory.
Diffstat (limited to 'gdb/tui')
-rw-r--r--gdb/tui/tui-win.c11
1 files changed, 7 insertions, 4 deletions
diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c
index a555145abbe..b48bf3ef59f 100644
--- a/gdb/tui/tui-win.c
+++ b/gdb/tui/tui-win.c
@@ -1583,13 +1583,16 @@ parse_scrolling_args (char *arg,
;
if (*buf_ptr != (char) 0)
- wname = buf_ptr;
+ {
+ wname = buf_ptr;
+
+ /* Validate the window name. */
+ for (i = 0; i < strlen (wname); i++)
+ wname[i] = toupper (wname[i]);
+ }
else
wname = "?";
- /* Validate the window name. */
- for (i = 0; i < strlen (wname); i++)
- wname[i] = toupper (wname[i]);
*win_to_scroll = tui_partial_win_by_name (wname);
if (*win_to_scroll == (struct tui_win_info *) NULL