diff options
author | Tom Tromey <tromey@redhat.com> | 2013-05-06 19:46:15 +0000 |
---|---|---|
committer | Tom Tromey <tromey@redhat.com> | 2013-05-06 19:46:15 +0000 |
commit | 8ef0b952c0422658fb407917888d4c98fa55117f (patch) | |
tree | 731f88a382a678de0da6ffd433ab80d58eceebf3 /gdb/value.c | |
parent | faa73d425d03b16dcbb3d7135872558c1852dd45 (diff) | |
download | gdb-8ef0b952c0422658fb407917888d4c98fa55117f.tar.gz |
* ada-lang.c (ada_value_primitive_packed_val): Don't
call value_incref.
* value.c (set_value_parent): Incref the new parent and decref
the old parent.
(value_copy, value_primitive_field): Use set_value_parent.
Diffstat (limited to 'gdb/value.c')
-rw-r--r-- | gdb/value.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/gdb/value.c b/gdb/value.c index 90bc41535d8..ee3c9983036 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -811,7 +811,12 @@ value_parent (struct value *value) void set_value_parent (struct value *value, struct value *parent) { + struct value *old = value->parent; + value->parent = parent; + if (parent != NULL) + value_incref (parent); + value_free (old); } gdb_byte * @@ -1398,9 +1403,7 @@ value_copy (struct value *arg) } val->unavailable = VEC_copy (range_s, arg->unavailable); - val->parent = arg->parent; - if (val->parent) - value_incref (val->parent); + set_value_parent (val, arg->parent); if (VALUE_LVAL (val) == lval_computed) { const struct lval_funcs *funcs = val->location.computed.funcs; @@ -2652,8 +2655,7 @@ value_primitive_field (struct value *arg1, int offset, v->offset = (value_embedded_offset (arg1) + offset + (bitpos - v->bitpos) / 8); - v->parent = arg1; - value_incref (v->parent); + set_value_parent (v, arg1); if (!value_lazy (arg1)) value_fetch_lazy (v); } |