summaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorMichael Snyder <msnyder@specifix.com>2011-03-01 02:16:55 +0000
committerMichael Snyder <msnyder@specifix.com>2011-03-01 02:16:55 +0000
commit2df9e44b5cbf60749dc200a3fd08c198602b84f0 (patch)
tree4b9e2ad83e0e46a57af831749dd132982cf81889 /gdb
parent0bf07cb790909a1eac146b28c7533aeeb389a64f (diff)
downloadgdb-2df9e44b5cbf60749dc200a3fd08c198602b84f0.tar.gz
2011-02-28 Michael Snyder <msnyder@vmware.com>
* breakpoint.c (breakpoint_adjustment_warning): Make local char buffers a little bigger, to avoid possibility of an overflow.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/ChangeLog3
-rw-r--r--gdb/breakpoint.c6
2 files changed, 7 insertions, 2 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 557f89f1ff1..8fcf424b159 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,8 @@
2011-02-28 Michael Snyder <msnyder@vmware.com>
+ * breakpoint.c (breakpoint_adjustment_warning): Make local char
+ buffers a little bigger, to avoid possibility of an overflow.
+
* coffread.c (coff_getfilename): Add check to avoid overflow.
* objc-lang.c (selectors_info): Add a small safety margin to
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index bb9927c408a..3fb8aab5fb0 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -5504,8 +5504,10 @@ static void
breakpoint_adjustment_warning (CORE_ADDR from_addr, CORE_ADDR to_addr,
int bnum, int have_bnum)
{
- char astr1[40];
- char astr2[40];
+ /* The longest string possibly returned by hex_string_custom
+ is 50 chars. These must be at least that big for safety. */
+ char astr1[64];
+ char astr2[64];
strcpy (astr1, hex_string_custom ((unsigned long) from_addr, 8));
strcpy (astr2, hex_string_custom ((unsigned long) to_addr, 8));