diff options
author | Havoc Pennington <hp@redhat.com> | 2001-11-28 20:42:15 +0000 |
---|---|---|
committer | Havoc Pennington <hp@src.gnome.org> | 2001-11-28 20:42:15 +0000 |
commit | 53da925c9b8776194283fdcb7d751283e73b5f7a (patch) | |
tree | 981b89399635ed444a8ef57142b4ad57ce0b89a2 | |
parent | 931fe180ff56b5faeb22e6e3f9f7bd6b95660b47 (diff) | |
download | gdk-pixbuf-53da925c9b8776194283fdcb7d751283e73b5f7a.tar.gz |
put the warning explaining the validation error in front of the
2001-11-28 Havoc Pennington <hp@redhat.com>
* gtk/gtktextview.c (gtk_text_view_paint): put the warning
explaining the validation error in front of the G_BREAKPOINT
* gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
process updates with include_children = FALSE instead of TRUE, so
we redraw the range only, not the whole darn window. Making
GtkRange a NO_WINDOW widget had weirdly caused the text widget
Trace/breakpoint trap bug to become much easier to trigger.
-rw-r--r-- | ChangeLog | 11 | ||||
-rw-r--r-- | ChangeLog.pre-2-0 | 11 | ||||
-rw-r--r-- | ChangeLog.pre-2-10 | 11 | ||||
-rw-r--r-- | ChangeLog.pre-2-2 | 11 | ||||
-rw-r--r-- | ChangeLog.pre-2-4 | 11 | ||||
-rw-r--r-- | ChangeLog.pre-2-6 | 11 | ||||
-rw-r--r-- | ChangeLog.pre-2-8 | 11 | ||||
-rw-r--r-- | gtk/gtkrange.c | 2 | ||||
-rw-r--r-- | gtk/gtktextview.c | 2 |
9 files changed, 79 insertions, 2 deletions
@@ -1,3 +1,14 @@ +2001-11-28 Havoc Pennington <hp@redhat.com> + + * gtk/gtktextview.c (gtk_text_view_paint): put the warning + explaining the validation error in front of the G_BREAKPOINT + + * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call + process updates with include_children = FALSE instead of TRUE, so + we redraw the range only, not the whole darn window. Making + GtkRange a NO_WINDOW widget had weirdly caused the text widget + Trace/breakpoint trap bug to become much easier to trigger. + Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> * gdk/Makefile.am (gdk_public_h_sources): Remove reference diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0 index 3e7d52b1c..d78968dc6 100644 --- a/ChangeLog.pre-2-0 +++ b/ChangeLog.pre-2-0 @@ -1,3 +1,14 @@ +2001-11-28 Havoc Pennington <hp@redhat.com> + + * gtk/gtktextview.c (gtk_text_view_paint): put the warning + explaining the validation error in front of the G_BREAKPOINT + + * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call + process updates with include_children = FALSE instead of TRUE, so + we redraw the range only, not the whole darn window. Making + GtkRange a NO_WINDOW widget had weirdly caused the text widget + Trace/breakpoint trap bug to become much easier to trigger. + Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> * gdk/Makefile.am (gdk_public_h_sources): Remove reference diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 3e7d52b1c..d78968dc6 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,14 @@ +2001-11-28 Havoc Pennington <hp@redhat.com> + + * gtk/gtktextview.c (gtk_text_view_paint): put the warning + explaining the validation error in front of the G_BREAKPOINT + + * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call + process updates with include_children = FALSE instead of TRUE, so + we redraw the range only, not the whole darn window. Making + GtkRange a NO_WINDOW widget had weirdly caused the text widget + Trace/breakpoint trap bug to become much easier to trigger. + Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> * gdk/Makefile.am (gdk_public_h_sources): Remove reference diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2 index 3e7d52b1c..d78968dc6 100644 --- a/ChangeLog.pre-2-2 +++ b/ChangeLog.pre-2-2 @@ -1,3 +1,14 @@ +2001-11-28 Havoc Pennington <hp@redhat.com> + + * gtk/gtktextview.c (gtk_text_view_paint): put the warning + explaining the validation error in front of the G_BREAKPOINT + + * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call + process updates with include_children = FALSE instead of TRUE, so + we redraw the range only, not the whole darn window. Making + GtkRange a NO_WINDOW widget had weirdly caused the text widget + Trace/breakpoint trap bug to become much easier to trigger. + Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> * gdk/Makefile.am (gdk_public_h_sources): Remove reference diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4 index 3e7d52b1c..d78968dc6 100644 --- a/ChangeLog.pre-2-4 +++ b/ChangeLog.pre-2-4 @@ -1,3 +1,14 @@ +2001-11-28 Havoc Pennington <hp@redhat.com> + + * gtk/gtktextview.c (gtk_text_view_paint): put the warning + explaining the validation error in front of the G_BREAKPOINT + + * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call + process updates with include_children = FALSE instead of TRUE, so + we redraw the range only, not the whole darn window. Making + GtkRange a NO_WINDOW widget had weirdly caused the text widget + Trace/breakpoint trap bug to become much easier to trigger. + Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> * gdk/Makefile.am (gdk_public_h_sources): Remove reference diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index 3e7d52b1c..d78968dc6 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,3 +1,14 @@ +2001-11-28 Havoc Pennington <hp@redhat.com> + + * gtk/gtktextview.c (gtk_text_view_paint): put the warning + explaining the validation error in front of the G_BREAKPOINT + + * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call + process updates with include_children = FALSE instead of TRUE, so + we redraw the range only, not the whole darn window. Making + GtkRange a NO_WINDOW widget had weirdly caused the text widget + Trace/breakpoint trap bug to become much easier to trigger. + Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> * gdk/Makefile.am (gdk_public_h_sources): Remove reference diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index 3e7d52b1c..d78968dc6 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,3 +1,14 @@ +2001-11-28 Havoc Pennington <hp@redhat.com> + + * gtk/gtktextview.c (gtk_text_view_paint): put the warning + explaining the validation error in front of the G_BREAKPOINT + + * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call + process updates with include_children = FALSE instead of TRUE, so + we redraw the range only, not the whole darn window. Making + GtkRange a NO_WINDOW widget had weirdly caused the text widget + Trace/breakpoint trap bug to become much easier to trigger. + Wed Nov 28 14:12:03 2001 Owen Taylor <otaylor@redhat.com> * gdk/Makefile.am (gdk_public_h_sources): Remove reference diff --git a/gtk/gtkrange.c b/gtk/gtkrange.c index 06a261a07..d2ead16d1 100644 --- a/gtk/gtkrange.c +++ b/gtk/gtkrange.c @@ -1446,7 +1446,7 @@ gtk_range_adjustment_value_changed (GtkAdjustment *adjustment, gtk_widget_queue_draw (GTK_WIDGET (range)); /* This is so we don't lag the widget being scrolled. */ if (GTK_WIDGET_REALIZED (range)) - gdk_window_process_updates (GTK_WIDGET (range)->window, TRUE); + gdk_window_process_updates (GTK_WIDGET (range)->window, FALSE); /* Note that we don't round off to range->round_digits here. * that's because it's really broken to change a value diff --git a/gtk/gtktextview.c b/gtk/gtktextview.c index ae03661be..f5595ecee 100644 --- a/gtk/gtktextview.c +++ b/gtk/gtktextview.c @@ -3719,8 +3719,8 @@ gtk_text_view_paint (GtkWidget *widget, if (!text_view->onscreen_validated) { + g_warning (G_STRLOC ": somehow some text lines were modified or scrolling occurred since the last validation of lines on the screen - this is a known bug, no need to report."); G_BREAKPOINT (); - g_warning (G_STRLOC ": somehow some text lines were modified or scrolling occurred since the last validation of lines on the screen"); } #if 0 |