diff options
author | Owen Taylor <otaylor@src.gnome.org> | 2003-06-09 02:12:11 +0000 |
---|---|---|
committer | Owen Taylor <otaylor@src.gnome.org> | 2003-06-09 02:12:11 +0000 |
commit | 6a422f88bc2fb3a579ccd0a1828588ab04288ee7 (patch) | |
tree | 78d7406f795d1686ebb3e6ef4d99abfc5b79875f | |
parent | 995098e65ec2e1f5d19da8c5721e2083bafd06fc (diff) | |
download | gdk-pixbuf-6a422f88bc2fb3a579ccd0a1828588ab04288ee7.tar.gz |
NULL out private->parent, since after destruction it might not be valid
* gdk/gdkwindow.c (_gdk_window_destroy_hierarchy):
NULL out private->parent, since after destruction
it might not be valid any more.
* gdk/gdkwindow.c (gdk_window_is_viewable): Fix some
accesses before g_return_val_if_fail(). Treat
DESTROYED windows as unmapped.
-rw-r--r-- | gdk/gdkwindow.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/gdk/gdkwindow.c b/gdk/gdkwindow.c index 2534ad86d..21310ceb2 100644 --- a/gdk/gdkwindow.c +++ b/gdk/gdkwindow.c @@ -354,6 +354,7 @@ _gdk_window_destroy_hierarchy (GdkWindow *window, } _gdk_windowing_window_destroy (window, recursing, foreign_destroy); + private->parent = NULL; private->destroyed = TRUE; if (private->filters) @@ -780,17 +781,20 @@ gboolean gdk_window_is_viewable (GdkWindow *window) { GdkWindowObject *private = (GdkWindowObject *)window; - GdkScreen *screen = gdk_drawable_get_screen (window); - GdkWindow *root_window = gdk_screen_get_root_window (screen); + GdkScreen *screen; + GdkWindow *root_window; g_return_val_if_fail (window != NULL, FALSE); g_return_val_if_fail (GDK_IS_WINDOW (window), FALSE); + + screen = gdk_drawable_get_screen (window); + root_window = gdk_screen_get_root_window (screen); while (private && (private != (GdkWindowObject *)root_window) && (GDK_WINDOW_TYPE (private) != GDK_WINDOW_FOREIGN)) { - if (!GDK_WINDOW_IS_MAPPED (window)) + if (GDK_WINDOW_DESTROYED (window) || !GDK_WINDOW_IS_MAPPED (window)) return FALSE; private = (GdkWindowObject *)private->parent; |