diff options
author | Ray Strode <rstrode@redhat.com> | 2012-07-06 14:48:37 -0400 |
---|---|---|
committer | Ray Strode <rstrode@redhat.com> | 2012-07-06 15:29:42 -0400 |
commit | c8bffea9ec259e018aa61be9b9900e777013d87c (patch) | |
tree | 96902a4edcc32d4f3b381fd75b6d30d98362342e /daemon/gdm-local-display-factory.c | |
parent | 84c9c43416ba09207d23d9191f94c131c6a31ca5 (diff) | |
download | gdm-c8bffea9ec259e018aa61be9b9900e777013d87c.tar.gz |
daemon: clean house (drop factory mode)
GDM has a currently unused feature called "factory mode", where
the login screen gets allocated its own VT and any subsequent logins
from that login screen go to their own VT. Any time there's a user
switch GDM just jumps back to initial VT where the login screen is
patiently waiting.
This feature has a lot of upsides, and we've had it as a TODO item to
start using it for while now.
It doesn't look it's going to happen in the near term, though, and
factory mode has downsides as well:
- a VT switch after the user hits enter at the login screen would be
jarring and would ruin the "flicker free" boot experience we've tried
to acheive at various points in the past. This could theoretically be
fixed by Wayland.
- it adds a bunch of untested, unused code to the codebase.
This latter reason makes me want to kill it for now. It shouldn't be
hard to resurrect later if we end up needing the feature.
This commit drops that code.
Diffstat (limited to 'daemon/gdm-local-display-factory.c')
-rw-r--r-- | daemon/gdm-local-display-factory.c | 49 |
1 files changed, 0 insertions, 49 deletions
diff --git a/daemon/gdm-local-display-factory.c b/daemon/gdm-local-display-factory.c index cb69a88b..9d823eb8 100644 --- a/daemon/gdm-local-display-factory.c +++ b/daemon/gdm-local-display-factory.c @@ -41,7 +41,6 @@ #include "gdm-display-store.h" #include "gdm-static-display.h" #include "gdm-transient-display.h" -#include "gdm-product-display.h" #define GDM_LOCAL_DISPLAY_FACTORY_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE ((o), GDM_TYPE_LOCAL_DISPLAY_FACTORY, GdmLocalDisplayFactoryPrivate)) @@ -252,54 +251,6 @@ gdm_local_display_factory_create_transient_display (GdmLocalDisplayFactory *fact return ret; } -gboolean -gdm_local_display_factory_create_product_display (GdmLocalDisplayFactory *factory, - const char *parent_display_id, - const char *relay_address, - char **id, - GError **error) -{ - gboolean ret; - GdmDisplay *display; - guint32 num; - const char *seat_id; - - g_return_val_if_fail (GDM_IS_LOCAL_DISPLAY_FACTORY (factory), FALSE); - - ret = FALSE; - - g_debug ("GdmLocalDisplayFactory: Creating product display parent %s address:%s", - parent_display_id, relay_address); - - num = take_next_display_number (factory); - - g_debug ("GdmLocalDisplayFactory: got display num %u", num); - - display = gdm_product_display_new (num, relay_address); - - seat_id = get_seat_of_transient_display (factory); - g_object_set (display, "seat-id", seat_id, NULL); - - store_display (factory, num, display); - - if (! gdm_display_manage (display)) { - display = NULL; - goto out; - } - - if (! gdm_display_get_id (display, id, NULL)) { - display = NULL; - goto out; - } - - ret = TRUE; - out: - /* ref either held by store or not at all */ - g_object_unref (display); - - return ret; -} - static void on_static_display_status_changed (GdmDisplay *display, GParamSpec *arg1, |