summaryrefslogtreecommitdiff
path: root/daemon/session-worker-main.c
diff options
context:
space:
mode:
authorColin Walters <walters@verbum.org>2012-12-03 13:24:07 -0500
committerRay Strode <rstrode@redhat.com>2013-01-22 11:56:26 -0500
commit59d705966a50fe796b5ba7414697aa503476a7ec (patch)
treeb640d55cd66ebc65c51031c8c3e8f6a378894603 /daemon/session-worker-main.c
parent305df4a7b0f2dcf92024478ead7e37295b61c07e (diff)
downloadgdm-59d705966a50fe796b5ba7414697aa503476a7ec.tar.gz
Remove handling of SIGSEGV/SIGFPE/SIGILL etc.
Modern operating systems have "crash catching" functionality; for example, systemd comes with "systemd-coredump" which collects cores automatically. Attempting to handle these kinds of fatal signals internally is now much worse, because the original source of the problem will be masked. systemd won't collect a core file that would include a backtrace, for example. Also, with these removed, we can move forward porting to g_unix_signal_add(). https://bugzilla.gnome.org/show_bug.cgi?id=676181
Diffstat (limited to 'daemon/session-worker-main.c')
-rw-r--r--daemon/session-worker-main.c22
1 files changed, 0 insertions, 22 deletions
diff --git a/daemon/session-worker-main.c b/daemon/session-worker-main.c
index e6b6dd0c..57027cf3 100644
--- a/daemon/session-worker-main.c
+++ b/daemon/session-worker-main.c
@@ -57,23 +57,6 @@ signal_cb (int signo,
ret = TRUE;
switch (signo) {
- case SIGSEGV:
- case SIGBUS:
- case SIGILL:
- case SIGABRT:
- g_debug ("Caught signal %d.", signo);
-
- ret = FALSE;
- break;
-
- case SIGFPE:
- case SIGPIPE:
- /* let the fatal signals interrupt us */
- g_debug ("Caught signal %d, shutting down abnormally.", signo);
- ret = FALSE;
-
- break;
-
case SIGINT:
case SIGTERM:
/* let the fatal signals interrupt us */
@@ -183,12 +166,7 @@ main (int argc,
(GDestroyNotify)g_main_loop_quit,
main_loop);
gdm_signal_handler_add (signal_handler, SIGINT, signal_cb, NULL);
- gdm_signal_handler_add (signal_handler, SIGILL, signal_cb, NULL);
- gdm_signal_handler_add (signal_handler, SIGBUS, signal_cb, NULL);
- gdm_signal_handler_add (signal_handler, SIGFPE, signal_cb, NULL);
gdm_signal_handler_add (signal_handler, SIGHUP, signal_cb, NULL);
- gdm_signal_handler_add (signal_handler, SIGSEGV, signal_cb, NULL);
- gdm_signal_handler_add (signal_handler, SIGABRT, signal_cb, NULL);
gdm_signal_handler_add (signal_handler, SIGUSR1, signal_cb, NULL);
g_main_loop_run (main_loop);