summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonatan Pålsson <jonatan.palsson@pelagicore.com>2014-04-08 14:01:47 +0200
committerJonatan Pålsson <jonatan.palsson@pelagicore.com>2014-04-08 14:32:13 +0200
commite4c9e95f3b241dc113b790add029f6ab87b2320b (patch)
tree84f6fb853cebf71e89e7b59a1835e6dc7ea38a2b
parent5debdbc871becebc8b0fcd7bea96d3973eb354b8 (diff)
downloadbrowser-poc-e4c9e95f3b241dc113b790add029f6ab87b2320b.tar.gz
Fixed duplication in select lists
-rw-r--r--browser/browserview.h18
1 files changed, 10 insertions, 8 deletions
diff --git a/browser/browserview.h b/browser/browserview.h
index 0ec7765..0cff39d 100644
--- a/browser/browserview.h
+++ b/browser/browserview.h
@@ -65,18 +65,20 @@ public slots:
void handleSelectElement(const QWebElement &elem) {
conn::brw::SelectableOptionList options;
- QList<QWebElement> elems;
QWebElement first = elem.firstChild();
QWebElement last = elem.lastChild();
+ QWebElement iter = first;
- conn::brw::SelectableOption o;
- o.strValue = first.toPlainText();
- options.append(o);
- elems.append(first);
- while (elems.last() != last) {
+ while (iter != last) {
conn::brw::SelectableOption o;
- o.strValue = elems.last().toPlainText();
- elems.append(elems.last().nextSibling());
+ o.strValue = iter.toPlainText();
+ options.append(o);
+ iter = iter.nextSibling();
+ }
+
+ if (iter == last) {
+ conn::brw::SelectableOption o;
+ o.strValue = iter.toPlainText();
options.append(o);
}