Make sure to not cast user_data to GObjects in callback if call is canceled

This can abort at runtime if the object pointed to by user_data is already
gone by the time the callback is run.

1 files changed, 6 insertions, 5 deletions

diff --git a/src/gclue-modem-gps.c b/src/gclue-modem-gps.c
index c258eda..fba6bcb 100644
--- a/src/gclue-modem-gps.c
+++ b/src/gclue-modem-gps.c
@@ -80,14 +80,15 @@ on_gps_enabled (GObject      *source_object,
                 GAsyncResult *result,
                 gpointer      user_data)
 {
-        GClueModemGPS *source = GCLUE_MODEM_GPS (user_data);
-        GError *error = NULL;
+        g_autoptr(GError) error = NULL;
 
-        if (!gclue_modem_enable_gps_finish (source->priv->modem,
+        if (!gclue_modem_enable_gps_finish (GCLUE_MODEM (source_object),
                                             result,
                                             &error)) {
-                g_warning ("Failed to enable GPS: %s", error->message);
-                g_error_free (error);
+                if (error && !g_error_matches (error, G_IO_ERROR,
+                                               G_IO_ERROR_CANCELLED)) {
+                        g_warning ("Failed to enable GPS: %s", error->message);
+                }
         }
 }