summaryrefslogtreecommitdiff
path: root/contrib
diff options
context:
space:
mode:
authorJulian Smith <jules@op59.net>2020-01-08 13:08:07 +0000
committerJulian Smith <jules@op59.net>2020-01-08 16:10:17 +0000
commitaba372d8efa1ffdb11a496474f519b0015b31031 (patch)
tree2f82078cf61be253513491b3f72a9a7c9f07981a /contrib
parent5e1685812864cfde94a5c0daee0cae3307078aa7 (diff)
downloadghostpdl-aba372d8efa1ffdb11a496474f519b0015b31031.tar.gz
Coverity 94665: removed unnecessary if and refactored expression.
Diffstat (limited to 'contrib')
-rw-r--r--contrib/gdevdj9.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/contrib/gdevdj9.c b/contrib/gdevdj9.c
index af0ef5be4..1800b3cb8 100644
--- a/contrib/gdevdj9.c
+++ b/contrib/gdevdj9.c
@@ -633,9 +633,10 @@ hp_colour_open(gx_device * pdev)
static int
cdj970_get_params(gx_device * pdev, gs_param_list * plist)
{
- int code = gdev_prn_get_params(pdev, plist);
-
- if (code < 0 ||
+ int code;
+
+ (void) (
+ (code = gdev_prn_get_params(pdev, plist)) < 0 ||
(code = param_write_int(plist, "Quality", &cdj970->quality)) < 0 ||
(code = param_write_int(plist, "Duplex", &cdj970->duplex)) < 0 ||
(code = param_write_int(plist, "Papertype", &cdj970->papertype)) < 0
@@ -652,9 +653,8 @@ cdj970_get_params(gx_device * pdev, gs_param_list * plist)
param_write_float(plist, "GammaValK", &cdj970->gammavalk)) < 0
|| (code =
param_write_float(plist, "BlackCorrect",
- &cdj970->blackcorrect)) < 0)
-
- return (code);
+ &cdj970->blackcorrect)) < 0
+ );
return (code);
}