diff options
| author | Chris Liddell <chris.liddell@artifex.com> | 2021-08-13 09:21:27 +0100 |
|---|---|---|
| committer | Chris Liddell <chris.liddell@artifex.com> | 2021-08-13 14:53:25 +0100 |
| commit | a1a95200be4e734cfc5bae0f43e6ee0bcc9e4fa3 (patch) | |
| tree | e7f41f89f575ee15c8ccb7e46b3f1fc474acea0c /pdf/pdf_fontps.c | |
| parent | 7793eb88709ce7ab3be1ae56e8d18cc56828f0de (diff) | |
| download | ghostpdl-a1a95200be4e734cfc5bae0f43e6ee0bcc9e4fa3.tar.gz | |
CID 372333: Pay closer attention to error codes.
The code was (intentionally) carrying on despite an error occuring, which
meant coverity complained about "overwriting previous value".
In retrospect, there is no point carrying on, in this case, so just break out
of the loop on error. Hopefully, keeping coverity happy.
Diffstat (limited to 'pdf/pdf_fontps.c')
| -rw-r--r-- | pdf/pdf_fontps.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/pdf/pdf_fontps.c b/pdf/pdf_fontps.c index db9b1713b..7ee9d2f09 100644 --- a/pdf/pdf_fontps.c +++ b/pdf/pdf_fontps.c @@ -496,16 +496,18 @@ ps_font_def_func(gs_memory_t *mem, pdf_ps_ctx_t *s, byte *buf, byte *bufend) else { code = pdfi_object_alloc(s->pdfi_ctx, PDF_INT, 0, (pdf_obj **)&n); if (code >= 0) - n->value.d = 0; + n->value.i = 0; } if (code < 0) - continue; + break; pdfi_countup(n); code = pdfi_array_put(s->pdfi_ctx, parr, j, (pdf_obj *)n); pdfi_countdown(n); + if (code < 0) break; } } - code = pdfi_array_put(s->pdfi_ctx, priv->u.t1.blendfontbbox, i, (pdf_obj *)parr); + if (code >= 0) + code = pdfi_array_put(s->pdfi_ctx, priv->u.t1.blendfontbbox, i, (pdf_obj *)parr); pdfi_countdown(parr); } } |