diff options
| author | Robin Watts <Robin.Watts@artifex.com> | 2019-01-16 05:12:54 -0800 |
|---|---|---|
| committer | Robin Watts <robin.watts@artifex.com> | 2019-01-16 13:20:09 +0000 |
| commit | 03a1e5eaf83896053fa32f68d328ff48f86d906f (patch) | |
| tree | 596a6468c1e75e6329d450a9e09dcf22a2cd0ca3 /psi/imain.c | |
| parent | b5ecd380a5af595f5e843352df88a6957b1accda (diff) | |
| download | ghostpdl-03a1e5eaf83896053fa32f68d328ff48f86d906f.tar.gz | |
Valgrind fixes.
Firstly, move entirely to HAVE_VALGRIND rather than ENABLE_VALGRIND.
My fault for having introduced 2 schemes to do the same thing in
the past.
Accordingly, move direct inclusions of memcheck/valgrind.h over to
calling our local valgrind.h header.
And finally, fix the problem that prompted all of this; in
image_simple_expand, we take 1 bit data in. The last bytes in this
data can frequently be only semi-filled, resulting in some
undefined bits. While our code to quickly skip complete bytes is
safe by construction, valgrind cannot recognise it as such, and so
signals false positive UMRs.
Work around that here by tweaking valgrinds ideas of what bits
are defined.
Diffstat (limited to 'psi/imain.c')
| -rw-r--r-- | psi/imain.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/psi/imain.c b/psi/imain.c index 7da08746a..19e5f4f36 100644 --- a/psi/imain.c +++ b/psi/imain.c @@ -59,9 +59,7 @@ #include "iplugin.h" #include "zfile.h" -#ifdef PACIFY_VALGRIND #include "valgrind.h" -#endif /* ------ Exported data ------ */ |