diff options
| author | Ken Sharp <ken.sharp@artifex.com> | 2016-05-02 09:44:18 +0100 |
|---|---|---|
| committer | Ken Sharp <ken.sharp@artifex.com> | 2016-05-02 09:44:18 +0100 |
| commit | ebdb8acb36a8084089fa7093882a40a4484640fb (patch) | |
| tree | 96bde2963b2b4819cf3ff578d4e0cf96202f84de /psi/zshade.c | |
| parent | c8827f917d2ff40ffeda384fa8df0ceaed2670de (diff) | |
| download | ghostpdl-ebdb8acb36a8084089fa7093882a40a4484640fb.tar.gz | |
Coverity ID 94546 - correct impossible condition
the a_all bit mask does not include the 'a_executable' bit, making the
r_has_masked_attrs() test always return false. We do not have a test
case for this invalid parameter, but I think this is at least an
improvement.
Diffstat (limited to 'psi/zshade.c')
| -rw-r--r-- | psi/zshade.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/psi/zshade.c b/psi/zshade.c index b9088c271..ae910e056 100644 --- a/psi/zshade.c +++ b/psi/zshade.c @@ -129,7 +129,7 @@ shading_param(const_os_ptr op, const gs_shading_t ** ppsh) * no way to check whether a structure is actually a shading. */ if (!r_is_struct(op) || - r_has_masked_attrs(op, a_executable | a_execute, a_all) + r_has_masked_attrs(op, a_execute, a_all) ) return_error(gs_error_typecheck); *ppsh = (gs_shading_t *) op->value.pstruct; |