diff options
| author | Chris Liddell <chris.liddell@artifex.com> | 2017-07-06 14:54:02 +0100 |
|---|---|---|
| committer | Chris Liddell <chris.liddell@artifex.com> | 2017-07-25 09:07:07 +0100 |
| commit | 671fd59eb657743aa86fbc1895cb15872a317caa (patch) | |
| tree | 6dbe92f8487df993d959cc812f9cf6b38aa13fe1 /psi/ztoken.c | |
| parent | 18a2365b69cc43ed4dbe2bfd44f739622623821c (diff) | |
| download | ghostpdl-671fd59eb657743aa86fbc1895cb15872a317caa.tar.gz | |
Bug 698158: prevent trying to reloc a freed object
In the token reader, we pass the scanner state structure around as a
t_struct ref on the Postscript operand stack.
But we explicitly free the scanner state when we're done, which leaves a
dangling reference on the operand stack and, unless that reference gets
overwritten before the next garbager run, we can end up with the garbager
trying to deal with an already freed object - that can cause a crash, or
memory corruption.
Diffstat (limited to 'psi/ztoken.c')
| -rw-r--r-- | psi/ztoken.c | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/psi/ztoken.c b/psi/ztoken.c index 4dba7c5bd..af1ceeb4f 100644 --- a/psi/ztoken.c +++ b/psi/ztoken.c @@ -107,6 +107,12 @@ token_continue(i_ctx_t *i_ctx_p, scanner_state * pstate, bool save) int code; ref token; + /* Since we might free pstate below, and we're dealing with + * gc memory referenced by the stack, we need to explicitly + * remove the reference to pstate from the stack, otherwise + * the garbager will fall over + */ + make_null(osp); /* Note that gs_scan_token may change osp! */ pop(1); /* remove the file or scanner state */ again: @@ -183,8 +189,14 @@ ztokenexec_continue(i_ctx_t *i_ctx_p) static int tokenexec_continue(i_ctx_t *i_ctx_p, scanner_state * pstate, bool save) { - os_ptr op; + os_ptr op = osp; int code; + /* Since we might free pstate below, and we're dealing with + * gc memory referenced by the stack, we need to explicitly + * remove the reference to pstate from the stack, otherwise + * the garbager will fall over + */ + make_null(osp); /* Note that gs_scan_token may change osp! */ pop(1); again: |