diff options
| author | Monty Taylor <mordred@inaugust.com> | 2019-03-18 14:28:21 +0000 |
|---|---|---|
| committer | Monty Taylor <mordred@inaugust.com> | 2019-03-18 14:37:27 +0000 |
| commit | 853f3bffb31efd3e5141b538e99713ee414e0002 (patch) | |
| tree | a006f8d06dbdfb789b3975a397db83952ccc521c /releasenotes/notes | |
| parent | 9b68a44f38390c1c245da09069c2eb13d45bcd53 (diff) | |
| download | git-review-853f3bffb31efd3e5141b538e99713ee414e0002.tar.gz | |
Use remote_url instead of remote for download1.28.0.0a11.28.0
If usepushurl is set, then it's likely that the pushurl is pointing
to the code review system while the normal url is pointing to a read
only mirror. If the read-only mirror in question doesn't contain
the gerrit refs (like opendev.org currently) then git fetch origin
won't work properly. However, we already calculate the correct
URL at the top of the function for use in query_reviews, and fetch
will happily work with a full url rather than a named remote.
Update the function to use the remote_url so that usepushurl works
even if the mirror url does not contain refs/changes.
Change-Id: Ib72afe97e65cb1dcaf95e28450dfe6e7d5f88965
Diffstat (limited to 'releasenotes/notes')
| -rw-r--r-- | releasenotes/notes/fix-usepushurl-c4a234689d808ece.yaml | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/releasenotes/notes/fix-usepushurl-c4a234689d808ece.yaml b/releasenotes/notes/fix-usepushurl-c4a234689d808ece.yaml new file mode 100644 index 0000000..817669b --- /dev/null +++ b/releasenotes/notes/fix-usepushurl-c4a234689d808ece.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + Fixed ``usepushurl`` to work when a read-only mirror being used as + ``origin`` does not contain ``refs/changes`` from gerrit. |