diff options
| author | Ilya Etingof <etingof@gmail.com> | 2017-07-04 18:50:28 +0200 |
|---|---|---|
| committer | Sorin Sbarnea <ssbarnea@redhat.com> | 2018-11-06 12:26:11 +0000 |
| commit | d94e3a3431dc39e255ecedafcfb755f9834298ba (patch) | |
| tree | 7f405e5b8be52e7f6431cccc0a3861e6e18f8160 /releasenotes/notes | |
| parent | af955c932eb97433199781b5d4f7fb5fb5af8a6f (diff) | |
| download | git-review-d94e3a3431dc39e255ecedafcfb755f9834298ba.tar.gz | |
Improve exit code implementation
Unnecessary dynamic GitReviewException.EXIT_CODE attribute
lookup refactored into static to benefit static analyzers.
Default process exit code changed from 127 (command not found error)
to 1 (general error)
Change-Id: I1fcb583a740bf32c4427a587e208d099712a7bc4
Diffstat (limited to 'releasenotes/notes')
| -rw-r--r-- | releasenotes/notes/fix-exit-code-5ab7f6314976319f.yaml | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/releasenotes/notes/fix-exit-code-5ab7f6314976319f.yaml b/releasenotes/notes/fix-exit-code-5ab7f6314976319f.yaml new file mode 100644 index 0000000..73657d6 --- /dev/null +++ b/releasenotes/notes/fix-exit-code-5ab7f6314976319f.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - | + Fixes ``gitreview`` process exit code to align with general + UNIX process exit code conventions. Specifically, default exit + code changed to ``1`` which stands for "general error". |