| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
| |
Change I40356ee81b98c1210de348e51335a20be48bec1d fixed this, but was
missing a release note. Also close the story task with this change
since the other one didn't.
Change-Id: Ia27d930bf0ecefe1c26c00d6a5e93136fd120964
Task: #45100
|
| |
|
|
|
|
|
|
|
|
|
| |
When a commit is signed and the git config contains the setting
log.ShowSignature=True, even the "--oneline" git log output for it will
include multiple lines (the output from gpg verifying the signature),
thus fooling us into assuming that multiple commits are to be submitted.
Override the option to make sure we always get one line per commit only.
Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
Change-Id: Id4528209f1cd500afd06e2e61eb5689022251118
|
| |
|
|
|
|
|
|
|
| |
An upcoming change needs a feature from Git 2.10, which Ubuntu 16.04
LTS lacks. Since Python 3.5 reached end of life with the 3.5.10
release on 2020-09-05, it's been unsupported by its maintainers for
nearly 2 years anyway.
Change-Id: I0369c29baa344c4dc76eaa47b3467b6117eb933c
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
OpenSSH has deprecated its use of scp/rcp protocol in favor of SFTP,
which the embedded Apache mina-sshd in widely-deployed Gerrit
versions does not yet support. The default officially changed in
OpenSSH 9.0 (some distributions, such as Fedora and CentOS, switched
their default behavior to this as early as OpenSSH 8.7 or 8.8),
leading to a ``subsystem request failed on channel 0`` error during
commit-msg hook retrieval. Now git-review will attempt to detect
whether scp's -O option is available to force use of the legacy
scp/rcp protocol, and apply it if so.
Change-Id: Ib64c03c3e12a3a8390e38f6ca9393db3b3c2a9e3
|
| |
|
|
|
|
|
| |
In preparation for a new release, include a release note about an
important fix we added recently.
Change-Id: Icfe0594cc1a4526e0781ac47c0d5f60bbcdce0e3
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
When checking for unstaged or uncommitted changes to avoid the test
rebase (which could cause data loss for users of git.autostash),
it's still fine if there are unstaged or uncommitted changes in
submodules since those won't be rebased. Have the git diff
invocations explicitly ignore submodules, and also add regression
tests which demonstrate it's working.
This fixes a regression originally introduced by change
Iabb8387c9db59a7d02ebfd43b688e7bb93d3159f.
Change-Id: I20d602e86537b573ac1f9788221215047a594f83
|
| |
|
|
|
|
|
|
|
|
| |
Couple of small follow-ups to Id8a3ac464ff75e6d8207f198089f018cc790eca5:
* Fix formatting in the reno (use monospace as applicable).
* Update "Installation and Configuration" to say that the local hook
*normally* goes into .git/hooks.
Change-Id: I1b326bdcaed38d3a82a65f944431f3640652dd33
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, git-review would assume that the Git repository's hook
directory is .git/hooks, relative to the root of the checkout. This
assumption breaks if the user has set the core.hooksPath option on the
repository (or, for that matter, in ~/.gitconfig or /etc/gitconfig).
core.hooksPath can either be set to an absolute path, in which case it
is to be interpreted as-is, or to a relative path, in which case it
should be interpreted as relative to the root of the checkout.
Introduce a new convenience function to suss out the correct path, and
use it in places where the reference to .git/hooks was previously
hard-coded.
Reference:
https: //git-scm.com/docs/git-config#Documentation/git-config.txt-corehooksPath
Depends-on: I0f0f44e57a100420d8e6d2eaec7dbb5d77b654af
Change-Id: Id8a3ac464ff75e6d8207f198089f018cc790eca5
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a long standing issue with C Git pushing to Gerrit and Jgit
where the occasional push will fail because the negotiated packs are
missing a tree object. This happens very occasionally but when it does
it would be nice to be able to point users at an easy workaround.
Pushing with --no-thin is that workaround.
Note that --no-thin is much less efficient so shouldn't be used by
default.
This old bug, https://bugs.launchpad.net/git-review/+bug/1332549, has
details but it seems to affect current C git and Gerrit+Jgit.
Change-Id: Id6ba52a656a14c921acab1b14ef668e6251245da
|
| |
|
|
|
|
|
|
|
| |
In preparation for the 2.0.0 release, move the release notes for
dropping Python 2.7 support and ceasing support for draft changes as
upgrade notes. This will make it a little more obvious that people
who rely on those features may need to hold off upgrading.
Change-Id: I6362ef2e878a855cb34e38487cef35ee3bcec75c
|
| |
|
|
|
|
|
|
|
|
|
| |
For safety, attempts to push a commit with unstaged or uncommitted
changes in the worktree will be caught and an error reported, rather
than leaving it up to ``git rebase`` to spot them. This addresses a
situation where users enabling "rebase.autostash" would otherwise
experience data loss when the test rebase is subsequently reset.
Change-Id: Iabb8387c9db59a7d02ebfd43b688e7bb93d3159f
Task: #38921
|
| |
|
|
|
|
|
|
| |
Many changes merged since the last release lack release notes. Since
we'll want to summarize them for the announcement anyway, we may as
well commit those summaries for posterity.
Change-Id: I56cda54cd9df781004462e95545a192302dd7bd4
|
| |
|
|
|
|
|
| |
This is documented at
<https://gerrit-review.googlesource.com/Documentation/user-upload.html#push_options>.
Change-Id: Ifbc0ec1225052cb804fcf537f5a071cad29e8328
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If usepushurl is set, then it's likely that the pushurl is pointing
to the code review system while the normal url is pointing to a read
only mirror. If the read-only mirror in question doesn't contain
the gerrit refs (like opendev.org currently) then git fetch origin
won't work properly. However, we already calculate the correct
URL at the top of the function for use in query_reviews, and fetch
will happily work with a full url rather than a named remote.
Update the function to use the remote_url so that usepushurl works
even if the mirror url does not contain refs/changes.
Change-Id: Ib72afe97e65cb1dcaf95e28450dfe6e7d5f88965
|
| |
|
|
|
|
|
|
|
|
| |
Unnecessary dynamic GitReviewException.EXIT_CODE attribute
lookup refactored into static to benefit static analyzers.
Default process exit code changed from 127 (command not found error)
to 1 (general error)
Change-Id: I1fcb583a740bf32c4427a587e208d099712a7bc4
|
| |
|
|
|
| |
Change-Id: I8f8880791ad7e46fb9e18623ab8bd295457424b2
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The feature to configure branch names based on the presence of "bug",
"lp", "blueprint" or "bp" in the commit message is overly elaborate and
very OpenStack specific. Even with this, it hasn't been updated to keep
up with the times as many projects have migrated to Storyboard, which
isn't handled here.
Given that it frequently does the wrong thing and likely doesn't apply
to anyone outside of the OpenStack ecosystem, the wisest thing it to
simply remove the feature. This is a break in behavior but it seems
better than adding yet another flag for something that many users will
want enabled by default.
Change-Id: I82ecc1719de5c87d59bbfe73a042917e6559da1e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Story: 1130330
Task: 566
Story: 2001247
Task: 5777
|
|
|
It's probably a good idea to be specific about what's changing in reno
releases.
Since reno support wasn't in tree we didn't pick up notes for these two
changes, but they're things users might want to know about.
Change-Id: I249a3a4d0cf378b60bf43ce65d49416879d5517e
|
