diff options
| author | Doug Kelly <dougk.ff7@gmail.com> | 2015-11-03 21:05:08 -0600 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2015-11-04 11:30:22 -0800 |
| commit | 478f34d2b6ea13d5f56ecec04de7ca7ce18367c0 (patch) | |
| tree | c42c51cc370555bc4fe5d978e6a9a3072182c16f | |
| parent | e6d65c9a47a0f245614d34246fe28782a6d2209b (diff) | |
| download | git-dk/gc-idx-wo-pack.tar.gz | |
gc: remove garbage .idx files from pack dirdk/gc-idx-wo-pack
Add a custom report_garbage handler to collect and remove
garbage .idx files from the pack directory.
Signed-off-by: Doug Kelly <dougk.ff7@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/gc.c | 21 | ||||
| -rwxr-xr-x | t/t5304-prune.sh | 2 |
2 files changed, 22 insertions, 1 deletions
diff --git a/builtin/gc.c b/builtin/gc.c index 4957c39032..203265db76 100644 --- a/builtin/gc.c +++ b/builtin/gc.c @@ -57,6 +57,22 @@ static void remove_pidfile_on_signal(int signo) raise(signo); } +static struct string_list pack_garbage = STRING_LIST_INIT_DUP; + +static void clean_pack_garbage(void) +{ + int i; + for (i = 0; i < pack_garbage.nr; i++) + unlink_or_warn(pack_garbage.items[i].string); + string_list_clear(&pack_garbage, 0); +} + +static void report_pack_garbage(unsigned seen_bits, const char *path) +{ + if (seen_bits == PACKDIR_FILE_IDX) + string_list_append(&pack_garbage, path); +} + static void git_config_date_string(const char *key, const char **output) { if (git_config_get_string_const(key, output)) @@ -372,6 +388,11 @@ int cmd_gc(int argc, const char **argv, const char *prefix) if (run_command_v_opt(rerere.argv, RUN_GIT_CMD)) return error(FAILED_RUN, rerere.argv[0]); + report_garbage = report_pack_garbage; + reprepare_packed_git(); + if (pack_garbage.nr > 0) + clean_pack_garbage(); + if (auto_gc && too_many_loose_objects()) warning(_("There are too many unreachable loose objects; " "run 'git prune' to remove them.")); diff --git a/t/t5304-prune.sh b/t/t5304-prune.sh index 029751544f..def203c724 100755 --- a/t/t5304-prune.sh +++ b/t/t5304-prune.sh @@ -245,7 +245,7 @@ EOF test_cmp expected actual ' -test_expect_failure 'clean pack garbage with gc' ' +test_expect_success 'clean pack garbage with gc' ' test_when_finished "rm -f .git/objects/pack/fake*" && test_when_finished "rm -f .git/objects/pack/foo*" && : >.git/objects/pack/foo.keep && |