diff options
| author | Elia Pinto <gitter.spiros@gmail.com> | 2016-01-12 11:49:38 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-01-12 11:49:49 -0800 |
| commit | ec1b763d05bb03d8741c1363d7acf4ccb7153f6d (patch) | |
| tree | 7bffd5ccb8deee748d07f7f66282bf3dba33cc60 | |
| parent | 9c1037751c0204c494b1ed49e8c1d94429ea78b1 (diff) | |
| download | git-ep/shell-command-substitution-style.tar.gz | |
t9901-git-web--browse.sh: use the $( ... ) construct for command substitutionep/shell-command-substitution-style
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t9901-git-web--browse.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t9901-git-web--browse.sh b/t/t9901-git-web--browse.sh index b0a6bad8dd..de7152f827 100755 --- a/t/t9901-git-web--browse.sh +++ b/t/t9901-git-web--browse.sh @@ -43,7 +43,7 @@ test_expect_success \ echo fake: "$@" EOF chmod +x "fake browser" && - git config browser.w3m.path "`pwd`/fake browser" && + git config browser.w3m.path "$(pwd)/fake browser" && test_web_browse w3m http://example.com/foo ' |