diff options
| author | Jon Griffiths <jon_p_griffiths@yahoo.com> | 2016-02-23 02:16:04 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-02-23 14:48:03 -0800 |
| commit | 6e6144905188a76ef75c5418bd48c333adeebdcd (patch) | |
| tree | 23bb7809cc65e736afad1c98ec857df3b041905f | |
| parent | bd93b8d9becb01d21871b63e34c2e824c60b1e8c (diff) | |
| download | git-jg/credential-cache-chdir-to-sockdir.tar.gz | |
credential-cache--daemon: change to the socket dir on startupjg/credential-cache-chdir-to-sockdir
Changing to the socket path stops the daemon holding open
the directory the user was in when it was started,
preventing umount from working. We're already holding open a
socket in that directory, so there's no downside.
Thanks-to: Jeff King <peff@peff.net>
Signed-off-by: Jon Griffiths <jon_p_griffiths@yahoo.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | credential-cache--daemon.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/credential-cache--daemon.c b/credential-cache--daemon.c index fe3779472c..6b00ee0ee6 100644 --- a/credential-cache--daemon.c +++ b/credential-cache--daemon.c @@ -236,6 +236,15 @@ static void init_socket_directory(const char *path) if (mkdir(dir, 0700) < 0) die_errno("unable to mkdir '%s'", dir); } + + if (chdir(dir)) + /* + * We don't actually care what our cwd is; we chdir here just to + * be a friendly daemon and avoid tying up our original cwd. + * If this fails, it's OK to just continue without that benefit. + */ + ; + free(path_copy); } |