diff options
| author | Jim Hill <gjthill@gmail.com> | 2014-12-21 11:26:00 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-12-22 10:27:42 -0800 |
| commit | 3af74cfb153e20277a1d22414f04249d90d34d5c (patch) | |
| tree | 29f7e45df9efd4b32bdda2c1ba0a28d6103d2787 | |
| parent | bef111d0a5e4b5dcac07f92b0fc918bb31184066 (diff) | |
| download | git-jh/pre-push-sample-no-custom-ifs.tar.gz | |
pre-push.sample: remove unnecessary and misleading IFS=' 'jh/pre-push-sample-no-custom-ifs
The sample hook explicitly sets IFS to SP and nothing else so that
the "read" used in the per-ref while loop that iterates over
"<localref> SP <localsha1> SP <remoteref> SP <remotesha>" records,
where we know refs and sha1s will not have SPs, would split them
correctly.
While this is not wrong per-se, it is not necessary; because we know
these fields do not contain HT or LF, either, we can simply leave
IFS the default.
This will also prevent those who cut and paste from this sample from
getting bitten when they write things in the per-ref loop that need
splitting with the default $IFS (e.g. use $(git rev-list ...) to
produce one-record-per-line output).
Signed-off-by: Jim Hill <gjthill@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | templates/hooks--pre-push.sample | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/templates/hooks--pre-push.sample b/templates/hooks--pre-push.sample index 69e3c67b00..6187dbf439 100755 --- a/templates/hooks--pre-push.sample +++ b/templates/hooks--pre-push.sample @@ -24,7 +24,6 @@ url="$2" z40=0000000000000000000000000000000000000000 -IFS=' ' while read local_ref local_sha remote_ref remote_sha do if [ "$local_sha" = $z40 ] |