summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2012-02-04 01:30:18 -0500
committerJunio C Hamano <gitster@pobox.com>2012-02-03 23:01:55 -0800
commit3d9f5b674fb53cc931e0f676f1599050bd69f696 (patch)
treedb851a3bfe67305db42a262d1f20756f789ac974
parent840c519d7e7ae4651a7b5a0954f7aa53eebc29b6 (diff)
downloadgit-jk/tests-write-script.tar.gz
t0300: use write_script helperjk/tests-write-script
t0300 creates some helper shell scripts, and marks them with "!/bin/sh". Even though the scripts are fairly simple, they can fail on broken shells (specifically, Solaris /bin/sh will persist a temporary assignment to IFS in a "read" command). Rather than work around the problem for Solaris /bin/sh, using write_script will make sure we point to a known-good shell that the user has given us. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-xt/t0300-credentials.sh8
1 files changed, 2 insertions, 6 deletions
diff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh
index 885af8fb62..8621ab036f 100755
--- a/t/t0300-credentials.sh
+++ b/t/t0300-credentials.sh
@@ -14,22 +14,18 @@ test_expect_success 'setup helper scripts' '
done
EOF
- cat >git-credential-useless <<-\EOF &&
- #!/bin/sh
+ write_script git-credential-useless <<-\EOF &&
. ./dump
exit 0
EOF
- chmod +x git-credential-useless &&
- cat >git-credential-verbatim <<-\EOF &&
- #!/bin/sh
+ write_script git-credential-verbatim <<-\EOF &&
user=$1; shift
pass=$1; shift
. ./dump
test -z "$user" || echo username=$user
test -z "$pass" || echo password=$pass
EOF
- chmod +x git-credential-verbatim &&
PATH="$PWD:$PATH"
'