diff options
| author | Jeff King <peff@peff.net> | 2016-07-08 05:16:53 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-07-08 09:47:29 -0700 |
| commit | 7eb6e10c9d7f43913615667740d1b22055cfba1f (patch) | |
| tree | 7906886fd00371deab448784296a546ec4f52a57 | |
| parent | e78d5d49935373dabcc40c5e32aefe4956a70b97 (diff) | |
| download | git-jk/write-file.tar.gz | |
branch: use write_file_buf instead of write_filejk/write-file
If we already have a strbuf, then using write_file_buf is a
little nicer to read (no wondering whether "%s" will eat
your NULs), and it's more efficient (no extra formatting
step).
We don't care about the newline magic of write_file(), as we
have our own multi-line content.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/branch.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/branch.c b/builtin/branch.c index 15232c4a42..1d41251a9a 100644 --- a/builtin/branch.c +++ b/builtin/branch.c @@ -618,7 +618,7 @@ static int edit_branch_description(const char *branch_name) " %s\n" "Lines starting with '%c' will be stripped.\n", branch_name, comment_line_char); - write_file(git_path(edit_description), "%s", buf.buf); + write_file_buf(git_path(edit_description), buf.buf, buf.len); strbuf_reset(&buf); if (launch_editor(git_path(edit_description), &buf, NULL)) { strbuf_release(&buf); |