summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKevin Willford <kewillf@microsoft.com>2017-08-14 15:54:25 -0600
committerJunio C Hamano <gitster@pobox.com>2017-08-16 10:19:46 -0700
commit680ee550d72150f27cdb3235462eee355a20038b (patch)
treee0147e0d7e7208cca1008efbdc85471989c7e1f0
parent3d9c5b5c4461957fbbc0479e037990db04ebb740 (diff)
downloadgit-kw/commit-keep-index-when-pre-commit-is-not-run.tar.gz
commit: skip discarding the index if there is no pre-commit hookkw/commit-keep-index-when-pre-commit-is-not-run
If there is not a pre-commit hook, there is no reason to discard the index and reread it. This change checks to presence of a pre-commit hook and then only discards the index if there was one. Signed-off-by: Kevin Willford <kewillf@microsoft.com> Reviewed-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--builtin/commit.c15
1 files changed, 9 insertions, 6 deletions
diff --git a/builtin/commit.c b/builtin/commit.c
index 2de5f6cc64..6448ef48b0 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -943,13 +943,16 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
return 0;
}
- /*
- * Re-read the index as pre-commit hook could have updated it,
- * and write it out as a tree. We must do this before we invoke
- * the editor and after we invoke run_status above.
- */
- discard_cache();
+ if (!no_verify && find_hook("pre-commit")) {
+ /*
+ * Re-read the index as pre-commit hook could have updated it,
+ * and write it out as a tree. We must do this before we invoke
+ * the editor and after we invoke run_status above.
+ */
+ discard_cache();
+ }
read_cache_from(index_file);
+
if (update_main_cache_tree(0)) {
error(_("Error building trees"));
return 0;