diff options
| author | Lukas Fleischer <git@cryptocrack.de> | 2015-01-10 22:33:21 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2015-01-12 11:12:39 -0800 |
| commit | 20a4a931fb64dbfd32fb575a41591daafac29516 (patch) | |
| tree | 4eb341bc574a100bf530df1898f39b5a8afb55b8 | |
| parent | 1da1e07c835e900337714cfad6c32a8dc0b36ac3 (diff) | |
| download | git-lf/blame-commit-label.tar.gz | |
blame.c: fix garbled error messagelf/blame-commit-label
The helper functions prepare_final() and prepare_initial() return a
pointer to a string that is a member of an object in the
revs->pending array.
Before 1da1e07c (clean up name allocation in prepare_revision_walk,
2014-10-15), these strings used to be non-volatile; they were
instead leaked more or less deliberately. But these days, these
strings are cleared before running prepare_revision_walk() which
potentially transforms the pointer target into a bogus string.
Fix this by maintaining a copy of the original string.
Signed-off-by: Lukas Fleischer <git@cryptocrack.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/blame.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/builtin/blame.c b/builtin/blame.c index 3838be2b02..f745876499 100644 --- a/builtin/blame.c +++ b/builtin/blame.c @@ -2390,7 +2390,7 @@ static struct commit *fake_working_tree_commit(struct diff_options *opt, return commit; } -static const char *prepare_final(struct scoreboard *sb) +static char *prepare_final(struct scoreboard *sb) { int i; const char *final_commit_name = NULL; @@ -2415,10 +2415,10 @@ static const char *prepare_final(struct scoreboard *sb) sb->final = (struct commit *) obj; final_commit_name = revs->pending.objects[i].name; } - return final_commit_name; + return xstrdup(final_commit_name); } -static const char *prepare_initial(struct scoreboard *sb) +static char *prepare_initial(struct scoreboard *sb) { int i; const char *final_commit_name = NULL; @@ -2445,7 +2445,7 @@ static const char *prepare_initial(struct scoreboard *sb) } if (!final_commit_name) die("No commit to dig down to?"); - return final_commit_name; + return xstrdup(final_commit_name); } static int blame_copy_callback(const struct option *option, const char *arg, int unset) @@ -2489,7 +2489,7 @@ int cmd_blame(int argc, const char **argv, const char *prefix) struct origin *o; struct blame_entry *ent = NULL; long dashdash_pos, lno; - const char *final_commit_name = NULL; + char *final_commit_name = NULL; enum object_type type; static struct string_list range_list; @@ -2786,6 +2786,8 @@ parse_done: assign_blame(&sb, opt); + free(final_commit_name); + if (incremental) return 0; |