summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Ågren <martin.agren@gmail.com>2017-11-19 16:03:50 +0100
committerJunio C Hamano <gitster@pobox.com>2017-11-20 09:50:25 +0900
commit0ae19de74f6f5d6c6f9c80899e1ecd611c5b9827 (patch)
treee769eb86928cc201ad2cc5c116f14ec8398228ff
parentd74b541e0b40be0bf35e836bd8c6cbf653283d4b (diff)
downloadgit-ma/branch-list-paginate.tar.gz
branch: change default of `pager.branch` to "on"ma/branch-list-paginate
This is similar to ff1e72483 (tag: change default of `pager.tag` to "on", 2017-08-02) and is safe now that we do not consider `pager.branch` at all when we are not listing branches. This change will help with listing many branches, but will not hurt users of `git branch --edit-description` as it would have before the previous commit. Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--Documentation/git-branch.txt2
-rw-r--r--builtin/branch.c2
-rwxr-xr-xt/t7006-pager.sh10
3 files changed, 7 insertions, 7 deletions
diff --git a/Documentation/git-branch.txt b/Documentation/git-branch.txt
index 9dae1ea295..ef187ba7cf 100644
--- a/Documentation/git-branch.txt
+++ b/Documentation/git-branch.txt
@@ -274,7 +274,7 @@ start-point is either a local or remote-tracking branch.
CONFIGURATION
-------------
`pager.branch` is only respected when listing branches, i.e., when
-`--list` is used or implied.
+`--list` is used or implied. The default is to use a pager.
See linkgit:git-config[1].
Examples
diff --git a/builtin/branch.c b/builtin/branch.c
index 3eb31cd1ed..39fa99bba7 100644
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -649,7 +649,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
}
if (list)
- setup_auto_pager("branch", 0);
+ setup_auto_pager("branch", 1);
if (delete) {
if (!argc)
diff --git a/t/t7006-pager.sh b/t/t7006-pager.sh
index 5998f7135b..f59dfd1432 100755
--- a/t/t7006-pager.sh
+++ b/t/t7006-pager.sh
@@ -214,21 +214,21 @@ test_expect_success TTY 'git tag as alias respects pager.tag with -l' '
! test -e paginated.out
'
-test_expect_success TTY 'git branch defaults to not paging' '
+test_expect_success TTY 'git branch defaults to paging' '
rm -f paginated.out &&
test_terminal git branch &&
- ! test -e paginated.out
+ test -e paginated.out
'
test_expect_success TTY 'git branch respects pager.branch' '
rm -f paginated.out &&
- test_terminal git -c pager.branch branch &&
- test -e paginated.out
+ test_terminal git -c pager.branch=false branch &&
+ ! test -e paginated.out
'
test_expect_success TTY 'git branch respects --no-pager' '
rm -f paginated.out &&
- test_terminal git -c pager.branch --no-pager branch &&
+ test_terminal git --no-pager branch &&
! test -e paginated.out
'