diff options
| author | Olga Telezhnaya <olyatelezhnaya@gmail.com> | 2018-02-21 06:59:01 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-02-21 09:34:07 -0800 |
| commit | edfb8ba06822375b08796b7b4354a94d98b05d13 (patch) | |
| tree | 7941c243a512d20604a8203f85ffcadda36a4fbe | |
| parent | 2bbc6e8a92e5bfe4f1db3836d7106aa0e9df9479 (diff) | |
| download | git-ot/ref-filter-cleanup.tar.gz | |
ref-filter: get rid of gotoot/ref-filter-cleanup
Get rid of goto command in ref-filter for better readability.
Signed-off-by: Olga Telezhnaia <olyatelezhnaya@gmail.com>
Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | ref-filter.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ref-filter.c b/ref-filter.c index 2570870439..be94766f78 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -1494,11 +1494,11 @@ static void populate_value(struct ref_array_item *ref) for (i = 0; i < used_atom_cnt; i++) { struct atom_value *v = &ref->value[i]; if (v->s == NULL) - goto need_obj; + break; } - return; + if (used_atom_cnt <= i) + return; - need_obj: get_object(ref, &ref->objectname, 0, &obj); /* |