summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Tan <pyokagan@gmail.com>2015-05-18 21:45:42 +0800
committerJunio C Hamano <gitster@pobox.com>2015-05-18 11:22:38 -0700
commitdb9bb280ed7df7858a2de5d1d0334114dd837be0 (patch)
tree2c90e8c32d9c3cd012763a37061841a079ee89de
parenteb8dc05c3d364174a6b694e2850ffd6cfe32c6d3 (diff)
downloadgit-pt/pull-ff-vs-merge-ff.tar.gz
pull: parse pull.ff as a bool or stringpt/pull-ff-vs-merge-ff
Since b814da8 (pull: add pull.ff configuration, 2014-01-15) git-pull supported setting --(no-)ff via the pull.ff configuration value. However, as it only matches the string values of "true" and "false", it does not support other boolean aliases such as "on", "off", "1", "0". This is inconsistent with the merge.ff setting, which supports these aliases. Fix this by using the bool_or_string_config function to retrieve the value of pull.ff. Signed-off-by: Paul Tan <pyokagan@gmail.com> Reviewed-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-xgit-pull.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/git-pull.sh b/git-pull.sh
index 2aea4fa38a..09f6beabdc 100755
--- a/git-pull.sh
+++ b/git-pull.sh
@@ -54,7 +54,7 @@ then
fi
# Setup default fast-forward options via `pull.ff`
-pull_ff=$(git config pull.ff)
+pull_ff=$(bool_or_string_config pull.ff)
case "$pull_ff" in
true)
no_ff=--ff