diff options
| author | René Scharfe <l.s.r@web.de> | 2015-03-09 23:46:54 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2015-03-10 15:44:41 -0700 |
| commit | 6f75d45b2412c646b74300f360361b319689e554 (patch) | |
| tree | 9019acb18d49dba98769569f5ad2fccfbd5d696f | |
| parent | 282616c72d1d08a77ca4fe1186cb708c38408d87 (diff) | |
| download | git-rs/use-isxdigit.tar.gz | |
use isxdigit() for checking if a character is a hexadecimal digitrs/use-isxdigit
Use the standard function isxdigit() to make the intent clearer and
avoid using magic constants.
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | sha1_name.c | 2 | ||||
| -rw-r--r-- | transport.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/sha1_name.c b/sha1_name.c index c2c938c4e1..dc85aafeca 100644 --- a/sha1_name.c +++ b/sha1_name.c @@ -749,7 +749,7 @@ static int get_describe_name(const char *name, int len, unsigned char *sha1) for (cp = name + len - 1; name + 2 <= cp; cp--) { char ch = *cp; - if (hexval(ch) & ~0377) { + if (!isxdigit(ch)) { /* We must be looking at g in "SOMETHING-g" * for it to be describe output. */ diff --git a/transport.c b/transport.c index 325f03e1ee..7ac0df21ea 100644 --- a/transport.c +++ b/transport.c @@ -117,7 +117,7 @@ static void insert_packed_refs(const char *packed_refs, struct ref **list) return; } - if (hexval(buffer[0]) > 0xf) + if (!isxdigit(buffer[0])) continue; len = strlen(buffer); if (len && buffer[len - 1] == '\n') |