summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Beller <sbeller@google.com>2015-02-13 13:18:49 -0800
committerJunio C Hamano <gitster@pobox.com>2015-02-13 13:42:17 -0800
commit0b868f0eecf4a5b4f25b5876e731f0b5456edc89 (patch)
tree6237fc5136d62544ce46f12d087206427b9de5c3
parenta5031214c4fe5f5d3fcf649d10769744cbc66fed (diff)
downloadgit-sb/hex-object-name-is-at-most-41-bytes-long.tar.gz
hex.c: reduce memory footprint of sha1_to_hex static bufferssb/hex-object-name-is-at-most-41-bytes-long
41 bytes is the exact number of bytes needed for having the returned hex string represented. 50 seems to be an arbitrary number, such that there are no benefits from alignment to certain address boundaries. Signed-off-by: Stefan Beller <sbeller@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--hex.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hex.c b/hex.c
index bb402fbaa2..9ec5a3b325 100644
--- a/hex.c
+++ b/hex.c
@@ -51,7 +51,7 @@ int get_sha1_hex(const char *hex, unsigned char *sha1)
char *sha1_to_hex(const unsigned char *sha1)
{
static int bufno;
- static char hexbuffer[4][50];
+ static char hexbuffer[4][41];
static const char hex[] = "0123456789abcdef";
char *buffer = hexbuffer[3 & ++bufno], *buf = buffer;
int i;