summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRamsay Jones <ramsay@ramsay1.demon.co.uk>2012-02-13 18:24:41 +0000
committerJunio C Hamano <gitster@pobox.com>2012-02-13 11:12:36 -0800
commit0975a5020ef050a9fd5b518cbd601e5ee43ddbcf (patch)
treeb8efc84cb5650d3e6e45aabe39d6a8b13e012ff6
parentae7706b9ac98e3c412d799c910de604347ffce5d (diff)
downloadgit-tg/tag-points-at.tar.gz
builtin/tag.c: Fix a sparse warningtg/tag-points-at
In particular, sparse complains as follows: SP builtin/tag.c builtin/tag.c:411:5: warning: symbol 'parse_opt_points_at' was \ not declared. Should it be static? In order to suppress the warning, since the parse_opt_points_at() function does not need to be an external symbol, we simply add the static modifier to the function definition. Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--builtin/tag.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/tag.c b/builtin/tag.c
index 27c35571ab..e377706e6d 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -400,7 +400,7 @@ static int strbuf_check_tag_ref(struct strbuf *sb, const char *name)
return check_refname_format(sb->buf, 0);
}
-int parse_opt_points_at(const struct option *opt __attribute__ ((unused)),
+static int parse_opt_points_at(const struct option *opt __attribute__((unused)),
const char *arg, int unset)
{
unsigned char sha1[20];