summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Beller <sbeller@google.com>2015-03-09 09:58:22 -0700
committerJunio C Hamano <gitster@pobox.com>2015-03-10 15:36:03 -0700
commit04f20c04c6e51ee061a44406b9a73bf54683d8eb (patch)
tree2e2bdb3fef717f4f421b22d20569aeb973deb858
parent7a9409cb0104466eba32162f5bc4e5ab46130f02 (diff)
downloadgit-04f20c04c6e51ee061a44406b9a73bf54683d8eb.tar.gz
connect.c: do not leak "conn" after showing diagnosis
When git_connect() is called to see how the URL is parsed for debugging purposes with CONNECT_DIAG_URL set, the variable conn is leaked. At this point in the codeflow, it only has its memory and no other resource is associated with it, so it is sufficient to clean it up by just freeing it. Signed-off-by: Stefan Beller <sbeller@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--connect.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/connect.c b/connect.c
index ce0e121423..6090211fe9 100644
--- a/connect.c
+++ b/connect.c
@@ -739,6 +739,7 @@ struct child_process *git_connect(int fd[2], const char *url,
free(hostandport);
free(path);
+ free(conn);
return NULL;
} else {
ssh = getenv("GIT_SSH_COMMAND");