diff options
| author | Elia Pinto <gitter.spiros@gmail.com> | 2014-04-30 09:23:06 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-04-30 11:08:09 -0700 |
| commit | ce21ccfae0729fd73b54f3ae4935fc7769343561 (patch) | |
| tree | bcd8bcc5770ccbb3322c3201e5f6c359a4ca85fb | |
| parent | 6003eb13c69516dfedc9466aeb8c3a32a054c286 (diff) | |
| download | git-ce21ccfae0729fd73b54f3ae4935fc7769343561.tar.gz | |
t4204-patch-id.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t4204-patch-id.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/t4204-patch-id.sh b/t/t4204-patch-id.sh index d2c930de87..7940f6f0b9 100755 --- a/t/t4204-patch-id.sh +++ b/t/t4204-patch-id.sh @@ -45,8 +45,8 @@ test_expect_success 'patch-id supports git-format-patch output' ' git checkout same && git format-patch -1 --stdout | calc_patch_id same && test_cmp patch-id_master patch-id_same && - set `git format-patch -1 --stdout | git patch-id` && - test "$2" = `git rev-parse HEAD` + set $(git format-patch -1 --stdout | git patch-id) && + test "$2" = $(git rev-parse HEAD) ' test_expect_success 'whitespace is irrelevant in footer' ' |