summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoel Holdsworth <jholdsworth@nvidia.com>2022-04-01 15:25:00 +0100
committerJunio C Hamano <gitster@pobox.com>2022-04-01 13:15:44 -0700
commitda0134f6534f407f8377ea97eb040ee6e49412e1 (patch)
treefdfbe6fe0435261a8b064f49f05de31752674d58
parent7a3e83d0bd1d8fe004cd2f3dd4bc03bc8ca6fe9e (diff)
downloadgit-da0134f6534f407f8377ea97eb040ee6e49412e1.tar.gz
git-p4: compare to singletons with "is" and "is not"
PEP8 recommends that comparisons with singletons such as None should be done with "is" and "is not", and never equality operators. This guideline is described here: https://www.python.org/dev/peps/pep-0008/#programming-recommendations Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-xgit-p4.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/git-p4.py b/git-p4.py
index a25adc8bae..2f2450f7d9 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -857,7 +857,7 @@ def p4Where(depotPath):
if data[:space] == depotPath:
output = entry
break
- if output == None:
+ if output is None:
return ""
if output["code"] == "error":
return ""
@@ -879,7 +879,7 @@ def currentGitBranch():
def isValidGitDir(path):
- return git_dir(path) != None
+ return git_dir(path) is not None
def parseRevision(ref):
@@ -4425,7 +4425,7 @@ def main():
global verbose
verbose = cmd.verbose
if cmd.needsGit:
- if cmd.gitdir == None:
+ if cmd.gitdir is None:
cmd.gitdir = os.path.abspath(".git")
if not isValidGitDir(cmd.gitdir):
# "rev-parse --git-dir" without arguments will try $PWD/.git