diff options
author | René Scharfe <l.s.r@web.de> | 2023-01-14 15:37:53 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2023-01-14 19:22:26 -0800 |
commit | 16fb5c54bd91c9714e12c6d742e5a6fd81459b71 (patch) | |
tree | 0247f5b7dfa8a6ffa4bf13f7801ba420545da6f3 /builtin/ls-tree.c | |
parent | 455923e0a152420054ad74f1af36336d5fa7be75 (diff) | |
download | git-16fb5c54bd91c9714e12c6d742e5a6fd81459b71.tar.gz |
ls-tree: fix expansion of repeated %(path)
expand_show_tree() borrows the base strbuf given to us by read_tree() to
build the full path of the current entry when handling %(path). Only
its indirect caller, show_tree_fmt(), removes the added entry name.
That works fine as long as %(path) is only included once in the format
string, but accumulates duplicates if it's repeated:
$ git ls-tree --format='%(path) %(path) %(path)' HEAD M*
Makefile MakefileMakefile MakefileMakefileMakefile
Reset the length after each use to get the same expansion every time;
here's the behavior with this patch:
$ ./git ls-tree --format='%(path) %(path) %(path)' HEAD M*
Makefile Makefile Makefile
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/ls-tree.c')
-rw-r--r-- | builtin/ls-tree.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/builtin/ls-tree.c b/builtin/ls-tree.c index 8a1bf2fa4d..c3284610dd 100644 --- a/builtin/ls-tree.c +++ b/builtin/ls-tree.c @@ -97,9 +97,12 @@ static size_t expand_show_tree(struct strbuf *sb, const char *start, const char *prefix = chomp_prefix ? ls_tree_prefix : NULL; struct strbuf quoted = STRBUF_INIT; struct strbuf sbuf = STRBUF_INIT; + size_t baselen = data->base->len; + strbuf_addstr(data->base, data->pathname); name = relative_path(data->base->buf, prefix, &sbuf); quote_c_style(name, "ed, NULL, 0); + strbuf_setlen(data->base, baselen); strbuf_addbuf(sb, "ed); strbuf_release(&sbuf); strbuf_release("ed); @@ -143,7 +146,6 @@ static int show_recursive(const char *base, size_t baselen, const char *pathname static int show_tree_fmt(const struct object_id *oid, struct strbuf *base, const char *pathname, unsigned mode, void *context) { - size_t baselen; int recurse = 0; struct strbuf sb = STRBUF_INIT; enum object_type type = object_type(mode); @@ -163,12 +165,10 @@ static int show_tree_fmt(const struct object_id *oid, struct strbuf *base, if (type == OBJ_BLOB && (ls_options & LS_TREE_ONLY)) return 0; - baselen = base->len; strbuf_expand(&sb, format, expand_show_tree, &data); strbuf_addch(&sb, line_termination); fwrite(sb.buf, sb.len, 1, stdout); strbuf_release(&sb); - strbuf_setlen(base, baselen); return recurse; } |