summaryrefslogtreecommitdiff
path: root/builtin/pack-objects.c
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2023-02-03 23:44:30 +0000
committerJunio C Hamano <gitster@pobox.com>2023-02-03 18:01:46 -0800
commit647982bb7171b2409f2a90da245b8a31913f930f (patch)
tree07573d1e5c8b2117fbe301ccd5b8c67415ea589f /builtin/pack-objects.c
parent844ede312b4e988881b6e27e352f469d8ab80b2a (diff)
downloadgit-647982bb7171b2409f2a90da245b8a31913f930f.tar.gz
delta-islands: free island_marks and bitmaps
On my mirror of linux.git forkgroup with 780 islands, this saves nearly 4G of heap memory in pack-objects. This savings only benefits delta island users of pack bitmaps, as the process would otherwise be exiting anyways. However, there's probably not many delta island users, but the majority of delta island users would also be pack bitmaps users. Signed-off-by: Eric Wong <e@80x24.org> Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Helped-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/pack-objects.c')
-rw-r--r--builtin/pack-objects.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index 573d0b20b7..f305dd3187 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -929,8 +929,10 @@ static struct object_entry **compute_write_order(void)
*/
for_each_tag_ref(mark_tagged, NULL);
- if (use_delta_islands)
+ if (use_delta_islands) {
max_layers = compute_pack_layers(&to_pack);
+ free_island_marks();
+ }
ALLOC_ARRAY(wo, to_pack.nr_objects);
wo_end = 0;