summaryrefslogtreecommitdiff
path: root/fetch-pack.c
diff options
context:
space:
mode:
authorDavid Turner <dturner@twosigma.com>2017-04-18 17:57:43 -0400
committerJunio C Hamano <gitster@pobox.com>2017-04-18 19:58:04 -0700
commit5781a9a2703e96b01587bb95ceebcc53f2cee91c (patch)
treea0c233542e0d0e694a699f191a16c358d7415122 /fetch-pack.c
parentda25bdb7766c01665500cf7c7b75e76ea1f28b49 (diff)
downloadgit-5781a9a2703e96b01587bb95ceebcc53f2cee91c.tar.gz
xgethostname: handle long hostnamesdt/xgethostname-nul-termination
If the full hostname doesn't fit in the buffer supplied to gethostname, POSIX does not specify whether the buffer will be null-terminated, so to be safe, we should do it ourselves. Introduce new function, xgethostname, which ensures that there is always a \0 at the end of the buffer. Signed-off-by: David Turner <dturner@twosigma.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'fetch-pack.c')
-rw-r--r--fetch-pack.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fetch-pack.c b/fetch-pack.c
index a75ed6c940..f43adfe7b5 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -746,7 +746,7 @@ static int get_pack(struct fetch_pack_args *args,
argv_array_push(&cmd.args, "--fix-thin");
if (args->lock_pack || unpack_limit) {
char hostname[HOST_NAME_MAX + 1];
- if (gethostname(hostname, sizeof(hostname)))
+ if (xgethostname(hostname, sizeof(hostname)))
xsnprintf(hostname, sizeof(hostname), "localhost");
argv_array_pushf(&cmd.args,
"--keep=fetch-pack %"PRIuMAX " on %s",