diff options
| author | Jeff King <peff@peff.net> | 2022-12-13 06:11:10 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-12-13 22:16:22 +0900 |
| commit | 91e2ab1587d8ee18e3d2978f2b7bc250faf5df8f (patch) | |
| tree | 209986d33cab0ede9918f91ca07e5cc8169160c0 /ref-filter.c | |
| parent | c48035d29b4e524aed3a32f0403676f0d9128863 (diff) | |
| download | git-91e2ab1587d8ee18e3d2978f2b7bc250faf5df8f.tar.gz | |
ls-refs: use repository parameter to iterate refs
The ls_refs() function (for the v2 protocol command of the same name)
takes a repository parameter (like all v2 commands), but ignores it. It
should use it to access the refs.
This isn't a bug in practice, since we only call this function when
serving upload-pack from the main repository. But it's an awkward
gotcha, and it causes -Wunused-parameter to complain.
The main reason we don't use the repository parameter is that the ref
iteration interface we call doesn't have a "refs_" variant that takes a
ref_store. However we can easily add one. In fact, since there is only
one other caller (in ref-filter.c), there is no need to maintain the
non-repository wrapper; that caller can just use the_repository. It's
still a long way from consistently using a repository object, but it's
one small step in the right direction.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'ref-filter.c')
| -rw-r--r-- | ref-filter.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/ref-filter.c b/ref-filter.c index 9dc2cd1451..971303683b 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -2128,8 +2128,9 @@ static int for_each_fullref_in_pattern(struct ref_filter *filter, return for_each_fullref_in("", cb, cb_data); } - return for_each_fullref_in_prefixes(NULL, filter->name_patterns, - cb, cb_data); + return refs_for_each_fullref_in_prefixes(get_main_ref_store(the_repository), + NULL, filter->name_patterns, + cb, cb_data); } /* |