Ensure that config show will fail if none of the keys supplied are found

2 files changed, 22 insertions, 0 deletions

diff --git a/lib/gitano/command.lua b/lib/gitano/command.lua
index e7a61cb..4070338 100644
--- a/lib/gitano/command.lua
+++ b/lib/gitano/command.lua
@@ -537,6 +537,15 @@ local function builtin_config_run(conf, repo, cmdline, env)
          end
          log.stdout(key .. ": " .. value)
       end
+      if #slist == 0 then
+         local keys = {}
+         for i = 4, #cmdline do
+            keys[#keys+1] = "'" .. cmdline[i] .. "'"
+         end
+         keys = table.concat(keys, ", ")
+         log.error("Configuration keys not found: " .. keys)
+         return "exit", 1
+      end
    elseif cmdline[3] == "set" then
       local key, value = cmdline[4], cmdline[5]
       local vtype, rest = value:match(pattern.CONF_SET_TYPE_PREFIX)
diff --git a/testing/02-commands-config.yarn b/testing/02-commands-config.yarn
index 00b07b8..1af8bc9 100644
--- a/testing/02-commands-config.yarn
+++ b/testing/02-commands-config.yarn
@@ -113,3 +113,16 @@ new items appended...
     FINALLY the instance is torn down
 
 FIXME: Now that we have the ability to patch the rules we should add more tests
+
+Unknown config values error out on show
+---------------------------------------
+
+It's essential that the user is told when they've attempted to show a config
+value which simply does not exist.
+
+    SCENARIO Showing non-existant configuration values
+
+    GIVEN a standard instance
+     WHEN testinstance adminkey, expecting failure, runs config gitano-admin show banana
+     THEN stdout is empty
+      AND stderr contains banana