diff options
| author | Yorick Peterse <yorickpeterse@gmail.com> | 2018-01-03 17:44:29 +0100 |
|---|---|---|
| committer | Yorick Peterse <yorickpeterse@gmail.com> | 2018-01-04 14:32:38 +0100 |
| commit | dac51ace521d7b2b2a5a5bb19167a8690ead242e (patch) | |
| tree | 2e6d20697bdfe4cc5d71d4f62075a186867236dd /.eslintrc | |
| parent | 1dac4271798a3b9ad36c3d985a3f7740cd1c60b3 (diff) | |
| download | gitlab-ce-conditionally-eager-load-event-target-authors.tar.gz | |
Eager load event target authors whenever possibleconditionally-eager-load-event-target-authors
This ensures that the "author" association of an event's "target"
association is eager loaded whenever the "target" association defines an
"author" association. This in turn solves the N+1 query problem we first
tried to solve in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/15788 but caused
problems when displaying milestones as those don't define an "author"
association.
The approach in this commit does mean that the authors are _always_
eager loaded since this takes place in the "belongs_to" block. This
however shouldn't pose too much of a problem, and as far as I can tell
there's no real way around this unfortunately.
Diffstat (limited to '.eslintrc')
0 files changed, 0 insertions, 0 deletions