diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-05-17 16:05:49 +0000 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-05-17 16:05:49 +0000 |
| commit | 43a25d93ebdabea52f99b05e15b06250cd8f07d7 (patch) | |
| tree | dceebdc68925362117480a5d672bcff122fb625b /.rubocop_todo | |
| parent | 20c84b99005abd1c82101dfeff264ac50d2df211 (diff) | |
| download | gitlab-ce-16.0.0-rc42.tar.gz | |
Add latest changes from gitlab-org/gitlab@16-0-stable-eev16.0.0-rc4216-0-stable
Diffstat (limited to '.rubocop_todo')
101 files changed, 881 insertions, 4399 deletions
diff --git a/.rubocop_todo/capybara/visibility_matcher.yml b/.rubocop_todo/capybara/visibility_matcher.yml index 32f8ddc0ae5..d303f0d5332 100644 --- a/.rubocop_todo/capybara/visibility_matcher.yml +++ b/.rubocop_todo/capybara/visibility_matcher.yml @@ -17,7 +17,6 @@ Capybara/VisibilityMatcher: - 'ee/spec/support/helpers/billing_plans_helpers.rb' - 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb' - 'ee/spec/support/shared_examples/views/issuable_bulk_dropdown_shared_examples.rb' - - 'ee/spec/views/layouts/_search.html.haml_spec.rb' - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' - 'spec/features/admin/admin_mode_spec.rb' - 'spec/features/dashboard/merge_requests_spec.rb' @@ -55,7 +54,6 @@ Capybara/VisibilityMatcher: - 'spec/features/search/user_searches_for_commits_spec.rb' - 'spec/features/snippets/notes_on_personal_snippets_spec.rb' - 'spec/features/task_lists_spec.rb' - - 'spec/features/u2f_spec.rb' - 'spec/features/uploads/user_uploads_file_to_note_spec.rb' - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/features/users/overview_spec.rb' @@ -69,7 +67,6 @@ Capybara/VisibilityMatcher: - 'spec/support/shared_examples/features/wiki/file_attachments_shared_examples.rb' - 'spec/views/import/gitlab_projects/new.html.haml_spec.rb' - 'spec/views/layouts/_header_search.html.haml_spec.rb' - - 'spec/views/layouts/_search.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'spec/views/profiles/preferences/show.html.haml_spec.rb' - 'spec/views/projects/merge_requests/edit.html.haml_spec.rb' diff --git a/.rubocop_todo/cop/redirect_with_status.yml b/.rubocop_todo/cop/redirect_with_status.yml deleted file mode 100644 index 3b4d9d2681e..00000000000 --- a/.rubocop_todo/cop/redirect_with_status.yml +++ /dev/null @@ -1,6 +0,0 @@ ---- -Cop/RedirectWithStatus: - Details: grace period - Exclude: - - 'app/controllers/concerns/issuable_actions.rb' - - 'app/controllers/concerns/membership_actions.rb' diff --git a/.rubocop_todo/cop/user_admin.yml b/.rubocop_todo/cop/user_admin.yml index d0e1d035a8d..82f57e52888 100644 --- a/.rubocop_todo/cop/user_admin.yml +++ b/.rubocop_todo/cop/user_admin.yml @@ -16,7 +16,6 @@ Cop/UserAdmin: - 'app/services/projects/fork_service.rb' - 'app/services/users/build_service.rb' - 'ee/app/controllers/ee/projects_controller.rb' - - 'ee/app/models/concerns/ee/protected_ref_access.rb' - 'ee/app/models/ee/user.rb' - 'ee/app/policies/ee/group_policy.rb' - 'ee/app/services/ee/groups/create_service.rb' diff --git a/.rubocop_todo/database/disable_referential_integrity.yml b/.rubocop_todo/database/disable_referential_integrity.yml deleted file mode 100644 index 95cfc5920d4..00000000000 --- a/.rubocop_todo/database/disable_referential_integrity.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -Database/DisableReferentialIntegrity: - Exclude: - - 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb' diff --git a/.rubocop_todo/database/rescue_query_canceled.yml b/.rubocop_todo/database/rescue_query_canceled.yml index 324ab498dd9..3fa3c8c388e 100644 --- a/.rubocop_todo/database/rescue_query_canceled.yml +++ b/.rubocop_todo/database/rescue_query_canceled.yml @@ -2,7 +2,6 @@ Database/RescueQueryCanceled: Exclude: - 'app/services/issues/relative_position_rebalancing_service.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' - 'lib/gitlab/database/batch_counter.rb' - 'lib/gitlab/issuables_count_for_state.rb' diff --git a/.rubocop_todo/fips/sha1.yml b/.rubocop_todo/fips/sha1.yml index a9637295cab..bfb51250295 100644 --- a/.rubocop_todo/fips/sha1.yml +++ b/.rubocop_todo/fips/sha1.yml @@ -18,19 +18,13 @@ Fips/SHA1: - 'ee/app/services/vulnerabilities/create_service_base.rb' - 'ee/app/services/vulnerabilities/manually_create_service.rb' - 'ee/app/services/vulnerabilities/starboard_vulnerability_create_service.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'ee/spec/factories/vulnerabilities/feedback.rb' - 'ee/spec/factories/vulnerabilities/finding_signatures.rb' - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/cluster_image_scanning_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/container_scanning_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/dast_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/dependency_scanning_spec.rb' - - 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb' - - 'ee/spec/models/merge_train_spec.rb' - 'ee/spec/models/resource_weight_event_spec.rb' - 'ee/spec/models/vulnerabilities/finding_signature_spec.rb' - 'ee/spec/models/vulnerabilities/finding_spec.rb' @@ -77,7 +71,6 @@ Fips/SHA1: - 'spec/lib/gitlab/alert_management/payload/generic_spec.rb' - 'spec/lib/gitlab/alert_management/payload/prometheus_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_note_discussion_id_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/ci/reports/security/finding_signature_spec.rb' - 'spec/lib/gitlab/ci/reports/security/locations/sast_spec.rb' - 'spec/lib/gitlab/ci/reports/security/locations/secret_detection_spec.rb' @@ -85,9 +78,7 @@ Fips/SHA1: - 'spec/lib/gitlab/diff/position_spec.rb' - 'spec/lib/gitlab/git/branch_spec.rb' - 'spec/lib/gitlab/git/tag_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - 'spec/migrations/20220524074947_finalize_backfill_null_note_discussion_ids_spec.rb' - - 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - 'spec/models/ci/artifact_blob_spec.rb' - 'spec/models/ci/job_artifact_spec.rb' - 'spec/models/ci/pipeline_spec.rb' diff --git a/.rubocop_todo/gettext/static_identifier.yml b/.rubocop_todo/gettext/static_identifier.yml new file mode 100644 index 00000000000..c330ffe1482 --- /dev/null +++ b/.rubocop_todo/gettext/static_identifier.yml @@ -0,0 +1,28 @@ +--- +Gettext/StaticIdentifier: + Details: grace period + Exclude: + - 'app/graphql/types/project_type.rb' + - 'app/models/integrations/apple_app_store.rb' + - 'app/models/integrations/confluence.rb' + - 'app/models/integrations/google_play.rb' + - 'app/services/import/fogbugz_service.rb' + - 'app/services/issuable_links/create_service.rb' + - 'app/services/issues/set_crm_contacts_service.rb' + - 'app/services/projects/create_from_template_service.rb' + - 'app/services/security/ci_configuration/base_create_service.rb' + - 'app/services/users/banned_user_base_service.rb' + - 'app/services/work_items/widgets/hierarchy_service/base_service.rb' + - 'ee/app/controllers/admin/licenses_controller.rb' + - 'ee/app/controllers/subscriptions/groups_controller.rb' + - 'ee/app/mailers/ee/emails/admin_notification.rb' + - 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb' + - 'ee/app/models/ee/member.rb' + - 'ee/app/models/integrations/github.rb' + - 'ee/app/services/ee/projects/create_from_template_service.rb' + - 'ee/app/services/security/security_orchestration_policies/policy_configuration_validation_service.rb' + - 'ee/app/services/timebox/rollup_report_service.rb' + - 'ee/app/services/timebox_report_service.rb' + - 'ee/spec/controllers/groups/security/policies_controller_spec.rb' + - 'ee/spec/features/registrations/identity_verification_spec.rb' + - 'lib/gitlab/github_import/settings.rb' diff --git a/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml b/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml deleted file mode 100644 index f5433dfd320..00000000000 --- a/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml +++ /dev/null @@ -1,13 +0,0 @@ ---- -Gitlab/DeprecateTrackRedisHLLEvent: - Exclude: - - 'app/controllers/concerns/snippets_actions.rb' - - 'app/controllers/concerns/wiki_actions.rb' - - 'app/controllers/projects/blob_controller.rb' - - 'app/controllers/projects/pipelines_controller.rb' - - 'ee/app/controllers/admin/audit_logs_controller.rb' - - 'ee/app/controllers/admin/credentials_controller.rb' - - 'ee/app/controllers/groups/analytics/ci_cd_analytics_controller.rb' - - 'ee/app/controllers/groups/audit_events_controller.rb' - - 'ee/app/controllers/groups/epic_boards_controller.rb' - - 'spec/controllers/concerns/redis_tracking_spec.rb' diff --git a/.rubocop_todo/gitlab/doc_url.yml b/.rubocop_todo/gitlab/doc_url.yml index 67c70593b44..ad203c8abd3 100644 --- a/.rubocop_todo/gitlab/doc_url.yml +++ b/.rubocop_todo/gitlab/doc_url.yml @@ -24,7 +24,6 @@ Gitlab/DocUrl: - 'ee/app/mailers/emails/user_cap.rb' - 'ee/app/workers/concerns/elastic/migration_obsolete.rb' - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb' - - 'ee/lib/slack/block_kit/app_home_opened.rb' - 'ee/lib/system_check/app/advanced_search_migrations_check.rb' - 'ee/lib/tasks/gitlab/geo.rake' - 'lib/backup/database.rb' diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index eec55aa7bbe..3a81130a47c 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -79,7 +79,6 @@ Gitlab/NamespacedClass: - 'app/finders/resource_milestone_event_finder.rb' - 'app/finders/resource_state_event_finder.rb' - 'app/finders/sentry_issue_finder.rb' - - 'app/finders/serverless_domain_finder.rb' - 'app/finders/snippets_finder.rb' - 'app/finders/starred_projects_finder.rb' - 'app/finders/tags_finder.rb' @@ -133,7 +132,6 @@ Gitlab/NamespacedClass: - 'app/models/commit_status.rb' - 'app/models/commit_user_mention.rb' - 'app/models/compare.rb' - - 'app/models/concerns/uniquify.rb' - 'app/models/container_expiration_policy.rb' - 'app/models/container_repository.rb' - 'app/models/context_commits_diff.rb' @@ -200,7 +198,6 @@ Gitlab/NamespacedClass: - 'app/models/issue_email_participant.rb' - 'app/models/issue_link.rb' - 'app/models/issue_user_mention.rb' - - 'app/models/iteration.rb' - 'app/models/jira_connect_installation.rb' - 'app/models/jira_connect_subscription.rb' - 'app/models/jira_import_state.rb' @@ -247,6 +244,7 @@ Gitlab/NamespacedClass: - 'app/models/notification_setting.rb' - 'app/models/oauth_access_grant.rb' - 'app/models/oauth_access_token.rb' + - 'app/models/organization.rb' - 'app/models/out_of_context_discussion.rb' - 'app/models/pages_deployment.rb' - 'app/models/pages_domain.rb' @@ -309,6 +307,7 @@ Gitlab/NamespacedClass: - 'app/models/service_desk_setting.rb' - 'app/models/service_list.rb' - 'app/models/shard.rb' + - 'app/models/slack_integration.rb' - 'app/models/snippet.rb' - 'app/models/snippet_blob.rb' - 'app/models/snippet_input_action.rb' @@ -355,6 +354,7 @@ Gitlab/NamespacedClass: - 'app/models/x509_certificate.rb' - 'app/models/x509_issuer.rb' - 'app/models/zoom_meeting.rb' + - 'app/policies/abuse_report_policy.rb' - 'app/policies/application_setting/term_policy.rb' - 'app/policies/award_emoji_policy.rb' - 'app/policies/base_policy.rb' @@ -479,7 +479,6 @@ Gitlab/NamespacedClass: - 'app/serializers/build_metadata_entity.rb' - 'app/serializers/build_trace_entity.rb' - 'app/serializers/build_trace_serializer.rb' - - 'app/serializers/cluster_application_entity.rb' - 'app/serializers/cluster_entity.rb' - 'app/serializers/cluster_serializer.rb' - 'app/serializers/codequality_degradation_entity.rb' @@ -823,8 +822,6 @@ Gitlab/NamespacedClass: - 'app/workers/run_pipeline_schedule_worker.rb' - 'app/workers/schedule_merge_request_cleanup_refs_worker.rb' - 'app/workers/schedule_migrate_external_diffs_worker.rb' - - 'app/workers/self_monitoring_project_create_worker.rb' - - 'app/workers/self_monitoring_project_delete_worker.rb' - 'app/workers/service_desk_email_receiver_worker.rb' - 'app/workers/stage_update_worker.rb' - 'app/workers/stuck_ci_jobs_worker.rb' @@ -865,7 +862,6 @@ Gitlab/NamespacedClass: - 'ee/app/finders/groups_with_templates_finder.rb' - 'ee/app/finders/iterations_finder.rb' - 'ee/app/finders/licenses_finder.rb' - - 'ee/app/finders/merge_trains_finder.rb' - 'ee/app/finders/productivity_analytics_finder.rb' - 'ee/app/finders/scim_finder.rb' - 'ee/app/finders/software_license_policies_finder.rb' @@ -878,6 +874,7 @@ Gitlab/NamespacedClass: - 'ee/app/models/approval_merge_request_rule.rb' - 'ee/app/models/approval_merge_request_rule_source.rb' - 'ee/app/models/approval_project_rule.rb' + - 'ee/app/models/approval_project_rules_user.rb' - 'ee/app/models/approval_project_rules_protected_branch.rb' - 'ee/app/models/approval_state.rb' - 'ee/app/models/approval_wrapped_any_approver_rule.rb' @@ -918,13 +915,13 @@ Gitlab/NamespacedClass: - 'ee/app/models/issuable_metric_image.rb' - 'ee/app/models/issuable_sla.rb' - 'ee/app/models/issuables_analytics.rb' + - 'ee/app/models/iteration.rb' - 'ee/app/models/iteration_note.rb' - 'ee/app/models/ldap_group_link.rb' - 'ee/app/models/ldap_key.rb' - 'ee/app/models/license.rb' - 'ee/app/models/merge_request_block.rb' - 'ee/app/models/merge_request_diff_detail.rb' - - 'ee/app/models/merge_train.rb' - 'ee/app/models/namespace_limit.rb' - 'ee/app/models/path_lock.rb' - 'ee/app/models/productivity_analytics.rb' @@ -940,7 +937,6 @@ Gitlab/NamespacedClass: - 'ee/app/models/scim_identity.rb' - 'ee/app/models/scim_oauth_access_token.rb' - 'ee/app/models/scoped_label_set.rb' - - 'ee/app/models/slack_integration.rb' - 'ee/app/models/smartcard_identity.rb' - 'ee/app/models/software_license.rb' - 'ee/app/models/software_license_policy.rb' @@ -973,6 +969,7 @@ Gitlab/NamespacedClass: - 'ee/app/presenters/epic_presenter.rb' - 'ee/app/presenters/iteration_presenter.rb' - 'ee/app/presenters/merge_request_approver_presenter.rb' + - 'ee/app/presenters/repository_presenter.rb' - 'ee/app/presenters/subscription_presenter.rb' - 'ee/app/presenters/vulnerability_presenter.rb' - 'ee/app/serializers/audit_event_entity.rb' @@ -1050,6 +1047,7 @@ Gitlab/NamespacedClass: - 'ee/app/workers/elastic_namespace_indexer_worker.rb' - 'ee/app/workers/elastic_namespace_rollout_worker.rb' - 'ee/app/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker.rb' + - 'ee/app/workers/elastic_wiki_indexer_worker.rb' - 'ee/app/workers/geo_repository_destroy_worker.rb' - 'ee/app/workers/group_saml_group_sync_worker.rb' - 'ee/app/workers/historical_data_worker.rb' @@ -1070,7 +1068,6 @@ Gitlab/NamespacedClass: - 'ee/app/workers/sync_seat_link_request_worker.rb' - 'ee/app/workers/sync_seat_link_worker.rb' - 'ee/app/workers/update_all_mirrors_worker.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/lib/gitlab/authority_analyzer.rb' - 'ee/lib/gitlab/cidr.rb' - 'ee/lib/gitlab/custom_file_templates.rb' @@ -1271,7 +1268,6 @@ Gitlab/NamespacedClass: - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb' - 'spec/support/helpers/ci_artifact_metadata_generator.rb' - 'spec/support/helpers/fake_migration_classes.rb' - - 'spec/support/helpers/fake_u2f_device.rb' - 'spec/support/helpers/fake_webauthn_device.rb' - 'spec/support/helpers/markdown_feature.rb' - 'spec/support/helpers/redis_without_keys.rb' diff --git a/.rubocop_todo/gitlab/no_code_coverage_comment.yml b/.rubocop_todo/gitlab/no_code_coverage_comment.yml index e37a9702094..e97974a4738 100644 --- a/.rubocop_todo/gitlab/no_code_coverage_comment.yml +++ b/.rubocop_todo/gitlab/no_code_coverage_comment.yml @@ -4,7 +4,6 @@ Gitlab/NoCodeCoverageComment: - 'app/models/integration.rb' - 'app/services/ci/job_artifacts/destroy_batch_service.rb' - 'app/workers/database/batched_background_migration/single_database_worker.rb' - - 'config/initializers/net_http_response_patch.rb' - 'ee/app/models/concerns/geo/replicable_model.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'lib/gitlab/auth/o_auth/session.rb' diff --git a/.rubocop_todo/gitlab/service_response.yml b/.rubocop_todo/gitlab/service_response.yml index d6ce9633882..a61bb27ed2e 100644 --- a/.rubocop_todo/gitlab/service_response.yml +++ b/.rubocop_todo/gitlab/service_response.yml @@ -60,7 +60,6 @@ Gitlab/ServiceResponse: - 'ee/app/services/iterations/roll_over_issues_service.rb' - 'ee/app/services/iterations/update_service.rb' - 'ee/app/services/security/findings/dismiss_service.rb' - - 'ee/app/services/vulnerabilities/finding_dismiss_service.rb' - 'ee/app/services/vulnerability_issue_links/create_service.rb' - 'ee/app/services/vulnerability_issue_links/delete_service.rb' - 'ee/spec/graphql/mutations/security/finding/dismiss_spec.rb' diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index 1eeb7c69a96..4274e59a2a9 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -127,7 +127,6 @@ Gitlab/StrongMemoizeAttr: - 'app/models/namespaces/traversal/linear.rb' - 'app/models/namespaces/traversal/recursive.rb' - 'app/models/note.rb' - - 'app/models/onboarding/completion.rb' - 'app/models/packages/go/module.rb' - 'app/models/packages/go/module_version.rb' - 'app/models/packages/package.rb' @@ -181,7 +180,7 @@ Gitlab/StrongMemoizeAttr: - 'app/services/ci/pipelines/hook_service.rb' - 'app/services/ci/queue/build_queue_service.rb' - 'app/services/ci/update_build_state_service.rb' - - 'app/services/clusters/agents/refresh_authorization_service.rb' + - 'app/services/clusters/agents/authorizations/ci_access/refresh_service.rb' - 'app/services/clusters/integrations/prometheus_health_check_service.rb' - 'app/services/concerns/alert_management/alert_processing.rb' - 'app/services/concerns/incident_management/settings.rb' @@ -230,8 +229,6 @@ Gitlab/StrongMemoizeAttr: - 'app/services/packages/cleanup/update_policy_service.rb' - 'app/services/packages/composer/create_package_service.rb' - 'app/services/packages/debian/extract_changes_metadata_service.rb' - - 'app/services/packages/debian/extract_metadata_service.rb' - - 'app/services/packages/debian/find_or_create_package_service.rb' - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'app/services/packages/debian/generate_distribution_service.rb' - 'app/services/packages/debian/process_changes_service.rb' @@ -320,7 +317,7 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/helpers/ee/preferences_helper.rb' - 'ee/app/helpers/ee/registrations_helper.rb' - 'ee/app/helpers/ee/timeboxes_helper.rb' - - 'ee/app/helpers/ee/trial_helper.rb' + - 'ee/app/helpers/trials_helper.rb' - 'ee/app/helpers/ee/welcome_helper.rb' - 'ee/app/helpers/license_monitoring_helper.rb' - 'ee/app/helpers/subscriptions_helper.rb' @@ -359,7 +356,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/models/gitlab_subscription.rb' - 'ee/app/models/issuables_analytics.rb' - 'ee/app/models/license.rb' - - 'ee/app/models/namespaces/storage/root_excess_size.rb' - 'ee/app/models/sca/license_compliance.rb' - 'ee/app/models/security/orchestration_policy_configuration.rb' - 'ee/app/models/security/orchestration_policy_rule_schedule.rb' @@ -413,7 +409,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/services/incident_management/escalation_policies/update_service.rb' - 'ee/app/services/incident_management/pending_escalations/process_service.rb' - 'ee/app/services/iterations/create_service.rb' - - 'ee/app/services/merge_commits/export_csv_service.rb' - 'ee/app/services/merge_requests/update_blocks_service.rb' - 'ee/app/services/projects/restore_service.rb' - 'ee/app/services/protected_environments/base_service.rb' @@ -473,7 +468,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/lib/gitlab/auth/group_saml/user.rb' - 'ee/lib/gitlab/auth/saml/membership_updater.rb' - 'ee/lib/gitlab/auth/smartcard/certificate.rb' - - 'ee/lib/gitlab/ci/minutes/build_consumption.rb' - 'ee/lib/gitlab/ci/minutes/cached_quota.rb' - 'ee/lib/gitlab/ci/minutes/gitlab_contribution_cost_factor.rb' - 'ee/lib/gitlab/ci/minutes/runners_availability.rb' @@ -551,7 +545,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/auth/otp/strategies/forti_token_cloud.rb' - 'lib/gitlab/auth/request_authenticator.rb' - 'lib/gitlab/background_migration/legacy_upload_mover.rb' - - 'lib/gitlab/bare_repository_import/repository.rb' - 'lib/gitlab/blob_helper.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' - 'lib/gitlab/chat/command.rb' @@ -596,7 +589,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/ci/reports/accessibility_reports_comparer.rb' - 'lib/gitlab/ci/reports/codequality_reports_comparer.rb' - 'lib/gitlab/ci/reports/security/locations/base.rb' - - 'lib/gitlab/ci/reports/security/vulnerability_reports_comparer.rb' - 'lib/gitlab/ci/reports/test_reports_comparer.rb' - 'lib/gitlab/ci/reports/test_suite_comparer.rb' - 'lib/gitlab/ci/reports/test_suite_summary.rb' @@ -647,7 +639,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/git_access_project.rb' - 'lib/gitlab/gitaly_client/with_feature_flag_actors.rb' - 'lib/gitlab/github_import/client.rb' - - 'lib/gitlab/github_import/importer/repository_importer.rb' - 'lib/gitlab/github_import/representation/diff_notes/suggestion_formatter.rb' - 'lib/gitlab/gl_repository/identifier.rb' - 'lib/gitlab/gpg/commit.rb' @@ -659,7 +650,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/import_export/fast_hash_serializer.rb' - 'lib/gitlab/import_export/group/tree_restorer.rb' - 'lib/gitlab/import_export/importer.rb' - - 'lib/gitlab/import_export/json/legacy_reader.rb' - 'lib/gitlab/import_export/lfs_restorer.rb' - 'lib/gitlab/import_export/project/sample/date_calculator.rb' - 'lib/gitlab/import_export/project/tree_restorer.rb' @@ -685,7 +675,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/relative_positioning/starting_from.rb' - 'lib/gitlab/request_context.rb' - 'lib/gitlab/search/found_blob.rb' - - 'lib/gitlab/serverless/service.rb' - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/deduplicates_when_scheduling.rb' - 'lib/gitlab/sidekiq_queue.rb' diff --git a/.rubocop_todo/graphql/authorize_types.yml b/.rubocop_todo/graphql/authorize_types.yml new file mode 100644 index 00000000000..6735ef9c9ad --- /dev/null +++ b/.rubocop_todo/graphql/authorize_types.yml @@ -0,0 +1,7 @@ +--- +Graphql/AuthorizeTypes: + Exclude: + - 'app/graphql/types/data_transfer/base_type.rb' + - 'app/graphql/types/data_transfer/egress_node_type.rb' + - 'app/graphql/types/data_transfer/group_data_transfer_type.rb' + - 'app/graphql/types/data_transfer/project_data_transfer_type.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index faa81abc0af..bdd3a15489d 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -3,56 +3,6 @@ Layout/ArgumentAlignment: Details: grace period Exclude: - - 'app/controllers/admin/application_settings_controller.rb' - - 'app/controllers/admin/ci/variables_controller.rb' - - 'app/controllers/admin/groups_controller.rb' - - 'app/controllers/admin/spam_logs_controller.rb' - - 'app/controllers/admin/topics_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/controllers/chaos_controller.rb' - - 'app/controllers/concerns/authenticates_with_two_factor.rb' - - 'app/controllers/concerns/enforces_two_factor_authentication.rb' - - 'app/controllers/concerns/invisible_captcha_on_signup.rb' - - 'app/controllers/concerns/issuable_actions.rb' - - 'app/controllers/concerns/known_sign_in.rb' - - 'app/controllers/concerns/membership_actions.rb' - - 'app/controllers/concerns/observability/content_security_policy.rb' - - 'app/controllers/concerns/wiki_actions.rb' - - 'app/controllers/dashboard/todos_controller.rb' - - 'app/controllers/groups/children_controller.rb' - - 'app/controllers/groups/group_members_controller.rb' - - 'app/controllers/groups_controller.rb' - - 'app/controllers/metrics_controller.rb' - - 'app/controllers/oauth/authorizations_controller.rb' - - 'app/controllers/oauth/authorized_applications_controller.rb' - - 'app/controllers/oauth/jira_dvcs/authorizations_controller.rb' - - 'app/controllers/profiles/emails_controller.rb' - - 'app/controllers/projects/blob_controller.rb' - - 'app/controllers/projects/commit_controller.rb' - - 'app/controllers/projects/environments_controller.rb' - - 'app/controllers/projects/error_tracking_controller.rb' - - 'app/controllers/projects/feature_flags_controller.rb' - - 'app/controllers/projects/google_cloud/base_controller.rb' - - 'app/controllers/projects/jobs_controller.rb' - - 'app/controllers/projects/labels_controller.rb' - - 'app/controllers/projects/merge_requests/creations_controller.rb' - - 'app/controllers/projects/merge_requests_controller.rb' - - 'app/controllers/projects/pages_controller.rb' - - 'app/controllers/projects/pages_domains_controller.rb' - - 'app/controllers/projects/pipeline_schedules_controller.rb' - - 'app/controllers/projects/pipelines_controller.rb' - - 'app/controllers/projects/prometheus/metrics_controller.rb' - - 'app/controllers/projects/repositories_controller.rb' - - 'app/controllers/projects/security/configuration_controller.rb' - - 'app/controllers/projects/tree_controller.rb' - - 'app/controllers/projects/web_ide_terminals_controller.rb' - - 'app/controllers/repositories/lfs_api_controller.rb' - - 'app/controllers/repositories/lfs_locks_api_controller.rb' - - 'app/controllers/search_controller.rb' - - 'app/controllers/sessions_controller.rb' - - 'app/controllers/users_controller.rb' - - 'app/finders/autocomplete/users_finder.rb' - - 'app/finders/group_descendants_finder.rb' - 'app/graphql/mutations/achievements/create.rb' - 'app/graphql/mutations/admin/sidekiq_queues/delete_jobs.rb' - 'app/graphql/mutations/alert_management/alerts/set_assignees.rb' @@ -150,7 +100,6 @@ Layout/ArgumentAlignment: - 'app/graphql/mutations/jira_import/import_users.rb' - 'app/graphql/mutations/jira_import/start.rb' - 'app/graphql/mutations/labels/create.rb' - - 'app/graphql/mutations/members/groups/bulk_update.rb' - 'app/graphql/mutations/merge_requests/accept.rb' - 'app/graphql/mutations/merge_requests/base.rb' - 'app/graphql/mutations/merge_requests/create.rb' @@ -557,65 +506,6 @@ Layout/ArgumentAlignment: - 'app/graphql/types/work_items/widgets/start_and_due_date_update_input_type.rb' - 'app/graphql/types/x509_certificate_type.rb' - 'app/graphql/types/x509_issuer_type.rb' - - 'app/helpers/application_helper.rb' - - 'app/helpers/application_settings_helper.rb' - - 'app/helpers/blob_helper.rb' - - 'app/helpers/ci/status_helper.rb' - - 'app/helpers/commits_helper.rb' - - 'app/helpers/dashboard_helper.rb' - - 'app/helpers/events_helper.rb' - - 'app/helpers/feature_flags_helper.rb' - - 'app/helpers/issuables_helper.rb' - - 'app/helpers/mirror_helper.rb' - - 'app/helpers/notes_helper.rb' - - 'app/helpers/projects/error_tracking_helper.rb' - - 'app/helpers/snippets_helper.rb' - - 'app/helpers/todos_helper.rb' - - 'app/helpers/users/group_callouts_helper.rb' - - 'app/helpers/users_helper.rb' - - 'app/helpers/visibility_level_helper.rb' - - 'app/mailers/emails/projects.rb' - - 'app/mailers/notify.rb' - - 'app/models/abuse_report.rb' - - 'app/models/achievements/achievement.rb' - - 'app/models/achievements/user_achievement.rb' - - 'app/models/active_session.rb' - - 'app/models/analytics/cycle_analytics/project_level.rb' - - 'app/models/analytics/cycle_analytics/stage.rb' - - 'app/models/analytics/cycle_analytics/value_stream.rb' - - 'app/models/appearance.rb' - - 'app/models/application_setting.rb' - - 'app/models/atlassian/identity.rb' - - 'app/models/bulk_imports/configuration.rb' - - 'app/models/bulk_imports/entity.rb' - - 'app/models/ci/build_trace_metadata.rb' - - 'app/models/ci/namespace_mirror.rb' - - 'app/models/ci/pipeline.rb' - - 'app/models/ci/project_mirror.rb' - - 'app/models/ci/ref.rb' - - 'app/models/ci/runner.rb' - - 'app/models/ci/runner_machine.rb' - - 'app/models/ci/running_build.rb' - - 'app/models/ci/stage.rb' - - 'app/models/clusters/kubernetes_namespace.rb' - - 'app/models/concerns/bulk_member_access_load.rb' - - 'app/models/concerns/ci/metadatable.rb' - - 'app/models/concerns/discussion_on_diff.rb' - - 'app/models/concerns/group_descendant.rb' - - 'app/models/concerns/integrations/has_issue_tracker_fields.rb' - - 'app/models/concerns/issuable.rb' - - 'app/models/concerns/limitable.rb' - - 'app/models/concerns/mentionable/reference_regexes.rb' - - 'app/models/concerns/resolvable_discussion.rb' - - 'app/models/concerns/vulnerability_finding_helpers.rb' - - 'app/models/concerns/web_hooks/auto_disabling.rb' - - 'app/models/container_repository.rb' - - 'app/models/cycle_analytics/project_level_stage_adapter.rb' - - 'app/models/deployment.rb' - - 'app/models/design_management/design.rb' - - 'app/models/design_management/version.rb' - - 'app/models/diff_discussion.rb' - - 'app/models/diff_viewer/base.rb' - 'app/models/discussion.rb' - 'app/models/environment.rb' - 'app/models/generic_commit_status.rb' @@ -629,20 +519,9 @@ Layout/ArgumentAlignment: - 'app/models/integrations/jira.rb' - 'app/models/jira_connect_installation.rb' - 'app/models/lfs_object.rb' - - 'app/models/loose_foreign_keys/deleted_record.rb' - - 'app/models/merge_request.rb' - - 'app/models/merge_request_diff.rb' - - 'app/models/merge_requests_closing_issues.rb' - - 'app/models/ml/candidate_metadata.rb' - - 'app/models/ml/experiment_metadata.rb' - - 'app/models/namespace.rb' - - 'app/models/namespaces/traversal/linear_scopes.rb' - - 'app/models/note.rb' - - 'app/models/note_diff_file.rb' - 'app/models/packages/cleanup/policy.rb' - 'app/models/packages/conan/metadatum.rb' - 'app/models/packages/debian/file_entry.rb' - - 'app/models/packages/debian/file_metadatum.rb' - 'app/models/packages/package.rb' - 'app/models/packages/rpm/metadatum.rb' - 'app/models/pages_domain.rb' @@ -657,44 +536,10 @@ Layout/ArgumentAlignment: - 'app/models/remote_mirror.rb' - 'app/models/repository.rb' - 'app/models/resource_timebox_event.rb' - - 'app/models/serverless/domain_cluster.rb' - 'app/models/service_desk_setting.rb' - 'app/models/terraform/state.rb' - 'app/models/time_tracking/timelog_category.rb' - 'app/models/u2f_registration.rb' - - 'app/models/user.rb' - - 'app/models/user_preference.rb' - - 'app/models/users/group_callout.rb' - - 'app/models/users/phone_number_validation.rb' - - 'app/models/users/project_callout.rb' - - 'app/models/users/user_follow_user.rb' - - 'app/models/web_ide_terminal.rb' - - 'app/models/webauthn_registration.rb' - - 'app/models/wiki_page.rb' - - 'app/models/work_item.rb' - - 'app/policies/project_snippet_policy.rb' - - 'app/presenters/ci/build_runner_presenter.rb' - - 'app/presenters/label_presenter.rb' - - 'app/presenters/merge_request_presenter.rb' - - 'app/presenters/project_presenter.rb' - - 'app/presenters/snippet_blob_presenter.rb' - - 'app/serializers/build_details_entity.rb' - - 'app/serializers/environment_serializer.rb' - - 'app/serializers/error_tracking/detailed_error_entity.rb' - - 'app/serializers/fork_namespace_entity.rb' - - 'app/serializers/group_child_entity.rb' - - 'app/serializers/issue_board_entity.rb' - - 'app/serializers/issue_entity.rb' - - 'app/serializers/linked_issue_entity.rb' - - 'app/serializers/merge_request_metrics_helper.rb' - - 'app/serializers/rollout_status_entity.rb' - - 'app/serializers/stage_entity.rb' - - 'app/serializers/test_case_entity.rb' - - 'app/services/ci/archive_trace_service.rb' - - 'app/services/ci/ensure_stage_service.rb' - - 'app/services/ci/list_config_variables_service.rb' - - 'app/services/ci/parse_dotenv_artifact_service.rb' - - 'app/services/ci/stuck_builds/drop_helpers.rb' - 'app/services/compare_service.rb' - 'app/services/concerns/rate_limited_service.rb' - 'app/services/design_management/copy_design_collection/copy_service.rb' @@ -715,33 +560,14 @@ Layout/ArgumentAlignment: - 'app/services/markdown_content_rewriter_service.rb' - 'app/services/members/base_service.rb' - 'app/services/members/create_service.rb' - - 'app/services/members/creator_service.rb' - - 'app/services/merge_requests/build_service.rb' - - 'app/services/merge_requests/ff_merge_service.rb' - - 'app/services/merge_requests/merge_service.rb' - - 'app/services/merge_requests/merge_to_ref_service.rb' - - 'app/services/merge_requests/push_options_handler_service.rb' - - 'app/services/merge_requests/refresh_service.rb' - - 'app/services/merge_requests/reload_diffs_service.rb' - - 'app/services/merge_requests/retarget_chain_service.rb' - 'app/services/metrics/dashboard/annotations/create_service.rb' - 'app/services/metrics/dashboard/annotations/delete_service.rb' - 'app/services/metrics/dashboard/clone_dashboard_service.rb' - 'app/services/metrics/users_starred_dashboards/create_service.rb' - 'app/services/ml/experiment_tracking/experiment_repository.rb' - - 'app/services/notes/create_service.rb' - - 'app/services/notes/destroy_service.rb' - - 'app/services/notes/update_service.rb' - 'app/services/pages/migrate_from_legacy_storage_service.rb' - 'app/services/post_receive_service.rb' - 'app/services/preview_markdown_service.rb' - - 'app/services/projects/create_service.rb' - - 'app/services/projects/fork_service.rb' - - 'app/services/projects/hashed_storage/base_repository_service.rb' - - 'app/services/projects/import_service.rb' - - 'app/services/projects/lfs_pointers/lfs_download_link_list_service.rb' - - 'app/services/projects/overwrite_project_service.rb' - - 'app/services/projects/update_remote_mirror_service.rb' - 'app/services/protected_branches/api_service.rb' - 'app/services/protected_branches/legacy_api_create_service.rb' - 'app/services/quick_actions/interpret_service.rb' @@ -766,34 +592,11 @@ Layout/ArgumentAlignment: - 'app/services/webauthn/authenticate_service.rb' - 'app/services/work_items/create_service.rb' - 'app/validators/feature_flag_user_xids_validator.rb' - - 'app/workers/gitlab/github_import/stage/import_protected_branches_worker.rb' - - 'app/workers/gitlab/jira_import/stuck_jira_import_jobs_worker.rb' - - 'app/workers/packages/debian/process_package_file_worker.rb' - - 'app/workers/repository_update_remote_mirror_worker.rb' - - 'app/workers/run_pipeline_schedule_worker.rb' - - 'app/workers/stuck_export_jobs_worker.rb' - - 'app/workers/x509_issuer_crl_check_worker.rb' - 'config/application.rb' - 'config/initializers/hashie_mash_permitted_patch.rb' - 'config/initializers/rack_timeout.rb' - 'config/initializers/rest-client-hostname_override.rb' - 'config/initializers/zz_metrics.rb' - - 'config/routes.rb' - - 'config/routes/admin.rb' - - 'config/routes/group.rb' - - 'config/routes/profile.rb' - - 'config/routes/project.rb' - - 'config/routes/snippets.rb' - - 'config/routes/unmatched_project.rb' - - 'config/routes/uploads.rb' - - 'config/routes/user.rb' - - 'db/migrate/20210901065504_add_index_on_name_and_id_to_public_groups.rb' - - 'db/migrate/20210910014741_add_dependency_proxy_ttl_group_policy_worker_capacity_to_application_settings.rb' - - 'db/migrate/20211111112639_add_fk_compliance_violations_merge_request.rb' - - 'db/migrate/20211111112713_add_fk_compliance_violations_violating_user.rb' - - 'db/migrate/20211224112937_add_packages_cleanup_package_file_worker_capacity_to_application_settings.rb' - - 'db/migrate/20220204154220_add_index_on_greatest_done_at_to_container_repositories.rb' - - 'db/migrate/20220314184009_create_protected_environment_approval_rules.rb' - 'db/migrate/20220401113123_add_check_constraint_to_vsa_aggregation_runtime_data_columns.rb' - 'db/migrate/20220405125459_add_non_migrated_index_to_container_repositories.rb' - 'db/migrate/20220408001450_add_work_item_type_name_unique_index_null_namespaces.rb' @@ -856,20 +659,6 @@ Layout/ArgumentAlignment: - 'db/migrate/20230124193917_add_index_for_protected_tag_create_access_levels.rb' - 'db/migrate/20230127151529_add_project_pointer_for_analytics_dashboard.rb' - 'db/migrate/20230127151531_change_dashboard_analytics_project_pointer_project_null.rb' - - 'db/post_migrate/20210921062820_add_image_location_index_to_vulnerability_occurrences.rb' - - 'db/post_migrate/20211007093340_remove_analytics_snapshots_segment_id_column.rb' - - 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb' - - 'db/post_migrate/20211022112202_add_cluster_id_location_index_to_vulnerability_occurrences.rb' - - 'db/post_migrate/20211027112901_drop_index_keys_on_expires_at_and_before_expiry_notification_undelivered.rb' - - 'db/post_migrate/20211102114802_update_vulnerability_occurrences_location.rb' - - 'db/post_migrate/20211118194239_drop_invalid_remediations.rb' - - 'db/post_migrate/20211213064821_add_agent_id_location_index_to_vulnerability_occurrences.rb' - - 'db/post_migrate/20211217120000_modify_kubernetes_resource_location_index_to_vulnerability_occurrences.rb' - - 'db/post_migrate/20220207080758_update_api_indexes_for_projects.rb' - - 'db/post_migrate/20220216201949_remove_package_files_limit_from_application_settings.rb' - - 'db/post_migrate/20220307192534_create_index_for_remove_duplicate_project_tag_releases.rb' - - 'db/post_migrate/20220307192645_remove_index_for_remove_duplicate_project_tag_releases.rb' - - 'db/post_migrate/20220307192725_create_unique_index_release_tag_project.rb' - 'db/post_migrate/20220415124802_remove_job_artifact_deprecated_geo_fields.rb' - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' - 'db/post_migrate/20220523164734_add_foreign_key_to_vulnerability_reads_casted_cluster_agent_id.rb' @@ -923,25 +712,6 @@ Layout/ArgumentAlignment: - 'db/post_migrate/20230130070623_add_index_on_packages_package_file_file_name.rb' - 'ee/app/components/namespaces/free_user_cap/base_alert_component.rb' - 'ee/app/components/namespaces/free_user_cap/enforcement_at_limit_alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/shared.rb' - - 'ee/app/controllers/admin/credentials_controller.rb' - - 'ee/app/controllers/concerns/ee/analytics/cycle_analytics/stage_actions.rb' - - 'ee/app/controllers/ee/groups_controller.rb' - - 'ee/app/controllers/ee/passwords_controller.rb' - - 'ee/app/controllers/ee/registrations_controller.rb' - - 'ee/app/controllers/ee/search_controller.rb' - - 'ee/app/controllers/groups/analytics/ci_cd_analytics_controller.rb' - - 'ee/app/controllers/groups/analytics/cycle_analytics_controller.rb' - - 'ee/app/controllers/groups/saml_group_links_controller.rb' - - 'ee/app/controllers/groups/security/credentials_controller.rb' - - 'ee/app/controllers/groups/two_factor_auths_controller.rb' - - 'ee/app/controllers/omniauth_kerberos_controller.rb' - - 'ee/app/controllers/projects/integrations/zentao/issues_controller.rb' - - 'ee/app/controllers/registrations/groups_projects_controller.rb' - - 'ee/app/controllers/subscriptions_controller.rb' - - 'ee/app/controllers/trials_controller.rb' - - 'ee/app/finders/security/findings_finder.rb' - - 'ee/app/finders/security/training_providers/base_url_finder.rb' - 'ee/app/graphql/ee/mutations/alert_management/http_integration/create.rb' - 'ee/app/graphql/ee/mutations/alert_management/http_integration/update.rb' - 'ee/app/graphql/ee/mutations/boards/issues/issue_move_list.rb' @@ -1071,7 +841,6 @@ Layout/ArgumentAlignment: - 'ee/app/graphql/mutations/vulnerabilities/create_external_issue_link.rb' - 'ee/app/graphql/mutations/vulnerabilities/destroy_external_issue_link.rb' - 'ee/app/graphql/mutations/vulnerabilities/dismiss.rb' - - 'ee/app/graphql/mutations/vulnerabilities/finding/dismiss.rb' - 'ee/app/graphql/mutations/vulnerabilities/resolve.rb' - 'ee/app/graphql/mutations/vulnerabilities/revert_to_detected.rb' - 'ee/app/graphql/resolvers/alert_management/payload_alert_field_resolver.rb' @@ -1225,15 +994,7 @@ Layout/ArgumentAlignment: - 'ee/app/graphql/types/work_items/widgets/status_filter_input_type.rb' - 'ee/app/graphql/types/work_items/widgets/status_input_type.rb' - 'ee/app/graphql/types/work_items/widgets/weight_input_type.rb' - - 'ee/app/helpers/billing_plans_helper.rb' - - 'ee/app/helpers/ee/feature_flags_helper.rb' - - 'ee/app/helpers/ee/search_helper.rb' - - 'ee/app/mailers/ee/emails/projects.rb' - - 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb' - 'ee/app/models/approval_wrapped_rule.rb' - - 'ee/app/models/ci/minutes/notification.rb' - - 'ee/app/models/concerns/ee/protected_ref_access.rb' - - 'ee/app/models/concerns/geo/verifiable_replicator.rb' - 'ee/app/models/dast/pre_scan_verification.rb' - 'ee/app/models/deployments/approval.rb' - 'ee/app/models/ee/application_setting.rb' @@ -1273,7 +1034,6 @@ Layout/ArgumentAlignment: - 'ee/app/models/scim_identity.rb' - 'ee/app/models/security/finding.rb' - 'ee/app/models/security/orchestration_policy_rule_schedule.rb' - - 'ee/app/models/slack_integration.rb' - 'ee/app/models/smartcard_identity.rb' - 'ee/app/models/status_page/project_setting.rb' - 'ee/app/models/vulnerabilities/external_issue_link.rb' @@ -1284,8 +1044,6 @@ Layout/ArgumentAlignment: - 'ee/app/models/vulnerabilities/read.rb' - 'ee/app/models/vulnerabilities/stat_diff.rb' - 'ee/app/models/vulnerabilities/statistic.rb' - - 'ee/app/serializers/blocking_merge_request_entity.rb' - - 'ee/app/serializers/dashboard_environment_entity.rb' - 'ee/app/services/analytics/devops_adoption/enabled_namespaces/bulk_find_or_create_service.rb' - 'ee/app/services/audit_events/streaming/event_type_filters/destroy_service.rb' - 'ee/app/services/auto_merge/merge_train_service.rb' @@ -1324,59 +1082,15 @@ Layout/ArgumentAlignment: - 'ee/app/services/vulnerabilities/starboard_vulnerability_resolve_service.rb' - 'ee/app/services/vulnerability_feedback/create_service.rb' - 'ee/app/services/vulnerability_merge_request_links/create_service.rb' - - 'ee/app/workers/audit_events/audit_event_streaming_worker.rb' - - 'ee/app/workers/audit_events/user_impersonation_event_create_worker.rb' - - 'ee/app/workers/concerns/geo/base_registry_sync_worker.rb' - - 'ee/app/workers/elastic/project_transfer_worker.rb' - - 'ee/app/workers/groups/export_memberships_worker.rb' - - 'ee/config/routes/admin.rb' - - 'ee/config/routes/group.rb' - - 'ee/config/routes/project.rb' - - 'ee/config/routes/uploads.rb' - - 'ee/config/routes/user.rb' - 'ee/db/geo/migrate/20180405074130_add_partial_index_project_repository_verification.rb' - 'ee/db/geo/post_migrate/20210217020154_add_unique_index_on_container_repository_registry.rb' - 'ee/db/geo/post_migrate/20210217020156_add_unique_index_on_terraform_state_version_registry.rb' - 'ee/db/seeds/awesome_co/awesome_co.rb' - - 'ee/lib/api/analytics/code_review_analytics.rb' - - 'ee/lib/api/analytics/product_analytics.rb' - - 'ee/lib/api/audit_events.rb' - - 'ee/lib/api/dependencies.rb' - - 'ee/lib/api/epics.rb' - - 'ee/lib/api/group_push_rule.rb' - - 'ee/lib/api/helpers/project_approval_rules_helpers.rb' - - 'ee/lib/api/ldap_group_links.rb' - - 'ee/lib/api/merge_request_approval_settings.rb' - - 'ee/lib/api/merge_trains.rb' - - 'ee/lib/api/project_aliases.rb' - - 'ee/lib/api/project_push_rule.rb' - - 'ee/lib/api/related_epic_links.rb' - - 'ee/lib/api/saml_group_links.rb' - - 'ee/lib/api/status_checks.rb' - - 'ee/lib/api/vulnerability_exports.rb' - - 'ee/lib/api/vulnerability_findings.rb' - - 'ee/lib/api/vulnerability_issue_links.rb' - 'ee/lib/audit/compliance_framework_changes_auditor.rb' - 'ee/lib/audit/external_status_check_changes_auditor.rb' - 'ee/lib/audit/group_changes_auditor.rb' - 'ee/lib/audit/group_push_rules_changes_auditor.rb' - 'ee/lib/audit/project_changes_auditor.rb' - - 'ee/lib/ee/api/entities/approval_rule.rb' - - 'ee/lib/ee/api/entities/epic_issue.rb' - - 'ee/lib/ee/api/entities/epic_issue_link.rb' - - 'ee/lib/ee/api/entities/group.rb' - - 'ee/lib/ee/api/entities/group_detail.rb' - - 'ee/lib/ee/api/entities/group_push_rule.rb' - - 'ee/lib/ee/api/entities/member.rb' - - 'ee/lib/ee/api/entities/merge_request_approval_state.rb' - - 'ee/lib/ee/api/entities/merge_request_approval_state_rule.rb' - - 'ee/lib/ee/api/entities/merge_train.rb' - - 'ee/lib/ee/api/entities/project.rb' - - 'ee/lib/ee/api/groups.rb' - - 'ee/lib/ee/api/helpers/issues_helpers.rb' - - 'ee/lib/ee/api/members.rb' - - 'ee/lib/ee/api/merge_request_approvals.rb' - - 'ee/lib/ee/api/projects.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_epic_cache_counts.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size.rb' @@ -1401,51 +1115,15 @@ Layout/ArgumentAlignment: - 'ee/lib/gitlab/status_page/pipeline/post_process_pipeline.rb' - 'ee/lib/gitlab/subscription_portal/clients/graphql.rb' - 'ee/lib/gitlab/zoekt/search_results.rb' - - 'ee/lib/slack/block_kit/app_home_opened.rb' - 'ee/spec/components/billing/plan_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/notification_alert_component_spec.rb' - 'ee/spec/components/namespaces/storage/pre_enforcement_alert_component_spec.rb' - - 'ee/spec/controllers/ee/admin/sessions_controller_spec.rb' - - 'ee/spec/controllers/ee/search_controller_spec.rb' - - 'ee/spec/controllers/groups/analytics/cycle_analytics/stages_controller_spec.rb' - - 'ee/spec/controllers/groups/epic_boards_controller_spec.rb' - - 'ee/spec/controllers/groups/group_members_controller_spec.rb' - - 'ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb' - - 'ee/spec/controllers/groups/sso_controller_spec.rb' - - 'ee/spec/controllers/operations_controller_spec.rb' - - 'ee/spec/controllers/projects/approver_groups_controller_spec.rb' - - 'ee/spec/controllers/projects/approvers_controller_spec.rb' - - 'ee/spec/controllers/projects/branches_controller_spec.rb' - - 'ee/spec/controllers/projects/environments_controller_spec.rb' - - 'ee/spec/controllers/projects/imports_controller_spec.rb' - - 'ee/spec/controllers/projects/iterations_controller_spec.rb' - - 'ee/spec/controllers/projects/merge_requests/creations_controller_spec.rb' - - 'ee/spec/controllers/projects/protected_environments_controller_spec.rb' - - 'ee/spec/controllers/projects/repositories_controller_spec.rb' - - 'ee/spec/controllers/projects/security/sast_configuration_controller_spec.rb' - - 'ee/spec/controllers/projects/security/scanned_resources_controller_spec.rb' - - 'ee/spec/controllers/projects/settings/ci_cd_controller_spec.rb' - - 'ee/spec/controllers/projects/settings/merge_requests_controller_spec.rb' - - 'ee/spec/controllers/projects/settings/operations_controller_spec.rb' - - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - - 'ee/spec/controllers/projects_controller_spec.rb' - - 'ee/spec/controllers/trials_controller_spec.rb' - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/elastic/migrate/20221124090600_add_namespace_ancestry_ids_to_original_index_mapping_spec.rb' - 'ee/spec/elastic/migrate/20221221110300_backfill_traversal_ids_to_blobs_and_wiki_blobs_spec.rb' - - 'ee/spec/factories/epic_tree_nodes.rb' - - 'ee/spec/factories/groups.rb' - - 'ee/spec/factories/import_states.rb' - - 'ee/spec/factories/merge_requests.rb' - - 'ee/spec/factories/namespaces.rb' - - 'ee/spec/factories/projects.rb' - - 'ee/spec/factories/security_scans.rb' - - 'ee/spec/factories/vulnerabilities/findings.rb' - 'ee/spec/features/account_recovery_regular_check_spec.rb' - 'ee/spec/features/admin/admin_emails_spec.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' - 'ee/spec/features/billings/billing_plans_spec.rb' - - 'ee/spec/features/billings/extend_reactivate_trial_spec.rb' - 'ee/spec/features/boards/boards_spec.rb' - 'ee/spec/features/boards/swimlanes/epics_swimlanes_drag_drop_spec.rb' - 'ee/spec/features/burndown_charts_spec.rb' @@ -1490,14 +1168,6 @@ Layout/ArgumentAlignment: - 'ee/spec/features/search/elastic/group_search_spec.rb' - 'ee/spec/features/security/project/discover_spec.rb' - 'ee/spec/features/users/identity_verification_spec.rb' - - 'ee/spec/finders/boards/milestones_finder_spec.rb' - - 'ee/spec/finders/epics/cross_hierarchy_ancestors_finder_spec.rb' - - 'ee/spec/finders/epics/cross_hierarchy_children_finder_spec.rb' - - 'ee/spec/finders/geo/project_registry_status_finder_spec.rb' - - 'ee/spec/finders/merge_requests_finder_spec.rb' - - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - - 'ee/spec/finders/security/training_providers/kontra_url_finder_spec.rb' - - 'ee/spec/finders/security/training_providers/secure_code_warrior_url_finder_spec.rb' - 'ee/spec/frontend/fixtures/dora/metrics.rb' - 'ee/spec/frontend/fixtures/oncall_schedule.rb' - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb' @@ -1521,14 +1191,6 @@ Layout/ArgumentAlignment: - 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb' - 'ee/spec/graphql/types/project_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_type_spec.rb' - - 'ee/spec/helpers/billing_plans_helper_spec.rb' - - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - - 'ee/spec/helpers/ee/namespace_user_cap_reached_alert_helper_spec.rb' - - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' - - 'ee/spec/helpers/ee/trial_registration_helper_spec.rb' - - 'ee/spec/helpers/license_monitoring_helper_spec.rb' - - 'ee/spec/helpers/projects_helper_spec.rb' - - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' - 'ee/spec/lib/analytics/group_activity_calculator_spec.rb' - 'ee/spec/lib/analytics/merge_request_metrics_calculator_spec.rb' - 'ee/spec/lib/api/entities/protected_environments/approval_rule_for_summary_spec.rb' @@ -1537,7 +1199,6 @@ Layout/ArgumentAlignment: - 'ee/spec/lib/audit/external_status_check_changes_auditor_spec.rb' - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' - 'ee/spec/lib/audit/protected_branches_changes_auditor_spec.rb' - - 'ee/spec/lib/banzai/filter/cross_project_issuable_information_filter_spec.rb' - 'ee/spec/lib/ee/api/entities/analytics/code_review/merge_request_spec.rb' - 'ee/spec/lib/ee/api/entities/geo_node_status_spec.rb' - 'ee/spec/lib/ee/gitlab/analytics/cycle_analytics/aggregated/base_query_builder_spec.rb' @@ -1556,9 +1217,7 @@ Layout/ArgumentAlignment: - 'ee/spec/lib/ee/gitlab/background_migration/populate_approval_project_rules_with_security_orchestration_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/purge_stale_security_scans_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config/entry/bridge_spec.rb' @@ -1582,7 +1241,6 @@ Layout/ArgumentAlignment: - 'ee/spec/lib/gitlab/auth/otp/session_enforcer_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/certificate_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb' - 'ee/spec/lib/gitlab/ci/project_config_spec.rb' @@ -1610,17 +1268,7 @@ Layout/ArgumentAlignment: - 'ee/spec/lib/gitlab/zoekt/search_results_spec.rb' - 'ee/spec/lib/incident_management/oncall_shift_generator_spec.rb' - 'ee/spec/lib/omni_auth/strategies/group_saml_spec.rb' - - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/models/approval_wrapped_code_owner_rule_spec.rb' - - 'ee/spec/models/ci/bridge_spec.rb' - - 'ee/spec/models/ci/build_spec.rb' - - 'ee/spec/models/concerns/elastic/issue_spec.rb' - - 'ee/spec/models/concerns/elastic/merge_request_spec.rb' - - 'ee/spec/models/concerns/elastic/note_spec.rb' - - 'ee/spec/models/concerns/elastic/project_spec.rb' - - 'ee/spec/models/concerns/elastic/repository_spec.rb' - - 'ee/spec/models/concerns/elastic/snippet_spec.rb' - 'ee/spec/models/dast/pre_scan_verification_step_spec.rb' - 'ee/spec/models/dast_site_profile_spec.rb' - 'ee/spec/models/deployments/approval_summary_spec.rb' @@ -1656,14 +1304,6 @@ Layout/ArgumentAlignment: - 'ee/spec/models/upload_spec.rb' - 'ee/spec/models/vulnerabilities/finding_spec.rb' - 'ee/spec/models/vulnerabilities/state_transition_spec.rb' - - 'ee/spec/policies/dast/pre_scan_verification_policy_spec.rb' - - 'ee/spec/policies/dast/pre_scan_verification_step_policy_spec.rb' - - 'ee/spec/policies/deployment_policy_spec.rb' - - 'ee/spec/policies/epic_policy_spec.rb' - - 'ee/spec/policies/merge_request_policy_spec.rb' - - 'ee/spec/policies/vulnerabilities/feedback_policy_spec.rb' - - 'ee/spec/policies/vulnerabilities/merge_request_link_policy_spec.rb' - - 'ee/spec/presenters/ci/pipeline_presenter_spec.rb' - 'ee/spec/requests/admin/impersonation_tokens_controller_spec.rb' - 'ee/spec/requests/api/analytics/product_analytics_spec.rb' - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' @@ -1743,37 +1383,17 @@ Layout/ArgumentAlignment: - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' - 'ee/spec/requests/groups/settings/domain_verification_controller_spec.rb' - 'ee/spec/requests/groups/two_factor_auths_controller_spec.rb' - - 'ee/spec/requests/projects/analytics/cycle_analytics/stages_controller_spec.rb' - - 'ee/spec/requests/projects/mirrors_controller_spec.rb' - - 'ee/spec/requests/projects/on_demand_scans_controller_spec.rb' - - 'ee/spec/requests/projects/security/dast_configuration_controller_spec.rb' - - 'ee/spec/requests/projects/security/dast_profiles_controller_spec.rb' - 'ee/spec/requests/registrations/project_creation_spec.rb' - 'ee/spec/requests/smartcard_controller_spec.rb' - 'ee/spec/requests/users/identity_verification_controller_spec.rb' - - 'ee/spec/routing/webhook_routes_spec.rb' - - 'ee/spec/serializers/pipeline_serializer_spec.rb' - - 'ee/spec/serializers/vulnerabilities/finding_entity_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/aggregator_service_spec.rb' - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/find_or_create_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/create_service_spec.rb' - - 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scan_configs/build_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scanner_profiles/create_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scanner_profiles/destroy_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scanner_profiles/update_service_spec.rb' - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/streaming/event_type_filters/create_service_spec.rb' - 'ee/spec/services/audit_events/streaming/event_type_filters/destroy_service_spec.rb' - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' - 'ee/spec/services/boards/lists/update_service_spec.rb' - - 'ee/spec/services/ci/process_pipeline_service_spec.rb' - - 'ee/spec/services/ci/retry_pipeline_service_spec.rb' - - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb' - - 'ee/spec/services/ci_cd/github_integration_setup_service_spec.rb' - - 'ee/spec/services/ci_cd/github_setup_service_spec.rb' - 'ee/spec/services/ee/boards/issues/create_service_spec.rb' - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' - 'ee/spec/services/ee/boards/issues/move_service_spec.rb' @@ -1788,7 +1408,6 @@ Layout/ArgumentAlignment: - 'ee/spec/services/ee/vulnerability_feedback_module/update_service_spec.rb' - 'ee/spec/services/elastic/process_bookkeeping_service_spec.rb' - 'ee/spec/services/epics/issue_promote_service_spec.rb' - - 'ee/spec/services/epics/tree_reorder_service_spec.rb' - 'ee/spec/services/geo/blob_upload_service_spec.rb' - 'ee/spec/services/geo/framework_repository_sync_service_spec.rb' - 'ee/spec/services/geo/hashed_storage_attachments_migration_service_spec.rb' @@ -1802,11 +1421,6 @@ Layout/ArgumentAlignment: - 'ee/spec/services/groups/restore_service_spec.rb' - 'ee/spec/services/issue_feature_flags/list_service_spec.rb' - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - - 'ee/spec/services/merge_requests/build_service_spec.rb' - - 'ee/spec/services/projects/create_service_spec.rb' - - 'ee/spec/services/projects/gitlab_projects_import_service_spec.rb' - - 'ee/spec/services/projects/prometheus/alerts/notify_service_spec.rb' - - 'ee/spec/services/projects/restore_service_spec.rb' - 'ee/spec/services/protected_environments/create_service_spec.rb' - 'ee/spec/services/protected_environments/update_service_spec.rb' - 'ee/spec/services/quick_actions/interpret_service_spec.rb' @@ -1837,41 +1451,7 @@ Layout/ArgumentAlignment: - 'ee/spec/services/vulnerabilities/user_notes_count_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' - 'ee/spec/services/vulnerability_merge_request_links/create_service_spec.rb' - - 'ee/spec/support/helpers/vulnerability_helpers.rb' - - 'ee/spec/support/shared_examples/audit/audit_event_type_stream_shared_examples.rb' - - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/credentials_inventory_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb' - - 'ee/spec/support/shared_examples/finders/security/findings_finder_shared_examples.rb' - - 'ee/spec/support/shared_examples/graphql/dast/dast_profile_schedule_shared_examples.rb' - - 'ee/spec/support/shared_examples/graphql/mutations/set_multiple_assignees_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/search_service_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/vulnerabilities/removes_dismissal_feedback_from_associated_findings_shared_example.rb' - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' - - 'ee/spec/views/admin/application_settings/_deletion_protection_settings.html.haml_spec.rb' - - 'ee/spec/views/admin/application_settings/_git_abuse_rate_limit.html.haml_spec.rb' - - 'ee/spec/views/admin/dashboard/index.html.haml_spec.rb' - - 'ee/spec/views/admin/identities/index.html.haml_spec.rb' - - 'ee/spec/views/groups/edit.html.haml_spec.rb' - - 'ee/spec/views/projects/edit.html.haml_spec.rb' - - 'ee/spec/workers/adjourned_group_deletion_worker_spec.rb' - - 'ee/spec/workers/analytics/cycle_analytics/consistency_worker_spec.rb' - - 'ee/spec/workers/analytics/devops_adoption/create_snapshot_worker_spec.rb' - - 'ee/spec/workers/audit_events/audit_event_streaming_worker_spec.rb' - - 'ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb' - - 'ee/spec/workers/create_github_webhook_worker_spec.rb' - - 'ee/spec/workers/ee/projects/inactive_projects_deletion_cron_worker_spec.rb' - - 'ee/spec/workers/ee/repository_check/batch_worker_spec.rb' - - 'ee/spec/workers/elastic_index_bulk_cron_worker_spec.rb' - - 'ee/spec/workers/elastic_index_initial_bulk_cron_worker_spec.rb' - - 'ee/spec/workers/epics/update_cached_metadata_worker_spec.rb' - - 'ee/spec/workers/namespaces/sync_namespace_name_worker_spec.rb' - - 'ee/spec/workers/pull_mirrors/reenable_configuration_worker_spec.rb' - - 'ee/spec/workers/repository_update_mirror_worker_spec.rb' - - 'ee/spec/workers/security/orchestration_policy_rule_schedule_namespace_worker_spec.rb' - - 'ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb' - - 'ee/spec/workers/security/process_scan_result_policy_worker_spec.rb' - 'lib/api/access_requests.rb' - 'lib/api/admin/plan_limits.rb' - 'lib/api/alert_management_alerts.rb' @@ -1987,26 +1567,12 @@ Layout/ArgumentAlignment: - 'lib/api/users.rb' - 'lib/api/v3/github.rb' - 'lib/backup/manager.rb' - - 'lib/banzai/filter/references/abstract_reference_filter.rb' - - 'lib/banzai/filter/references/commit_range_reference_filter.rb' - - 'lib/banzai/filter/references/commit_reference_filter.rb' - - 'lib/banzai/filter/references/merge_request_reference_filter.rb' - - 'lib/banzai/filter/references/snippet_reference_filter.rb' - 'lib/bitbucket_server/connection.rb' - 'lib/gem_extensions/active_record/disable_joins/associations/association_scope.rb' - 'lib/generators/gitlab/partitioning/foreign_keys_generator.rb' - 'lib/gitlab/alert_management/payload/managed_prometheus.rb' - 'lib/gitlab/alert_management/payload/prometheus.rb' - 'lib/gitlab/auth/ldap/adapter.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - - 'lib/gitlab/background_migration/disable_legacy_open_source_license_for_no_issues_no_repo_projects.rb' - - 'lib/gitlab/background_migration/disable_legacy_open_source_license_for_one_member_no_repo_projects.rb' - - 'lib/gitlab/background_migration/encrypt_integration_properties.rb' - - 'lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics.rb' - - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - - 'lib/gitlab/background_migration/reset_status_on_container_repositories.rb' - - 'lib/gitlab/bare_repository_import/importer.rb' - 'lib/gitlab/bitbucket_server_import/importer.rb' - 'lib/gitlab/chat/command.rb' - 'lib/gitlab/ci/ansi2json/line.rb' @@ -2090,7 +1656,6 @@ Layout/ArgumentAlignment: - 'lib/gitlab/import_export/snippets_repo_restorer.rb' - 'lib/gitlab/import_export/snippets_repo_saver.rb' - 'lib/gitlab/issuable/clone/copy_resource_events_service.rb' - - 'lib/gitlab/legacy_github_import/importer.rb' - 'lib/gitlab/mail_room.rb' - 'lib/gitlab/markdown_cache/redis/store.rb' - 'lib/gitlab/memory/reports_uploader.rb' @@ -2098,12 +1663,6 @@ Layout/ArgumentAlignment: - 'lib/gitlab/metrics/dashboard/importers/prometheus_metrics.rb' - 'lib/gitlab/metrics/requests_rack_middleware.rb' - 'lib/gitlab/other_markup.rb' - - 'lib/gitlab/phabricator_import/cache/map.rb' - - 'lib/gitlab/phabricator_import/conduit/maniphest.rb' - - 'lib/gitlab/phabricator_import/conduit/response.rb' - - 'lib/gitlab/phabricator_import/conduit/user.rb' - - 'lib/gitlab/phabricator_import/issues/importer.rb' - - 'lib/gitlab/phabricator_import/user_finder.rb' - 'lib/gitlab/project_authorizations.rb' - 'lib/gitlab/redis/multi_store.rb' - 'lib/gitlab/request_context.rb' @@ -2113,7 +1672,6 @@ Layout/ArgumentAlignment: - 'lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb' - 'lib/gitlab/setup_helper.rb' - 'lib/gitlab/sidekiq_config/worker.rb' - - 'lib/gitlab/sidekiq_daemon/memory_killer.rb' - 'lib/gitlab/spamcheck/client.rb' - 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb' - 'lib/gitlab/usage_data.rb' @@ -2161,14 +1719,8 @@ Layout/ArgumentAlignment: - 'qa/qa/specs/features/api/3_create/repository/project_archive_compare_spec.rb' - 'qa/qa/specs/features/api/3_create/repository/tag_revision_trigger_prereceive_hook_spec.rb' - 'qa/qa/specs/features/api/4_verify/api_variable_inheritance_with_forward_pipeline_variables_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/group/group_member_access_request_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/group/transfer_group_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/group/transfer_project_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/integrations/jenkins/jenkins_build_status_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/integrations/jira/jira_basic_integration_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/dashboard_images_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/view_project_activity_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/parent_group_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/pages/new_static_page_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_content_creation_spec.rb' @@ -2179,8 +1731,8 @@ Layout/ArgumentAlignment: - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_ssh_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/source_editor/source_editor_toolbar_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/add_file_template_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide_new/add_new_directory_in_web_ide_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide/add_new_directory_in_web_ide_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/add_file_template_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_with_image_pull_policy_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_project_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' @@ -2228,7 +1780,6 @@ Layout/ArgumentAlignment: - 'qa/qa/specs/features/ee/browser_ui/15_growth/free_trial_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/group_wiki/delete_group_wiki_page_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' @@ -2248,75 +1799,6 @@ Layout/ArgumentAlignment: - 'spec/components/previews/pajamas/alert_component_preview.rb' - 'spec/components/previews/pajamas/banner_component_preview.rb' - 'spec/components/previews/pajamas/button_component_preview.rb' - - 'spec/controllers/admin/spam_logs_controller_spec.rb' - - 'spec/controllers/admin/users_controller_spec.rb' - - 'spec/controllers/concerns/analytics/cycle_analytics/value_stream_actions_spec.rb' - - 'spec/controllers/concerns/continue_params_spec.rb' - - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' - - 'spec/controllers/concerns/product_analytics_tracking_spec.rb' - - 'spec/controllers/concerns/renders_commits_spec.rb' - - 'spec/controllers/confirmations_controller_spec.rb' - - 'spec/controllers/every_controller_spec.rb' - - 'spec/controllers/graphql_controller_spec.rb' - - 'spec/controllers/groups/group_members_controller_spec.rb' - - 'spec/controllers/groups/milestones_controller_spec.rb' - - 'spec/controllers/groups/variables_controller_spec.rb' - - 'spec/controllers/help_controller_spec.rb' - - 'spec/controllers/import/bitbucket_controller_spec.rb' - - 'spec/controllers/import/bulk_imports_controller_spec.rb' - - 'spec/controllers/import/fogbugz_controller_spec.rb' - - 'spec/controllers/oauth/authorizations_controller_spec.rb' - - 'spec/controllers/oauth/jira_dvcs/authorizations_controller_spec.rb' - - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - - 'spec/controllers/passwords_controller_spec.rb' - - 'spec/controllers/profiles_controller_spec.rb' - - 'spec/controllers/projects/artifacts_controller_spec.rb' - - 'spec/controllers/projects/blame_controller_spec.rb' - - 'spec/controllers/projects/blob_controller_spec.rb' - - 'spec/controllers/projects/branches_controller_spec.rb' - - 'spec/controllers/projects/clusters_controller_spec.rb' - - 'spec/controllers/projects/commit_controller_spec.rb' - - 'spec/controllers/projects/commits_controller_spec.rb' - - 'spec/controllers/projects/cycle_analytics_controller_spec.rb' - - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - - 'spec/controllers/projects/deployments_controller_spec.rb' - - 'spec/controllers/projects/design_management/designs/resized_image_controller_spec.rb' - - 'spec/controllers/projects/environments_controller_spec.rb' - - 'spec/controllers/projects/feature_flags_controller_spec.rb' - - 'spec/controllers/projects/find_file_controller_spec.rb' - - 'spec/controllers/projects/forks_controller_spec.rb' - - 'spec/controllers/projects/grafana_api_controller_spec.rb' - - 'spec/controllers/projects/issues_controller_spec.rb' - - 'spec/controllers/projects/jobs_controller_spec.rb' - - 'spec/controllers/projects/mattermosts_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/creations_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/diffs_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb' - - 'spec/controllers/projects/merge_requests_controller_spec.rb' - - 'spec/controllers/projects/notes_controller_spec.rb' - - 'spec/controllers/projects/pipelines_controller_spec.rb' - - 'spec/controllers/projects/prometheus/alerts_controller_spec.rb' - - 'spec/controllers/projects/raw_controller_spec.rb' - - 'spec/controllers/projects/refs_controller_spec.rb' - - 'spec/controllers/projects/registry/repositories_controller_spec.rb' - - 'spec/controllers/projects/registry/tags_controller_spec.rb' - - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - - 'spec/controllers/projects/settings/merge_requests_controller_spec.rb' - - 'spec/controllers/projects/snippets/blobs_controller_spec.rb' - - 'spec/controllers/projects/snippets_controller_spec.rb' - - 'spec/controllers/projects/tree_controller_spec.rb' - - 'spec/controllers/projects_controller_spec.rb' - - 'spec/controllers/registrations_controller_spec.rb' - - 'spec/controllers/search_controller_spec.rb' - - 'spec/controllers/sessions_controller_spec.rb' - - 'spec/controllers/snippets/blobs_controller_spec.rb' - - 'spec/factories/ci/processable.rb' - - 'spec/factories/draft_note.rb' - - 'spec/factories/environments.rb' - - 'spec/factories/group_members.rb' - - 'spec/factories/ml/candidates.rb' - - 'spec/factories/notes.rb' - 'spec/features/admin/admin_mode/login_spec.rb' - 'spec/features/admin/integrations/user_activates_mattermost_slash_command_spec.rb' - 'spec/features/atom/issues_spec.rb' @@ -2423,21 +1905,10 @@ Layout/ArgumentAlignment: - 'spec/features/snippets/spam_snippets_spec.rb' - 'spec/features/snippets/user_creates_snippet_spec.rb' - 'spec/features/task_lists_spec.rb' - - 'spec/features/u2f_spec.rb' - 'spec/features/user_sees_revert_modal_spec.rb' - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/features/users/overview_spec.rb' - - 'spec/finders/alert_management/alerts_finder_spec.rb' - - 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb' - - 'spec/finders/deployments_finder_spec.rb' - - 'spec/finders/group_descendants_finder_spec.rb' - - 'spec/finders/groups/accepting_group_transfers_finder_spec.rb' - - 'spec/finders/groups/accepting_project_transfers_finder_spec.rb' - - 'spec/finders/merge_requests_finder_spec.rb' - - 'spec/finders/notes_finder_spec.rb' - - 'spec/finders/snippets_finder_spec.rb' - - 'spec/finders/users_finder_spec.rb' - 'spec/frontend/fixtures/autocomplete.rb' - 'spec/frontend/fixtures/autocomplete_sources.rb' - 'spec/frontend/fixtures/environments.rb' @@ -2473,30 +1944,12 @@ Layout/ArgumentAlignment: - 'spec/graphql/types/project_type_spec.rb' - 'spec/graphql/types/root_storage_statistics_type_spec.rb' - 'spec/graphql/types/todo_type_spec.rb' - - 'spec/helpers/avatars_helper_spec.rb' - - 'spec/helpers/emoji_helper_spec.rb' - - 'spec/helpers/feature_flags_helper_spec.rb' - - 'spec/helpers/ide_helper_spec.rb' - - 'spec/helpers/namespaces_helper_spec.rb' - - 'spec/helpers/notify_helper_spec.rb' - - 'spec/helpers/page_layout_helper_spec.rb' - - 'spec/helpers/routing/pseudonymization_helper_spec.rb' - - 'spec/helpers/storage_helper_spec.rb' - - 'spec/helpers/todos_helper_spec.rb' - - 'spec/helpers/users/callouts_helper_spec.rb' - - 'spec/helpers/users/group_callouts_helper_spec.rb' - - 'spec/helpers/visibility_level_helper_spec.rb' - 'spec/initializers/00_rails_disable_joins_spec.rb' - 'spec/initializers/secret_token_spec.rb' - 'spec/lib/api/every_api_endpoint_spec.rb' - 'spec/lib/atlassian/jira_connect/client_spec.rb' - - 'spec/lib/atlassian/jira_connect/serializers/feature_flag_entity_spec.rb' - 'spec/lib/backup/dump/postgres_spec.rb' - 'spec/lib/backup/manager_spec.rb' - - 'spec/lib/banzai/filter/kroki_filter_spec.rb' - - 'spec/lib/banzai/filter/references/design_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/syntax_highlight_filter_spec.rb' - - 'spec/lib/banzai/reference_redactor_spec.rb' - 'spec/lib/bulk_imports/common/pipelines/lfs_objects_pipeline_spec.rb' - 'spec/lib/container_registry/blob_spec.rb' - 'spec/lib/container_registry/migration_spec.rb' @@ -2517,21 +1970,6 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb' - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' - - 'spec/lib/gitlab/auth/u2f_webauthn_converter_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_cluster_agents_has_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_environment_tiers_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_group_features_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_details_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_id_of_vulnerability_reads_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_project_feature_package_registry_access_level_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_project_member_namespace_id_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_project_namespace_details_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_releases_author_id_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb' - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb' @@ -2546,26 +1984,10 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_one_member_no_repo_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_projects_less_than_five_mb_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_projects_less_than_one_mb_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb' - 'spec/lib/gitlab/background_migration/expire_o_auth_tokens_spec.rb' - - 'spec/lib/gitlab/background_migration/extract_project_topics_into_separate_table_spec.rb' - 'spec/lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_shimo_confluence_integration_category_spec.rb' - - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' - - 'spec/lib/gitlab/background_migration/prune_stale_project_export_jobs_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_backfilled_job_artifacts_expire_at_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_self_managed_wiki_notes_spec.rb' - - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb' - - 'spec/lib/gitlab/background_migration/set_correct_vulnerability_state_spec.rb' - - 'spec/lib/gitlab/background_migration/set_legacy_open_source_license_available_for_non_public_projects_spec.rb' - - 'spec/lib/gitlab/background_migration/update_delayed_project_removal_to_null_for_user_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_import/project_creator_spec.rb' - 'spec/lib/gitlab/bitbucket_import/wiki_formatter_spec.rb' @@ -2685,15 +2107,9 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/middleware/multipart_spec.rb' - 'spec/lib/gitlab/pagination_delegate_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' - - 'spec/lib/gitlab/phabricator_import/cache/map_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/maniphest_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb' - 'spec/lib/gitlab/profiler_spec.rb' - 'spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/redis/sidekiq_status_spec.rb' - 'spec/lib/gitlab/repository_cache/preloader_spec.rb' - 'spec/lib/gitlab/repository_cache_spec.rb' @@ -2710,7 +2126,6 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/suggestions/commit_message_spec.rb' - 'spec/lib/gitlab/suggestions/file_suggestion_spec.rb' - 'spec/lib/gitlab/suggestions/suggestion_set_spec.rb' - - 'spec/lib/gitlab/template/finders/global_template_finder_spec.rb' - 'spec/lib/gitlab/tracking/destinations/snowplow_spec.rb' - 'spec/lib/gitlab/usage/metrics/aggregates/sources/postgres_hll_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/count_ci_internal_pipelines_metric_spec.rb' @@ -2729,84 +2144,6 @@ Layout/ArgumentAlignment: - 'spec/lib/security/weak_passwords_spec.rb' - 'spec/lib/sidebars/projects/menus/repository_menu_spec.rb' - 'spec/lib/uploaded_file_spec.rb' - - 'spec/mailers/emails/merge_requests_spec.rb' - - 'spec/mailers/emails/pipelines_spec.rb' - - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20210918201050_remove_old_pending_jobs_for_recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/migrations/20211110151350_schedule_drop_invalid_security_findings_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20211207125331_remove_jobs_for_recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/migrations/20220124130028_dedup_runner_projects_spec.rb' - - 'spec/migrations/20220128155251_remove_dangling_running_builds_spec.rb' - - 'spec/migrations/20220307192610_remove_duplicate_project_tag_releases_spec.rb' - - 'spec/migrations/20220310141349_remove_dependency_list_usage_data_from_redis_spec.rb' - - 'spec/migrations/20220324032250_migrate_shimo_confluence_service_category_spec.rb' - - 'spec/migrations/20220505044348_fix_automatic_iterations_cadences_start_date_spec.rb' - - 'spec/migrations/20220601152916_add_user_id_and_ip_address_success_index_to_authentication_events_spec.rb' - - 'spec/migrations/20220606082910_add_tmp_index_for_potentially_misassociated_vulnerability_occurrences_spec.rb' - - 'spec/migrations/20220607082910_add_sync_tmp_index_for_potentially_misassociated_vulnerability_occurrences_spec.rb' - - 'spec/migrations/20220801155858_schedule_disable_legacy_open_source_licence_for_recent_public_projects_spec.rb' - - 'spec/migrations/20220816163444_update_start_date_for_iterations_cadences_spec.rb' - - 'spec/migrations/20220819153725_add_vulnerability_advisory_foreign_key_to_sbom_vulnerable_component_versions_spec.rb' - - 'spec/migrations/20220819162852_add_sbom_component_version_foreign_key_to_sbom_vulnerable_component_versions_spec.rb' - - 'spec/migrations/20220921144258_remove_orphan_group_token_users_spec.rb' - - 'spec/migrations/20220928225711_schedule_update_ci_pipeline_artifacts_locked_status_spec.rb' - - 'spec/migrations/20221018050323_add_objective_and_keyresult_to_work_item_types_spec.rb' - - 'spec/migrations/20221215151822_schedule_backfill_releases_author_id_spec.rb' - - 'spec/migrations/20221221110733_remove_temp_index_for_project_statistics_upload_size_migration_spec.rb' - - 'spec/migrations/20230105172120_sync_new_amount_used_with_amount_used_on_ci_namespace_monthly_usages_table_spec.rb' - - 'spec/migrations/cleanup_backfill_integrations_enable_ssl_verification_spec.rb' - - 'spec/migrations/cleanup_vulnerability_state_transitions_with_same_from_state_to_state_spec.rb' - - 'spec/migrations/delete_migrate_shared_vulnerability_scanners_spec.rb' - - 'spec/migrations/schedule_backfill_draft_status_on_merge_requests_corrected_regex_spec.rb' - - 'spec/migrations/schedule_fixing_security_scan_statuses_spec.rb' - - 'spec/migrations/schedule_purging_stale_security_scans_spec.rb' - - 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'spec/migrations/set_email_confirmation_setting_before_removing_send_user_confirmation_email_column_spec.rb' - - 'spec/migrations/start_backfill_ci_queuing_tables_spec.rb' - - 'spec/migrations/sync_new_amount_used_for_ci_namespace_monthly_usages_spec.rb' - - 'spec/migrations/sync_new_amount_used_for_ci_project_monthly_usages_spec.rb' - - 'spec/migrations/update_application_settings_container_registry_exp_pol_worker_capacity_default_spec.rb' - - 'spec/migrations/update_application_settings_protected_paths_spec.rb' - - 'spec/migrations/update_default_scan_method_of_dast_site_profile_spec.rb' - - 'spec/models/analytics/cycle_analytics/stage_spec.rb' - - 'spec/models/application_setting_spec.rb' - - 'spec/models/ci/bridge_spec.rb' - - 'spec/models/ci/build_dependencies_spec.rb' - - 'spec/models/ci/build_metadata_spec.rb' - - 'spec/models/ci/build_spec.rb' - - 'spec/models/ci/build_trace_chunk_spec.rb' - - 'spec/models/ci/group_spec.rb' - - 'spec/models/ci/pipeline_spec.rb' - - 'spec/models/ci/processable_spec.rb' - - 'spec/models/ci/ref_spec.rb' - - 'spec/models/ci/secure_file_spec.rb' - - 'spec/models/ci/stage_spec.rb' - - 'spec/models/clusters/cluster_spec.rb' - - 'spec/models/clusters/kubernetes_namespace_spec.rb' - - 'spec/models/clusters/platforms/kubernetes_spec.rb' - - 'spec/models/commit_spec.rb' - - 'spec/models/concerns/ci/partitionable/switch_spec.rb' - - 'spec/models/concerns/ci/partitionable_spec.rb' - - 'spec/models/concerns/ci/track_environment_usage_spec.rb' - - 'spec/models/concerns/database_event_tracking_spec.rb' - - 'spec/models/concerns/deployment_platform_spec.rb' - - 'spec/models/concerns/issuable_spec.rb' - - 'spec/models/concerns/token_authenticatable_spec.rb' - - 'spec/models/container_repository_spec.rb' - - 'spec/models/deployment_spec.rb' - - 'spec/models/design_management/version_spec.rb' - - 'spec/models/diff_note_spec.rb' - - 'spec/models/environment_spec.rb' - - 'spec/models/environment_status_spec.rb' - - 'spec/models/event_collection_spec.rb' - - 'spec/models/event_spec.rb' - - 'spec/models/generic_commit_status_spec.rb' - - 'spec/models/group_group_link_spec.rb' - - 'spec/models/group_spec.rb' - - 'spec/models/integrations/apple_app_store_spec.rb' - - 'spec/models/integrations/buildkite_spec.rb' - - 'spec/models/integrations/hangouts_chat_spec.rb' - 'spec/models/integrations/mattermost_slash_commands_spec.rb' - 'spec/models/integrations/microsoft_teams_spec.rb' - 'spec/models/issue_spec.rb' @@ -2828,24 +2165,6 @@ Layout/ArgumentAlignment: - 'spec/models/project_team_spec.rb' - 'spec/models/release_spec.rb' - 'spec/models/remote_mirror_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/models/resource_state_event_spec.rb' - - 'spec/models/snippet_spec.rb' - - 'spec/models/spam_log_spec.rb' - - 'spec/models/u2f_registration_spec.rb' - - 'spec/models/upload_spec.rb' - - 'spec/models/user_detail_spec.rb' - - 'spec/models/user_spec.rb' - - 'spec/models/wiki_page/meta_spec.rb' - - 'spec/policies/ci/build_policy_spec.rb' - - 'spec/policies/ci/pipeline_policy_spec.rb' - - 'spec/policies/ci/pipeline_schedule_policy_spec.rb' - - 'spec/policies/environment_policy_spec.rb' - - 'spec/policies/group_policy_spec.rb' - - 'spec/presenters/blob_presenter_spec.rb' - - 'spec/presenters/ci/build_runner_presenter_spec.rb' - - 'spec/presenters/merge_request_presenter_spec.rb' - - 'spec/presenters/packages/detail/package_presenter_spec.rb' - 'spec/requests/admin/applications_controller_spec.rb' - 'spec/requests/admin/impersonation_tokens_controller_spec.rb' - 'spec/requests/api/access_requests_spec.rb' @@ -2884,10 +2203,6 @@ Layout/ArgumentAlignment: - 'spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb' - 'spec/requests/api/graphql/mutations/alert_management/alerts/create_alert_issue_spec.rb' - 'spec/requests/api/graphql/mutations/boards/issues/issue_move_list_spec.rb' - - 'spec/requests/api/graphql/mutations/ci/job_cancel_spec.rb' - - 'spec/requests/api/graphql/mutations/ci/job_play_spec.rb' - - 'spec/requests/api/graphql/mutations/ci/job_retry_spec.rb' - - 'spec/requests/api/graphql/mutations/ci/job_unschedule_spec.rb' - 'spec/requests/api/graphql/mutations/ci/pipeline_retry_spec.rb' - 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb' - 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb' @@ -2979,12 +2294,6 @@ Layout/ArgumentAlignment: - 'spec/requests/jwt_controller_spec.rb' - 'spec/requests/lfs_http_spec.rb' - 'spec/requests/oauth_tokens_spec.rb' - - 'spec/requests/projects/environments_controller_spec.rb' - - 'spec/requests/projects/incident_management/timeline_events_spec.rb' - - 'spec/requests/projects/issue_links_controller_spec.rb' - - 'spec/requests/projects/issues_controller_spec.rb' - - 'spec/requests/projects/merge_requests_controller_spec.rb' - - 'spec/requests/projects/merge_requests_spec.rb' - 'spec/requests/rack_attack_global_spec.rb' - 'spec/requests/recursive_webhook_detection_spec.rb' - 'spec/requests/users/group_callouts_spec.rb' @@ -2997,21 +2306,6 @@ Layout/ArgumentAlignment: - 'spec/rubocop/cop/rspec/env_mocking_spec.rb' - 'spec/rubocop/cop/style/regexp_literal_mixed_preserve_spec.rb' - 'spec/rubocop/formatter/graceful_formatter_spec.rb' - - 'spec/serializers/build_details_entity_spec.rb' - - 'spec/serializers/ci/downloadable_artifact_entity_spec.rb' - - 'spec/serializers/ci/job_entity_spec.rb' - - 'spec/serializers/ci/pipeline_entity_spec.rb' - - 'spec/serializers/discussion_diff_file_entity_spec.rb' - - 'spec/serializers/environment_entity_spec.rb' - - 'spec/serializers/environment_serializer_spec.rb' - - 'spec/serializers/group_child_entity_spec.rb' - - 'spec/serializers/issue_board_entity_spec.rb' - - 'spec/serializers/issue_entity_spec.rb' - - 'spec/serializers/merge_request_metrics_helper_spec.rb' - - 'spec/serializers/merge_request_poll_cached_widget_entity_spec.rb' - - 'spec/serializers/merge_request_poll_widget_entity_spec.rb' - - 'spec/serializers/pipeline_details_entity_spec.rb' - - 'spec/serializers/pipeline_serializer_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - 'spec/services/authorized_project_update/find_records_due_for_refresh_service_spec.rb' - 'spec/services/auto_merge/base_service_spec.rb' @@ -3020,24 +2314,6 @@ Layout/ArgumentAlignment: - 'spec/services/award_emojis/destroy_service_spec.rb' - 'spec/services/bulk_imports/create_service_spec.rb' - 'spec/services/bulk_imports/get_importable_data_service_spec.rb' - - 'spec/services/ci/archive_trace_service_spec.rb' - - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - - 'spec/services/ci/create_pipeline_service/include_spec.rb' - - 'spec/services/ci/create_pipeline_service/logger_spec.rb' - - 'spec/services/ci/create_pipeline_service/merge_requests_spec.rb' - - 'spec/services/ci/create_pipeline_service/partitioning_spec.rb' - - 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb' - - 'spec/services/ci/create_pipeline_service_spec.rb' - - 'spec/services/ci/job_artifacts/destroy_all_expired_service_spec.rb' - - 'spec/services/ci/job_artifacts/track_artifact_report_service_spec.rb' - - 'spec/services/ci/list_config_variables_service_spec.rb' - - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - - 'spec/services/ci/play_build_service_spec.rb' - - 'spec/services/ci/play_manual_stage_service_spec.rb' - - 'spec/services/ci/process_sync_events_service_spec.rb' - - 'spec/services/ci/retry_job_service_spec.rb' - - 'spec/services/ci/retry_pipeline_service_spec.rb' - - 'spec/services/ci/run_scheduled_build_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - 'spec/services/cohorts_service_spec.rb' @@ -3068,51 +2344,12 @@ Layout/ArgumentAlignment: - 'spec/services/issues/resolve_discussions_spec.rb' - 'spec/services/issues/update_service_spec.rb' - 'spec/services/loose_foreign_keys/batch_cleaner_service_spec.rb' - - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb' - - 'spec/services/merge_requests/assign_issues_service_spec.rb' - - 'spec/services/merge_requests/conflicts/resolve_service_spec.rb' - - 'spec/services/merge_requests/create_service_spec.rb' - - 'spec/services/merge_requests/ff_merge_service_spec.rb' - - 'spec/services/merge_requests/merge_orchestration_service_spec.rb' - - 'spec/services/merge_requests/merge_service_spec.rb' - - 'spec/services/merge_requests/merge_to_ref_service_spec.rb' - - 'spec/services/merge_requests/mergeability/detailed_merge_status_service_spec.rb' - - 'spec/services/merge_requests/mergeability_check_service_spec.rb' - - 'spec/services/merge_requests/rebase_service_spec.rb' - - 'spec/services/merge_requests/refresh_service_spec.rb' - - 'spec/services/merge_requests/reload_diffs_service_spec.rb' - - 'spec/services/merge_requests/squash_service_spec.rb' - - 'spec/services/merge_requests/update_assignees_service_spec.rb' - - 'spec/services/merge_requests/update_reviewers_service_spec.rb' - - 'spec/services/merge_requests/update_service_spec.rb' - 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb' - 'spec/services/note_summary_spec.rb' - - 'spec/services/notes/build_service_spec.rb' - - 'spec/services/notes/copy_service_spec.rb' - - 'spec/services/notes/create_service_spec.rb' - - 'spec/services/notes/destroy_service_spec.rb' - - 'spec/services/notes/render_service_spec.rb' - 'spec/services/notification_service_spec.rb' - 'spec/services/pages/migrate_legacy_storage_to_deployment_service_spec.rb' - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - 'spec/services/preview_markdown_service_spec.rb' - - 'spec/services/projects/all_merge_requests_count_service_spec.rb' - - 'spec/services/projects/container_repository/gitlab/cleanup_tags_service_spec.rb' - - 'spec/services/projects/container_repository/third_party/cleanup_tags_service_spec.rb' - - 'spec/services/projects/create_service_spec.rb' - - 'spec/services/projects/destroy_service_spec.rb' - - 'spec/services/projects/fork_service_spec.rb' - - 'spec/services/projects/group_links/create_service_spec.rb' - - 'spec/services/projects/group_links/destroy_service_spec.rb' - - 'spec/services/projects/group_links/update_service_spec.rb' - - 'spec/services/projects/hashed_storage/migration_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_link_service_spec.rb' - - 'spec/services/projects/open_merge_requests_count_service_spec.rb' - - 'spec/services/projects/prometheus/alerts/notify_service_spec.rb' - - 'spec/services/projects/transfer_service_spec.rb' - - 'spec/services/projects/unlink_fork_service_spec.rb' - - 'spec/services/projects/update_pages_service_spec.rb' - - 'spec/services/projects/update_service_spec.rb' - 'spec/services/protected_branches/api_service_spec.rb' - 'spec/services/push_event_payload_service_spec.rb' - 'spec/services/quick_actions/interpret_service_spec.rb' @@ -3137,66 +2374,10 @@ Layout/ArgumentAlignment: - 'spec/services/work_items/task_list_reference_removal_service_spec.rb' - 'spec/services/work_items/widgets/description_service/update_service_spec.rb' - 'spec/sidekiq/cron/job_gem_dependency_spec.rb' - - 'spec/support/helpers/api_internal_base_helpers.rb' - - 'spec/support/helpers/board_helpers.rb' - - 'spec/support/helpers/ci/source_pipeline_helpers.rb' - - 'spec/support/helpers/feature_flag_helpers.rb' - - 'spec/support/helpers/graphql_helpers.rb' - - 'spec/support/helpers/stub_object_storage.rb' - - 'spec/support/helpers/workhorse_helpers.rb' - - 'spec/support/import_export/export_file_helper.rb' - - 'spec/support/redis/redis_shared_examples.rb' - - 'spec/support/shared_contexts/bulk_imports_requests_shared_context.rb' - - 'spec/support/shared_contexts/design_management_shared_contexts.rb' - - 'spec/support/shared_contexts/finders/issues_finder_shared_contexts.rb' - - 'spec/support/shared_contexts/finders/merge_requests_finder_shared_contexts.rb' - - 'spec/support/shared_contexts/finders/work_items_finder_shared_contexts.rb' - - 'spec/support/shared_contexts/merge_request_create_shared_context.rb' - - 'spec/support/shared_contexts/merge_request_edit_shared_context.rb' - - 'spec/support/shared_contexts/merge_requests_allowing_collaboration_shared_context.rb' - - 'spec/support/shared_contexts/requests/api/graphql/releases_and_group_releases_shared_context.rb' - - 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb' - - 'spec/support/shared_examples/controllers/snippets_sort_order_shared_examples.rb' - - 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb' - - 'spec/support/shared_examples/features/search/redacted_search_results_shared_examples.rb' - - 'spec/support/shared_examples/features/wiki/user_views_wiki_page_shared_examples.rb' - - 'spec/support/shared_examples/finders/issues_finder_shared_examples.rb' - - 'spec/support/shared_examples/graphql/members_shared_examples.rb' - - 'spec/support/shared_examples/graphql/mutation_shared_examples.rb' - - 'spec/support/shared_examples/graphql/mutations/set_assignees_shared_examples.rb' - - 'spec/support/shared_examples/graphql/notes_on_noteables_shared_examples.rb' - 'spec/support/shared_examples/initializers/uses_gitlab_url_blocker_shared_examples.rb' - 'spec/support/shared_examples/integrations/integration_settings_form.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/database/background_migration_job_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/gitaly_client_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/project_search_results_shared_examples.rb' - - 'spec/support/shared_examples/lib/sentry/client_shared_examples.rb' - - 'spec/support/shared_examples/models/chat_integration_shared_examples.rb' - - 'spec/support/shared_examples/models/clusters/prometheus_client_shared.rb' - - 'spec/support/shared_examples/models/concerns/auto_disabling_hooks_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/cascading_namespace_setting_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/integrations/slack_mattermost_notifier_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/timebox_shared_examples.rb' - - 'spec/support/shared_examples/models/concerns/unstoppable_hooks_shared_examples.rb' - - 'spec/support/shared_examples/models/diff_note_after_commit_shared_examples.rb' - - 'spec/support/shared_examples/models/member_shared_examples.rb' - - 'spec/support/shared_examples/observability/csp_shared_examples.rb' - - 'spec/support/shared_examples/projects/container_repository/cleanup_tags_service_shared_examples.rb' - - 'spec/support/shared_examples/quick_actions/issuable/max_issuable_examples.rb' - - 'spec/support/shared_examples/requests/api/discussions_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/mutations/snippets_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/mutations/subscription_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/projects/branch_protections/access_level_request_examples.rb' - - 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/resolvable_discussions_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/time_tracking_shared_examples.rb' - - 'spec/support/shared_examples/requests/graphql_shared_examples.rb' - - 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb' - - 'spec/support/shared_examples/serializers/diff_file_entity_shared_examples.rb' - - 'spec/support/shared_examples/views/pipeline_status_changes_email.rb' - 'spec/tasks/cache/clear/redis_spec.rb' - 'spec/tasks/gitlab/cleanup_rake_spec.rb' - 'spec/tasks/gitlab/db/decomposition/rollback/bump_ci_sequences_rake_spec.rb' @@ -3204,67 +2385,4 @@ Layout/ArgumentAlignment: - 'spec/tasks/gitlab/sidekiq_rake_spec.rb' - 'spec/tooling/danger/sidekiq_queues_spec.rb' - 'spec/tooling/graphql/docs/renderer_spec.rb' - - 'spec/uploaders/attachment_uploader_spec.rb' - - 'spec/uploaders/avatar_uploader_spec.rb' - - 'spec/uploaders/ci/pipeline_artifact_uploader_spec.rb' - - 'spec/uploaders/dependency_proxy/file_uploader_spec.rb' - - 'spec/uploaders/design_management/design_v432x230_uploader_spec.rb' - - 'spec/uploaders/external_diff_uploader_spec.rb' - - 'spec/uploaders/file_uploader_spec.rb' - - 'spec/uploaders/job_artifact_uploader_spec.rb' - - 'spec/uploaders/lfs_object_uploader_spec.rb' - - 'spec/uploaders/packages/composer/cache_uploader_spec.rb' - - 'spec/uploaders/packages/debian/component_file_uploader_spec.rb' - - 'spec/uploaders/packages/debian/distribution_release_file_uploader_spec.rb' - - 'spec/uploaders/packages/package_file_uploader_spec.rb' - - 'spec/uploaders/packages/rpm/repository_file_uploader_spec.rb' - - 'spec/uploaders/pages/deployment_uploader_spec.rb' - - 'spec/uploaders/personal_file_uploader_spec.rb' - - 'spec/views/admin/application_settings/_ci_cd.html.haml_spec.rb' - - 'spec/views/admin/application_settings/_repository_check.html.haml_spec.rb' - - 'spec/views/ci/status/_badge.html.haml_spec.rb' - - 'spec/views/ci/status/_icon.html.haml_spec.rb' - - 'spec/views/devise/shared/_signup_box.html.haml_spec.rb' - - 'spec/views/notify/autodevops_disabled_email.text.erb_spec.rb' - - 'spec/views/notify/pipeline_failed_email.text.erb_spec.rb' - - 'spec/views/profiles/keys/_key.html.haml_spec.rb' - - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb' - - 'spec/views/projects/edit.html.haml_spec.rb' - - 'spec/views/projects/settings/merge_requests/show.html.haml_spec.rb' - - 'spec/views/projects/tags/index.html.haml_spec.rb' - - 'spec/views/shared/milestones/_issuables.html.haml_spec.rb' - - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - - 'spec/workers/authorized_project_update/user_refresh_over_user_range_worker_spec.rb' - - 'spec/workers/build_hooks_worker_spec.rb' - - 'spec/workers/build_queue_worker_spec.rb' - - 'spec/workers/ci/job_artifacts/track_artifact_report_worker_spec.rb' - - 'spec/workers/concerns/worker_context_spec.rb' - - 'spec/workers/deployments/hooks_worker_spec.rb' - - 'spec/workers/design_management/new_version_worker_spec.rb' - - 'spec/workers/every_sidekiq_worker_spec.rb' - - 'spec/workers/integrations/irker_worker_spec.rb' - - 'spec/workers/jira_connect/sync_branch_worker_spec.rb' - - 'spec/workers/jira_connect/sync_builds_worker_spec.rb' - - 'spec/workers/jira_connect/sync_deployments_worker_spec.rb' - - 'spec/workers/jira_connect/sync_feature_flags_worker_spec.rb' - - 'spec/workers/jira_connect/sync_merge_request_worker_spec.rb' - - 'spec/workers/jira_connect/sync_project_worker_spec.rb' - - 'spec/workers/merge_requests/delete_source_branch_worker_spec.rb' - - 'spec/workers/merge_requests/update_head_pipeline_worker_spec.rb' - - 'spec/workers/namespaces/root_statistics_worker_spec.rb' - - 'spec/workers/object_pool/destroy_worker_spec.rb' - - 'spec/workers/pipeline_hooks_worker_spec.rb' - - 'spec/workers/pipeline_metrics_worker_spec.rb' - - 'spec/workers/process_commit_worker_spec.rb' - - 'spec/workers/projects/inactive_projects_deletion_cron_worker_spec.rb' - - 'spec/workers/projects/inactive_projects_deletion_notification_worker_spec.rb' - - 'spec/workers/rebase_worker_spec.rb' - - 'spec/workers/remote_mirror_notification_worker_spec.rb' - - 'spec/workers/remove_expired_members_worker_spec.rb' - - 'spec/workers/remove_unaccepted_member_invites_worker_spec.rb' - - 'spec/workers/remove_unreferenced_lfs_objects_worker_spec.rb' - - 'spec/workers/repository_update_remote_mirror_worker_spec.rb' - - 'spec/workers/run_pipeline_schedule_worker_spec.rb' - - 'spec/workers/update_head_pipeline_for_merge_request_worker_spec.rb' - - 'spec/workers/web_hook_worker_spec.rb' - 'tooling/danger/suggestor.rb' diff --git a/.rubocop_todo/layout/array_alignment.yml b/.rubocop_todo/layout/array_alignment.yml index 51e48bafa44..893a9338c5b 100644 --- a/.rubocop_todo/layout/array_alignment.yml +++ b/.rubocop_todo/layout/array_alignment.yml @@ -4,7 +4,6 @@ Layout/ArrayAlignment: Details: grace period Exclude: - 'app/controllers/admin/application_settings_controller.rb' - - 'app/controllers/admin/broadcast_messages_controller.rb' - 'app/controllers/admin/plan_limits_controller.rb' - 'app/controllers/concerns/observability/content_security_policy.rb' - 'app/controllers/profiles_controller.rb' @@ -101,7 +100,6 @@ Layout/ArrayAlignment: - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' - 'ee/spec/lib/audit/project_changes_auditor_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' - 'ee/spec/lib/gitlab/ci/config/security_orchestration_policies/processor_spec.rb' @@ -184,7 +182,6 @@ Layout/ArrayAlignment: - 'lib/gitlab/metrics/samplers/threads_sampler.rb' - 'lib/gitlab/object_hierarchy.rb' - 'lib/gitlab/project_authorizations.rb' - - 'lib/gitlab/rack_attack/instrumented_cache_store.rb' - 'lib/gitlab/reference_extractor.rb' - 'lib/gitlab/sidekiq_middleware/size_limiter/validator.rb' - 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric.rb' @@ -351,7 +348,6 @@ Layout/ArrayAlignment: - 'spec/services/spam/spam_verdict_service_spec.rb' - 'spec/support/helpers/kubernetes_helpers.rb' - 'spec/support/helpers/login_helpers.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' - 'spec/support/shared_examples/lib/email/email_shared_examples.rb' - 'spec/support/shared_examples/lib/wikis_api_examples.rb' - 'spec/support/shared_examples/models/label_note_shared_examples.rb' diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index 9c7b9f2c1a8..93302cebaa1 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -40,7 +40,6 @@ Layout/EmptyLineAfterMagicComment: - 'app/helpers/ci/secure_files_helper.rb' - 'app/helpers/projects/google_cloud/cloudsql_helper.rb' - 'app/helpers/projects/ml/experiments_helper.rb' - - 'app/models/airflow.rb' - 'app/models/ci/job_token/allowlist.rb' - 'app/models/commit_signatures/gpg_signature.rb' - 'app/models/commit_signatures/x509_commit_signature.rb' @@ -133,7 +132,6 @@ Layout/EmptyLineAfterMagicComment: - 'app/workers/concerns/limited_capacity/job_tracker.rb' - 'app/workers/database/batched_background_migration/ci_database_worker.rb' - 'app/workers/gitlab/import/stuck_project_import_jobs_worker.rb' - - 'app/workers/gitlab/phabricator_import/import_tasks_worker.rb' - 'config/application.rb' - 'config/initializers/fog_core_patch.rb' - 'config/initializers/rubyzip.rb' @@ -144,11 +142,6 @@ Layout/EmptyLineAfterMagicComment: - 'danger/ce_ee_vue_templates/Dangerfile' - 'danger/feature_flag/Dangerfile' - 'danger/pajamas/Dangerfile' - - 'db/migrate/20210929121516_add_releases_author_id_id_created_at_index.rb' - - 'db/migrate/20211019153615_add_state_to_merge_request_assignees.rb' - - 'db/migrate/20211126113029_add_text_limit_for_static_objects_external_storage_auth_token.rb' - - 'db/migrate/20220204093120_create_analytics_cycle_analytics_aggregations.rb' - - 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb' - 'db/migrate/20220506154054_create_sync_namespace_details_trigger.rb' - 'db/migrate/20220524184149_create_sync_project_namespace_details_trigger.rb' - 'db/migrate/20220617141347_create_ci_secure_file_states.rb' @@ -162,8 +155,6 @@ Layout/EmptyLineAfterMagicComment: - 'db/migrate/20221219103007_add_name_to_ml_candidates.rb' - 'db/migrate/20221219122320_copy_clickhouse_connection_string_to_encrypted_var.rb' - 'db/migrate/20230111124512_remove_tmp_index_vulns_on_report_type.rb' - - 'db/post_migrate/20211209203820_add_tmp_index_on_report_type.rb' - - 'db/post_migrate/20211209203821_convert_stringified_raw_metadata_hash_to_json.rb' - 'db/post_migrate/20220412143551_add_partial_index_on_unencrypted_integrations.rb' - 'db/post_migrate/20220413011328_remove_partial_index_on_unencrypted_integrations.rb' - 'db/post_migrate/20220901071355_cleanup_attention_request_user_callouts.rb' @@ -215,7 +206,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/app/models/dependencies/dependency_list_export.rb' - 'ee/app/models/ee/issue_assignee.rb' - 'ee/app/models/geo/ci_secure_file_state.rb' - - 'ee/app/models/namespaces/storage/cli_notification.rb' - 'ee/app/models/namespaces/storage/limit_exclusion.rb' - 'ee/app/models/project_security_setting.rb' - 'ee/app/models/protected_environment.rb' @@ -282,13 +272,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/lib/gitlab/cidr.rb' - 'ee/lib/quality/seeders/vulnerabilities.rb' - 'ee/spec/components/billing/plan_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/enforcement_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/enforcement_at_limit_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/non_owner_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/non_owner_notification_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/notification_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/usage_quota_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/usage_quota_trial_alert_component_spec.rb' - 'ee/spec/components/namespaces/storage/limit_alert_component_spec.rb' - 'ee/spec/components/namespaces/storage/pre_enforcement_alert_component_spec.rb' - 'ee/spec/components/namespaces/storage/project_pre_enforcement_alert_component_spec.rb' @@ -344,7 +327,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/graphql/mutations/vulnerabilities/revert_to_detected_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' - 'ee/spec/helpers/ee/geo_helper_spec.rb' - - 'ee/spec/helpers/ee/groups/analytics/cycle_analytics_helper_spec.rb' - 'ee/spec/helpers/ee/invite_members_helper_spec.rb' - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' - 'ee/spec/helpers/ee/saml_providers_helper_spec.rb' @@ -442,7 +424,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/services/wikis/create_attachment_service_spec.rb' - 'ee/spec/support/helpers/board_helpers.rb' - 'ee/spec/workers/app_sec/dast/profile_schedule_worker_spec.rb' - - 'ee/spec/workers/integrations/slack_event_worker_spec.rb' - 'ee/spec/workers/namespaces/free_user_cap/backfill_notification_jobs_worker_spec.rb' - 'lib/api/commits.rb' - 'lib/api/concerns/packages/nuget_endpoints.rb' @@ -459,11 +440,7 @@ Layout/EmptyLineAfterMagicComment: - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_project_import_level.rb' - 'lib/gitlab/background_migration/backfill_project_namespace_details.rb' - - 'lib/gitlab/background_migration/drop_invalid_security_findings.rb' - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' - - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - - 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb' - - 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb' - 'lib/gitlab/ci/secure_files/mobile_provision.rb' - 'lib/gitlab/cleanup/remote_uploads.rb' - 'lib/gitlab/database/migrations/background_migration_helpers.rb' @@ -482,25 +459,12 @@ Layout/EmptyLineAfterMagicComment: - 'lib/gitlab/import_export/recursive_merge_folders.rb' - 'lib/gitlab/import_export/shared.rb' - 'lib/gitlab/json_logger.rb' - - 'lib/gitlab/kubernetes/helm/v2/certificate.rb' - 'lib/gitlab/lfs/client.rb' - 'lib/gitlab/merge_requests/mergeability/check_result.rb' - 'lib/gitlab/merge_requests/mergeability/redis_interface.rb' - 'lib/gitlab/merge_requests/mergeability/results_store.rb' - 'lib/gitlab/merge_requests/message_generator.rb' - 'lib/gitlab/pagination/keyset/sql_type_missing_error.rb' - - 'lib/gitlab/phabricator_import/cache/map.rb' - - 'lib/gitlab/phabricator_import/conduit.rb' - - 'lib/gitlab/phabricator_import/conduit/client.rb' - - 'lib/gitlab/phabricator_import/conduit/maniphest.rb' - - 'lib/gitlab/phabricator_import/conduit/pagination.rb' - - 'lib/gitlab/phabricator_import/conduit/response.rb' - - 'lib/gitlab/phabricator_import/conduit/tasks_response.rb' - - 'lib/gitlab/phabricator_import/conduit/user.rb' - - 'lib/gitlab/phabricator_import/issues/importer.rb' - - 'lib/gitlab/phabricator_import/issues/task_importer.rb' - - 'lib/gitlab/phabricator_import/representation/task.rb' - - 'lib/gitlab/phabricator_import/worker_state.rb' - 'lib/gitlab/relative_positioning/gap.rb' - 'lib/gitlab/safe_device_detector.rb' - 'lib/gitlab/spamcheck/client.rb' @@ -555,10 +519,8 @@ Layout/EmptyLineAfterMagicComment: - 'spec/components/previews/pajamas/card_component_preview.rb' - 'spec/components/previews/pajamas/spinner_component_preview.rb' - 'spec/controllers/application_controller_spec.rb' - - 'spec/controllers/concerns/analytics/cycle_analytics/value_stream_actions_spec.rb' - 'spec/controllers/projects/jobs_controller_spec.rb' - 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb' - - 'spec/factories/airflow/dags.rb' - 'spec/factories/alert_management/alerts.rb' - 'spec/factories/draft_note.rb' - 'spec/factories/ml/candidates.rb' @@ -594,18 +556,13 @@ Layout/EmptyLineAfterMagicComment: - 'spec/graphql/types/label_type_spec.rb' - 'spec/graphql/types/users/email_type_spec.rb' - 'spec/graphql/types/users/namespace_commit_email_type_spec.rb' - - 'spec/helpers/analytics/cycle_analytics_helper_spec.rb' - 'spec/helpers/keyset_helper_spec.rb' - 'spec/helpers/sorting_helper_spec.rb' - 'spec/initializers/mail_encoding_patch_spec.rb' - 'spec/lib/constraints/admin_constrainer_spec.rb' - 'spec/lib/gitlab/analytics/date_filler_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/class_attributes_spec.rb' - 'spec/lib/gitlab/cleanup/remote_uploads_spec.rb' @@ -619,7 +576,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/lib/gitlab/database/migrations/observers/total_database_size_change_spec.rb' - 'spec/lib/gitlab/database/migrations/observers/transaction_duration_spec.rb' - 'spec/lib/gitlab/database/migrations/runner_spec.rb' - - 'spec/lib/gitlab/database/schema_validation/index_spec.rb' - 'spec/lib/gitlab/file_markdown_link_builder_spec.rb' - 'spec/lib/gitlab/file_type_detection_spec.rb' - 'spec/lib/gitlab/git/patches/collection_spec.rb' @@ -639,7 +595,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/lib/gitlab/json_cache_spec.rb' - 'spec/lib/gitlab/jwt_token_spec.rb' - 'spec/lib/gitlab/kroki_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/certificate_spec.rb' - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' - 'spec/lib/gitlab/markdown_cache/redis/extension_spec.rb' - 'spec/lib/gitlab/markdown_cache/redis/store_spec.rb' @@ -648,15 +603,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/lib/gitlab/metrics/rails_slis_spec.rb' - 'spec/lib/gitlab/middleware/handle_malformed_strings_spec.rb' - 'spec/lib/gitlab/middleware/request_context_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/client_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/maniphest_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/tasks_response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/users_response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/project_creator_spec.rb' - 'spec/lib/gitlab/request_endpoints_spec.rb' - 'spec/lib/gitlab/slash_commands/presenters/issue_new_spec.rb' - 'spec/lib/gitlab/ssh/commit_spec.rb' @@ -666,17 +612,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/lib/gitlab/x509/commit_spec.rb' - 'spec/lib/gitlab/x509/tag_spec.rb' - 'spec/lib/security/report_schema_version_matcher_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211110143306_add_not_null_constraint_to_security_findings_uuid_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20211207125331_remove_jobs_for_recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/migrations/20211210140629_encrypt_static_object_token_spec.rb' - - 'spec/migrations/20211217174331_mark_recalculate_finding_signatures_as_completed_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - - 'spec/migrations/20220202105733_delete_service_template_records_spec.rb' - - 'spec/migrations/20220222192524_create_not_null_constraint_releases_tag_spec.rb' - - 'spec/migrations/20220222192525_remove_null_releases_spec.rb' - - 'spec/migrations/20220309084954_remove_leftover_external_pull_request_deletions_spec.rb' - 'spec/migrations/20220322132242_update_pages_onboarding_state_spec.rb' - 'spec/migrations/20220329175119_remove_leftover_ci_job_artifact_deletions_spec.rb' - 'spec/models/analytics/cycle_analytics/aggregation_spec.rb' @@ -813,10 +748,7 @@ Layout/EmptyLineAfterMagicComment: - 'spec/services/packages/create_package_file_service_spec.rb' - 'spec/services/packages/debian/extract_changes_metadata_service_spec.rb' - 'spec/services/packages/debian/extract_deb_metadata_service_spec.rb' - - 'spec/services/packages/debian/extract_metadata_service_spec.rb' - 'spec/services/packages/debian/parse_debian822_service_spec.rb' - - 'spec/services/packages/debian/process_changes_service_spec.rb' - - 'spec/services/packages/debian/process_package_file_service_spec.rb' - 'spec/services/packages/helm/extract_file_metadata_service_spec.rb' - 'spec/services/packages/helm/process_file_service_spec.rb' - 'spec/services/packages/maven/create_package_service_spec.rb' @@ -852,11 +784,10 @@ Layout/EmptyLineAfterMagicComment: - 'spec/services/wikis/create_attachment_service_spec.rb' - 'spec/support/fips.rb' - 'spec/support/generate-seed-repo-rb' - - 'spec/support/graphql/fake_query_type.rb' + - 'spec/support/helpers/graphql/fake_query_type.rb' - 'spec/support/helpers/fake_webauthn_device.rb' - 'spec/support/helpers/features/access_token_helpers.rb' - 'spec/support/helpers/features/iteration_helpers.rb' - - 'spec/support/helpers/features/list_rows_helpers.rb' - 'spec/support/helpers/features/responsive_table_helpers.rb' - 'spec/support/helpers/features/two_factor_helpers.rb' - 'spec/support/helpers/lfs_http_helpers.rb' @@ -888,12 +819,10 @@ Layout/EmptyLineAfterMagicComment: - 'spec/views/shared/ssh_keys/_key_delete.html.haml_spec.rb' - 'spec/views/shared/wikis/_sidebar.html.haml_spec.rb' - 'spec/workers/auto_devops/disable_worker_spec.rb' - - 'spec/workers/gitlab/phabricator_import/base_worker_spec.rb' - - 'spec/workers/gitlab/phabricator_import/import_tasks_worker_spec.rb' - 'spec/workers/integrations/execute_worker_spec.rb' - 'spec/workers/partition_creation_worker_spec.rb' - 'spec/workers/projects/delete_branch_worker_spec.rb' - 'spec/workers/web_hook_worker_spec.rb' - - 'tooling/danger/product_intelligence.rb' + - 'tooling/danger/analytics_instrumentation.rb' - 'tooling/danger/suggestor.rb' - 'tooling/docs/deprecation_handling.rb' diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml index e06a9a9d824..f55a4e6b0dc 100644 --- a/.rubocop_todo/layout/first_array_element_indentation.yml +++ b/.rubocop_todo/layout/first_array_element_indentation.yml @@ -3,7 +3,6 @@ Layout/FirstArrayElementIndentation: Details: grace period Exclude: - - 'app/controllers/admin/broadcast_messages_controller.rb' - 'app/controllers/admin/plan_limits_controller.rb' - 'app/finders/user_groups_counter.rb' - 'app/helpers/search_helper.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index 71a32b64c50..4537d0a499b 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -23,7 +23,6 @@ Layout/FirstHashElementIndentation: - 'app/helpers/tags_helper.rb' - 'app/models/application_setting.rb' - 'app/models/ci/build_metadata.rb' - - 'app/models/clusters/applications/crossplane.rb' - 'app/models/concerns/has_wiki_page_slug_attributes.rb' - 'app/models/concerns/subscribable.rb' - 'app/models/concerns/taskable.rb' @@ -46,7 +45,6 @@ Layout/FirstHashElementIndentation: - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/helpers/ee/geo_helper.rb' - 'ee/app/helpers/ee/groups/group_members_helper.rb' - - 'ee/app/helpers/ee/trial_helper.rb' - 'ee/app/models/ee/list.rb' - 'ee/app/services/app_sec/dast/profiles/update_service.rb' - 'ee/app/services/elastic/cluster_reindexing_service.rb' @@ -151,7 +149,7 @@ Layout/FirstHashElementIndentation: - 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_release_spec.rb' - 'qa/qa/specs/features/api/3_create/repository/commit_to_templated_project_spec.rb' - 'qa/qa/specs/features/api/5_package/container_registry_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_web_ide_from_diff_tab_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/open_web_ide_from_diff_tab_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/online_garbage_collection_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/dependency_proxy/dependency_proxy_spec.rb' @@ -186,7 +184,6 @@ Layout/FirstHashElementIndentation: - 'spec/controllers/projects/web_ide_terminals_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - 'spec/factories/ci/builds.rb' - - 'spec/factories/packages/debian/file_metadatum.rb' - 'spec/frontend/fixtures/autocomplete_sources.rb' - 'spec/graphql/types/ci/detailed_status_type_spec.rb' - 'spec/helpers/groups/observability_helper_spec.rb' @@ -201,8 +198,6 @@ Layout/FirstHashElementIndentation: - 'spec/lib/container_registry/client_spec.rb' - 'spec/lib/gitlab/application_rate_limiter_spec.rb' - 'spec/lib/gitlab/asciidoc_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_u2f_webauthn_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/ci/config_spec.rb' - 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb' @@ -222,7 +217,6 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/import_export/members_mapper_spec.rb' - 'spec/lib/gitlab/instrumentation_helper_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - 'spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb' - 'spec/lib/gitlab/workhorse_spec.rb' - 'spec/lib/mattermost/team_spec.rb' diff --git a/.rubocop_todo/layout/line_continuation_leading_space.yml b/.rubocop_todo/layout/line_continuation_leading_space.yml index ca9a5a0b6fb..f2c9feec08d 100644 --- a/.rubocop_todo/layout/line_continuation_leading_space.yml +++ b/.rubocop_todo/layout/line_continuation_leading_space.yml @@ -20,7 +20,6 @@ Layout/LineContinuationLeadingSpace: - 'ee/app/services/system_notes/epics_service.rb' - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb' - 'ee/lib/ee/gitlab/git_access.rb' - - 'ee/lib/slack/block_kit/app_home_opened.rb' - 'ee/lib/tasks/gitlab/geo.rake' - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' - 'ee/spec/features/gitlab_subscriptions/seat_count_alert_spec.rb' diff --git a/.rubocop_todo/layout/line_continuation_spacing.yml b/.rubocop_todo/layout/line_continuation_spacing.yml index 08b0f5498a9..bbb9e83ce48 100644 --- a/.rubocop_todo/layout/line_continuation_spacing.yml +++ b/.rubocop_todo/layout/line_continuation_spacing.yml @@ -16,7 +16,6 @@ Layout/LineContinuationSpacing: - 'app/models/environment.rb' - 'app/models/integrations/base_third_party_wiki.rb' - 'app/models/integrations/teamcity.rb' - - 'app/models/members/member_role.rb' - 'app/models/work_items/parent_link.rb' - 'app/services/feature_flags/update_service.rb' - 'app/services/issues/build_service.rb' @@ -56,7 +55,6 @@ Layout/LineContinuationSpacing: - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb' - 'ee/lib/ee/gitlab/git_access.rb' - 'ee/lib/tasks/gitlab/geo.rake' - - 'ee/spec/components/namespaces/free_user_cap/usage_quota_trial_alert_component_spec.rb' - 'ee/spec/controllers/groups/group_members_controller_spec.rb' - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb' - 'ee/spec/features/admin/admin_emails_spec.rb' @@ -142,8 +140,6 @@ Layout/LineContinuationSpacing: - 'rubocop/cop/migration/background_migrations.rb' - 'rubocop/cop/performance/ar_exists_and_present_blank.rb' - 'rubocop/cop/redis_queue_usage.rb' - - 'scripts/create-pipeline-failure-incident.rb' - - 'scripts/generate-failed-pipeline-slack-message.rb' - 'scripts/qa/testcases-check' - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' - 'spec/features/issues/create_issue_for_single_discussion_in_merge_request_spec.rb' @@ -154,7 +150,6 @@ Layout/LineContinuationSpacing: - 'spec/features/projects/files/user_edits_files_spec.rb' - 'spec/features/projects/files/user_replaces_files_spec.rb' - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' - - 'spec/features/u2f_spec.rb' - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb' @@ -184,7 +179,6 @@ Layout/LineContinuationSpacing: - 'spec/models/integrations/chat_message/push_message_spec.rb' - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' - 'spec/models/member_spec.rb' - - 'spec/models/members/member_role_spec.rb' - 'spec/models/operations/feature_flags_client_spec.rb' - 'spec/models/project_spec.rb' - 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index 1cd22cb3e18..d1b6eddb465 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -26,7 +26,6 @@ Layout/LineEndStringConcatenationIndentation: - 'app/models/concerns/spammable.rb' - 'app/models/environment.rb' - 'app/models/integrations/pivotaltracker.rb' - - 'app/models/members/member_role.rb' - 'app/models/merge_request_diff_commit.rb' - 'app/models/postgresql/replication_slot.rb' - 'app/presenters/packages/npm/package_presenter.rb' @@ -82,14 +81,7 @@ Layout/LineEndStringConcatenationIndentation: - 'ee/lib/ee/gitlab/git_access.rb' - 'ee/lib/ee/gitlab/namespace_storage_size_error_message.rb' - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' - - 'ee/lib/slack/block_kit/app_home_opened.rb' - 'ee/lib/tasks/gitlab/geo.rake' - - 'ee/spec/components/namespaces/free_user_cap/enforcement_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/enforcement_at_limit_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/non_owner_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/notification_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/usage_quota_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/usage_quota_trial_alert_component_spec.rb' - 'ee/spec/controllers/admin/licenses_controller_spec.rb' - 'ee/spec/controllers/groups/group_members_controller_spec.rb' - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb' @@ -244,8 +236,6 @@ Layout/LineEndStringConcatenationIndentation: - 'rubocop/cop/rspec/have_gitlab_http_status.rb' - 'rubocop/cop/sidekiq_api_usage.rb' - 'rubocop/cop/user_admin.rb' - - 'scripts/create-pipeline-failure-incident.rb' - - 'scripts/generate-failed-pipeline-slack-message.rb' - 'scripts/lib/glfm/parse_examples.rb' - 'scripts/lib/glfm/update_example_snapshots.rb' - 'scripts/lib/glfm/update_specification.rb' @@ -303,7 +293,6 @@ Layout/LineEndStringConcatenationIndentation: - 'spec/models/integrations/chat_message/push_message_spec.rb' - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' - 'spec/models/member_spec.rb' - - 'spec/models/members/member_role_spec.rb' - 'spec/models/operations/feature_flags_client_spec.rb' - 'spec/models/ssh_host_key_spec.rb' - 'spec/presenters/ci/pipeline_presenter_spec.rb' @@ -315,7 +304,6 @@ Layout/LineEndStringConcatenationIndentation: - 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb' - 'spec/requests/api/releases_spec.rb' - 'spec/requests/api/users_spec.rb' - - 'spec/requests/self_monitoring_project_spec.rb' - 'spec/rubocop/cop/api/grape_array_missing_coerce_spec.rb' - 'spec/rubocop/cop/group_public_or_visible_to_user_spec.rb' - 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb' @@ -339,7 +327,6 @@ Layout/LineEndStringConcatenationIndentation: - 'spec/support/shared_examples/features/project_upload_files_shared_examples.rb' - 'spec/support/shared_examples/lib/email/email_shared_examples.rb' - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' - - 'spec/support/shared_examples/requests/self_monitoring_shared_examples.rb' - 'spec/uploaders/file_mover_spec.rb' - 'spec/views/devise/shared/_signup_box.html.haml_spec.rb' - 'spec/views/projects/pages/show.html.haml_spec.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 772284a6ce7..339edfce783 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -105,7 +105,7 @@ Layout/LineLength: - 'app/controllers/users_controller.rb' - 'app/finders/analytics/cycle_analytics/stage_finder.rb' - 'app/finders/ci/runners_finder.rb' - - 'app/finders/clusters/agent_authorizations_finder.rb' + - 'app/finders/clusters/agents/authorizations/ci_access/finder.rb' - 'app/finders/group_descendants_finder.rb' - 'app/finders/group_members_finder.rb' - 'app/finders/group_projects_finder.rb' @@ -214,7 +214,6 @@ Layout/LineLength: - 'app/graphql/types/root_storage_statistics_type.rb' - 'app/graphql/types/snippets/visibility_scopes_enum.rb' - 'app/graphql/types/todo_action_enum.rb' - - 'app/helpers/analytics/cycle_analytics_helper.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/application_settings_helper.rb' - 'app/helpers/award_emoji_helper.rb' @@ -301,8 +300,6 @@ Layout/LineLength: - 'app/models/ci/runner.rb' - 'app/models/ci/unit_test.rb' - 'app/models/clusters/agent.rb' - - 'app/models/clusters/applications/knative.rb' - - 'app/models/clusters/applications/prometheus.rb' - 'app/models/clusters/cluster.rb' - 'app/models/commit_range.rb' - 'app/models/commit_status.rb' @@ -444,7 +441,6 @@ Layout/LineLength: - 'app/models/releases/link.rb' - 'app/models/remote_mirror.rb' - 'app/models/repository.rb' - - 'app/models/serverless/domain.rb' - 'app/models/service_desk_setting.rb' - 'app/models/suggestion.rb' - 'app/models/todo.rb' @@ -507,6 +503,7 @@ Layout/LineLength: - 'app/services/ci/runners/register_runner_service.rb' - 'app/services/ci/runners/unregister_runner_service.rb' - 'app/services/clusters/agent_tokens/create_service.rb' + - 'app/services/clusters/agents/authorizations/ci_access/refresh_service.rb' - 'app/services/clusters/agents/delete_service.rb' - 'app/services/clusters/build_kubernetes_namespace_service.rb' - 'app/services/clusters/integrations/create_service.rb' @@ -746,149 +743,8 @@ Layout/LineLength: - 'danger/roulette/Dangerfile' - 'danger/vue_shared_documentation/Dangerfile' - 'danger/z_metadata/Dangerfile' - - 'db/migrate/20210830085837_add_throttle_authenticated_git_lfs_columns.rb' - - 'db/migrate/20210831203408_upsert_base_work_item_types.rb' - - 'db/migrate/20210908140437_add_sidekiq_limits_to_application_settings.rb' - - 'db/migrate/20210909184349_add_index_package_id_id_on_package_files.rb' - - 'db/migrate/20210910015047_add_app_settings_dep_proxy_ttl_worker_capacity_check_constraint.rb' - - 'db/migrate/20210913224558_update_dependency_proxy_manifests_uniqueness_constraint.rb' - - 'db/migrate/20210914145810_add_throttle_deprecated_api_columns.rb' - - 'db/migrate/20210917153905_remove_pipeline_fk_from_packages_package_file_build_infos.rb' - - 'db/migrate/20210921063924_index_labels_using_varchar_pattern_ops.rb' - - 'db/migrate/20210928155022_improve_index_for_error_tracking.rb' - - 'db/migrate/20210929031049_add_unique_index_phone_on_user_details.rb' - - 'db/migrate/20210929115340_add_security_policy_configurations_management_project_id_foreign_key.rb' - - 'db/migrate/20210930081208_fix_deprecated_api_throttle_defaults.rb' - - 'db/migrate/20211005093558_add_range_partitioned_loose_fk_table.rb' - - 'db/migrate/20211006103122_change_helm_channel_length.rb' - - 'db/migrate/20211011004242_create_content_blocked_states.rb' - - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' - - 'db/migrate/20211013192749_add_states_into_approval_project_rules.rb' - - 'db/migrate/20211028132247_create_packages_npm_metadata.rb' - - 'db/migrate/20211101165656_create_upload_states.rb' - - 'db/migrate/20211110015252_add_agent_activity_events_foreign_keys.rb' - - 'db/migrate/20211111112425_create_merge_requests_compliance_violations.rb' - - 'db/migrate/20211116093739_add_foreign_key_to_incident_management_timeline_events_on_updated_by_user.rb' - - 'db/migrate/20211117174209_create_vulnerability_reads.rb' - - 'db/migrate/20211119111006_create_job_artifact_states.rb' - - 'db/migrate/20211119154221_create_pages_deployment_states.rb' - - 'db/migrate/20211126042235_add_sequence_column_to_sprints_table.rb' - - 'db/migrate/20211126115449_encrypt_static_objects_external_storage_auth_token.rb' - - 'db/migrate/20211130151724_add_foreign_key_to_incident_management_timeline_events_on_note.rb' - - 'db/migrate/20211130205719_add_uniqueness_for_evidence_occurrence_id.rb' - - 'db/migrate/20211201143042_create_lfs_object_states.rb' - - 'db/migrate/20211202094944_move_loose_fk_deleted_records_to_dynamic_schema.rb' - - 'db/migrate/20211207154413_add_ci_runners_index_on_created_at_where_active_is_false.rb' - - 'db/migrate/20211207154414_add_ci_runners_index_on_contacted_at_where_active_is_false.rb' - - 'db/migrate/20211216135651_add_index_to_cluster_agent_id.rb' - - 'db/migrate/20211217050753_remove_artifacts_archive_id_foreign_key_from_project_pages_metadata.rb' - - 'db/migrate/20220106230629_add_registry_migration_application_settings.rb' - - 'db/migrate/20220107091629_add_route_namespace_index.rb' - - 'db/migrate/20220111154951_add_index_to_ci_runners_token_expires_at.rb' - - 'db/migrate/20220112232605_add_member_namespace_index.rb' - - 'db/migrate/20220113125401_create_security_trainings.rb' - - 'db/migrate/20220118155846_add_runner_token_expiration_interval_settings_to_application_settings.rb' - - 'db/migrate/20220118155847_add_runner_token_expiration_interval_settings_to_namespace_settings.rb' - - 'db/migrate/20220119094023_add_unique_index_to_aed_verification_token.rb' - - 'db/migrate/20220120033115_create_alert_management_alert_metric_images.rb' - - 'db/migrate/20220120211831_temp_index_for_group_namespace_member_backfill.rb' - - 'db/migrate/20220125122725_add_topics_non_private_projects_count_index.rb' - - 'db/migrate/20220202115350_add_migration_indexes_to_container_repositories.rb' - - 'db/migrate/20220203091304_fix_unique_packages_index_excluding_pending_destruction_status.rb' - - 'db/migrate/20220204093120_create_analytics_cycle_analytics_aggregations.rb' - - 'db/migrate/20220207083129_add_users_get_by_id_limit_to_application_setting.rb' - - 'db/migrate/20220208171826_update_default_scan_method_of_dast_site_profile.rb' - - 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb' - - 'db/migrate/20220216110023_create_saved_replies.rb' - - 'db/migrate/20220217100008_add_container_registry_expiration_policies_caching_to_application_settings.rb' - - 'db/migrate/20220222072536_add_target_access_levels_to_broadcast_messages.rb' - - 'db/migrate/20220301003502_add_security_orchestration_policy_configuration_namespace_index.rb' - - 'db/migrate/20220301175104_change_security_orchestration_policy_configuration_project_index.rb' - - 'db/migrate/20220304062107_remove_unique_index_for_sprints_on_project_id_and_title.rb' - - 'db/migrate/20220310101118_update_holder_name_limit.rb' - 'db/migrate/20220314184209_add_group_fk_to_protected_environment_approval_rules.rb' - 'db/migrate/20220314204009_add_approval_rule_fk_to_deployment_approvals.rb' - - 'db/post_migrate/20210901184511_prepare_async_indexes_for_ci_builds.rb' - - 'db/post_migrate/20210907211557_finalize_ci_builds_bigint_conversion.rb' - - 'db/post_migrate/20210923135909_remove_delayed_project_removal_from_namespaces.rb' - - 'db/post_migrate/20210927153807_update_issues_relative_position_indexes.rb' - - 'db/post_migrate/20211007093340_remove_analytics_snapshots_segment_id_column.rb' - - 'db/post_migrate/20211012155931_remove_schedule_and_status_from_pending_alert_escalations.rb' - - 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb' - - 'db/post_migrate/20211031152417_add_indexes_to_issue_stage_events.rb' - - 'db/post_migrate/20211031154919_add_indexes_to_merge_request_stage_events.rb' - - 'db/post_migrate/20211104165220_remove_vulnerability_finding_links.rb' - - 'db/post_migrate/20211105135157_drop_ci_build_trace_sections.rb' - - 'db/post_migrate/20211112113300_remove_ci_pipeline_chat_data_fk_on_chat_names.rb' - - 'db/post_migrate/20211118194239_drop_invalid_remediations.rb' - - 'db/post_migrate/20211201101541_drop_clusters_applications_runners_ci_runners_fk.rb' - - 'db/post_migrate/20211207173510_remove_extra_finding_evidence_tables_foreign_keys.rb' - - 'db/post_migrate/20211207173511_remove_extra_finding_evidence_tables.rb' - - 'db/post_migrate/20211209103048_backfill_project_namespaces_for_group.rb' - - 'db/post_migrate/20211210140000_add_temporary_static_object_token_index.rb' - - 'db/post_migrate/20211210173137_remove_vulnerability_finding_links_again.rb' - - 'db/post_migrate/20211213102111_drop_ci_pipelines_mr_metrics_fk.rb' - - 'db/post_migrate/20211220120402_add_index_on_ci_pipelines_user_id_id_failure_reason.rb' - - 'db/post_migrate/20220104060049_remove_foreign_key_ci_group_variables_group_id.rb' - - 'db/post_migrate/20220105020514_remove_ci_minutes_additional_packs_namespace_id_foreign_key_constraint.rb' - - 'db/post_migrate/20220106231518_remove_foreign_key_ci_daily_build_group_report_results_group_id.rb' - - 'db/post_migrate/20220106233459_remove_foreign_key_ci_pending_builds_namespace_id.rb' - - 'db/post_migrate/20220106235626_remove_foreign_key_ci_runner_namespaces_namespace_id.rb' - - 'db/post_migrate/20220110224913_remove_dast_scanner_profiles_builds_ci_build_id_fk.rb' - - 'db/post_migrate/20220110231420_remove_requirements_management_test_reports_build_id_fk.rb' - - 'db/post_migrate/20220110233155_remove_dast_site_profiles_builds_ci_build_id_fk.rb' - - 'db/post_migrate/20220111002756_remove_security_scans_build_id_fk.rb' - - 'db/post_migrate/20220111221516_remove_projects_ci_pending_builds_fk.rb' - - 'db/post_migrate/20220112015940_remove_projects_ci_running_builds_fk.rb' - - 'db/post_migrate/20220112230642_remove_projects_ci_unit_tests_project_id_fk.rb' - - 'db/post_migrate/20220112232723_remove_projects_ci_daily_build_group_report_results_project_id_fk.rb' - - 'db/post_migrate/20220113013319_remove_projects_ci_freeze_periods_project_id_fk.rb' - - 'db/post_migrate/20220113014438_remove_projects_ci_resource_groups_project_id_fk.rb' - - 'db/post_migrate/20220113015830_remove_projects_ci_build_report_results_project_id_fk.rb' - - 'db/post_migrate/20220113035519_remove_users_ci_job_token_project_scope_links_added_by_id_fk.rb' - - 'db/post_migrate/20220113040447_remove_users_ci_pipeline_schedules_owner_id_fk.rb' - - 'db/post_migrate/20220113111440_schedule_fix_incorrect_max_seats_used.rb' - - 'db/post_migrate/20220119141736_remove_projects_ci_pipeline_artifacts_project_id_fk.rb' - - 'db/post_migrate/20220119143130_remove_projects_ci_sources_pipelines_source_project_id_fk.rb' - - 'db/post_migrate/20220119144458_remove_users_ci_triggers_owner_id_fk.rb' - - 'db/post_migrate/20220119151221_remove_merge_requests_ci_pipelines_merge_request_id_fk.rb' - - 'db/post_migrate/20220119153706_remove_ci_pipelines_merge_trains_pipeline_id_fk.rb' - - 'db/post_migrate/20220119154442_remove_ci_pipelines_merge_requests_head_pipeline_id_fk.rb' - - 'db/post_migrate/20220119193130_remove_ci_pipelines_dast_profiles_pipelines_ci_pipeline_id_fk.rb' - - 'db/post_migrate/20220119201340_remove_ci_pipelines_vulnerability_statistics_latest_pipeline_id_fk.rb' - - 'db/post_migrate/20220119203119_remove_ci_pipelines_vulnerability_occurrence_pipelines_pipeline_id_fk.rb' - - 'db/post_migrate/20220120123700_add_tmp_index_routes_id_for_namespaces.rb' - - 'db/post_migrate/20220121214752_remove_projects_ci_stages_project_id_fk.rb' - - 'db/post_migrate/20220121221651_remove_projects_ci_variables_project_id_fk.rb' - - 'db/post_migrate/20220124130028_dedup_runner_projects.rb' - - 'db/post_migrate/20220124145019_remove_projects_external_pull_requests_project_id_fk.rb' - - 'db/post_migrate/20220124151456_remove_projects_ci_triggers_project_id_fk.rb' - - 'db/post_migrate/20220124151949_remove_projects_ci_runner_projects_project_id_fk.rb' - - 'db/post_migrate/20220124152824_remove_projects_ci_subscriptions_projects_downstream_project_id_fk.rb' - - 'db/post_migrate/20220124153233_remove_projects_ci_job_artifacts_project_id_fk.rb' - - 'db/post_migrate/20220124180704_remove_projects_ci_builds_metadata_project_id_fk.rb' - - 'db/post_migrate/20220124184338_remove_projects_ci_subscriptions_projects_upstream_project_id_fk.rb' - - 'db/post_migrate/20220124204046_remove_projects_ci_sources_pipelines_project_id_fk.rb' - - 'db/post_migrate/20220124214131_remove_projects_ci_refs_project_id_fk.rb' - - 'db/post_migrate/20220124215857_remove_projects_ci_job_token_project_scope_links_source_project_id_fk.rb' - - 'db/post_migrate/20220124221521_remove_projects_ci_project_monthly_usages_project_id_fk.rb' - - 'db/post_migrate/20220125083520_remove_ci_pipelines_dast_site_profiles_pipelines_ci_pipeline_id_fk.rb' - - 'db/post_migrate/20220125084348_remove_ci_pipelines_vulnerability_feedback_pipeline_id_fk.rb' - - 'db/post_migrate/20220126201752_remove_projects_ci_job_token_project_scope_links_target_project_id_fk.rb' - - 'db/post_migrate/20220126202654_remove_projects_ci_sources_projects_source_project_id_fk.rb' - - 'db/post_migrate/20220126203421_remove_projects_ci_pipeline_schedules_project_id_fk.rb' - - 'db/post_migrate/20220126210021_remove_projects_ci_builds_project_id_fk.rb' - - 'db/post_migrate/20220126210657_remove_projects_ci_pipelines_project_id_fk.rb' - - 'db/post_migrate/20220128155814_fix_approval_rules_code_owners_rule_type_index.rb' - - 'db/post_migrate/20220131000000_index_job_artifacts_on_trace_type_and_expire_at.rb' - - 'db/post_migrate/20220201193033_add_unique_index_to_vulnerability_finding_links_with_truncate.rb' - - 'db/post_migrate/20220207080758_update_api_indexes_for_projects.rb' - - 'db/post_migrate/20220212120735_schedule_fix_incorrect_max_seats_used2.rb' - - 'db/post_migrate/20220224000000_async_build_trace_expire_at_index.rb' - - 'db/post_migrate/20220305223212_add_security_training_providers.rb' - - 'db/post_migrate/20220307192610_remove_duplicate_project_tag_releases.rb' - - 'db/post_migrate/20220308115219_schedule_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'db/post_migrate/20220308115502_schedule_reset_duplicate_ci_runners_token_values_on_projects.rb' - 'db/post_migrate/20220315171027_add_tmp_index_to_support_leaky_regex_cleanup.rb' - 'db/post_migrate/20220316102902_add_user_foreign_key_to_deploy_tokens.rb' - 'db/post_migrate/20220317161914_remove_ci_runners_ci_builds_runner_id_fk.rb' @@ -932,7 +788,6 @@ Layout/LineLength: - 'ee/app/controllers/projects/security/policies_controller.rb' - 'ee/app/controllers/projects/security/vulnerabilities/notes_controller.rb' - 'ee/app/controllers/subscriptions_controller.rb' - - 'ee/app/controllers/trials_controller.rb' - 'ee/app/enums/vulnerabilities/dismissal_reason_enum.rb' - 'ee/app/finders/compliance_management/merge_requests/compliance_violations_finder.rb' - 'ee/app/finders/incident_management/escalation_rules_finder.rb' @@ -1026,7 +881,6 @@ Layout/LineLength: - 'ee/app/helpers/ee/button_helper.rb' - 'ee/app/helpers/ee/feature_flags_helper.rb' - 'ee/app/helpers/ee/geo_helper.rb' - - 'ee/app/helpers/ee/groups/analytics/cycle_analytics_helper.rb' - 'ee/app/helpers/ee/groups/settings_helper.rb' - 'ee/app/helpers/ee/groups_helper.rb' - 'ee/app/helpers/ee/import_helper.rb' @@ -1042,10 +896,8 @@ Layout/LineLength: - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/helpers/ee/search_helper.rb' - 'ee/app/helpers/ee/subscribable_banner_helper.rb' - - 'ee/app/helpers/ee/trial_helper.rb' - 'ee/app/helpers/epics_helper.rb' - 'ee/app/helpers/gitlab_subscriptions/upcoming_reconciliation_helper.rb' - - 'ee/app/helpers/groups/feature_discovery_moments_helper.rb' - 'ee/app/helpers/groups/security_features_helper.rb' - 'ee/app/helpers/groups/sso_helper.rb' - 'ee/app/helpers/license_helper.rb' @@ -1092,7 +944,6 @@ Layout/LineLength: - 'ee/app/models/ee/group.rb' - 'ee/app/models/ee/integrations/jira.rb' - 'ee/app/models/ee/issue.rb' - - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/key.rb' - 'ee/app/models/ee/lfs_object.rb' - 'ee/app/models/ee/list.rb' @@ -1123,6 +974,7 @@ Layout/LineLength: - 'ee/app/models/incident_management/oncall_rotation.rb' - 'ee/app/models/integrations/github.rb' - 'ee/app/models/issuable_sla.rb' + - 'ee/app/models/iteration.rb' - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/license.rb' - 'ee/app/models/merge_requests/compliance_violation.rb' @@ -1329,7 +1181,6 @@ Layout/LineLength: - 'ee/app/workers/repository_update_mirror_worker.rb' - 'ee/app/workers/security/orchestration_policy_rule_schedule_namespace_worker.rb' - 'ee/app/workers/security/orchestration_policy_rule_schedule_worker.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/config/routes/group.rb' - 'ee/config/routes/project.rb' - 'ee/db/fixtures/development/20_burndown.rb' @@ -1378,6 +1229,7 @@ Layout/LineLength: - 'ee/lib/api/resource_iteration_events.rb' - 'ee/lib/api/status_checks.rb' - 'ee/lib/api/vulnerability_issue_links.rb' + - 'ee/lib/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/api/deployments.rb' - 'ee/lib/ee/api/entities/application_setting.rb' - 'ee/lib/ee/api/entities/dependency.rb' @@ -1404,7 +1256,6 @@ Layout/LineLength: - 'ee/lib/ee/api/merge_request_approvals.rb' - 'ee/lib/ee/api/merge_requests.rb' - 'ee/lib/ee/api/namespaces.rb' - - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/data_collector.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/stage_events.rb' @@ -1414,14 +1265,9 @@ Layout/LineLength: - 'ee/lib/ee/gitlab/auth/ldap/sync/users.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'ee/lib/ee/gitlab/background_migration/create_security_setting.rb' - - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - 'ee/lib/ee/gitlab/checks/push_rules/commit_check.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/lib/ee/gitlab/ci/config_ee.rb' @@ -1543,7 +1389,6 @@ Layout/LineLength: - 'ee/spec/controllers/operations_controller_spec.rb' - 'ee/spec/controllers/projects/analytics/cycle_analytics/summary_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' - - 'ee/spec/controllers/projects/dependencies_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb' - 'ee/spec/controllers/projects/issues_controller_spec.rb' @@ -1582,7 +1427,6 @@ Layout/LineLength: - 'ee/spec/features/admin/groups/admin_subscription_alerts_spec.rb' - 'ee/spec/features/admin/subscriptions/admin_views_subscription_spec.rb' - 'ee/spec/features/billings/billing_plans_spec.rb' - - 'ee/spec/features/billings/extend_reactivate_trial_spec.rb' - 'ee/spec/features/boards/scoped_issue_board_spec.rb' - 'ee/spec/features/boards/sidebar_spec.rb' - 'ee/spec/features/boards/swimlanes/epics_swimlanes_drag_drop_spec.rb' @@ -1602,7 +1446,6 @@ Layout/LineLength: - 'ee/spec/features/groups/analytics/cycle_analytics/multiple_value_streams_spec.rb' - 'ee/spec/features/groups/audit_events_spec.rb' - 'ee/spec/features/groups/billing_spec.rb' - - 'ee/spec/features/groups/feature_discovery_moments_spec.rb' - 'ee/spec/features/groups/group_roadmap_spec.rb' - 'ee/spec/features/groups/group_settings_spec.rb' - 'ee/spec/features/groups/groups_security_credentials_spec.rb' @@ -1619,7 +1462,6 @@ Layout/LineLength: - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' - 'ee/spec/features/groups/sso_spec.rb' - 'ee/spec/features/integrations/jira/jira_issues_list_spec.rb' - - 'ee/spec/features/invites_spec.rb' - 'ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb' - 'ee/spec/features/issues/form_spec.rb' - 'ee/spec/features/labels_hierarchy_spec.rb' @@ -1845,16 +1687,10 @@ Layout/LineLength: - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_namespace_statistics_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' @@ -1915,8 +1751,6 @@ Layout/LineLength: - 'ee/spec/lib/gitlab/auth/ldap/user_spec.rb' - 'ee/spec/lib/gitlab/auth/saml/user_spec.rb' - 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/populate_test_reports_issue_id_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/checks/diff_check_spec.rb' - 'ee/spec/lib/gitlab/ci/config/entry/job_spec.rb' - 'ee/spec/lib/gitlab/ci/config/security_orchestration_policies/processor_spec.rb' @@ -2015,14 +1849,9 @@ Layout/LineLength: - 'ee/spec/mailers/emails/requirements_spec.rb' - 'ee/spec/mailers/license_mailer_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/migrations/drop_invalid_remediations_spec.rb' - 'ee/spec/migrations/geo/migrate_ci_job_artifacts_to_separate_registry_spec.rb' - 'ee/spec/migrations/geo/migrate_lfs_objects_to_separate_registry_spec.rb' - 'ee/spec/migrations/geo/set_resync_flag_for_retried_projects_spec.rb' - - 'ee/spec/migrations/schedule_populate_test_reports_issue_id_spec.rb' - - 'ee/spec/migrations/schedule_requirements_migration_spec.rb' - - 'ee/spec/migrations/schedule_trace_expiry_removal_spec.rb' - - 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/models/allowed_email_domain_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/group_level_spec.rb' - 'ee/spec/models/analytics/devops_adoption/enabled_namespace_spec.rb' @@ -2043,7 +1872,7 @@ Layout/LineLength: - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - 'ee/spec/models/ci/minutes/project_monthly_usage_spec.rb' - 'ee/spec/models/ci/pipeline_spec.rb' - - 'ee/spec/models/concerns/ee/clusters/agents/authorization_config_scopes_spec.rb' + - 'ee/spec/models/concerns/ee/clusters/agents/authorizations/ci_access/config_scopes_spec.rb' - 'ee/spec/models/concerns/ee/issuable_spec.rb' - 'ee/spec/models/concerns/ee/noteable_spec.rb' - 'ee/spec/models/concerns/ee/project_security_scanners_information_spec.rb' @@ -2077,7 +1906,6 @@ Layout/LineLength: - 'ee/spec/models/ee/group_spec.rb' - 'ee/spec/models/ee/incident_management/project_incident_management_setting_spec.rb' - 'ee/spec/models/ee/integrations/jira_spec.rb' - - 'ee/spec/models/ee/iteration_spec.rb' - 'ee/spec/models/ee/iterations/cadence_spec.rb' - 'ee/spec/models/ee/lfs_object_spec.rb' - 'ee/spec/models/ee/merge_request_diff_spec.rb' @@ -2116,12 +1944,12 @@ Layout/LineLength: - 'ee/spec/models/integrations/chat_message/vulnerability_message_spec.rb' - 'ee/spec/models/issuable_sla_spec.rb' - 'ee/spec/models/issue_spec.rb' + - 'ee/spec/models/iteration_spec.rb' - 'ee/spec/models/license_spec.rb' - 'ee/spec/models/member_spec.rb' - 'ee/spec/models/merge_request_spec.rb' - 'ee/spec/models/merge_requests/compliance_violation_spec.rb' - 'ee/spec/models/merge_requests/external_status_check_spec.rb' - - 'ee/spec/models/merge_train_spec.rb' - 'ee/spec/models/namespace_setting_spec.rb' - 'ee/spec/models/note_spec.rb' - 'ee/spec/models/packages/package_file_spec.rb' @@ -2374,7 +2202,6 @@ Layout/LineLength: - 'ee/spec/services/ci/compare_security_reports_service_spec.rb' - 'ee/spec/services/ci/create_pipeline_service/compliance_spec.rb' - 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb' - - 'ee/spec/services/ci/minutes/batch_reset_service_spec.rb' - 'ee/spec/services/ci/minutes/refresh_cached_data_service_spec.rb' - 'ee/spec/services/ci/minutes/update_project_and_namespace_usage_service_spec.rb' - 'ee/spec/services/ci/process_build_service_spec.rb' @@ -2422,7 +2249,6 @@ Layout/LineLength: - 'ee/spec/services/epic_issues/create_service_spec.rb' - 'ee/spec/services/epics/issue_promote_service_spec.rb' - 'ee/spec/services/epics/related_epic_links/create_service_spec.rb' - - 'ee/spec/services/epics/tree_reorder_service_spec.rb' - 'ee/spec/services/epics/update_dates_service_spec.rb' - 'ee/spec/services/epics/update_service_spec.rb' - 'ee/spec/services/external_status_checks/update_service_spec.rb' @@ -2470,7 +2296,6 @@ Layout/LineLength: - 'ee/spec/services/jira/requests/issues/list_service_spec.rb' - 'ee/spec/services/ldap_group_reset_service_spec.rb' - 'ee/spec/services/members/activate_service_spec.rb' - - 'ee/spec/services/merge_commits/export_csv_service_spec.rb' - 'ee/spec/services/merge_requests/merge_service_spec.rb' - 'ee/spec/services/merge_requests/push_options_handler_service_spec.rb' - 'ee/spec/services/merge_requests/reset_approvals_service_spec.rb' @@ -2609,10 +2434,8 @@ Layout/LineLength: - 'ee/spec/views/admin/application_settings/general.html.haml_spec.rb' - 'ee/spec/views/admin/dashboard/index.html.haml_spec.rb' - 'ee/spec/views/compliance_management/compliance_framework/_project_settings.html.haml_spec.rb' - - 'ee/spec/views/groups/feature_discovery_moments/advanced_features_dashboard.html.haml_spec.rb' - 'ee/spec/views/groups/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_current_user_dropdown.html.haml_spec.rb' - - 'ee/spec/views/layouts/header/help_dropdown/_cross_stage_fdm.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'ee/spec/views/operations/environments.html.haml_spec.rb' - 'ee/spec/views/projects/security/discover/show.html.haml_spec.rb' @@ -2796,7 +2619,6 @@ Layout/LineLength: - 'lib/banzai/filter/markdown_post_escape_filter.rb' - 'lib/banzai/filter/references/external_issue_reference_filter.rb' - 'lib/banzai/filter/references/issue_reference_filter.rb' - - 'lib/banzai/filter/references/iteration_reference_filter.rb' - 'lib/banzai/filter/references/milestone_reference_filter.rb' - 'lib/banzai/filter/references/reference_filter.rb' - 'lib/banzai/filter/references/vulnerability_reference_filter.rb' @@ -2850,27 +2672,17 @@ Layout/LineLength: - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'lib/gitlab/background_migration/backfill_snippet_repositories.rb' - 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb' - - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - 'lib/gitlab/background_migration/create_security_setting.rb' - - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - - 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb' - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' - - 'lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature.rb' - - 'lib/gitlab/background_migration/populate_namespace_statistics.rb' - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - 'lib/gitlab/bitbucket_import/importer.rb' - 'lib/gitlab/bitbucket_server_import/importer.rb' - 'lib/gitlab/buffered_io.rb' @@ -2964,7 +2776,6 @@ Layout/LineLength: - 'lib/gitlab/database/with_lock_retries.rb' - 'lib/gitlab/database/with_lock_retries_outside_transaction.rb' - 'lib/gitlab/database_importers/instance_administrators/create_group.rb' - - 'lib/gitlab/database_importers/self_monitoring/project/create_service.rb' - 'lib/gitlab/dependency_linker/base_linker.rb' - 'lib/gitlab/dependency_linker/go_mod_linker.rb' - 'lib/gitlab/dependency_linker/go_sum_linker.rb' @@ -3020,8 +2831,6 @@ Layout/LineLength: - 'lib/gitlab/github_import.rb' - 'lib/gitlab/github_import/importer/pull_request_importer.rb' - 'lib/gitlab/github_import/parallel_scheduling.rb' - - 'lib/gitlab/gitlab_import/client.rb' - - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/gl_repository.rb' - 'lib/gitlab/global_id/deprecations.rb' - 'lib/gitlab/golang.rb' @@ -3043,7 +2852,6 @@ Layout/LineLength: - 'lib/gitlab/import_export/file_importer.rb' - 'lib/gitlab/import_export/group/relation_tree_restorer.rb' - 'lib/gitlab/import_export/importer.rb' - - 'lib/gitlab/import_export/json/legacy_reader.rb' - 'lib/gitlab/import_export/json/streaming_serializer.rb' - 'lib/gitlab/import_export/lfs_saver.rb' - 'lib/gitlab/import_export/members_mapper.rb' @@ -3059,10 +2867,8 @@ Layout/LineLength: - 'lib/gitlab/jira_import.rb' - 'lib/gitlab/jira_import/base_importer.rb' - 'lib/gitlab/jira_import/issues_importer.rb' - - 'lib/gitlab/kubernetes/helm/pod.rb' - 'lib/gitlab/kubernetes/kubectl_cmd.rb' - 'lib/gitlab/kubernetes/pod_cmd.rb' - - 'lib/gitlab/legacy_github_import/importer.rb' - 'lib/gitlab/legacy_github_import/project_creator.rb' - 'lib/gitlab/local_and_remote_storage_migration/base_migrater.rb' - 'lib/gitlab/lograge/custom_options.rb' @@ -3121,7 +2927,6 @@ Layout/LineLength: - 'lib/gitlab/setup_helper.rb' - 'lib/gitlab/sidekiq_config.rb' - 'lib/gitlab/sidekiq_config/worker_router.rb' - - 'lib/gitlab/sidekiq_daemon/memory_killer.rb' - 'lib/gitlab/sidekiq_daemon/monitor.rb' - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/deduplicates_when_scheduling.rb' - 'lib/gitlab/sidekiq_middleware/server_metrics.rb' @@ -3150,7 +2955,6 @@ Layout/LineLength: - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' - 'lib/gitlab/usage_data_counters/issue_activity_unique_counter.rb' - 'lib/gitlab/usage_data_counters/jetbrains_plugin_activity_unique_counter.rb' - - 'lib/gitlab/usage_data_counters/track_unique_events.rb' - 'lib/gitlab/utils/delegator_override/error.rb' - 'lib/gitlab/utils/markdown.rb' - 'lib/gitlab/utils/override.rb' @@ -3238,7 +3042,6 @@ Layout/LineLength: - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/rate_limits_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - - 'qa/qa/specs/features/api/1_manage/users_spec.rb' - 'qa/qa/specs/features/api/3_create/merge_request/push_options_labels_spec.rb' - 'qa/qa/specs/features/api/3_create/merge_request/push_options_mwps_spec.rb' - 'qa/qa/specs/features/api/3_create/repository/default_branch_name_setting_spec.rb' @@ -3256,9 +3059,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/1_manage/login/log_into_mattermost_via_gitlab_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/maintain_log_in_mixed_env_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_badge_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb' @@ -3299,14 +3099,11 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/3_create/snippet/create_project_snippet_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/snippet/create_project_snippet_with_multiple_files_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/snippet/share_snippet_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/add_new_directory_in_web_ide_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/create_first_file_in_web_ide_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/link_to_line_in_web_ide_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_fork_in_web_ide_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_web_ide_from_diff_tab_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/review_merge_request_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/create_first_file_in_web_ide_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/link_to_line_in_web_ide_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/open_web_ide_from_diff_tab_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/review_merge_request_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/ci_variable/pipeline_with_protected_variable_spec.rb' - - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/create_and_process_pipeline_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_local_config_file_paths_with_wildcard_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_multiple_files_from_a_project_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/merge_mr_when_pipline_is_blocked_spec.rb' @@ -3340,8 +3137,6 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/share_group_with_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/burndown_chart/burndown_chart_spec.rb' @@ -3526,6 +3321,8 @@ Layout/LineLength: - 'spec/factories/ci/job_artifacts.rb' - 'spec/factories/ci/pipelines.rb' - 'spec/factories/ci/reports/codequality_degradations.rb' + - 'spec/factories/clusters/agents/authorizations/ci_access/group_authorizations.rb' + - 'spec/factories/clusters/agents/authorizations/ci_access/project_authorizations.rb' - 'spec/factories/container_repositories.rb' - 'spec/factories/dependency_proxy.rb' - 'spec/factories/deployments.rb' @@ -3536,7 +3333,6 @@ Layout/LineLength: - 'spec/factories/keys.rb' - 'spec/factories/namespaces.rb' - 'spec/factories/notes.rb' - - 'spec/factories/packages/debian/file_metadatum.rb' - 'spec/factories/packages/package_files.rb' - 'spec/factories/project_members.rb' - 'spec/factories/projects.rb' @@ -3590,7 +3386,6 @@ Layout/LineLength: - 'spec/features/groups/settings/repository_spec.rb' - 'spec/features/groups_spec.rb' - 'spec/features/ide/static_object_external_storage_csp_spec.rb' - - 'spec/features/invites_spec.rb' - 'spec/features/issuables/issuable_list_spec.rb' - 'spec/features/issuables/markdown_references/internal_references_spec.rb' - 'spec/features/issuables/markdown_references/jira_spec.rb' @@ -3755,7 +3550,7 @@ Layout/LineLength: - 'spec/finders/ci/pipelines_finder_spec.rb' - 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb' - 'spec/finders/ci/runners_finder_spec.rb' - - 'spec/finders/clusters/agent_authorizations_finder_spec.rb' + - 'spec/finders/clusters/agents/authorizations/ci_access/finder_spec.rb' - 'spec/finders/clusters_finder_spec.rb' - 'spec/finders/deploy_tokens/tokens_finder_spec.rb' - 'spec/finders/deployments_finder_spec.rb' @@ -3790,7 +3585,6 @@ Layout/LineLength: - 'spec/finders/projects_finder_spec.rb' - 'spec/finders/repositories/tree_finder_spec.rb' - 'spec/finders/security/security_jobs_finder_spec.rb' - - 'spec/finders/serverless_domain_finder_spec.rb' - 'spec/finders/snippets_finder_spec.rb' - 'spec/finders/tags_finder_spec.rb' - 'spec/finders/todos_finder_spec.rb' @@ -3894,7 +3688,6 @@ Layout/LineLength: - 'spec/helpers/blob_helper_spec.rb' - 'spec/helpers/boards_helper_spec.rb' - 'spec/helpers/branches_helper_spec.rb' - - 'spec/helpers/broadcast_messages_helper_spec.rb' - 'spec/helpers/button_helper_spec.rb' - 'spec/helpers/ci/pipeline_editor_helper_spec.rb' - 'spec/helpers/clusters_helper_spec.rb' @@ -4036,7 +3829,6 @@ Layout/LineLength: - 'spec/lib/error_tracking/sentry_client/projects_spec.rb' - 'spec/lib/event_filter_spec.rb' - 'spec/lib/feature_spec.rb' - - 'spec/lib/generators/gitlab/snowplow_event_definition_generator_spec.rb' - 'spec/lib/generators/gitlab/usage_metric_definition/redis_hll_generator_spec.rb' - 'spec/lib/generators/gitlab/usage_metric_definition_generator_spec.rb' - 'spec/lib/generators/gitlab/usage_metric_generator_spec.rb' @@ -4073,33 +3865,17 @@ Layout/LineLength: - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb' - - 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/delete_orphaned_deployments_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/extract_project_topics_into_separate_table_spec.rb' - 'spec/lib/gitlab/background_migration/fix_duplicate_project_name_and_path_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_first_mentioned_in_commit_at_spec.rb' - 'spec/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata_spec.rb' - 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner_spec.rb' - - 'spec/lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature_spec.rb' - 'spec/lib/gitlab/background_migration/populate_container_repository_migration_plan_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_vulnerability_finding_links_spec.rb' - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - - 'spec/lib/gitlab/background_migration/update_timelogs_null_spent_at_spec.rb' - - 'spec/lib/gitlab/background_migration/update_timelogs_project_id_spec.rb' - - 'spec/lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' - 'spec/lib/gitlab/buffered_io_spec.rb' @@ -4150,7 +3926,6 @@ Layout/LineLength: - 'spec/lib/gitlab/ci/reports/codequality_mr_diff_spec.rb' - 'spec/lib/gitlab/ci/reports/security/flag_spec.rb' - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/runner_upgrade_check_spec.rb' - 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb' - 'spec/lib/gitlab/ci/status/build/manual_spec.rb' @@ -4223,7 +3998,6 @@ Layout/LineLength: - 'spec/lib/gitlab/database/transaction/observer_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' - - 'spec/lib/gitlab/database_importers/self_monitoring/project/create_service_spec.rb' - 'spec/lib/gitlab/database_spec.rb' - 'spec/lib/gitlab/dependency_linker/package_json_linker_spec.rb' - 'spec/lib/gitlab/dependency_linker/requirements_txt_linker_spec.rb' @@ -4344,8 +4118,6 @@ Layout/LineLength: - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kas_spec.rb' - 'spec/lib/gitlab/kubernetes/deployment_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/pod_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - 'spec/lib/gitlab/kubernetes/kubectl_cmd_spec.rb' - 'spec/lib/gitlab/kubernetes/namespace_spec.rb' @@ -4395,12 +4167,8 @@ Layout/LineLength: - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' - 'spec/lib/gitlab/performance_bar/redis_adapter_when_peek_enabled_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - - 'spec/lib/gitlab/phabricator_import/user_finder_spec.rb' - 'spec/lib/gitlab/project_search_results_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/prometheus/query_variables_spec.rb' - 'spec/lib/gitlab/prometheus_client_spec.rb' @@ -4419,9 +4187,7 @@ Layout/LineLength: - 'spec/lib/gitlab/search/found_blob_spec.rb' - 'spec/lib/gitlab/search_results_spec.rb' - 'spec/lib/gitlab/serializer/pagination_spec.rb' - - 'spec/lib/gitlab/serverless/service_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb' @@ -4463,7 +4229,6 @@ Layout/LineLength: - 'spec/lib/gitlab/usage_data_counters/issue_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/jetbrains_plugin_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/merge_request_activity_unique_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/track_unique_events_spec.rb' - 'spec/lib/gitlab/usage_data_metrics_spec.rb' - 'spec/lib/gitlab/usage_data_non_sql_metrics_spec.rb' - 'spec/lib/gitlab/usage_data_queries_spec.rb' @@ -4511,38 +4276,10 @@ Layout/LineLength: - 'spec/mailers/emails/releases_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20210831203408_upsert_base_work_item_types_spec.rb' - - 'spec/migrations/20210907211557_finalize_ci_builds_bigint_conversion_spec.rb' - - 'spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211110143306_add_not_null_constraint_to_security_findings_uuid_spec.rb' - - 'spec/migrations/20211110151350_schedule_drop_invalid_security_findings_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20211117084814_migrate_remaining_u2f_registrations_spec.rb' - - 'spec/migrations/20211126204445_add_task_to_work_item_types_spec.rb' - - 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb' - - 'spec/migrations/20211203091642_add_index_to_projects_on_marked_for_deletion_at_spec.rb' - - 'spec/migrations/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4_spec.rb' - - 'spec/migrations/20211210140629_encrypt_static_object_token_spec.rb' - - 'spec/migrations/20220106111958_add_insert_or_update_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220106112043_add_update_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220106112085_add_update_vulnerability_reads_location_trigger_spec.rb' - - 'spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - - 'spec/migrations/20220222192524_create_not_null_constraint_releases_tag_spec.rb' - - 'spec/migrations/20220309084954_remove_leftover_external_pull_request_deletions_spec.rb' - 'spec/migrations/active_record/schema_spec.rb' - - 'spec/migrations/backfill_all_project_namespaces_spec.rb' - - 'spec/migrations/backfill_project_namespaces_for_group_spec.rb' - 'spec/migrations/cleanup_after_fixing_issue_when_admin_changed_primary_email_spec.rb' - 'spec/migrations/finalize_project_namespaces_backfill_spec.rb' - 'spec/migrations/fix_and_backfill_project_namespaces_for_projects_with_duplicate_name_spec.rb' - - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_features_spec.rb' - - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features_spec.rb' - - 'spec/migrations/remove_not_null_contraint_on_title_from_sprints_spec.rb' - - 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'spec/migrations/schedule_update_timelogs_null_spent_at_spec.rb' - - 'spec/migrations/update_invalid_member_states_spec.rb' - 'spec/models/active_session_spec.rb' - 'spec/models/acts_as_taggable_on/tag_spec.rb' - 'spec/models/acts_as_taggable_on/tagging_spec.rb' @@ -4555,7 +4292,6 @@ Layout/LineLength: - 'spec/models/award_emoji_spec.rb' - 'spec/models/blob_viewer/go_mod_spec.rb' - 'spec/models/blob_viewer/metrics_dashboard_yml_spec.rb' - - 'spec/models/broadcast_message_spec.rb' - 'spec/models/bulk_import_spec.rb' - 'spec/models/bulk_imports/entity_spec.rb' - 'spec/models/bulk_imports/file_transfer/project_config_spec.rb' @@ -4573,9 +4309,6 @@ Layout/LineLength: - 'spec/models/ci/runner_spec.rb' - 'spec/models/ci/variable_spec.rb' - 'spec/models/clusters/agent_spec.rb' - - 'spec/models/clusters/applications/ingress_spec.rb' - - 'spec/models/clusters/applications/knative_spec.rb' - - 'spec/models/clusters/applications/prometheus_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - 'spec/models/clusters/platforms/kubernetes_spec.rb' - 'spec/models/commit_spec.rb' @@ -4583,7 +4316,7 @@ Layout/LineLength: - 'spec/models/concerns/cache_markdown_field_spec.rb' - 'spec/models/concerns/cacheable_attributes_spec.rb' - 'spec/models/concerns/ci/artifactable_spec.rb' - - 'spec/models/concerns/clusters/agents/authorization_config_scopes_spec.rb' + - 'spec/models/concerns/clusters/agents/authorizations/ci_access/config_scopes_spec.rb' - 'spec/models/concerns/deployment_platform_spec.rb' - 'spec/models/concerns/group_descendant_spec.rb' - 'spec/models/concerns/id_in_ordered_spec.rb' @@ -4671,7 +4404,6 @@ Layout/LineLength: - 'spec/models/packages/composer/metadatum_spec.rb' - 'spec/models/packages/conan/metadatum_spec.rb' - 'spec/models/packages/debian/file_entry_spec.rb' - - 'spec/models/packages/debian/file_metadatum_spec.rb' - 'spec/models/packages/debian/publication_spec.rb' - 'spec/models/packages/dependency_link_spec.rb' - 'spec/models/packages/dependency_spec.rb' @@ -4713,7 +4445,6 @@ Layout/LineLength: - 'spec/models/resource_state_event_spec.rb' - 'spec/models/sent_notification_spec.rb' - 'spec/models/sentry_issue_spec.rb' - - 'spec/models/serverless/domain_spec.rb' - 'spec/models/service_desk_setting_spec.rb' - 'spec/models/snippet_input_action_spec.rb' - 'spec/models/snippet_repository_spec.rb' @@ -4930,7 +4661,6 @@ Layout/LineLength: - 'spec/requests/groups/milestones_controller_spec.rb' - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/groups_controller_spec.rb' - - 'spec/requests/ide_controller_spec.rb' - 'spec/requests/jwt_controller_spec.rb' - 'spec/requests/lfs_http_spec.rb' - 'spec/requests/oauth/tokens_controller_spec.rb' @@ -5035,6 +4765,7 @@ Layout/LineLength: - 'spec/services/ci/test_failure_history_service_spec.rb' - 'spec/services/ci/unlock_artifacts_service_spec.rb' - 'spec/services/ci/update_pending_build_service_spec.rb' + - 'spec/services/clusters/agents/authorizations/ci_access/filter_service_spec.rb' - 'spec/services/clusters/create_service_spec.rb' - 'spec/services/clusters/integrations/prometheus_health_check_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' @@ -5116,7 +4847,6 @@ Layout/LineLength: - 'spec/services/lfs/push_service_spec.rb' - 'spec/services/loose_foreign_keys/batch_cleaner_service_spec.rb' - 'spec/services/loose_foreign_keys/cleaner_service_spec.rb' - - 'spec/services/members/approve_access_request_service_spec.rb' - 'spec/services/members/create_service_spec.rb' - 'spec/services/members/destroy_service_spec.rb' - 'spec/services/members/invitation_reminder_email_service_spec.rb' @@ -5266,11 +4996,10 @@ Layout/LineLength: - 'spec/spec_helper.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' - 'spec/support/capybara.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/database/prevent_cross_database_modification.rb' - 'spec/support/database/prevent_cross_joins.rb' - 'spec/support/db_cleaner.rb' - - 'spec/support/flaky_tests.rb' + - 'spec/support/fast_quarantine.rb' - 'spec/support/helpers/api_helpers.rb' - 'spec/support/helpers/board_helpers.rb' - 'spec/support/helpers/cycle_analytics_helpers.rb' @@ -5485,10 +5214,9 @@ Layout/LineLength: - 'spec/tasks/migrate/schema_check_rake_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/danger/feature_flag_spec.rb' - - 'spec/tooling/danger/product_intelligence_spec.rb' + - 'spec/tooling/danger/analytics_instrumentation_spec.rb' - 'spec/tooling/danger/project_helper_spec.rb' - 'spec/tooling/danger/sidekiq_queues_spec.rb' - - 'spec/tooling/danger/specs_spec.rb' - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' - 'spec/tooling/lib/tooling/test_map_generator_spec.rb' - 'spec/tooling/quality/test_level_spec.rb' @@ -5537,7 +5265,6 @@ Layout/LineLength: - 'spec/workers/authorized_project_update/project_recalculate_per_user_worker_spec.rb' - 'spec/workers/authorized_project_update/user_refresh_from_replica_worker_spec.rb' - 'spec/workers/auto_devops/disable_worker_spec.rb' - - 'spec/workers/background_migration/ci_database_worker_spec.rb' - 'spec/workers/build_success_worker_spec.rb' - 'spec/workers/bulk_import_worker_spec.rb' - 'spec/workers/bulk_imports/export_request_worker_spec.rb' @@ -5602,8 +5329,7 @@ Layout/LineLength: - 'spec/workers/todos_destroyer/confidential_issue_worker_spec.rb' - 'spec/workers/update_head_pipeline_for_merge_request_worker_spec.rb' - 'spec/workers/users/deactivate_dormant_users_worker_spec.rb' - - 'tooling/bin/find_changes' - - 'tooling/danger/product_intelligence.rb' + - 'tooling/danger/analytics_instrumentation.rb' - 'tooling/danger/project_helper.rb' - 'tooling/danger/specs.rb' - 'tooling/graphql/docs/helper.rb' diff --git a/.rubocop_todo/layout/parameter_alignment.yml b/.rubocop_todo/layout/parameter_alignment.yml index 4fafbab6024..56a96fb82c1 100644 --- a/.rubocop_todo/layout/parameter_alignment.yml +++ b/.rubocop_todo/layout/parameter_alignment.yml @@ -3,15 +3,9 @@ Layout/ParameterAlignment: Details: grace period Exclude: - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'lib/gitlab/cross_project_access.rb' - 'lib/gitlab/data_builder/push.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/support/helpers/content_security_policy_helpers.rb' - 'spec/support/helpers/migrations_helpers/vulnerabilities_helper.rb' - 'spec/support/helpers/repo_helpers.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index 3abff1e8788..62aa752c376 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -20,7 +20,6 @@ Layout/SpaceInLambdaLiteral: - 'app/models/clusters/agent.rb' - 'app/models/clusters/agent_token.rb' - 'app/models/clusters/agents/activity_event.rb' - - 'app/models/clusters/applications/knative.rb' - 'app/models/clusters/cluster.rb' - 'app/models/clusters/kubernetes_namespace.rb' - 'app/models/commit_status.rb' @@ -36,7 +35,6 @@ Layout/SpaceInLambdaLiteral: - 'app/models/concerns/issuable.rb' - 'app/models/concerns/mentionable.rb' - 'app/models/concerns/milestoneable.rb' - - 'app/models/concerns/protected_ref_access.rb' - 'app/models/concerns/reactive_caching.rb' - 'app/models/concerns/shardable.rb' - 'app/models/concerns/timebox.rb' @@ -119,7 +117,6 @@ Layout/SpaceInLambdaLiteral: - 'app/serializers/ci/job_entity.rb' - 'app/serializers/ci/pipeline_entity.rb' - 'app/serializers/ci/trigger_entity.rb' - - 'app/serializers/cluster_application_entity.rb' - 'app/serializers/concerns/user_status_tooltip.rb' - 'app/serializers/container_repository_entity.rb' - 'app/serializers/container_tag_entity.rb' @@ -202,7 +199,6 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/models/ee/group.rb' - 'ee/app/models/ee/group_group_link.rb' - 'ee/app/models/ee/issue.rb' - - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/list.rb' - 'ee/app/models/ee/member.rb' - 'ee/app/models/ee/namespace.rb' @@ -220,10 +216,10 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/models/incident_management/oncall_rotation.rb' - 'ee/app/models/incident_management/oncall_schedule.rb' - 'ee/app/models/incident_management/oncall_shift.rb' + - 'ee/app/models/iteration.rb' - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/merge_request_block.rb' - 'ee/app/models/merge_requests/compliance_violation.rb' - - 'ee/app/models/merge_train.rb' - 'ee/app/models/namespaces/namespace_ban.rb' - 'ee/app/models/requirements_management/requirement.rb' - 'ee/app/models/resource_iteration_event.rb' @@ -234,7 +230,6 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/models/security/scan.rb' - 'ee/app/models/security/training.rb' - 'ee/app/models/security/training_provider.rb' - - 'ee/app/models/slack_integration.rb' - 'ee/app/models/software_license.rb' - 'ee/app/models/software_license_policy.rb' - 'ee/app/models/vulnerabilities/external_issue_link.rb' @@ -279,7 +274,6 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/services/groups/memberships/export_service.rb' - 'ee/app/services/groups/seat_usage_export_service.rb' - 'ee/app/services/historical_user_data/csv_service.rb' - - 'ee/app/services/merge_commits/export_csv_service.rb' - 'ee/app/services/user_permissions/export_service.rb' - 'ee/app/services/vulnerability_exports/exporters/csv_service.rb' - 'ee/app/workers/update_all_mirrors_worker.rb' @@ -353,7 +347,6 @@ Layout/SpaceInLambdaLiteral: - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'lib/gitlab/background_migration/purge_stale_security_scans.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - 'lib/gitlab/cache/helpers.rb' - 'lib/gitlab/ci/config/entry/inherit/default.rb' - 'lib/gitlab/ci/config/entry/inherit/variables.rb' @@ -398,9 +391,7 @@ Layout/SpaceInLambdaLiteral: - 'spec/lib/gitlab/sidekiq_signals_spec.rb' - 'spec/lib/gitlab/utils/sanitize_node_link_spec.rb' - 'spec/models/ability_spec.rb' - - 'spec/models/broadcast_message_spec.rb' - 'spec/models/concerns/participable_spec.rb' - - 'spec/models/concerns/uniquify_spec.rb' - 'spec/models/merge_request_spec.rb' - 'spec/support/shared_examples/lib/cache_helpers_shared_examples.rb' - 'spec/support/shared_examples/workers/batched_background_migration_worker_shared_examples.rb' diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml index 131a56976a6..b27fae0c6be 100644 --- a/.rubocop_todo/layout/space_inside_parens.yml +++ b/.rubocop_todo/layout/space_inside_parens.yml @@ -21,12 +21,10 @@ Layout/SpaceInsideParens: - 'ee/spec/lib/gitlab/search/index_curator_spec.rb' - 'ee/spec/lib/world_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/migrations/drop_invalid_remediations_spec.rb' - 'ee/spec/models/allowed_email_domain_spec.rb' - 'ee/spec/models/boards/epic_board_position_spec.rb' - 'ee/spec/models/dora/change_failure_rate_metric_spec.rb' - 'ee/spec/models/ee/integrations/jira_spec.rb' - - 'ee/spec/models/ee/iteration_spec.rb' - 'ee/spec/models/ee/iterations/cadence_spec.rb' - 'ee/spec/models/ee/key_spec.rb' - 'ee/spec/models/ee/project_setting_spec.rb' @@ -35,6 +33,7 @@ Layout/SpaceInsideParens: - 'ee/spec/models/geo/every_geo_event_spec.rb' - 'ee/spec/models/incident_management/escalation_rule_spec.rb' - 'ee/spec/models/ip_restriction_spec.rb' + - 'ee/spec/models/iteration_spec.rb' - 'ee/spec/models/ldap_group_link_spec.rb' - 'ee/spec/models/license_spec.rb' - 'ee/spec/models/member_spec.rb' @@ -68,7 +67,6 @@ Layout/SpaceInsideParens: - 'ee/spec/services/ee/users/update_service_spec.rb' - 'ee/spec/services/epic_issues/update_service_spec.rb' - 'ee/spec/services/epics/related_epic_links/destroy_service_spec.rb' - - 'ee/spec/services/epics/tree_reorder_service_spec.rb' - 'ee/spec/services/geo/container_repository_sync_spec.rb' - 'ee/spec/services/geo/replication_toggle_request_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb' @@ -98,7 +96,6 @@ Layout/SpaceInsideParens: - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/badges_helper_spec.rb' - 'spec/helpers/ci/builds_helper_spec.rb' - - 'spec/helpers/ci/runners_helper_spec.rb' - 'spec/helpers/dev_ops_report_helper_spec.rb' - 'spec/helpers/git_helper_spec.rb' - 'spec/helpers/gitlab_routing_helper_spec.rb' @@ -128,7 +125,6 @@ Layout/SpaceInsideParens: - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/parsers_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/test_suite_spec.rb' - 'spec/lib/gitlab/ci/templates/AWS/deploy_ecs_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/ci/templates/MATLAB_spec.rb' @@ -167,7 +163,6 @@ Layout/SpaceInsideParens: - 'spec/lib/gitlab/kubernetes/rollout_status_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' - 'spec/lib/gitlab/middleware/same_site_cookies_spec.rb' - - 'spec/lib/gitlab/rack_attack/instrumented_cache_store_spec.rb' - 'spec/lib/gitlab/redis/cache_spec.rb' - 'spec/lib/gitlab/redis/queues_spec.rb' - 'spec/lib/gitlab/redis/shared_state_spec.rb' @@ -185,7 +180,6 @@ Layout/SpaceInsideParens: - 'spec/lib/security/ci_configuration/sast_iac_build_action_spec.rb' - 'spec/lib/security/ci_configuration/secret_detection_build_action_spec.rb' - 'spec/mailers/emails/profile_spec.rb' - - 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb' - 'spec/models/ci/pending_build_spec.rb' - 'spec/models/ci/running_build_spec.rb' - 'spec/models/ml/candidate_metric_spec.rb' @@ -227,7 +221,6 @@ Layout/SpaceInsideParens: - 'spec/views/dashboard/projects/_blank_state_welcome.html.haml_spec.rb' - 'spec/views/profiles/keys/_form.html.haml_spec.rb' - 'spec/views/search/_results.html.haml_spec.rb' - - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' - 'spec/workers/gitlab/jira_import/stage/import_labels_worker_spec.rb' - 'spec/workers/pipeline_schedule_worker_spec.rb' diff --git a/.rubocop_todo/layout/trailing_whitespace.yml b/.rubocop_todo/layout/trailing_whitespace.yml index 1395fa78e35..35db371a055 100644 --- a/.rubocop_todo/layout/trailing_whitespace.yml +++ b/.rubocop_todo/layout/trailing_whitespace.yml @@ -6,7 +6,6 @@ Layout/TrailingWhitespace: - 'db/migrate/20220913082728_drop_index_cadence_create_iterations_automation.rb' - 'db/post_migrate/20220816163444_update_start_date_for_iterations_cadences.rb' - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' - - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' - 'lib/gitlab/pagination/keyset/sql_type_missing_error.rb' - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/support/helpers/x509_helpers.rb' diff --git a/.rubocop_todo/lint/ambiguous_operator_precedence.yml b/.rubocop_todo/lint/ambiguous_operator_precedence.yml index ea6cadc7f8a..a890c6af6d0 100644 --- a/.rubocop_todo/lint/ambiguous_operator_precedence.yml +++ b/.rubocop_todo/lint/ambiguous_operator_precedence.yml @@ -30,7 +30,6 @@ Lint/AmbiguousOperatorPrecedence: - 'app/services/issuable_links/create_service.rb' - 'app/services/issues/relative_position_rebalancing_service.rb' - 'app/services/jira/requests/base.rb' - - 'app/services/projects/blame_service.rb' - 'config/initializers/1_settings.rb' - 'config/initializers/carrierwave_patch.rb' - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' @@ -39,7 +38,6 @@ Lint/AmbiguousOperatorPrecedence: - 'ee/app/models/geo/upload_registry.rb' - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/license.rb' - - 'ee/app/models/namespaces/storage/root_size.rb' - 'ee/app/policies/ee/issuable_policy.rb' - 'ee/app/services/boards/epics/position_create_service.rb' - 'ee/app/services/geo/registry_consistency_service.rb' @@ -82,7 +80,6 @@ Lint/AmbiguousOperatorPrecedence: - 'lib/gitlab/template_parser/parser.rb' - 'lib/gitlab/tree_summary.rb' - 'lib/gitlab/usage/metrics/name_suggestion.rb' - - 'lib/gitlab/utils/email.rb' - 'lib/omni_auth/strategies/bitbucket.rb' - 'qa/qa/ee/page/project/secure/pipeline_security.rb' - 'qa/qa/resource/api_fabricator.rb' @@ -123,7 +120,6 @@ Lint/AmbiguousOperatorPrecedence: - 'spec/lib/gitlab/regex_spec.rb' - 'spec/lib/gitlab/search/abuse_validators/no_abusive_term_length_validator_spec.rb' - 'spec/lib/gitlab/slash_commands/deploy_spec.rb' - - 'spec/lib/gitlab/url_blocker_spec.rb' - 'spec/mailers/notify_spec.rb' - 'spec/models/appearance_spec.rb' - 'spec/models/ci/build_spec.rb' @@ -143,7 +139,6 @@ Lint/AmbiguousOperatorPrecedence: - 'spec/services/ci/pipeline_schedules/calculate_next_run_service_spec.rb' - 'spec/services/issues/relative_position_rebalancing_service_spec.rb' - 'spec/services/web_hook_service_spec.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/helpers/dependency_proxy_helpers.rb' - 'spec/support/models/ci/partitioning_testing/cascade_check.rb' - 'spec/support/shared_examples/features/sidebar_shared_examples.rb' diff --git a/.rubocop_todo/lint/ambiguous_range.yml b/.rubocop_todo/lint/ambiguous_range.yml index 3d6f49a4846..155c1a36128 100644 --- a/.rubocop_todo/lint/ambiguous_range.yml +++ b/.rubocop_todo/lint/ambiguous_range.yml @@ -4,7 +4,7 @@ Lint/AmbiguousRange: Details: grace period Exclude: - 'app/models/ci/runner.rb' - - 'app/models/ci/runner_machine.rb' + - 'app/models/ci/runner_manager.rb' - 'app/services/clusters/agent_tokens/track_usage_service.rb' - 'lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb' - 'spec/lib/gitlab/database/reindexing/reindex_concurrently_spec.rb' diff --git a/.rubocop_todo/lint/ambiguous_regexp_literal.yml b/.rubocop_todo/lint/ambiguous_regexp_literal.yml index d0160d620d5..6f2b8f03f8a 100644 --- a/.rubocop_todo/lint/ambiguous_regexp_literal.yml +++ b/.rubocop_todo/lint/ambiguous_regexp_literal.yml @@ -62,8 +62,6 @@ Lint/AmbiguousRegexpLiteral: - 'spec/lib/gitlab/database/partitioning_spec.rb' - 'spec/lib/gitlab/database/query_analyzers/prevent_cross_database_modification_spec.rb' - 'spec/lib/gitlab/gitaly_client/with_feature_flag_actors_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/base_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/base_command_spec.rb' - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/array_scope_columns_spec.rb' - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb' - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' diff --git a/.rubocop_todo/lint/duplicate_branch.yml b/.rubocop_todo/lint/duplicate_branch.yml index 89d1ff7e2aa..6a171415cbc 100644 --- a/.rubocop_todo/lint/duplicate_branch.yml +++ b/.rubocop_todo/lint/duplicate_branch.yml @@ -33,4 +33,3 @@ Lint/DuplicateBranch: - 'lib/sidebars/groups/menus/settings_menu.rb' - 'qa/qa/resource/pipeline.rb' - 'scripts/rubocop-parse' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' diff --git a/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml b/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml index 813a27455a8..c0d46ba9e95 100644 --- a/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml +++ b/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml @@ -4,4 +4,3 @@ Lint/DuplicateRegexpCharacterClassElement: Details: grace period Exclude: - 'lib/gitlab/path_regex.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' diff --git a/.rubocop_todo/lint/empty_block.yml b/.rubocop_todo/lint/empty_block.yml index 8845fb3abe2..e111703ce3b 100644 --- a/.rubocop_todo/lint/empty_block.yml +++ b/.rubocop_todo/lint/empty_block.yml @@ -6,7 +6,6 @@ Lint/EmptyBlock: - 'app/controllers/projects/boards_controller.rb' - 'app/controllers/projects/pipelines_controller.rb' - 'app/experiments/logged_out_marketing_header_experiment.rb' - - 'app/experiments/security_reports_mr_widget_prompt_experiment.rb' - 'config/application.rb' - 'ee/app/controllers/projects/learn_gitlab_controller.rb' - 'ee/spec/factories/incident_management/escalation_rules.rb' @@ -109,7 +108,6 @@ Lint/EmptyBlock: - 'spec/lib/gitlab/database/migrations/instrumentation_spec.rb' - 'spec/lib/gitlab/database/migrations/lock_retries_helpers_spec.rb' - 'spec/lib/gitlab/database/migrations/observers/transaction_duration_spec.rb' - - 'spec/lib/gitlab/database/obsolete_ignored_columns_spec.rb' - 'spec/lib/gitlab/database/shared_model_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb' - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' @@ -138,10 +136,8 @@ Lint/EmptyBlock: - 'spec/lib/gitlab/patch/prependable_spec.rb' - 'spec/lib/gitlab/profiler_spec.rb' - 'spec/lib/gitlab/quick_actions/extractor_spec.rb' - - 'spec/lib/gitlab/rack_attack/instrumented_cache_store_spec.rb' - 'spec/lib/gitlab/search_context/builder_spec.rb' - 'spec/lib/gitlab/session_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/extra_done_log_metadata_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' diff --git a/.rubocop_todo/lint/missing_cop_enable_directive.yml b/.rubocop_todo/lint/missing_cop_enable_directive.yml index 8346468e4fc..8cfecb87f2b 100644 --- a/.rubocop_todo/lint/missing_cop_enable_directive.yml +++ b/.rubocop_todo/lint/missing_cop_enable_directive.yml @@ -67,7 +67,6 @@ Lint/MissingCopEnableDirective: - 'danger/feature_flag/Dangerfile' - 'danger/pajamas/Dangerfile' - 'danger/z_metadata/Dangerfile' - - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' - 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb' - 'ee/app/controllers/ee/admin/dashboard_controller.rb' - 'ee/app/controllers/ee/admin/groups_controller.rb' @@ -137,7 +136,6 @@ Lint/MissingCopEnableDirective: - 'ee/app/services/ee/ci/queue/build_queue_service.rb' - 'ee/app/workers/ci/runners/stale_group_runners_prune_cron_worker.rb' - 'ee/app/workers/groups/export_memberships_worker.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/lib/api/ldap_group_links.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' @@ -151,27 +149,16 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/background_migration/backfill_imported_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - 'lib/gitlab/background_migration/delete_invalid_epic_issues.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb' - - 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'lib/gitlab/background_migration/purge_stale_security_scans.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - - 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb' - 'lib/gitlab/buffered_io.rb' - 'lib/gitlab/ci/reports/test_suite_summary.rb' - 'lib/gitlab/data_builder/push.rb' @@ -195,6 +182,5 @@ Lint/MissingCopEnableDirective: - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb' - 'spec/support/capybara.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/google_api/cloud_platform_helpers.rb' - - 'tooling/danger/product_intelligence.rb' + - 'tooling/danger/analytics_instrumentation.rb' diff --git a/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml b/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml index 04115b12600..1d724ccc783 100644 --- a/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml +++ b/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml @@ -5,7 +5,6 @@ Lint/NoReturnInBeginEndBlocks: - 'app/models/concerns/metric_image_uploading.rb' - 'app/models/merge_request.rb' - 'app/services/security/ci_configuration/sast_parser_service.rb' - - 'app/services/work_items/parent_links/create_service.rb' - 'ee/app/services/epic_issues/create_service.rb' - 'ee/app/services/gitlab_subscriptions/preview_billable_user_change_service.rb' - 'ee/app/services/security/token_revocation_service.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index b5870b251b5..6274aecec04 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -50,7 +50,6 @@ Lint/RedundantCopDisableDirective: - 'app/services/issues/export_csv_service.rb' - 'app/services/labels/transfer_service.rb' - 'app/services/members/create_service.rb' - - 'app/services/members/creator_service.rb' - 'app/services/members/projects/creator_service.rb' - 'app/services/members/standard_member_builder.rb' - 'app/services/projects/auto_devops/disable_service.rb' @@ -78,13 +77,9 @@ Lint/RedundantCopDisableDirective: - 'config/initializers/wikicloth_redos_patch.rb' - 'config/initializers/wikicloth_ruby_3_patch.rb' - 'config/routes/api.rb' - - 'db/migrate/20210917134321_remove_temporary_index_for_project_topics_on_taggings.rb' - - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' - 'db/migrate/20220316022505_create_namespace_details.rb' - 'db/migrate/20220421141342_add_allowed_plans_to_ci_runners.rb' - 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb' - - 'db/post_migrate/20210906130643_drop_temporary_columns_and_triggers_for_taggings.rb' - - 'db/post_migrate/20211028100303_tmp_index_for_delete_issue_merge_request_taggings_records.rb' - 'db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb' - 'db/post_migrate/20220720090354_remove_pending_builds_covering_index_from_ci_builds.rb' @@ -96,7 +91,6 @@ Lint/RedundantCopDisableDirective: - 'ee/app/controllers/ee/groups/group_members_controller.rb' - 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb' - 'ee/app/controllers/groups/todos_controller.rb' - - 'ee/app/experiments/cart_abandonment_modal_experiment.rb' - 'ee/app/finders/epics/with_issues_finder.rb' - 'ee/app/finders/geo/file_registry_finder.rb' - 'ee/app/finders/geo/project_registry_finder.rb' @@ -153,7 +147,6 @@ Lint/RedundantCopDisableDirective: - 'ee/lib/gitlab/spdx/license.rb' - 'ee/lib/gitlab/status_page/storage/object.rb' - 'ee/spec/controllers/concerns/gitlab_subscriptions/seat_count_alert_spec.rb' - - 'ee/spec/controllers/concerns/registrations/verification_spec.rb' - 'ee/spec/controllers/concerns/routable_actions_spec.rb' - 'ee/spec/elastic/migrate/20221026082700_backfill_users_spec.rb' - 'ee/spec/features/boards/user_visits_board_spec.rb' @@ -190,12 +183,9 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'lib/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size.rb' - 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - 'lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics.rb' - 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb' - 'lib/gitlab/background_migration/re_expire_o_auth_tokens.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/bitbucket_import/importer.rb' @@ -228,7 +218,6 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/git/patches/collection.rb' - 'lib/gitlab/github_import/markdown_text.rb' - 'lib/gitlab/github_import/user_finder.rb' - - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/graphql/pagination/keyset/connection.rb' - 'lib/gitlab/health_checks/metric.rb' - 'lib/gitlab/health_checks/probes/status.rb' @@ -276,7 +265,6 @@ Lint/RedundantCopDisableDirective: - 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_statistics_with_container_registry_size_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/remove_backfilled_job_artifacts_expire_at_batching_strategy_spec.rb' - - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects_spec.rb' - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' @@ -329,7 +317,7 @@ Lint/RedundantCopDisableDirective: - 'spec/support/shared_examples/models/packages/debian/distribution_key_shared_examples.rb' - 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb' - 'spec/uploaders/packages/composer/cache_uploader_spec.rb' - - 'tooling/danger/product_intelligence.rb' + - 'tooling/danger/analytics_instrumentation.rb' - 'tooling/danger/stable_branch.rb' - 'tooling/danger/suggestor.rb' - 'tooling/lib/tooling/helm3_client.rb' diff --git a/.rubocop_todo/lint/symbol_conversion.yml b/.rubocop_todo/lint/symbol_conversion.yml index 537b32d856d..c7f8b9549fb 100644 --- a/.rubocop_todo/lint/symbol_conversion.yml +++ b/.rubocop_todo/lint/symbol_conversion.yml @@ -15,17 +15,11 @@ Lint/SymbolConversion: - 'ee/app/controllers/projects/security/scanned_resources_controller.rb' - 'ee/app/models/product_analytics/jitsu_authentication.rb' - 'ee/app/serializers/integrations/zentao_serializers/issue_entity.rb' - - 'ee/app/services/integrations/slack_interactions/incident_management/incident_modal_closed_service.rb' - - 'ee/app/services/integrations/slack_interactions/incident_management/incident_modal_submit_service.rb' - - 'ee/app/services/integrations/slack_interactions/slack_block_actions/incident_management/project_update_handler.rb' - - 'ee/app/services/integrations/slack_options/user_search_handler.rb' - 'ee/db/fixtures/development/35_merge_request_predictions.rb' - 'ee/lib/api/analytics/product_analytics.rb' - 'ee/lib/ee/gitlab/scim/attribute_transform.rb' - 'ee/lib/elastic/latest/note_class_proxy.rb' - 'ee/lib/gitlab/applied_ml/suggested_reviewers/client.rb' - - 'ee/lib/slack/block_kit/app_home_opened.rb' - - 'ee/lib/slack/block_kit/incident_management/incident_modal_opened.rb' - 'ee/spec/controllers/admin/audit_logs_controller_spec.rb' - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' @@ -36,7 +30,6 @@ Lint/SymbolConversion: - 'ee/spec/helpers/ee/environments_helper_spec.rb' - 'ee/spec/helpers/subscriptions_helper_spec.rb' - 'ee/spec/lib/arkose/logger_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/params_parser_spec.rb' - 'ee/spec/lib/ee/gitlab/tracking_spec.rb' @@ -54,13 +47,9 @@ Lint/SymbolConversion: - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/destroy_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/update_spec.rb' - - 'ee/spec/requests/api/integrations/slack/interactions_spec.rb' - - 'ee/spec/requests/api/integrations/slack/options_spec.rb' - 'ee/spec/requests/api/scim/group_scim_spec.rb' - 'ee/spec/requests/api/scim/instance_scim_spec.rb' - 'ee/spec/services/elastic/data_migration_service_spec.rb' - - 'ee/spec/services/integrations/slack_interactions/incident_management/incident_modal_closed_service_spec.rb' - - 'ee/spec/services/integrations/slack_interactions/incident_management/incident_modal_submit_service_spec.rb' - 'ee/spec/services/security/token_revocation_service_spec.rb' - 'ee/spec/support/helpers/subscription_portal_helpers.rb' - 'ee/spec/support/prometheus/additional_metrics_shared_examples.rb' @@ -84,7 +73,6 @@ Lint/SymbolConversion: - 'spec/controllers/jira_connect/branches_controller_spec.rb' - 'spec/factories/ci/reports/codequality_degradations.rb' - 'spec/factories/evidences.rb' - - 'spec/factories/packages/debian/file_metadatum.rb' - 'spec/factories/packages/helm/file_metadatum.rb' - 'spec/factories/packages/npm/metadata.rb' - 'spec/features/file_uploads/graphql_add_design_spec.rb' @@ -127,7 +115,6 @@ Lint/SymbolConversion: - 'spec/lib/gitlab/grape_logging/loggers/token_logger_spec.rb' - 'spec/lib/gitlab/harbor/client_spec.rb' - 'spec/lib/gitlab/harbor/query_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb' - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb' @@ -140,7 +127,6 @@ Lint/SymbolConversion: - 'spec/lib/service_ping/devops_report_spec.rb' - 'spec/models/integrations/prometheus_spec.rb' - 'spec/models/merge_request_diff_commit_spec.rb' - - 'spec/models/packages/debian/file_metadatum_spec.rb' - 'spec/models/packages/helm/file_metadatum_spec.rb' - 'spec/models/packages/npm/metadatum_spec.rb' - 'spec/presenters/packages/npm/package_presenter_spec.rb' diff --git a/.rubocop_todo/lint/triple_quotes.yml b/.rubocop_todo/lint/triple_quotes.yml deleted file mode 100644 index 7695fa46b03..00000000000 --- a/.rubocop_todo/lint/triple_quotes.yml +++ /dev/null @@ -1,7 +0,0 @@ ---- -# Cop supports --autocorrect. -Lint/TripleQuotes: - Details: grace period - Exclude: - - 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb' - - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' diff --git a/.rubocop_todo/lint/unused_block_argument.yml b/.rubocop_todo/lint/unused_block_argument.yml index f226f04445a..7676faf0275 100644 --- a/.rubocop_todo/lint/unused_block_argument.yml +++ b/.rubocop_todo/lint/unused_block_argument.yml @@ -33,12 +33,10 @@ Lint/UnusedBlockArgument: - 'app/models/clusters/cluster.rb' - 'app/models/concerns/atomic_internal_id.rb' - 'app/models/concerns/avatarable.rb' - - 'app/models/concerns/enum_with_nil.rb' - 'app/models/concerns/mentionable.rb' - 'app/models/customer_relations/organization.rb' - 'app/models/integration.rb' - 'app/models/merge_request.rb' - - 'app/models/namespace/root_storage_statistics.rb' - 'app/models/project.rb' - 'app/models/projects/build_artifacts_size_refresh.rb' - 'app/models/service_desk_setting.rb' @@ -87,7 +85,6 @@ Lint/UnusedBlockArgument: - 'config/initializers/warden.rb' - 'config/routes/project.rb' - 'config/routes/wiki.rb' - - 'db/post_migrate/20211117084814_migrate_remaining_u2f_registrations.rb' - 'ee/app/finders/security/training_providers/kontra_url_finder.rb' - 'ee/app/finders/security/training_providers/secure_code_warrior_url_finder.rb' - 'ee/app/graphql/resolvers/incident_management/escalation_policies_resolver.rb' @@ -122,7 +119,6 @@ Lint/UnusedBlockArgument: - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/lib/tasks/gitlab/indexer.rake' - 'ee/lib/tasks/gitlab/seed/insights.rake' - - 'ee/spec/config/metrics/every_metric_definition_spec.rb' - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/elastic/migrate/20220613120500_migrate_commits_to_separate_index_spec.rb' @@ -136,15 +132,12 @@ Lint/UnusedBlockArgument: - 'ee/spec/factories/projects.rb' - 'ee/spec/factories/protected_branches.rb' - 'ee/spec/factories/protected_environments.rb' - - 'ee/spec/factories/slack_integrations.rb' - 'ee/spec/factories/users.rb' - - 'ee/spec/features/billings/extend_reactivate_trial_spec.rb' - 'ee/spec/features/groups/group_settings_spec.rb' - 'ee/spec/graphql/mutations/dast/profiles/update_spec.rb' - 'ee/spec/graphql/resolvers/analytics/contribution_analytics/contributions_resolver_spec.rb' - 'ee/spec/lib/compliance_management/compliance_report/commit_loader_spec.rb' - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - 'ee/spec/lib/gitlab/insights/project_insights_config_spec.rb' - 'ee/spec/lib/gitlab/usage_data_metrics_spec.rb' @@ -203,7 +196,6 @@ Lint/UnusedBlockArgument: - 'lib/api/helpers/snippets_helpers.rb' - 'lib/api/search.rb' - 'lib/atlassian/jira_connect/serializers/repository_entity.rb' - - 'lib/backup/database.rb' - 'lib/banzai/filter/autolink_filter.rb' - 'lib/banzai/filter/emoji_filter.rb' - 'lib/banzai/filter/inline_metrics_redactor_filter.rb' @@ -261,7 +253,6 @@ Lint/UnusedBlockArgument: - 'lib/tasks/contracts/pipeline_schedules.rake' - 'lib/tasks/contracts/pipelines.rake' - 'lib/tasks/frontend.rake' - - 'lib/tasks/gitlab/background_migrations.rake' - 'lib/tasks/gitlab/bulk_add_permission.rake' - 'lib/tasks/gitlab/db.rake' - 'lib/tasks/gitlab/external_diffs.rake' @@ -333,13 +324,11 @@ Lint/UnusedBlockArgument: - 'spec/graphql/types/base_object_spec.rb' - 'spec/initializers/secret_token_spec.rb' - 'spec/lib/api/helpers/pagination_strategies_spec.rb' - - 'spec/lib/backup/database_spec.rb' - 'spec/lib/banzai/filter/audio_link_filter_spec.rb' - 'spec/lib/banzai/filter/video_link_filter_spec.rb' - 'spec/lib/feature_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/ci/parsers/terraform/tfplan_spec.rb' - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' - 'spec/lib/gitlab/ci/pipeline/logger_spec.rb' @@ -370,16 +359,13 @@ Lint/UnusedBlockArgument: - 'spec/lib/gitlab/utils/usage_data_spec.rb' - 'spec/lib/mattermost/session_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - 'spec/models/active_session_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/concerns/ci/partitionable/switch_spec.rb' - 'spec/models/concerns/ci/partitionable_spec.rb' - 'spec/models/concerns/each_batch_spec.rb' - - 'spec/models/concerns/uniquify_spec.rb' - 'spec/models/container_repository_spec.rb' - 'spec/models/network/graph_spec.rb' - - 'spec/models/packages/debian/file_metadatum_spec.rb' - 'spec/requests/api/ci/pipeline_schedules_spec.rb' - 'spec/requests/api/graphql/gitlab_schema_spec.rb' - 'spec/requests/api/internal/container_registry/migration_spec.rb' @@ -398,7 +384,6 @@ Lint/UnusedBlockArgument: - 'spec/services/snippets/update_service_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/database/prevent_cross_database_modification.rb' - 'spec/support/graphql/subscriptions/action_cable/mock_action_cable.rb' - 'spec/support/helpers/cycle_analytics_helpers.rb' @@ -445,5 +430,4 @@ Lint/UnusedBlockArgument: - 'spec/tooling/lib/tooling/find_codeowners_spec.rb' - 'spec/tooling/rspec_flaky/config_spec.rb' - 'spec/workers/projects/git_garbage_collect_worker_spec.rb' - - 'tooling/danger/specs.rb' - 'tooling/lib/tooling/find_codeowners.rb' diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml index 8c23a6ae84b..45f18e605b7 100644 --- a/.rubocop_todo/lint/unused_method_argument.yml +++ b/.rubocop_todo/lint/unused_method_argument.yml @@ -19,7 +19,6 @@ Lint/UnusedMethodArgument: - 'app/graphql/mutations/base_mutation.rb' - 'app/graphql/mutations/ci/runner/delete.rb' - 'app/graphql/mutations/concerns/mutations/assignable.rb' - - 'app/graphql/mutations/members/groups/bulk_update.rb' - 'app/graphql/mutations/notes/create/base.rb' - 'app/graphql/mutations/notes/create/diff_note.rb' - 'app/graphql/mutations/notes/create/image_diff_note.rb' @@ -106,7 +105,6 @@ Lint/UnusedMethodArgument: - 'app/models/ci/runner.rb' - 'app/models/concerns/bulk_insert_safe.rb' - 'app/models/concerns/cache_markdown_field.rb' - - 'app/models/concerns/ci/partitionable/partitioned_filter.rb' - 'app/models/concerns/cross_database_modification.rb' - 'app/models/concerns/issuable.rb' - 'app/models/concerns/mentionable.rb' @@ -265,10 +263,10 @@ Lint/UnusedMethodArgument: - 'ee/app/models/concerns/geo/repository_replicator_strategy.rb' - 'ee/app/models/concerns/geo/verifiable_replicator.rb' - 'ee/app/models/concerns/geo/verification_state.rb' - - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/member.rb' - 'ee/app/models/ee/project.rb' - 'ee/app/models/group_wiki.rb' + - 'ee/app/models/iteration.rb' - 'ee/app/models/iteration_note.rb' - 'ee/app/replicators/geo/container_repository_replicator.rb' - 'ee/app/replicators/geo/pipeline_replicator.rb' @@ -284,7 +282,6 @@ Lint/UnusedMethodArgument: - 'ee/app/services/group_saml/identity/destroy_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/app/services/security/security_orchestration_policies/process_scan_result_policy_service.rb' - - 'ee/app/services/vulnerabilities/finding_dismiss_service.rb' - 'ee/app/validators/vulnerabilities/cvss_vector_validator.rb' - 'ee/app/workers/automation/execute_rule_worker.rb' - 'ee/app/workers/gitlab_subscriptions/refresh_seats_worker.rb' @@ -295,7 +292,6 @@ Lint/UnusedMethodArgument: - 'ee/lib/ee/api/ci/helpers/runner.rb' - 'ee/lib/ee/api/entities/project.rb' - 'ee/lib/ee/backup/repositories.rb' - - 'ee/lib/ee/banzai/reference_parser/iteration_parser.rb' - 'ee/lib/ee/gitlab/auth/ldap/sync/proxy.rb' - 'ee/lib/ee/gitlab/geo_git_access.rb' - 'ee/lib/ee/gitlab/tracking.rb' @@ -328,7 +324,6 @@ Lint/UnusedMethodArgument: - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/api/helpers/notes_helpers_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/patch/geo_database_tasks_spec.rb' @@ -386,7 +381,6 @@ Lint/UnusedMethodArgument: - 'lib/gitlab/auth/database/authentication.rb' - 'lib/gitlab/auth/ldap/access.rb' - 'lib/gitlab/auth/ldap/adapter.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_project_settings.rb' - 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb' - 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb' @@ -601,8 +595,6 @@ Lint/UnusedMethodArgument: - 'spec/lib/banzai/reference_parser/base_parser_spec.rb' - 'spec/lib/gitlab/auth_spec.rb' - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/set_correct_vulnerability_state_spec.rb' - 'spec/lib/gitlab/background_migration/truncate_overlong_vulnerability_html_titles_spec.rb' @@ -613,10 +605,6 @@ Lint/UnusedMethodArgument: - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/worker_context/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware_spec.rb' - - 'spec/lib/gitlab/url_blocker_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4_spec.rb' - 'spec/models/concerns/from_set_operator_spec.rb' - 'spec/models/concerns/redis_cacheable_spec.rb' - 'spec/policies/resource_state_event_policy_spec.rb' diff --git a/.rubocop_todo/metrics/cyclomatic_complexity.yml b/.rubocop_todo/metrics/cyclomatic_complexity.yml index 634ec6221f4..414f4f6243c 100644 --- a/.rubocop_todo/metrics/cyclomatic_complexity.yml +++ b/.rubocop_todo/metrics/cyclomatic_complexity.yml @@ -18,4 +18,3 @@ Metrics/CyclomaticComplexity: - 'qa/qa/runtime/browser.rb' - 'qa/qa/support/repeater.rb' - 'sidekiq_cluster/cli.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/metrics/perceived_complexity.yml b/.rubocop_todo/metrics/perceived_complexity.yml index 1eef5031e47..51ec88c1582 100644 --- a/.rubocop_todo/metrics/perceived_complexity.yml +++ b/.rubocop_todo/metrics/perceived_complexity.yml @@ -17,4 +17,3 @@ Metrics/PerceivedComplexity: - 'qa/qa/support/repeater.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' - 'sidekiq_cluster/cli.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/migration/background_migration_base_class.yml b/.rubocop_todo/migration/background_migration_base_class.yml index 6050a4d8055..6e5d34726e9 100644 --- a/.rubocop_todo/migration/background_migration_base_class.yml +++ b/.rubocop_todo/migration/background_migration_base_class.yml @@ -1,78 +1,45 @@ --- Migration/BackgroundMigrationBaseClass: Exclude: - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb' - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - - 'lib/gitlab/background_migration/backfill_integrations_type_new.rb' - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'lib/gitlab/background_migration/backfill_member_namespace_for_group_members.rb' - 'lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route.rb' - 'lib/gitlab/background_migration/backfill_namespace_id_for_project_route.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - 'lib/gitlab/background_migration/backfill_project_settings.rb' - 'lib/gitlab/background_migration/backfill_snippet_repositories.rb' - 'lib/gitlab/background_migration/backfill_topics_title.rb' - - 'lib/gitlab/background_migration/backfill_upvotes_count_on_issues.rb' - - 'lib/gitlab/background_migration/backfill_user_namespace.rb' - 'lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb' - - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - 'lib/gitlab/background_migration/create_security_setting.rb' - - 'lib/gitlab/background_migration/delete_orphaned_deployments.rb' - - 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb' - - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - - 'lib/gitlab/background_migration/drop_invalid_security_findings.rb' - 'lib/gitlab/background_migration/encrypt_integration_properties.rb' - - 'lib/gitlab/background_migration/encrypt_static_object_token.rb' - - 'lib/gitlab/background_migration/extract_project_topics_into_separate_table.rb' - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' - 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb' - - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - - 'lib/gitlab/background_migration/fix_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb' - 'lib/gitlab/background_migration/legacy_upload_mover.rb' - 'lib/gitlab/background_migration/legacy_uploads_migrator.rb' - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' - - 'lib/gitlab/background_migration/merge_topics_with_same_name.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/migrate_null_private_profile_to_false.rb' - 'lib/gitlab/background_migration/migrate_pages_to_zip_storage.rb' - 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb' - - 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb' - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' - 'lib/gitlab/background_migration/migrate_shimo_confluence_integration_category.rb' - - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - - 'lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature.rb' - 'lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds.rb' - 'lib/gitlab/background_migration/populate_container_repository_migration_plan.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'lib/gitlab/background_migration/populate_namespace_statistics.rb' - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb' - - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' - - 'lib/gitlab/background_migration/populate_topics_total_projects_count_cache.rb' - - 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'lib/gitlab/background_migration/populate_vulnerability_reads.rb' - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' - 'lib/gitlab/background_migration/project_namespaces/models/namespace.rb' - 'lib/gitlab/background_migration/project_namespaces/models/project.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - 'lib/gitlab/background_migration/remove_vulnerability_finding_links.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb' - - 'lib/gitlab/background_migration/steal_migrate_merge_request_diff_commit_users.rb' - - 'lib/gitlab/background_migration/update_timelogs_null_spent_at.rb' - - 'lib/gitlab/background_migration/update_timelogs_project_id.rb' - - 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb' - - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' diff --git a/.rubocop_todo/migration/background_migration_record.yml b/.rubocop_todo/migration/background_migration_record.yml index ec2b9fb6d6a..c803790525f 100644 --- a/.rubocop_todo/migration/background_migration_record.yml +++ b/.rubocop_todo/migration/background_migration_record.yml @@ -3,46 +3,24 @@ Migration/BackgroundMigrationRecord: Exclude: - 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'ee/lib/ee/gitlab/background_migration/create_security_setting.rb' - - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_requirements_to_work_items.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - 'lib/gitlab/background_migration/backfill_topics_title.rb' - 'lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb' - - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - - 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb' - - 'lib/gitlab/background_migration/drop_invalid_security_findings.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - 'lib/gitlab/background_migration/encrypt_integration_properties.rb' - - 'lib/gitlab/background_migration/encrypt_static_object_token.rb' - - 'lib/gitlab/background_migration/extract_project_topics_into_separate_table.rb' - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' - 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb' - - 'lib/gitlab/background_migration/merge_topics_with_same_name.rb' - - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/migrate_null_private_profile_to_false.rb' - - 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb' - - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' - - 'lib/gitlab/background_migration/populate_topics_total_projects_count_cache.rb' - 'lib/gitlab/background_migration/project_namespaces/models/namespace.rb' - 'lib/gitlab/background_migration/project_namespaces/models/project.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb' diff --git a/.rubocop_todo/migration/background_migrations.yml b/.rubocop_todo/migration/background_migrations.yml index ce2ad6da45e..fee1a7a0a6e 100644 --- a/.rubocop_todo/migration/background_migrations.yml +++ b/.rubocop_todo/migration/background_migrations.yml @@ -1,38 +1,6 @@ --- Migration/BackgroundMigrations: Exclude: - - 'db/post_migrate/20210830104800_reschedule_extract_project_topics_into_separate_table.rb' - - 'db/post_migrate/20210901153324_slice_merge_request_diff_commit_migrations.rb' - - 'db/post_migrate/20210909104800_reschedule_extract_project_topics_into_separate_table_2.rb' - - 'db/post_migrate/20211004110927_schedule_fix_first_mentioned_in_commit_at_job.rb' - - 'db/post_migrate/20211005010101_rereschedule_delete_orphaned_deployments.rb' - - 'db/post_migrate/20211005194425_schedule_requirements_migration.rb' - - 'db/post_migrate/20211006060436_schedule_populate_topics_total_projects_count_cache.rb' - - 'db/post_migrate/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3.rb' - - 'db/post_migrate/20211028155449_schedule_fix_merge_request_diff_commit_users_migration.rb' - - 'db/post_migrate/20211102114802_update_vulnerability_occurrences_location.rb' - - 'db/post_migrate/20211110151350_schedule_drop_invalid_security_findings.rb' - - 'db/post_migrate/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - - 'db/post_migrate/20211118194239_drop_invalid_remediations.rb' - - 'db/post_migrate/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4.rb' - - 'db/post_migrate/20211208171402_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'db/post_migrate/20211209203821_convert_stringified_raw_metadata_hash_to_json.rb' - - 'db/post_migrate/20211210140629_encrypt_static_object_token.rb' - - 'db/post_migrate/20211215090620_schedule_update_timelogs_null_spent_at.rb' - - 'db/post_migrate/20220107064845_populate_vulnerability_reads.rb' - - 'db/post_migrate/20220110171049_schedule_populate_test_reports_issue_id.rb' - - 'db/post_migrate/20220113111440_schedule_fix_incorrect_max_seats_used.rb' - - 'db/post_migrate/20220118204039_self_managed_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'db/post_migrate/20220125122640_schedule_populate_topics_non_private_projects_count.rb' - - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' - - 'db/post_migrate/20220204095121_backfill_namespace_statistics_with_dependency_proxy_size.rb' - - 'db/post_migrate/20220204194347_encrypt_integration_properties.rb' - - 'db/post_migrate/20220208115439_start_backfill_ci_queuing_tables.rb' - - 'db/post_migrate/20220212120735_schedule_fix_incorrect_max_seats_used2.rb' - - 'db/post_migrate/20220215190020_rerun_convert_stringified_raw_metadata_hash_to_json.rb' - - 'db/post_migrate/20220223124428_schedule_merge_topics_with_same_name.rb' - - 'db/post_migrate/20220308115219_schedule_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'db/post_migrate/20220308115502_schedule_reset_duplicate_ci_runners_token_values_on_projects.rb' - 'db/post_migrate/20220315171129_cleanup_draft_data_from_faulty_regex.rb' - 'db/post_migrate/20220316202640_populate_container_repositories_migration_plan.rb' - 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb' diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml index ae71e06b6d3..9b6d26a53ca 100644 --- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml +++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml @@ -8,7 +8,6 @@ Naming/HeredocDelimiterNaming: - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'app/workers/concerns/limited_capacity/job_tracker.rb' - 'config/initializers/01_secret_token.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/db/geo/migrate/20180322062741_migrate_ci_job_artifacts_to_separate_registry.rb' - 'ee/db/geo/migrate/20191010204941_migrate_lfs_objects_to_separate_registry.rb' - 'ee/lib/api/elasticsearch_indexed_namespaces.rb' @@ -50,16 +49,13 @@ Naming/HeredocDelimiterNaming: - 'rubocop/cop/default_scope.rb' - 'rubocop/cop/file_decompression.rb' - 'rubocop/cop/gitlab/httparty.rb' - - 'rubocop/cop/gitlab/json.rb' - 'rubocop/cop/gitlab/module_with_instance_variables.rb' - 'rubocop/cop/gitlab/predicate_memoization.rb' - 'spec/controllers/projects/pipelines_controller_spec.rb' - 'spec/deprecation_toolkit_env.rb' - - 'spec/factories/packages/debian/file_metadatum.rb' - 'spec/features/projects/commit/user_comments_on_commit_spec.rb' - 'spec/features/task_lists_spec.rb' - 'spec/initializers/100_patch_omniauth_oauth2_spec.rb' - - 'spec/initializers/net_http_response_patch_spec.rb' - 'spec/initializers/rack_multipart_patch_spec.rb' - 'spec/initializers/secret_token_spec.rb' - 'spec/initializers/validate_database_config_spec.rb' @@ -86,14 +82,6 @@ Naming/HeredocDelimiterNaming: - 'spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb' - 'spec/lib/gitlab/import_export/attributes_permitter_spec.rb' - 'spec/lib/gitlab/import_export/config_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/delete_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/init_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/install_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/patch_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/reset_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/delete_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/install_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/patch_command_spec.rb' - 'spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb' - 'spec/lib/gitlab/patch/database_config_spec.rb' - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb' diff --git a/.rubocop_todo/naming/inclusive_language.yml b/.rubocop_todo/naming/inclusive_language.yml index 953e1a6e508..465e338bbe7 100644 --- a/.rubocop_todo/naming/inclusive_language.yml +++ b/.rubocop_todo/naming/inclusive_language.yml @@ -1,9 +1,7 @@ --- Naming/InclusiveLanguage: - Details: grace period Exclude: - 'app/controllers/admin/application_settings/appearances_controller.rb' - - 'app/controllers/application_controller.rb' - 'app/controllers/concerns/requires_whitelisted_monitoring_client.rb' - 'app/controllers/health_check_controller.rb' - 'app/controllers/health_controller.rb' @@ -13,7 +11,6 @@ Naming/InclusiveLanguage: - 'app/helpers/markup_helper.rb' - 'app/models/application_setting.rb' - 'app/models/application_setting_implementation.rb' - - 'app/models/clusters/applications/jupyter.rb' - 'app/models/concerns/cache_markdown_field.rb' - 'app/services/application_settings/update_service.rb' - 'app/services/projects/download_service.rb' @@ -37,7 +34,6 @@ Naming/InclusiveLanguage: - 'lib/api/settings.rb' - 'lib/banzai/filter/asset_proxy_filter.rb' - 'lib/gitlab/asset_proxy.rb' - - 'lib/gitlab/auth.rb' - 'lib/gitlab/auth/ip_rate_limiter.rb' - 'lib/gitlab/ci/config/external/file/base.rb' - 'lib/gitlab/git/hook_env.rb' @@ -45,7 +41,6 @@ Naming/InclusiveLanguage: - 'lib/gitlab/markdown_cache/active_record/extension.rb' - 'lib/gitlab/markdown_cache/field_data.rb' - 'lib/gitlab/middleware/basic_health_check.rb' - - 'lib/gitlab/middleware/go.rb' - 'lib/gitlab/sanitizers/exif.rb' - 'lib/gitlab/sanitizers/svg.rb' - 'lib/gitlab/sanitizers/svg/whitelist.rb' @@ -61,7 +56,6 @@ Naming/InclusiveLanguage: - 'rubocop/cop/ignored_columns.rb' - 'rubocop/cop/inject_enterprise_edition_module.rb' - 'rubocop/cop/migration/add_columns_to_wide_tables.rb' - - 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/concerns/issuable_collections_spec.rb' - 'spec/controllers/health_check_controller_spec.rb' - 'spec/controllers/metrics_controller_spec.rb' @@ -70,7 +64,6 @@ Naming/InclusiveLanguage: - 'spec/lib/banzai/filter/asset_proxy_filter_spec.rb' - 'spec/lib/gitlab/asset_proxy_spec.rb' - 'spec/lib/gitlab/auth/ip_rate_limiter_spec.rb' - - 'spec/lib/gitlab/auth_spec.rb' - 'spec/lib/gitlab/git/hook_env_spec.rb' - 'spec/lib/gitlab/github_import/markdown/attachment_spec.rb' - 'spec/lib/gitlab/import_export/attribute_configuration_spec.rb' @@ -81,7 +74,6 @@ Naming/InclusiveLanguage: - 'spec/lib/gitlab/sanitizers/exif_spec.rb' - 'spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb' - 'spec/models/application_setting_spec.rb' - - 'spec/models/clusters/applications/jupyter_spec.rb' - 'spec/requests/api/settings_spec.rb' - 'spec/requests/health_controller_spec.rb' - 'spec/rubocop/cop/avoid_return_from_blocks_spec.rb' diff --git a/.rubocop_todo/performance/map_compact.yml b/.rubocop_todo/performance/map_compact.yml index ca0e8d604fd..2ea13f71fa4 100644 --- a/.rubocop_todo/performance/map_compact.yml +++ b/.rubocop_todo/performance/map_compact.yml @@ -65,11 +65,10 @@ Performance/MapCompact: - 'ee/app/services/vulnerabilities/findings/find_or_create_from_security_finding_service.rb' - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' - 'ee/db/fixtures/development/30_customizable_cycle_analytics.rb' + - 'ee/lib/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/api/entities/experiment.rb' - - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/gitlab/auth/ldap/person.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'ee/lib/elastic/latest/repository_instance_proxy.rb' - 'ee/lib/gitlab/alert_management/alert_payload_field_extractor.rb' - 'ee/lib/gitlab/ci/parsers/security/dast.rb' @@ -97,30 +96,16 @@ Performance/MapCompact: - 'lib/gitlab/analytics/usage_trends/workers_argument_builder.rb' - 'lib/gitlab/auth/ip_rate_limiter.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - - 'lib/gitlab/changes_list.rb' - - 'lib/gitlab/checks/changes_access.rb' - 'lib/gitlab/ci/parsers/security/common.rb' - 'lib/gitlab/ci/reports/security/aggregated_report.rb' - 'lib/gitlab/ci/reports/security/finding.rb' - 'lib/gitlab/ci/reports/test_suite_summary.rb' - - 'lib/gitlab/config/entry/validators.rb' - 'lib/gitlab/database/load_balancing/service_discovery.rb' - - 'lib/gitlab/database/obsolete_ignored_columns.rb' - - 'lib/gitlab/email/receiver.rb' - 'lib/gitlab/git/commit.rb' - 'lib/gitlab/git/conflict/file.rb' - 'lib/gitlab/git/rugged_impl/commit.rb' - - 'lib/gitlab/github_import/importer/pull_requests/review_request_importer.rb' - - 'lib/gitlab/issuable/clone/copy_resource_events_service.rb' - - 'lib/gitlab/issues/rebalancing/state.rb' - - 'lib/gitlab/jira_import/metadata_collector.rb' - - 'lib/gitlab/json_cache.rb' - - 'lib/gitlab/language_detection.rb' - - 'lib/gitlab/legacy_github_import/importer.rb' - - 'lib/gitlab/private_commit_email.rb' - 'lib/gitlab/sql/pattern.rb' - 'lib/gitlab/url_blocker.rb' - - 'lib/gitlab/verify/batch_verifier.rb' - 'qa/qa/page/component/issuable/sidebar.rb' - 'qa/qa/support/formatters/test_metrics_formatter.rb' - 'qa/qa/tools/ci/ff_changes.rb' diff --git a/.rubocop_todo/performance/string_include.yml b/.rubocop_todo/performance/string_include.yml deleted file mode 100644 index f2e17d3576a..00000000000 --- a/.rubocop_todo/performance/string_include.yml +++ /dev/null @@ -1,9 +0,0 @@ ---- -# Cop supports --autocorrect. -Performance/StringInclude: - Details: grace period - Exclude: - - 'lib/gitlab/github_import/importer/repository_importer.rb' - - 'lib/gitlab/legacy_github_import/importer.rb' - - 'lib/gitlab/usage_data.rb' - - 'rubocop/cop/gitlab/json.rb' diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml index a18dec335d1..e536c22e518 100644 --- a/.rubocop_todo/rails/file_path.yml +++ b/.rubocop_todo/rails/file_path.yml @@ -78,7 +78,6 @@ Rails/FilePath: - 'spec/factories/file_uploaders.rb' - 'spec/factories/packages/debian/distribution_key.rb' - 'spec/factories/pages_domains.rb' - - 'spec/factories/serverless/domain_cluster.rb' - 'spec/features/admin/admin_appearance_spec.rb' - 'spec/features/groups/group_settings_spec.rb' - 'spec/features/groups/import_export/import_file_spec.rb' @@ -101,7 +100,6 @@ Rails/FilePath: - 'spec/helpers/blob_helper_spec.rb' - 'spec/helpers/startupjs_helper_spec.rb' - 'spec/lib/backup/database_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_first_mentioned_in_commit_at_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base_spec.rb' - 'spec/lib/gitlab/database/schema_migrations/context_spec.rb' diff --git a/.rubocop_todo/rails/inverse_of.yml b/.rubocop_todo/rails/inverse_of.yml index 31535699d2e..59c0e14e180 100644 --- a/.rubocop_todo/rails/inverse_of.yml +++ b/.rubocop_todo/rails/inverse_of.yml @@ -1,27 +1,11 @@ --- Rails/InverseOf: Exclude: - - 'app/models/alert_management/alert.rb' - - 'app/models/alert_management/alert_assignee.rb' - - 'app/models/application_setting.rb' - - 'app/models/audit_event.rb' - - 'app/models/board.rb' - - 'app/models/bulk_imports/entity.rb' - - 'app/models/bulk_imports/tracker.rb' - - 'app/models/ci/build.rb' - - 'app/models/ci/build_pending_state.rb' - - 'app/models/ci/build_trace_chunk.rb' - - 'app/models/ci/daily_build_group_report_result.rb' - - 'app/models/ci/job_artifact.rb' - - 'app/models/ci/job_variable.rb' - - 'app/models/ci/pipeline.rb' - - 'app/models/ci/pipeline_schedule.rb' - 'app/models/ci/runner.rb' - 'app/models/ci/runner_namespace.rb' - 'app/models/ci/sources/pipeline.rb' - 'app/models/ci/trigger_request.rb' - 'app/models/ci/unit_test_failure.rb' - - 'app/models/clusters/applications/runner.rb' - 'app/models/clusters/cluster.rb' - 'app/models/clusters/concerns/application_core.rb' - 'app/models/clusters/integrations/prometheus.rb' @@ -44,8 +28,6 @@ Rails/InverseOf: - 'app/models/group_group_link.rb' - 'app/models/group_label.rb' - 'app/models/incident_management/timeline_event.rb' - - 'app/models/integrations/base_slash_commands.rb' - - 'app/models/issue.rb' - 'app/models/jira_connect_subscription.rb' - 'app/models/members/group_member.rb' - 'app/models/members/project_member.rb' @@ -59,7 +41,6 @@ Rails/InverseOf: - 'app/models/project.rb' - 'app/models/project_label.rb' - 'app/models/resource_state_event.rb' - - 'app/models/serverless/domain_cluster.rb' - 'app/models/terraform/state_version.rb' - 'app/models/time_tracking/timelog_category.rb' - 'app/models/todo.rb' @@ -79,7 +60,6 @@ Rails/InverseOf: - 'ee/app/models/ee/clusters/agent.rb' - 'ee/app/models/ee/epic.rb' - 'ee/app/models/ee/group.rb' - - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/merge_request.rb' - 'ee/app/models/ee/plan.rb' - 'ee/app/models/ee/project.rb' @@ -95,7 +75,7 @@ Rails/InverseOf: - 'ee/app/models/incident_management/escalation_rule.rb' - 'ee/app/models/incident_management/oncall_participant.rb' - 'ee/app/models/insight.rb' - - 'ee/app/models/integrations/gitlab_slack_application.rb' + - 'ee/app/models/iteration.rb' - 'ee/app/models/requirements_management/requirement.rb' - 'ee/app/models/requirements_management/test_report.rb' - 'ee/app/models/sbom/vulnerable_component_version.rb' diff --git a/.rubocop_todo/rails/negate_include.yml b/.rubocop_todo/rails/negate_include.yml index 48a1e4483b9..c99f15f98e3 100644 --- a/.rubocop_todo/rails/negate_include.yml +++ b/.rubocop_todo/rails/negate_include.yml @@ -13,7 +13,6 @@ Rails/NegateInclude: - 'app/models/merge_request.rb' - 'app/models/milestone.rb' - 'app/services/todo_service.rb' - - 'app/services/work_items/parent_links/create_service.rb' - 'config/application.rb' - 'config/initializers/1_settings.rb' - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb' diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml index 7e4af1ef3f9..4571e1ae19e 100644 --- a/.rubocop_todo/rails/pluck.yml +++ b/.rubocop_todo/rails/pluck.yml @@ -25,10 +25,9 @@ Rails/Pluck: - 'ee/app/workers/geo/repository_shard_sync_worker.rb' - 'ee/app/workers/geo/repository_verification/secondary/shard_worker.rb' - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' - - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' + - 'ee/lib/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/gitlab/auth/ldap/person.rb' - 'ee/lib/ee/gitlab/background_migration/delete_invalid_epic_issues.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/lib/elastic/latest/custom_language_analyzers.rb' - 'ee/lib/gitlab/search/index_curator.rb' @@ -74,7 +73,6 @@ Rails/Pluck: - 'ee/spec/requests/api/groups_spec.rb' - 'ee/spec/requests/api/iterations_spec.rb' - 'ee/spec/requests/api/members_spec.rb' - - 'ee/spec/requests/api/merge_request_approval_rules_spec.rb' - 'ee/spec/requests/api/project_approval_rules_spec.rb' - 'ee/spec/requests/api/project_approval_settings_spec.rb' - 'ee/spec/requests/api/projects_spec.rb' @@ -150,14 +148,11 @@ Rails/Pluck: - 'spec/controllers/projects/feature_flags_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/jobs_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/diffs_controller_spec.rb' - 'spec/controllers/projects/pipelines/tests_controller_spec.rb' - 'spec/controllers/projects/releases_controller_spec.rb' - 'spec/controllers/projects/starrers_controller_spec.rb' - 'spec/db/schema_spec.rb' - 'spec/features/issues/csv_spec.rb' - - 'spec/features/merge_request/user_sees_versions_spec.rb' - 'spec/finders/license_template_finder_spec.rb' - 'spec/graphql/resolvers/ci/test_suite_resolver_spec.rb' - 'spec/graphql/resolvers/concerns/looks_ahead_spec.rb' @@ -182,7 +177,6 @@ Rails/Pluck: - 'spec/lib/gitlab/language_detection_spec.rb' - 'spec/lib/gitlab/lograge/custom_options_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/tasks_response_spec.rb' - 'spec/lib/gitlab/relative_positioning/item_context_spec.rb' - 'spec/lib/gitlab/search/query_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_matcher_spec.rb' @@ -278,15 +272,5 @@ Rails/Pluck: - 'spec/support/helpers/api_helpers.rb' - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/matchers/background_migrations_matchers.rb' - - 'spec/support/shared_examples/graphql/mutation_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/container_repositories_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/custom_attributes_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/packages/package_details_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/labels_api_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/milestones_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb' - - 'spec/support/shared_examples/services/packages_shared_examples.rb' - 'spec/tooling/docs/deprecation_handling_spec.rb' - 'tooling/docs/deprecation_handling.rb' diff --git a/.rubocop_todo/rails/redundant_foreign_key.yml b/.rubocop_todo/rails/redundant_foreign_key.yml index 8705236aaf9..fc0f1c97fba 100644 --- a/.rubocop_todo/rails/redundant_foreign_key.yml +++ b/.rubocop_todo/rails/redundant_foreign_key.yml @@ -14,7 +14,6 @@ Rails/RedundantForeignKey: - 'app/models/ci/sources/pipeline.rb' - 'app/models/ci/stage.rb' - 'app/models/ci/unit_test_failure.rb' - - 'app/models/clusters/applications/runner.rb' - 'app/models/clusters/concerns/application_core.rb' - 'app/models/clusters/integrations/prometheus.rb' - 'app/models/commit_signatures/x509_commit_signature.rb' @@ -44,7 +43,6 @@ Rails/RedundantForeignKey: - 'ee/app/models/ci/sources/project.rb' - 'ee/app/models/concerns/incident_management/base_pending_escalation.rb' - 'ee/app/models/deployments/approval.rb' - - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/service_desk_setting.rb' - 'ee/app/models/geo/event_log.rb' - 'ee/app/models/incident_management/escalation_rule.rb' @@ -53,13 +51,10 @@ Rails/RedundantForeignKey: - 'ee/app/models/incident_management/pending_escalations/alert.rb' - 'ee/app/models/incident_management/pending_escalations/issue.rb' - 'ee/app/models/issuable_metric_image.rb' + - 'ee/app/models/iteration.rb' - 'ee/app/models/security/orchestration_policy_configuration.rb' - 'ee/app/models/security/orchestration_policy_rule_schedule.rb' - 'ee/app/models/vulnerabilities/feedback.rb' - 'ee/app/models/vulnerabilities/finding.rb' - 'ee/app/models/vulnerabilities/finding_signature.rb' - 'ee/app/models/vulnerabilities/identifier.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' diff --git a/.rubocop_todo/rails/render_inline.yml b/.rubocop_todo/rails/render_inline.yml deleted file mode 100644 index fbebec72cd7..00000000000 --- a/.rubocop_todo/rails/render_inline.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -Rails/RenderInline: - Exclude: - - 'ee/app/controllers/sitemap_controller.rb' diff --git a/.rubocop_todo/rails/time_zone.yml b/.rubocop_todo/rails/time_zone.yml index 220a6f39550..00e8150585d 100644 --- a/.rubocop_todo/rails/time_zone.yml +++ b/.rubocop_todo/rails/time_zone.yml @@ -44,7 +44,6 @@ Rails/TimeZone: - 'lib/gitlab/instrumentation_helper.rb' - 'lib/gitlab/lfs_token.rb' - 'lib/gitlab/loop_helpers.rb' - - 'lib/gitlab/phabricator_import/representation/task.rb' - 'lib/gitlab/popen.rb' - 'lib/gitlab/prometheus/queries/additional_metrics_environment_query.rb' - 'lib/gitlab/prometheus/queries/matched_metric_query.rb' @@ -97,8 +96,6 @@ Rails/TimeZone: - 'spec/lib/gitlab/lfs_token_spec.rb' - 'spec/lib/gitlab/log_timestamp_formatter_spec.rb' - 'spec/lib/gitlab/middleware/rails_queue_duration_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/representation/task_spec.rb' - 'spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb' diff --git a/.rubocop_todo/rake/require.yml b/.rubocop_todo/rake/require.yml deleted file mode 100644 index e3cd483f056..00000000000 --- a/.rubocop_todo/rake/require.yml +++ /dev/null @@ -1,20 +0,0 @@ ---- -Rake/Require: - Details: grace period - Exclude: - - 'lib/tasks/gitlab/assets.rake' - - 'lib/tasks/gitlab/docs/redirect.rake' - - 'lib/tasks/gitlab/graphql.rake' - - 'lib/tasks/gitlab/lfs/migrate.rake' - - 'lib/tasks/gitlab/metrics_exporter.rake' - - 'lib/tasks/gitlab/openapi.rake' - - 'lib/tasks/gitlab/packages/events.rake' - - 'lib/tasks/gitlab/packages/migrate.rake' - - 'lib/tasks/gitlab/pages.rake' - - 'lib/tasks/gitlab/refresh_project_statistics_build_artifacts_size.rake' - - 'lib/tasks/gitlab/terraform/migrate.rake' - - 'lib/tasks/gitlab/tw/codeowners.rake' - - 'lib/tasks/gitlab/x509/update.rake' - - 'lib/tasks/import.rake' - - 'lib/tasks/tokens.rake' - - 'qa/tasks/webdrivers.rake' diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml index b278eb355d5..e8cc0e77ca9 100644 --- a/.rubocop_todo/rspec/any_instance_of.yml +++ b/.rubocop_todo/rspec/any_instance_of.yml @@ -55,7 +55,6 @@ RSpec/AnyInstanceOf: - 'ee/spec/services/projects/destroy_service_spec.rb' - 'ee/spec/services/projects/group_links/destroy_service_spec.rb' - 'ee/spec/services/projects/update_service_spec.rb' - - 'ee/spec/services/slash_commands/global_slack_handler_spec.rb' - 'ee/spec/support/helpers/ee/stub_configuration.rb' - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' - 'ee/spec/support/shared_examples/features/ultimate_trial_callout_shared_examples.rb' diff --git a/.rubocop_todo/rspec/avoid_conditional_statements.yml b/.rubocop_todo/rspec/avoid_conditional_statements.yml new file mode 100644 index 00000000000..43ffaaa452a --- /dev/null +++ b/.rubocop_todo/rspec/avoid_conditional_statements.yml @@ -0,0 +1,84 @@ +--- +RSpec/AvoidConditionalStatements: + Details: grace period + Exclude: + - 'ee/spec/features/admin/admin_settings_spec.rb' + - 'ee/spec/features/analytics/code_analytics_spec.rb' + - 'ee/spec/features/billings/billing_plans_spec.rb' + - 'ee/spec/features/boards/scoped_issue_board_spec.rb' + - 'ee/spec/features/boards/user_visits_board_spec.rb' + - 'ee/spec/features/ci_shared_runner_warnings_spec.rb' + - 'ee/spec/features/epic_boards/epic_boards_spec.rb' + - 'ee/spec/features/epics/epic_show_spec.rb' + - 'ee/spec/features/epics/gfm_autocomplete_spec.rb' + - 'ee/spec/features/group_protected_branches_spec.rb' + - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb' + - 'ee/spec/features/groups/analytics/cycle_analytics/multiple_value_streams_spec.rb' + - 'ee/spec/features/groups/iterations/user_views_iteration_spec.rb' + - 'ee/spec/features/incidents/incident_details_spec.rb' + - 'ee/spec/features/issues/user_sees_empty_state_spec.rb' + - 'ee/spec/features/labels_hierarchy_spec.rb' + - 'ee/spec/features/profiles/usage_quotas_spec.rb' + - 'ee/spec/features/projects/analytics/visualization_designer_spec.rb' + - 'ee/spec/features/projects/licenses/maintainer_views_policies_spec.rb' + - 'ee/spec/features/projects/merge_requests/user_approves_merge_request_spec.rb' + - 'ee/spec/features/projects/settings/issues_settings_spec.rb' + - 'ee/spec/features/projects_spec.rb' + - 'ee/spec/features/registrations/email_confirmation_spec.rb' + - 'ee/spec/features/registrations/identity_verification_spec.rb' + - 'ee/spec/features/search/elastic/snippet_search_spec.rb' + - 'ee/spec/features/subscriptions/expiring_subscription_message_spec.rb' + - 'ee/spec/features/users/identity_verification_spec.rb' + - 'spec/features/admin/dashboard_spec.rb' + - 'spec/features/calendar_spec.rb' + - 'spec/features/groups/dependency_proxy_for_containers_spec.rb' + - 'spec/features/groups/empty_states_spec.rb' + - 'spec/features/groups/group_settings_spec.rb' + - 'spec/features/groups/members/sort_members_spec.rb' + - 'spec/features/groups/navbar_spec.rb' + - 'spec/features/issuables/issuable_list_spec.rb' + - 'spec/features/issuables/markdown_references/jira_spec.rb' + - 'spec/features/issues/create_issue_for_discussions_in_merge_request_spec.rb' + - 'spec/features/issues/user_bulk_edits_issues_labels_spec.rb' + - 'spec/features/issues/user_creates_branch_and_merge_request_spec.rb' + - 'spec/features/issues/user_edits_issue_spec.rb' + - 'spec/features/issues/user_interacts_with_awards_spec.rb' + - 'spec/features/labels_hierarchy_spec.rb' + - 'spec/features/markdown/keyboard_shortcuts_spec.rb' + - 'spec/features/merge_request/batch_comments_spec.rb' + - 'spec/features/merge_request/user_posts_diff_notes_spec.rb' + - 'spec/features/merge_request/user_reverts_merge_request_spec.rb' + - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' + - 'spec/features/merge_request/user_squashes_merge_request_spec.rb' + - 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb' + - 'spec/features/monitor_sidebar_link_spec.rb' + - 'spec/features/oauth_login_spec.rb' + - 'spec/features/participants_autocomplete_spec.rb' + - 'spec/features/profiles/user_edit_profile_spec.rb' + - 'spec/features/projects/blobs/edit_spec.rb' + - 'spec/features/projects/branches_spec.rb' + - 'spec/features/projects/commit/cherry_pick_spec.rb' + - 'spec/features/projects/commit/user_reverts_commit_spec.rb' + - 'spec/features/projects/compare_spec.rb' + - 'spec/features/projects/deploy_keys_spec.rb' + - 'spec/features/projects/environments/environment_spec.rb' + - 'spec/features/projects/files/template_selector_menu_spec.rb' + - 'spec/features/projects/integrations/user_activates_issue_tracker_spec.rb' + - 'spec/features/projects/integrations/user_activates_jira_spec.rb' + - 'spec/features/projects/labels/user_removes_labels_spec.rb' + - 'spec/features/projects/members/sorting_spec.rb' + - 'spec/features/projects/milestones/milestone_spec.rb' + - 'spec/features/projects/releases/user_views_releases_spec.rb' + - 'spec/features/projects/settings/project_settings_spec.rb' + - 'spec/features/projects/settings/repository_settings_spec.rb' + - 'spec/features/projects/settings/user_transfers_a_project_spec.rb' + - 'spec/features/projects/show/user_sees_git_instructions_spec.rb' + - 'spec/features/projects/tree/create_directory_spec.rb' + - 'spec/features/projects/tree/create_file_spec.rb' + - 'spec/features/projects_spec.rb' + - 'spec/features/search/user_uses_header_search_field_spec.rb' + - 'spec/features/snippets/explore_spec.rb' + - 'spec/features/tags/developer_creates_tag_spec.rb' + - 'spec/features/usage_stats_consent_spec.rb' + - 'spec/features/users/login_spec.rb' + - 'spec/features/users/overview_spec.rb' diff --git a/.rubocop_todo/rspec/context_method.yml b/.rubocop_todo/rspec/context_method.yml deleted file mode 100644 index fa428552cb9..00000000000 --- a/.rubocop_todo/rspec/context_method.yml +++ /dev/null @@ -1,7 +0,0 @@ ---- -# Cop supports --autocorrect. -RSpec/ContextMethod: - Details: grace period - Exclude: - - 'ee/spec/models/geo/secondary_usage_data_spec.rb' - - 'ee/spec/models/geo_node_status_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index cb732ea307c..a2886ff9679 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -169,7 +169,6 @@ RSpec/ContextWording: - 'ee/spec/features/protected_branches_spec.rb' - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/trial_registrations/company_information_spec.rb' - - 'ee/spec/features/trials/select_namespace_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/features/users/signup_spec.rb' - 'ee/spec/finders/approval_rules/group_finder_spec.rb' @@ -182,7 +181,7 @@ RSpec/ContextWording: - 'ee/spec/finders/dast_site_profiles_finder_spec.rb' - 'ee/spec/finders/dast_site_validations_finder_spec.rb' - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' - - 'ee/spec/finders/ee/clusters/agent_authorizations_finder_spec.rb' + - 'ee/spec/finders/ee/clusters/agents/authorizations/ci_access/finder_spec.rb' - 'ee/spec/finders/ee/clusters/agents_finder_spec.rb' - 'ee/spec/finders/ee/group_members_finder_spec.rb' - 'ee/spec/finders/ee/namespaces/projects_finder_spec.rb' @@ -306,8 +305,6 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' @@ -425,7 +422,6 @@ RSpec/ContextWording: - 'ee/spec/lib/system_check/rake_task/geo_task_spec.rb' - 'ee/spec/mailers/ee/emails/issues_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/migrations/schedule_requirements_migration_spec.rb' - 'ee/spec/models/alert_management/alert_payload_field_spec.rb' - 'ee/spec/models/allowed_email_domain_spec.rb' - 'ee/spec/models/application_setting_spec.rb' @@ -463,7 +459,6 @@ RSpec/ContextWording: - 'ee/spec/models/ee/group_group_link_spec.rb' - 'ee/spec/models/ee/group_spec.rb' - 'ee/spec/models/ee/incident_management/project_incident_management_setting_spec.rb' - - 'ee/spec/models/ee/iteration_spec.rb' - 'ee/spec/models/ee/iterations/cadence_spec.rb' - 'ee/spec/models/ee/namespace_ci_cd_setting_spec.rb' - 'ee/spec/models/ee/namespace_spec.rb' @@ -495,11 +490,11 @@ RSpec/ContextWording: - 'ee/spec/models/issuable_sla_spec.rb' - 'ee/spec/models/issue_link_spec.rb' - 'ee/spec/models/issue_spec.rb' + - 'ee/spec/models/iteration_spec.rb' - 'ee/spec/models/license_spec.rb' - 'ee/spec/models/member_spec.rb' - 'ee/spec/models/merge_request/blocking_spec.rb' - 'ee/spec/models/merge_request_spec.rb' - - 'ee/spec/models/merge_train_spec.rb' - 'ee/spec/models/namespace_setting_spec.rb' - 'ee/spec/models/note_spec.rb' - 'ee/spec/models/packages/package_file_spec.rb' @@ -535,7 +530,6 @@ RSpec/ContextWording: - 'ee/spec/policies/project_snippet_policy_spec.rb' - 'ee/spec/policies/protected_branch_policy_spec.rb' - 'ee/spec/policies/saml_provider_policy_spec.rb' - - 'ee/spec/presenters/approval_rule_presenter_spec.rb' - 'ee/spec/presenters/audit_event_presenter_spec.rb' - 'ee/spec/presenters/ci/build_runner_presenter_spec.rb' - 'ee/spec/presenters/ee/issue_presenter_spec.rb' @@ -759,7 +753,6 @@ RSpec/ContextWording: - 'ee/spec/services/geo/wiki_sync_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_hand_raise_lead_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/extend_reactivate_trial_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/preview_billable_user_change_service_spec.rb' - 'ee/spec/services/group_saml/group_managed_accounts/transfer_membership_service_spec.rb' - 'ee/spec/services/groups/create_service_spec.rb' @@ -786,7 +779,6 @@ RSpec/ContextWording: - 'ee/spec/services/jira/jql_builder_service_spec.rb' - 'ee/spec/services/ldap_group_reset_service_spec.rb' - 'ee/spec/services/members/activate_service_spec.rb' - - 'ee/spec/services/merge_commits/export_csv_service_spec.rb' - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - 'ee/spec/services/merge_requests/build_service_spec.rb' - 'ee/spec/services/merge_requests/merge_service_spec.rb' @@ -834,7 +826,6 @@ RSpec/ContextWording: - 'ee/spec/services/security/store_grouped_scans_service_spec.rb' - 'ee/spec/services/security/track_scan_service_spec.rb' - 'ee/spec/services/security/vulnerability_counting_service_spec.rb' - - 'ee/spec/services/slash_commands/global_slack_handler_spec.rb' - 'ee/spec/services/software_license_policies/update_service_spec.rb' - 'ee/spec/services/status_page/publish_attachments_service_spec.rb' - 'ee/spec/services/status_page/publish_details_service_spec.rb' @@ -945,10 +936,8 @@ RSpec/ContextWording: - 'ee/spec/workers/requirements_management/process_requirements_reports_worker_spec.rb' - 'ee/spec/workers/security/track_secure_scans_worker_spec.rb' - 'ee/spec/workers/sync_seat_link_worker_spec.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/milestone/assign_milestone_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/testing/endpoint_coverage_spec.rb' @@ -984,7 +973,6 @@ RSpec/ContextWording: - 'spec/controllers/admin/application_settings_controller_spec.rb' - 'spec/controllers/admin/instance_review_controller_spec.rb' - 'spec/controllers/admin/integrations_controller_spec.rb' - - 'spec/controllers/admin/runner_projects_controller_spec.rb' - 'spec/controllers/admin/sessions_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb' @@ -1166,7 +1154,6 @@ RSpec/ContextWording: - 'spec/features/ics/project_issues_spec.rb' - 'spec/features/ide/static_object_external_storage_csp_spec.rb' - 'spec/features/incidents/user_creates_new_incident_spec.rb' - - 'spec/features/invites_spec.rb' - 'spec/features/issuables/markdown_references/internal_references_spec.rb' - 'spec/features/issuables/sorting_list_spec.rb' - 'spec/features/issuables/user_sees_sidebar_spec.rb' @@ -1346,7 +1333,7 @@ RSpec/ContextWording: - 'spec/finders/ci/pipelines_finder_spec.rb' - 'spec/finders/ci/runners_finder_spec.rb' - 'spec/finders/cluster_ancestors_finder_spec.rb' - - 'spec/finders/clusters/agent_authorizations_finder_spec.rb' + - 'spec/finders/clusters/agents/authorizations/ci_access/finder_spec.rb' - 'spec/finders/clusters/agents_finder_spec.rb' - 'spec/finders/clusters/kubernetes_namespace_finder_spec.rb' - 'spec/finders/contributed_projects_finder_spec.rb' @@ -1402,7 +1389,6 @@ RSpec/ContextWording: - 'spec/frontend/fixtures/merge_requests.rb' - 'spec/frontend/fixtures/projects.rb' - 'spec/frontend/fixtures/search.rb' - - 'spec/frontend/fixtures/u2f.rb' - 'spec/frontend/fixtures/webauthn.rb' - 'spec/graphql/mutations/alert_management/create_alert_issue_spec.rb' - 'spec/graphql/mutations/alert_management/http_integration/create_spec.rb' @@ -1494,7 +1480,6 @@ RSpec/ContextWording: - 'spec/helpers/gitlab_routing_helper_spec.rb' - 'spec/helpers/groups/group_members_helper_spec.rb' - 'spec/helpers/groups_helper_spec.rb' - - 'spec/helpers/ide_helper_spec.rb' - 'spec/helpers/integrations_helper_spec.rb' - 'spec/helpers/jira_connect_helper_spec.rb' - 'spec/helpers/labels_helper_spec.rb' @@ -1532,7 +1517,7 @@ RSpec/ContextWording: - 'spec/initializers/validate_database_config_spec.rb' - 'spec/lib/api/entities/application_setting_spec.rb' - 'spec/lib/api/entities/basic_project_details_spec.rb' - - 'spec/lib/api/entities/clusters/agent_authorization_spec.rb' + - 'spec/lib/api/entities/clusters/agents/authorizations/ci_access_spec.rb' - 'spec/lib/api/entities/nuget/dependency_group_spec.rb' - 'spec/lib/api/entities/user_spec.rb' - 'spec/lib/api/every_api_endpoint_spec.rb' @@ -1636,7 +1621,6 @@ RSpec/ContextWording: - 'spec/lib/extracts_ref_spec.rb' - 'spec/lib/feature/definition_spec.rb' - 'spec/lib/feature_spec.rb' - - 'spec/lib/generators/gitlab/snowplow_event_definition_generator_spec.rb' - 'spec/lib/gitlab/alert_management/fingerprint_spec.rb' - 'spec/lib/gitlab/analytics/cycle_analytics/average_spec.rb' - 'spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb' @@ -1665,14 +1649,10 @@ RSpec/ContextWording: - 'spec/lib/gitlab/auth_spec.rb' - 'spec/lib/gitlab/authorized_keys_spec.rb' - 'spec/lib/gitlab/avatar_cache_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/repository_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' - 'spec/lib/gitlab/blame_spec.rb' @@ -1732,7 +1712,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/ci/pipeline_object_hierarchy_spec.rb' - 'spec/lib/gitlab/ci/reports/reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/security/aggregated_report_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/test_suite_comparer_spec.rb' - 'spec/lib/gitlab/ci/runner_instructions_spec.rb' - 'spec/lib/gitlab/ci/runner_upgrade_check_spec.rb' @@ -1854,7 +1833,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/encoding_helper_spec.rb' - 'spec/lib/gitlab/error_tracking/context_payload_generator_spec.rb' - 'spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb' - - 'spec/lib/gitlab/error_tracking_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers/sleeping_lock_spec.rb' - 'spec/lib/gitlab/external_authorization/access_spec.rb' - 'spec/lib/gitlab/favicon_spec.rb' @@ -1930,9 +1908,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb' - 'spec/lib/gitlab/import_export/importer_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/file_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/shared_example.rb' - 'spec/lib/gitlab/import_export/json/ndjson_reader_spec.rb' - 'spec/lib/gitlab/import_export/json/streaming_serializer_spec.rb' - 'spec/lib/gitlab/import_export/members_mapper_spec.rb' @@ -1958,8 +1933,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kas_spec.rb' - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/certificate_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' @@ -2007,14 +1980,12 @@ RSpec/ContextWording: - 'spec/lib/gitlab/patch/prependable_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' - 'spec/lib/gitlab/performance_bar_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/importer_spec.rb' - 'spec/lib/gitlab/popen_spec.rb' - 'spec/lib/gitlab/process_supervisor_spec.rb' - 'spec/lib/gitlab/profiler_spec.rb' - 'spec/lib/gitlab/project_authorizations_spec.rb' - 'spec/lib/gitlab/project_search_results_spec.rb' - 'spec/lib/gitlab/prometheus/adapter_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb' - 'spec/lib/gitlab/prometheus/query_variables_spec.rb' @@ -2044,7 +2015,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/search_context/controller_concern_spec.rb' - 'spec/lib/gitlab/search_results_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/json_formatter_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/admin_mode/client_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/admin_mode/server_spec.rb' @@ -2081,7 +2051,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/tree_summary_spec.rb' - 'spec/lib/gitlab/untrusted_regexp/ruby_syntax_spec.rb' - 'spec/lib/gitlab/untrusted_regexp_spec.rb' - - 'spec/lib/gitlab/url_blocker_spec.rb' - 'spec/lib/gitlab/url_sanitizer_spec.rb' - 'spec/lib/gitlab/usage/metric_definition_spec.rb' - 'spec/lib/gitlab/usage/metric_spec.rb' @@ -2097,7 +2066,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/quick_action_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/search_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/track_unique_events_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/lazy_attributes_spec.rb' - 'spec/lib/gitlab/utils/mime_type_spec.rb' @@ -2148,7 +2116,6 @@ RSpec/ContextWording: - 'spec/mailers/emails/releases_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/finalize_traversal_ids_background_migrations_spec.rb' - 'spec/models/ability_spec.rb' - 'spec/models/active_session_spec.rb' - 'spec/models/alert_management/alert_spec.rb' @@ -2191,13 +2158,6 @@ RSpec/ContextWording: - 'spec/models/ci/trigger_spec.rb' - 'spec/models/ci/variable_spec.rb' - 'spec/models/clusters/agent_spec.rb' - - 'spec/models/clusters/applications/crossplane_spec.rb' - - 'spec/models/clusters/applications/helm_spec.rb' - - 'spec/models/clusters/applications/ingress_spec.rb' - - 'spec/models/clusters/applications/jupyter_spec.rb' - - 'spec/models/clusters/applications/knative_spec.rb' - - 'spec/models/clusters/applications/prometheus_spec.rb' - - 'spec/models/clusters/applications/runner_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - 'spec/models/clusters/clusters_hierarchy_spec.rb' - 'spec/models/clusters/kubernetes_namespace_spec.rb' @@ -2308,7 +2268,6 @@ RSpec/ContextWording: - 'spec/models/notification_setting_spec.rb' - 'spec/models/operations/feature_flag_spec.rb' - 'spec/models/packages/conan/file_metadatum_spec.rb' - - 'spec/models/packages/debian/file_metadatum_spec.rb' - 'spec/models/packages/dependency_link_spec.rb' - 'spec/models/packages/dependency_spec.rb' - 'spec/models/packages/package_file_spec.rb' @@ -2321,7 +2280,6 @@ RSpec/ContextWording: - 'spec/models/personal_access_token_spec.rb' - 'spec/models/plan_limits_spec.rb' - 'spec/models/preloaders/labels_preloader_spec.rb' - - 'spec/models/preloaders/users_max_access_level_in_projects_preloader_spec.rb' - 'spec/models/project_authorization_spec.rb' - 'spec/models/project_feature_spec.rb' - 'spec/models/project_feature_usage_spec.rb' @@ -2437,7 +2395,6 @@ RSpec/ContextWording: - 'spec/requests/api/deployments_spec.rb' - 'spec/requests/api/environments_spec.rb' - 'spec/requests/api/error_tracking/collector_spec.rb' - - 'spec/requests/api/error_tracking/project_settings_spec.rb' - 'spec/requests/api/files_spec.rb' - 'spec/requests/api/generic_packages_spec.rb' - 'spec/requests/api/graphql/ci/runner_spec.rb' @@ -2576,7 +2533,6 @@ RSpec/ContextWording: - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/groups_controller_spec.rb' - 'spec/requests/health_controller_spec.rb' - - 'spec/requests/ide_controller_spec.rb' - 'spec/requests/jira_connect/installations_controller_spec.rb' - 'spec/requests/jira_connect/oauth_application_ids_controller_spec.rb' - 'spec/requests/jira_routing_spec.rb' @@ -2635,7 +2591,6 @@ RSpec/ContextWording: - 'spec/scripts/pipeline_test_report_builder_spec.rb' - 'spec/serializers/analytics_build_entity_spec.rb' - 'spec/serializers/ci/pipeline_entity_spec.rb' - - 'spec/serializers/cluster_application_entity_spec.rb' - 'spec/serializers/deploy_keys/basic_deploy_key_entity_spec.rb' - 'spec/serializers/diff_file_base_entity_spec.rb' - 'spec/serializers/diffs_entity_spec.rb' @@ -2697,7 +2652,7 @@ RSpec/ContextWording: - 'spec/services/ci/update_pending_build_service_spec.rb' - 'spec/services/clusters/agent_tokens/track_usage_service_spec.rb' - 'spec/services/clusters/agents/delete_expired_events_service_spec.rb' - - 'spec/services/clusters/agents/refresh_authorization_service_spec.rb' + - 'spec/services/clusters/agents/authorizations/ci_access/refresh_service_spec.rb' - 'spec/services/clusters/build_kubernetes_namespace_service_spec.rb' - 'spec/services/clusters/create_service_spec.rb' - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' @@ -2822,7 +2777,6 @@ RSpec/ContextWording: - 'spec/services/metrics/dashboard/grafana_metric_embed_service_spec.rb' - 'spec/services/metrics/dashboard/panel_preview_service_spec.rb' - 'spec/services/metrics/dashboard/pod_dashboard_service_spec.rb' - - 'spec/services/metrics/dashboard/self_monitoring_dashboard_service_spec.rb' - 'spec/services/metrics/dashboard/system_dashboard_service_spec.rb' - 'spec/services/metrics/dashboard/transient_embed_service_spec.rb' - 'spec/services/metrics/dashboard/update_dashboard_service_spec.rb' @@ -2847,9 +2801,7 @@ RSpec/ContextWording: - 'spec/services/packages/conan/create_package_service_spec.rb' - 'spec/services/packages/create_package_file_service_spec.rb' - 'spec/services/packages/debian/create_distribution_service_spec.rb' - - 'spec/services/packages/debian/extract_metadata_service_spec.rb' - 'spec/services/packages/debian/find_or_create_incoming_service_spec.rb' - - 'spec/services/packages/debian/process_changes_service_spec.rb' - 'spec/services/packages/helm/process_file_service_spec.rb' - 'spec/services/packages/maven/create_package_service_spec.rb' - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' @@ -2979,7 +2931,6 @@ RSpec/ContextWording: - 'spec/support/shared_contexts/features/integrations/group_integrations_shared_context.rb' - 'spec/support/shared_contexts/features/integrations/instance_and_group_integrations_shared_context.rb' - 'spec/support/shared_contexts/features/integrations/instance_integrations_shared_context.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' - 'spec/support/shared_contexts/features/integrations/project_integrations_jira_context.rb' - 'spec/support/shared_contexts/features/integrations/project_integrations_shared_context.rb' - 'spec/support/shared_contexts/finders/group_projects_finder_shared_contexts.rb' @@ -3169,7 +3120,6 @@ RSpec/ContextWording: - 'spec/support_specs/helpers/stub_method_calls_spec.rb' - 'spec/tasks/cache/clear/redis_spec.rb' - 'spec/tasks/dev_rake_spec.rb' - - 'spec/tasks/gettext_rake_spec.rb' - 'spec/tasks/gitlab/cleanup_rake_spec.rb' - 'spec/tasks/gitlab/db/validate_config_rake_spec.rb' - 'spec/tasks/gitlab/db_rake_spec.rb' diff --git a/.rubocop_todo/rspec/described_class.yml b/.rubocop_todo/rspec/described_class.yml index 7dcf1838282..67f7c365248 100644 --- a/.rubocop_todo/rspec/described_class.yml +++ b/.rubocop_todo/rspec/described_class.yml @@ -13,7 +13,6 @@ RSpec/DescribedClass: - 'ee/spec/models/ee/ci/runner_spec.rb' - 'ee/spec/models/ee/gpg_key_spec.rb' - 'ee/spec/models/ee/group_spec.rb' - - 'ee/spec/models/ee/iteration_spec.rb' - 'ee/spec/models/ee/project_spec.rb' - 'ee/spec/models/ee/vulnerability_spec.rb' - 'ee/spec/models/epic_issue_spec.rb' @@ -25,8 +24,8 @@ RSpec/DescribedClass: - 'ee/spec/models/geo/secondary_usage_data_spec.rb' - 'ee/spec/models/issuable_metric_image_spec.rb' - 'ee/spec/models/issue_spec.rb' + - 'ee/spec/models/iteration_spec.rb' - 'ee/spec/models/license_spec.rb' - - 'ee/spec/models/merge_train_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' - 'ee/spec/models/release_highlight_spec.rb' - 'ee/spec/models/requirements_management/test_report_spec.rb' @@ -94,7 +93,6 @@ RSpec/DescribedClass: - 'spec/lib/gitlab/relative_positioning/range_spec.rb' - 'spec/lib/gitlab/runtime_spec.rb' - 'spec/lib/gitlab/seeder_spec.rb' - - 'spec/lib/gitlab/serverless/service_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/client_spec.rb' - 'spec/lib/gitlab/usage/metrics/aggregates/sources/redis_hll_spec.rb' - 'spec/lib/gitlab/utils/measuring_spec.rb' @@ -108,8 +106,6 @@ RSpec/DescribedClass: - 'spec/models/alert_management/alert_spec.rb' - 'spec/models/application_record_spec.rb' - 'spec/models/application_setting_spec.rb' - - 'spec/models/awareness_session_spec.rb' - - 'spec/models/broadcast_message_spec.rb' - 'spec/models/chat_name_spec.rb' - 'spec/models/ci/build_runner_session_spec.rb' - 'spec/models/ci/build_spec.rb' @@ -162,7 +158,6 @@ RSpec/DescribedClass: - 'spec/models/performance_monitoring/prometheus_panel_spec.rb' - 'spec/models/postgresql/detached_partition_spec.rb' - 'spec/models/preloaders/user_max_access_level_in_projects_preloader_spec.rb' - - 'spec/models/preloaders/users_max_access_level_in_projects_preloader_spec.rb' - 'spec/models/project_spec.rb' - 'spec/models/projects/topic_spec.rb' - 'spec/models/release_highlight_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 9e3be798f09..8cecf3677dc 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -17,7 +17,6 @@ RSpec/ExpectChange: - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb' - 'ee/spec/lib/ee/feature_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/delete_approval_rules_with_vulnerability_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners_spec.rb' - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/access_spec.rb' @@ -196,7 +195,6 @@ RSpec/ExpectChange: - 'ee/spec/workers/groups/create_event_worker_spec.rb' - 'ee/spec/workers/import_software_licenses_worker_spec.rb' - 'ee/spec/workers/sync_seat_link_request_worker_spec.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'ee/spec/workers/vulnerabilities/mark_dropped_as_resolved_worker_spec.rb' - 'spec/controllers/admin/groups_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' @@ -241,11 +239,7 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/auth_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_namespace_statistics_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_self_managed_wiki_notes_spec.rb' - 'spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb' @@ -257,7 +251,6 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/database/tables_truncate_spec.rb' - 'spec/lib/gitlab/diff/file_spec.rb' - 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb' - - 'spec/lib/gitlab/email/hook/validate_addresses_interceptor_spec.rb' - 'spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/events/changed_reviewer_spec.rb' - 'spec/lib/gitlab/github_import/importer/note_importer_spec.rb' @@ -273,7 +266,6 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/pages/cache_control_spec.rb' - 'spec/lib/gitlab/query_limiting/transaction_spec.rb' - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' - - 'spec/migrations/20211126204445_add_task_to_work_item_types_spec.rb' - 'spec/migrations/20220321234317_remove_all_issuable_escalation_statuses_spec.rb' - 'spec/migrations/20220506154054_create_sync_namespace_details_trigger_spec.rb' - 'spec/migrations/20220512190659_remove_web_hooks_web_hook_logs_web_hook_id_fk_spec.rb' @@ -286,7 +278,6 @@ RSpec/ExpectChange: - 'spec/migrations/cleanup_mr_attention_request_todos_spec.rb' - 'spec/migrations/cleanup_vulnerability_state_transitions_with_same_from_state_to_state_spec.rb' - 'spec/migrations/delete_migrate_shared_vulnerability_scanners_spec.rb' - - 'spec/models/awareness_session_spec.rb' - 'spec/models/ci/build_metadata_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/job_artifact_spec.rb' @@ -398,8 +389,6 @@ RSpec/ExpectChange: - 'spec/services/milestones/find_or_create_service_spec.rb' - 'spec/services/milestones/transfer_service_spec.rb' - 'spec/services/namespaces/statistics_refresher_service_spec.rb' - - 'spec/services/packages/debian/process_changes_service_spec.rb' - - 'spec/services/packages/debian/process_package_file_service_spec.rb' - 'spec/services/pages_domains/create_service_spec.rb' - 'spec/services/post_receive_service_spec.rb' - 'spec/services/projects/cleanup_service_spec.rb' @@ -447,6 +436,5 @@ RSpec/ExpectChange: - 'spec/services/work_items/task_list_reference_replacement_service_spec.rb' - 'spec/services/work_items/update_service_spec.rb' - 'spec/services/work_items/widgets/hierarchy_service/update_service_spec.rb' - - 'spec/services/work_items/widgets/milestone_service/update_service_spec.rb' - 'spec/services/work_items/widgets/start_and_due_date_service/update_service_spec.rb' - 'spec/services/x509_certificate_revoke_service_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index 7a3aea07707..4003908c97e 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -62,7 +62,6 @@ RSpec/ExpectInHook: - 'ee/spec/requests/omniauth_kerberos_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb' - 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb' - - 'ee/spec/services/ci/minutes/batch_reset_service_spec.rb' - 'ee/spec/services/ci/runners/register_runner_service_spec.rb' - 'ee/spec/services/ci/runners/reset_registration_token_service_spec.rb' - 'ee/spec/services/ci/runners/unassign_runner_service_spec.rb' @@ -164,7 +163,6 @@ RSpec/ExpectInHook: - 'spec/helpers/projects_helper_spec.rb' - 'spec/helpers/search_helper_spec.rb' - 'spec/helpers/users_helper_spec.rb' - - 'spec/initializers/net_http_response_patch_spec.rb' - 'spec/initializers/validate_database_config_spec.rb' - 'spec/lib/api/entities/merge_request_changes_spec.rb' - 'spec/lib/api/helpers/variables_helpers_spec.rb' @@ -220,10 +218,8 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' - 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb' - 'spec/lib/gitlab/database_importers/instance_administrators/create_group_spec.rb' - - 'spec/lib/gitlab/database_importers/self_monitoring/project/create_service_spec.rb' - 'spec/lib/gitlab/diff/highlight_cache_spec.rb' - 'spec/lib/gitlab/email/service_desk_receiver_spec.rb' - - 'spec/lib/gitlab/error_tracking_spec.rb' - 'spec/lib/gitlab/faraday/error_callback_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/git_access_snippet_spec.rb' @@ -249,7 +245,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/import_failure_service_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/shared_example.rb' - 'spec/lib/gitlab/import_export/json/ndjson_reader_spec.rb' - 'spec/lib/gitlab/import_export/lfs_saver_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' @@ -259,7 +254,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/import_export/snippets_repo_restorer_spec.rb' - 'spec/lib/gitlab/jira_import/labels_importer_spec.rb' - 'spec/lib/gitlab/kas/client_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - 'spec/lib/gitlab/memory/instrumentation_spec.rb' @@ -441,7 +435,6 @@ RSpec/ExpectInHook: - 'spec/services/projects/update_remote_mirror_service_spec.rb' - 'spec/services/projects/update_repository_storage_service_spec.rb' - 'spec/services/search_service_spec.rb' - - 'spec/services/serverless/associate_domain_service_spec.rb' - 'spec/services/snippets/update_repository_storage_service_spec.rb' - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/services/suggestions/create_service_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml index 9a4d5f35be4..3a990dcd12d 100644 --- a/.rubocop_todo/rspec/factory_bot/avoid_create.yml +++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml @@ -2,7 +2,7 @@ RSpec/FactoryBot/AvoidCreate: Exclude: - 'ee/spec/components/namespaces/free_user_cap/enforcement_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/non_owner_alert_component_spec.rb' + - 'ee/spec/components/namespaces/free_user_cap/non_owner_enforcement_alert_component_spec.rb' - 'ee/spec/components/namespaces/free_user_cap/notification_alert_component_spec.rb' - 'ee/spec/components/namespaces/free_user_cap/usage_quota_alert_component_spec.rb' - 'ee/spec/components/namespaces/free_user_cap/usage_quota_trial_alert_component_spec.rb' @@ -27,7 +27,6 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/helpers/ee/feature_flags_helper_spec.rb' - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' - 'ee/spec/helpers/ee/graph_helper_spec.rb' - - 'ee/spec/helpers/ee/groups/analytics/cycle_analytics_helper_spec.rb' - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - 'ee/spec/helpers/ee/hooks_helper_spec.rb' @@ -50,13 +49,12 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - 'ee/spec/helpers/ee/todos_helper_spec.rb' - - 'ee/spec/helpers/ee/trial_helper_spec.rb' + - 'ee/spec/helpers/trials_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - 'ee/spec/helpers/ee/welcome_helper_spec.rb' - 'ee/spec/helpers/ee/wiki_helper_spec.rb' - 'ee/spec/helpers/epics_helper_spec.rb' - 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb' - - 'ee/spec/helpers/groups/feature_discovery_moments_helper_spec.rb' - 'ee/spec/helpers/groups/security_features_helper_spec.rb' - 'ee/spec/helpers/incident_management/escalation_policy_helper_spec.rb' - 'ee/spec/helpers/incident_management/oncall_schedule_helper_spec.rb' @@ -101,7 +99,6 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/mailers/emails/user_cap_spec.rb' - 'ee/spec/mailers/license_mailer_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/presenters/approval_rule_presenter_spec.rb' - 'ee/spec/presenters/audit_event_presenter_spec.rb' - 'ee/spec/presenters/ci/build_runner_presenter_spec.rb' - 'ee/spec/presenters/ci/minutes/usage_presenter_spec.rb' @@ -202,18 +199,15 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/views/compliance_management/compliance_framework/_project_settings.html.haml_spec.rb' - 'ee/spec/views/groups/billings/index.html.haml_spec.rb' - 'ee/spec/views/groups/edit.html.haml_spec.rb' - - 'ee/spec/views/groups/feature_discovery_moments/advanced_features_dashboard.html.haml_spec.rb' - 'ee/spec/views/groups/hook_logs/show.html.haml_spec.rb' - 'ee/spec/views/groups/hooks/edit.html.haml_spec.rb' - 'ee/spec/views/groups/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/groups/settings/_remove.html.haml_spec.rb' - 'ee/spec/views/groups/settings/reporting/show.html.haml_spec.rb' - - 'ee/spec/views/layouts/_search.html.haml_spec.rb' - 'ee/spec/views/layouts/application.html.haml_spec.rb' - 'ee/spec/views/layouts/group.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_current_user_dropdown.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_read_only_banner.html.haml_spec.rb' - - 'ee/spec/views/layouts/header/help_dropdown/_cross_stage_fdm.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_group.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'ee/spec/views/layouts/project.html.haml_spec.rb' @@ -253,7 +247,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/components/pajamas/avatar_component_spec.rb' - 'spec/helpers/admin/identities_helper_spec.rb' - 'spec/helpers/admin/user_actions_helper_spec.rb' - - 'spec/helpers/analytics/cycle_analytics_helper_spec.rb' - 'spec/helpers/appearances_helper_spec.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' @@ -392,7 +385,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/presenters/packages/pypi/simple_index_presenter_spec.rb' - 'spec/presenters/packages/pypi/simple_package_versions_presenter_spec.rb' - 'spec/presenters/pages_domain_presenter_spec.rb' - - 'spec/presenters/project_clusterable_presenter_spec.rb' - 'spec/presenters/project_hook_presenter_spec.rb' - 'spec/presenters/project_presenter_spec.rb' - 'spec/presenters/projects/import_export/project_export_presenter_spec.rb' @@ -433,7 +425,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/serializers/ci/lint/result_serializer_spec.rb' - 'spec/serializers/ci/pipeline_entity_spec.rb' - 'spec/serializers/ci/trigger_entity_spec.rb' - - 'spec/serializers/cluster_application_entity_spec.rb' - 'spec/serializers/cluster_entity_spec.rb' - 'spec/serializers/cluster_serializer_spec.rb' - 'spec/serializers/clusters/kubernetes_error_entity_spec.rb' @@ -559,7 +550,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/views/groups/edit.html.haml_spec.rb' - 'spec/views/groups/new.html.haml_spec.rb' - 'spec/views/help/instance_configuration.html.haml_spec.rb' - - 'spec/views/layouts/_search.html.haml_spec.rb' - 'spec/views/layouts/application.html.haml_spec.rb' - 'spec/views/layouts/devise.html.haml_spec.rb' - 'spec/views/layouts/fullscreen.html.haml_spec.rb' @@ -629,7 +619,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/views/shared/projects/_inactive_project_deletion_alert.html.haml_spec.rb' - 'spec/views/shared/projects/_list.html.haml_spec.rb' - 'spec/views/shared/projects/_project.html.haml_spec.rb' - - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - 'spec/views/shared/snippets/_snippet.html.haml_spec.rb' - 'spec/views/shared/web_hooks/_web_hook_disabled_alert.html.haml_spec.rb' - 'spec/views/shared/wikis/_sidebar.html.haml_spec.rb' diff --git a/.rubocop_todo/rspec/file_path.yml b/.rubocop_todo/rspec/file_path.yml index 9cc2e1b5b6c..ea193948909 100644 --- a/.rubocop_todo/rspec/file_path.yml +++ b/.rubocop_todo/rspec/file_path.yml @@ -12,6 +12,7 @@ RSpec/FilePath: - 'ee/spec/frontend/fixtures/analytics/value_streams_staging_stage.rb' - 'ee/spec/frontend/fixtures/analytics/value_streams_test_stage.rb' - 'ee/spec/frontend/fixtures/dora/metrics.rb' + - 'ee/spec/helpers/merge_requests_helper_spec.rb' - 'ee/spec/models/merge_request/blocking_spec.rb' - 'ee/spec/requests/api/ci/runner/jobs_put_spec.rb' - 'ee/spec/requests/api/ci/runner/jobs_trace_spec.rb' @@ -24,7 +25,6 @@ RSpec/FilePath: - 'spec/docs_screenshots/container_registry_docs.rb' - 'spec/docs_screenshots/wiki_docs.rb' - 'spec/lib/error_tracking/sentry_client/event_spec.rb' - - 'spec/lib/gitlab/import_export/import_export_equivalence_spec.rb' - 'spec/lib/gitlab/import_export/import_export_spec.rb' - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' diff --git a/.rubocop_todo/rspec/hooks_before_examples.yml b/.rubocop_todo/rspec/hooks_before_examples.yml index a6291452db8..66b2fc48874 100644 --- a/.rubocop_todo/rspec/hooks_before_examples.yml +++ b/.rubocop_todo/rspec/hooks_before_examples.yml @@ -17,7 +17,6 @@ RSpec/HooksBeforeExamples: - 'ee/spec/lib/ee/gitlab/usage_data_counters/hll_redis_counter_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb' - 'ee/spec/models/ee/merge_request_diff_spec.rb' - - 'ee/spec/models/merge_train_spec.rb' - 'ee/spec/requests/api/boards_spec.rb' - 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' @@ -27,19 +26,14 @@ RSpec/HooksBeforeExamples: - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - - 'qa/qa/specs/features/api/1_manage/user_inherited_access_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_with_2fa_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/project_access_token_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/user_inherited_access_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/revert/revert_commit_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_fork_in_web_ide_spec.rb' - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb' - 'qa/spec/specs/runner_spec.rb' diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml index faac690bb94..fe632cdd57b 100644 --- a/.rubocop_todo/rspec/instance_variable.yml +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -40,8 +40,8 @@ RSpec/InstanceVariable: - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_ssh_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/user_views_commit_diff_patch_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/add_file_template_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/link_to_line_in_web_ide_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/add_file_template_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/link_to_line_in_web_ide_spec.rb' - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/merge_request_license_widget_spec.rb' @@ -75,7 +75,6 @@ RSpec/InstanceVariable: - 'spec/features/merge_requests/user_lists_merge_requests_spec.rb' - 'spec/features/projects/diffs/diff_show_spec.rb' - 'spec/features/triggers_spec.rb' - - 'spec/features/u2f_spec.rb' - 'spec/finders/admin/plans_finder_spec.rb' - 'spec/finders/groups_finder_spec.rb' - 'spec/frontend/fixtures/listbox.rb' @@ -83,7 +82,6 @@ RSpec/InstanceVariable: - 'spec/frontend/fixtures/sessions.rb' - 'spec/frontend/fixtures/tabs.rb' - 'spec/frontend/fixtures/timezones.rb' - - 'spec/frontend/fixtures/u2f.rb' - 'spec/frontend/fixtures/webauthn.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/award_emoji_helper_spec.rb' @@ -100,7 +98,6 @@ RSpec/InstanceVariable: - 'spec/lib/extracts_ref_spec.rb' - 'spec/lib/gitlab/auth/auth_finders_spec.rb' - 'spec/lib/gitlab/auth/ldap/person_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/chat_name_token_spec.rb' - 'spec/lib/gitlab/ci/lint_spec.rb' @@ -122,7 +119,6 @@ RSpec/InstanceVariable: - 'spec/lib/gitlab/version_info_spec.rb' - 'spec/lib/gitlab/x509/certificate_spec.rb' - 'spec/mailers/emails/issues_spec.rb' - - 'spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb' - 'spec/models/group_spec.rb' - 'spec/models/integrations/assembla_spec.rb' - 'spec/models/integrations/campfire_spec.rb' diff --git a/.rubocop_todo/rspec/invalid_feature_category.yml b/.rubocop_todo/rspec/invalid_feature_category.yml deleted file mode 100644 index 53ed05b881c..00000000000 --- a/.rubocop_todo/rspec/invalid_feature_category.yml +++ /dev/null @@ -1,66 +0,0 @@ ---- -RSpec/InvalidFeatureCategory: - Exclude: - - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' - - 'ee/spec/controllers/admin/applications_controller_spec.rb' - - 'ee/spec/controllers/admin/dashboard_controller_spec.rb' - - 'ee/spec/controllers/admin/emails_controller_spec.rb' - - 'ee/spec/controllers/countries_controller_spec.rb' - - 'ee/spec/controllers/country_states_controller_spec.rb' - - 'ee/spec/controllers/sitemap_controller_spec.rb' - - 'ee/spec/features/admin/admin_dashboard_spec.rb' - - 'ee/spec/features/dashboards/operations_spec.rb' - - 'ee/spec/requests/api/award_emoji_spec.rb' - - 'ee/spec/requests/api/settings_spec.rb' - - 'spec/config/inject_enterprise_edition_module_spec.rb' - - 'spec/config/object_store_settings_spec.rb' - - 'spec/config/smime_signature_settings_spec.rb' - - 'spec/contracts/provider_specs/helpers/provider/contract_source_helper_spec.rb' - - 'spec/controllers/concerns/content_security_policy_patch_spec.rb' - - 'spec/features/action_cable_logging_spec.rb' - - 'spec/features/admin/admin_abuse_reports_spec.rb' - - 'spec/features/admin/admin_appearance_spec.rb' - - 'spec/features/admin/admin_browse_spam_logs_spec.rb' - - 'spec/features/admin/admin_mode_spec.rb' - - 'spec/features/admin/admin_settings_spec.rb' - - 'spec/features/admin/admin_system_info_spec.rb' - - 'spec/features/breadcrumbs_schema_markup_spec.rb' - - 'spec/features/dashboard/root_explore_spec.rb' - - 'spec/features/dashboard/shortcuts_spec.rb' - - 'spec/features/display_system_header_and_footer_bar_spec.rb' - - 'spec/features/frequently_visited_projects_and_groups_spec.rb' - - 'spec/features/help_dropdown_spec.rb' - - 'spec/features/help_pages_spec.rb' - - 'spec/features/monitor_sidebar_link_spec.rb' - - 'spec/features/unsubscribe_links_spec.rb' - - 'spec/features/whats_new_spec.rb' - - 'spec/lib/api/helpers_spec.rb' - - 'spec/lib/gitlab/slug/path_spec.rb' - - 'spec/lib/gitlab/utils/strong_memoize_spec.rb' - - 'spec/models/application_setting_spec.rb' - - 'spec/models/namespaces/randomized_suffix_path_spec.rb' - - 'spec/requests/admin/version_check_controller_spec.rb' - - 'spec/requests/api/admin/plan_limits_spec.rb' - - 'spec/requests/api/admin/sidekiq_spec.rb' - - 'spec/requests/api/api_guard/admin_mode_middleware_spec.rb' - - 'spec/requests/api/api_guard/response_coercer_middleware_spec.rb' - - 'spec/requests/api/award_emoji_spec.rb' - - 'spec/requests/api/graphql/custom_emoji_query_spec.rb' - - 'spec/requests/api/graphql/multiplexed_queries_spec.rb' - - 'spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb' - - 'spec/requests/api/graphql/mutations/award_emojis/add_spec.rb' - - 'spec/requests/api/graphql/mutations/award_emojis/remove_spec.rb' - - 'spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb' - - 'spec/requests/api/graphql/mutations/custom_emoji/create_spec.rb' - - 'spec/requests/api/graphql/mutations/custom_emoji/destroy_spec.rb' - - 'spec/requests/api/graphql/query_spec.rb' - - 'spec/requests/api/graphql_spec.rb' - - 'spec/requests/api/internal/workhorse_spec.rb' - - 'spec/requests/api/metadata_spec.rb' - - 'spec/requests/api/settings_spec.rb' - - 'spec/requests/api/sidekiq_metrics_spec.rb' - - 'spec/requests/projects/uploads_spec.rb' - - 'spec/requests/sandbox_controller_spec.rb' - - 'spec/rubocop/cop/gitlab/doc_url_spec.rb' - - 'spec/rubocop/cop/lint/last_keyword_argument_spec.rb' - - 'spec/rubocop/cop/rspec/avoid_test_prof_spec.rb' diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/missing_feature_category.yml index fa24075c566..0382b0ff43e 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/missing_feature_category.yml @@ -1,20 +1,9 @@ --- RSpec/MissingFeatureCategory: Exclude: - - 'ee/spec/components/billing/plan_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/enforcement_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/enforcement_at_limit_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/non_owner_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/usage_quota_alert_component_spec.rb' - - 'ee/spec/components/namespaces/free_user_cap/usage_quota_trial_alert_component_spec.rb' - - 'ee/spec/components/namespaces/storage/limit_alert_component_spec.rb' - - 'ee/spec/components/namespaces/storage/project_pre_enforcement_alert_component_spec.rb' - 'ee/spec/components/namespaces/storage/subgroup_pre_enforcement_alert_component_spec.rb' - - 'ee/spec/components/namespaces/storage/user_pre_enforcement_alert_component_spec.rb' - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' - 'ee/spec/controllers/admin/clusters_controller_spec.rb' - - 'ee/spec/controllers/admin/geo/nodes_controller_spec.rb' - - 'ee/spec/controllers/admin/geo/projects_controller_spec.rb' - 'ee/spec/controllers/autocomplete_controller_spec.rb' - 'ee/spec/controllers/dashboard_controller_spec.rb' - 'ee/spec/controllers/ee/projects/autocomplete_sources_controller_spec.rb' @@ -42,10 +31,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/elastic/migrate/20210825110300_backfill_namespace_ancestry_for_issues_spec.rb' - 'ee/spec/elastic/migrate/20210910094600_add_namespace_ancestry_ids_to_issues_mapping_spec.rb' - 'ee/spec/elastic/migrate/20210910100000_redo_backfill_namespace_ancestry_ids_for_issues_spec.rb' - - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' - - 'ee/spec/elastic/migrate/20220512150000_pause_indexing_for_unsupported_es_versions_spec.rb' - - 'ee/spec/elastic/migrate/20220824123000_add_label_ids_and_schema_version_to_issues_mapping_spec.rb' - - 'ee/spec/elastic/migrate/20221026082700_backfill_users_spec.rb' - 'ee/spec/elastic_integration/repository_index_spec.rb' - 'ee/spec/features/admin/admin_emails_spec.rb' - 'ee/spec/features/admin/admin_settings_spec.rb' @@ -66,7 +51,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/finders/boards/milestones_finder_spec.rb' - 'ee/spec/finders/boards/users_finder_spec.rb' - 'ee/spec/finders/clusters/environments_finder_spec.rb' - - 'ee/spec/finders/compliance_management/merge_requests/compliance_violations_finder_spec.rb' - 'ee/spec/finders/concerns/epics/with_access_check_spec.rb' - 'ee/spec/finders/custom_project_templates_finder_spec.rb' - 'ee/spec/finders/dast/profiles_finder_spec.rb' @@ -76,7 +60,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' - 'ee/spec/finders/ee/autocomplete/users_finder_spec.rb' - 'ee/spec/finders/ee/ci/daily_build_group_report_results_finder_spec.rb' - - 'ee/spec/finders/ee/clusters/agent_authorizations_finder_spec.rb' - 'ee/spec/finders/ee/clusters/agents_finder_spec.rb' - 'ee/spec/finders/ee/fork_targets_finder_spec.rb' - 'ee/spec/finders/ee/group_members_finder_spec.rb' @@ -88,24 +71,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/finders/epics/cross_hierarchy_children_finder_spec.rb' - 'ee/spec/finders/epics/with_issues_finder_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' - - 'ee/spec/finders/geo/ci_secure_file_registry_finder_spec.rb' - - 'ee/spec/finders/geo/container_repository_registry_finder_spec.rb' - - 'ee/spec/finders/geo/dependency_proxy_blob_registry_finder_spec.rb' - - 'ee/spec/finders/geo/dependency_proxy_manifest_registry_finder_spec.rb' - - 'ee/spec/finders/geo/design_registry_finder_spec.rb' - - 'ee/spec/finders/geo/group_wiki_repository_registry_finder_spec.rb' - - 'ee/spec/finders/geo/lfs_object_registry_finder_spec.rb' - - 'ee/spec/finders/geo/merge_request_diff_registry_finder_spec.rb' - - 'ee/spec/finders/geo/package_file_registry_finder_spec.rb' - - 'ee/spec/finders/geo/pages_deployment_registry_finder_spec.rb' - - 'ee/spec/finders/geo/pipeline_artifact_registry_finder_spec.rb' - - 'ee/spec/finders/geo/project_registry_finder_spec.rb' - - 'ee/spec/finders/geo/project_registry_status_finder_spec.rb' - - 'ee/spec/finders/geo/repository_verification_finder_spec.rb' - - 'ee/spec/finders/geo/snippet_repository_registry_finder_spec.rb' - - 'ee/spec/finders/geo/terraform_state_version_registry_finder_spec.rb' - - 'ee/spec/finders/geo/upload_registry_finder_spec.rb' - - 'ee/spec/finders/geo_node_finder_spec.rb' - 'ee/spec/finders/gpg_keys_finder_spec.rb' - 'ee/spec/finders/group_projects_finder_spec.rb' - 'ee/spec/finders/group_saml_identity_finder_spec.rb' @@ -118,18 +83,13 @@ RSpec/MissingFeatureCategory: - 'ee/spec/finders/incident_management/oncall_users_finder_spec.rb' - 'ee/spec/finders/issues_finder_spec.rb' - 'ee/spec/finders/iterations/cadences_finder_spec.rb' - - 'ee/spec/finders/iterations_finder_spec.rb' - 'ee/spec/finders/license_template_finder_spec.rb' - 'ee/spec/finders/licenses_finder_spec.rb' - - 'ee/spec/finders/merge_requests_finder_spec.rb' - - 'ee/spec/finders/merge_trains_finder_spec.rb' - 'ee/spec/finders/notes_finder_spec.rb' - 'ee/spec/finders/productivity_analytics_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/by_ids_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb' - 'ee/spec/finders/scim_finder_spec.rb' - - 'ee/spec/finders/security/scan_execution_policies_finder_spec.rb' - - 'ee/spec/finders/security/scan_result_policies_finder_spec.rb' - 'ee/spec/finders/security/training_providers/base_url_finder_spec.rb' - 'ee/spec/finders/security/training_providers/kontra_url_finder_spec.rb' - 'ee/spec/finders/security/training_providers/secure_code_warrior_url_finder_spec.rb' @@ -138,7 +98,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/finders/security/vulnerability_feedbacks_finder_spec.rb' - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - 'ee/spec/finders/snippets_finder_spec.rb' - - 'ee/spec/finders/software_license_policies_finder_spec.rb' - 'ee/spec/finders/status_page/incident_comments_finder_spec.rb' - 'ee/spec/finders/status_page/incidents_finder_spec.rb' - 'ee/spec/finders/template_finder_spec.rb' @@ -171,7 +130,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/api/vulnerabilities_spec.rb' - 'ee/spec/graphql/ee/mutations/boards/issues/issue_move_list_spec.rb' - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb' - - 'ee/spec/graphql/ee/mutations/ci/project_ci_cd_settings_update_spec.rb' - 'ee/spec/graphql/ee/mutations/concerns/mutations/resolves_issuable_spec.rb' - 'ee/spec/graphql/ee/resolvers/board_list_issues_resolver_spec.rb' - 'ee/spec/graphql/ee/resolvers/board_lists_resolver_spec.rb' @@ -204,11 +162,7 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/ee/types/repository/blob_type_spec.rb' - 'ee/spec/graphql/ee/types/todoable_interface_spec.rb' - 'ee/spec/graphql/ee/types/user_merge_request_interaction_type_spec.rb' - - 'ee/spec/graphql/graphql_triggers_spec.rb' - - 'ee/spec/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create_spec.rb' - 'ee/spec/graphql/mutations/app_sec/fuzzing/coverage/corpus/create_spec.rb' - - 'ee/spec/graphql/mutations/audit_events/streaming/event_type_filters/create_spec.rb' - - 'ee/spec/graphql/mutations/audit_events/streaming/event_type_filters/destroy_spec.rb' - 'ee/spec/graphql/mutations/audit_events/streaming/headers/create_spec.rb' - 'ee/spec/graphql/mutations/audit_events/streaming/headers/destroy_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/create_spec.rb' @@ -292,31 +246,14 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/resolvers/ci/code_coverage_activities_resolver_spec.rb' - 'ee/spec/graphql/resolvers/ci/code_coverage_summary_resolver_spec.rb' - 'ee/spec/graphql/resolvers/clusters/agents_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/compliance_management/merge_requests/compliance_violation_resolver_spec.rb' - 'ee/spec/graphql/resolvers/dast_site_profile_resolver_spec.rb' - 'ee/spec/graphql/resolvers/dast_site_validation_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/dora_metrics_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epic_ancestors_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epic_issues_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epics/children_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epics/default_project_for_issue_creation_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epics_resolver_spec.rb' - 'ee/spec/graphql/resolvers/external_issue_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/ci_secure_file_registries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/container_repository_registries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/dependency_proxy_blob_registries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/dependency_proxy_manifest_registries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/geo_node_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/group_wiki_repository_registries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/job_artifact_registries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/lfs_object_registries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/merge_request_diff_registries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/package_file_registries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/pages_deployment_registries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/pipeline_artifact_registries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/snippet_repository_registries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/terraform_state_version_registries_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/geo/upload_registries_resolver_spec.rb' - 'ee/spec/graphql/resolvers/incident_management/escalation_policies_resolver_spec.rb' - 'ee/spec/graphql/resolvers/incident_management/issuable_resource_links_resolver_spec.rb' - 'ee/spec/graphql/resolvers/incident_management/oncall_rotations_resolver_spec.rb' @@ -329,7 +266,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/resolvers/iterations_resolver_spec.rb' - 'ee/spec/graphql/resolvers/network_policy_resolver_spec.rb' - 'ee/spec/graphql/resolvers/path_locks_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/product_analytics/dashboards_resolver_spec.rb' - 'ee/spec/graphql/resolvers/product_analytics/visualization_resolver_spec.rb' - 'ee/spec/graphql/resolvers/requirements_management/requirements_resolver_spec.rb' - 'ee/spec/graphql/resolvers/requirements_management/test_reports_resolver_spec.rb' @@ -340,7 +276,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/resolvers/timebox_report_resolver_spec.rb' - 'ee/spec/graphql/resolvers/user_discussions_count_resolver_spec.rb' - 'ee/spec/graphql/resolvers/user_notes_count_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/vulnerabilities_count_per_day_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_grade_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerability_severities_count_resolver_spec.rb' @@ -397,7 +332,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/types/deployments/approval_type_spec.rb' - 'ee/spec/graphql/types/dora_metric_bucketing_interval_enum_spec.rb' - 'ee/spec/graphql/types/dora_metric_type_enum_spec.rb' - - 'ee/spec/graphql/types/dora_metric_type_spec.rb' - 'ee/spec/graphql/types/dora_type_spec.rb' - 'ee/spec/graphql/types/epic_connection_type_spec.rb' - 'ee/spec/graphql/types/epic_descendant_count_type_spec.rb' @@ -405,22 +339,7 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/types/epic_issue_type_spec.rb' - 'ee/spec/graphql/types/epic_sort_enum_spec.rb' - 'ee/spec/graphql/types/epic_state_enum_spec.rb' - - 'ee/spec/graphql/types/epic_type_spec.rb' - 'ee/spec/graphql/types/external_issue_type_spec.rb' - - 'ee/spec/graphql/types/geo/ci_secure_file_registry_type_spec.rb' - - 'ee/spec/graphql/types/geo/container_repository_registry_type_spec.rb' - - 'ee/spec/graphql/types/geo/dependency_proxy_blob_registry_type_spec.rb' - - 'ee/spec/graphql/types/geo/dependency_proxy_manifest_registry_type_spec.rb' - - 'ee/spec/graphql/types/geo/geo_node_type_spec.rb' - - 'ee/spec/graphql/types/geo/job_artifact_registry_type_spec.rb' - - 'ee/spec/graphql/types/geo/lfs_object_registry_type_spec.rb' - - 'ee/spec/graphql/types/geo/merge_request_diff_registry_type_spec.rb' - - 'ee/spec/graphql/types/geo/package_file_registry_type_spec.rb' - - 'ee/spec/graphql/types/geo/pages_deployment_registry_type_spec.rb' - - 'ee/spec/graphql/types/geo/pipeline_artifact_registry_type_spec.rb' - - 'ee/spec/graphql/types/geo/registry_state_enum_spec.rb' - - 'ee/spec/graphql/types/geo/terraform_state_version_registry_type_spec.rb' - - 'ee/spec/graphql/types/geo/upload_registry_type_spec.rb' - 'ee/spec/graphql/types/gitlab_subscriptions/user_role_enum_spec.rb' - 'ee/spec/graphql/types/global_id_type_spec.rb' - 'ee/spec/graphql/types/group_release_stats_type_spec.rb' @@ -475,7 +394,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/types/security_report_summary_type_spec.rb' - 'ee/spec/graphql/types/security_scanner_type_enum_spec.rb' - 'ee/spec/graphql/types/security_scanners_spec.rb' - - 'ee/spec/graphql/types/subscription_type_spec.rb' - 'ee/spec/graphql/types/timebox_report_type_spec.rb' - 'ee/spec/graphql/types/vulnerabilities_count_by_day_type_spec.rb' - 'ee/spec/graphql/types/vulnerability/external_issue_link_external_tracker_enum_spec.rb' @@ -495,7 +413,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/types/vulnerability_details/list_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_details/markdown_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_details/module_location_type_spec.rb' - - 'ee/spec/graphql/types/vulnerability_details/table_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_details/text_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_details/url_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_evidence_source_type_spec.rb' @@ -539,7 +456,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/helpers/analytics/code_review_helper_spec.rb' - 'ee/spec/helpers/application_helper_spec.rb' - 'ee/spec/helpers/audit_events_helper_spec.rb' - - 'ee/spec/helpers/billing_plans_helper_spec.rb' - 'ee/spec/helpers/boards_helper_spec.rb' - 'ee/spec/helpers/compliance_management/compliance_framework/group_settings_helper_spec.rb' - 'ee/spec/helpers/credentials_inventory_helper_spec.rb' @@ -557,10 +473,8 @@ RSpec/MissingFeatureCategory: - 'ee/spec/helpers/ee/events_helper_spec.rb' - 'ee/spec/helpers/ee/export_helper_spec.rb' - 'ee/spec/helpers/ee/feature_flags_helper_spec.rb' - - 'ee/spec/helpers/ee/geo_helper_spec.rb' - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' - 'ee/spec/helpers/ee/graph_helper_spec.rb' - - 'ee/spec/helpers/ee/groups/analytics/cycle_analytics_helper_spec.rb' - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - 'ee/spec/helpers/ee/groups/settings_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' @@ -570,7 +484,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/helpers/ee/labels_helper_spec.rb' - 'ee/spec/helpers/ee/lock_helper_spec.rb' - 'ee/spec/helpers/ee/namespace_user_cap_reached_alert_helper_spec.rb' - - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' - 'ee/spec/helpers/ee/operations_helper_spec.rb' - 'ee/spec/helpers/ee/personal_access_tokens_helper_spec.rb' - 'ee/spec/helpers/ee/profiles_helper_spec.rb' @@ -585,21 +498,16 @@ RSpec/MissingFeatureCategory: - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - 'ee/spec/helpers/ee/system_note_helper_spec.rb' - 'ee/spec/helpers/ee/todos_helper_spec.rb' - - 'ee/spec/helpers/ee/trial_helper_spec.rb' - - 'ee/spec/helpers/ee/trial_registration_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - - 'ee/spec/helpers/ee/version_check_helper_spec.rb' - 'ee/spec/helpers/ee/welcome_helper_spec.rb' - 'ee/spec/helpers/ee/wiki_helper_spec.rb' - 'ee/spec/helpers/epics_helper_spec.rb' - 'ee/spec/helpers/gitlab_subscriptions/upcoming_reconciliation_helper_spec.rb' - - 'ee/spec/helpers/groups/feature_discovery_moments_helper_spec.rb' - 'ee/spec/helpers/groups/ldap_sync_helper_spec.rb' - 'ee/spec/helpers/groups/security_features_helper_spec.rb' - 'ee/spec/helpers/groups/sso_helper_spec.rb' - 'ee/spec/helpers/incident_management/oncall_schedule_helper_spec.rb' - 'ee/spec/helpers/kerberos_helper_spec.rb' - - 'ee/spec/helpers/license_helper_spec.rb' - 'ee/spec/helpers/license_monitoring_helper_spec.rb' - 'ee/spec/helpers/manual_quarterly_co_term_banner_helper_spec.rb' - 'ee/spec/helpers/markup_helper_spec.rb' @@ -622,14 +530,12 @@ RSpec/MissingFeatureCategory: - 'ee/spec/helpers/timeboxes_helper_spec.rb' - 'ee/spec/helpers/trial_registrations/reassurances_helper_spec.rb' - 'ee/spec/helpers/users/identity_verification_helper_spec.rb' - - 'ee/spec/helpers/users_helper_spec.rb' - 'ee/spec/initializers/1_settings_spec.rb' - 'ee/spec/initializers/database_config_spec.rb' - 'ee/spec/initializers/fog_google_https_private_urls_spec.rb' - 'ee/spec/initializers/session_store_spec.rb' - 'ee/spec/lib/analytics/devops_adoption/snapshot_calculator_spec.rb' - 'ee/spec/lib/analytics/group_activity_calculator_spec.rb' - - 'ee/spec/lib/analytics/merge_request_metrics_refresh_spec.rb' - 'ee/spec/lib/analytics/productivity_analytics_request_params_spec.rb' - 'ee/spec/lib/analytics/refresh_approvals_data_spec.rb' - 'ee/spec/lib/analytics/refresh_comments_data_spec.rb' @@ -643,7 +549,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/api/entities/protected_environments/deploy_access_level_spec.rb' - 'ee/spec/lib/arkose/logger_spec.rb' - 'ee/spec/lib/arkose/settings_spec.rb' - - 'ee/spec/lib/arkose/verify_response_spec.rb' - 'ee/spec/lib/audit/base_changes_auditor_spec.rb' - 'ee/spec/lib/audit/changes_spec.rb' - 'ee/spec/lib/audit/compliance_framework_changes_auditor_spec.rb' @@ -653,7 +558,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' - 'ee/spec/lib/audit/group_push_rules_changes_auditor_spec.rb' - 'ee/spec/lib/banzai/filter/cross_project_issuable_information_filter_spec.rb' - - 'ee/spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb' - 'ee/spec/lib/banzai/filter/jira_private_image_link_filter_spec.rb' - 'ee/spec/lib/banzai/filter/references/epic_reference_filter_spec.rb' - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb' @@ -667,7 +571,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/bulk_imports/common/pipelines/wiki_pipeline_spec.rb' - 'ee/spec/lib/bulk_imports/groups/graphql/get_iterations_query_spec.rb' - 'ee/spec/lib/bulk_imports/groups/pipelines/epics_pipeline_spec.rb' - - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_cadences_pipeline_spec.rb' - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb' - 'ee/spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' - 'ee/spec/lib/bulk_imports/projects/pipelines/protected_branches_pipeline_spec.rb' @@ -680,7 +583,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/api/entities/ci/minutes/additional_pack_spec.rb' - 'ee/spec/lib/ee/api/entities/deployment_extended_spec.rb' - 'ee/spec/lib/ee/api/entities/experiment_spec.rb' - - 'ee/spec/lib/ee/api/entities/geo_node_status_spec.rb' - 'ee/spec/lib/ee/api/entities/group_detail_spec.rb' - 'ee/spec/lib/ee/api/entities/groups/repository_storage_move_spec.rb' - 'ee/spec/lib/ee/api/entities/identity_detail_spec.rb' @@ -704,7 +606,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/api/helpers/variables_helpers_spec.rb' - 'ee/spec/lib/ee/api/helpers_spec.rb' - 'ee/spec/lib/ee/api/support/git_access_actor_spec.rb' - - 'ee/spec/lib/ee/backup/repositories_spec.rb' - 'ee/spec/lib/ee/banzai/filter/sanitization_filter_spec.rb' - 'ee/spec/lib/ee/bulk_imports/groups/stage_spec.rb' - 'ee/spec/lib/ee/bulk_imports/projects/stage_spec.rb' @@ -733,8 +634,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/background_migration/create_security_setting_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/delete_approval_rules_with_vulnerability_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' @@ -742,13 +641,8 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/background_migration/populate_approval_merge_request_rules_with_security_orchestration_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_approval_project_rules_with_security_orchestration_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_namespace_statistics_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/purge_stale_security_scans_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/file_size_check_spec.rb' @@ -760,20 +654,16 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/ci/jwt_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/matching/runner_matcher_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/after_config_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/external_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/chain/validate/security_orchestration_policy_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/activity_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/size_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/reports/security/reports_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/status/build/manual_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/templates/templates_spec.rb' - 'ee/spec/lib/ee/gitlab/cleanup/orphan_job_artifact_files_spec.rb' - 'ee/spec/lib/ee/gitlab/database/gitlab_schema_spec.rb' - 'ee/spec/lib/ee/gitlab/database_spec.rb' - 'ee/spec/lib/ee/gitlab/email/handler/service_desk_handler_spec.rb' - - 'ee/spec/lib/ee/gitlab/etag_caching/router/rails_spec.rb' - 'ee/spec/lib/ee/gitlab/event_store_spec.rb' - 'ee/spec/lib/ee/gitlab/git_access_design_spec.rb' - 'ee/spec/lib/ee/gitlab/git_access_project_spec.rb' @@ -795,7 +685,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/metrics/samplers/database_sampler_spec.rb' - 'ee/spec/lib/ee/gitlab/middleware/read_only_spec.rb' - 'ee/spec/lib/ee/gitlab/namespace_storage_size_error_message_spec.rb' - - 'ee/spec/lib/ee/gitlab/namespaces/storage/enforcement_spec.rb' - 'ee/spec/lib/ee/gitlab/omniauth_initializer_spec.rb' - 'ee/spec/lib/ee/gitlab/pages/deployment_update_spec.rb' - 'ee/spec/lib/ee/gitlab/prometheus/metric_group_spec.rb' @@ -803,8 +692,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/repo_path_spec.rb' - 'ee/spec/lib/ee/gitlab/repository_size_checker_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/attribute_transform_spec.rb' - - 'ee/spec/lib/ee/gitlab/scim/filter_parser_spec.rb' - - 'ee/spec/lib/ee/gitlab/scim/params_parser_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/value_parser_spec.rb' - 'ee/spec/lib/ee/gitlab/search_results_spec.rb' - 'ee/spec/lib/ee/gitlab/security/scan_configuration_spec.rb' @@ -830,14 +717,11 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/sidebars/projects/menus/issues_menu_spec.rb' - 'ee/spec/lib/ee/sidebars/projects/menus/monitor_menu_spec.rb' - 'ee/spec/lib/ee/sidebars/projects/menus/repository_menu_spec.rb' - - 'ee/spec/lib/ee/sidebars/projects/menus/security_compliance_menu_spec.rb' - 'ee/spec/lib/ee/sidebars/projects/panel_spec.rb' - - 'ee/spec/lib/elastic/latest/application_instance_proxy_spec.rb' - 'ee/spec/lib/elastic/latest/commit_config_spec.rb' - 'ee/spec/lib/elastic/latest/config_spec.rb' - 'ee/spec/lib/elastic/latest/custom_language_analyzers_spec.rb' - 'ee/spec/lib/elastic/latest/git_instance_proxy_spec.rb' - - 'ee/spec/lib/elastic/latest/issue_class_proxy_spec.rb' - 'ee/spec/lib/elastic/latest/issue_config_spec.rb' - 'ee/spec/lib/elastic/latest/merge_request_config_spec.rb' - 'ee/spec/lib/elastic/latest/note_config_spec.rb' @@ -850,13 +734,10 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/elastic/multi_version_class_proxy_spec.rb' - 'ee/spec/lib/elastic/multi_version_instance_proxy_spec.rb' - 'ee/spec/lib/gem_extensions/elasticsearch/model/adapter/active_record/records_spec.rb' - - 'ee/spec/lib/gem_extensions/elasticsearch/model/indexing/instance_methods_spec.rb' - 'ee/spec/lib/gitlab/alert_management/alert_payload_field_extractor_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/aggregated/data_for_duration_chart_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_for_duration_chart_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/distinct_stage_loader_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_closed_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_first_added_to_board_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_first_associated_with_milestone_spec.rb' @@ -868,11 +749,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_label_added_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_label_removed_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_last_edited_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/base_dora_summary_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/change_failure_rate_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/lead_time_for_changes_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/lead_time_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/time_to_restore_service_spec.rb' - 'ee/spec/lib/gitlab/analytics/type_of_work/tasks_by_type_spec.rb' - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' - 'ee/spec/lib/gitlab/audit/events/preloader_spec.rb' @@ -889,7 +765,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/auth/group_saml/membership_updater_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/response_check_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/response_store_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/session_enforcer_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/sso_state_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/token_actor_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb' @@ -910,8 +785,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/auth/smartcard/session_spec.rb' - 'ee/spec/lib/gitlab/auth_spec.rb' - 'ee/spec/lib/gitlab/authority_analyzer_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/populate_test_reports_issue_id_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/bullet/exclusions_spec.rb' - 'ee/spec/lib/gitlab/cache_spec.rb' - 'ee/spec/lib/gitlab/checks/changes_access_spec.rb' @@ -922,10 +795,8 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/ci/config/entry/vault/engine_spec.rb' - 'ee/spec/lib/gitlab/ci/config/entry/vault/secret_spec.rb' - 'ee/spec/lib/gitlab/ci/config/required/processor_spec.rb' - - 'ee/spec/lib/gitlab/ci/minutes/build_consumption_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/cached_quota_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' - - 'ee/spec/lib/gitlab/ci/minutes/gitlab_contribution_cost_factor_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/runners_availability_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/license_compliance/license_scanning_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/metrics/generic_spec.rb' @@ -936,20 +807,15 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/ci/parsers/security/dependency_scanning_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/formatters/dependency_list_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/validators/default_branch_image_validator_spec.rb' - - 'ee/spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/create_cross_database_associations_spec.rb' - - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/activity_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb' - 'ee/spec/lib/gitlab/ci/project_config_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/coverage_fuzzing/report_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/dependency_list/dependency_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/dependency_list/report_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/license_scanning/dependency_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/license_scanning/license_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/license_scanning/reports_comparer_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/metrics/report_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/metrics/reports_comparer_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/security/finding_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/cluster_image_scanning_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/container_scanning_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/dast_spec.rb' @@ -965,22 +831,11 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/ci/templates/secure_binaries_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'ee/spec/lib/gitlab/cidr_spec.rb' - - 'ee/spec/lib/gitlab/code_owners/entry_spec.rb' - - 'ee/spec/lib/gitlab/code_owners/groups_loader_spec.rb' - - 'ee/spec/lib/gitlab/code_owners/loader_spec.rb' - - 'ee/spec/lib/gitlab/code_owners/reference_extractor_spec.rb' - - 'ee/spec/lib/gitlab/code_owners/users_loader_spec.rb' - - 'ee/spec/lib/gitlab/code_owners/validator_spec.rb' - - 'ee/spec/lib/gitlab/code_owners_spec.rb' - - 'ee/spec/lib/gitlab/com_spec.rb' - - 'ee/spec/lib/gitlab/console_spec.rb' - - 'ee/spec/lib/gitlab/contribution_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/custom_file_templates_spec.rb' - 'ee/spec/lib/gitlab/customers_dot/jwt_spec.rb' - 'ee/spec/lib/gitlab/data_builder/vulnerability_spec.rb' - 'ee/spec/lib/gitlab/elastic/bulk_indexer_spec.rb' - 'ee/spec/lib/gitlab/elastic/client_spec.rb' - - 'ee/spec/lib/gitlab/elastic/document_reference_spec.rb' - 'ee/spec/lib/gitlab/elastic/elasticsearch_enabled_cache_spec.rb' - 'ee/spec/lib/gitlab/elastic/group_search_results_spec.rb' - 'ee/spec/lib/gitlab/elastic/project_search_results_spec.rb' @@ -991,39 +846,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/exclusive_lease_spec.rb' - 'ee/spec/lib/gitlab/expiring_subscription_message_spec.rb' - 'ee/spec/lib/gitlab/favicon_spec.rb' - - 'ee/spec/lib/gitlab/geo/base_request_spec.rb' - - 'ee/spec/lib/gitlab/geo/cron_manager_spec.rb' - - 'ee/spec/lib/gitlab/geo/event_gap_tracking_spec.rb' - - 'ee/spec/lib/gitlab/geo/geo_tasks_spec.rb' - - 'ee/spec/lib/gitlab/geo/git_push_http_spec.rb' - - 'ee/spec/lib/gitlab/geo/git_ssh_proxy_spec.rb' - - 'ee/spec/lib/gitlab/geo/health_check_spec.rb' - - 'ee/spec/lib/gitlab/geo/json_request_spec.rb' - - 'ee/spec/lib/gitlab/geo/jwt_request_decoder_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/event_logs_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/cache_invalidation_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/design_repository_updated_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_attachments_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/hashed_storage_migrated_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/repositories_changed_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_created_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_deleted_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_renamed_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_updated_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/reset_checksum_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_helpers_spec.rb' - - 'ee/spec/lib/gitlab/geo/logger_spec.rb' - - 'ee/spec/lib/gitlab/geo/oauth/login_state_spec.rb' - - 'ee/spec/lib/gitlab/geo/oauth/logout_state_spec.rb' - - 'ee/spec/lib/gitlab/geo/oauth/logout_token_spec.rb' - - 'ee/spec/lib/gitlab/geo/oauth/session_spec.rb' - - 'ee/spec/lib/gitlab/geo/registry_batcher_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - - 'ee/spec/lib/gitlab/geo/replication/blob_retriever_spec.rb' - - 'ee/spec/lib/gitlab/geo/replicator_spec.rb' - - 'ee/spec/lib/gitlab/geo/signed_data_spec.rb' - - 'ee/spec/lib/gitlab/geo_spec.rb' - 'ee/spec/lib/gitlab/git_access_wiki_spec.rb' - 'ee/spec/lib/gitlab/gitaly_client/with_feature_flag_actors_spec.rb' - 'ee/spec/lib/gitlab/gl_repository/identifier_spec.rb' @@ -1048,7 +870,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/import_sources_spec.rb' - 'ee/spec/lib/gitlab/incident_management_spec.rb' - 'ee/spec/lib/gitlab/ingestion/bulk_insertable_task_spec.rb' - - 'ee/spec/lib/gitlab/insights/executors/dora_executor_spec.rb' - 'ee/spec/lib/gitlab/insights/executors/issuable_executor_spec.rb' - 'ee/spec/lib/gitlab/insights/finders/projects_finder_spec.rb' - 'ee/spec/lib/gitlab/insights/loader_spec.rb' @@ -1066,7 +887,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/ip_address_state_spec.rb' - 'ee/spec/lib/gitlab/items_collection_spec.rb' - 'ee/spec/lib/gitlab/kerberos/authentication_spec.rb' - - 'ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' - 'ee/spec/lib/gitlab/licenses/submit_license_usage_data_banner_spec.rb' - 'ee/spec/lib/gitlab/manual_quarterly_co_term_banner_spec.rb' - 'ee/spec/lib/gitlab/metrics/samplers/global_search_sampler_spec.rb' @@ -1076,7 +896,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/pagination/keyset/simple_order_builder_spec.rb' - 'ee/spec/lib/gitlab/patch/database_config_spec.rb' - 'ee/spec/lib/gitlab/patch/draw_route_spec.rb' - - 'ee/spec/lib/gitlab/patch/geo_database_tasks_spec.rb' - 'ee/spec/lib/gitlab/path_locks_finder_spec.rb' - 'ee/spec/lib/gitlab/project_template_spec.rb' - 'ee/spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb' @@ -1109,7 +928,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/status_page/usage_data_counters/incident_counter_spec.rb' - 'ee/spec/lib/gitlab/status_page_spec.rb' - 'ee/spec/lib/gitlab/subscription_portal/client_spec.rb' - - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb' - 'ee/spec/lib/gitlab/subscription_portal/clients/rest_spec.rb' - 'ee/spec/lib/gitlab/template/custom_templates_spec.rb' - 'ee/spec/lib/gitlab/tracking/snowplow_schema_validation_spec.rb' @@ -1164,16 +982,9 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/omni_auth/strategies/kerberos_spec.rb' - 'ee/spec/lib/peek/views/elasticsearch_spec.rb' - 'ee/spec/lib/quality/seeders/vulnerabilities_spec.rb' - - 'ee/spec/lib/sidebars/groups/menus/administration_menu_spec.rb' - 'ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb' - - 'ee/spec/lib/sidebars/groups/menus/epics_menu_spec.rb' - 'ee/spec/lib/sidebars/groups/menus/security_compliance_menu_spec.rb' - - 'ee/spec/lib/sidebars/groups/menus/wiki_menu_spec.rb' - - 'ee/spec/lib/slack/api_spec.rb' - - 'ee/spec/lib/slack/block_kit/app_home_opened_spec.rb' - - 'ee/spec/lib/slack/block_kit/incident_management/incident_modal_opened_spec.rb' - 'ee/spec/lib/system_check/app/search_check_spec.rb' - - 'ee/spec/lib/system_check/rake_task/geo_task_spec.rb' - 'ee/spec/mailers/ci_minutes_usage_mailer_spec.rb' - 'ee/spec/mailers/credentials_inventory_mailer_spec.rb' - 'ee/spec/mailers/devise_mailer_spec.rb' @@ -1183,17 +994,13 @@ RSpec/MissingFeatureCategory: - 'ee/spec/mailers/ee/emails/profile_spec.rb' - 'ee/spec/mailers/ee/emails/projects_spec.rb' - 'ee/spec/mailers/emails/epics_spec.rb' - - 'ee/spec/mailers/emails/free_user_cap_spec.rb' - 'ee/spec/mailers/emails/group_memberships_spec.rb' - 'ee/spec/mailers/emails/in_product_marketing_spec.rb' - - 'ee/spec/mailers/emails/merge_commits_spec.rb' - 'ee/spec/mailers/emails/namespace_storage_usage_mailer_spec.rb' - 'ee/spec/mailers/emails/requirements_spec.rb' - 'ee/spec/mailers/emails/user_cap_spec.rb' - 'ee/spec/mailers/license_mailer_spec.rb' - - 'ee/spec/mailers/notify_spec.rb' - 'ee/spec/models/alert_management/alert_payload_field_spec.rb' - - 'ee/spec/models/allowed_email_domain_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/aggregation_context_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/runtime_limiter_spec.rb' - 'ee/spec/models/analytics/devops_adoption/enabled_namespace_spec.rb' @@ -1223,9 +1030,7 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/boards/epic_user_preference_spec.rb' - 'ee/spec/models/broadcast_message_spec.rb' - 'ee/spec/models/ci/bridge_spec.rb' - - 'ee/spec/models/ci/build_spec.rb' - 'ee/spec/models/ci/daily_build_group_report_result_spec.rb' - - 'ee/spec/models/ci/minutes/additional_pack_spec.rb' - 'ee/spec/models/ci/minutes/context_spec.rb' - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - 'ee/spec/models/ci/minutes/notification_spec.rb' @@ -1238,11 +1043,9 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/commit_spec.rb' - 'ee/spec/models/compliance_management/compliance_framework/project_settings_spec.rb' - 'ee/spec/models/compliance_management/framework_spec.rb' - - 'ee/spec/models/concerns/approval_rule_like_spec.rb' - 'ee/spec/models/concerns/approver_migrate_hook_spec.rb' - 'ee/spec/models/concerns/auditable_spec.rb' - 'ee/spec/models/concerns/deprecated_approvals_before_merge_spec.rb' - - 'ee/spec/models/concerns/ee/clusters/agents/authorization_config_scopes_spec.rb' - 'ee/spec/models/concerns/ee/issuable_spec.rb' - 'ee/spec/models/concerns/ee/mentionable_spec.rb' - 'ee/spec/models/concerns/ee/milestoneable_spec.rb' @@ -1250,23 +1053,13 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/concerns/ee/participable_spec.rb' - 'ee/spec/models/concerns/ee/project_security_scanners_information_spec.rb' - 'ee/spec/models/concerns/ee/weight_eventable_spec.rb' - - 'ee/spec/models/concerns/elastic/application_versioned_search_spec.rb' - - 'ee/spec/models/concerns/elastic/issue_spec.rb' - - 'ee/spec/models/concerns/elastic/merge_request_spec.rb' - 'ee/spec/models/concerns/elastic/milestone_spec.rb' - - 'ee/spec/models/concerns/elastic/project_wiki_spec.rb' - 'ee/spec/models/concerns/elastic/projects_search_spec.rb' - 'ee/spec/models/concerns/elastic/repository_spec.rb' - 'ee/spec/models/concerns/elastic/snippet_spec.rb' - 'ee/spec/models/concerns/epic_tree_sorting_spec.rb' - 'ee/spec/models/concerns/filterable_by_test_reports_spec.rb' - - 'ee/spec/models/concerns/geo/eventable_spec.rb' - - 'ee/spec/models/concerns/geo/has_replicator_spec.rb' - - 'ee/spec/models/concerns/geo/replicable_model_spec.rb' - - 'ee/spec/models/concerns/geo/verifiable_model_spec.rb' - - 'ee/spec/models/concerns/geo/verification_state_spec.rb' - 'ee/spec/models/concerns/health_status_spec.rb' - - 'ee/spec/models/concerns/identity_verifiable_spec.rb' - 'ee/spec/models/concerns/incident_management/base_pending_escalation_spec.rb' - 'ee/spec/models/concerns/mirror_configuration_spec.rb' - 'ee/spec/models/concerns/password_complexity_spec.rb' @@ -1333,12 +1126,8 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/ee/preloaders/group_policy_preloader_spec.rb' - 'ee/spec/models/ee/project_authorization_spec.rb' - 'ee/spec/models/ee/project_group_link_spec.rb' - - 'ee/spec/models/ee/project_setting_spec.rb' - 'ee/spec/models/ee/project_statistics_spec.rb' - 'ee/spec/models/ee/project_wiki_spec.rb' - - 'ee/spec/models/ee/projects/wiki_repository_spec.rb' - - 'ee/spec/models/ee/protected_branch_spec.rb' - - 'ee/spec/models/ee/protected_ref_access_spec.rb' - 'ee/spec/models/ee/protected_ref_spec.rb' - 'ee/spec/models/ee/release_spec.rb' - 'ee/spec/models/ee/resource_label_event_spec.rb' @@ -1358,48 +1147,14 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/environment_spec.rb' - 'ee/spec/models/epic/related_epic_link_spec.rb' - 'ee/spec/models/epic_user_mention_spec.rb' - - 'ee/spec/models/geo/cache_invalidation_event_spec.rb' - - 'ee/spec/models/geo/ci_secure_file_registry_spec.rb' - - 'ee/spec/models/geo/container_repository_registry_spec.rb' - - 'ee/spec/models/geo/deleted_project_spec.rb' - - 'ee/spec/models/geo/dependency_proxy_blob_registry_spec.rb' - - 'ee/spec/models/geo/dependency_proxy_manifest_registry_spec.rb' - - 'ee/spec/models/geo/event_log_spec.rb' - - 'ee/spec/models/geo/event_log_state_spec.rb' - - 'ee/spec/models/geo/every_geo_event_spec.rb' - - 'ee/spec/models/geo/group_wiki_repository_registry_spec.rb' - - 'ee/spec/models/geo/hashed_storage_migrated_event_spec.rb' - - 'ee/spec/models/geo/job_artifact_registry_spec.rb' - - 'ee/spec/models/geo/lfs_object_registry_spec.rb' - - 'ee/spec/models/geo/merge_request_diff_registry_spec.rb' - - 'ee/spec/models/geo/pages_deployment_registry_spec.rb' - - 'ee/spec/models/geo/pipeline_artifact_registry_spec.rb' - - 'ee/spec/models/geo/project_wiki_repository_registry_spec.rb' - - 'ee/spec/models/geo/project_wiki_repository_state_spec.rb' - - 'ee/spec/models/geo/push_user_spec.rb' - - 'ee/spec/models/geo/repositories_changed_event_spec.rb' - - 'ee/spec/models/geo/repository_created_event_spec.rb' - - 'ee/spec/models/geo/repository_renamed_event_spec.rb' - - 'ee/spec/models/geo/repository_updated_event_spec.rb' - - 'ee/spec/models/geo/reset_checksum_event_spec.rb' - - 'ee/spec/models/geo/secondary_usage_data_spec.rb' - - 'ee/spec/models/geo/snippet_repository_registry_spec.rb' - - 'ee/spec/models/geo/terraform_state_version_registry_spec.rb' - - 'ee/spec/models/geo/tracking_base_spec.rb' - - 'ee/spec/models/geo/upload_registry_spec.rb' - - 'ee/spec/models/geo/upload_state_spec.rb' - - 'ee/spec/models/geo_node_namespace_link_spec.rb' - - 'ee/spec/models/geo_node_spec.rb' - 'ee/spec/models/gitlab/seat_link_data_spec.rb' - 'ee/spec/models/gitlab_subscription_history_spec.rb' - - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/gitlab_subscriptions/features_spec.rb' - 'ee/spec/models/gitlab_subscriptions/upcoming_reconciliation_spec.rb' - 'ee/spec/models/group_deletion_schedule_spec.rb' - 'ee/spec/models/group_member_spec.rb' - 'ee/spec/models/group_merge_request_approval_setting_spec.rb' - 'ee/spec/models/group_wiki_repository_spec.rb' - - 'ee/spec/models/group_wiki_spec.rb' - 'ee/spec/models/groups/repository_storage_move_spec.rb' - 'ee/spec/models/historical_data_spec.rb' - 'ee/spec/models/identity_spec.rb' @@ -1426,27 +1181,20 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/iteration_note_spec.rb' - 'ee/spec/models/label_note_spec.rb' - 'ee/spec/models/ldap_group_link_spec.rb' - - 'ee/spec/models/member_spec.rb' - 'ee/spec/models/merge_request/blocking_spec.rb' - 'ee/spec/models/merge_request_block_spec.rb' - - 'ee/spec/models/merge_request_spec.rb' - - 'ee/spec/models/merge_requests/compliance_violation_spec.rb' - 'ee/spec/models/merge_requests/external_status_check_spec.rb' - 'ee/spec/models/merge_requests/status_check_response_spec.rb' - - 'ee/spec/models/merge_train_spec.rb' - 'ee/spec/models/milestone_release_spec.rb' - 'ee/spec/models/milestone_spec.rb' - 'ee/spec/models/namespace_limit_spec.rb' - 'ee/spec/models/namespace_setting_spec.rb' - - 'ee/spec/models/namespaces/free_user_cap_spec.rb' - 'ee/spec/models/namespaces/storage/root_excess_size_spec.rb' - 'ee/spec/models/namespaces/storage/root_size_spec.rb' - - 'ee/spec/models/note_spec.rb' - 'ee/spec/models/packages/package_file_spec.rb' - 'ee/spec/models/path_lock_spec.rb' - 'ee/spec/models/plan_spec.rb' - 'ee/spec/models/preloaders/environments/protected_environment_preloader_spec.rb' - - 'ee/spec/models/product_analytics/dashboard_spec.rb' - 'ee/spec/models/product_analytics/jitsu_authentication_spec.rb' - 'ee/spec/models/productivity_analytics_spec.rb' - 'ee/spec/models/project_alias_spec.rb' @@ -1458,30 +1206,25 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/project_security_setting_spec.rb' - 'ee/spec/models/project_team_spec.rb' - 'ee/spec/models/protected_branch/required_code_owners_section_spec.rb' - - 'ee/spec/models/protected_branch/unprotect_access_level_spec.rb' - 'ee/spec/models/protected_environment_spec.rb' - 'ee/spec/models/protected_environments/approval_rule_spec.rb' - 'ee/spec/models/protected_environments/deploy_access_level_spec.rb' - 'ee/spec/models/push_rule_spec.rb' - 'ee/spec/models/remote_mirror_spec.rb' - - 'ee/spec/models/repository_spec.rb' - 'ee/spec/models/requirements_management/requirement_spec.rb' - 'ee/spec/models/saml_group_link_spec.rb' - 'ee/spec/models/saml_provider_spec.rb' - - 'ee/spec/models/sca/license_policy_spec.rb' - 'ee/spec/models/scoped_label_set_spec.rb' - 'ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb' - 'ee/spec/models/security/training_provider_spec.rb' - 'ee/spec/models/security/training_spec.rb' - 'ee/spec/models/snippet_repository_spec.rb' - 'ee/spec/models/snippet_spec.rb' - - 'ee/spec/models/software_license_policy_spec.rb' - 'ee/spec/models/status_page/project_setting_spec.rb' - 'ee/spec/models/status_page/published_incident_spec.rb' - 'ee/spec/models/storage_shard_spec.rb' - 'ee/spec/models/upload_spec.rb' - 'ee/spec/models/uploads/local_spec.rb' - - 'ee/spec/models/user_detail_spec.rb' - 'ee/spec/models/user_permission_export_upload_spec.rb' - 'ee/spec/models/user_preference_spec.rb' - 'ee/spec/models/users_security_dashboard_project_spec.rb' @@ -1511,17 +1254,13 @@ RSpec/MissingFeatureCategory: - 'ee/spec/policies/ee/namespaces/user_namespace_policy_spec.rb' - 'ee/spec/policies/environment_policy_spec.rb' - 'ee/spec/policies/event_policy_spec.rb' - - 'ee/spec/policies/geo/registry_policy_spec.rb' - - 'ee/spec/policies/geo_node_policy_spec.rb' - 'ee/spec/policies/group_hook_policy_spec.rb' - - 'ee/spec/policies/group_policy_spec.rb' - 'ee/spec/policies/identity_provider_policy_spec.rb' - 'ee/spec/policies/incident_management/oncall_rotation_policy_spec.rb' - 'ee/spec/policies/incident_management/oncall_schedule_policy_spec.rb' - 'ee/spec/policies/incident_management/oncall_shift_policy_spec.rb' - 'ee/spec/policies/instance_security_dashboard_policy_spec.rb' - 'ee/spec/policies/issuable_policy_spec.rb' - - 'ee/spec/policies/issue_policy_spec.rb' - 'ee/spec/policies/merge_requests/external_status_check_policy_spec.rb' - 'ee/spec/policies/note_policy_spec.rb' - 'ee/spec/policies/path_lock_policy_spec.rb' @@ -1532,9 +1271,7 @@ RSpec/MissingFeatureCategory: - 'ee/spec/policies/security/finding_policy_spec.rb' - 'ee/spec/policies/security/scan_policy_spec.rb' - 'ee/spec/policies/user_policy_spec.rb' - - 'ee/spec/policies/vulnerability_policy_spec.rb' - 'ee/spec/presenters/analytics/cycle_analytics/stage_presenter_spec.rb' - - 'ee/spec/presenters/approval_rule_presenter_spec.rb' - 'ee/spec/presenters/audit_event_presenter_spec.rb' - 'ee/spec/presenters/ci/build_presenter_spec.rb' - 'ee/spec/presenters/ci/build_runner_presenter_spec.rb' @@ -1558,24 +1295,9 @@ RSpec/MissingFeatureCategory: - 'ee/spec/presenters/subscriptions/new_plan_presenter_spec.rb' - 'ee/spec/presenters/vulnerability_presenter_spec.rb' - 'ee/spec/presenters/web_hooks/group/hook_presenter_spec.rb' - - 'ee/spec/replicators/geo/ci_secure_file_replicator_spec.rb' - - 'ee/spec/replicators/geo/dependency_proxy_blob_replicator_spec.rb' - - 'ee/spec/replicators/geo/dependency_proxy_manifest_replicator_spec.rb' - - 'ee/spec/replicators/geo/group_wiki_repository_replicator_spec.rb' - - 'ee/spec/replicators/geo/job_artifact_replicator_spec.rb' - - 'ee/spec/replicators/geo/lfs_object_replicator_spec.rb' - - 'ee/spec/replicators/geo/merge_request_diff_replicator_spec.rb' - - 'ee/spec/replicators/geo/package_file_replicator_spec.rb' - - 'ee/spec/replicators/geo/pages_deployment_replicator_spec.rb' - - 'ee/spec/replicators/geo/pipeline_artifact_replicator_spec.rb' - - 'ee/spec/replicators/geo/pipeline_replicator_spec.rb' - - 'ee/spec/replicators/geo/snippet_repository_replicator_spec.rb' - - 'ee/spec/replicators/geo/terraform_state_version_replicator_spec.rb' - - 'ee/spec/replicators/geo/upload_replicator_spec.rb' - 'ee/spec/requests/admin/credentials_controller_spec.rb' - 'ee/spec/requests/api/graphql/mutations/work_items/update_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' - - 'ee/spec/requests/ee/application_controller_spec.rb' - 'ee/spec/requests/projects/analytics/code_reviews_controller_spec.rb' - 'ee/spec/routing/admin_routing_spec.rb' - 'ee/spec/routing/git_http_routing_spec.rb' @@ -1608,7 +1330,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/serializers/dependency_list_serializer_spec.rb' - 'ee/spec/serializers/ee/admin/user_entity_spec.rb' - 'ee/spec/serializers/ee/blob_entity_spec.rb' - - 'ee/spec/serializers/ee/build_details_entity_spec.rb' - 'ee/spec/serializers/ee/ci/job_entity_spec.rb' - 'ee/spec/serializers/ee/ci/pipeline_entity_spec.rb' - 'ee/spec/serializers/ee/deployment_entity_spec.rb' @@ -1628,7 +1349,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/serializers/evidences/build_artifact_entity_spec.rb' - 'ee/spec/serializers/evidences/evidence_entity_spec.rb' - 'ee/spec/serializers/fork_namespace_entity_spec.rb' - - 'ee/spec/serializers/geo_project_registry_entity_spec.rb' - 'ee/spec/serializers/group_vulnerability_autocomplete_entity_spec.rb' - 'ee/spec/serializers/incident_management/escalation_policy_entity_spec.rb' - 'ee/spec/serializers/incident_management/oncall_schedule_entity_spec.rb' @@ -1657,7 +1377,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/serializers/protected_environments/deploy_access_level_entity_spec.rb' - 'ee/spec/serializers/protected_environments/entity_spec.rb' - 'ee/spec/serializers/scim_oauth_access_token_entity_spec.rb' - - 'ee/spec/serializers/security/license_policy_entity_spec.rb' - 'ee/spec/serializers/security/vulnerability_report_data_entity_spec.rb' - 'ee/spec/serializers/security/vulnerability_report_data_serializer_spec.rb' - 'ee/spec/serializers/status_page/incident_comment_entity_spec.rb' @@ -1695,7 +1414,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/app_sec/dast/profiles/build_config_service_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/destroy_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scan_configs/fetch_service_spec.rb' - 'ee/spec/services/app_sec/dast/scans/create_service_spec.rb' - 'ee/spec/services/app_sec/dast/scans/run_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_profile_secret_variables/create_or_update_service_spec.rb' @@ -1720,9 +1438,7 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/approval_rules/project_rule_destroy_service_spec.rb' - 'ee/spec/services/approval_rules/update_service_spec.rb' - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - - 'ee/spec/services/arkose/record_user_data_service_spec.rb' - 'ee/spec/services/arkose/token_verification_service_spec.rb' - - 'ee/spec/services/audit_event_service_spec.rb' - 'ee/spec/services/audit_events/build_service_spec.rb' - 'ee/spec/services/audit_events/custom_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/impersonation_audit_event_service_spec.rb' @@ -1732,11 +1448,8 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/audit_events/release_associate_milestone_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/release_created_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/release_updated_audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/repository_download_started_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/runner_custom_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/runners_token_audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/streaming/event_type_filters/create_service_spec.rb' - - 'ee/spec/services/audit_events/streaming/event_type_filters/destroy_service_spec.rb' - 'ee/spec/services/audit_events/streaming/headers/base_spec.rb' - 'ee/spec/services/audit_events/streaming/headers/create_service_spec.rb' - 'ee/spec/services/audit_events/streaming/headers/destroy_service_spec.rb' @@ -1744,11 +1457,9 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/audit_events/unregister_runner_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/user_impersonation_group_audit_event_service_spec.rb' - 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb' - - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' - 'ee/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' - 'ee/spec/services/award_emojis/add_service_spec.rb' - 'ee/spec/services/award_emojis/destroy_service_spec.rb' - - 'ee/spec/services/base_count_service_spec.rb' - 'ee/spec/services/billable_members/destroy_service_spec.rb' - 'ee/spec/services/boards/create_service_spec.rb' - 'ee/spec/services/boards/epic_boards/create_service_spec.rb' @@ -1767,335 +1478,11 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/boards/update_service_spec.rb' - 'ee/spec/services/boards/user_preferences/update_service_spec.rb' - 'ee/spec/services/branches/delete_service_spec.rb' - - 'ee/spec/services/ci/audit_variable_change_service_spec.rb' - - 'ee/spec/services/ci/compare_metrics_reports_service_spec.rb' - - 'ee/spec/services/ci/compare_security_reports_service_spec.rb' - - 'ee/spec/services/ci/copy_cross_database_associations_service_spec.rb' - - 'ee/spec/services/ci/create_pipeline_service/compliance_spec.rb' - - 'ee/spec/services/ci/create_pipeline_service/cross_needs_artifacts_spec.rb' - - 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb' - - 'ee/spec/services/ci/create_pipeline_service/needs_spec.rb' - - 'ee/spec/services/ci/create_pipeline_service/runnable_builds_spec.rb' - - 'ee/spec/services/ci/create_pipeline_service_spec.rb' - - 'ee/spec/services/ci/destroy_pipeline_service_spec.rb' - - 'ee/spec/services/ci/external_pull_requests/process_github_event_service_spec.rb' - - 'ee/spec/services/ci/minutes/additional_packs/change_namespace_service_spec.rb' - - 'ee/spec/services/ci/minutes/additional_packs/create_service_spec.rb' - - 'ee/spec/services/ci/minutes/batch_reset_service_spec.rb' - - 'ee/spec/services/ci/minutes/email_notification_service_spec.rb' - - 'ee/spec/services/ci/minutes/refresh_cached_data_service_spec.rb' - - 'ee/spec/services/ci/minutes/reset_usage_service_spec.rb' - - 'ee/spec/services/ci/minutes/track_live_consumption_service_spec.rb' - - 'ee/spec/services/ci/minutes/update_build_minutes_service_spec.rb' - - 'ee/spec/services/ci/pipeline_bridge_status_service_spec.rb' - - 'ee/spec/services/ci/pipeline_creation/drop_not_runnable_builds_service_spec.rb' - - 'ee/spec/services/ci/pipeline_creation/start_pipeline_service_spec.rb' - - 'ee/spec/services/ci/pipeline_trigger_service_spec.rb' - - 'ee/spec/services/ci/play_bridge_service_spec.rb' - - 'ee/spec/services/ci/play_build_service_spec.rb' - - 'ee/spec/services/ci/process_build_service_spec.rb' - - 'ee/spec/services/ci/process_pipeline_service_spec.rb' - - 'ee/spec/services/ci/retry_job_service_spec.rb' - - 'ee/spec/services/ci/retry_pipeline_service_spec.rb' - - 'ee/spec/services/ci/subscribe_bridge_service_spec.rb' - - 'ee/spec/services/ci/trigger_downstream_subscription_service_spec.rb' - - 'ee/spec/services/ci_cd/github_integration_setup_service_spec.rb' - - 'ee/spec/services/ci_cd/github_setup_service_spec.rb' - - 'ee/spec/services/ci_cd/setup_project_spec.rb' - - 'ee/spec/services/compliance_management/frameworks/create_service_spec.rb' - - 'ee/spec/services/compliance_management/frameworks/destroy_service_spec.rb' - - 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb' - - 'ee/spec/services/compliance_management/merge_requests/create_compliance_violations_service_spec.rb' - - 'ee/spec/services/concerns/epics/related_epic_links/usage_data_helper_spec.rb' - - 'ee/spec/services/dashboard/environments/list_service_spec.rb' - - 'ee/spec/services/dashboard/operations/list_service_spec.rb' - - 'ee/spec/services/dashboard/projects/create_service_spec.rb' - - 'ee/spec/services/dashboard/projects/list_service_spec.rb' - - 'ee/spec/services/deploy_keys/create_service_spec.rb' - - 'ee/spec/services/deployments/auto_rollback_service_spec.rb' - - 'ee/spec/services/ee/admin/set_feature_flag_service_spec.rb' - - 'ee/spec/services/ee/alert_management/alerts/update_service_spec.rb' - - 'ee/spec/services/ee/alert_management/create_alert_issue_service_spec.rb' - - 'ee/spec/services/ee/alert_management/http_integrations/create_service_spec.rb' - - 'ee/spec/services/ee/alert_management/http_integrations/update_service_spec.rb' - - 'ee/spec/services/ee/allowed_email_domains/update_service_spec.rb' - - 'ee/spec/services/ee/auth/container_registry_authentication_service_spec.rb' - - 'ee/spec/services/ee/auto_merge_service_spec.rb' - - 'ee/spec/services/ee/boards/issues/create_service_spec.rb' - - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' - - 'ee/spec/services/ee/boards/issues/move_service_spec.rb' - - 'ee/spec/services/ee/boards/lists/create_service_spec.rb' - - 'ee/spec/services/ee/boards/lists/list_service_spec.rb' - - 'ee/spec/services/ee/boards/lists/max_limits_spec.rb' - - 'ee/spec/services/ee/ci/change_variable_service_spec.rb' - - 'ee/spec/services/ee/ci/change_variables_service_spec.rb' - - 'ee/spec/services/ee/ci/job_artifacts/create_service_spec.rb' - - 'ee/spec/services/ee/ci/job_artifacts/destroy_all_expired_service_spec.rb' - - 'ee/spec/services/ee/ci/job_artifacts/destroy_batch_service_spec.rb' - - 'ee/spec/services/ee/ci/pipeline_processing/atomic_processing_service_spec.rb' - - 'ee/spec/services/ee/commits/create_service_spec.rb' - - 'ee/spec/services/ee/deployments/update_environment_service_spec.rb' - - 'ee/spec/services/ee/design_management/delete_designs_service_spec.rb' - - 'ee/spec/services/ee/design_management/save_designs_service_spec.rb' - - 'ee/spec/services/ee/event_create_service_spec.rb' - - 'ee/spec/services/ee/git/branch_push_service_spec.rb' - - 'ee/spec/services/ee/git/wiki_push_service_spec.rb' - - 'ee/spec/services/ee/gpg_keys/create_service_spec.rb' - - 'ee/spec/services/ee/gpg_keys/destroy_service_spec.rb' - - 'ee/spec/services/ee/groups/autocomplete_service_spec.rb' - - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' - - 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb' - - 'ee/spec/services/ee/groups/deploy_tokens/revoke_service_spec.rb' - - 'ee/spec/services/ee/groups/import_export/export_service_spec.rb' - - 'ee/spec/services/ee/groups/import_export/import_service_spec.rb' - - 'ee/spec/services/ee/incident_management/issuable_escalation_statuses/after_update_service_spec.rb' - - 'ee/spec/services/ee/incident_management/issuable_escalation_statuses/create_service_spec.rb' - - 'ee/spec/services/ee/incident_management/issuable_escalation_statuses/prepare_update_service_spec.rb' - - 'ee/spec/services/ee/integrations/test/project_service_spec.rb' - - 'ee/spec/services/ee/ip_restrictions/update_service_spec.rb' - - 'ee/spec/services/ee/issuable/bulk_update_service_spec.rb' - - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - - 'ee/spec/services/ee/issuable/destroy_service_spec.rb' - - 'ee/spec/services/ee/issue_links/create_service_spec.rb' - - 'ee/spec/services/ee/issues/after_create_service_spec.rb' - - 'ee/spec/services/ee/issues/clone_service_spec.rb' - - 'ee/spec/services/ee/issues/move_service_spec.rb' - - 'ee/spec/services/ee/keys/destroy_service_spec.rb' - - 'ee/spec/services/ee/labels/create_service_spec.rb' - - 'ee/spec/services/ee/labels/promote_service_spec.rb' - - 'ee/spec/services/ee/members/create_service_spec.rb' - - 'ee/spec/services/ee/members/destroy_service_spec.rb' - - 'ee/spec/services/ee/members/import_project_team_service_spec.rb' - - 'ee/spec/services/ee/members/invite_service_spec.rb' - - 'ee/spec/services/ee/members/update_service_spec.rb' - - 'ee/spec/services/ee/merge_request_metrics_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/base_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/create_approval_event_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/create_from_vulnerability_data_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/create_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/execute_approval_hooks_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/handle_assignees_change_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/post_merge_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/update_assignees_service_spec.rb' - - 'ee/spec/services/ee/merge_requests/update_reviewers_service_spec.rb' - - 'ee/spec/services/ee/namespace_settings/update_service_spec.rb' - 'ee/spec/services/ee/notes/destroy_service_spec.rb' - 'ee/spec/services/ee/notes/post_process_service_spec.rb' - 'ee/spec/services/ee/notes/quick_actions_service_spec.rb' - 'ee/spec/services/ee/notes/update_service_spec.rb' - - 'ee/spec/services/ee/null_notification_service_spec.rb' - - 'ee/spec/services/ee/personal_access_tokens/revoke_service_spec.rb' - - 'ee/spec/services/ee/post_receive_service_spec.rb' - - 'ee/spec/services/ee/preview_markdown_service_spec.rb' - - 'ee/spec/services/ee/projects/autocomplete_service_spec.rb' - - 'ee/spec/services/ee/projects/deploy_tokens/create_service_spec.rb' - - 'ee/spec/services/ee/projects/deploy_tokens/destroy_service_spec.rb' - - 'ee/spec/services/ee/projects/unlink_fork_service_spec.rb' - - 'ee/spec/services/ee/protected_branches/update_service_spec.rb' - - 'ee/spec/services/ee/quick_actions/target_service_spec.rb' - - 'ee/spec/services/ee/releases/create_evidence_service_spec.rb' - - 'ee/spec/services/ee/resource_events/change_iteration_service_spec.rb' - - 'ee/spec/services/ee/resource_events/change_labels_service_spec.rb' - - 'ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb' - - 'ee/spec/services/ee/resource_events/synthetic_iteration_notes_builder_service_spec.rb' - - 'ee/spec/services/ee/resource_events/synthetic_weight_notes_builder_service_spec.rb' - - 'ee/spec/services/ee/system_notes/issuables_service_spec.rb' - - 'ee/spec/services/ee/terraform/states/destroy_service_spec.rb' - - 'ee/spec/services/ee/todos/destroy/entity_leave_service_spec.rb' - - 'ee/spec/services/ee/users/approve_service_spec.rb' - - 'ee/spec/services/ee/users/authorized_build_service_spec.rb' - - 'ee/spec/services/ee/users/block_service_spec.rb' - - 'ee/spec/services/ee/users/build_service_spec.rb' - - 'ee/spec/services/ee/users/create_service_spec.rb' - - 'ee/spec/services/ee/users/destroy_service_spec.rb' - - 'ee/spec/services/ee/users/migrate_records_to_ghost_user_service_spec.rb' - - 'ee/spec/services/ee/users/reject_service_spec.rb' - - 'ee/spec/services/ee/users/update_service_spec.rb' - - 'ee/spec/services/ee/vulnerability_feedback_module/update_service_spec.rb' - - 'ee/spec/services/elastic/cluster_reindexing_service_spec.rb' - - 'ee/spec/services/elastic/data_migration_service_spec.rb' - - 'ee/spec/services/elastic/index_projects_by_id_service_spec.rb' - - 'ee/spec/services/elastic/index_projects_by_range_service_spec.rb' - - 'ee/spec/services/elastic/index_projects_service_spec.rb' - - 'ee/spec/services/elastic/indexing_control_service_spec.rb' - - 'ee/spec/services/elastic/metrics_update_service_spec.rb' - - 'ee/spec/services/elastic/process_initial_bookkeeping_service_spec.rb' - - 'ee/spec/services/emails/create_service_spec.rb' - - 'ee/spec/services/emails/destroy_service_spec.rb' - - 'ee/spec/services/epic_issues/destroy_service_spec.rb' - - 'ee/spec/services/epic_issues/list_service_spec.rb' - - 'ee/spec/services/epic_issues/update_service_spec.rb' - - 'ee/spec/services/epics/close_service_spec.rb' - - 'ee/spec/services/epics/create_service_spec.rb' - - 'ee/spec/services/epics/descendant_count_service_spec.rb' - - 'ee/spec/services/epics/epic_links/list_service_spec.rb' - - 'ee/spec/services/epics/issue_promote_service_spec.rb' - - 'ee/spec/services/epics/reopen_service_spec.rb' - - 'ee/spec/services/epics/transfer_service_spec.rb' - - 'ee/spec/services/epics/update_dates_service_spec.rb' - - 'ee/spec/services/epics/update_service_spec.rb' - 'ee/spec/services/external_status_checks/create_service_spec.rb' - - 'ee/spec/services/external_status_checks/destroy_service_spec.rb' - - 'ee/spec/services/external_status_checks/dispatch_service_spec.rb' - - 'ee/spec/services/external_status_checks/update_service_spec.rb' - - 'ee/spec/services/feature_flag_issues/destroy_service_spec.rb' - - 'ee/spec/services/geo/base_file_service_spec.rb' - - 'ee/spec/services/geo/blob_download_service_spec.rb' - - 'ee/spec/services/geo/blob_upload_service_spec.rb' - - 'ee/spec/services/geo/cache_invalidation_event_store_spec.rb' - - 'ee/spec/services/geo/container_repository_registry_removal_service_spec.rb' - - 'ee/spec/services/geo/container_repository_sync_service_spec.rb' - - 'ee/spec/services/geo/container_repository_sync_spec.rb' - - 'ee/spec/services/geo/event_service_spec.rb' - - 'ee/spec/services/geo/file_registry_removal_service_spec.rb' - - 'ee/spec/services/geo/files_expire_service_spec.rb' - - 'ee/spec/services/geo/framework_repository_sync_service_spec.rb' - - 'ee/spec/services/geo/graphql_request_service_spec.rb' - - 'ee/spec/services/geo/hashed_storage_attachments_event_store_spec.rb' - - 'ee/spec/services/geo/hashed_storage_attachments_migration_service_spec.rb' - - 'ee/spec/services/geo/hashed_storage_migrated_event_store_spec.rb' - - 'ee/spec/services/geo/hashed_storage_migration_service_spec.rb' - - 'ee/spec/services/geo/metrics_update_service_spec.rb' - - 'ee/spec/services/geo/move_repository_service_spec.rb' - - 'ee/spec/services/geo/node_create_service_spec.rb' - - 'ee/spec/services/geo/node_status_request_service_spec.rb' - - 'ee/spec/services/geo/node_update_service_spec.rb' - - 'ee/spec/services/geo/project_housekeeping_service_spec.rb' - - 'ee/spec/services/geo/prune_event_log_service_spec.rb' - - 'ee/spec/services/geo/rename_repository_service_spec.rb' - - 'ee/spec/services/geo/replication_toggle_request_service_spec.rb' - - 'ee/spec/services/geo/repositories_changed_event_store_spec.rb' - - 'ee/spec/services/geo/repository_base_sync_service_spec.rb' - - 'ee/spec/services/geo/repository_created_event_store_spec.rb' - - 'ee/spec/services/geo/repository_deleted_event_store_spec.rb' - - 'ee/spec/services/geo/repository_destroy_service_spec.rb' - - 'ee/spec/services/geo/repository_registry_removal_service_spec.rb' - - 'ee/spec/services/geo/repository_renamed_event_store_spec.rb' - - 'ee/spec/services/geo/repository_updated_event_store_spec.rb' - - 'ee/spec/services/geo/repository_updated_service_spec.rb' - - 'ee/spec/services/geo/repository_verification_reset_spec.rb' - - 'ee/spec/services/geo/reset_checksum_event_store_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/activate_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/check_future_renewal_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/create_hand_raise_lead_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/create_lead_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/create_trial_or_lead_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/extend_reactivate_trial_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/fetch_purchase_eligible_namespaces_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/fetch_subscription_plans_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/plan_upgrade_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/preview_billable_user_change_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/reconciliations/check_seat_usage_alerts_eligibility_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/trials/apply_trial_service_spec.rb' - - 'ee/spec/services/group_saml/group_managed_accounts/clean_up_members_service_spec.rb' - - 'ee/spec/services/group_saml/group_managed_accounts/transfer_membership_service_spec.rb' - - 'ee/spec/services/group_saml/identity/destroy_service_spec.rb' - - 'ee/spec/services/group_saml/saml_group_links/create_service_spec.rb' - - 'ee/spec/services/group_saml/saml_group_links/destroy_service_spec.rb' - - 'ee/spec/services/group_saml/saml_provider/create_service_spec.rb' - - 'ee/spec/services/group_saml/saml_provider/update_service_spec.rb' - - 'ee/spec/services/group_saml/sign_up_service_spec.rb' - - 'ee/spec/services/groups/create_service_spec.rb' - - 'ee/spec/services/groups/epics_count_service_spec.rb' - - 'ee/spec/services/groups/mark_for_deletion_service_spec.rb' - - 'ee/spec/services/groups/memberships/export_service_spec.rb' - - 'ee/spec/services/groups/participants_service_spec.rb' - - 'ee/spec/services/groups/restore_service_spec.rb' - - 'ee/spec/services/groups/schedule_bulk_repository_shard_moves_service_spec.rb' - - 'ee/spec/services/groups/seat_usage_export_service_spec.rb' - - 'ee/spec/services/groups/transfer_service_spec.rb' - - 'ee/spec/services/groups/update_repository_storage_service_spec.rb' - - 'ee/spec/services/groups/update_service_spec.rb' - - 'ee/spec/services/historical_user_data/csv_service_spec.rb' - - 'ee/spec/services/ide/schemas_config_service_spec.rb' - - 'ee/spec/services/incident_management/create_incident_sla_exceeded_label_service_spec.rb' - - 'ee/spec/services/incident_management/escalation_policies/create_service_spec.rb' - - 'ee/spec/services/incident_management/escalation_policies/destroy_service_spec.rb' - - 'ee/spec/services/incident_management/escalation_policies/update_service_spec.rb' - - 'ee/spec/services/incident_management/escalation_rules/destroy_service_spec.rb' - - 'ee/spec/services/incident_management/incidents/create_sla_service_spec.rb' - - 'ee/spec/services/incident_management/incidents/upload_metric_service_spec.rb' - - 'ee/spec/services/incident_management/issuable_resource_links/create_service_spec.rb' - - 'ee/spec/services/incident_management/issuable_resource_links/destroy_service_spec.rb' - - 'ee/spec/services/incident_management/issuable_resource_links/zoom_link_service_spec.rb' - - 'ee/spec/services/incident_management/oncall_rotations/create_service_spec.rb' - - 'ee/spec/services/incident_management/oncall_rotations/destroy_service_spec.rb' - - 'ee/spec/services/incident_management/oncall_rotations/edit_service_spec.rb' - - 'ee/spec/services/incident_management/oncall_rotations/remove_participant_service_spec.rb' - - 'ee/spec/services/incident_management/oncall_rotations/remove_participants_service_spec.rb' - - 'ee/spec/services/incident_management/oncall_schedules/create_service_spec.rb' - - 'ee/spec/services/incident_management/oncall_schedules/destroy_service_spec.rb' - - 'ee/spec/services/incident_management/oncall_schedules/update_service_spec.rb' - - 'ee/spec/services/incident_management/oncall_shifts/read_service_spec.rb' - - 'ee/spec/services/incident_management/pending_escalations/create_service_spec.rb' - - 'ee/spec/services/incident_management/pending_escalations/process_service_spec.rb' - - 'ee/spec/services/integrations/slack_event_service_spec.rb' - - 'ee/spec/services/integrations/slack_events/app_home_opened_service_spec.rb' - - 'ee/spec/services/integrations/slack_events/url_verification_service_spec.rb' - - 'ee/spec/services/integrations/slack_interactions/incident_management/incident_modal_closed_service_spec.rb' - - 'ee/spec/services/issuable/destroy_label_links_service_spec.rb' - - 'ee/spec/services/issuable/discussions_list_service_spec.rb' - - 'ee/spec/services/issue_feature_flags/list_service_spec.rb' - - 'ee/spec/services/issues/build_service_spec.rb' - - 'ee/spec/services/issues/duplicate_service_spec.rb' - - 'ee/spec/services/iterations/cadences/create_iterations_in_advance_service_spec.rb' - - 'ee/spec/services/iterations/cadences/create_service_spec.rb' - - 'ee/spec/services/iterations/cadences/destroy_service_spec.rb' - - 'ee/spec/services/iterations/cadences/update_service_spec.rb' - - 'ee/spec/services/iterations/create_service_spec.rb' - - 'ee/spec/services/iterations/delete_service_spec.rb' - - 'ee/spec/services/iterations/update_service_spec.rb' - - 'ee/spec/services/jira/jql_builder_service_spec.rb' - - 'ee/spec/services/jira/requests/issues/list_service_spec.rb' - - 'ee/spec/services/keys/create_service_spec.rb' - - 'ee/spec/services/keys/last_used_service_spec.rb' - - 'ee/spec/services/ldap_group_reset_service_spec.rb' - - 'ee/spec/services/lfs/lock_file_service_spec.rb' - - 'ee/spec/services/lfs/unlock_file_service_spec.rb' - - 'ee/spec/services/licenses/destroy_service_spec.rb' - - 'ee/spec/services/members/activate_service_spec.rb' - - 'ee/spec/services/members/await_service_spec.rb' - - 'ee/spec/services/merge_commits/export_csv_service_spec.rb' - - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - - 'ee/spec/services/merge_requests/approval_service_spec.rb' - - 'ee/spec/services/merge_requests/build_service_spec.rb' - - 'ee/spec/services/merge_requests/merge_service_spec.rb' - - 'ee/spec/services/merge_requests/merge_to_ref_service_spec.rb' - - 'ee/spec/services/merge_requests/mergeability/check_approved_service_spec.rb' - - 'ee/spec/services/merge_requests/mergeability/check_blocked_by_other_mrs_service_spec.rb' - - 'ee/spec/services/merge_requests/mergeability/check_denied_policies_service_spec.rb' - - 'ee/spec/services/merge_requests/mergeability/check_external_status_checks_passed_service_spec.rb' - - 'ee/spec/services/merge_requests/push_options_handler_service_spec.rb' - - 'ee/spec/services/merge_requests/reload_merge_head_diff_service_spec.rb' - - 'ee/spec/services/merge_requests/remove_approval_service_spec.rb' - - 'ee/spec/services/merge_requests/stream_approval_audit_event_service_spec.rb' - - 'ee/spec/services/merge_requests/sync_code_owner_approval_rules_spec.rb' - - 'ee/spec/services/merge_requests/sync_report_approver_approval_rules_spec.rb' - - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' - - 'ee/spec/services/merge_trains/check_status_service_spec.rb' - - 'ee/spec/services/merge_trains/refresh_merge_request_service_spec.rb' - - 'ee/spec/services/merge_trains/refresh_service_spec.rb' - - 'ee/spec/services/milestones/destroy_service_spec.rb' - - 'ee/spec/services/milestones/promote_service_spec.rb' - - 'ee/spec/services/milestones/update_service_spec.rb' - - 'ee/spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - - 'ee/spec/services/namespaces/storage/email_notification_service_spec.rb' - - 'ee/spec/services/path_locks/lock_service_spec.rb' - - 'ee/spec/services/path_locks/unlock_service_spec.rb' - - 'ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb' - - 'ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb' - - 'ee/spec/services/personal_access_tokens/instance/update_lifetime_service_spec.rb' - - 'ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb' - - 'ee/spec/services/personal_access_tokens/revoke_service_audit_log_spec.rb' - - 'ee/spec/services/personal_access_tokens/rotation_verifier_service_spec.rb' - - 'ee/spec/services/phone_verification/telesign_client/base_service_spec.rb' - - 'ee/spec/services/phone_verification/telesign_client/risk_score_service_spec.rb' - - 'ee/spec/services/phone_verification/telesign_client/send_verification_code_service_spec.rb' - - 'ee/spec/services/phone_verification/telesign_client/verify_code_service_spec.rb' - - 'ee/spec/services/phone_verification/users/send_verification_code_service_spec.rb' - - 'ee/spec/services/product_analytics/initialize_stack_service_spec.rb' - 'ee/spec/services/projects/after_rename_service_spec.rb' - 'ee/spec/services/projects/alerting/notify_service_spec.rb' - 'ee/spec/services/projects/cleanup_service_spec.rb' @@ -2106,7 +1493,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/projects/enable_deploy_key_service_spec.rb' - 'ee/spec/services/projects/fork_service_spec.rb' - 'ee/spec/services/projects/gitlab_projects_import_service_spec.rb' - - 'ee/spec/services/projects/group_links/create_service_spec.rb' - 'ee/spec/services/projects/group_links/destroy_service_spec.rb' - 'ee/spec/services/projects/group_links/update_service_spec.rb' - 'ee/spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb' @@ -2122,7 +1508,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/projects/setup_ci_cd_spec.rb' - 'ee/spec/services/projects/transfer_service_spec.rb' - 'ee/spec/services/projects/update_mirror_service_spec.rb' - - 'ee/spec/services/projects/update_service_spec.rb' - 'ee/spec/services/protected_environments/base_service_spec.rb' - 'ee/spec/services/protected_environments/environment_dropdown_service_spec.rb' - 'ee/spec/services/protected_environments/search_service_spec.rb' @@ -2133,105 +1518,8 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/releases/update_service_spec.rb' - 'ee/spec/services/requirements_management/prepare_import_csv_service_spec.rb' - 'ee/spec/services/requirements_management/process_test_reports_service_spec.rb' - - 'ee/spec/services/resource_access_tokens/create_service_spec.rb' - 'ee/spec/services/resource_access_tokens/revoke_service_spec.rb' - - 'ee/spec/services/search/snippet_service_spec.rb' - - 'ee/spec/services/security/auto_fix_label_service_spec.rb' - - 'ee/spec/services/security/auto_fix_service_spec.rb' - - 'ee/spec/services/security/configuration/save_auto_fix_service_spec.rb' - - 'ee/spec/services/security/dependency_list_service_spec.rb' - - 'ee/spec/services/security/findings/dismiss_service_spec.rb' - - 'ee/spec/services/security/ingestion/finding_map_collection_spec.rb' - - 'ee/spec/services/security/ingestion/finding_map_spec.rb' - - 'ee/spec/services/security/ingestion/ingest_report_service_spec.rb' - - 'ee/spec/services/security/ingestion/ingest_report_slice_service_spec.rb' - - 'ee/spec/services/security/ingestion/ingest_reports_service_spec.rb' - - 'ee/spec/services/security/ingestion/mark_as_resolved_service_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/hooks_execution_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_finding_evidence_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_identifiers_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_remediations_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities/mark_resolved_as_detected_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerability_statistics_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' - - 'ee/spec/services/security/merge_reports_service_spec.rb' - - 'ee/spec/services/security/orchestration/assign_service_spec.rb' - - 'ee/spec/services/security/orchestration/unassign_service_spec.rb' - - 'ee/spec/services/security/override_uuids_service_spec.rb' - - 'ee/spec/services/security/purge_scans_service_spec.rb' - - 'ee/spec/services/security/report_fetch_service_spec.rb' - - 'ee/spec/services/security/report_summary_service_spec.rb' - - 'ee/spec/services/security/scanned_resources_counting_service_spec.rb' - - 'ee/spec/services/security/scanned_resources_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/fetch_policy_approvers_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/fetch_policy_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/operational_vulnerabilities_configuration_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/policy_configuration_validation_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/process_policy_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/process_rule_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/project_create_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/rule_schedule_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/sync_open_merge_requests_head_pipeline_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/sync_opened_merge_requests_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/sync_scan_result_policies_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/validate_policy_service_spec.rb' - - 'ee/spec/services/security/store_findings_service_spec.rb' - - 'ee/spec/services/security/store_grouped_scans_service_spec.rb' - - 'ee/spec/services/security/store_scan_service_spec.rb' - - 'ee/spec/services/security/store_scans_service_spec.rb' - - 'ee/spec/services/security/token_revocation_service_spec.rb' - - 'ee/spec/services/security/track_scan_service_spec.rb' - - 'ee/spec/services/security/update_training_service_spec.rb' - - 'ee/spec/services/security/vulnerability_counting_service_spec.rb' - - 'ee/spec/services/sitemap/create_service_spec.rb' - - 'ee/spec/services/slash_commands/global_slack_handler_spec.rb' - - 'ee/spec/services/software_license_policies/update_service_spec.rb' - - 'ee/spec/services/start_pull_mirroring_service_spec.rb' - - 'ee/spec/services/status_page/mark_for_publication_service_spec.rb' - - 'ee/spec/services/status_page/publish_attachments_service_spec.rb' - - 'ee/spec/services/status_page/publish_details_service_spec.rb' - - 'ee/spec/services/status_page/publish_list_service_spec.rb' - - 'ee/spec/services/status_page/publish_service_spec.rb' - - 'ee/spec/services/status_page/trigger_publish_service_spec.rb' - - 'ee/spec/services/status_page/unpublish_details_service_spec.rb' - - 'ee/spec/services/system_note_service_spec.rb' - - 'ee/spec/services/system_notes/epics_service_spec.rb' - - 'ee/spec/services/system_notes/escalations_service_spec.rb' - - 'ee/spec/services/system_notes/merge_train_service_spec.rb' - - 'ee/spec/services/system_notes/vulnerabilities_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' - - 'ee/spec/services/todo_service_spec.rb' - - 'ee/spec/services/todos/allowed_target_filter_service_spec.rb' - - 'ee/spec/services/todos/destroy/confidential_epic_service_spec.rb' - - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - - 'ee/spec/services/user_permissions/export_service_spec.rb' - - 'ee/spec/services/users/abuse/namespace_bans/create_service_spec.rb' - - 'ee/spec/services/users/abuse/namespace_bans/destroy_service_spec.rb' - - 'ee/spec/services/users/abuse/projects_download_ban_check_service_spec.rb' - - 'ee/spec/services/users/captcha_challenge_service_spec.rb' - - 'ee/spec/services/users/update_highest_member_role_service_spec.rb' - - 'ee/spec/services/users_ops_dashboard_projects/destroy_service_spec.rb' - - 'ee/spec/services/vulnerability_exports/create_service_spec.rb' - - 'ee/spec/services/vulnerability_exports/export_service_spec.rb' - - 'ee/spec/services/vulnerability_exports/exporters/csv_service_spec.rb' - - 'ee/spec/services/vulnerability_external_issue_links/create_service_spec.rb' - - 'ee/spec/services/vulnerability_external_issue_links/destroy_service_spec.rb' - - 'ee/spec/services/vulnerability_feedback/destroy_service_spec.rb' - - 'ee/spec/services/vulnerability_issue_links/create_service_spec.rb' - - 'ee/spec/services/vulnerability_issue_links/delete_service_spec.rb' - - 'ee/spec/services/vulnerability_merge_request_links/create_service_spec.rb' - - 'ee/spec/services/vulnerability_scanners/list_service_spec.rb' - - 'ee/spec/services/web_hook_service_spec.rb' - - 'ee/spec/services/wiki_pages/create_service_spec.rb' - - 'ee/spec/services/wiki_pages/destroy_service_spec.rb' - - 'ee/spec/services/wiki_pages/update_service_spec.rb' - - 'ee/spec/services/wikis/create_attachment_service_spec.rb' - - 'ee/spec/services/work_items/update_service_spec.rb' - - 'ee/spec/services/work_items/widgets/status_service/update_service_spec.rb' - - 'ee/spec/services/work_items/widgets/weight_service/update_service_spec.rb' - - 'ee/spec/tasks/geo/git_rake_spec.rb' - 'ee/spec/tasks/gitlab/license_rake_spec.rb' - 'ee/spec/tasks/gitlab/spdx_rake_spec.rb' - 'ee/spec/uploaders/every_gitlab_uploader_spec.rb' @@ -2255,28 +1543,18 @@ RSpec/MissingFeatureCategory: - 'ee/spec/views/compliance_management/compliance_framework/_project_settings.html.haml_spec.rb' - 'ee/spec/views/devise/sessions/new.html.haml_spec.rb' - 'ee/spec/views/groups/_compliance_frameworks.html.haml_spec.rb' - - 'ee/spec/views/groups/analytics/dashboards/index.html.haml_spec.rb' - - 'ee/spec/views/groups/billings/index.html.haml_spec.rb' - - 'ee/spec/views/groups/compliance_frameworks/edit.html.haml_spec.rb' - - 'ee/spec/views/groups/compliance_frameworks/new.html.haml_spec.rb' - - 'ee/spec/views/groups/edit.html.haml_spec.rb' - - 'ee/spec/views/groups/feature_discovery_moments/advanced_features_dashboard.html.haml_spec.rb' - 'ee/spec/views/groups/hook_logs/show.html.haml_spec.rb' - 'ee/spec/views/groups/hooks/edit.html.haml_spec.rb' - 'ee/spec/views/groups/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/groups/settings/_remove.html.haml_spec.rb' - 'ee/spec/views/groups/settings/reporting/show.html.haml_spec.rb' - - 'ee/spec/views/layouts/_search.html.haml_spec.rb' - 'ee/spec/views/layouts/application.html.haml_spec.rb' - 'ee/spec/views/layouts/checkout.html.haml_spec.rb' - 'ee/spec/views/layouts/group.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_current_user_dropdown.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_ee_subscribable_banner.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_read_only_banner.html.haml_spec.rb' - - 'ee/spec/views/layouts/header/help_dropdown/_cross_stage_fdm.html.haml_spec.rb' - - 'ee/spec/views/layouts/nav/sidebar/_admin.html.haml_spec.rb' - 'ee/spec/views/layouts/nav/sidebar/_group.html.haml_spec.rb' - - 'ee/spec/views/layouts/nav/sidebar/_push_rules_link.html.haml_spec.rb' - 'ee/spec/views/layouts/project.html.haml_spec.rb' - 'ee/spec/views/operations/environments.html.haml_spec.rb' - 'ee/spec/views/operations/index.html.haml_spec.rb' @@ -2284,7 +1562,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/views/projects/_merge_request_status_checks_settings.html.haml_spec.rb' - 'ee/spec/views/projects/edit.html.haml_spec.rb' - 'ee/spec/views/projects/issues/show.html.haml_spec.rb' - - 'ee/spec/views/projects/on_demand_scans/index.html.haml_spec.rb' - 'ee/spec/views/projects/security/corpus_management/show.html.haml_spec.rb' - 'ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb' - 'ee/spec/views/projects/security/dast_scanner_profiles/edit.html.haml_spec.rb' @@ -2296,9 +1573,7 @@ RSpec/MissingFeatureCategory: - 'ee/spec/views/projects/security/sast_configuration/show.html.haml_spec.rb' - 'ee/spec/views/projects/settings/merge_requests/_merge_request_approvals.html.haml_spec.rb' - 'ee/spec/views/projects/settings/subscriptions/_index.html.haml_spec.rb' - - 'ee/spec/views/registrations/company/new.html.haml_spec.rb' - 'ee/spec/views/registrations/groups_projects/new.html.haml_spec.rb' - - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' - 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb' - 'ee/spec/views/shared/_kerberos_clone_button.html.haml_spec.rb' - 'ee/spec/views/shared/_mirror_status.html.haml_spec.rb' @@ -2327,169 +1602,12 @@ RSpec/MissingFeatureCategory: - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - 'ee/spec/views/subscriptions/new.html.haml_spec.rb' - 'ee/spec/views/trial_registrations/new.html.haml_spec.rb' - - 'ee/spec/workers/active_user_count_threshold_worker_spec.rb' - - 'ee/spec/workers/adjourned_group_deletion_worker_spec.rb' - - 'ee/spec/workers/adjourned_project_deletion_worker_spec.rb' - - 'ee/spec/workers/adjourned_projects_deletion_cron_worker_spec.rb' - - 'ee/spec/workers/admin_emails_worker_spec.rb' - - 'ee/spec/workers/analytics/code_review_metrics_worker_spec.rb' - - 'ee/spec/workers/analytics/cycle_analytics/consistency_worker_spec.rb' - - 'ee/spec/workers/analytics/cycle_analytics/incremental_worker_spec.rb' - - 'ee/spec/workers/analytics/cycle_analytics/reaggregation_worker_spec.rb' - - 'ee/spec/workers/analytics/devops_adoption/create_all_snapshots_worker_spec.rb' - - 'ee/spec/workers/analytics/devops_adoption/create_snapshot_worker_spec.rb' - - 'ee/spec/workers/app_sec/dast/scanner_profiles_builds/consistency_worker_spec.rb' - - 'ee/spec/workers/app_sec/dast/scans/consistency_worker_spec.rb' - - 'ee/spec/workers/app_sec/dast/site_profiles_builds/consistency_worker_spec.rb' - - 'ee/spec/workers/approval_rules/external_approval_rule_payload_worker_spec.rb' - - 'ee/spec/workers/audit_events/user_impersonation_event_create_worker_spec.rb' - - 'ee/spec/workers/auth/saml_group_sync_worker_spec.rb' - - 'ee/spec/workers/ci/batch_reset_minutes_worker_spec.rb' - - 'ee/spec/workers/ci/initial_pipeline_process_worker_spec.rb' - - 'ee/spec/workers/ci/minutes/refresh_cached_data_worker_spec.rb' - - 'ee/spec/workers/ci/minutes/update_project_and_namespace_usage_worker_spec.rb' - - 'ee/spec/workers/ci/runners/stale_group_runners_prune_cron_worker_spec.rb' - - 'ee/spec/workers/ci/sync_reports_to_report_approval_rules_worker_spec.rb' - - 'ee/spec/workers/ci/trigger_downstream_subscriptions_worker_spec.rb' - - 'ee/spec/workers/ci/upstream_projects_subscriptions_cleanup_worker_spec.rb' - - 'ee/spec/workers/clear_shared_runners_minutes_worker_spec.rb' - - 'ee/spec/workers/compliance_management/chain_of_custody_report_worker_spec.rb' - - 'ee/spec/workers/compliance_management/merge_requests/compliance_violations_worker_spec.rb' - - 'ee/spec/workers/compliance_management/update_default_framework_worker_spec.rb' - - 'ee/spec/workers/concerns/elastic/indexing_control_spec.rb' - - 'ee/spec/workers/concerns/elastic/migration_obsolete_spec.rb' - - 'ee/spec/workers/concerns/elastic/migration_options_spec.rb' - - 'ee/spec/workers/concerns/geo_queue_spec.rb' - - 'ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb' - - 'ee/spec/workers/create_github_webhook_worker_spec.rb' - - 'ee/spec/workers/deployments/auto_rollback_worker_spec.rb' - - 'ee/spec/workers/dora/daily_metrics/refresh_worker_spec.rb' - - 'ee/spec/workers/ee/arkose/blocked_users_report_worker_spec.rb' - - 'ee/spec/workers/ee/ci/build_finished_worker_spec.rb' - - 'ee/spec/workers/ee/issuable_export_csv_worker_spec.rb' - - 'ee/spec/workers/ee/namespaces/in_product_marketing_emails_worker_spec.rb' - - 'ee/spec/workers/ee/namespaces/root_statistics_worker_spec.rb' - - 'ee/spec/workers/ee/projects/inactive_projects_deletion_cron_worker_spec.rb' - - 'ee/spec/workers/ee/repository_check/batch_worker_spec.rb' - - 'ee/spec/workers/ee/repository_check/single_repository_worker_spec.rb' - - 'ee/spec/workers/elastic/migration_worker_spec.rb' - - 'ee/spec/workers/elastic/project_transfer_worker_spec.rb' - - 'ee/spec/workers/elastic_association_indexer_worker_spec.rb' - - 'ee/spec/workers/elastic_cluster_reindexing_cron_worker_spec.rb' - - 'ee/spec/workers/elastic_full_index_worker_spec.rb' - - 'ee/spec/workers/elastic_index_initial_bulk_cron_worker_spec.rb' - - 'ee/spec/workers/elastic_indexing_control_worker_spec.rb' - - 'ee/spec/workers/elastic_namespace_indexer_worker_spec.rb' - - 'ee/spec/workers/elastic_namespace_rollout_worker_spec.rb' - - 'ee/spec/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker_spec.rb' - - 'ee/spec/workers/epics/new_epic_issue_worker_spec.rb' - - 'ee/spec/workers/epics/update_cached_metadata_worker_spec.rb' - - 'ee/spec/workers/geo/batch/project_registry_scheduler_worker_spec.rb' - - 'ee/spec/workers/geo/batch/project_registry_worker_spec.rb' - - 'ee/spec/workers/geo/batch_event_create_worker_spec.rb' - - 'ee/spec/workers/geo/container_repository_sync_worker_spec.rb' - - 'ee/spec/workers/geo/create_repository_updated_event_worker_spec.rb' - - 'ee/spec/workers/geo/design_repository_shard_sync_worker_spec.rb' - - 'ee/spec/workers/geo/design_repository_sync_worker_spec.rb' - - 'ee/spec/workers/geo/destroy_worker_spec.rb' - - 'ee/spec/workers/geo/event_worker_spec.rb' - - 'ee/spec/workers/geo/file_registry_removal_worker_spec.rb' - - 'ee/spec/workers/geo/metrics_update_worker_spec.rb' - - 'ee/spec/workers/geo/prune_event_log_worker_spec.rb' - - 'ee/spec/workers/geo/repositories_clean_up_worker_spec.rb' - - 'ee/spec/workers/geo/repository_cleanup_worker_spec.rb' - - 'ee/spec/workers/geo/repository_shard_sync_worker_spec.rb' - - 'ee/spec/workers/geo/repository_sync_worker_spec.rb' - - 'ee/spec/workers/geo/repository_verification/primary/batch_worker_spec.rb' - - 'ee/spec/workers/geo/repository_verification/primary/shard_worker_spec.rb' - - 'ee/spec/workers/geo/repository_verification/primary/single_worker_spec.rb' - - 'ee/spec/workers/geo/repository_verification/secondary/scheduler_worker_spec.rb' - - 'ee/spec/workers/geo/repository_verification/secondary/shard_worker_spec.rb' - - 'ee/spec/workers/geo/repository_verification/secondary/single_worker_spec.rb' - - 'ee/spec/workers/geo/reverification_batch_worker_spec.rb' - - 'ee/spec/workers/geo/scheduler/per_shard_scheduler_worker_spec.rb' - - 'ee/spec/workers/geo/scheduler/scheduler_worker_spec.rb' - - 'ee/spec/workers/geo/secondary_usage_data_cron_worker_spec.rb' - - 'ee/spec/workers/geo/sidekiq_cron_config_worker_spec.rb' - - 'ee/spec/workers/geo/sync_timeout_cron_worker_spec.rb' - - 'ee/spec/workers/geo/verification_batch_worker_spec.rb' - - 'ee/spec/workers/geo/verification_cron_worker_spec.rb' - - 'ee/spec/workers/geo/verification_state_backfill_service_spec.rb' - - 'ee/spec/workers/geo/verification_state_backfill_worker_spec.rb' - - 'ee/spec/workers/geo/verification_worker_spec.rb' - - 'ee/spec/workers/geo_repository_destroy_worker_spec.rb' - - 'ee/spec/workers/gitlab_subscriptions/trials/apply_trial_worker_spec.rb' - - 'ee/spec/workers/group_saml_group_sync_worker_spec.rb' - - 'ee/spec/workers/groups/create_event_worker_spec.rb' - - 'ee/spec/workers/groups/export_memberships_worker_spec.rb' - - 'ee/spec/workers/groups/schedule_bulk_repository_shard_moves_worker_spec.rb' - - 'ee/spec/workers/groups/update_repository_storage_worker_spec.rb' - - 'ee/spec/workers/historical_data_worker_spec.rb' - - 'ee/spec/workers/import_software_licenses_worker_spec.rb' - - 'ee/spec/workers/incident_management/apply_incident_sla_exceeded_label_worker_spec.rb' - - 'ee/spec/workers/incident_management/incident_sla_exceeded_check_worker_spec.rb' - - 'ee/spec/workers/incident_management/oncall_rotations/persist_all_rotations_shifts_job_spec.rb' - - 'ee/spec/workers/incident_management/oncall_rotations/persist_shifts_job_spec.rb' - - 'ee/spec/workers/incident_management/pending_escalations/alert_check_worker_spec.rb' - - 'ee/spec/workers/incident_management/pending_escalations/alert_create_worker_spec.rb' - - 'ee/spec/workers/incident_management/pending_escalations/issue_check_worker_spec.rb' - - 'ee/spec/workers/incident_management/pending_escalations/issue_create_worker_spec.rb' - - 'ee/spec/workers/incident_management/pending_escalations/schedule_check_cron_worker_spec.rb' - - 'ee/spec/workers/integrations/slack_event_worker_spec.rb' - - 'ee/spec/workers/iterations/cadences/create_iterations_worker_spec.rb' - - 'ee/spec/workers/iterations/cadences/schedule_create_iterations_worker_spec.rb' - - 'ee/spec/workers/iterations/roll_over_issues_worker_spec.rb' - - 'ee/spec/workers/iterations_update_status_worker_spec.rb' - - 'ee/spec/workers/ldap_all_groups_sync_worker_spec.rb' - - 'ee/spec/workers/ldap_group_sync_worker_spec.rb' - - 'ee/spec/workers/ldap_sync_worker_spec.rb' - - 'ee/spec/workers/licenses/reset_submit_license_usage_data_banner_worker_spec.rb' - - 'ee/spec/workers/merge_request_reset_approvals_worker_spec.rb' - - 'ee/spec/workers/merge_requests/stream_approval_audit_event_worker_spec.rb' - - 'ee/spec/workers/merge_requests/sync_code_owner_approval_rules_worker_spec.rb' - - 'ee/spec/workers/merge_trains/refresh_worker_spec.rb' - - 'ee/spec/workers/namespaces/sync_namespace_name_worker_spec.rb' - - 'ee/spec/workers/new_epic_worker_spec.rb' - - 'ee/spec/workers/personal_access_tokens/groups/policy_worker_spec.rb' - - 'ee/spec/workers/personal_access_tokens/instance/policy_worker_spec.rb' - - 'ee/spec/workers/post_receive_spec.rb' - - 'ee/spec/workers/product_analytics/initialize_analytics_worker_spec.rb' - - 'ee/spec/workers/project_cache_worker_spec.rb' - - 'ee/spec/workers/project_template_export_worker_spec.rb' - - 'ee/spec/workers/projects/disable_legacy_open_source_license_for_inactive_projects_worker_spec.rb' - - 'ee/spec/workers/repository_update_mirror_worker_spec.rb' - - 'ee/spec/workers/requirements_management/import_requirements_csv_worker_spec.rb' - - 'ee/spec/workers/requirements_management/process_requirements_reports_worker_spec.rb' - - 'ee/spec/workers/scan_security_report_secrets_worker_spec.rb' - - 'ee/spec/workers/security/auto_fix_worker_spec.rb' - - 'ee/spec/workers/security/create_orchestration_policy_worker_spec.rb' - - 'ee/spec/workers/security/orchestration_policy_rule_schedule_namespace_worker_spec.rb' - - 'ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb' - - 'ee/spec/workers/security/process_scan_result_policy_worker_spec.rb' - - 'ee/spec/workers/security/scans/purge_by_job_id_worker_spec.rb' - - 'ee/spec/workers/security/scans/purge_worker_spec.rb' - - 'ee/spec/workers/security/store_scans_worker_spec.rb' - - 'ee/spec/workers/security/sync_scan_policies_worker_spec.rb' - - 'ee/spec/workers/security/track_secure_scans_worker_spec.rb' - - 'ee/spec/workers/set_user_status_based_on_user_cap_setting_worker_spec.rb' - - 'ee/spec/workers/status_page/publish_worker_spec.rb' - - 'ee/spec/workers/store_security_reports_worker_spec.rb' - - 'ee/spec/workers/sync_seat_link_request_worker_spec.rb' - - 'ee/spec/workers/sync_seat_link_worker_spec.rb' - - 'ee/spec/workers/todos_destroyer/confidential_epic_worker_spec.rb' - - 'ee/spec/workers/update_all_mirrors_worker_spec.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - - 'ee/spec/workers/vulnerability_exports/export_deletion_worker_spec.rb' - - 'ee/spec/workers/vulnerability_exports/export_worker_spec.rb' - - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/bin/audit_event_type_spec.rb' - 'spec/bin/diagnostic_reports_uploader_spec.rb' - 'spec/bin/sidekiq_cluster_spec.rb' - 'spec/channels/application_cable/connection_spec.rb' - - 'spec/channels/awareness_channel_spec.rb' - 'spec/commands/diagnostic_reports/uploader_smoke_spec.rb' - 'spec/commands/metrics_server/metrics_server_spec.rb' - - 'spec/commands/sidekiq_cluster/cli_spec.rb' - 'spec/components/diffs/overflow_warning_component_spec.rb' - 'spec/components/diffs/stats_component_spec.rb' - 'spec/components/layouts/horizontal_section_component_spec.rb' @@ -2510,7 +1628,6 @@ RSpec/MissingFeatureCategory: - 'spec/components/pajamas/toggle_component_spec.rb' - 'spec/controllers/acme_challenges_controller_spec.rb' - 'spec/controllers/admin/application_settings/appearances_controller_spec.rb' - - 'spec/controllers/admin/application_settings_controller_spec.rb' - 'spec/controllers/admin/applications_controller_spec.rb' - 'spec/controllers/admin/ci/variables_controller_spec.rb' - 'spec/controllers/admin/cohorts_controller_spec.rb' @@ -2527,17 +1644,14 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/admin/plan_limits_controller_spec.rb' - 'spec/controllers/admin/projects_controller_spec.rb' - 'spec/controllers/admin/sessions_controller_spec.rb' - - 'spec/controllers/admin/spam_logs_controller_spec.rb' - 'spec/controllers/admin/topics/avatars_controller_spec.rb' - 'spec/controllers/admin/topics_controller_spec.rb' - 'spec/controllers/admin/usage_trends_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' - - 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/autocomplete_controller_spec.rb' - 'spec/controllers/chaos_controller_spec.rb' - 'spec/controllers/concerns/check_rate_limit_spec.rb' - 'spec/controllers/concerns/checks_collaboration_spec.rb' - - 'spec/controllers/concerns/confirm_email_warning_spec.rb' - 'spec/controllers/concerns/continue_params_spec.rb' - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' - 'spec/controllers/concerns/enforces_admin_authentication_spec.rb' @@ -2555,10 +1669,8 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/concerns/preferred_language_switcher_spec.rb' - 'spec/controllers/concerns/project_unauthorized_spec.rb' - 'spec/controllers/concerns/redirects_for_missing_path_on_tree_spec.rb' - - 'spec/controllers/concerns/redis_tracking_spec.rb' - 'spec/controllers/concerns/renders_commits_spec.rb' - 'spec/controllers/concerns/routable_actions_spec.rb' - - 'spec/controllers/concerns/send_file_upload_spec.rb' - 'spec/controllers/concerns/sorting_preference_spec.rb' - 'spec/controllers/concerns/sourcegraph_decorator_spec.rb' - 'spec/controllers/concerns/spammable_actions/akismet_mark_as_spam_action_spec.rb' @@ -2566,7 +1678,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/concerns/spammable_actions/captcha_check/json_format_actions_support_spec.rb' - 'spec/controllers/concerns/spammable_actions/captcha_check/rest_api_actions_support_spec.rb' - 'spec/controllers/concerns/static_object_external_storage_spec.rb' - - 'spec/controllers/confirmations_controller_spec.rb' - 'spec/controllers/dashboard/groups_controller_spec.rb' - 'spec/controllers/dashboard/labels_controller_spec.rb' - 'spec/controllers/dashboard/milestones_controller_spec.rb' @@ -2598,27 +1709,14 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/groups/variables_controller_spec.rb' - 'spec/controllers/health_check_controller_spec.rb' - 'spec/controllers/help_controller_spec.rb' - - 'spec/controllers/import/bitbucket_controller_spec.rb' - - 'spec/controllers/import/bitbucket_server_controller_spec.rb' - - 'spec/controllers/import/fogbugz_controller_spec.rb' - - 'spec/controllers/import/gitea_controller_spec.rb' - - 'spec/controllers/import/gitlab_controller_spec.rb' - - 'spec/controllers/import/manifest_controller_spec.rb' - - 'spec/controllers/import/phabricator_controller_spec.rb' - 'spec/controllers/invites_controller_spec.rb' - - 'spec/controllers/jira_connect/app_descriptor_controller_spec.rb' - - 'spec/controllers/jira_connect/branches_controller_spec.rb' - - 'spec/controllers/jira_connect/events_controller_spec.rb' - - 'spec/controllers/jira_connect/subscriptions_controller_spec.rb' - 'spec/controllers/ldap/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/metrics_controller_spec.rb' - 'spec/controllers/oauth/applications_controller_spec.rb' - 'spec/controllers/oauth/authorizations_controller_spec.rb' - 'spec/controllers/oauth/authorized_applications_controller_spec.rb' - - 'spec/controllers/oauth/jira_dvcs/authorizations_controller_spec.rb' - 'spec/controllers/oauth/token_info_controller_spec.rb' - 'spec/controllers/oauth/tokens_controller_spec.rb' - - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/passwords_controller_spec.rb' - 'spec/controllers/profiles/accounts_controller_spec.rb' - 'spec/controllers/profiles/active_sessions_controller_spec.rb' @@ -2636,17 +1734,13 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/analytics/cycle_analytics/stages_controller_spec.rb' - 'spec/controllers/projects/analytics/cycle_analytics/summary_controller_spec.rb' - 'spec/controllers/projects/analytics/cycle_analytics/value_streams_controller_spec.rb' - - 'spec/controllers/projects/artifacts_controller_spec.rb' - 'spec/controllers/projects/autocomplete_sources_controller_spec.rb' - 'spec/controllers/projects/avatars_controller_spec.rb' - 'spec/controllers/projects/badges_controller_spec.rb' - - 'spec/controllers/projects/blame_controller_spec.rb' - - 'spec/controllers/projects/blob_controller_spec.rb' - 'spec/controllers/projects/boards_controller_spec.rb' - 'spec/controllers/projects/ci/daily_build_group_report_results_controller_spec.rb' - 'spec/controllers/projects/ci/lints_controller_spec.rb' - 'spec/controllers/projects/ci/pipeline_editor_controller_spec.rb' - - 'spec/controllers/projects/commit_controller_spec.rb' - 'spec/controllers/projects/compare_controller_spec.rb' - 'spec/controllers/projects/cycle_analytics/events_controller_spec.rb' - 'spec/controllers/projects/cycle_analytics_controller_spec.rb' @@ -2664,9 +1758,7 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/feature_flags_user_lists_controller_spec.rb' - 'spec/controllers/projects/find_file_controller_spec.rb' - 'spec/controllers/projects/graphs_controller_spec.rb' - - 'spec/controllers/projects/hooks_controller_spec.rb' - 'spec/controllers/projects/import/jira_controller_spec.rb' - - 'spec/controllers/projects/imports_controller_spec.rb' - 'spec/controllers/projects/incidents_controller_spec.rb' - 'spec/controllers/projects/issue_links_controller_spec.rb' - 'spec/controllers/projects/mattermosts_controller_spec.rb' @@ -2677,7 +1769,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/mirrors_controller_spec.rb' - 'spec/controllers/projects/packages/infrastructure_registry_controller_spec.rb' - 'spec/controllers/projects/packages/packages_controller_spec.rb' - - 'spec/controllers/projects/pages_controller_spec.rb' - 'spec/controllers/projects/performance_monitoring/dashboards_controller_spec.rb' - 'spec/controllers/projects/pipelines/stages_controller_spec.rb' - 'spec/controllers/projects/pipelines/tests_controller_spec.rb' @@ -2704,17 +1795,13 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/templates_controller_spec.rb' - 'spec/controllers/projects/terraform_controller_spec.rb' - 'spec/controllers/projects/todos_controller_spec.rb' - - 'spec/controllers/projects/tree_controller_spec.rb' - 'spec/controllers/projects/uploads_controller_spec.rb' - 'spec/controllers/projects/usage_quotas_controller_spec.rb' - 'spec/controllers/projects/variables_controller_spec.rb' - 'spec/controllers/projects/web_ide_schemas_controller_spec.rb' - 'spec/controllers/projects/web_ide_terminals_controller_spec.rb' - - 'spec/controllers/projects/wikis_controller_spec.rb' - - 'spec/controllers/repositories/git_http_controller_spec.rb' - 'spec/controllers/repositories/lfs_storage_controller_spec.rb' - 'spec/controllers/root_controller_spec.rb' - - 'spec/controllers/search_controller_spec.rb' - 'spec/controllers/sent_notifications_controller_spec.rb' - 'spec/controllers/sessions_controller_spec.rb' - 'spec/controllers/snippets/blobs_controller_spec.rb' @@ -2732,16 +1819,12 @@ RSpec/MissingFeatureCategory: - 'spec/dependencies/omniauth_saml_spec.rb' - 'spec/docs_screenshots/container_registry_docs.rb' - 'spec/docs_screenshots/wiki_docs.rb' - - 'spec/experiments/application_experiment_spec.rb' - 'spec/experiments/concerns/project_commit_count_spec.rb' - 'spec/experiments/force_company_trial_experiment_spec.rb' - 'spec/experiments/in_product_guidance_environments_webide_experiment_spec.rb' - 'spec/experiments/ios_specific_templates_experiment_spec.rb' - - 'spec/experiments/require_verification_for_namespace_creation_experiment_spec.rb' - - 'spec/experiments/security_reports_mr_widget_prompt_experiment_spec.rb' - 'spec/features/admin/dashboard_spec.rb' - 'spec/features/groups/integrations/group_integrations_spec.rb' - - 'spec/features/markdown/observability_spec.rb' - 'spec/features/milestones/user_views_milestones_spec.rb' - 'spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb' - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' @@ -2778,7 +1861,6 @@ RSpec/MissingFeatureCategory: - 'spec/finders/ci/runner_jobs_finder_spec.rb' - 'spec/finders/ci/variables_finder_spec.rb' - 'spec/finders/cluster_ancestors_finder_spec.rb' - - 'spec/finders/clusters/agent_authorizations_finder_spec.rb' - 'spec/finders/clusters/agent_tokens_finder_spec.rb' - 'spec/finders/clusters/agents_finder_spec.rb' - 'spec/finders/clusters/knative_services_finder_spec.rb' @@ -2812,7 +1894,6 @@ RSpec/MissingFeatureCategory: - 'spec/finders/groups/accepting_project_transfers_finder_spec.rb' - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb' - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_transfer_finder_spec.rb' - - 'spec/finders/groups/user_groups_finder_spec.rb' - 'spec/finders/groups_finder_spec.rb' - 'spec/finders/incident_management/timeline_event_tags_finder_spec.rb' - 'spec/finders/incident_management/timeline_events_finder_spec.rb' @@ -2835,7 +1916,6 @@ RSpec/MissingFeatureCategory: - 'spec/finders/packages/build_infos_finder_spec.rb' - 'spec/finders/packages/composer/packages_finder_spec.rb' - 'spec/finders/packages/conan/package_file_finder_spec.rb' - - 'spec/finders/packages/conan/package_finder_spec.rb' - 'spec/finders/packages/debian/distributions_finder_spec.rb' - 'spec/finders/packages/generic/package_finder_spec.rb' - 'spec/finders/packages/go/module_finder_spec.rb' @@ -2878,7 +1958,6 @@ RSpec/MissingFeatureCategory: - 'spec/finders/security/license_compliance_jobs_finder_spec.rb' - 'spec/finders/security/security_jobs_finder_spec.rb' - 'spec/finders/sentry_issue_finder_spec.rb' - - 'spec/finders/serverless_domain_finder_spec.rb' - 'spec/finders/snippets_finder_spec.rb' - 'spec/finders/starred_projects_finder_spec.rb' - 'spec/finders/tags_finder_spec.rb' @@ -2926,7 +2005,6 @@ RSpec/MissingFeatureCategory: - 'spec/frontend/fixtures/prometheus_integration.rb' - 'spec/frontend/fixtures/raw.rb' - 'spec/frontend/fixtures/releases.rb' - - 'spec/frontend/fixtures/runner.rb' - 'spec/frontend/fixtures/search.rb' - 'spec/frontend/fixtures/sessions.rb' - 'spec/frontend/fixtures/snippet.rb' @@ -2935,11 +2013,9 @@ RSpec/MissingFeatureCategory: - 'spec/frontend/fixtures/tags.rb' - 'spec/frontend/fixtures/timezones.rb' - 'spec/frontend/fixtures/todos.rb' - - 'spec/frontend/fixtures/u2f.rb' - 'spec/frontend/fixtures/webauthn.rb' - 'spec/graphql/features/authorization_spec.rb' - 'spec/graphql/gitlab_schema_spec.rb' - - 'spec/graphql/graphql_triggers_spec.rb' - 'spec/graphql/mutations/alert_management/alerts/set_assignees_spec.rb' - 'spec/graphql/mutations/alert_management/alerts/todo/create_spec.rb' - 'spec/graphql/mutations/alert_management/create_alert_issue_spec.rb' @@ -2962,7 +2038,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/mutations/clusters/agents/create_spec.rb' - 'spec/graphql/mutations/clusters/agents/delete_spec.rb' - 'spec/graphql/mutations/commits/create_spec.rb' - - 'spec/graphql/mutations/concerns/mutations/finds_by_gid_spec.rb' - 'spec/graphql/mutations/concerns/mutations/resolves_group_spec.rb' - 'spec/graphql/mutations/concerns/mutations/resolves_issuable_spec.rb' - 'spec/graphql/mutations/container_expiration_policies/update_spec.rb' @@ -3011,9 +2086,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/mutations/namespace/package_settings/update_spec.rb' - 'spec/graphql/mutations/notes/reposition_image_diff_note_spec.rb' - 'spec/graphql/mutations/pages/mark_onboarding_complete_spec.rb' - - 'spec/graphql/mutations/release_asset_links/create_spec.rb' - - 'spec/graphql/mutations/release_asset_links/delete_spec.rb' - - 'spec/graphql/mutations/release_asset_links/update_spec.rb' - 'spec/graphql/mutations/releases/create_spec.rb' - 'spec/graphql/mutations/releases/delete_spec.rb' - 'spec/graphql/mutations/releases/update_spec.rb' @@ -3048,10 +2120,8 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/resolvers/board_resolver_spec.rb' - 'spec/graphql/resolvers/boards_resolver_spec.rb' - 'spec/graphql/resolvers/branch_commit_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/all_jobs_resolver_spec.rb' - 'spec/graphql/resolvers/ci/config_resolver_spec.rb' - 'spec/graphql/resolvers/ci/job_token_scope_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/jobs_resolver_spec.rb' - 'spec/graphql/resolvers/ci/project_pipeline_counts_resolver_spec.rb' - 'spec/graphql/resolvers/ci/template_resolver_spec.rb' - 'spec/graphql/resolvers/ci/test_report_summary_resolver_spec.rb' @@ -3092,10 +2162,8 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/resolvers/group_labels_resolver_spec.rb' - 'spec/graphql/resolvers/group_members/notification_email_resolver_spec.rb' - 'spec/graphql/resolvers/group_members_resolver_spec.rb' - - 'spec/graphql/resolvers/group_milestones_resolver_spec.rb' - 'spec/graphql/resolvers/group_packages_resolver_spec.rb' - 'spec/graphql/resolvers/group_resolver_spec.rb' - - 'spec/graphql/resolvers/groups_resolver_spec.rb' - 'spec/graphql/resolvers/incident_management/timeline_event_tags_resolver_spec.rb' - 'spec/graphql/resolvers/incident_management/timeline_events_resolver_spec.rb' - 'spec/graphql/resolvers/issue_status_counts_resolver_spec.rb' @@ -3112,7 +2180,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/resolvers/package_details_resolver_spec.rb' - 'spec/graphql/resolvers/package_pipelines_resolver_spec.rb' - 'spec/graphql/resolvers/packages_base_resolver_spec.rb' - - 'spec/graphql/resolvers/paginated_tree_resolver_spec.rb' - 'spec/graphql/resolvers/project_issues_resolver_spec.rb' - 'spec/graphql/resolvers/project_jobs_resolver_spec.rb' - 'spec/graphql/resolvers/project_members_resolver_spec.rb' @@ -3199,7 +2266,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/types/ci/job_kind_enum_spec.rb' - 'spec/graphql/types/ci/job_need_union_spec.rb' - 'spec/graphql/types/ci/job_status_enum_spec.rb' - - 'spec/graphql/types/ci/job_type_spec.rb' - 'spec/graphql/types/ci/manual_variable_type_spec.rb' - 'spec/graphql/types/ci/pipeline_counts_type_spec.rb' - 'spec/graphql/types/ci/pipeline_merge_request_event_type_enum_spec.rb' @@ -3269,10 +2335,8 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/types/dependency_proxy/image_ttl_group_policy_type_spec.rb' - 'spec/graphql/types/dependency_proxy/manifest_type_spec.rb' - 'spec/graphql/types/deployment_tier_enum_spec.rb' - - 'spec/graphql/types/design_management/design_at_version_type_spec.rb' - 'spec/graphql/types/design_management/design_collection_copy_state_enum_spec.rb' - 'spec/graphql/types/design_management/design_collection_type_spec.rb' - - 'spec/graphql/types/design_management/design_type_spec.rb' - 'spec/graphql/types/design_management/design_version_event_enum_spec.rb' - 'spec/graphql/types/design_management/version_type_spec.rb' - 'spec/graphql/types/design_management_type_spec.rb' @@ -3320,7 +2384,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/types/merge_request_sort_enum_spec.rb' - 'spec/graphql/types/merge_request_state_enum_spec.rb' - 'spec/graphql/types/merge_request_state_event_enum_spec.rb' - - 'spec/graphql/types/merge_request_type_spec.rb' - 'spec/graphql/types/merge_requests/assignee_type_spec.rb' - 'spec/graphql/types/merge_requests/author_type_spec.rb' - 'spec/graphql/types/merge_requests/participant_type_spec.rb' @@ -3427,10 +2490,8 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/types/user_callout_feature_name_enum_spec.rb' - 'spec/graphql/types/user_callout_type_spec.rb' - 'spec/graphql/types/user_merge_request_interaction_type_spec.rb' - - 'spec/graphql/types/user_preferences_type_spec.rb' - 'spec/graphql/types/user_status_type_spec.rb' - 'spec/graphql/types/work_item_id_type_spec.rb' - - 'spec/graphql/types/work_item_type_spec.rb' - 'spec/graphql/types/work_items/widget_interface_spec.rb' - 'spec/graphql/types/work_items/widget_type_enum_spec.rb' - 'spec/graphql/types/work_items/widgets/assignees_input_type_spec.rb' @@ -3445,36 +2506,30 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/types/x509_certificate_type_spec.rb' - 'spec/graphql/types/x509_issuer_type_spec.rb' - 'spec/haml_lint/linter/inline_javascript_spec.rb' - - 'spec/haml_lint/linter/no_plain_nodes_spec.rb' - 'spec/helpers/access_tokens_helper_spec.rb' - 'spec/helpers/admin/application_settings/settings_helper_spec.rb' - 'spec/helpers/admin/background_migrations_helper_spec.rb' - 'spec/helpers/admin/deploy_key_helper_spec.rb' - 'spec/helpers/admin/identities_helper_spec.rb' - 'spec/helpers/admin/user_actions_helper_spec.rb' - - 'spec/helpers/analytics/cycle_analytics_helper_spec.rb' - 'spec/helpers/appearances_helper_spec.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' - 'spec/helpers/auth_helper_spec.rb' - 'spec/helpers/auto_devops_helper_spec.rb' - - 'spec/helpers/avatars_helper_spec.rb' - 'spec/helpers/award_emoji_helper_spec.rb' - 'spec/helpers/badges_helper_spec.rb' - 'spec/helpers/bizible_helper_spec.rb' - - 'spec/helpers/blame_helper_spec.rb' - 'spec/helpers/blob_helper_spec.rb' - 'spec/helpers/boards_helper_spec.rb' - 'spec/helpers/branches_helper_spec.rb' - 'spec/helpers/breadcrumbs_helper_spec.rb' - - 'spec/helpers/broadcast_messages_helper_spec.rb' - 'spec/helpers/button_helper_spec.rb' - 'spec/helpers/calendar_helper_spec.rb' - 'spec/helpers/ci/builds_helper_spec.rb' - 'spec/helpers/ci/jobs_helper_spec.rb' - 'spec/helpers/ci/pipeline_editor_helper_spec.rb' - 'spec/helpers/ci/pipelines_helper_spec.rb' - - 'spec/helpers/ci/runners_helper_spec.rb' - 'spec/helpers/ci/secure_files_helper_spec.rb' - 'spec/helpers/ci/status_helper_spec.rb' - 'spec/helpers/ci/triggers_helper_spec.rb' @@ -3525,16 +2580,12 @@ RSpec/MissingFeatureCategory: - 'spec/helpers/markup_helper_spec.rb' - 'spec/helpers/members_helper_spec.rb' - 'spec/helpers/milestones_helper_spec.rb' - - 'spec/helpers/namespaces_helper_spec.rb' - 'spec/helpers/nav/top_nav_helper_spec.rb' - - 'spec/helpers/nav_helper_spec.rb' - - 'spec/helpers/notes_helper_spec.rb' - 'spec/helpers/notifications_helper_spec.rb' - 'spec/helpers/notify_helper_spec.rb' - 'spec/helpers/numbers_helper_spec.rb' - 'spec/helpers/one_trust_helper_spec.rb' - 'spec/helpers/operations_helper_spec.rb' - - 'spec/helpers/packages_helper_spec.rb' - 'spec/helpers/page_layout_helper_spec.rb' - 'spec/helpers/pagination_helper_spec.rb' - 'spec/helpers/preferences_helper_spec.rb' @@ -3579,7 +2630,6 @@ RSpec/MissingFeatureCategory: - 'spec/helpers/users/group_callouts_helper_spec.rb' - 'spec/helpers/users_helper_spec.rb' - 'spec/helpers/version_check_helper_spec.rb' - - 'spec/helpers/visibility_level_helper_spec.rb' - 'spec/helpers/web_ide_button_helper_spec.rb' - 'spec/helpers/webpack_helper_spec.rb' - 'spec/helpers/whats_new_helper_spec.rb' @@ -3613,7 +2663,6 @@ RSpec/MissingFeatureCategory: - 'spec/initializers/mailer_retries_spec.rb' - 'spec/initializers/microsoft_graph_mailer_spec.rb' - 'spec/initializers/net_http_patch_spec.rb' - - 'spec/initializers/net_http_response_patch_spec.rb' - 'spec/initializers/omniauth_spec.rb' - 'spec/initializers/pages_storage_check_spec.rb' - 'spec/initializers/rack_VULNDB-255039_patch_spec.rb' @@ -3647,7 +2696,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/api/entities/ci/job_request/port_spec.rb' - 'spec/lib/api/entities/ci/job_request/service_spec.rb' - 'spec/lib/api/entities/ci/pipeline_spec.rb' - - 'spec/lib/api/entities/clusters/agent_authorization_spec.rb' - 'spec/lib/api/entities/clusters/agent_spec.rb' - 'spec/lib/api/entities/deploy_key_spec.rb' - 'spec/lib/api/entities/deploy_keys_project_spec.rb' @@ -3708,21 +2756,16 @@ RSpec/MissingFeatureCategory: - 'spec/lib/api/validations/validators/limit_spec.rb' - 'spec/lib/api/validations/validators/project_portable_spec.rb' - 'spec/lib/api/validations/validators/untrusted_regexp_spec.rb' - - 'spec/lib/atlassian/jira_issue_key_extractor_spec.rb' - 'spec/lib/backup/database_backup_error_spec.rb' - 'spec/lib/backup/file_backup_error_spec.rb' - 'spec/lib/backup/files_spec.rb' - - 'spec/lib/backup/gitaly_backup_spec.rb' - - 'spec/lib/backup/repositories_spec.rb' - 'spec/lib/backup/task_spec.rb' - - 'spec/lib/banzai/filter/external_link_filter_spec.rb' - 'spec/lib/banzai/filter/inline_alert_metrics_filter_spec.rb' - 'spec/lib/banzai/filter/inline_cluster_metrics_filter_spec.rb' - 'spec/lib/banzai/filter/inline_diff_filter_spec.rb' - 'spec/lib/banzai/filter/inline_grafana_metrics_filter_spec.rb' - 'spec/lib/banzai/filter/inline_metrics_filter_spec.rb' - 'spec/lib/banzai/filter/inline_metrics_redactor_filter_spec.rb' - - 'spec/lib/banzai/filter/inline_observability_filter_spec.rb' - 'spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - 'spec/lib/bitbucket/collection_spec.rb' - 'spec/lib/bitbucket/connection_spec.rb' @@ -3756,7 +2799,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/bulk_imports/common/rest/get_badges_query_spec.rb' - 'spec/lib/bulk_imports/common/transformers/prohibited_attributes_transformer_spec.rb' - 'spec/lib/bulk_imports/common/transformers/user_reference_transformer_spec.rb' - - 'spec/lib/bulk_imports/features_spec.rb' - 'spec/lib/bulk_imports/file_downloads/filename_fetch_spec.rb' - 'spec/lib/bulk_imports/file_downloads/validations_spec.rb' - 'spec/lib/bulk_imports/groups/extractors/subgroups_extractor_spec.rb' @@ -3768,7 +2810,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/bulk_imports/groups/pipelines/subgroup_entities_pipeline_spec.rb' - 'spec/lib/bulk_imports/groups/transformers/member_attributes_transformer_spec.rb' - 'spec/lib/bulk_imports/groups/transformers/subgroup_to_entity_transformer_spec.rb' - - 'spec/lib/bulk_imports/ndjson_pipeline_spec.rb' - 'spec/lib/bulk_imports/network_error_spec.rb' - 'spec/lib/bulk_imports/pipeline/context_spec.rb' - 'spec/lib/bulk_imports/pipeline/extracted_data_spec.rb' @@ -3787,7 +2828,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/bulk_imports/projects/pipelines/pipeline_schedules_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_attributes_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb' - - 'spec/lib/bulk_imports/projects/pipelines/project_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/protected_branches_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/releases_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/repository_bundle_pipeline_spec.rb' @@ -3832,7 +2872,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/feature/gitaly_spec.rb' - 'spec/lib/file_size_validator_spec.rb' - 'spec/lib/forever_spec.rb' - - 'spec/lib/generators/gitlab/snowplow_event_definition_generator_spec.rb' - 'spec/lib/generators/gitlab/usage_metric_definition/redis_hll_generator_spec.rb' - 'spec/lib/generators/gitlab/usage_metric_definition_generator_spec.rb' - 'spec/lib/generators/gitlab/usage_metric_generator_spec.rb' @@ -3866,17 +2905,14 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_last_build_started_spec.rb' - 'spec/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_merged_spec.rb' - 'spec/lib/gitlab/analytics/cycle_analytics/stage_events/plan_stage_start_spec.rb' - - 'spec/lib/gitlab/analytics/cycle_analytics/stage_events/stage_event_spec.rb' - 'spec/lib/gitlab/analytics/date_filler_spec.rb' - 'spec/lib/gitlab/analytics/usage_trends/workers_argument_builder_spec.rb' - 'spec/lib/gitlab/anonymous_session_spec.rb' - 'spec/lib/gitlab/api_authentication/builder_spec.rb' - 'spec/lib/gitlab/api_authentication/sent_through_builder_spec.rb' - 'spec/lib/gitlab/api_authentication/token_locator_spec.rb' - - 'spec/lib/gitlab/api_authentication/token_resolver_spec.rb' - 'spec/lib/gitlab/api_authentication/token_type_builder_spec.rb' - 'spec/lib/gitlab/app_json_logger_spec.rb' - - 'spec/lib/gitlab/app_logger_spec.rb' - 'spec/lib/gitlab/app_text_logger_spec.rb' - 'spec/lib/gitlab/application_context_spec.rb' - 'spec/lib/gitlab/application_rate_limiter/base_strategy_spec.rb' @@ -3886,7 +2922,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/asciidoc/html5_converter_spec.rb' - 'spec/lib/gitlab/asciidoc/include_processor_spec.rb' - 'spec/lib/gitlab/asset_proxy_spec.rb' - - 'spec/lib/gitlab/audit/auditor_spec.rb' - 'spec/lib/gitlab/audit/ci_runner_token_author_spec.rb' - 'spec/lib/gitlab/audit/deploy_key_author_spec.rb' - 'spec/lib/gitlab/audit/deploy_token_author_spec.rb' @@ -3899,7 +2934,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/auth/atlassian/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/atlassian/identity_linker_spec.rb' - 'spec/lib/gitlab/auth/atlassian/user_spec.rb' - - 'spec/lib/gitlab/auth/auth_finders_spec.rb' - 'spec/lib/gitlab/auth/blocked_user_tracker_spec.rb' - 'spec/lib/gitlab/auth/crowd/authentication_spec.rb' - 'spec/lib/gitlab/auth/current_user_mode_spec.rb' @@ -3913,7 +2947,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/auth/ldap/dn_spec.rb' - 'spec/lib/gitlab/auth/ldap/person_spec.rb' - 'spec/lib/gitlab/auth/ldap/user_spec.rb' - - 'spec/lib/gitlab/auth/o_auth/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/o_auth/identity_linker_spec.rb' - 'spec/lib/gitlab/auth/o_auth/provider_spec.rb' - 'spec/lib/gitlab/auth/otp/strategies/devise_spec.rb' @@ -3928,28 +2961,20 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/auth/saml/origin_validator_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' - 'spec/lib/gitlab/auth/two_factor_auth_verifier_spec.rb' - - 'spec/lib/gitlab/auth/u2f_webauthn_converter_spec.rb' - 'spec/lib/gitlab/auth/unique_ips_limiter_spec.rb' - 'spec/lib/gitlab/auth/user_access_denied_reason_spec.rb' - 'spec/lib/gitlab/authorized_keys_spec.rb' - 'spec/lib/gitlab/avatar_cache_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_cluster_agents_has_vulnerabilities_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_draft_status_on_merge_requests_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_draft_status_on_merge_requests_with_corrected_regex_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_group_features_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_integrations_type_new_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_internal_on_notes_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_issue_search_data_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_member_namespace_for_group_members_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_namespace_details_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_namespace_id_for_project_route_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_namespace_id_of_vulnerability_reads_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_traversal_ids_children_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_note_discussion_id_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_feature_package_registry_access_level_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_import_level_spec.rb' @@ -3958,11 +2983,8 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_settings_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_topics_title_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_upvotes_count_on_issues_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_user_details_fields_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_user_namespace_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_work_item_type_id_for_issues_spec.rb' - 'spec/lib/gitlab/background_migration/base_job_spec.rb' - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy_spec.rb' @@ -3973,77 +2995,44 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/remove_backfilled_job_artifacts_expire_at_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' - - 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_orphaned_routes_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/delete_orphaned_deployments_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphans_approval_merge_request_rules_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphans_approval_project_rules_spec.rb' - 'spec/lib/gitlab/background_migration/destroy_invalid_group_members_spec.rb' - 'spec/lib/gitlab/background_migration/destroy_invalid_members_spec.rb' - 'spec/lib/gitlab/background_migration/destroy_invalid_project_members_spec.rb' - - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_licence_for_recent_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_inactive_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_no_issues_no_repo_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_one_member_no_repo_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_projects_less_than_one_mb_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/background_migration/expire_o_auth_tokens_spec.rb' - - 'spec/lib/gitlab/background_migration/extract_project_topics_into_separate_table_spec.rb' - 'spec/lib/gitlab/background_migration/fix_duplicate_project_name_and_path_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_first_mentioned_in_commit_at_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_merge_request_diff_commit_users_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata_spec.rb' - 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - 'spec/lib/gitlab/background_migration/mailers/unconfirm_mailer_spec.rb' - - 'spec/lib/gitlab/background_migration/merge_topics_with_same_name_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_shimo_confluence_integration_category_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_u2f_webauthn_spec.rb' - - 'spec/lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature_spec.rb' - - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' - 'spec/lib/gitlab/background_migration/populate_container_repository_migration_plan_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_namespace_statistics_spec.rb' - 'spec/lib/gitlab/background_migration/populate_operation_visibility_permissions_from_operations_spec.rb' - 'spec/lib/gitlab/background_migration/populate_projects_star_count_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_topics_non_private_projects_count_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_topics_total_projects_count_cache_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'spec/lib/gitlab/background_migration/remove_backfilled_job_artifacts_expire_at_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_self_managed_wiki_notes_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_vulnerability_finding_links_spec.rb' - 'spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects_spec.rb' - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb' - 'spec/lib/gitlab/background_migration/set_correct_vulnerability_state_spec.rb' - 'spec/lib/gitlab/background_migration/set_legacy_open_source_license_available_for_non_public_projects_spec.rb' - - 'spec/lib/gitlab/background_migration/steal_migrate_merge_request_diff_commit_users_spec.rb' - 'spec/lib/gitlab/background_migration/update_ci_pipeline_artifacts_unknown_locked_status_spec.rb' - 'spec/lib/gitlab/background_migration/update_delayed_project_removal_to_null_for_user_namespaces_spec.rb' - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - - 'spec/lib/gitlab/background_migration/update_timelogs_null_spent_at_spec.rb' - - 'spec/lib/gitlab/background_migration/update_timelogs_project_id_spec.rb' - - 'spec/lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group_spec.rb' - 'spec/lib/gitlab/background_migration_spec.rb' - - 'spec/lib/gitlab/background_task_spec.rb' - 'spec/lib/gitlab/backtrace_cleaner_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/repository_spec.rb' - 'spec/lib/gitlab/batch_worker_context_spec.rb' - 'spec/lib/gitlab/bitbucket_import/project_creator_spec.rb' - 'spec/lib/gitlab/bitbucket_import/wiki_formatter_spec.rb' @@ -4052,7 +3041,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/branch_push_merge_commit_analyzer_spec.rb' - 'spec/lib/gitlab/buffered_io_spec.rb' - 'spec/lib/gitlab/build_access_spec.rb' - - 'spec/lib/gitlab/bullet/exclusions_spec.rb' - 'spec/lib/gitlab/bullet_spec.rb' - 'spec/lib/gitlab/cache/helpers_spec.rb' - 'spec/lib/gitlab/cache/import/caching_spec.rb' @@ -4063,7 +3051,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/changelog/config_spec.rb' - 'spec/lib/gitlab/changelog/generator_spec.rb' - 'spec/lib/gitlab/changelog/release_spec.rb' - - 'spec/lib/gitlab/changes_list_spec.rb' - 'spec/lib/gitlab/chat/command_spec.rb' - 'spec/lib/gitlab/chat/output_spec.rb' - 'spec/lib/gitlab/chat/responder/base_spec.rb' @@ -4072,9 +3059,7 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/chat_name_token_spec.rb' - 'spec/lib/gitlab/chat_spec.rb' - 'spec/lib/gitlab/checks/branch_check_spec.rb' - - 'spec/lib/gitlab/checks/changes_access_spec.rb' - 'spec/lib/gitlab/checks/container_moved_spec.rb' - - 'spec/lib/gitlab/checks/diff_check_spec.rb' - 'spec/lib/gitlab/checks/force_push_spec.rb' - 'spec/lib/gitlab/checks/lfs_check_spec.rb' - 'spec/lib/gitlab/checks/lfs_integrity_spec.rb' @@ -4091,7 +3076,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/ansi2json/parser_spec.rb' - 'spec/lib/gitlab/ci/ansi2json/result_spec.rb' - 'spec/lib/gitlab/ci/ansi2json/style_spec.rb' - - 'spec/lib/gitlab/ci/ansi2json_spec.rb' - 'spec/lib/gitlab/ci/artifact_file_reader_spec.rb' - 'spec/lib/gitlab/ci/artifacts/logger_spec.rb' - 'spec/lib/gitlab/ci/artifacts/metrics_spec.rb' @@ -4110,7 +3094,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/build/artifacts/metadata_spec.rb' - 'spec/lib/gitlab/ci/build/artifacts/path_spec.rb' - 'spec/lib/gitlab/ci/build/cache_spec.rb' - - 'spec/lib/gitlab/ci/build/context/global_spec.rb' - 'spec/lib/gitlab/ci/build/credentials/factory_spec.rb' - 'spec/lib/gitlab/ci/build/credentials/registry/dependency_proxy_spec.rb' - 'spec/lib/gitlab/ci/build/credentials/registry/gitlab_registry_spec.rb' @@ -4160,14 +3143,12 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/config/entry/need_spec.rb' - 'spec/lib/gitlab/ci/config/entry/needs_spec.rb' - 'spec/lib/gitlab/ci/config/entry/paths_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/policy_spec.rb' - 'spec/lib/gitlab/ci/config/entry/port_spec.rb' - 'spec/lib/gitlab/ci/config/entry/ports_spec.rb' - 'spec/lib/gitlab/ci/config/entry/prefix_spec.rb' - 'spec/lib/gitlab/ci/config/entry/product/matrix_spec.rb' - 'spec/lib/gitlab/ci/config/entry/product/parallel_spec.rb' - 'spec/lib/gitlab/ci/config/entry/product/variables_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/pull_policy_spec.rb' - 'spec/lib/gitlab/ci/config/entry/release/assets/link_spec.rb' - 'spec/lib/gitlab/ci/config/entry/release/assets/links_spec.rb' - 'spec/lib/gitlab/ci/config/entry/release/assets_spec.rb' @@ -4196,7 +3177,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/config/yaml/tags/resolver_spec.rb' - 'spec/lib/gitlab/ci/cron_parser_spec.rb' - 'spec/lib/gitlab/ci/jwt_spec.rb' - - 'spec/lib/gitlab/ci/jwt_v2_spec.rb' - 'spec/lib/gitlab/ci/mask_secret_spec.rb' - 'spec/lib/gitlab/ci/matching/build_matcher_spec.rb' - 'spec/lib/gitlab/ci/matching/runner_matcher_spec.rb' @@ -4205,7 +3185,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/parsers/coverage/cobertura_spec.rb' - 'spec/lib/gitlab/ci/parsers/coverage/sax_document_spec.rb' - 'spec/lib/gitlab/ci/parsers/instrumentation_spec.rb' - - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/sast_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/secret_detection_spec.rb' - 'spec/lib/gitlab/ci/parsers/terraform/tfplan_spec.rb' @@ -4214,7 +3193,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/pipeline/chain/assign_partition_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/build_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/command_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/create_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/ensure_environments_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/ensure_resource_groups_spec.rb' @@ -4233,7 +3211,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/pipeline/chain/template_usage_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/validate/external_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/validate/repository_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/duration_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/and_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/equals_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/not_equals_spec.rb' @@ -4254,12 +3231,9 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/pipeline/seed/processable/resource_group_spec.rb' - 'spec/lib/gitlab/ci/pipeline_object_hierarchy_spec.rb' - 'spec/lib/gitlab/ci/processable_object_hierarchy_spec.rb' - - 'spec/lib/gitlab/ci/project_config/repository_spec.rb' - - 'spec/lib/gitlab/ci/project_config/source_spec.rb' - 'spec/lib/gitlab/ci/project_config_spec.rb' - 'spec/lib/gitlab/ci/reports/accessibility_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb' - - 'spec/lib/gitlab/ci/reports/codequality_mr_diff_spec.rb' - 'spec/lib/gitlab/ci/reports/codequality_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/codequality_reports_spec.rb' - 'spec/lib/gitlab/ci/reports/coverage_report_generator_spec.rb' @@ -4278,7 +3252,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/reports/security/scan_spec.rb' - 'spec/lib/gitlab/ci/reports/security/scanned_resource_spec.rb' - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/terraform_reports_spec.rb' - 'spec/lib/gitlab/ci/reports/test_case_spec.rb' - 'spec/lib/gitlab/ci/reports/test_failure_history_spec.rb' @@ -4317,7 +3290,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/status/build/waiting_for_approval_spec.rb' - 'spec/lib/gitlab/ci/status/build/waiting_for_resource_spec.rb' - 'spec/lib/gitlab/ci/status/canceled_spec.rb' - - 'spec/lib/gitlab/ci/status/composite_spec.rb' - 'spec/lib/gitlab/ci/status/core_spec.rb' - 'spec/lib/gitlab/ci/status/created_spec.rb' - 'spec/lib/gitlab/ci/status/extended_spec.rb' @@ -4334,7 +3306,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/status/pipeline/delayed_spec.rb' - 'spec/lib/gitlab/ci/status/pipeline/factory_spec.rb' - 'spec/lib/gitlab/ci/status/preparing_spec.rb' - - 'spec/lib/gitlab/ci/status/processable/waiting_for_resource_spec.rb' - 'spec/lib/gitlab/ci/status/running_spec.rb' - 'spec/lib/gitlab/ci/status/scheduled_spec.rb' - 'spec/lib/gitlab/ci/status/skipped_spec.rb' @@ -4410,7 +3381,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/config_checker/puma_rugged_checker_spec.rb' - 'spec/lib/gitlab/conflict/file_collection_spec.rb' - 'spec/lib/gitlab/conflict/file_spec.rb' - - 'spec/lib/gitlab/console_spec.rb' - 'spec/lib/gitlab/consul/internal_spec.rb' - 'spec/lib/gitlab/container_repository/tags/cache_spec.rb' - 'spec/lib/gitlab/content_security_policy/config_loader_spec.rb' @@ -4440,10 +3410,8 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_job_transition_log_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_wrapper_spec.rb' - 'spec/lib/gitlab/database/background_migration/health_status/indicators/write_ahead_log_spec.rb' - - 'spec/lib/gitlab/database/background_migration/health_status_spec.rb' - 'spec/lib/gitlab/database/background_migration/prometheus_metrics_spec.rb' - 'spec/lib/gitlab/database/background_migration_job_spec.rb' - 'spec/lib/gitlab/database/batch_average_counter_spec.rb' @@ -4457,9 +3425,7 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/count_spec.rb' - 'spec/lib/gitlab/database/dynamic_model_helpers_spec.rb' - 'spec/lib/gitlab/database/each_database_spec.rb' - - 'spec/lib/gitlab/database/gitlab_schema_spec.rb' - 'spec/lib/gitlab/database/grant_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/action_cable_callbacks_spec.rb' - 'spec/lib/gitlab/database/load_balancing/configuration_spec.rb' - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb' - 'spec/lib/gitlab/database/load_balancing/host_list_spec.rb' @@ -4470,7 +3436,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/load_balancing/service_discovery/sampler_spec.rb' - 'spec/lib/gitlab/database/load_balancing/session_spec.rb' - 'spec/lib/gitlab/database/load_balancing/setup_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' - 'spec/lib/gitlab/database/load_balancing/srv_resolver_spec.rb' - 'spec/lib/gitlab/database/load_balancing/sticking_spec.rb' - 'spec/lib/gitlab/database/loose_foreign_keys_spec.rb' @@ -4478,7 +3443,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/migration_helpers/cascading_namespace_settings_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/loose_foreign_key_helpers_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/v2_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - 'spec/lib/gitlab/database/migration_spec.rb' - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' - 'spec/lib/gitlab/database/migrations/base_background_runner_spec.rb' @@ -4498,8 +3462,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/migrations/sidekiq_helpers_spec.rb' - 'spec/lib/gitlab/database/migrations/test_background_runner_spec.rb' - 'spec/lib/gitlab/database/no_cross_db_foreign_keys_spec.rb' - - 'spec/lib/gitlab/database/obsolete_ignored_columns_spec.rb' - - 'spec/lib/gitlab/database/partitioning/convert_table_to_first_list_partition_spec.rb' - 'spec/lib/gitlab/database/partitioning/detached_partition_dropper_spec.rb' - 'spec/lib/gitlab/database/partitioning/monthly_strategy_spec.rb' - 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb' @@ -4509,17 +3471,13 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb' - 'spec/lib/gitlab/database/partitioning/time_partition_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/index_helpers_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - - 'spec/lib/gitlab/database/partitioning_spec.rb' - 'spec/lib/gitlab/database/pg_class_spec.rb' - 'spec/lib/gitlab/database/postgres_constraint_spec.rb' - 'spec/lib/gitlab/database/postgres_hll/batch_distinct_counter_spec.rb' - 'spec/lib/gitlab/database/postgres_hll/buckets_spec.rb' - 'spec/lib/gitlab/database/postgres_index_bloat_estimate_spec.rb' - 'spec/lib/gitlab/database/postgres_index_spec.rb' - - 'spec/lib/gitlab/database/postgres_partition_spec.rb' - 'spec/lib/gitlab/database/postgres_partitioned_table_spec.rb' - 'spec/lib/gitlab/database/postgresql_adapter/dump_schema_versions_mixin_spec.rb' - 'spec/lib/gitlab/database/postgresql_adapter/empty_query_ping_spec.rb' @@ -4548,10 +3506,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/unidirectional_copy_trigger_spec.rb' - 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb' - 'spec/lib/gitlab/database_importers/common_metrics/prometheus_metric_spec.rb' - - 'spec/lib/gitlab/database_importers/instance_administrators/create_group_spec.rb' - - 'spec/lib/gitlab/database_importers/self_monitoring/project/create_service_spec.rb' - - 'spec/lib/gitlab/database_importers/self_monitoring/project/delete_service_spec.rb' - - 'spec/lib/gitlab/database_spec.rb' - 'spec/lib/gitlab/default_branch_spec.rb' - 'spec/lib/gitlab/dependency_linker/base_linker_spec.rb' - 'spec/lib/gitlab/dependency_linker/cargo_toml_linker_spec.rb' @@ -4580,8 +3534,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/diff/file_spec.rb' - 'spec/lib/gitlab/diff/formatters/image_formatter_spec.rb' - 'spec/lib/gitlab/diff/formatters/text_formatter_spec.rb' - - 'spec/lib/gitlab/diff/highlight_cache_spec.rb' - - 'spec/lib/gitlab/diff/highlight_spec.rb' - 'spec/lib/gitlab/diff/inline_diff_markdown_marker_spec.rb' - 'spec/lib/gitlab/diff/inline_diff_marker_spec.rb' - 'spec/lib/gitlab/diff/inline_diff_spec.rb' @@ -4620,7 +3572,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/email/hook/delivery_metrics_observer_spec.rb' - 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb' - 'spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb' - - 'spec/lib/gitlab/email/hook/validate_addresses_interceptor_spec.rb' - 'spec/lib/gitlab/email/message/build_ios_app_guide_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/admin_verify_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/base_spec.rb' @@ -4634,14 +3585,12 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/email/message/in_product_marketing_spec.rb' - 'spec/lib/gitlab/email/message/repository_push_spec.rb' - 'spec/lib/gitlab/email/receiver_spec.rb' - - 'spec/lib/gitlab/email/reply_parser_spec.rb' - 'spec/lib/gitlab/email/service_desk_receiver_spec.rb' - 'spec/lib/gitlab/email/smime/signer_spec.rb' - 'spec/lib/gitlab/emoji_spec.rb' - 'spec/lib/gitlab/empty_search_results_spec.rb' - 'spec/lib/gitlab/encoding_helper_spec.rb' - 'spec/lib/gitlab/encrypted_configuration_spec.rb' - - 'spec/lib/gitlab/endpoint_attributes_spec.rb' - 'spec/lib/gitlab/error_tracking/context_payload_generator_spec.rb' - 'spec/lib/gitlab/error_tracking/error_repository/open_api_strategy_spec.rb' - 'spec/lib/gitlab/error_tracking/log_formatter_spec.rb' @@ -4652,7 +3601,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/error_tracking/processor/sanitizer_processor_spec.rb' - 'spec/lib/gitlab/error_tracking/processor/sidekiq_processor_spec.rb' - 'spec/lib/gitlab/error_tracking/stack_trace_highlight_decorator_spec.rb' - - 'spec/lib/gitlab/error_tracking_spec.rb' - 'spec/lib/gitlab/etag_caching/middleware_spec.rb' - 'spec/lib/gitlab/etag_caching/router/graphql_spec.rb' - 'spec/lib/gitlab/etag_caching/router/rails_spec.rb' @@ -4683,7 +3631,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/fips_spec.rb' - 'spec/lib/gitlab/fogbugz_import/client_spec.rb' - 'spec/lib/gitlab/fogbugz_import/importer_spec.rb' - - 'spec/lib/gitlab/fogbugz_import/project_creator_spec.rb' - 'spec/lib/gitlab/form_builders/gitlab_ui_form_builder_spec.rb' - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb' - 'spec/lib/gitlab/gfm/uploads_rewriter_spec.rb' @@ -4696,7 +3643,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/git/bundle_file_spec.rb' - 'spec/lib/gitlab/git/changed_path_spec.rb' - 'spec/lib/gitlab/git/changes_spec.rb' - - 'spec/lib/gitlab/git/commit_spec.rb' - 'spec/lib/gitlab/git/commit_stats_spec.rb' - 'spec/lib/gitlab/git/compare_spec.rb' - 'spec/lib/gitlab/git/conflict/file_spec.rb' @@ -4726,7 +3672,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/git/user_spec.rb' - 'spec/lib/gitlab/git/util_spec.rb' - 'spec/lib/gitlab/git/wiki_page_version_spec.rb' - - 'spec/lib/gitlab/git/wraps_gitaly_errors_spec.rb' - 'spec/lib/gitlab/git_access_design_spec.rb' - 'spec/lib/gitlab/git_access_project_spec.rb' - 'spec/lib/gitlab/git_access_snippet_spec.rb' @@ -4738,7 +3683,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/gitaly_client/blobs_stitcher_spec.rb' - 'spec/lib/gitlab/gitaly_client/call_spec.rb' - 'spec/lib/gitlab/gitaly_client/cleanup_service_spec.rb' - - 'spec/lib/gitlab/gitaly_client/commit_service_spec.rb' - 'spec/lib/gitlab/gitaly_client/conflict_files_stitcher_spec.rb' - 'spec/lib/gitlab/gitaly_client/conflicts_service_spec.rb' - 'spec/lib/gitlab/gitaly_client/diff_spec.rb' @@ -4772,14 +3716,12 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/github_import/importer/issue_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/label_links_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/lfs_object_importer_spec.rb' - - 'spec/lib/gitlab/github_import/importer/note_attachments_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/note_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/protected_branch_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/pull_request_merged_by_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/pull_requests/review_request_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/pull_requests_merged_by_importer_spec.rb' - - 'spec/lib/gitlab/github_import/importer/pull_requests_reviews_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/repository_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/single_endpoint_diff_notes_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/single_endpoint_issue_events_importer_spec.rb' @@ -4788,7 +3730,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/github_import/issuable_finder_spec.rb' - 'spec/lib/gitlab/github_import/label_finder_spec.rb' - 'spec/lib/gitlab/github_import/logger_spec.rb' - - 'spec/lib/gitlab/github_import/markdown/attachment_spec.rb' - 'spec/lib/gitlab/github_import/markdown_text_spec.rb' - 'spec/lib/gitlab/github_import/milestone_finder_spec.rb' - 'spec/lib/gitlab/github_import/object_counter_spec.rb' @@ -4813,9 +3754,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/github_import/single_endpoint_notes_importing_spec.rb' - 'spec/lib/gitlab/github_import/user_finder_spec.rb' - 'spec/lib/gitlab/github_import_spec.rb' - - 'spec/lib/gitlab/gitlab_import/client_spec.rb' - - 'spec/lib/gitlab/gitlab_import/importer_spec.rb' - - 'spec/lib/gitlab/gitlab_import/project_creator_spec.rb' - 'spec/lib/gitlab/gl_repository/identifier_spec.rb' - 'spec/lib/gitlab/gl_repository/repo_type_spec.rb' - 'spec/lib/gitlab/gl_repository_spec.rb' @@ -4904,7 +3842,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/i18n/metadata_entry_spec.rb' - 'spec/lib/gitlab/i18n/po_linter_spec.rb' - 'spec/lib/gitlab/i18n/translation_entry_spec.rb' - - 'spec/lib/gitlab/i18n_spec.rb' - 'spec/lib/gitlab/identifier_spec.rb' - 'spec/lib/gitlab/import/database_helpers_spec.rb' - 'spec/lib/gitlab/import/import_failure_service_spec.rb' @@ -4917,37 +3854,23 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/import_export/after_export_strategies/web_upload_strategy_spec.rb' - 'spec/lib/gitlab/import_export/after_export_strategy_builder_spec.rb' - 'spec/lib/gitlab/import_export/attribute_cleaner_spec.rb' - - 'spec/lib/gitlab/import_export/attribute_configuration_spec.rb' - - 'spec/lib/gitlab/import_export/attributes_finder_spec.rb' - - 'spec/lib/gitlab/import_export/attributes_permitter_spec.rb' - 'spec/lib/gitlab/import_export/avatar_restorer_spec.rb' - 'spec/lib/gitlab/import_export/avatar_saver_spec.rb' - 'spec/lib/gitlab/import_export/base/object_builder_spec.rb' - 'spec/lib/gitlab/import_export/base/relation_factory_spec.rb' - - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' - - 'spec/lib/gitlab/import_export/config_spec.rb' - 'spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb' - 'spec/lib/gitlab/import_export/design_repo_restorer_spec.rb' - 'spec/lib/gitlab/import_export/design_repo_saver_spec.rb' - 'spec/lib/gitlab/import_export/duration_measuring_spec.rb' - 'spec/lib/gitlab/import_export/error_spec.rb' - - 'spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb' - 'spec/lib/gitlab/import_export/file_importer_spec.rb' - - 'spec/lib/gitlab/import_export/fork_spec.rb' - 'spec/lib/gitlab/import_export/group/object_builder_spec.rb' - 'spec/lib/gitlab/import_export/group/relation_factory_spec.rb' - - 'spec/lib/gitlab/import_export/group/relation_tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb' - 'spec/lib/gitlab/import_export/hash_util_spec.rb' - 'spec/lib/gitlab/import_export/import_export_spec.rb' - - 'spec/lib/gitlab/import_export/import_failure_service_spec.rb' - 'spec/lib/gitlab/import_export/import_test_coverage_spec.rb' - 'spec/lib/gitlab/import_export/importer_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/file_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_writer_spec.rb' - - 'spec/lib/gitlab/import_export/json/ndjson_reader_spec.rb' - 'spec/lib/gitlab/import_export/json/ndjson_writer_spec.rb' - 'spec/lib/gitlab/import_export/legacy_relation_tree_saver_spec.rb' - 'spec/lib/gitlab/import_export/lfs_restorer_spec.rb' @@ -4955,19 +3878,15 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/import_export/log_util_spec.rb' - 'spec/lib/gitlab/import_export/members_mapper_spec.rb' - 'spec/lib/gitlab/import_export/merge_request_parser_spec.rb' - - 'spec/lib/gitlab/import_export/model_configuration_spec.rb' - 'spec/lib/gitlab/import_export/project/export_task_spec.rb' - 'spec/lib/gitlab/import_export/project/exported_relations_merger_spec.rb' - - 'spec/lib/gitlab/import_export/project/import_task_spec.rb' - 'spec/lib/gitlab/import_export/project/object_builder_spec.rb' - 'spec/lib/gitlab/import_export/project/relation_saver_spec.rb' - 'spec/lib/gitlab/import_export/project/sample/date_calculator_spec.rb' - 'spec/lib/gitlab/import_export/project/sample/relation_factory_spec.rb' - 'spec/lib/gitlab/import_export/project/sample/relation_tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb' - 'spec/lib/gitlab/import_export/reader_spec.rb' - 'spec/lib/gitlab/import_export/recursive_merge_folders_spec.rb' - - 'spec/lib/gitlab/import_export/references_configuration_spec.rb' - 'spec/lib/gitlab/import_export/remote_stream_upload_spec.rb' - 'spec/lib/gitlab/import_export/repo_restorer_spec.rb' - 'spec/lib/gitlab/import_export/repo_saver_spec.rb' @@ -4981,10 +3900,8 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/import_export/uploads_saver_spec.rb' - 'spec/lib/gitlab/import_export/wiki_repo_saver_spec.rb' - 'spec/lib/gitlab/import_formatter_spec.rb' - - 'spec/lib/gitlab/import_sources_spec.rb' - 'spec/lib/gitlab/inactive_projects_deletion_warning_tracker_spec.rb' - 'spec/lib/gitlab/incident_management/pager_duty/incident_issue_description_spec.rb' - - 'spec/lib/gitlab/incoming_email_spec.rb' - 'spec/lib/gitlab/insecure_key_fingerprint_spec.rb' - 'spec/lib/gitlab/instrumentation/rate_limiting_gates_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_base_spec.rb' @@ -5021,19 +3938,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - 'spec/lib/gitlab/kubernetes/deployment_spec.rb' - 'spec/lib/gitlab/kubernetes/generic_secret_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/pod_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/base_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/certificate_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/delete_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/init_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/install_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/patch_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/reset_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/base_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/delete_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/install_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/patch_command_spec.rb' - 'spec/lib/gitlab/kubernetes/ingress_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/entry/cluster_spec.rb' @@ -5058,7 +3962,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/legacy_github_import/branch_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' - 'spec/lib/gitlab/legacy_github_import/comment_formatter_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' - 'spec/lib/gitlab/legacy_github_import/issuable_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/issue_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb' @@ -5085,7 +3988,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/mailgun/webhook_processors/member_invites_spec.rb' - 'spec/lib/gitlab/manifest_import/manifest_spec.rb' - 'spec/lib/gitlab/manifest_import/metadata_spec.rb' - - 'spec/lib/gitlab/manifest_import/project_creator_spec.rb' - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' - 'spec/lib/gitlab/markdown_cache/field_data_spec.rb' - 'spec/lib/gitlab/markdown_cache/redis/extension_spec.rb' @@ -5100,14 +4002,12 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/memory/upload_and_cleanup_reports_spec.rb' - 'spec/lib/gitlab/memory/watchdog/configuration_spec.rb' - 'spec/lib/gitlab/memory/watchdog/monitor/heap_fragmentation_spec.rb' - - 'spec/lib/gitlab/memory/watchdog/monitor/rss_memory_limit_spec.rb' - 'spec/lib/gitlab/memory/watchdog/monitor/unique_memory_growth_spec.rb' - 'spec/lib/gitlab/memory/watchdog/monitor_state_spec.rb' - 'spec/lib/gitlab/merge_requests/mergeability/check_result_spec.rb' - 'spec/lib/gitlab/merge_requests/mergeability/redis_interface_spec.rb' - 'spec/lib/gitlab/merge_requests/mergeability/results_store_spec.rb' - 'spec/lib/gitlab/metrics/background_transaction_spec.rb' - - 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/cache_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/defaults_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/finder_spec.rb' @@ -5146,10 +4046,8 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/metrics/samplers/ruby_sampler_spec.rb' - 'spec/lib/gitlab/metrics/samplers/threads_sampler_spec.rb' - 'spec/lib/gitlab/metrics/sli_spec.rb' - - 'spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/action_view_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb' - - 'spec/lib/gitlab/metrics/subscribers/external_http_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/rack_attack_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/rails_cache_spec.rb' - 'spec/lib/gitlab/metrics/system_spec.rb' @@ -5178,12 +4076,10 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/multi_destination_logger_spec.rb' - 'spec/lib/gitlab/namespaced_session_store_spec.rb' - 'spec/lib/gitlab/nav/top_nav_menu_header_spec.rb' - - 'spec/lib/gitlab/net_http_adapter_spec.rb' - 'spec/lib/gitlab/no_cache_headers_spec.rb' - 'spec/lib/gitlab/noteable_metadata_spec.rb' - 'spec/lib/gitlab/null_request_store_spec.rb' - 'spec/lib/gitlab/object_hierarchy_spec.rb' - - 'spec/lib/gitlab/observability_spec.rb' - 'spec/lib/gitlab/omniauth_initializer_spec.rb' - 'spec/lib/gitlab/optimistic_locking_spec.rb' - 'spec/lib/gitlab/other_markup_spec.rb' @@ -5225,21 +4121,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/performance_bar/stats_spec.rb' - 'spec/lib/gitlab/performance_bar/with_top_level_warnings_spec.rb' - 'spec/lib/gitlab/performance_bar_spec.rb' - - 'spec/lib/gitlab/phabricator_import/cache/map_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/client_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/maniphest_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/tasks_response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/users_response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/issues/task_importer_spec.rb' - - 'spec/lib/gitlab/phabricator_import/project_creator_spec.rb' - - 'spec/lib/gitlab/phabricator_import/representation/task_spec.rb' - - 'spec/lib/gitlab/phabricator_import/representation/user_spec.rb' - - 'spec/lib/gitlab/phabricator_import/user_finder_spec.rb' - - 'spec/lib/gitlab/phabricator_import/worker_state_spec.rb' - 'spec/lib/gitlab/pipeline_scope_counts_spec.rb' - 'spec/lib/gitlab/polling_interval_spec.rb' - 'spec/lib/gitlab/popen/runner_spec.rb' @@ -5260,7 +4141,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/additional_metrics_environment_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb' - 'spec/lib/gitlab/prometheus/query_variables_spec.rb' @@ -5275,12 +4155,10 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/query_limiting_spec.rb' - 'spec/lib/gitlab/quick_actions/command_definition_spec.rb' - 'spec/lib/gitlab/quick_actions/dsl_spec.rb' - - 'spec/lib/gitlab/quick_actions/extractor_spec.rb' - 'spec/lib/gitlab/quick_actions/spend_time_and_date_separator_spec.rb' - 'spec/lib/gitlab/quick_actions/substitution_definition_spec.rb' - 'spec/lib/gitlab/quick_actions/timeline_text_and_date_time_separator_spec.rb' - 'spec/lib/gitlab/quick_actions/users_extractor_spec.rb' - - 'spec/lib/gitlab/rack_attack/instrumented_cache_store_spec.rb' - 'spec/lib/gitlab/rack_attack/request_spec.rb' - 'spec/lib/gitlab/rack_attack/user_allowlist_spec.rb' - 'spec/lib/gitlab/rack_attack_spec.rb' @@ -5317,13 +4195,11 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/route_map_spec.rb' - 'spec/lib/gitlab/routing_spec.rb' - 'spec/lib/gitlab/rugged_instrumentation_spec.rb' - - 'spec/lib/gitlab/runtime_spec.rb' - 'spec/lib/gitlab/saas_spec.rb' - 'spec/lib/gitlab/safe_request_loader_spec.rb' - 'spec/lib/gitlab/safe_request_purger_spec.rb' - 'spec/lib/gitlab/safe_request_store_spec.rb' - 'spec/lib/gitlab/sample_data_template_spec.rb' - - 'spec/lib/gitlab/sanitizers/exception_message_spec.rb' - 'spec/lib/gitlab/sanitizers/exif_spec.rb' - 'spec/lib/gitlab/sanitizers/svg_spec.rb' - 'spec/lib/gitlab/search/abuse_detection_spec.rb' @@ -5343,8 +4219,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/seeders/ci/daily_build_group_report_result_spec.rb' - 'spec/lib/gitlab/serializer/ci/variables_spec.rb' - 'spec/lib/gitlab/serializer/pagination_spec.rb' - - 'spec/lib/gitlab/serverless/service_spec.rb' - - 'spec/lib/gitlab/service_desk_email_spec.rb' - 'spec/lib/gitlab/service_desk_spec.rb' - 'spec/lib/gitlab/session_spec.rb' - 'spec/lib/gitlab/setup_helper/praefect_spec.rb' @@ -5356,7 +4230,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_spec.rb' - 'spec/lib/gitlab/sidekiq_config_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_daemon/monitor_spec.rb' - 'spec/lib/gitlab/sidekiq_death_handler_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/deduplication_logger_spec.rb' @@ -5366,7 +4239,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/sidekiq_middleware/admin_mode/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/client_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/none_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/until_executed_spec.rb' @@ -5413,10 +4285,8 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/slash_commands/presenters/issue_show_spec.rb' - 'spec/lib/gitlab/slash_commands/presenters/run_spec.rb' - 'spec/lib/gitlab/slash_commands/run_spec.rb' - - 'spec/lib/gitlab/slug/environment_spec.rb' - 'spec/lib/gitlab/snippet_search_results_spec.rb' - 'spec/lib/gitlab/sourcegraph_spec.rb' - - 'spec/lib/gitlab/spamcheck/client_spec.rb' - 'spec/lib/gitlab/sql/cte_spec.rb' - 'spec/lib/gitlab/sql/except_spec.rb' - 'spec/lib/gitlab/sql/glob_spec.rb' @@ -5457,15 +4327,11 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/tracking/service_ping_context_spec.rb' - 'spec/lib/gitlab/tracking/snowplow_schema_validation_spec.rb' - 'spec/lib/gitlab/tracking/standard_context_spec.rb' - - 'spec/lib/gitlab/tracking_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - 'spec/lib/gitlab/unicode_spec.rb' - 'spec/lib/gitlab/untrusted_regexp/ruby_syntax_spec.rb' - - 'spec/lib/gitlab/untrusted_regexp_spec.rb' - 'spec/lib/gitlab/uploads_transfer_spec.rb' - - 'spec/lib/gitlab/url_blocker_spec.rb' - 'spec/lib/gitlab/url_blockers/domain_allowlist_entry_spec.rb' - - 'spec/lib/gitlab/url_blockers/ip_allowlist_entry_spec.rb' - 'spec/lib/gitlab/url_blockers/url_allowlist_spec.rb' - 'spec/lib/gitlab/url_builder_spec.rb' - 'spec/lib/gitlab/url_sanitizer_spec.rb' @@ -5480,7 +4346,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/usage/metrics/instrumentations/cert_based_clusters_ff_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/collected_data_categories_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/count_boards_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/count_issues_metric_spec.rb' @@ -5540,7 +4405,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/usage_data_counters/service_usage_data_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/snippet_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/source_code_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/track_unique_events_spec.rb' - 'spec/lib/gitlab/usage_data_counters/vscode_extension_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/web_ide_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/wiki_page_counter_spec.rb' @@ -5549,7 +4413,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/usage_data_non_sql_metrics_spec.rb' - 'spec/lib/gitlab/usage_data_queries_spec.rb' - 'spec/lib/gitlab/user_access_snippet_spec.rb' - - 'spec/lib/gitlab/user_access_spec.rb' - 'spec/lib/gitlab/utils/batch_loader_spec.rb' - 'spec/lib/gitlab/utils/deep_size_spec.rb' - 'spec/lib/gitlab/utils/delegator_override/error_spec.rb' @@ -5629,8 +4492,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/mattermost/team_spec.rb' - 'spec/lib/microsoft_teams/activity_spec.rb' - 'spec/lib/microsoft_teams/notifier_spec.rb' - - 'spec/lib/object_storage/config_spec.rb' - - 'spec/lib/object_storage/direct_upload_spec.rb' - 'spec/lib/omni_auth/strategies/bitbucket_spec.rb' - 'spec/lib/omni_auth/strategies/jwt_spec.rb' - 'spec/lib/pager_duty/webhook_payload_parser_spec.rb' @@ -5641,12 +4502,9 @@ RSpec/MissingFeatureCategory: - 'spec/lib/peek/views/redis_detailed_spec.rb' - 'spec/lib/peek/views/rugged_spec.rb' - 'spec/lib/product_analytics/event_params_spec.rb' - - 'spec/lib/product_analytics/tracker_spec.rb' - 'spec/lib/prometheus/cleanup_multiproc_dir_service_spec.rb' - 'spec/lib/prometheus/pid_provider_spec.rb' - 'spec/lib/quality/seeders/issues_spec.rb' - - 'spec/lib/release_highlights/validator/entry_spec.rb' - - 'spec/lib/rouge/formatters/html_gitlab_spec.rb' - 'spec/lib/safe_zip/entry_spec.rb' - 'spec/lib/safe_zip/extract_params_spec.rb' - 'spec/lib/safe_zip/extract_spec.rb' @@ -5662,41 +4520,21 @@ RSpec/MissingFeatureCategory: - 'spec/lib/sidebars/concerns/container_with_html_options_spec.rb' - 'spec/lib/sidebars/concerns/link_with_html_options_spec.rb' - 'spec/lib/sidebars/groups/menus/ci_cd_menu_spec.rb' - - 'spec/lib/sidebars/groups/menus/group_information_menu_spec.rb' - - 'spec/lib/sidebars/groups/menus/invite_team_members_menu_spec.rb' - - 'spec/lib/sidebars/groups/menus/issues_menu_spec.rb' - - 'spec/lib/sidebars/groups/menus/kubernetes_menu_spec.rb' - - 'spec/lib/sidebars/groups/menus/merge_requests_menu_spec.rb' - 'spec/lib/sidebars/groups/menus/observability_menu_spec.rb' - - 'spec/lib/sidebars/groups/menus/packages_registries_menu_spec.rb' - - 'spec/lib/sidebars/groups/menus/scope_menu_spec.rb' - 'spec/lib/sidebars/groups/menus/settings_menu_spec.rb' - 'spec/lib/sidebars/menu_item_spec.rb' - - 'spec/lib/sidebars/menu_spec.rb' - - 'spec/lib/sidebars/panel_spec.rb' - 'spec/lib/sidebars/projects/context_spec.rb' - 'spec/lib/sidebars/projects/menus/analytics_menu_spec.rb' - 'spec/lib/sidebars/projects/menus/ci_cd_menu_spec.rb' - 'spec/lib/sidebars/projects/menus/confluence_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/deployments_menu_spec.rb' - 'spec/lib/sidebars/projects/menus/external_issue_tracker_menu_spec.rb' - 'spec/lib/sidebars/projects/menus/external_wiki_menu_spec.rb' - 'spec/lib/sidebars/projects/menus/hidden_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/infrastructure_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/invite_team_members_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/issues_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/merge_requests_menu_spec.rb' - 'spec/lib/sidebars/projects/menus/monitor_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/packages_registries_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/project_information_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/scope_menu_spec.rb' - 'spec/lib/sidebars/projects/menus/security_compliance_menu_spec.rb' - 'spec/lib/sidebars/projects/menus/settings_menu_spec.rb' - 'spec/lib/sidebars/projects/menus/shimo_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/snippets_menu_spec.rb' - - 'spec/lib/sidebars/projects/menus/wiki_menu_spec.rb' - 'spec/lib/sidebars/projects/menus/zentao_menu_spec.rb' - - 'spec/lib/sidebars/projects/panel_spec.rb' - 'spec/lib/system_check/app/authorized_keys_permission_check_spec.rb' - 'spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb' - 'spec/lib/system_check/app/hashed_storage_all_projects_check_spec.rb' @@ -5709,10 +4547,8 @@ RSpec/MissingFeatureCategory: - 'spec/lib/system_check/sidekiq_check_spec.rb' - 'spec/lib/system_check/simple_executor_spec.rb' - 'spec/lib/system_check_spec.rb' - - 'spec/lib/tasks/gitlab/metrics_exporter_task_spec.rb' - 'spec/lib/unnested_in_filters/dsl_spec.rb' - 'spec/lib/unnested_in_filters/rewriter_spec.rb' - - 'spec/lib/uploaded_file_spec.rb' - 'spec/lib/version_check_spec.rb' - 'spec/mailers/abuse_report_mailer_spec.rb' - 'spec/mailers/devise_mailer_spec.rb' @@ -5722,14 +4558,11 @@ RSpec/MissingFeatureCategory: - 'spec/mailers/emails/groups_spec.rb' - 'spec/mailers/emails/identity_verification_spec.rb' - 'spec/mailers/emails/in_product_marketing_spec.rb' - - 'spec/mailers/emails/issues_spec.rb' - 'spec/mailers/emails/merge_requests_spec.rb' - 'spec/mailers/emails/pages_domains_spec.rb' - 'spec/mailers/emails/pipelines_spec.rb' - - 'spec/mailers/emails/profile_spec.rb' - 'spec/mailers/emails/projects_spec.rb' - 'spec/mailers/emails/releases_spec.rb' - - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/mailers/notify_spec.rb' - 'spec/mailers/previews_spec.rb' - 'spec/mailers/repository_check_mailer_spec.rb' @@ -5754,7 +4587,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/audit_event_spec.rb' - 'spec/models/authentication_event_spec.rb' - 'spec/models/award_emoji_spec.rb' - - 'spec/models/awareness_session_spec.rb' - 'spec/models/aws/role_spec.rb' - 'spec/models/badge_spec.rb' - 'spec/models/badges/group_badge_spec.rb' @@ -5769,7 +4601,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/blob_viewer/license_spec.rb' - 'spec/models/blob_viewer/markup_spec.rb' - 'spec/models/blob_viewer/metrics_dashboard_yml_spec.rb' - - 'spec/models/blob_viewer/package_json_spec.rb' - 'spec/models/blob_viewer/podspec_json_spec.rb' - 'spec/models/blob_viewer/podspec_spec.rb' - 'spec/models/blob_viewer/readme_spec.rb' @@ -5779,14 +4610,10 @@ RSpec/MissingFeatureCategory: - 'spec/models/board_project_recent_visit_spec.rb' - 'spec/models/board_spec.rb' - 'spec/models/broadcast_message_spec.rb' - - 'spec/models/bulk_import_spec.rb' - 'spec/models/bulk_imports/configuration_spec.rb' - - 'spec/models/bulk_imports/export_spec.rb' - 'spec/models/bulk_imports/export_status_spec.rb' - 'spec/models/bulk_imports/export_upload_spec.rb' - 'spec/models/bulk_imports/failure_spec.rb' - - 'spec/models/bulk_imports/file_transfer/group_config_spec.rb' - - 'spec/models/bulk_imports/file_transfer/project_config_spec.rb' - 'spec/models/bulk_imports/file_transfer_spec.rb' - 'spec/models/bulk_imports/tracker_spec.rb' - 'spec/models/chat_team_spec.rb' @@ -5798,12 +4625,9 @@ RSpec/MissingFeatureCategory: - 'spec/models/ci/build_trace_chunks/database_spec.rb' - 'spec/models/ci/build_trace_chunks/fog_spec.rb' - 'spec/models/ci/build_trace_chunks/redis_spec.rb' - - 'spec/models/ci/build_trace_spec.rb' - - 'spec/models/ci/commit_with_pipeline_spec.rb' - 'spec/models/ci/daily_build_group_report_result_spec.rb' - 'spec/models/ci/deleted_object_spec.rb' - 'spec/models/ci/group_spec.rb' - - 'spec/models/ci/group_variable_spec.rb' - 'spec/models/ci/instance_variable_spec.rb' - 'spec/models/ci/namespace_mirror_spec.rb' - 'spec/models/ci/pending_build_spec.rb' @@ -5825,20 +4649,8 @@ RSpec/MissingFeatureCategory: - 'spec/models/ci/trigger_request_spec.rb' - 'spec/models/ci/unit_test_failure_spec.rb' - 'spec/models/ci/unit_test_spec.rb' - - 'spec/models/ci/variable_spec.rb' - - 'spec/models/clusters/agent_spec.rb' - 'spec/models/clusters/agent_token_spec.rb' - 'spec/models/clusters/agents/activity_event_spec.rb' - - 'spec/models/clusters/agents/group_authorization_spec.rb' - - 'spec/models/clusters/agents/implicit_authorization_spec.rb' - - 'spec/models/clusters/agents/project_authorization_spec.rb' - - 'spec/models/clusters/applications/crossplane_spec.rb' - - 'spec/models/clusters/applications/helm_spec.rb' - - 'spec/models/clusters/applications/ingress_spec.rb' - - 'spec/models/clusters/applications/jupyter_spec.rb' - - 'spec/models/clusters/applications/knative_spec.rb' - - 'spec/models/clusters/applications/prometheus_spec.rb' - - 'spec/models/clusters/applications/runner_spec.rb' - 'spec/models/clusters/cluster_enabled_grant_spec.rb' - 'spec/models/clusters/clusters_hierarchy_spec.rb' - 'spec/models/clusters/group_spec.rb' @@ -5848,13 +4660,10 @@ RSpec/MissingFeatureCategory: - 'spec/models/clusters/project_spec.rb' - 'spec/models/clusters/providers/aws_spec.rb' - 'spec/models/clusters/providers/gcp_spec.rb' - - 'spec/models/commit_collection_spec.rb' - 'spec/models/commit_range_spec.rb' - 'spec/models/commit_signatures/gpg_signature_spec.rb' - 'spec/models/commit_signatures/x509_commit_signature_spec.rb' - 'spec/models/commit_spec.rb' - - 'spec/models/commit_status_spec.rb' - - 'spec/models/compare_spec.rb' - 'spec/models/concerns/access_requestable_spec.rb' - 'spec/models/concerns/after_commit_queue_spec.rb' - 'spec/models/concerns/approvable_spec.rb' @@ -5862,7 +4671,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/concerns/atomic_internal_id_spec.rb' - 'spec/models/concerns/avatarable_spec.rb' - 'spec/models/concerns/awardable_spec.rb' - - 'spec/models/concerns/awareness_spec.rb' - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb' - 'spec/models/concerns/batch_nullify_dependent_associations_spec.rb' - 'spec/models/concerns/blob_language_from_git_attributes_spec.rb' @@ -5879,7 +4687,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/concerns/ci/partitionable/switch_spec.rb' - 'spec/models/concerns/ci/partitionable_spec.rb' - 'spec/models/concerns/ci/track_environment_usage_spec.rb' - - 'spec/models/concerns/clusters/agents/authorization_config_scopes_spec.rb' - 'spec/models/concerns/commit_signature_spec.rb' - 'spec/models/concerns/counter_attribute_spec.rb' - 'spec/models/concerns/cron_schedulable_spec.rb' @@ -5904,7 +4711,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/concerns/from_union_spec.rb' - 'spec/models/concerns/group_descendant_spec.rb' - 'spec/models/concerns/has_environment_scope_spec.rb' - - 'spec/models/concerns/has_user_type_spec.rb' - 'spec/models/concerns/id_in_ordered_spec.rb' - 'spec/models/concerns/ignorable_columns_spec.rb' - 'spec/models/concerns/integrations/enable_ssl_verification_spec.rb' @@ -5929,7 +4735,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/concerns/project_api_compatibility_spec.rb' - 'spec/models/concerns/project_features_compatibility_spec.rb' - 'spec/models/concerns/prometheus_adapter_spec.rb' - - 'spec/models/concerns/protected_ref_access_spec.rb' - 'spec/models/concerns/reactive_caching_spec.rb' - 'spec/models/concerns/redactable_spec.rb' - 'spec/models/concerns/redis_cacheable_spec.rb' @@ -5951,13 +4756,10 @@ RSpec/MissingFeatureCategory: - 'spec/models/concerns/subscribable_spec.rb' - 'spec/models/concerns/taggable_queries_spec.rb' - 'spec/models/concerns/token_authenticatable_spec.rb' - - 'spec/models/concerns/token_authenticatable_strategies/base_spec.rb' - 'spec/models/concerns/token_authenticatable_strategies/digest_spec.rb' - - 'spec/models/concerns/token_authenticatable_strategies/encrypted_spec.rb' - 'spec/models/concerns/token_authenticatable_strategies/encryption_helper_spec.rb' - 'spec/models/concerns/transactions_spec.rb' - 'spec/models/concerns/triggerable_hooks_spec.rb' - - 'spec/models/concerns/uniquify_spec.rb' - 'spec/models/concerns/usage_statistics_spec.rb' - 'spec/models/concerns/vulnerability_finding_helpers_spec.rb' - 'spec/models/concerns/vulnerability_finding_signature_helpers_spec.rb' @@ -5988,7 +4790,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/design_management/design_action_spec.rb' - 'spec/models/design_management/design_at_version_spec.rb' - 'spec/models/design_management/design_collection_spec.rb' - - 'spec/models/design_management/repository_spec.rb' - 'spec/models/design_management/version_spec.rb' - 'spec/models/design_user_mention_spec.rb' - 'spec/models/dev_ops_report/metric_spec.rb' @@ -6005,7 +4806,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/error_tracking/client_key_spec.rb' - 'spec/models/error_tracking/error_event_spec.rb' - 'spec/models/error_tracking/error_spec.rb' - - 'spec/models/error_tracking/project_error_tracking_setting_spec.rb' - 'spec/models/event_collection_spec.rb' - 'spec/models/exported_protected_branch_spec.rb' - 'spec/models/external_issue_spec.rb' @@ -6038,7 +4838,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/instance_configuration_spec.rb' - 'spec/models/instance_metadata/kas_spec.rb' - 'spec/models/instance_metadata_spec.rb' - - 'spec/models/integration_spec.rb' - 'spec/models/integrations/asana_spec.rb' - 'spec/models/integrations/assembla_spec.rb' - 'spec/models/integrations/bamboo_spec.rb' @@ -6047,7 +4846,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/integrations/base_third_party_wiki_spec.rb' - 'spec/models/integrations/bugzilla_spec.rb' - 'spec/models/integrations/buildkite_spec.rb' - - 'spec/models/integrations/campfire_spec.rb' - 'spec/models/integrations/chat_message/alert_message_spec.rb' - 'spec/models/integrations/chat_message/base_message_spec.rb' - 'spec/models/integrations/chat_message/deployment_message_spec.rb' @@ -6059,7 +4857,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' - 'spec/models/integrations/confluence_spec.rb' - 'spec/models/integrations/custom_issue_tracker_spec.rb' - - 'spec/models/integrations/datadog_spec.rb' - 'spec/models/integrations/discord_spec.rb' - 'spec/models/integrations/drone_ci_spec.rb' - 'spec/models/integrations/emails_on_push_spec.rb' @@ -6074,7 +4871,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/integrations/jenkins_spec.rb' - 'spec/models/integrations/jira_spec.rb' - 'spec/models/integrations/jira_tracker_data_spec.rb' - - 'spec/models/integrations/mattermost_slash_commands_spec.rb' - 'spec/models/integrations/mattermost_spec.rb' - 'spec/models/integrations/microsoft_teams_spec.rb' - 'spec/models/integrations/mock_ci_spec.rb' @@ -6086,7 +4882,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/integrations/pushover_spec.rb' - 'spec/models/integrations/redmine_spec.rb' - 'spec/models/integrations/shimo_spec.rb' - - 'spec/models/integrations/slack_slash_commands_spec.rb' - 'spec/models/integrations/slack_spec.rb' - 'spec/models/integrations/teamcity_spec.rb' - 'spec/models/integrations/unify_circuit_spec.rb' @@ -6138,7 +4933,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/milestone_spec.rb' - 'spec/models/ml/candidate_metric_spec.rb' - 'spec/models/ml/candidate_param_spec.rb' - - 'spec/models/ml/experiment_spec.rb' - 'spec/models/namespace/admin_note_spec.rb' - 'spec/models/namespace/aggregation_schedule_spec.rb' - 'spec/models/namespace/detail_spec.rb' @@ -6151,11 +4945,9 @@ RSpec/MissingFeatureCategory: - 'spec/models/namespaces/user_namespace_spec.rb' - 'spec/models/network/graph_spec.rb' - 'spec/models/note_diff_file_spec.rb' - - 'spec/models/note_spec.rb' - 'spec/models/notification_setting_spec.rb' - 'spec/models/oauth_access_grant_spec.rb' - 'spec/models/oauth_access_token_spec.rb' - - 'spec/models/onboarding/completion_spec.rb' - 'spec/models/onboarding/progress_spec.rb' - 'spec/models/operations/feature_flag_spec.rb' - 'spec/models/operations/feature_flags/strategy_spec.rb' @@ -6168,25 +4960,20 @@ RSpec/MissingFeatureCategory: - 'spec/models/packages/conan/file_metadatum_spec.rb' - 'spec/models/packages/conan/metadatum_spec.rb' - 'spec/models/packages/debian/file_entry_spec.rb' - - 'spec/models/packages/debian/file_metadatum_spec.rb' - 'spec/models/packages/debian/group_architecture_spec.rb' - 'spec/models/packages/debian/group_component_file_spec.rb' - 'spec/models/packages/debian/group_component_spec.rb' - 'spec/models/packages/debian/group_distribution_key_spec.rb' - - 'spec/models/packages/debian/group_distribution_spec.rb' - 'spec/models/packages/debian/project_architecture_spec.rb' - 'spec/models/packages/debian/project_component_file_spec.rb' - 'spec/models/packages/debian/project_component_spec.rb' - 'spec/models/packages/debian/project_distribution_key_spec.rb' - - 'spec/models/packages/debian/project_distribution_spec.rb' - 'spec/models/packages/debian/publication_spec.rb' - 'spec/models/packages/dependency_link_spec.rb' - - 'spec/models/packages/dependency_spec.rb' - 'spec/models/packages/go/module_spec.rb' - 'spec/models/packages/go/module_version_spec.rb' - 'spec/models/packages/helm/file_metadatum_spec.rb' - 'spec/models/packages/maven/metadatum_spec.rb' - - 'spec/models/packages/npm/metadatum_spec.rb' - 'spec/models/packages/npm_spec.rb' - 'spec/models/packages/nuget/dependency_link_metadatum_spec.rb' - 'spec/models/packages/nuget/metadatum_spec.rb' @@ -6219,7 +5006,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/preloaders/project_root_ancestor_preloader_spec.rb' - 'spec/models/preloaders/user_max_access_level_in_groups_preloader_spec.rb' - 'spec/models/preloaders/user_max_access_level_in_projects_preloader_spec.rb' - - 'spec/models/preloaders/users_max_access_level_in_projects_preloader_spec.rb' - 'spec/models/product_analytics_event_spec.rb' - 'spec/models/programming_language_spec.rb' - 'spec/models/project_authorization_spec.rb' @@ -6235,13 +5021,10 @@ RSpec/MissingFeatureCategory: - 'spec/models/project_metrics_setting_spec.rb' - 'spec/models/project_pages_metadatum_spec.rb' - 'spec/models/project_repository_spec.rb' - - 'spec/models/project_setting_spec.rb' - 'spec/models/project_snippet_spec.rb' - 'spec/models/project_statistics_spec.rb' - - 'spec/models/project_wiki_spec.rb' - 'spec/models/projects/build_artifacts_size_refresh_spec.rb' - 'spec/models/projects/ci_feature_usage_spec.rb' - - 'spec/models/projects/import_export/relation_export_spec.rb' - 'spec/models/projects/import_export/relation_export_upload_spec.rb' - 'spec/models/projects/project_topic_spec.rb' - 'spec/models/projects/repository_storage_move_spec.rb' @@ -6252,9 +5035,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/prometheus_alert_spec.rb' - 'spec/models/prometheus_metric_spec.rb' - 'spec/models/protectable_dropdown_spec.rb' - - 'spec/models/protected_branch/merge_access_level_spec.rb' - - 'spec/models/protected_branch/push_access_level_spec.rb' - - 'spec/models/protected_branch_spec.rb' - 'spec/models/protected_tag_spec.rb' - 'spec/models/push_event_payload_spec.rb' - 'spec/models/push_event_spec.rb' @@ -6271,9 +5051,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/route_spec.rb' - 'spec/models/sent_notification_spec.rb' - 'spec/models/sentry_issue_spec.rb' - - 'spec/models/serverless/domain_cluster_spec.rb' - - 'spec/models/serverless/domain_spec.rb' - - 'spec/models/serverless/function_spec.rb' - 'spec/models/shard_spec.rb' - 'spec/models/snippet_blob_spec.rb' - 'spec/models/snippet_input_action_collection_spec.rb' @@ -6290,14 +5067,11 @@ RSpec/MissingFeatureCategory: - 'spec/models/synthetic_note_spec.rb' - 'spec/models/system_note_metadata_spec.rb' - 'spec/models/term_agreement_spec.rb' - - 'spec/models/terraform/state_spec.rb' - - 'spec/models/terraform/state_version_spec.rb' - 'spec/models/time_tracking/timelog_category_spec.rb' - 'spec/models/todo_spec.rb' - 'spec/models/token_with_iv_spec.rb' - 'spec/models/tree_spec.rb' - 'spec/models/trending_project_spec.rb' - - 'spec/models/u2f_registration_spec.rb' - 'spec/models/upload_spec.rb' - 'spec/models/uploads/fog_spec.rb' - 'spec/models/uploads/local_spec.rb' @@ -6311,7 +5085,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/user_mentions/issue_user_mention_spec.rb' - 'spec/models/user_mentions/merge_request_user_mention_spec.rb' - 'spec/models/user_mentions/snippet_user_mention_spec.rb' - - 'spec/models/user_preference_spec.rb' - 'spec/models/user_status_spec.rb' - 'spec/models/users/banned_user_spec.rb' - 'spec/models/users/callout_spec.rb' @@ -6369,7 +5142,6 @@ RSpec/MissingFeatureCategory: - 'spec/policies/deploy_key_policy_spec.rb' - 'spec/policies/deploy_keys_project_policy_spec.rb' - 'spec/policies/deploy_token_policy_spec.rb' - - 'spec/policies/design_management/design_policy_spec.rb' - 'spec/policies/environment_policy_spec.rb' - 'spec/policies/group_deploy_key_policy_spec.rb' - 'spec/policies/group_deploy_keys_group_policy_spec.rb' @@ -6383,13 +5155,11 @@ RSpec/MissingFeatureCategory: - 'spec/policies/metrics/dashboard/annotation_policy_spec.rb' - 'spec/policies/namespace/root_storage_statistics_policy_spec.rb' - 'spec/policies/namespaces/project_namespace_policy_spec.rb' - - 'spec/policies/namespaces/user_namespace_policy_spec.rb' - 'spec/policies/packages/package_policy_spec.rb' - 'spec/policies/packages/policies/group_policy_spec.rb' - 'spec/policies/packages/policies/project_policy_spec.rb' - 'spec/policies/personal_access_token_policy_spec.rb' - 'spec/policies/personal_snippet_policy_spec.rb' - - 'spec/policies/project_hook_policy_spec.rb' - 'spec/policies/project_member_policy_spec.rb' - 'spec/policies/project_snippet_policy_spec.rb' - 'spec/policies/project_statistics_policy_spec.rb' @@ -6414,14 +5184,12 @@ RSpec/MissingFeatureCategory: - 'spec/presenters/ci/build_runner_presenter_spec.rb' - 'spec/presenters/ci/group_variable_presenter_spec.rb' - 'spec/presenters/ci/pipeline_artifacts/code_coverage_presenter_spec.rb' - - 'spec/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter_spec.rb' - 'spec/presenters/ci/pipeline_presenter_spec.rb' - 'spec/presenters/ci/stage_presenter_spec.rb' - 'spec/presenters/ci/trigger_presenter_spec.rb' - 'spec/presenters/ci/variable_presenter_spec.rb' - 'spec/presenters/clusterable_presenter_spec.rb' - 'spec/presenters/clusters/cluster_presenter_spec.rb' - - 'spec/presenters/commit_presenter_spec.rb' - 'spec/presenters/commit_status_presenter_spec.rb' - 'spec/presenters/deploy_key_presenter_spec.rb' - 'spec/presenters/deployments/deployment_presenter_spec.rb' @@ -6440,7 +5208,6 @@ RSpec/MissingFeatureCategory: - 'spec/presenters/packages/conan/package_presenter_spec.rb' - 'spec/presenters/packages/detail/package_presenter_spec.rb' - 'spec/presenters/packages/helm/index_presenter_spec.rb' - - 'spec/presenters/packages/npm/package_presenter_spec.rb' - 'spec/presenters/packages/nuget/package_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_versions_presenter_spec.rb' - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' @@ -6448,7 +5215,6 @@ RSpec/MissingFeatureCategory: - 'spec/presenters/packages/pypi/simple_index_presenter_spec.rb' - 'spec/presenters/packages/pypi/simple_package_versions_presenter_spec.rb' - 'spec/presenters/pages_domain_presenter_spec.rb' - - 'spec/presenters/project_clusterable_presenter_spec.rb' - 'spec/presenters/project_hook_presenter_spec.rb' - 'spec/presenters/project_member_presenter_spec.rb' - 'spec/presenters/project_presenter_spec.rb' @@ -6467,7 +5233,6 @@ RSpec/MissingFeatureCategory: - 'spec/presenters/user_presenter_spec.rb' - 'spec/presenters/web_hook_log_presenter_spec.rb' - 'spec/rack_servers/puma_spec.rb' - - 'spec/requests/api/admin/ci/variables_spec.rb' - 'spec/requests/api/graphql/ci/runners_spec.rb' - 'spec/requests/api/graphql/mutations/ci/pipeline_schedule_create_spec.rb' - 'spec/requests/api/graphql/mutations/merge_requests/accept_spec.rb' @@ -6479,7 +5244,6 @@ RSpec/MissingFeatureCategory: - 'spec/routing/environments_spec.rb' - 'spec/routing/git_http_routing_spec.rb' - 'spec/routing/group_routing_spec.rb' - - 'spec/routing/import_routing_spec.rb' - 'spec/routing/notifications_routing_spec.rb' - 'spec/routing/openid_connect_spec.rb' - 'spec/routing/project_routing_spec.rb' @@ -6521,7 +5285,6 @@ RSpec/MissingFeatureCategory: - 'spec/rubocop/cop/gitlab/change_timezone_spec.rb' - 'spec/rubocop/cop/gitlab/const_get_inherit_false_spec.rb' - 'spec/rubocop/cop/gitlab/delegate_predicate_methods_spec.rb' - - 'spec/rubocop/cop/gitlab/deprecate_track_redis_hll_event_spec.rb' - 'spec/rubocop/cop/gitlab/event_store_subscriber_spec.rb' - 'spec/rubocop/cop/gitlab/except_spec.rb' - 'spec/rubocop/cop/gitlab/feature_available_usage_spec.rb' @@ -6611,17 +5374,14 @@ RSpec/MissingFeatureCategory: - 'spec/rubocop/cop/rspec/factory_bot/inline_association_spec.rb' - 'spec/rubocop/cop/rspec/factory_bot/strategy_in_callback_spec.rb' - 'spec/rubocop/cop/rspec/have_gitlab_http_status_spec.rb' - - 'spec/rubocop/cop/rspec/htt_party_basic_auth_spec.rb' - 'spec/rubocop/cop/rspec/modify_sidekiq_middleware_spec.rb' - 'spec/rubocop/cop/rspec/top_level_describe_path_spec.rb' - 'spec/rubocop/cop/rspec/web_mock_enable_spec.rb' - - 'spec/rubocop/cop/ruby_interpolation_in_translation_spec.rb' - 'spec/rubocop/cop/safe_params_spec.rb' - 'spec/rubocop/cop/scalability/bulk_perform_with_context_spec.rb' - 'spec/rubocop/cop/scalability/cron_worker_context_spec.rb' - 'spec/rubocop/cop/scalability/idempotent_worker_spec.rb' - 'spec/rubocop/cop/sidekiq_api_usage_spec.rb' - - 'spec/rubocop/cop/sidekiq_load_balancing/worker_data_consistency_spec.rb' - 'spec/rubocop/cop/sidekiq_options_queue_spec.rb' - 'spec/rubocop/cop/sidekiq_redis_call_spec.rb' - 'spec/rubocop/cop/static_translation_definition_spec.rb' @@ -6640,7 +5400,6 @@ RSpec/MissingFeatureCategory: - 'spec/scripts/changed-feature-flags_spec.rb' - 'spec/scripts/failed_tests_spec.rb' - 'spec/scripts/lib/glfm/parse_examples_spec.rb' - - 'spec/scripts/lib/glfm/shared_spec.rb' - 'spec/scripts/lib/glfm/verify_all_generated_files_are_up_to_date_spec.rb' - 'spec/scripts/setup/find_jh_branch_spec.rb' - 'spec/serializers/access_token_entity_base_spec.rb' @@ -6662,7 +5421,6 @@ RSpec/MissingFeatureCategory: - 'spec/serializers/build_artifact_entity_spec.rb' - 'spec/serializers/build_details_entity_spec.rb' - 'spec/serializers/build_trace_entity_spec.rb' - - 'spec/serializers/ci/codequality_mr_diff_entity_spec.rb' - 'spec/serializers/ci/codequality_mr_diff_report_serializer_spec.rb' - 'spec/serializers/ci/dag_job_entity_spec.rb' - 'spec/serializers/ci/dag_job_group_entity_spec.rb' @@ -6683,7 +5441,6 @@ RSpec/MissingFeatureCategory: - 'spec/serializers/ci/trigger_entity_spec.rb' - 'spec/serializers/ci/trigger_serializer_spec.rb' - 'spec/serializers/ci/variable_entity_spec.rb' - - 'spec/serializers/cluster_application_entity_spec.rb' - 'spec/serializers/cluster_entity_spec.rb' - 'spec/serializers/cluster_serializer_spec.rb' - 'spec/serializers/clusters/kubernetes_error_entity_spec.rb' @@ -6745,7 +5502,6 @@ RSpec/MissingFeatureCategory: - 'spec/serializers/impersonation_access_token_serializer_spec.rb' - 'spec/serializers/import/bitbucket_provider_repo_entity_spec.rb' - 'spec/serializers/import/bitbucket_server_provider_repo_entity_spec.rb' - - 'spec/serializers/import/bulk_import_entity_spec.rb' - 'spec/serializers/import/fogbugz_provider_repo_entity_spec.rb' - 'spec/serializers/import/github_org_entity_spec.rb' - 'spec/serializers/import/github_org_serializer_spec.rb' @@ -6782,7 +5538,6 @@ RSpec/MissingFeatureCategory: - 'spec/serializers/merge_request_diff_entity_spec.rb' - 'spec/serializers/merge_request_for_pipeline_entity_spec.rb' - 'spec/serializers/merge_request_metrics_helper_spec.rb' - - 'spec/serializers/merge_request_poll_cached_widget_entity_spec.rb' - 'spec/serializers/merge_request_poll_widget_entity_spec.rb' - 'spec/serializers/merge_request_serializer_spec.rb' - 'spec/serializers/merge_request_sidebar_basic_entity_spec.rb' @@ -6799,7 +5554,6 @@ RSpec/MissingFeatureCategory: - 'spec/serializers/paginated_diff_entity_spec.rb' - 'spec/serializers/personal_access_token_entity_spec.rb' - 'spec/serializers/personal_access_token_serializer_spec.rb' - - 'spec/serializers/pipeline_details_entity_spec.rb' - 'spec/serializers/pipeline_serializer_spec.rb' - 'spec/serializers/project_access_token_entity_spec.rb' - 'spec/serializers/project_access_token_serializer_spec.rb' @@ -6831,760 +5585,10 @@ RSpec/MissingFeatureCategory: - 'spec/serializers/user_serializer_spec.rb' - 'spec/serializers/web_ide_terminal_entity_spec.rb' - 'spec/serializers/web_ide_terminal_serializer_spec.rb' - - 'spec/services/access_token_validation_service_spec.rb' - - 'spec/services/admin/set_feature_flag_service_spec.rb' - - 'spec/services/alert_management/alerts/todo/create_service_spec.rb' - - 'spec/services/alert_management/alerts/update_service_spec.rb' - - 'spec/services/alert_management/create_alert_issue_service_spec.rb' - - 'spec/services/alert_management/http_integrations/create_service_spec.rb' - - 'spec/services/alert_management/http_integrations/destroy_service_spec.rb' - - 'spec/services/alert_management/http_integrations/update_service_spec.rb' - - 'spec/services/alert_management/metric_images/upload_service_spec.rb' - - 'spec/services/alert_management/process_prometheus_alert_service_spec.rb' - - 'spec/services/analytics/cycle_analytics/stages/list_service_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - 'spec/services/applications/create_service_spec.rb' - - 'spec/services/audit_event_service_spec.rb' - - 'spec/services/audit_events/build_service_spec.rb' - - 'spec/services/auth/container_registry_authentication_service_spec.rb' - - 'spec/services/auth/dependency_proxy_authentication_service_spec.rb' - - 'spec/services/authorized_project_update/find_records_due_for_refresh_service_spec.rb' - - 'spec/services/authorized_project_update/periodic_recalculate_service_spec.rb' - - 'spec/services/authorized_project_update/project_access_changed_service_spec.rb' - - 'spec/services/authorized_project_update/project_recalculate_per_user_service_spec.rb' - - 'spec/services/authorized_project_update/project_recalculate_service_spec.rb' - - 'spec/services/auto_merge/base_service_spec.rb' - - 'spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' - - 'spec/services/auto_merge_service_spec.rb' - - 'spec/services/award_emojis/add_service_spec.rb' - - 'spec/services/award_emojis/base_service_spec.rb' - - 'spec/services/award_emojis/collect_user_emoji_service_spec.rb' - - 'spec/services/award_emojis/copy_service_spec.rb' - - 'spec/services/award_emojis/destroy_service_spec.rb' - - 'spec/services/award_emojis/toggle_service_spec.rb' - - 'spec/services/base_container_service_spec.rb' - - 'spec/services/base_count_service_spec.rb' - - 'spec/services/boards/create_service_spec.rb' - - 'spec/services/boards/destroy_service_spec.rb' - - 'spec/services/boards/issues/create_service_spec.rb' - - 'spec/services/boards/issues/list_service_spec.rb' - - 'spec/services/boards/issues/move_service_spec.rb' - - 'spec/services/boards/lists/create_service_spec.rb' - - 'spec/services/boards/lists/destroy_service_spec.rb' - - 'spec/services/boards/lists/list_service_spec.rb' - - 'spec/services/boards/lists/move_service_spec.rb' - - 'spec/services/boards/lists/update_service_spec.rb' - - 'spec/services/boards/visits/create_service_spec.rb' - - 'spec/services/branches/create_service_spec.rb' - - 'spec/services/branches/delete_merged_service_spec.rb' - - 'spec/services/branches/delete_service_spec.rb' - - 'spec/services/branches/diverging_commit_counts_service_spec.rb' - - 'spec/services/branches/validate_new_service_spec.rb' - - 'spec/services/bulk_create_integration_service_spec.rb' - - 'spec/services/bulk_imports/archive_extraction_service_spec.rb' - - 'spec/services/bulk_imports/export_service_spec.rb' - - 'spec/services/bulk_imports/file_decompression_service_spec.rb' - - 'spec/services/bulk_imports/file_download_service_spec.rb' - - 'spec/services/bulk_imports/file_export_service_spec.rb' - - 'spec/services/bulk_imports/lfs_objects_export_service_spec.rb' - - 'spec/services/bulk_imports/relation_export_service_spec.rb' - - 'spec/services/bulk_imports/repository_bundle_export_service_spec.rb' - - 'spec/services/bulk_imports/tree_export_service_spec.rb' - - 'spec/services/bulk_imports/uploads_export_service_spec.rb' - - 'spec/services/bulk_push_event_payload_service_spec.rb' - - 'spec/services/bulk_update_integration_service_spec.rb' - - 'spec/services/captcha/captcha_verification_service_spec.rb' - - 'spec/services/chat_names/find_user_service_spec.rb' - - 'spec/services/ci/abort_pipelines_service_spec.rb' - - 'spec/services/ci/append_build_trace_service_spec.rb' - - 'spec/services/ci/build_cancel_service_spec.rb' - - 'spec/services/ci/build_erase_service_spec.rb' - - 'spec/services/ci/build_report_result_service_spec.rb' - - 'spec/services/ci/build_unschedule_service_spec.rb' - - 'spec/services/ci/change_variable_service_spec.rb' - - 'spec/services/ci/change_variables_service_spec.rb' - - 'spec/services/ci/compare_accessibility_reports_service_spec.rb' - - 'spec/services/ci/compare_codequality_reports_service_spec.rb' - - 'spec/services/ci/compare_reports_base_service_spec.rb' - - 'spec/services/ci/compare_test_reports_service_spec.rb' - - 'spec/services/ci/copy_cross_database_associations_service_spec.rb' - - 'spec/services/ci/create_pipeline_service/artifacts_spec.rb' - - 'spec/services/ci/create_pipeline_service/cache_spec.rb' - - 'spec/services/ci/create_pipeline_service/creation_errors_and_warnings_spec.rb' - - 'spec/services/ci/create_pipeline_service/cross_project_pipeline_spec.rb' - - 'spec/services/ci/create_pipeline_service/custom_config_content_spec.rb' - - 'spec/services/ci/create_pipeline_service/custom_yaml_tags_spec.rb' - - 'spec/services/ci/create_pipeline_service/dry_run_spec.rb' - - 'spec/services/ci/create_pipeline_service/environment_spec.rb' - - 'spec/services/ci/create_pipeline_service/evaluate_runner_tags_spec.rb' - - 'spec/services/ci/create_pipeline_service/limit_active_jobs_spec.rb' - - 'spec/services/ci/create_pipeline_service/merge_requests_spec.rb' - - 'spec/services/ci/create_pipeline_service/needs_spec.rb' - - 'spec/services/ci/create_pipeline_service/parallel_spec.rb' - - 'spec/services/ci/create_pipeline_service/parameter_content_spec.rb' - - 'spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb' - - 'spec/services/ci/create_pipeline_service/pre_post_stages_spec.rb' - - 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb' - - 'spec/services/ci/create_pipeline_service/scripts_spec.rb' - - 'spec/services/ci/create_pipeline_service/tags_spec.rb' - - 'spec/services/ci/create_pipeline_service/variables_spec.rb' - - 'spec/services/ci/create_web_ide_terminal_service_spec.rb' - - 'spec/services/ci/daily_build_group_report_result_service_spec.rb' - - 'spec/services/ci/delete_objects_service_spec.rb' - - 'spec/services/ci/delete_unit_tests_service_spec.rb' - - 'spec/services/ci/deployments/destroy_service_spec.rb' - - 'spec/services/ci/destroy_pipeline_service_spec.rb' - - 'spec/services/ci/destroy_secure_file_service_spec.rb' - - 'spec/services/ci/disable_user_pipeline_schedules_service_spec.rb' - - 'spec/services/ci/drop_pipeline_service_spec.rb' - - 'spec/services/ci/ensure_stage_service_spec.rb' - - 'spec/services/ci/expire_pipeline_cache_service_spec.rb' - - 'spec/services/ci/external_pull_requests/create_pipeline_service_spec.rb' - - 'spec/services/ci/find_exposed_artifacts_service_spec.rb' - - 'spec/services/ci/generate_codequality_mr_diff_report_service_spec.rb' - - 'spec/services/ci/generate_coverage_reports_service_spec.rb' - - 'spec/services/ci/generate_kubeconfig_service_spec.rb' - - 'spec/services/ci/generate_terraform_reports_service_spec.rb' - - 'spec/services/ci/job_artifacts/create_service_spec.rb' - - 'spec/services/ci/job_artifacts/delete_project_artifacts_service_spec.rb' - - 'spec/services/ci/job_artifacts/delete_service_spec.rb' - - 'spec/services/ci/job_artifacts/destroy_associations_service_spec.rb' - - 'spec/services/ci/job_artifacts/destroy_batch_service_spec.rb' - - 'spec/services/ci/job_artifacts/expire_project_build_artifacts_service_spec.rb' - - 'spec/services/ci/job_artifacts/track_artifact_report_service_spec.rb' - - 'spec/services/ci/job_artifacts/update_unknown_locked_status_service_spec.rb' - - 'spec/services/ci/pipeline_artifacts/coverage_report_service_spec.rb' - - 'spec/services/ci/pipeline_artifacts/create_code_quality_mr_diff_report_service_spec.rb' - - 'spec/services/ci/pipeline_artifacts/destroy_all_expired_service_spec.rb' - - 'spec/services/ci/pipeline_bridge_status_service_spec.rb' - - 'spec/services/ci/pipeline_creation/start_pipeline_service_spec.rb' - - 'spec/services/ci/pipeline_processing/atomic_processing_service/status_collection_spec.rb' - - 'spec/services/ci/pipeline_schedules/take_ownership_service_spec.rb' - - 'spec/services/ci/pipeline_trigger_service_spec.rb' - - 'spec/services/ci/pipelines/add_job_service_spec.rb' - - 'spec/services/ci/pipelines/hook_service_spec.rb' - - 'spec/services/ci/play_bridge_service_spec.rb' - - 'spec/services/ci/play_build_service_spec.rb' - - 'spec/services/ci/play_manual_stage_service_spec.rb' - - 'spec/services/ci/prepare_build_service_spec.rb' - - 'spec/services/ci/process_build_service_spec.rb' - - 'spec/services/ci/process_pipeline_service_spec.rb' - - 'spec/services/ci/process_sync_events_service_spec.rb' - - 'spec/services/ci/prometheus_metrics/observe_histograms_service_spec.rb' - - 'spec/services/ci/queue/pending_builds_strategy_spec.rb' - - 'spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb' - - 'spec/services/ci/retry_pipeline_service_spec.rb' - - 'spec/services/ci/run_scheduled_build_service_spec.rb' - - 'spec/services/ci/stuck_builds/drop_pending_service_spec.rb' - - 'spec/services/ci/stuck_builds/drop_running_service_spec.rb' - - 'spec/services/ci/stuck_builds/drop_scheduled_service_spec.rb' - - 'spec/services/ci/test_failure_history_service_spec.rb' - - 'spec/services/ci/track_failed_build_service_spec.rb' - - 'spec/services/ci/unlock_artifacts_service_spec.rb' - - 'spec/services/ci/update_build_queue_service_spec.rb' - - 'spec/services/ci/update_instance_variables_service_spec.rb' - - 'spec/services/ci/update_pending_build_service_spec.rb' - - 'spec/services/clusters/agent_tokens/create_service_spec.rb' - - 'spec/services/clusters/agent_tokens/track_usage_service_spec.rb' - - 'spec/services/clusters/agents/create_activity_event_service_spec.rb' - - 'spec/services/clusters/agents/create_service_spec.rb' - - 'spec/services/clusters/agents/delete_expired_events_service_spec.rb' - - 'spec/services/clusters/agents/delete_service_spec.rb' - - 'spec/services/clusters/build_kubernetes_namespace_service_spec.rb' - - 'spec/services/clusters/build_service_spec.rb' - - 'spec/services/clusters/cleanup/project_namespace_service_spec.rb' - - 'spec/services/clusters/cleanup/service_account_service_spec.rb' - - 'spec/services/clusters/create_service_spec.rb' - - 'spec/services/clusters/destroy_service_spec.rb' - - 'spec/services/clusters/integrations/create_service_spec.rb' - - 'spec/services/clusters/integrations/prometheus_health_check_service_spec.rb' - - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' - - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - - 'spec/services/clusters/kubernetes/fetch_kubernetes_token_service_spec.rb' - - 'spec/services/clusters/kubernetes_spec.rb' - - 'spec/services/clusters/management/validate_management_project_permissions_service_spec.rb' - - 'spec/services/clusters/update_service_spec.rb' - - 'spec/services/cohorts_service_spec.rb' - - 'spec/services/commits/cherry_pick_service_spec.rb' - - 'spec/services/commits/commit_patch_service_spec.rb' - - 'spec/services/commits/tag_service_spec.rb' - - 'spec/services/compare_service_spec.rb' - - 'spec/services/concerns/audit_event_save_type_spec.rb' - - 'spec/services/concerns/exclusive_lease_guard_spec.rb' - - 'spec/services/concerns/merge_requests/assigns_merge_params_spec.rb' - - 'spec/services/concerns/rate_limited_service_spec.rb' - - 'spec/services/container_expiration_policies/cleanup_service_spec.rb' - - 'spec/services/container_expiration_policies/update_service_spec.rb' - - 'spec/services/customer_relations/contacts/create_service_spec.rb' - - 'spec/services/customer_relations/contacts/update_service_spec.rb' - - 'spec/services/customer_relations/organizations/create_service_spec.rb' - - 'spec/services/customer_relations/organizations/update_service_spec.rb' - - 'spec/services/database/consistency_fix_service_spec.rb' - - 'spec/services/dependency_proxy/auth_token_service_spec.rb' - - 'spec/services/dependency_proxy/find_cached_manifest_service_spec.rb' - - 'spec/services/dependency_proxy/group_settings/update_service_spec.rb' - - 'spec/services/dependency_proxy/head_manifest_service_spec.rb' - - 'spec/services/dependency_proxy/image_ttl_group_policies/update_service_spec.rb' - - 'spec/services/dependency_proxy/request_token_service_spec.rb' - - 'spec/services/deploy_keys/create_service_spec.rb' - - 'spec/services/deployments/archive_in_project_service_spec.rb' - - 'spec/services/deployments/create_for_build_service_spec.rb' - - 'spec/services/deployments/create_service_spec.rb' - - 'spec/services/deployments/link_merge_requests_service_spec.rb' - - 'spec/services/deployments/older_deployments_drop_service_spec.rb' - - 'spec/services/deployments/update_environment_service_spec.rb' - - 'spec/services/deployments/update_service_spec.rb' - - 'spec/services/design_management/copy_design_collection/copy_service_spec.rb' - - 'spec/services/design_management/copy_design_collection/queue_service_spec.rb' - - 'spec/services/design_management/delete_designs_service_spec.rb' - - 'spec/services/design_management/design_user_notes_count_service_spec.rb' - - 'spec/services/design_management/generate_image_versions_service_spec.rb' - - 'spec/services/design_management/move_designs_service_spec.rb' - - 'spec/services/discussions/capture_diff_note_position_service_spec.rb' - - 'spec/services/discussions/capture_diff_note_positions_service_spec.rb' - - 'spec/services/discussions/update_diff_position_service_spec.rb' - - 'spec/services/draft_notes/create_service_spec.rb' - - 'spec/services/draft_notes/destroy_service_spec.rb' - - 'spec/services/draft_notes/publish_service_spec.rb' - - 'spec/services/emails/confirm_service_spec.rb' - - 'spec/services/emails/create_service_spec.rb' - - 'spec/services/emails/destroy_service_spec.rb' - - 'spec/services/environments/auto_stop_service_spec.rb' - - 'spec/services/environments/canary_ingress/update_service_spec.rb' - - 'spec/services/environments/create_for_build_service_spec.rb' - - 'spec/services/environments/reset_auto_stop_service_spec.rb' - - 'spec/services/environments/schedule_to_delete_review_apps_service_spec.rb' - - 'spec/services/environments/stop_service_spec.rb' - - 'spec/services/error_tracking/base_service_spec.rb' - - 'spec/services/error_tracking/collect_error_service_spec.rb' - - 'spec/services/error_tracking/issue_details_service_spec.rb' - - 'spec/services/error_tracking/issue_latest_event_service_spec.rb' - - 'spec/services/error_tracking/issue_update_service_spec.rb' - - 'spec/services/error_tracking/list_issues_service_spec.rb' - - 'spec/services/event_create_service_spec.rb' - - 'spec/services/events/destroy_service_spec.rb' - - 'spec/services/events/render_service_spec.rb' - - 'spec/services/feature_flags/create_service_spec.rb' - - 'spec/services/feature_flags/destroy_service_spec.rb' - - 'spec/services/feature_flags/hook_service_spec.rb' - - 'spec/services/feature_flags/update_service_spec.rb' - - 'spec/services/files/create_service_spec.rb' - - 'spec/services/files/delete_service_spec.rb' - - 'spec/services/files/multi_service_spec.rb' - - 'spec/services/files/update_service_spec.rb' - - 'spec/services/git/base_hooks_service_spec.rb' - - 'spec/services/git/branch_hooks_service_spec.rb' - - 'spec/services/git/branch_push_service_spec.rb' - - 'spec/services/git/process_ref_changes_service_spec.rb' - - 'spec/services/git/tag_hooks_service_spec.rb' - - 'spec/services/git/tag_push_service_spec.rb' - - 'spec/services/git/wiki_push_service/change_spec.rb' - - 'spec/services/google_cloud/create_cloudsql_instance_service_spec.rb' - - 'spec/services/google_cloud/create_service_accounts_service_spec.rb' - - 'spec/services/google_cloud/enable_cloud_run_service_spec.rb' - - 'spec/services/google_cloud/enable_cloudsql_service_spec.rb' - - 'spec/services/google_cloud/gcp_region_add_or_replace_service_spec.rb' - - 'spec/services/google_cloud/generate_pipeline_service_spec.rb' - - 'spec/services/google_cloud/get_cloudsql_instances_service_spec.rb' - - 'spec/services/google_cloud/service_accounts_service_spec.rb' - - 'spec/services/google_cloud/setup_cloudsql_instance_service_spec.rb' - - 'spec/services/gpg_keys/create_service_spec.rb' - 'spec/services/gpg_keys/destroy_service_spec.rb' - - 'spec/services/grafana/proxy_service_spec.rb' - - 'spec/services/gravatar_service_spec.rb' - - 'spec/services/groups/auto_devops_service_spec.rb' - - 'spec/services/groups/autocomplete_service_spec.rb' - - 'spec/services/groups/deploy_tokens/create_service_spec.rb' - - 'spec/services/groups/deploy_tokens/destroy_service_spec.rb' - - 'spec/services/groups/deploy_tokens/revoke_service_spec.rb' - - 'spec/services/groups/group_links/create_service_spec.rb' - - 'spec/services/groups/group_links/destroy_service_spec.rb' - - 'spec/services/groups/group_links/update_service_spec.rb' - - 'spec/services/groups/import_export/export_service_spec.rb' - - 'spec/services/groups/import_export/import_service_spec.rb' - - 'spec/services/groups/merge_requests_count_service_spec.rb' - - 'spec/services/groups/nested_create_service_spec.rb' - - 'spec/services/groups/open_issues_count_service_spec.rb' - - 'spec/services/groups/participants_service_spec.rb' - - 'spec/services/groups/update_service_spec.rb' - - 'spec/services/groups/update_shared_runners_service_spec.rb' - - 'spec/services/groups/update_statistics_service_spec.rb' - - 'spec/services/ide/base_config_service_spec.rb' - - 'spec/services/ide/schemas_config_service_spec.rb' - - 'spec/services/ide/terminal_config_service_spec.rb' - - 'spec/services/import/bitbucket_server_service_spec.rb' - - 'spec/services/import/fogbugz_service_spec.rb' - - 'spec/services/import/github/cancel_project_import_service_spec.rb' - - 'spec/services/import/github/notes/create_service_spec.rb' - - 'spec/services/import/github_service_spec.rb' - - 'spec/services/import/gitlab_projects/create_project_service_spec.rb' - - 'spec/services/import/gitlab_projects/file_acquisition_strategies/file_upload_spec.rb' - - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3_spec.rb' - - 'spec/services/import/prepare_service_spec.rb' - - 'spec/services/import/validate_remote_git_endpoint_service_spec.rb' - - 'spec/services/import_export_clean_up_service_spec.rb' - - 'spec/services/incident_management/incidents/create_service_spec.rb' - - 'spec/services/incident_management/issuable_escalation_statuses/after_update_service_spec.rb' - - 'spec/services/incident_management/issuable_escalation_statuses/build_service_spec.rb' - - 'spec/services/incident_management/issuable_escalation_statuses/create_service_spec.rb' - - 'spec/services/incident_management/issuable_escalation_statuses/prepare_update_service_spec.rb' - - 'spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb' - - 'spec/services/incident_management/pager_duty/process_webhook_service_spec.rb' - - 'spec/services/incident_management/timeline_event_tags/create_service_spec.rb' - - 'spec/services/incident_management/timeline_events/create_service_spec.rb' - - 'spec/services/incident_management/timeline_events/destroy_service_spec.rb' - - 'spec/services/integrations/propagate_service_spec.rb' - - 'spec/services/integrations/test/project_service_spec.rb' - - 'spec/services/issuable/bulk_update_service_spec.rb' - - 'spec/services/issuable/common_system_notes_service_spec.rb' - - 'spec/services/issuable/destroy_label_links_service_spec.rb' - - 'spec/services/issuable/destroy_service_spec.rb' - - 'spec/services/issuable/discussions_list_service_spec.rb' - - 'spec/services/issuable/process_assignees_spec.rb' - - 'spec/services/issue_links/create_service_spec.rb' - - 'spec/services/issue_links/destroy_service_spec.rb' - - 'spec/services/issue_links/list_service_spec.rb' - - 'spec/services/issues/after_create_service_spec.rb' - - 'spec/services/issues/build_service_spec.rb' - - 'spec/services/issues/clone_service_spec.rb' - - 'spec/services/issues/close_service_spec.rb' - - 'spec/services/issues/create_service_spec.rb' - - 'spec/services/issues/duplicate_service_spec.rb' - - 'spec/services/issues/prepare_import_csv_service_spec.rb' - - 'spec/services/issues/referenced_merge_requests_service_spec.rb' - - 'spec/services/issues/related_branches_service_spec.rb' - - 'spec/services/issues/relative_position_rebalancing_service_spec.rb' - - 'spec/services/issues/reopen_service_spec.rb' - - 'spec/services/issues/reorder_service_spec.rb' - - 'spec/services/issues/resolve_discussions_spec.rb' - - 'spec/services/issues/set_crm_contacts_service_spec.rb' - - 'spec/services/issues/update_service_spec.rb' - - 'spec/services/issues/zoom_link_service_spec.rb' - - 'spec/services/jira/requests/projects/list_service_spec.rb' - - 'spec/services/jira_connect/sync_service_spec.rb' - - 'spec/services/jira_connect_installations/destroy_service_spec.rb' - - 'spec/services/jira_connect_subscriptions/create_service_spec.rb' - - 'spec/services/jira_import/cloud_users_mapper_service_spec.rb' - - 'spec/services/jira_import/server_users_mapper_service_spec.rb' - - 'spec/services/jira_import/start_import_service_spec.rb' - - 'spec/services/jira_import/users_importer_spec.rb' - - 'spec/services/keys/create_service_spec.rb' - - 'spec/services/keys/destroy_service_spec.rb' - - 'spec/services/keys/expiry_notification_service_spec.rb' - - 'spec/services/keys/last_used_service_spec.rb' - - 'spec/services/labels/available_labels_service_spec.rb' - - 'spec/services/labels/create_service_spec.rb' - - 'spec/services/labels/find_or_create_service_spec.rb' - - 'spec/services/labels/promote_service_spec.rb' - - 'spec/services/labels/transfer_service_spec.rb' - - 'spec/services/labels/update_service_spec.rb' - - 'spec/services/lfs/lock_file_service_spec.rb' - - 'spec/services/lfs/locks_finder_service_spec.rb' - - 'spec/services/lfs/push_service_spec.rb' - - 'spec/services/lfs/unlock_file_service_spec.rb' - - 'spec/services/loose_foreign_keys/batch_cleaner_service_spec.rb' - - 'spec/services/loose_foreign_keys/cleaner_service_spec.rb' - - 'spec/services/loose_foreign_keys/process_deleted_records_service_spec.rb' - - 'spec/services/markdown_content_rewriter_service_spec.rb' - - 'spec/services/markup/rendering_service_spec.rb' - - 'spec/services/members/approve_access_request_service_spec.rb' - - 'spec/services/members/create_service_spec.rb' - - 'spec/services/members/creator_service_spec.rb' - - 'spec/services/members/groups/creator_service_spec.rb' - - 'spec/services/members/import_project_team_service_spec.rb' - - 'spec/services/members/invitation_reminder_email_service_spec.rb' - - 'spec/services/members/invite_member_builder_spec.rb' - - 'spec/services/members/invite_service_spec.rb' - - 'spec/services/members/projects/creator_service_spec.rb' - - 'spec/services/members/request_access_service_spec.rb' - - 'spec/services/members/standard_member_builder_spec.rb' - - 'spec/services/members/unassign_issuables_service_spec.rb' - - 'spec/services/members/update_service_spec.rb' - - 'spec/services/merge_requests/add_context_service_spec.rb' - - 'spec/services/merge_requests/add_spent_time_service_spec.rb' - - 'spec/services/merge_requests/add_todo_when_build_fails_service_spec.rb' - - 'spec/services/merge_requests/approval_service_spec.rb' - - 'spec/services/merge_requests/assign_issues_service_spec.rb' - - 'spec/services/merge_requests/cleanup_refs_service_spec.rb' - - 'spec/services/merge_requests/conflicts/list_service_spec.rb' - - 'spec/services/merge_requests/conflicts/resolve_service_spec.rb' - - 'spec/services/merge_requests/create_approval_event_service_spec.rb' - - 'spec/services/merge_requests/create_pipeline_service_spec.rb' - - 'spec/services/merge_requests/delete_non_latest_diffs_service_spec.rb' - - 'spec/services/merge_requests/execute_approval_hooks_service_spec.rb' - - 'spec/services/merge_requests/ff_merge_service_spec.rb' - - 'spec/services/merge_requests/get_urls_service_spec.rb' - - 'spec/services/merge_requests/handle_assignees_change_service_spec.rb' - - 'spec/services/merge_requests/mark_reviewer_reviewed_service_spec.rb' - - 'spec/services/merge_requests/merge_orchestration_service_spec.rb' - - 'spec/services/merge_requests/merge_service_spec.rb' - - 'spec/services/merge_requests/merge_to_ref_service_spec.rb' - - 'spec/services/merge_requests/mergeability/check_base_service_spec.rb' - - 'spec/services/merge_requests/mergeability/check_broken_status_service_spec.rb' - - 'spec/services/merge_requests/mergeability/check_ci_status_service_spec.rb' - - 'spec/services/merge_requests/mergeability/check_discussions_status_service_spec.rb' - - 'spec/services/merge_requests/mergeability/check_draft_status_service_spec.rb' - - 'spec/services/merge_requests/mergeability/check_open_status_service_spec.rb' - - 'spec/services/merge_requests/mergeability/detailed_merge_status_service_spec.rb' - - 'spec/services/merge_requests/mergeability/logger_spec.rb' - - 'spec/services/merge_requests/mergeability/run_checks_service_spec.rb' - - 'spec/services/merge_requests/mergeability_check_service_spec.rb' - - 'spec/services/merge_requests/migrate_external_diffs_service_spec.rb' - - 'spec/services/merge_requests/post_merge_service_spec.rb' - - 'spec/services/merge_requests/push_options_handler_service_spec.rb' - - 'spec/services/merge_requests/reload_diffs_service_spec.rb' - - 'spec/services/merge_requests/reload_merge_head_diff_service_spec.rb' - - 'spec/services/merge_requests/reopen_service_spec.rb' - - 'spec/services/merge_requests/request_review_service_spec.rb' - - 'spec/services/merge_requests/resolve_todos_service_spec.rb' - - 'spec/services/merge_requests/resolved_discussion_notification_service_spec.rb' - - 'spec/services/merge_requests/squash_service_spec.rb' - - 'spec/services/merge_requests/update_assignees_service_spec.rb' - - 'spec/services/merge_requests/update_reviewers_service_spec.rb' - - 'spec/services/metrics/dashboard/annotations/create_service_spec.rb' - - 'spec/services/metrics/dashboard/annotations/delete_service_spec.rb' - - 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb' - - 'spec/services/metrics/dashboard/cluster_dashboard_service_spec.rb' - - 'spec/services/metrics/dashboard/cluster_metrics_embed_service_spec.rb' - - 'spec/services/metrics/dashboard/custom_dashboard_service_spec.rb' - - 'spec/services/metrics/dashboard/custom_metric_embed_service_spec.rb' - - 'spec/services/metrics/dashboard/default_embed_service_spec.rb' - - 'spec/services/metrics/dashboard/dynamic_embed_service_spec.rb' - - 'spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb' - 'spec/services/metrics/dashboard/grafana_metric_embed_service_spec.rb' - - 'spec/services/metrics/dashboard/panel_preview_service_spec.rb' - - 'spec/services/metrics/dashboard/pod_dashboard_service_spec.rb' - - 'spec/services/metrics/dashboard/self_monitoring_dashboard_service_spec.rb' - - 'spec/services/metrics/dashboard/system_dashboard_service_spec.rb' - - 'spec/services/metrics/dashboard/transient_embed_service_spec.rb' - - 'spec/services/metrics/dashboard/update_dashboard_service_spec.rb' - - 'spec/services/metrics/sample_metrics_service_spec.rb' - - 'spec/services/metrics/users_starred_dashboards/create_service_spec.rb' - - 'spec/services/metrics/users_starred_dashboards/delete_service_spec.rb' - - 'spec/services/milestones/close_service_spec.rb' - - 'spec/services/milestones/closed_issues_count_service_spec.rb' - - 'spec/services/milestones/create_service_spec.rb' - - 'spec/services/milestones/destroy_service_spec.rb' - - 'spec/services/milestones/find_or_create_service_spec.rb' - - 'spec/services/milestones/issues_count_service_spec.rb' - - 'spec/services/milestones/merge_requests_count_service_spec.rb' - - 'spec/services/milestones/promote_service_spec.rb' - - 'spec/services/milestones/transfer_service_spec.rb' - - 'spec/services/milestones/update_service_spec.rb' - - 'spec/services/ml/experiment_tracking/candidate_repository_spec.rb' - - 'spec/services/ml/experiment_tracking/experiment_repository_spec.rb' - - 'spec/services/namespace_settings/update_service_spec.rb' - - 'spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - - 'spec/services/namespaces/package_settings/update_service_spec.rb' - - 'spec/services/namespaces/statistics_refresher_service_spec.rb' - - 'spec/services/note_summary_spec.rb' - - 'spec/services/notes/build_service_spec.rb' - - 'spec/services/notes/copy_service_spec.rb' - - 'spec/services/notes/destroy_service_spec.rb' - - 'spec/services/notes/post_process_service_spec.rb' - - 'spec/services/notes/quick_actions_service_spec.rb' - - 'spec/services/notes/render_service_spec.rb' - - 'spec/services/notes/resolve_service_spec.rb' - - 'spec/services/notes/update_service_spec.rb' - - 'spec/services/notification_recipients/build_service_spec.rb' - - 'spec/services/notification_recipients/builder/default_spec.rb' - - 'spec/services/notification_recipients/builder/new_note_spec.rb' - - 'spec/services/onboarding/progress_service_spec.rb' - - 'spec/services/packages/cleanup/execute_policy_service_spec.rb' - - 'spec/services/packages/cleanup/update_policy_service_spec.rb' - - 'spec/services/packages/composer/composer_json_service_spec.rb' - - 'spec/services/packages/composer/create_package_service_spec.rb' - - 'spec/services/packages/composer/version_parser_service_spec.rb' - - 'spec/services/packages/conan/create_package_file_service_spec.rb' - - 'spec/services/packages/conan/create_package_service_spec.rb' - - 'spec/services/packages/create_dependency_service_spec.rb' - - 'spec/services/packages/create_event_service_spec.rb' - - 'spec/services/packages/create_package_file_service_spec.rb' - - 'spec/services/packages/create_temporary_package_service_spec.rb' - - 'spec/services/packages/generic/create_package_file_service_spec.rb' - - 'spec/services/packages/generic/find_or_create_package_service_spec.rb' - - 'spec/services/packages/go/create_package_service_spec.rb' - - 'spec/services/packages/go/sync_packages_service_spec.rb' - - 'spec/services/packages/helm/extract_file_metadata_service_spec.rb' - - 'spec/services/packages/helm/process_file_service_spec.rb' - - 'spec/services/packages/mark_package_files_for_destruction_service_spec.rb' - - 'spec/services/packages/mark_package_for_destruction_service_spec.rb' - - 'spec/services/packages/mark_packages_for_destruction_service_spec.rb' - - 'spec/services/packages/maven/create_package_service_spec.rb' - - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' - - 'spec/services/packages/maven/metadata/append_package_file_service_spec.rb' - - 'spec/services/packages/maven/metadata/create_plugins_xml_service_spec.rb' - - 'spec/services/packages/maven/metadata/create_versions_xml_service_spec.rb' - - 'spec/services/packages/maven/metadata/sync_service_spec.rb' - - 'spec/services/packages/npm/create_package_service_spec.rb' - - 'spec/services/packages/npm/create_tag_service_spec.rb' - - 'spec/services/packages/nuget/create_dependency_service_spec.rb' - - 'spec/services/packages/nuget/metadata_extraction_service_spec.rb' - - 'spec/services/packages/nuget/search_service_spec.rb' - - 'spec/services/packages/nuget/sync_metadatum_service_spec.rb' - - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - - 'spec/services/packages/pypi/create_package_service_spec.rb' - - 'spec/services/packages/remove_tag_service_spec.rb' - - 'spec/services/packages/rpm/parse_package_service_spec.rb' - - 'spec/services/packages/rpm/repository_metadata/build_filelist_xml_service_spec.rb' - - 'spec/services/packages/rpm/repository_metadata/build_other_xml_service_spec.rb' - - 'spec/services/packages/rpm/repository_metadata/build_primary_xml_service_spec.rb' - - 'spec/services/packages/rpm/repository_metadata/build_repomd_xml_service_spec.rb' - - 'spec/services/packages/rpm/repository_metadata/update_xml_service_spec.rb' - - 'spec/services/packages/rubygems/create_dependencies_service_spec.rb' - - 'spec/services/packages/rubygems/create_gemspec_service_spec.rb' - - 'spec/services/packages/rubygems/dependency_resolver_service_spec.rb' - - 'spec/services/packages/rubygems/metadata_extraction_service_spec.rb' - - 'spec/services/packages/rubygems/process_gem_service_spec.rb' - - 'spec/services/packages/terraform_module/create_package_service_spec.rb' - - 'spec/services/packages/update_package_file_service_spec.rb' - - 'spec/services/packages/update_tags_service_spec.rb' - - 'spec/services/pages/delete_service_spec.rb' - - 'spec/services/pages/migrate_legacy_storage_to_deployment_service_spec.rb' - - 'spec/services/pages/zip_directory_service_spec.rb' - - 'spec/services/pages_domains/create_acme_order_service_spec.rb' - - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - - 'spec/services/personal_access_tokens/create_service_spec.rb' - - 'spec/services/personal_access_tokens/last_used_service_spec.rb' - - 'spec/services/personal_access_tokens/revoke_service_spec.rb' - - 'spec/services/post_receive_service_spec.rb' - - 'spec/services/preview_markdown_service_spec.rb' - - 'spec/services/product_analytics/build_activity_graph_service_spec.rb' - - 'spec/services/product_analytics/build_graph_service_spec.rb' - - 'spec/services/projects/after_rename_service_spec.rb' - - 'spec/services/projects/alerting/notify_service_spec.rb' - - 'spec/services/projects/all_issues_count_service_spec.rb' - - 'spec/services/projects/all_merge_requests_count_service_spec.rb' - - 'spec/services/projects/android_target_platform_detector_service_spec.rb' - - 'spec/services/projects/apple_target_platform_detector_service_spec.rb' - - 'spec/services/projects/auto_devops/disable_service_spec.rb' - - 'spec/services/projects/autocomplete_service_spec.rb' - - 'spec/services/projects/batch_open_issues_count_service_spec.rb' - - 'spec/services/projects/blame_service_spec.rb' - - 'spec/services/projects/branches_by_mode_service_spec.rb' - - 'spec/services/projects/cleanup_service_spec.rb' - - 'spec/services/projects/container_repository/cleanup_tags_service_spec.rb' - - 'spec/services/projects/container_repository/delete_tags_service_spec.rb' - - 'spec/services/projects/container_repository/destroy_service_spec.rb' - - 'spec/services/projects/container_repository/gitlab/cleanup_tags_service_spec.rb' - - 'spec/services/projects/container_repository/gitlab/delete_tags_service_spec.rb' - - 'spec/services/projects/container_repository/third_party/cleanup_tags_service_spec.rb' - - 'spec/services/projects/container_repository/third_party/delete_tags_service_spec.rb' - - 'spec/services/projects/count_service_spec.rb' - - 'spec/services/projects/create_from_template_service_spec.rb' - - 'spec/services/projects/deploy_tokens/create_service_spec.rb' - - 'spec/services/projects/deploy_tokens/destroy_service_spec.rb' - - 'spec/services/projects/detect_repository_languages_service_spec.rb' - - 'spec/services/projects/download_service_spec.rb' - - 'spec/services/projects/enable_deploy_key_service_spec.rb' - - 'spec/services/projects/fork_service_spec.rb' - - 'spec/services/projects/forks_count_service_spec.rb' - - 'spec/services/projects/git_deduplication_service_spec.rb' - - 'spec/services/projects/gitlab_projects_import_service_spec.rb' - - 'spec/services/projects/group_links/create_service_spec.rb' - - 'spec/services/projects/group_links/destroy_service_spec.rb' - - 'spec/services/projects/group_links/update_service_spec.rb' - - 'spec/services/projects/hashed_storage/base_attachment_service_spec.rb' - - 'spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb' - - 'spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - - 'spec/services/projects/hashed_storage/migration_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_attachments_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_service_spec.rb' - - 'spec/services/projects/import_error_filter_spec.rb' - - 'spec/services/projects/import_export/relation_export_service_spec.rb' - - 'spec/services/projects/in_product_marketing_campaign_emails_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_import_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_link_service_spec.rb' - - 'spec/services/projects/lfs_pointers/lfs_object_download_list_service_spec.rb' - - 'spec/services/projects/move_access_service_spec.rb' - - 'spec/services/projects/move_deploy_keys_projects_service_spec.rb' - - 'spec/services/projects/move_forks_service_spec.rb' - - 'spec/services/projects/move_lfs_objects_projects_service_spec.rb' - - 'spec/services/projects/move_notification_settings_service_spec.rb' - - 'spec/services/projects/move_project_authorizations_service_spec.rb' - - 'spec/services/projects/move_project_group_links_service_spec.rb' - - 'spec/services/projects/move_project_members_service_spec.rb' - - 'spec/services/projects/move_users_star_projects_service_spec.rb' - - 'spec/services/projects/open_issues_count_service_spec.rb' - - 'spec/services/projects/open_merge_requests_count_service_spec.rb' - - 'spec/services/projects/operations/update_service_spec.rb' - - 'spec/services/projects/overwrite_project_service_spec.rb' - - 'spec/services/projects/participants_service_spec.rb' - - 'spec/services/projects/prometheus/alerts/notify_service_spec.rb' - - 'spec/services/projects/prometheus/metrics/destroy_service_spec.rb' - - 'spec/services/projects/protect_default_branch_service_spec.rb' - - 'spec/services/projects/readme_renderer_service_spec.rb' - - 'spec/services/projects/record_target_platforms_service_spec.rb' - - 'spec/services/projects/refresh_build_artifacts_size_statistics_service_spec.rb' - - 'spec/services/projects/repository_languages_service_spec.rb' - - 'spec/services/projects/schedule_bulk_repository_shard_moves_service_spec.rb' - - 'spec/services/projects/transfer_service_spec.rb' - - 'spec/services/projects/unlink_fork_service_spec.rb' - - 'spec/services/projects/update_pages_service_spec.rb' - - 'spec/services/projects/update_remote_mirror_service_spec.rb' - - 'spec/services/projects/update_repository_storage_service_spec.rb' - - 'spec/services/projects/update_service_spec.rb' - - 'spec/services/projects/update_statistics_service_spec.rb' - - 'spec/services/prometheus/proxy_service_spec.rb' - - 'spec/services/prometheus/proxy_variable_substitution_service_spec.rb' - - 'spec/services/protected_branches/api_service_spec.rb' - - 'spec/services/protected_branches/cache_service_spec.rb' - - 'spec/services/protected_branches/destroy_service_spec.rb' - - 'spec/services/protected_branches/update_service_spec.rb' - - 'spec/services/protected_tags/create_service_spec.rb' - - 'spec/services/protected_tags/destroy_service_spec.rb' - - 'spec/services/protected_tags/update_service_spec.rb' - - 'spec/services/push_event_payload_service_spec.rb' - - 'spec/services/quick_actions/target_service_spec.rb' - - 'spec/services/releases/create_evidence_service_spec.rb' - - 'spec/services/releases/destroy_service_spec.rb' - - 'spec/services/repositories/changelog_service_spec.rb' - - 'spec/services/repositories/destroy_service_spec.rb' - - 'spec/services/repository_archive_clean_up_service_spec.rb' - - 'spec/services/reset_project_cache_service_spec.rb' - - 'spec/services/resource_access_tokens/create_service_spec.rb' - - 'spec/services/resource_access_tokens/revoke_service_spec.rb' - - 'spec/services/resource_events/change_milestone_service_spec.rb' - - 'spec/services/resource_events/change_state_service_spec.rb' - - 'spec/services/resource_events/merge_into_notes_service_spec.rb' - - 'spec/services/resource_events/synthetic_label_notes_builder_service_spec.rb' - - 'spec/services/resource_events/synthetic_milestone_notes_builder_service_spec.rb' - - 'spec/services/resource_events/synthetic_state_notes_builder_service_spec.rb' - - 'spec/services/search/global_service_spec.rb' - - 'spec/services/search/group_service_spec.rb' - - 'spec/services/search/snippet_service_spec.rb' - - 'spec/services/security/ci_configuration/container_scanning_create_service_spec.rb' - - 'spec/services/security/ci_configuration/sast_iac_create_service_spec.rb' - - 'spec/services/security/ci_configuration/sast_parser_service_spec.rb' - - 'spec/services/security/ci_configuration/secret_detection_create_service_spec.rb' - - 'spec/services/security/merge_reports_service_spec.rb' - - 'spec/services/serverless/associate_domain_service_spec.rb' - - 'spec/services/service_desk_settings/update_service_spec.rb' - - 'spec/services/service_ping/submit_service_ping_service_spec.rb' - - 'spec/services/service_response_spec.rb' - - 'spec/services/snippets/bulk_destroy_service_spec.rb' - - 'spec/services/snippets/count_service_spec.rb' - - 'spec/services/snippets/create_service_spec.rb' - - 'spec/services/snippets/destroy_service_spec.rb' - - 'spec/services/snippets/repository_validation_service_spec.rb' - - 'spec/services/snippets/schedule_bulk_repository_shard_moves_service_spec.rb' - - 'spec/services/snippets/update_repository_storage_service_spec.rb' - - 'spec/services/snippets/update_service_spec.rb' - - 'spec/services/snippets/update_statistics_service_spec.rb' - - 'spec/services/spam/akismet_mark_as_spam_service_spec.rb' - - 'spec/services/spam/akismet_service_spec.rb' - - 'spec/services/spam/ham_service_spec.rb' - - 'spec/services/spam/spam_action_service_spec.rb' - - 'spec/services/spam/spam_params_spec.rb' - - 'spec/services/spam/spam_verdict_service_spec.rb' - - 'spec/services/submodules/update_service_spec.rb' - - 'spec/services/suggestions/apply_service_spec.rb' - - 'spec/services/suggestions/create_service_spec.rb' - - 'spec/services/suggestions/outdate_service_spec.rb' - - 'spec/services/system_hooks_service_spec.rb' - - 'spec/services/system_notes/alert_management_service_spec.rb' - - 'spec/services/system_notes/base_service_spec.rb' - - 'spec/services/system_notes/commit_service_spec.rb' - - 'spec/services/system_notes/design_management_service_spec.rb' - - 'spec/services/system_notes/incident_service_spec.rb' - - 'spec/services/system_notes/incidents_service_spec.rb' - - 'spec/services/system_notes/issuables_service_spec.rb' - - 'spec/services/system_notes/merge_requests_service_spec.rb' - - 'spec/services/system_notes/time_tracking_service_spec.rb' - - 'spec/services/system_notes/zoom_service_spec.rb' - - 'spec/services/tags/create_service_spec.rb' - - 'spec/services/tags/destroy_service_spec.rb' - - 'spec/services/task_list_toggle_service_spec.rb' - - 'spec/services/tasks_to_be_done/base_service_spec.rb' - - 'spec/services/terraform/remote_state_handler_spec.rb' - - 'spec/services/terraform/states/destroy_service_spec.rb' - - 'spec/services/terraform/states/trigger_destroy_service_spec.rb' - - 'spec/services/test_hooks/project_service_spec.rb' - - 'spec/services/test_hooks/system_service_spec.rb' - - 'spec/services/timelogs/delete_service_spec.rb' - - 'spec/services/todo_service_spec.rb' - - 'spec/services/todos/allowed_target_filter_service_spec.rb' - - 'spec/services/todos/destroy/confidential_issue_service_spec.rb' - - 'spec/services/todos/destroy/design_service_spec.rb' - - 'spec/services/todos/destroy/destroyed_issuable_service_spec.rb' - - 'spec/services/todos/destroy/project_private_service_spec.rb' - - 'spec/services/todos/destroy/unauthorized_features_service_spec.rb' - - 'spec/services/topics/merge_service_spec.rb' - - 'spec/services/two_factor/destroy_service_spec.rb' - - 'spec/services/update_container_registry_info_service_spec.rb' - - 'spec/services/update_merge_request_metrics_service_spec.rb' - - 'spec/services/upload_service_spec.rb' - - 'spec/services/uploads/destroy_service_spec.rb' - - 'spec/services/user_preferences/update_service_spec.rb' - - 'spec/services/users/activity_service_spec.rb' - - 'spec/services/users/approve_service_spec.rb' - - 'spec/services/users/authorized_build_service_spec.rb' - - 'spec/services/users/ban_service_spec.rb' - - 'spec/services/users/banned_user_base_service_spec.rb' - - 'spec/services/users/batch_status_cleaner_service_spec.rb' - - 'spec/services/users/block_service_spec.rb' - - 'spec/services/users/build_service_spec.rb' - - 'spec/services/users/create_service_spec.rb' - - 'spec/services/users/destroy_service_spec.rb' - - 'spec/services/users/dismiss_callout_service_spec.rb' - - 'spec/services/users/dismiss_group_callout_service_spec.rb' - - 'spec/services/users/dismiss_project_callout_service_spec.rb' - - 'spec/services/users/email_verification/generate_token_service_spec.rb' - - 'spec/services/users/email_verification/validate_token_service_spec.rb' - - 'spec/services/users/in_product_marketing_email_records_spec.rb' - - 'spec/services/users/keys_count_service_spec.rb' - - 'spec/services/users/last_push_event_service_spec.rb' - - 'spec/services/users/migrate_records_to_ghost_user_in_batches_service_spec.rb' - - 'spec/services/users/migrate_records_to_ghost_user_service_spec.rb' - - 'spec/services/users/refresh_authorized_projects_service_spec.rb' - - 'spec/services/users/registrations_build_service_spec.rb' - - 'spec/services/users/reject_service_spec.rb' - - 'spec/services/users/repair_ldap_blocked_service_spec.rb' - - 'spec/services/users/respond_to_terms_service_spec.rb' - - 'spec/services/users/saved_replies/create_service_spec.rb' - - 'spec/services/users/saved_replies/destroy_service_spec.rb' - - 'spec/services/users/saved_replies/update_service_spec.rb' - - 'spec/services/users/set_status_service_spec.rb' - - 'spec/services/users/signup_service_spec.rb' - - 'spec/services/users/unban_service_spec.rb' - - 'spec/services/users/unblock_service_spec.rb' - - 'spec/services/users/update_canonical_email_service_spec.rb' - - 'spec/services/users/update_highest_member_role_service_spec.rb' - - 'spec/services/users/update_service_spec.rb' - - 'spec/services/users/update_todo_count_cache_service_spec.rb' - - 'spec/services/users/upsert_credit_card_validation_service_spec.rb' - - 'spec/services/users/validate_manual_otp_service_spec.rb' - - 'spec/services/users/validate_push_otp_service_spec.rb' - - 'spec/services/verify_pages_domain_service_spec.rb' - - 'spec/services/web_hooks/destroy_service_spec.rb' - - 'spec/services/web_hooks/log_destroy_service_spec.rb' - - 'spec/services/web_hooks/log_execution_service_spec.rb' - - 'spec/services/webauthn/authenticate_service_spec.rb' - - 'spec/services/webauthn/register_service_spec.rb' - - 'spec/services/wiki_pages/base_service_spec.rb' - - 'spec/services/wiki_pages/create_service_spec.rb' - - 'spec/services/wiki_pages/destroy_service_spec.rb' - - 'spec/services/wiki_pages/event_create_service_spec.rb' - - 'spec/services/wiki_pages/update_service_spec.rb' - - 'spec/services/wikis/create_attachment_service_spec.rb' - - 'spec/services/work_items/build_service_spec.rb' - - 'spec/services/work_items/create_from_task_service_spec.rb' - - 'spec/services/work_items/create_service_spec.rb' - - 'spec/services/work_items/delete_service_spec.rb' - - 'spec/services/work_items/delete_task_service_spec.rb' - - 'spec/services/work_items/parent_links/destroy_service_spec.rb' - - 'spec/services/work_items/task_list_reference_removal_service_spec.rb' - - 'spec/services/work_items/task_list_reference_replacement_service_spec.rb' - - 'spec/services/work_items/update_service_spec.rb' - - 'spec/services/work_items/widgets/assignees_service/update_service_spec.rb' - - 'spec/services/work_items/widgets/description_service/update_service_spec.rb' - - 'spec/services/work_items/widgets/milestone_service/create_service_spec.rb' - - 'spec/services/work_items/widgets/milestone_service/update_service_spec.rb' - - 'spec/services/work_items/widgets/start_and_due_date_service/update_service_spec.rb' - - 'spec/services/x509_certificate_revoke_service_spec.rb' - 'spec/sidekiq/cron/job_gem_dependency_spec.rb' - 'spec/sidekiq_cluster/sidekiq_cluster_spec.rb' - 'spec/spam/concerns/has_spam_action_response_fields_spec.rb' @@ -7598,21 +5602,17 @@ RSpec/MissingFeatureCategory: - 'spec/support_specs/helpers/active_record/query_recorder_spec.rb' - 'spec/support_specs/helpers/graphql_helpers_spec.rb' - 'spec/support_specs/helpers/html_escaped_helpers_spec.rb' - - 'spec/support_specs/helpers/migrations_helpers_spec.rb' - 'spec/support_specs/helpers/redis_commands/recorder_spec.rb' - 'spec/support_specs/helpers/stub_feature_flags_spec.rb' - 'spec/support_specs/helpers/stub_method_calls_spec.rb' - 'spec/support_specs/matchers/be_sorted_spec.rb' - - 'spec/support_specs/matchers/event_store_spec.rb' - 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb' - 'spec/support_specs/time_travel_spec.rb' - 'spec/tasks/admin_mode_spec.rb' - 'spec/tasks/config_lint_spec.rb' - 'spec/tasks/dev_rake_spec.rb' - - 'spec/tasks/gettext_rake_spec.rb' - 'spec/tasks/gitlab/artifacts/check_rake_spec.rb' - 'spec/tasks/gitlab/artifacts/migrate_rake_spec.rb' - - 'spec/tasks/gitlab/background_migrations_rake_spec.rb' - 'spec/tasks/gitlab/cleanup_rake_spec.rb' - 'spec/tasks/gitlab/container_registry_rake_spec.rb' - 'spec/tasks/gitlab/dependency_proxy/migrate_rake_spec.rb' @@ -7628,7 +5628,6 @@ RSpec/MissingFeatureCategory: - 'spec/tasks/gitlab/pages_rake_spec.rb' - 'spec/tasks/gitlab/password_rake_spec.rb' - 'spec/tasks/gitlab/praefect_rake_spec.rb' - - 'spec/tasks/gitlab/refresh_project_statistics_build_artifacts_size_rake_spec.rb' - 'spec/tasks/gitlab/setup_rake_spec.rb' - 'spec/tasks/gitlab/shell_rake_spec.rb' - 'spec/tasks/gitlab/sidekiq_rake_spec.rb' @@ -7648,7 +5647,7 @@ RSpec/MissingFeatureCategory: - 'spec/tooling/danger/customer_success_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/danger/feature_flag_spec.rb' - - 'spec/tooling/danger/product_intelligence_spec.rb' + - 'spec/tooling/danger/analytics_instrumentation_spec.rb' - 'spec/tooling/danger/project_helper_spec.rb' - 'spec/tooling/danger/sidekiq_queues_spec.rb' - 'spec/tooling/docs/deprecation_handling_spec.rb' @@ -7679,14 +5678,12 @@ RSpec/MissingFeatureCategory: - 'spec/uploaders/favicon_uploader_spec.rb' - 'spec/uploaders/file_mover_spec.rb' - 'spec/uploaders/file_uploader_spec.rb' - - 'spec/uploaders/gitlab_uploader_spec.rb' - 'spec/uploaders/import_export_uploader_spec.rb' - 'spec/uploaders/job_artifact_uploader_spec.rb' - 'spec/uploaders/lfs_object_uploader_spec.rb' - 'spec/uploaders/metric_image_uploader_spec.rb' - 'spec/uploaders/namespace_file_uploader_spec.rb' - 'spec/uploaders/object_storage/cdn/google_ip_cache_spec.rb' - - 'spec/uploaders/object_storage_spec.rb' - 'spec/uploaders/packages/composer/cache_uploader_spec.rb' - 'spec/uploaders/packages/debian/component_file_uploader_spec.rb' - 'spec/uploaders/packages/debian/distribution_release_file_uploader_spec.rb' @@ -7752,7 +5749,6 @@ RSpec/MissingFeatureCategory: - 'spec/views/events/event/_common.html.haml_spec.rb' - 'spec/views/events/event/_push.html.haml_spec.rb' - 'spec/views/groups/_home_panel.html.haml_spec.rb' - - 'spec/views/groups/edit.html.haml_spec.rb' - 'spec/views/groups/milestones/index.html.haml_spec.rb' - 'spec/views/groups/new.html.haml_spec.rb' - 'spec/views/groups/observability/observability.html.haml_spec.rb' @@ -7766,13 +5762,10 @@ RSpec/MissingFeatureCategory: - 'spec/views/layouts/_head.html.haml_spec.rb' - 'spec/views/layouts/_header_search.html.haml_spec.rb' - 'spec/views/layouts/_published_experiments.html.haml_spec.rb' - - 'spec/views/layouts/_search.html.haml_spec.rb' - 'spec/views/layouts/application.html.haml_spec.rb' - - 'spec/views/layouts/devise.html.haml_spec.rb' - 'spec/views/layouts/devise_empty.html.haml_spec.rb' - 'spec/views/layouts/fullscreen.html.haml_spec.rb' - 'spec/views/layouts/header/_gitlab_version.html.haml_spec.rb' - - 'spec/views/layouts/nav/sidebar/_admin.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_group.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_profile.html.haml_spec.rb' - 'spec/views/layouts/profile.html.haml_spec.rb' @@ -7850,358 +5843,10 @@ RSpec/MissingFeatureCategory: - 'spec/views/shared/projects/_inactive_project_deletion_alert.html.haml_spec.rb' - 'spec/views/shared/projects/_list.html.haml_spec.rb' - 'spec/views/shared/projects/_project.html.haml_spec.rb' - - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - 'spec/views/shared/snippets/_snippet.html.haml_spec.rb' - 'spec/views/shared/ssh_keys/_key_delete.html.haml_spec.rb' - 'spec/views/shared/web_hooks/_web_hook_disabled_alert.html.haml_spec.rb' - 'spec/views/shared/wikis/_sidebar.html.haml_spec.rb' - - 'spec/workers/admin_email_worker_spec.rb' - - 'spec/workers/analytics/usage_trends/count_job_trigger_worker_spec.rb' - - 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb' - - 'spec/workers/approve_blocked_pending_approval_users_worker_spec.rb' - - 'spec/workers/authorized_keys_worker_spec.rb' - - 'spec/workers/authorized_project_update/periodic_recalculate_worker_spec.rb' - - 'spec/workers/authorized_project_update/project_recalculate_per_user_worker_spec.rb' - - 'spec/workers/authorized_project_update/project_recalculate_worker_spec.rb' - - 'spec/workers/authorized_project_update/user_refresh_from_replica_worker_spec.rb' - - 'spec/workers/authorized_project_update/user_refresh_over_user_range_worker_spec.rb' - - 'spec/workers/authorized_project_update/user_refresh_with_low_urgency_worker_spec.rb' - - 'spec/workers/authorized_projects_worker_spec.rb' - - 'spec/workers/auto_devops/disable_worker_spec.rb' - - 'spec/workers/auto_merge_process_worker_spec.rb' - - 'spec/workers/background_migration/ci_database_worker_spec.rb' - - 'spec/workers/background_migration_worker_spec.rb' - - 'spec/workers/build_hooks_worker_spec.rb' - - 'spec/workers/build_queue_worker_spec.rb' - - 'spec/workers/build_success_worker_spec.rb' - - 'spec/workers/bulk_imports/entity_worker_spec.rb' - - 'spec/workers/bulk_imports/relation_export_worker_spec.rb' - - 'spec/workers/bulk_imports/stuck_import_worker_spec.rb' - - 'spec/workers/chat_notification_worker_spec.rb' - - 'spec/workers/ci/archive_trace_worker_spec.rb' - - 'spec/workers/ci/build_finished_worker_spec.rb' - - 'spec/workers/ci/build_prepare_worker_spec.rb' - - 'spec/workers/ci/build_schedule_worker_spec.rb' - - 'spec/workers/ci/build_trace_chunk_flush_worker_spec.rb' - - 'spec/workers/ci/cancel_pipeline_worker_spec.rb' - - 'spec/workers/ci/create_cross_project_pipeline_worker_spec.rb' - - 'spec/workers/ci/create_downstream_pipeline_worker_spec.rb' - - 'spec/workers/ci/daily_build_group_report_results_worker_spec.rb' - - 'spec/workers/ci/delete_objects_worker_spec.rb' - - 'spec/workers/ci/delete_unit_tests_worker_spec.rb' - - 'spec/workers/ci/drop_pipeline_worker_spec.rb' - - 'spec/workers/ci/job_artifacts/expire_project_build_artifacts_worker_spec.rb' - - 'spec/workers/ci/job_artifacts/track_artifact_report_worker_spec.rb' - - 'spec/workers/ci/merge_requests/add_todo_when_build_fails_worker_spec.rb' - - 'spec/workers/ci/parse_secure_file_metadata_worker_spec.rb' - - 'spec/workers/ci/pending_builds/update_group_worker_spec.rb' - - 'spec/workers/ci/pending_builds/update_project_worker_spec.rb' - - 'spec/workers/ci/pipeline_artifacts/coverage_report_worker_spec.rb' - - 'spec/workers/ci/pipeline_artifacts/create_quality_report_worker_spec.rb' - - 'spec/workers/ci/pipeline_artifacts/expire_artifacts_worker_spec.rb' - - 'spec/workers/ci/pipeline_bridge_status_worker_spec.rb' - - 'spec/workers/ci/pipeline_success_unlock_artifacts_worker_spec.rb' - - 'spec/workers/ci/ref_delete_unlock_artifacts_worker_spec.rb' - - 'spec/workers/ci/resource_groups/assign_resource_from_resource_group_worker_spec.rb' - - 'spec/workers/ci/retry_pipeline_worker_spec.rb' - - 'spec/workers/ci/schedule_delete_objects_cron_worker_spec.rb' - - 'spec/workers/ci/stuck_builds/drop_running_worker_spec.rb' - - 'spec/workers/ci/stuck_builds/drop_scheduled_worker_spec.rb' - - 'spec/workers/ci/test_failure_history_worker_spec.rb' - - 'spec/workers/ci/track_failed_build_worker_spec.rb' - - 'spec/workers/ci/update_locked_unknown_artifacts_worker_spec.rb' - - 'spec/workers/ci_platform_metrics_update_cron_worker_spec.rb' - - 'spec/workers/cleanup_container_repository_worker_spec.rb' - - 'spec/workers/clusters/agents/delete_expired_events_worker_spec.rb' - - 'spec/workers/clusters/applications/activate_integration_worker_spec.rb' - - 'spec/workers/clusters/applications/deactivate_integration_worker_spec.rb' - - 'spec/workers/clusters/cleanup/project_namespace_worker_spec.rb' - - 'spec/workers/clusters/cleanup/service_account_worker_spec.rb' - - 'spec/workers/clusters/integrations/check_prometheus_health_worker_spec.rb' - - 'spec/workers/concerns/application_worker_spec.rb' - - 'spec/workers/concerns/cluster_agent_queue_spec.rb' - - 'spec/workers/concerns/cluster_queue_spec.rb' - - 'spec/workers/concerns/cronjob_queue_spec.rb' - - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' - - 'spec/workers/concerns/gitlab/github_import/queue_spec.rb' - - 'spec/workers/concerns/gitlab/github_import/rescheduling_methods_spec.rb' - - 'spec/workers/concerns/gitlab/github_import/stage_methods_spec.rb' - - 'spec/workers/concerns/gitlab/notify_upon_death_spec.rb' - - 'spec/workers/concerns/limited_capacity/job_tracker_spec.rb' - - 'spec/workers/concerns/limited_capacity/worker_spec.rb' - - 'spec/workers/concerns/packages/cleanup_artifact_worker_spec.rb' - - 'spec/workers/concerns/pipeline_background_queue_spec.rb' - - 'spec/workers/concerns/pipeline_queue_spec.rb' - - 'spec/workers/concerns/project_import_options_spec.rb' - 'spec/workers/concerns/reenqueuer_spec.rb' - - 'spec/workers/concerns/repository_check_queue_spec.rb' - - 'spec/workers/concerns/waitable_worker_spec.rb' - - 'spec/workers/concerns/worker_attributes_spec.rb' - - 'spec/workers/concerns/worker_context_spec.rb' - - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' - - 'spec/workers/container_expiration_policy_worker_spec.rb' - - 'spec/workers/container_registry/cleanup_worker_spec.rb' - - 'spec/workers/container_registry/delete_container_repository_worker_spec.rb' - - 'spec/workers/container_registry/migration/enqueuer_worker_spec.rb' - - 'spec/workers/container_registry/migration/guard_worker_spec.rb' - - 'spec/workers/container_registry/migration/observer_worker_spec.rb' - - 'spec/workers/counters/cleanup_refresh_worker_spec.rb' - - 'spec/workers/create_commit_signature_worker_spec.rb' - - 'spec/workers/create_note_diff_file_worker_spec.rb' - - 'spec/workers/create_pipeline_worker_spec.rb' - - 'spec/workers/database/batched_background_migration/ci_database_worker_spec.rb' - - 'spec/workers/database/batched_background_migration_worker_spec.rb' - - 'spec/workers/database/ci_namespace_mirrors_consistency_check_worker_spec.rb' - - 'spec/workers/database/ci_project_mirrors_consistency_check_worker_spec.rb' - - 'spec/workers/database/drop_detached_partitions_worker_spec.rb' - - 'spec/workers/database/partition_management_worker_spec.rb' - - 'spec/workers/delete_container_repository_worker_spec.rb' - - 'spec/workers/delete_diff_files_worker_spec.rb' - - 'spec/workers/delete_merged_branches_worker_spec.rb' - - 'spec/workers/delete_user_worker_spec.rb' - - 'spec/workers/dependency_proxy/cleanup_blob_worker_spec.rb' - - 'spec/workers/dependency_proxy/cleanup_dependency_proxy_worker_spec.rb' - - 'spec/workers/dependency_proxy/cleanup_manifest_worker_spec.rb' - - 'spec/workers/dependency_proxy/image_ttl_group_policy_worker_spec.rb' - - 'spec/workers/deployments/archive_in_project_worker_spec.rb' - - 'spec/workers/deployments/drop_older_deployments_worker_spec.rb' - - 'spec/workers/deployments/hooks_worker_spec.rb' - - 'spec/workers/deployments/link_merge_request_worker_spec.rb' - - 'spec/workers/deployments/update_environment_worker_spec.rb' - - 'spec/workers/design_management/copy_design_collection_worker_spec.rb' - - 'spec/workers/design_management/new_version_worker_spec.rb' - - 'spec/workers/destroy_pages_deployments_worker_spec.rb' - - 'spec/workers/detect_repository_languages_worker_spec.rb' - - 'spec/workers/disallow_two_factor_for_group_worker_spec.rb' - - 'spec/workers/disallow_two_factor_for_subgroups_worker_spec.rb' - - 'spec/workers/email_receiver_worker_spec.rb' - - 'spec/workers/emails_on_push_worker_spec.rb' - - 'spec/workers/environments/auto_delete_cron_worker_spec.rb' - - 'spec/workers/environments/auto_stop_cron_worker_spec.rb' - - 'spec/workers/environments/auto_stop_worker_spec.rb' - - 'spec/workers/environments/canary_ingress/update_worker_spec.rb' - - 'spec/workers/error_tracking_issue_link_worker_spec.rb' - - 'spec/workers/every_sidekiq_worker_spec.rb' - - 'spec/workers/expire_build_artifacts_worker_spec.rb' - - 'spec/workers/export_csv_worker_spec.rb' - - 'spec/workers/external_service_reactive_caching_worker_spec.rb' - - 'spec/workers/file_hook_worker_spec.rb' - - 'spec/workers/flush_counter_increments_worker_spec.rb' - - 'spec/workers/gitlab/github_import/advance_stage_worker_spec.rb' - - 'spec/workers/gitlab/github_import/attachments/import_issue_worker_spec.rb' - - 'spec/workers/gitlab/github_import/attachments/import_merge_request_worker_spec.rb' - - 'spec/workers/gitlab/github_import/attachments/import_note_worker_spec.rb' - - 'spec/workers/gitlab/github_import/attachments/import_release_worker_spec.rb' - - 'spec/workers/gitlab/github_import/import_diff_note_worker_spec.rb' - - 'spec/workers/gitlab/github_import/import_issue_event_worker_spec.rb' - - 'spec/workers/gitlab/github_import/import_issue_worker_spec.rb' - - 'spec/workers/gitlab/github_import/import_note_worker_spec.rb' - - 'spec/workers/gitlab/github_import/import_protected_branch_worker_spec.rb' - - 'spec/workers/gitlab/github_import/import_pull_request_merged_by_worker_spec.rb' - - 'spec/workers/gitlab/github_import/import_pull_request_review_worker_spec.rb' - - 'spec/workers/gitlab/github_import/import_pull_request_worker_spec.rb' - - 'spec/workers/gitlab/github_import/import_release_attachments_worker_spec.rb' - - 'spec/workers/gitlab/github_import/pull_requests/import_review_request_worker_spec.rb' - - 'spec/workers/gitlab/github_import/refresh_import_jid_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/finish_import_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/import_attachments_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/import_base_data_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/import_issue_events_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/import_issues_and_diff_notes_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/import_lfs_objects_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/import_notes_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/import_protected_branches_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/import_pull_requests_merged_by_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/import_pull_requests_review_requests_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/import_pull_requests_reviews_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/import_pull_requests_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/import_repository_worker_spec.rb' - - 'spec/workers/gitlab/import/stuck_import_job_spec.rb' - - 'spec/workers/gitlab/import/stuck_project_import_jobs_worker_spec.rb' - - 'spec/workers/gitlab/jira_import/import_issue_worker_spec.rb' - - 'spec/workers/gitlab/jira_import/stage/finish_import_worker_spec.rb' - - 'spec/workers/gitlab/jira_import/stage/import_attachments_worker_spec.rb' - - 'spec/workers/gitlab/jira_import/stage/import_issues_worker_spec.rb' - - 'spec/workers/gitlab/jira_import/stage/import_labels_worker_spec.rb' - - 'spec/workers/gitlab/jira_import/stage/import_notes_worker_spec.rb' - - 'spec/workers/gitlab/jira_import/stage/start_import_worker_spec.rb' - - 'spec/workers/gitlab/jira_import/stuck_jira_import_jobs_worker_spec.rb' - - 'spec/workers/gitlab/phabricator_import/base_worker_spec.rb' - - 'spec/workers/gitlab/phabricator_import/import_tasks_worker_spec.rb' - - 'spec/workers/gitlab_performance_bar_stats_worker_spec.rb' - - 'spec/workers/gitlab_service_ping_worker_spec.rb' - - 'spec/workers/gitlab_shell_worker_spec.rb' - - 'spec/workers/google_cloud/create_cloudsql_instance_worker_spec.rb' - - 'spec/workers/group_destroy_worker_spec.rb' - - 'spec/workers/group_export_worker_spec.rb' - - 'spec/workers/group_import_worker_spec.rb' - - 'spec/workers/groups/update_statistics_worker_spec.rb' - - 'spec/workers/groups/update_two_factor_requirement_for_members_worker_spec.rb' - - 'spec/workers/hashed_storage/migrator_worker_spec.rb' - - 'spec/workers/hashed_storage/project_migrate_worker_spec.rb' - - 'spec/workers/hashed_storage/project_rollback_worker_spec.rb' - - 'spec/workers/hashed_storage/rollbacker_worker_spec.rb' - - 'spec/workers/import_issues_csv_worker_spec.rb' - - 'spec/workers/incident_management/add_severity_system_note_worker_spec.rb' - - 'spec/workers/incident_management/close_incident_worker_spec.rb' - - 'spec/workers/incident_management/pager_duty/process_incident_worker_spec.rb' - - 'spec/workers/incident_management/process_alert_worker_v2_spec.rb' - - 'spec/workers/integrations/create_external_cross_reference_worker_spec.rb' - - 'spec/workers/integrations/execute_worker_spec.rb' - - 'spec/workers/integrations/irker_worker_spec.rb' - - 'spec/workers/invalid_gpg_signature_update_worker_spec.rb' - - 'spec/workers/issuable/label_links_destroy_worker_spec.rb' - - 'spec/workers/issuable_export_csv_worker_spec.rb' - - 'spec/workers/issuables/clear_groups_issue_counter_worker_spec.rb' - - 'spec/workers/issue_due_scheduler_worker_spec.rb' - - 'spec/workers/issues/close_worker_spec.rb' - - 'spec/workers/issues/placement_worker_spec.rb' - - 'spec/workers/issues/rebalancing_worker_spec.rb' - - 'spec/workers/issues/reschedule_stuck_issue_rebalances_worker_spec.rb' - - 'spec/workers/jira_connect/forward_event_worker_spec.rb' - - 'spec/workers/jira_connect/retry_request_worker_spec.rb' - - 'spec/workers/jira_connect/sync_branch_worker_spec.rb' - - 'spec/workers/jira_connect/sync_builds_worker_spec.rb' - - 'spec/workers/jira_connect/sync_deployments_worker_spec.rb' - - 'spec/workers/jira_connect/sync_feature_flags_worker_spec.rb' - - 'spec/workers/jira_connect/sync_merge_request_worker_spec.rb' - - 'spec/workers/jira_connect/sync_project_worker_spec.rb' - - 'spec/workers/loose_foreign_keys/cleanup_worker_spec.rb' - - 'spec/workers/mail_scheduler/issue_due_worker_spec.rb' - - 'spec/workers/mail_scheduler/notification_service_worker_spec.rb' - - 'spec/workers/member_invitation_reminder_emails_worker_spec.rb' - - 'spec/workers/members_destroyer/unassign_issuables_worker_spec.rb' - - 'spec/workers/merge_request_cleanup_refs_worker_spec.rb' - - 'spec/workers/merge_request_mergeability_check_worker_spec.rb' - - 'spec/workers/merge_requests/close_issue_worker_spec.rb' - - 'spec/workers/merge_requests/create_approval_event_worker_spec.rb' - - 'spec/workers/merge_requests/create_approval_note_worker_spec.rb' - - 'spec/workers/merge_requests/delete_source_branch_worker_spec.rb' - - 'spec/workers/merge_requests/execute_approval_hooks_worker_spec.rb' - - 'spec/workers/merge_requests/handle_assignees_change_worker_spec.rb' - - 'spec/workers/merge_requests/resolve_todos_after_approval_worker_spec.rb' - - 'spec/workers/merge_requests/resolve_todos_worker_spec.rb' - - 'spec/workers/merge_requests/update_head_pipeline_worker_spec.rb' - - 'spec/workers/merge_worker_spec.rb' - - 'spec/workers/metrics/dashboard/prune_old_annotations_worker_spec.rb' - - 'spec/workers/metrics/dashboard/schedule_annotations_prune_worker_spec.rb' - - 'spec/workers/metrics/dashboard/sync_dashboards_worker_spec.rb' - - 'spec/workers/migrate_external_diffs_worker_spec.rb' - - 'spec/workers/namespaces/in_product_marketing_emails_worker_spec.rb' - - 'spec/workers/namespaces/process_sync_events_worker_spec.rb' - - 'spec/workers/namespaces/prune_aggregation_schedules_worker_spec.rb' - - 'spec/workers/namespaces/root_statistics_worker_spec.rb' - - 'spec/workers/namespaces/schedule_aggregation_worker_spec.rb' - - 'spec/workers/namespaces/update_root_statistics_worker_spec.rb' - - 'spec/workers/new_issue_worker_spec.rb' - - 'spec/workers/new_note_worker_spec.rb' - - 'spec/workers/object_pool/create_worker_spec.rb' - - 'spec/workers/object_pool/destroy_worker_spec.rb' - - 'spec/workers/object_pool/join_worker_spec.rb' - - 'spec/workers/onboarding/issue_created_worker_spec.rb' - - 'spec/workers/onboarding/pipeline_created_worker_spec.rb' - - 'spec/workers/onboarding/progress_worker_spec.rb' - - 'spec/workers/onboarding/user_added_worker_spec.rb' - - 'spec/workers/packages/cleanup/execute_policy_worker_spec.rb' - - 'spec/workers/packages/cleanup_package_file_worker_spec.rb' - - 'spec/workers/packages/cleanup_package_registry_worker_spec.rb' - - 'spec/workers/packages/composer/cache_cleanup_worker_spec.rb' - - 'spec/workers/packages/composer/cache_update_worker_spec.rb' - - 'spec/workers/packages/go/sync_packages_worker_spec.rb' - - 'spec/workers/packages/helm/extraction_worker_spec.rb' - - 'spec/workers/packages/mark_package_files_for_destruction_worker_spec.rb' - 'spec/workers/packages/maven/metadata/sync_worker_spec.rb' - - 'spec/workers/packages/nuget/extraction_worker_spec.rb' - - 'spec/workers/packages/rubygems/extraction_worker_spec.rb' - - 'spec/workers/pages_domain_removal_cron_worker_spec.rb' - - 'spec/workers/pages_domain_ssl_renewal_cron_worker_spec.rb' - - 'spec/workers/pages_domain_ssl_renewal_worker_spec.rb' - - 'spec/workers/pages_domain_verification_cron_worker_spec.rb' - - 'spec/workers/pages_domain_verification_worker_spec.rb' - - 'spec/workers/pages_worker_spec.rb' - - 'spec/workers/partition_creation_worker_spec.rb' - - 'spec/workers/personal_access_tokens/expired_notification_worker_spec.rb' - - 'spec/workers/personal_access_tokens/expiring_worker_spec.rb' - - 'spec/workers/pipeline_hooks_worker_spec.rb' - - 'spec/workers/pipeline_metrics_worker_spec.rb' - - 'spec/workers/pipeline_notification_worker_spec.rb' - - 'spec/workers/pipeline_process_worker_spec.rb' - - 'spec/workers/post_receive_spec.rb' - - 'spec/workers/process_commit_worker_spec.rb' - - 'spec/workers/project_cache_worker_spec.rb' - - 'spec/workers/project_destroy_worker_spec.rb' - - 'spec/workers/project_export_worker_spec.rb' - - 'spec/workers/projects/after_import_worker_spec.rb' - - 'spec/workers/projects/finalize_project_statistics_refresh_worker_spec.rb' - - 'spec/workers/projects/import_export/relation_export_worker_spec.rb' - - 'spec/workers/projects/inactive_projects_deletion_cron_worker_spec.rb' - - 'spec/workers/projects/inactive_projects_deletion_notification_worker_spec.rb' - - 'spec/workers/projects/post_creation_worker_spec.rb' - - 'spec/workers/projects/process_sync_events_worker_spec.rb' - - 'spec/workers/projects/record_target_platforms_worker_spec.rb' - - 'spec/workers/projects/refresh_build_artifacts_size_statistics_worker_spec.rb' - - 'spec/workers/projects/schedule_bulk_repository_shard_moves_worker_spec.rb' - - 'spec/workers/projects/schedule_refresh_build_artifacts_size_statistics_worker_spec.rb' - - 'spec/workers/projects/update_repository_storage_worker_spec.rb' - - 'spec/workers/propagate_integration_group_worker_spec.rb' - - 'spec/workers/propagate_integration_inherit_descendant_worker_spec.rb' - - 'spec/workers/propagate_integration_inherit_worker_spec.rb' - 'spec/workers/propagate_integration_project_worker_spec.rb' - - 'spec/workers/propagate_integration_worker_spec.rb' - - 'spec/workers/prune_old_events_worker_spec.rb' - - 'spec/workers/purge_dependency_proxy_cache_worker_spec.rb' - - 'spec/workers/reactive_caching_worker_spec.rb' - - 'spec/workers/rebase_worker_spec.rb' - - 'spec/workers/releases/create_evidence_worker_spec.rb' - - 'spec/workers/releases/manage_evidence_worker_spec.rb' - - 'spec/workers/remote_mirror_notification_worker_spec.rb' - - 'spec/workers/remove_expired_group_links_worker_spec.rb' - - 'spec/workers/remove_expired_members_worker_spec.rb' - - 'spec/workers/remove_unaccepted_member_invites_worker_spec.rb' - - 'spec/workers/remove_unreferenced_lfs_objects_worker_spec.rb' - - 'spec/workers/repository_check/batch_worker_spec.rb' - - 'spec/workers/repository_check/clear_worker_spec.rb' - - 'spec/workers/repository_check/dispatch_worker_spec.rb' - - 'spec/workers/repository_check/single_repository_worker_spec.rb' - - 'spec/workers/repository_cleanup_worker_spec.rb' - - 'spec/workers/repository_fork_worker_spec.rb' - - 'spec/workers/repository_update_remote_mirror_worker_spec.rb' - - 'spec/workers/schedule_merge_request_cleanup_refs_worker_spec.rb' - - 'spec/workers/schedule_migrate_external_diffs_worker_spec.rb' - - 'spec/workers/self_monitoring_project_create_worker_spec.rb' - - 'spec/workers/self_monitoring_project_delete_worker_spec.rb' - - 'spec/workers/service_desk_email_receiver_worker_spec.rb' - - 'spec/workers/snippets/schedule_bulk_repository_shard_moves_worker_spec.rb' - - 'spec/workers/snippets/update_repository_storage_worker_spec.rb' - - 'spec/workers/ssh_keys/expired_notification_worker_spec.rb' - - 'spec/workers/ssh_keys/expiring_soon_notification_worker_spec.rb' - - 'spec/workers/stage_update_worker_spec.rb' - - 'spec/workers/stuck_ci_jobs_worker_spec.rb' - - 'spec/workers/stuck_export_jobs_worker_spec.rb' - - 'spec/workers/stuck_merge_jobs_worker_spec.rb' - - 'spec/workers/system_hook_push_worker_spec.rb' - - 'spec/workers/tasks_to_be_done/create_worker_spec.rb' - - 'spec/workers/terraform/states/destroy_worker_spec.rb' - - 'spec/workers/todos_destroyer/confidential_issue_worker_spec.rb' - - 'spec/workers/todos_destroyer/destroyed_designs_worker_spec.rb' - - 'spec/workers/todos_destroyer/destroyed_issuable_worker_spec.rb' - - 'spec/workers/todos_destroyer/entity_leave_worker_spec.rb' - - 'spec/workers/todos_destroyer/group_private_worker_spec.rb' - - 'spec/workers/todos_destroyer/private_features_worker_spec.rb' - - 'spec/workers/todos_destroyer/project_private_worker_spec.rb' - - 'spec/workers/trending_projects_worker_spec.rb' - - 'spec/workers/update_container_registry_info_worker_spec.rb' - - 'spec/workers/update_external_pull_requests_worker_spec.rb' - - 'spec/workers/update_head_pipeline_for_merge_request_worker_spec.rb' - - 'spec/workers/update_highest_role_worker_spec.rb' - - 'spec/workers/update_merge_requests_worker_spec.rb' - - 'spec/workers/update_project_statistics_worker_spec.rb' - - 'spec/workers/upload_checksum_worker_spec.rb' - - 'spec/workers/user_status_cleanup/batch_worker_spec.rb' - - 'spec/workers/users/create_statistics_worker_spec.rb' - - 'spec/workers/users/deactivate_dormant_users_worker_spec.rb' - - 'spec/workers/users/migrate_records_to_ghost_user_in_batches_worker_spec.rb' - - 'spec/workers/web_hook_worker_spec.rb' - - 'spec/workers/web_hooks/log_destroy_worker_spec.rb' - - 'spec/workers/x509_certificate_revoke_worker_spec.rb' - - 'spec/workers/x509_issuer_crl_check_worker_spec.rb' diff --git a/.rubocop_todo/rspec/misspelled_aggregate_failures.yml b/.rubocop_todo/rspec/misspelled_aggregate_failures.yml new file mode 100644 index 00000000000..75465411b63 --- /dev/null +++ b/.rubocop_todo/rspec/misspelled_aggregate_failures.yml @@ -0,0 +1,4 @@ +--- +# Cop supports --autocorrect. +RSpec/MisspelledAggregateFailures: + Details: grace period diff --git a/.rubocop_todo/rspec/multiple_memoized_helpers.yml b/.rubocop_todo/rspec/multiple_memoized_helpers.yml index 708543510a2..ddb9f70c3b4 100644 --- a/.rubocop_todo/rspec/multiple_memoized_helpers.yml +++ b/.rubocop_todo/rspec/multiple_memoized_helpers.yml @@ -5,7 +5,6 @@ RSpec/MultipleMemoizedHelpers: - 'ee/spec/finders/epics_finder_spec.rb' - 'ee/spec/finders/incident_management/oncall_users_finder_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' @@ -15,7 +14,6 @@ RSpec/MultipleMemoizedHelpers: - 'spec/finders/ci/runners_finder_spec.rb' - 'spec/finders/labels_finder_spec.rb' - 'spec/finders/user_recent_events_finder_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' - 'spec/models/event_spec.rb' - 'spec/models/milestone_spec.rb' diff --git a/.rubocop_todo/rspec/repeated_example_group_description.yml b/.rubocop_todo/rspec/repeated_example_group_description.yml index e34ea087ed1..d5b3ad81d01 100644 --- a/.rubocop_todo/rspec/repeated_example_group_description.yml +++ b/.rubocop_todo/rspec/repeated_example_group_description.yml @@ -1,7 +1,6 @@ --- RSpec/RepeatedExampleGroupDescription: Exclude: - - 'ee/spec/finders/merge_trains_finder_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_grade_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerability_severities_count_resolver_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' @@ -90,7 +89,6 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/services/merge_requests/refresh_service_spec.rb' - 'spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/limitable_shared_examples.rb' - 'spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb' diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml index 17c72133549..da4c41e2f6d 100644 --- a/.rubocop_todo/rspec/return_from_stub.yml +++ b/.rubocop_todo/rspec/return_from_stub.yml @@ -15,7 +15,6 @@ RSpec/ReturnFromStub: - 'ee/spec/lib/ee/feature_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb' - 'ee/spec/lib/ee/gitlab/database_spec.rb' - - 'ee/spec/lib/gitlab/ci/minutes/build_consumption_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' - 'ee/spec/lib/gitlab/geo/health_check_spec.rb' - 'ee/spec/lib/gitlab/geo/logger_spec.rb' @@ -75,7 +74,6 @@ RSpec/ReturnFromStub: - 'ee/spec/workers/geo/repository_verification/secondary/single_worker_spec.rb' - 'ee/spec/workers/post_receive_spec.rb' - 'ee/spec/workers/store_security_reports_worker_spec.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'qa/spec/specs/runner_spec.rb' - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/bin/feature_flag_spec.rb' @@ -112,7 +110,6 @@ RSpec/ReturnFromStub: - 'spec/graphql/mutations/environments/canary_ingress/update_spec.rb' - 'spec/graphql/types/project_type_spec.rb' - 'spec/helpers/auth_helper_spec.rb' - - 'spec/helpers/broadcast_messages_helper_spec.rb' - 'spec/helpers/dashboard_helper_spec.rb' - 'spec/helpers/diff_helper_spec.rb' - 'spec/helpers/explore_helper_spec.rb' @@ -134,7 +131,6 @@ RSpec/ReturnFromStub: - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' - 'spec/lib/gitlab/auth_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/ci/build/policy/changes_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/stage_spec.rb' @@ -146,7 +142,6 @@ RSpec/ReturnFromStub: - 'spec/lib/gitlab/diff/file_spec.rb' - 'spec/lib/gitlab/email/message/build_ios_app_guide_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/helper_spec.rb' - - 'spec/lib/gitlab/error_tracking_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers/sleeping_lock_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers_spec.rb' - 'spec/lib/gitlab/external_authorization_spec.rb' @@ -167,7 +162,6 @@ RSpec/ReturnFromStub: - 'spec/lib/gitlab/redis/shared_state_spec.rb' - 'spec/lib/gitlab/redis/sidekiq_status_spec.rb' - 'spec/lib/gitlab/relative_positioning/range_spec.rb' - - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/until_executed_spec.rb' diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml index f1cb325bd50..573991418f7 100644 --- a/.rubocop_todo/rspec/scattered_let.yml +++ b/.rubocop_todo/rspec/scattered_let.yml @@ -24,9 +24,9 @@ RSpec/ScatteredLet: - 'ee/spec/models/approval_wrapped_any_approver_rule_spec.rb' - 'ee/spec/models/dast_site_validation_spec.rb' - 'ee/spec/models/ee/ci/build_dependencies_spec.rb' - - 'ee/spec/models/ee/iteration_spec.rb' - 'ee/spec/models/ee/user_spec.rb' - 'ee/spec/models/epic_spec.rb' + - 'ee/spec/models/iteration_spec.rb' - 'ee/spec/models/preloaders/environments/protected_environment_preloader_spec.rb' - 'ee/spec/models/vulnerabilities/historical_statistic_spec.rb' - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' @@ -125,7 +125,6 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_inactive_public_projects_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb' diff --git a/.rubocop_todo/rspec/shared_groups_metadata.yml b/.rubocop_todo/rspec/shared_groups_metadata.yml new file mode 100644 index 00000000000..ddac8bf6589 --- /dev/null +++ b/.rubocop_todo/rspec/shared_groups_metadata.yml @@ -0,0 +1,6 @@ +--- +RSpec/SharedGroupsMetadata: + Details: grace period + Exclude: + - 'spec/lib/gitlab/ci/config/entry/retry_spec.rb' + - 'spec/lib/gitlab/git/merge_base_spec.rb' diff --git a/.rubocop_todo/rspec/variable_name.yml b/.rubocop_todo/rspec/variable_name.yml deleted file mode 100644 index 8858fbd9eb7..00000000000 --- a/.rubocop_todo/rspec/variable_name.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -RSpec/VariableName: - Exclude: - - 'spec/models/user_spec.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 7bb6e4a8188..88b6f302e56 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -31,8 +31,6 @@ RSpec/VerifiedDoubles: - 'ee/spec/helpers/ee/ci/runners_helper_spec.rb' - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - - 'ee/spec/helpers/ee/trial_helper_spec.rb' - - 'ee/spec/helpers/ee/trial_registration_helper_spec.rb' - 'ee/spec/helpers/kerberos_helper_spec.rb' - 'ee/spec/helpers/license_helper_spec.rb' - 'ee/spec/helpers/roadmaps_helper_spec.rb' @@ -170,7 +168,6 @@ RSpec/VerifiedDoubles: - 'ee/spec/services/security/ingestion/ingest_report_slice_service_spec.rb' - 'ee/spec/services/security/orchestration/assign_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/on_demand_scan_pipeline_configuration_service_spec.rb' - - 'ee/spec/services/slash_commands/global_slack_handler_spec.rb' - 'ee/spec/services/status_page/publish_details_service_spec.rb' - 'ee/spec/services/status_page/publish_service_spec.rb' - 'ee/spec/services/status_page/trigger_publish_service_spec.rb' @@ -211,7 +208,6 @@ RSpec/VerifiedDoubles: - 'ee/spec/workers/ldap_group_sync_worker_spec.rb' - 'ee/spec/workers/merge_request_reset_approvals_worker_spec.rb' - 'ee/spec/workers/new_epic_worker_spec.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'qa/spec/git/repository_spec.rb' - 'qa/spec/page/base_spec.rb' - 'qa/spec/page/validator_spec.rb' @@ -377,7 +373,6 @@ RSpec/VerifiedDoubles: - 'spec/lib/gitlab/background_migration/base_job_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/base_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - 'spec/lib/gitlab/background_migration_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_import/project_creator_spec.rb' @@ -618,7 +613,6 @@ RSpec/VerifiedDoubles: - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kubernetes/config_map_spec.rb' - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - 'spec/lib/gitlab/kubernetes/namespace_spec.rb' - 'spec/lib/gitlab/lazy_spec.rb' - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' @@ -673,16 +667,12 @@ RSpec/VerifiedDoubles: - 'spec/lib/gitlab/pagination/offset_header_builder_spec.rb' - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' - 'spec/lib/gitlab/performance_bar/stats_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/maniphest_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/response_spec.rb' - - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - 'spec/lib/gitlab/polling_interval_spec.rb' - 'spec/lib/gitlab/popen/runner_spec.rb' - 'spec/lib/gitlab/process_management_spec.rb' - 'spec/lib/gitlab/profiler_spec.rb' - 'spec/lib/gitlab/prometheus/adapter_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/query_limiting/middleware_spec.rb' - 'spec/lib/gitlab/quick_actions/dsl_spec.rb' @@ -749,7 +739,6 @@ RSpec/VerifiedDoubles: - 'spec/models/ci/commit_with_pipeline_spec.rb' - 'spec/models/ci/group_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - - 'spec/models/clusters/applications/runner_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - 'spec/models/clusters/platforms/kubernetes_spec.rb' - 'spec/models/commit_spec.rb' @@ -1012,7 +1001,6 @@ RSpec/VerifiedDoubles: - 'spec/workers/bulk_imports/export_request_worker_spec.rb' - 'spec/workers/chat_notification_worker_spec.rb' - 'spec/workers/ci/build_prepare_worker_spec.rb' - - 'spec/workers/ci/create_cross_project_pipeline_worker_spec.rb' - 'spec/workers/ci/create_downstream_pipeline_worker_spec.rb' - 'spec/workers/ci/pipeline_bridge_status_worker_spec.rb' - 'spec/workers/ci/pipeline_success_unlock_artifacts_worker_spec.rb' diff --git a/.rubocop_todo/search/namespaced_class.yml b/.rubocop_todo/search/namespaced_class.yml new file mode 100644 index 00000000000..ad27603ad47 --- /dev/null +++ b/.rubocop_todo/search/namespaced_class.yml @@ -0,0 +1,231 @@ +--- +Search/NamespacedClass: + Details: grace period + Exclude: + - 'app/controllers/concerns/search_rate_limitable.rb' + - 'app/controllers/search_controller.rb' + - 'app/graphql/resolvers/concerns/project_search_arguments.rb' + - 'app/graphql/resolvers/concerns/search_arguments.rb' + - 'app/graphql/types/issuable_searchable_field_enum.rb' + - 'app/helpers/enable_search_settings_helper.rb' + - 'app/helpers/search_helper.rb' + - 'app/models/concerns/optionally_search.rb' + - 'app/models/concerns/pg_full_text_searchable.rb' + - 'app/models/issues/search_data.rb' + - 'app/presenters/packages/nuget/search_results_presenter.rb' + - 'app/presenters/search_service_presenter.rb' + - 'app/services/packages/conan/search_service.rb' + - 'app/services/packages/nuget/search_service.rb' + - 'app/services/search_service.rb' + - 'ee/app/controllers/admin/elasticsearch_controller.rb' + - 'ee/app/controllers/ee/search_controller.rb' + - 'ee/app/graphql/types/iteration_searchable_field_enum.rb' + - 'ee/app/helpers/ee/search_helper.rb' + - 'ee/app/models/concerns/elastic/application_versioned_search.rb' + - 'ee/app/models/concerns/elastic/namespace_update.rb' + - 'ee/app/models/concerns/elastic/projects_search.rb' + - 'ee/app/models/concerns/elastic/repositories_search.rb' + - 'ee/app/models/concerns/elastic/snippets_search.rb' + - 'ee/app/models/concerns/elastic/wiki_repositories_search.rb' + - 'ee/app/models/concerns/elasticsearch_indexed_container.rb' + - 'ee/app/models/concerns/zoekt/searchable_repository.rb' + - 'ee/app/models/elastic/group_index_status.rb' + - 'ee/app/models/elastic/index_setting.rb' + - 'ee/app/models/elastic/migration_record.rb' + - 'ee/app/models/elastic/reindexing_slice.rb' + - 'ee/app/models/elastic/reindexing_subtask.rb' + - 'ee/app/models/elastic/reindexing_task.rb' + - 'ee/app/models/elasticsearch_indexed_namespace.rb' + - 'ee/app/models/elasticsearch_indexed_project.rb' + - 'ee/app/models/zoekt/indexed_namespace.rb' + - 'ee/app/models/zoekt/shard.rb' + - 'ee/app/presenters/ee/search_service_presenter.rb' + - 'ee/app/services/ee/search_service.rb' + - 'ee/app/services/elastic/bookkeeping_shard_service.rb' + - 'ee/app/services/elastic/cluster_reindexing_service.rb' + - 'ee/app/services/elastic/data_migration_service.rb' + - 'ee/app/services/elastic/index_projects_by_id_service.rb' + - 'ee/app/services/elastic/index_projects_by_range_service.rb' + - 'ee/app/services/elastic/index_projects_service.rb' + - 'ee/app/services/elastic/indexing_control_service.rb' + - 'ee/app/services/elastic/process_bookkeeping_service.rb' + - 'ee/app/services/elastic/process_initial_bookkeeping_service.rb' + - 'ee/app/services/protected_environments/search_service.rb' + - 'ee/app/workers/concerns/elastic/bulk_cron_worker.rb' + - 'ee/app/workers/concerns/elastic/indexing_control.rb' + - 'ee/app/workers/concerns/elastic/migration_backfill_helper.rb' + - 'ee/app/workers/concerns/elastic/migration_helper.rb' + - 'ee/app/workers/concerns/elastic/migration_obsolete.rb' + - 'ee/app/workers/concerns/elastic/migration_options.rb' + - 'ee/app/workers/concerns/elastic/migration_remove_fields_helper.rb' + - 'ee/app/workers/concerns/elastic/migration_state.rb' + - 'ee/app/workers/concerns/elastic/migration_update_mappings_helper.rb' + - 'ee/app/workers/elastic/migration_worker.rb' + - 'ee/app/workers/elastic/namespace_update_worker.rb' + - 'ee/app/workers/elastic/project_transfer_worker.rb' + - 'ee/app/workers/elastic_association_indexer_worker.rb' + - 'ee/app/workers/elastic_cluster_reindexing_cron_worker.rb' + - 'ee/app/workers/elastic_commit_indexer_worker.rb' + - 'ee/app/workers/elastic_delete_project_worker.rb' + - 'ee/app/workers/elastic_full_index_worker.rb' + - 'ee/app/workers/elastic_index_bulk_cron_worker.rb' + - 'ee/app/workers/elastic_index_initial_bulk_cron_worker.rb' + - 'ee/app/workers/elastic_indexing_control_worker.rb' + - 'ee/app/workers/elastic_namespace_indexer_worker.rb' + - 'ee/app/workers/elastic_namespace_rollout_worker.rb' + - 'ee/app/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker.rb' + - 'ee/app/workers/elastic_wiki_indexer_worker.rb' + - 'ee/app/workers/zoekt/indexer_worker.rb' + - 'ee/lib/api/elasticsearch_indexed_namespaces.rb' + - 'ee/lib/ee/api/helpers/search_helpers.rb' + - 'ee/lib/ee/gitlab/group_search_results.rb' + - 'ee/lib/ee/gitlab/search/parsed_query.rb' + - 'ee/lib/ee/gitlab/search_context.rb' + - 'ee/lib/ee/gitlab/search_results.rb' + - 'ee/lib/ee/gitlab/snippet_search_results.rb' + - 'ee/lib/elastic/as_json.rb' + - 'ee/lib/elastic/class_proxy_util.rb' + - 'ee/lib/elastic/instance_proxy_util.rb' + - 'ee/lib/elastic/latest/application_class_proxy.rb' + - 'ee/lib/elastic/latest/application_instance_proxy.rb' + - 'ee/lib/elastic/latest/commit_config.rb' + - 'ee/lib/elastic/latest/config.rb' + - 'ee/lib/elastic/latest/custom_language_analyzers.rb' + - 'ee/lib/elastic/latest/document_should_be_deleted_from_index_error.rb' + - 'ee/lib/elastic/latest/git_class_proxy.rb' + - 'ee/lib/elastic/latest/git_instance_proxy.rb' + - 'ee/lib/elastic/latest/issue_class_proxy.rb' + - 'ee/lib/elastic/latest/issue_config.rb' + - 'ee/lib/elastic/latest/issue_instance_proxy.rb' + - 'ee/lib/elastic/latest/merge_request_class_proxy.rb' + - 'ee/lib/elastic/latest/merge_request_config.rb' + - 'ee/lib/elastic/latest/merge_request_instance_proxy.rb' + - 'ee/lib/elastic/latest/milestone_class_proxy.rb' + - 'ee/lib/elastic/latest/milestone_instance_proxy.rb' + - 'ee/lib/elastic/latest/note_class_proxy.rb' + - 'ee/lib/elastic/latest/note_config.rb' + - 'ee/lib/elastic/latest/note_instance_proxy.rb' + - 'ee/lib/elastic/latest/project_class_proxy.rb' + - 'ee/lib/elastic/latest/project_instance_proxy.rb' + - 'ee/lib/elastic/latest/project_wiki_class_proxy.rb' + - 'ee/lib/elastic/latest/project_wiki_instance_proxy.rb' + - 'ee/lib/elastic/latest/query_context.rb' + - 'ee/lib/elastic/latest/repository_class_proxy.rb' + - 'ee/lib/elastic/latest/repository_instance_proxy.rb' + - 'ee/lib/elastic/latest/routing.rb' + - 'ee/lib/elastic/latest/snippet_class_proxy.rb' + - 'ee/lib/elastic/latest/snippet_instance_proxy.rb' + - 'ee/lib/elastic/latest/state_filter.rb' + - 'ee/lib/elastic/latest/user_class_proxy.rb' + - 'ee/lib/elastic/latest/user_config.rb' + - 'ee/lib/elastic/latest/user_instance_proxy.rb' + - 'ee/lib/elastic/latest/wiki_config.rb' + - 'ee/lib/elastic/metrics_update_service.rb' + - 'ee/lib/elastic/migration.rb' + - 'ee/lib/elastic/multi_version_class_proxy.rb' + - 'ee/lib/elastic/multi_version_instance_proxy.rb' + - 'ee/lib/elastic/multi_version_util.rb' + - 'ee/lib/elastic/timeout_error.rb' + - 'ee/lib/elastic/v12p1/application_class_proxy.rb' + - 'ee/lib/elastic/v12p1/application_instance_proxy.rb' + - 'ee/lib/elastic/v12p1/config.rb' + - 'ee/lib/elastic/v12p1/issue_class_proxy.rb' + - 'ee/lib/elastic/v12p1/issue_instance_proxy.rb' + - 'ee/lib/elastic/v12p1/merge_request_class_proxy.rb' + - 'ee/lib/elastic/v12p1/merge_request_instance_proxy.rb' + - 'ee/lib/elastic/v12p1/milestone_class_proxy.rb' + - 'ee/lib/elastic/v12p1/milestone_instance_proxy.rb' + - 'ee/lib/elastic/v12p1/note_class_proxy.rb' + - 'ee/lib/elastic/v12p1/note_instance_proxy.rb' + - 'ee/lib/elastic/v12p1/project_class_proxy.rb' + - 'ee/lib/elastic/v12p1/project_instance_proxy.rb' + - 'ee/lib/elastic/v12p1/project_wiki_class_proxy.rb' + - 'ee/lib/elastic/v12p1/project_wiki_instance_proxy.rb' + - 'ee/lib/elastic/v12p1/repository_class_proxy.rb' + - 'ee/lib/elastic/v12p1/repository_instance_proxy.rb' + - 'ee/lib/elastic/v12p1/routing.rb' + - 'ee/lib/elastic/v12p1/snippet_class_proxy.rb' + - 'ee/lib/elastic/v12p1/snippet_instance_proxy.rb' + - 'ee/lib/elastic/v12p1/user_class_proxy.rb' + - 'ee/lib/elastic/v12p1/user_instance_proxy.rb' + - 'ee/lib/gem_extensions/elasticsearch/model/adapter/active_record/importing.rb' + - 'ee/lib/gem_extensions/elasticsearch/model/adapter/multiple/records.rb' + - 'ee/lib/gem_extensions/elasticsearch/model/client.rb' + - 'ee/lib/gem_extensions/elasticsearch/model/indexing/instance_methods.rb' + - 'ee/lib/gem_extensions/elasticsearch/model/response/records.rb' + - 'ee/lib/gitlab/elastic/bool_expr.rb' + - 'ee/lib/gitlab/elastic/bulk_indexer.rb' + - 'ee/lib/gitlab/elastic/client.rb' + - 'ee/lib/gitlab/elastic/document_reference.rb' + - 'ee/lib/gitlab/elastic/elasticsearch_enabled_cache.rb' + - 'ee/lib/gitlab/elastic/expr_name.rb' + - 'ee/lib/gitlab/elastic/group_search_results.rb' + - 'ee/lib/gitlab/elastic/helper.rb' + - 'ee/lib/gitlab/elastic/indexer.rb' + - 'ee/lib/gitlab/elastic/project_search_results.rb' + - 'ee/lib/gitlab/elastic/search_results.rb' + - 'ee/lib/gitlab/elastic/snippet_search_results.rb' + - 'ee/lib/gitlab/metrics/global_search_indexing_slis.rb' + - 'ee/lib/gitlab/metrics/samplers/global_search_sampler.rb' + - 'ee/lib/gitlab/search/aggregation.rb' + - 'ee/lib/gitlab/search/aggregation_parser.rb' + - 'ee/lib/gitlab/search/client.rb' + - 'ee/lib/gitlab/search/index_curator.rb' + - 'ee/lib/gitlab/search/recent_epics.rb' + - 'ee/lib/gitlab/usage/metrics/instrumentations/advanced_search/build_type_metric.rb' + - 'ee/lib/gitlab/usage/metrics/instrumentations/advanced_search/distribution_metric.rb' + - 'ee/lib/gitlab/usage/metrics/instrumentations/advanced_search/lucene_version_metric.rb' + - 'ee/lib/gitlab/usage/metrics/instrumentations/advanced_search/version_metric.rb' + - 'ee/lib/gitlab/zoekt/search_results.rb' + - 'ee/lib/system_check/app/advanced_search_migrations_check.rb' + - 'ee/lib/system_check/app/search_check.rb' + - 'ee/lib/zoekt/logger.rb' + - 'ee/spec/support/elastic.rb' + - 'ee/spec/support/elastic_query_name_inspector.rb' + - 'ee/spec/support/helpers/elasticsearch_helpers.rb' + - 'ee/spec/support/helpers/search_results_helpers.rb' + - 'ee/spec/support/zoekt.rb' + - 'lib/api/entities/nuget/search_result.rb' + - 'lib/api/entities/nuget/search_result_version.rb' + - 'lib/api/entities/nuget/search_results.rb' + - 'lib/api/helpers/search_helpers.rb' + - 'lib/gitlab/background_migration/backfill_imported_issue_search_data.rb' + - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' + - 'lib/gitlab/elasticsearch/logger.rb' + - 'lib/gitlab/empty_search_results.rb' + - 'lib/gitlab/github_import/clients/search_repos.rb' + - 'lib/gitlab/group_search_results.rb' + - 'lib/gitlab/metrics/elasticsearch_rack_middleware.rb' + - 'lib/gitlab/metrics/global_search_slis.rb' + - 'lib/gitlab/project_search_results.rb' + - 'lib/gitlab/redacted_search_results_logger.rb' + - 'lib/gitlab/search/abuse_detection.rb' + - 'lib/gitlab/search/abuse_validators/no_abusive_coercion_from_string_validator.rb' + - 'lib/gitlab/search/abuse_validators/no_abusive_term_length_validator.rb' + - 'lib/gitlab/search/found_blob.rb' + - 'lib/gitlab/search/found_wiki_page.rb' + - 'lib/gitlab/search/params.rb' + - 'lib/gitlab/search/parsed_query.rb' + - 'lib/gitlab/search/query.rb' + - 'lib/gitlab/search/recent_issues.rb' + - 'lib/gitlab/search/recent_items.rb' + - 'lib/gitlab/search/recent_merge_requests.rb' + - 'lib/gitlab/search/sort_options.rb' + - 'lib/gitlab/search_context.rb' + - 'lib/gitlab/search_results.rb' + - 'lib/gitlab/slash_commands/issue_search.rb' + - 'lib/gitlab/slash_commands/presenters/issue_search.rb' + - 'lib/gitlab/snippet_search_results.rb' + - 'lib/gitlab/usage_data_counters/search_counter.rb' + - 'lib/peek/views/elasticsearch.rb' + - 'lib/peek/views/zoekt.rb' + - 'qa/qa/ee/page/admin/settings/component/elasticsearch.rb' + - 'qa/qa/ee/resource/settings/elasticsearch.rb' + - 'qa/qa/ee/scenario/test/integration/elasticsearch.rb' + - 'qa/qa/page/search/results.rb' + - 'qa/qa/runtime/search.rb' + - 'spec/support/helpers/filtered_search_helpers.rb' + - 'spec/support/helpers/search_helpers.rb' + - 'spec/support/helpers/search_settings_helpers.rb' + - 'lib/sidebars/search/panel.rb' + - 'spec/lib/sidebars/search/panel_spec.rb' diff --git a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml new file mode 100644 index 00000000000..a7311c1c6df --- /dev/null +++ b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml @@ -0,0 +1,456 @@ +--- +SidekiqLoadBalancing/WorkerDataConsistency: + Details: grace period + Exclude: + - 'app/workers/admin_email_worker.rb' + - 'app/workers/analytics/usage_trends/count_job_trigger_worker.rb' + - 'app/workers/analytics/usage_trends/counter_job_worker.rb' + - 'app/workers/approve_blocked_pending_approval_users_worker.rb' + - 'app/workers/authorized_keys_worker.rb' + - 'app/workers/authorized_project_update/periodic_recalculate_worker.rb' + - 'app/workers/authorized_project_update/project_recalculate_worker.rb' + - 'app/workers/authorized_project_update/user_refresh_from_replica_worker.rb' + - 'app/workers/authorized_projects_worker.rb' + - 'app/workers/auto_devops/disable_worker.rb' + - 'app/workers/auto_merge_process_worker.rb' + - 'app/workers/build_success_worker.rb' + - 'app/workers/bulk_import_worker.rb' + - 'app/workers/bulk_imports/entity_worker.rb' + - 'app/workers/bulk_imports/export_request_worker.rb' + - 'app/workers/bulk_imports/pipeline_worker.rb' + - 'app/workers/bulk_imports/relation_export_worker.rb' + - 'app/workers/bulk_imports/stuck_import_worker.rb' + - 'app/workers/chaos/cpu_spin_worker.rb' + - 'app/workers/chaos/db_spin_worker.rb' + - 'app/workers/chaos/kill_worker.rb' + - 'app/workers/chaos/leak_mem_worker.rb' + - 'app/workers/chaos/sleep_worker.rb' + - 'app/workers/chat_notification_worker.rb' + - 'app/workers/ci/archive_traces_cron_worker.rb' + - 'app/workers/ci/build_finished_worker.rb' + - 'app/workers/ci/build_prepare_worker.rb' + - 'app/workers/ci/build_schedule_worker.rb' + - 'app/workers/ci/build_trace_chunk_flush_worker.rb' + - 'app/workers/ci/cancel_pipeline_worker.rb' + - 'app/workers/ci/cancel_redundant_pipelines_worker.rb' + - 'app/workers/ci/daily_build_group_report_results_worker.rb' + - 'app/workers/ci/delete_objects_worker.rb' + - 'app/workers/ci/delete_unit_tests_worker.rb' + - 'app/workers/ci/drop_pipeline_worker.rb' + - 'app/workers/ci/external_pull_requests/create_pipeline_worker.rb' + - 'app/workers/ci/initial_pipeline_process_worker.rb' + - 'app/workers/ci/job_artifacts/expire_project_build_artifacts_worker.rb' + - 'app/workers/ci/merge_requests/add_todo_when_build_fails_worker.rb' + - 'app/workers/ci/pending_builds/update_group_worker.rb' + - 'app/workers/ci/pending_builds/update_project_worker.rb' + - 'app/workers/ci/pipeline_artifacts/coverage_report_worker.rb' + - 'app/workers/ci/pipeline_artifacts/create_quality_report_worker.rb' + - 'app/workers/ci/pipeline_artifacts/expire_artifacts_worker.rb' + - 'app/workers/ci/pipeline_success_unlock_artifacts_worker.rb' + - 'app/workers/ci/ref_delete_unlock_artifacts_worker.rb' + - 'app/workers/ci/resource_groups/assign_resource_from_resource_group_worker.rb' + - 'app/workers/ci/runners/process_runner_version_update_worker.rb' + - 'app/workers/ci/schedule_delete_objects_cron_worker.rb' + - 'app/workers/ci/stuck_builds/drop_running_worker.rb' + - 'app/workers/ci/stuck_builds/drop_scheduled_worker.rb' + - 'app/workers/ci/test_failure_history_worker.rb' + - 'app/workers/ci_platform_metrics_update_cron_worker.rb' + - 'app/workers/cleanup_container_repository_worker.rb' + - 'app/workers/cluster_configure_istio_worker.rb' + - 'app/workers/cluster_install_app_worker.rb' + - 'app/workers/cluster_patch_app_worker.rb' + - 'app/workers/cluster_provision_worker.rb' + - 'app/workers/cluster_update_app_worker.rb' + - 'app/workers/cluster_upgrade_app_worker.rb' + - 'app/workers/cluster_wait_for_app_installation_worker.rb' + - 'app/workers/cluster_wait_for_app_update_worker.rb' + - 'app/workers/cluster_wait_for_ingress_ip_address_worker.rb' + - 'app/workers/clusters/agents/delete_expired_events_worker.rb' + - 'app/workers/clusters/applications/activate_integration_worker.rb' + - 'app/workers/clusters/applications/deactivate_integration_worker.rb' + - 'app/workers/clusters/applications/uninstall_worker.rb' + - 'app/workers/clusters/applications/wait_for_uninstall_app_worker.rb' + - 'app/workers/clusters/integrations/check_prometheus_health_worker.rb' + - 'app/workers/container_expiration_policies/cleanup_container_repository_worker.rb' + - 'app/workers/container_expiration_policy_worker.rb' + - 'app/workers/container_registry/cleanup_worker.rb' + - 'app/workers/container_registry/delete_container_repository_worker.rb' + - 'app/workers/container_registry/migration/enqueuer_worker.rb' + - 'app/workers/container_registry/migration/guard_worker.rb' + - 'app/workers/counters/cleanup_refresh_worker.rb' + - 'app/workers/create_commit_signature_worker.rb' + - 'app/workers/create_note_diff_file_worker.rb' + - 'app/workers/create_pipeline_worker.rb' + - 'app/workers/database/drop_detached_partitions_worker.rb' + - 'app/workers/database/partition_management_worker.rb' + - 'app/workers/delete_container_repository_worker.rb' + - 'app/workers/delete_diff_files_worker.rb' + - 'app/workers/delete_merged_branches_worker.rb' + - 'app/workers/delete_stored_files_worker.rb' + - 'app/workers/delete_user_worker.rb' + - 'app/workers/dependency_proxy/cleanup_blob_worker.rb' + - 'app/workers/dependency_proxy/cleanup_dependency_proxy_worker.rb' + - 'app/workers/dependency_proxy/cleanup_manifest_worker.rb' + - 'app/workers/dependency_proxy/image_ttl_group_policy_worker.rb' + - 'app/workers/deployments/link_merge_request_worker.rb' + - 'app/workers/deployments/update_environment_worker.rb' + - 'app/workers/design_management/copy_design_collection_worker.rb' + - 'app/workers/design_management/new_version_worker.rb' + - 'app/workers/destroy_pages_deployments_worker.rb' + - 'app/workers/detect_repository_languages_worker.rb' + - 'app/workers/disallow_two_factor_for_group_worker.rb' + - 'app/workers/disallow_two_factor_for_subgroups_worker.rb' + - 'app/workers/email_receiver_worker.rb' + - 'app/workers/emails_on_push_worker.rb' + - 'app/workers/environments/auto_delete_cron_worker.rb' + - 'app/workers/environments/auto_stop_cron_worker.rb' + - 'app/workers/environments/auto_stop_worker.rb' + - 'app/workers/environments/canary_ingress/update_worker.rb' + - 'app/workers/error_tracking_issue_link_worker.rb' + - 'app/workers/expire_build_artifacts_worker.rb' + - 'app/workers/export_csv_worker.rb' + - 'app/workers/file_hook_worker.rb' + - 'app/workers/flush_counter_increments_worker.rb' + - 'app/workers/gitlab/export/prune_project_export_jobs_worker.rb' + - 'app/workers/gitlab/github_gists_import/finish_import_worker.rb' + - 'app/workers/gitlab/github_gists_import/import_gist_worker.rb' + - 'app/workers/gitlab/github_gists_import/start_import_worker.rb' + - 'app/workers/gitlab/github_import/advance_stage_worker.rb' + - 'app/workers/gitlab/github_import/refresh_import_jid_worker.rb' + - 'app/workers/gitlab/github_import/stage/finish_import_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_attachments_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_base_data_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_collaborators_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_issue_events_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_issues_and_diff_notes_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_lfs_objects_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_notes_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_protected_branches_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_pull_requests_merged_by_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_pull_requests_review_requests_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_pull_requests_reviews_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_pull_requests_worker.rb' + - 'app/workers/gitlab/github_import/stage/import_repository_worker.rb' + - 'app/workers/gitlab/jira_import/advance_stage_worker.rb' + - 'app/workers/gitlab/jira_import/import_issue_worker.rb' + - 'app/workers/gitlab/jira_import/stage/start_import_worker.rb' + - 'app/workers/gitlab_performance_bar_stats_worker.rb' + - 'app/workers/gitlab_service_ping_worker.rb' + - 'app/workers/gitlab_shell_worker.rb' + - 'app/workers/google_cloud/create_cloudsql_instance_worker.rb' + - 'app/workers/group_destroy_worker.rb' + - 'app/workers/group_export_worker.rb' + - 'app/workers/group_import_worker.rb' + - 'app/workers/groups/update_statistics_worker.rb' + - 'app/workers/groups/update_two_factor_requirement_for_members_worker.rb' + - 'app/workers/hashed_storage/migrator_worker.rb' + - 'app/workers/hashed_storage/project_migrate_worker.rb' + - 'app/workers/hashed_storage/project_rollback_worker.rb' + - 'app/workers/hashed_storage/rollbacker_worker.rb' + - 'app/workers/import_export_project_cleanup_worker.rb' + - 'app/workers/import_issues_csv_worker.rb' + - 'app/workers/incident_management/add_severity_system_note_worker.rb' + - 'app/workers/incident_management/close_incident_worker.rb' + - 'app/workers/incident_management/pager_duty/process_incident_worker.rb' + - 'app/workers/incident_management/process_alert_worker_v2.rb' + - 'app/workers/integrations/execute_worker.rb' + - 'app/workers/integrations/irker_worker.rb' + - 'app/workers/invalid_gpg_signature_update_worker.rb' + - 'app/workers/issuable/label_links_destroy_worker.rb' + - 'app/workers/issuable_export_csv_worker.rb' + - 'app/workers/issuables/clear_groups_issue_counter_worker.rb' + - 'app/workers/issue_due_scheduler_worker.rb' + - 'app/workers/issues/close_worker.rb' + - 'app/workers/issues/placement_worker.rb' + - 'app/workers/issues/rebalancing_worker.rb' + - 'app/workers/jira_connect/forward_event_worker.rb' + - 'app/workers/jira_connect/retry_request_worker.rb' + - 'app/workers/loose_foreign_keys/cleanup_worker.rb' + - 'app/workers/mail_scheduler/issue_due_worker.rb' + - 'app/workers/mail_scheduler/notification_service_worker.rb' + - 'app/workers/member_invitation_reminder_emails_worker.rb' + - 'app/workers/members_destroyer/unassign_issuables_worker.rb' + - 'app/workers/merge_request_cleanup_refs_worker.rb' + - 'app/workers/merge_request_mergeability_check_worker.rb' + - 'app/workers/merge_requests/close_issue_worker.rb' + - 'app/workers/merge_requests/create_pipeline_worker.rb' + - 'app/workers/merge_requests/delete_source_branch_worker.rb' + - 'app/workers/merge_requests/handle_assignees_change_worker.rb' + - 'app/workers/merge_requests/resolve_todos_worker.rb' + - 'app/workers/merge_worker.rb' + - 'app/workers/metrics/dashboard/prune_old_annotations_worker.rb' + - 'app/workers/metrics/dashboard/schedule_annotations_prune_worker.rb' + - 'app/workers/metrics/dashboard/sync_dashboards_worker.rb' + - 'app/workers/migrate_external_diffs_worker.rb' + - 'app/workers/namespaces/in_product_marketing_emails_worker.rb' + - 'app/workers/namespaces/process_sync_events_worker.rb' + - 'app/workers/namespaces/prune_aggregation_schedules_worker.rb' + - 'app/workers/namespaces/schedule_aggregation_worker.rb' + - 'app/workers/new_issue_worker.rb' + - 'app/workers/new_merge_request_worker.rb' + - 'app/workers/new_note_worker.rb' + - 'app/workers/object_pool/create_worker.rb' + - 'app/workers/object_pool/destroy_worker.rb' + - 'app/workers/object_pool/join_worker.rb' + - 'app/workers/object_pool/schedule_join_worker.rb' + - 'app/workers/object_storage/migrate_uploads_worker.rb' + - 'app/workers/onboarding/issue_created_worker.rb' + - 'app/workers/onboarding/pipeline_created_worker.rb' + - 'app/workers/onboarding/progress_worker.rb' + - 'app/workers/onboarding/user_added_worker.rb' + - 'app/workers/packages/cleanup/execute_policy_worker.rb' + - 'app/workers/packages/cleanup_package_file_worker.rb' + - 'app/workers/packages/cleanup_package_registry_worker.rb' + - 'app/workers/packages/composer/cache_cleanup_worker.rb' + - 'app/workers/packages/composer/cache_update_worker.rb' + - 'app/workers/packages/debian/cleanup_dangling_package_files_worker.rb' + - 'app/workers/packages/debian/generate_distribution_worker.rb' + - 'app/workers/packages/debian/process_changes_worker.rb' + - 'app/workers/packages/debian/process_package_file_worker.rb' + - 'app/workers/packages/go/sync_packages_worker.rb' + - 'app/workers/packages/helm/extraction_worker.rb' + - 'app/workers/packages/maven/metadata/sync_worker.rb' + - 'app/workers/packages/nuget/extraction_worker.rb' + - 'app/workers/packages/rubygems/extraction_worker.rb' + - 'app/workers/pages_domain_removal_cron_worker.rb' + - 'app/workers/pages_domain_ssl_renewal_cron_worker.rb' + - 'app/workers/pages_domain_ssl_renewal_worker.rb' + - 'app/workers/pages_domain_verification_cron_worker.rb' + - 'app/workers/pages_domain_verification_worker.rb' + - 'app/workers/pages_worker.rb' + - 'app/workers/partition_creation_worker.rb' + - 'app/workers/personal_access_tokens/expired_notification_worker.rb' + - 'app/workers/personal_access_tokens/expiring_worker.rb' + - 'app/workers/pipeline_metrics_worker.rb' + - 'app/workers/pipeline_process_worker.rb' + - 'app/workers/pipeline_schedule_worker.rb' + - 'app/workers/post_receive.rb' + - 'app/workers/process_commit_worker.rb' + - 'app/workers/project_cache_worker.rb' + - 'app/workers/project_destroy_worker.rb' + - 'app/workers/project_export_worker.rb' + - 'app/workers/projects/after_import_worker.rb' + - 'app/workers/projects/delete_branch_worker.rb' + - 'app/workers/projects/finalize_project_statistics_refresh_worker.rb' + - 'app/workers/projects/import_export/create_relation_exports_worker.rb' + - 'app/workers/projects/import_export/parallel_project_export_worker.rb' + - 'app/workers/projects/import_export/relation_export_worker.rb' + - 'app/workers/projects/import_export/wait_relation_exports_worker.rb' + - 'app/workers/projects/inactive_projects_deletion_cron_worker.rb' + - 'app/workers/projects/post_creation_worker.rb' + - 'app/workers/projects/process_sync_events_worker.rb' + - 'app/workers/projects/record_target_platforms_worker.rb' + - 'app/workers/projects/refresh_build_artifacts_size_statistics_worker.rb' + - 'app/workers/projects/schedule_bulk_repository_shard_moves_worker.rb' + - 'app/workers/projects/schedule_refresh_build_artifacts_size_statistics_worker.rb' + - 'app/workers/propagate_integration_group_worker.rb' + - 'app/workers/propagate_integration_inherit_descendant_worker.rb' + - 'app/workers/propagate_integration_inherit_worker.rb' + - 'app/workers/propagate_integration_project_worker.rb' + - 'app/workers/propagate_integration_worker.rb' + - 'app/workers/prune_old_events_worker.rb' + - 'app/workers/purge_dependency_proxy_cache_worker.rb' + - 'app/workers/rebase_worker.rb' + - 'app/workers/releases/create_evidence_worker.rb' + - 'app/workers/releases/manage_evidence_worker.rb' + - 'app/workers/remote_mirror_notification_worker.rb' + - 'app/workers/remove_expired_group_links_worker.rb' + - 'app/workers/remove_expired_members_worker.rb' + - 'app/workers/remove_unaccepted_member_invites_worker.rb' + - 'app/workers/remove_unreferenced_lfs_objects_worker.rb' + - 'app/workers/repository_archive_cache_worker.rb' + - 'app/workers/repository_check/batch_worker.rb' + - 'app/workers/repository_check/clear_worker.rb' + - 'app/workers/repository_check/dispatch_worker.rb' + - 'app/workers/repository_check/single_repository_worker.rb' + - 'app/workers/repository_cleanup_worker.rb' + - 'app/workers/repository_fork_worker.rb' + - 'app/workers/repository_import_worker.rb' + - 'app/workers/repository_update_remote_mirror_worker.rb' + - 'app/workers/run_pipeline_schedule_worker.rb' + - 'app/workers/schedule_merge_request_cleanup_refs_worker.rb' + - 'app/workers/schedule_migrate_external_diffs_worker.rb' + - 'app/workers/service_desk_email_receiver_worker.rb' + - 'app/workers/snippets/schedule_bulk_repository_shard_moves_worker.rb' + - 'app/workers/ssh_keys/expired_notification_worker.rb' + - 'app/workers/ssh_keys/expiring_soon_notification_worker.rb' + - 'app/workers/stage_update_worker.rb' + - 'app/workers/stuck_ci_jobs_worker.rb' + - 'app/workers/stuck_export_jobs_worker.rb' + - 'app/workers/stuck_merge_jobs_worker.rb' + - 'app/workers/system_hook_push_worker.rb' + - 'app/workers/tasks_to_be_done/create_worker.rb' + - 'app/workers/terraform/states/destroy_worker.rb' + - 'app/workers/todos_destroyer/confidential_issue_worker.rb' + - 'app/workers/todos_destroyer/destroyed_designs_worker.rb' + - 'app/workers/todos_destroyer/destroyed_issuable_worker.rb' + - 'app/workers/todos_destroyer/entity_leave_worker.rb' + - 'app/workers/todos_destroyer/group_private_worker.rb' + - 'app/workers/todos_destroyer/private_features_worker.rb' + - 'app/workers/todos_destroyer/project_private_worker.rb' + - 'app/workers/trending_projects_worker.rb' + - 'app/workers/update_container_registry_info_worker.rb' + - 'app/workers/update_external_pull_requests_worker.rb' + - 'app/workers/update_head_pipeline_for_merge_request_worker.rb' + - 'app/workers/update_highest_role_worker.rb' + - 'app/workers/update_merge_requests_worker.rb' + - 'app/workers/update_project_statistics_worker.rb' + - 'app/workers/upload_checksum_worker.rb' + - 'app/workers/user_status_cleanup/batch_worker.rb' + - 'app/workers/users/create_statistics_worker.rb' + - 'app/workers/users/deactivate_dormant_users_worker.rb' + - 'app/workers/users/migrate_records_to_ghost_user_in_batches_worker.rb' + - 'app/workers/wait_for_cluster_creation_worker.rb' + - 'app/workers/web_hooks/log_destroy_worker.rb' + - 'app/workers/web_hooks/log_execution_worker.rb' + - 'app/workers/work_items/import_work_items_csv_worker.rb' + - 'app/workers/x509_certificate_revoke_worker.rb' + - 'app/workers/x509_issuer_crl_check_worker.rb' + - 'ee/app/workers/active_user_count_threshold_worker.rb' + - 'ee/app/workers/adjourned_group_deletion_worker.rb' + - 'ee/app/workers/adjourned_project_deletion_worker.rb' + - 'ee/app/workers/adjourned_projects_deletion_cron_worker.rb' + - 'ee/app/workers/admin_emails_worker.rb' + - 'ee/app/workers/analytics/code_review_metrics_worker.rb' + - 'ee/app/workers/analytics/cycle_analytics/consistency_worker.rb' + - 'ee/app/workers/analytics/cycle_analytics/incremental_worker.rb' + - 'ee/app/workers/analytics/cycle_analytics/reaggregation_worker.rb' + - 'ee/app/workers/analytics/devops_adoption/create_all_snapshots_worker.rb' + - 'ee/app/workers/analytics/devops_adoption/create_snapshot_worker.rb' + - 'ee/app/workers/app_sec/dast/profile_schedule_worker.rb' + - 'ee/app/workers/app_sec/dast/scanner_profiles_builds/consistency_worker.rb' + - 'ee/app/workers/app_sec/dast/scans/consistency_worker.rb' + - 'ee/app/workers/app_sec/dast/site_profiles_builds/consistency_worker.rb' + - 'ee/app/workers/approval_rules/external_approval_rule_payload_worker.rb' + - 'ee/app/workers/arkose/blocked_users_report_worker.rb' + - 'ee/app/workers/auth/saml_group_sync_worker.rb' + - 'ee/app/workers/automation/execute_rule_worker.rb' + - 'ee/app/workers/ci/batch_reset_minutes_worker.rb' + - 'ee/app/workers/ci/minutes/refresh_cached_data_worker.rb' + - 'ee/app/workers/ci/minutes/update_project_and_namespace_usage_worker.rb' + - 'ee/app/workers/ci/sync_reports_to_report_approval_rules_worker.rb' + - 'ee/app/workers/ci/upstream_projects_subscriptions_cleanup_worker.rb' + - 'ee/app/workers/clear_shared_runners_minutes_worker.rb' + - 'ee/app/workers/compliance_management/chain_of_custody_report_worker.rb' + - 'ee/app/workers/compliance_management/merge_requests/compliance_violations_consistency_worker.rb' + - 'ee/app/workers/compliance_management/merge_requests/compliance_violations_worker.rb' + - 'ee/app/workers/compliance_management/update_default_framework_worker.rb' + - 'ee/app/workers/create_github_webhook_worker.rb' + - 'ee/app/workers/dependencies/destroy_export_worker.rb' + - 'ee/app/workers/dependencies/export_worker.rb' + - 'ee/app/workers/deployments/auto_rollback_worker.rb' + - 'ee/app/workers/dora/daily_metrics/refresh_worker.rb' + - 'ee/app/workers/elastic/migration_worker.rb' + - 'ee/app/workers/elastic_association_indexer_worker.rb' + - 'ee/app/workers/elastic_cluster_reindexing_cron_worker.rb' + - 'ee/app/workers/elastic_commit_indexer_worker.rb' + - 'ee/app/workers/elastic_delete_project_worker.rb' + - 'ee/app/workers/elastic_full_index_worker.rb' + - 'ee/app/workers/elastic_indexing_control_worker.rb' + - 'ee/app/workers/elastic_namespace_indexer_worker.rb' + - 'ee/app/workers/elastic_namespace_rollout_worker.rb' + - 'ee/app/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker.rb' + - 'ee/app/workers/elastic_wiki_indexer_worker.rb' + - 'ee/app/workers/emails/abandoned_trial_emails_cron_worker.rb' + - 'ee/app/workers/epics/new_epic_issue_worker.rb' + - 'ee/app/workers/epics/update_cached_metadata_worker.rb' + - 'ee/app/workers/epics/update_epics_dates_worker.rb' + - 'ee/app/workers/geo/batch/project_registry_scheduler_worker.rb' + - 'ee/app/workers/geo/batch/project_registry_worker.rb' + - 'ee/app/workers/geo/batch_event_create_worker.rb' + - 'ee/app/workers/geo/container_repository_sync_worker.rb' + - 'ee/app/workers/geo/create_repository_updated_event_worker.rb' + - 'ee/app/workers/geo/design_repository_sync_worker.rb' + - 'ee/app/workers/geo/destroy_worker.rb' + - 'ee/app/workers/geo/event_worker.rb' + - 'ee/app/workers/geo/file_registry_removal_worker.rb' + - 'ee/app/workers/geo/file_removal_worker.rb' + - 'ee/app/workers/geo/hashed_storage_attachments_migration_worker.rb' + - 'ee/app/workers/geo/hashed_storage_migration_worker.rb' + - 'ee/app/workers/geo/metrics_update_worker.rb' + - 'ee/app/workers/geo/project_sync_worker.rb' + - 'ee/app/workers/geo/prune_event_log_worker.rb' + - 'ee/app/workers/geo/rename_repository_worker.rb' + - 'ee/app/workers/geo/repositories_clean_up_worker.rb' + - 'ee/app/workers/geo/repository_cleanup_worker.rb' + - 'ee/app/workers/geo/repository_verification/primary/single_worker.rb' + - 'ee/app/workers/geo/repository_verification/secondary/single_worker.rb' + - 'ee/app/workers/geo/reverification_batch_worker.rb' + - 'ee/app/workers/geo/scheduler/per_shard_scheduler_worker.rb' + - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' + - 'ee/app/workers/geo/secondary/registry_consistency_worker.rb' + - 'ee/app/workers/geo/secondary_usage_data_cron_worker.rb' + - 'ee/app/workers/geo/sidekiq_cron_config_worker.rb' + - 'ee/app/workers/geo/sync_timeout_cron_worker.rb' + - 'ee/app/workers/geo/verification_batch_worker.rb' + - 'ee/app/workers/geo/verification_cron_worker.rb' + - 'ee/app/workers/geo/verification_state_backfill_worker.rb' + - 'ee/app/workers/geo/verification_timeout_worker.rb' + - 'ee/app/workers/geo/verification_worker.rb' + - 'ee/app/workers/geo_repository_destroy_worker.rb' + - 'ee/app/workers/gitlab_subscriptions/schedule_refresh_seats_worker.rb' + - 'ee/app/workers/gitlab_subscriptions/trials/apply_trial_worker.rb' + - 'ee/app/workers/group_saml_group_sync_worker.rb' + - 'ee/app/workers/groups/schedule_bulk_repository_shard_moves_worker.rb' + - 'ee/app/workers/historical_data_worker.rb' + - 'ee/app/workers/import_software_licenses_worker.rb' + - 'ee/app/workers/incident_management/apply_incident_sla_exceeded_label_worker.rb' + - 'ee/app/workers/incident_management/incident_sla_exceeded_check_worker.rb' + - 'ee/app/workers/incident_management/oncall_rotations/persist_all_rotations_shifts_job.rb' + - 'ee/app/workers/incident_management/oncall_rotations/persist_shifts_job.rb' + - 'ee/app/workers/incident_management/pending_escalations/alert_check_worker.rb' + - 'ee/app/workers/incident_management/pending_escalations/alert_create_worker.rb' + - 'ee/app/workers/incident_management/pending_escalations/issue_check_worker.rb' + - 'ee/app/workers/incident_management/pending_escalations/issue_create_worker.rb' + - 'ee/app/workers/incident_management/pending_escalations/schedule_check_cron_worker.rb' + - 'ee/app/workers/iterations/cadences/create_iterations_worker.rb' + - 'ee/app/workers/iterations/cadences/schedule_create_iterations_worker.rb' + - 'ee/app/workers/iterations/roll_over_issues_worker.rb' + - 'ee/app/workers/iterations_update_status_worker.rb' + - 'ee/app/workers/ldap_all_groups_sync_worker.rb' + - 'ee/app/workers/ldap_group_sync_worker.rb' + - 'ee/app/workers/ldap_sync_worker.rb' + - 'ee/app/workers/merge_request_reset_approvals_worker.rb' + - 'ee/app/workers/merge_requests/capture_suggested_reviewers_accepted_worker.rb' + - 'ee/app/workers/merge_requests/fetch_suggested_reviewers_worker.rb' + - 'ee/app/workers/merge_requests/llm/summarize_merge_request_worker.rb' + - 'ee/app/workers/merge_requests/sync_code_owner_approval_rules_worker.rb' + - 'ee/app/workers/merge_trains/refresh_worker.rb' + - 'ee/app/workers/namespaces/free_user_cap/backfill_notification_clearing_jobs_worker.rb' + - 'ee/app/workers/namespaces/free_user_cap/backfill_notification_jobs_worker.rb' + - 'ee/app/workers/namespaces/free_user_cap/notification_clearing_worker.rb' + - 'ee/app/workers/namespaces/free_user_cap/over_limit_notification_worker.rb' + - 'ee/app/workers/namespaces/sync_namespace_name_worker.rb' + - 'ee/app/workers/new_epic_worker.rb' + - 'ee/app/workers/onboarding/create_learn_gitlab_worker.rb' + - 'ee/app/workers/package_metadata/sync_worker.rb' + - 'ee/app/workers/personal_access_tokens/groups/policy_worker.rb' + - 'ee/app/workers/personal_access_tokens/instance/policy_worker.rb' + - 'ee/app/workers/projects/register_suggested_reviewers_project_worker.rb' + - 'ee/app/workers/refresh_license_compliance_checks_worker.rb' + - 'ee/app/workers/requirements_management/import_requirements_csv_worker.rb' + - 'ee/app/workers/requirements_management/process_requirements_reports_worker.rb' + - 'ee/app/workers/sbom/ingest_reports_worker.rb' + - 'ee/app/workers/scan_security_report_secrets_worker.rb' + - 'ee/app/workers/search/index_curation_worker.rb' + - 'ee/app/workers/security/auto_fix_worker.rb' + - 'ee/app/workers/security/create_orchestration_policy_worker.rb' + - 'ee/app/workers/security/orchestration_policy_rule_schedule_worker.rb' + - 'ee/app/workers/security/process_scan_result_policy_worker.rb' + - 'ee/app/workers/security/scans/purge_by_job_id_worker.rb' + - 'ee/app/workers/security/scans/purge_worker.rb' + - 'ee/app/workers/security/store_scans_worker.rb' + - 'ee/app/workers/security/sync_scan_policies_worker.rb' + - 'ee/app/workers/security/track_secure_scans_worker.rb' + - 'ee/app/workers/set_user_status_based_on_user_cap_setting_worker.rb' + - 'ee/app/workers/status_page/publish_worker.rb' + - 'ee/app/workers/store_security_reports_worker.rb' + - 'ee/app/workers/sync_seat_link_request_worker.rb' + - 'ee/app/workers/sync_seat_link_worker.rb' + - 'ee/app/workers/todos_destroyer/confidential_epic_worker.rb' + - 'ee/app/workers/vulnerabilities/historical_statistics/deletion_worker.rb' + - 'ee/app/workers/vulnerabilities/statistics/adjustment_worker.rb' + - 'ee/app/workers/vulnerabilities/statistics/schedule_worker.rb' + - 'ee/app/workers/vulnerability_exports/export_deletion_worker.rb' + - 'ee/app/workers/vulnerability_exports/export_worker.rb' + - 'ee/app/workers/zoekt/indexer_worker.rb' diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml index c49901db696..4257adbdc6f 100644 --- a/.rubocop_todo/style/class_and_module_children.yml +++ b/.rubocop_todo/style/class_and_module_children.yml @@ -90,7 +90,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/import/gitlab_projects_controller.rb' - 'app/controllers/import/history_controller.rb' - 'app/controllers/import/manifest_controller.rb' - - 'app/controllers/import/phabricator_controller.rb' - 'app/controllers/import/url_controller.rb' - 'app/controllers/jira_connect/app_descriptor_controller.rb' - 'app/controllers/jira_connect/application_controller.rb' @@ -99,7 +98,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/jira_connect/installations_controller.rb' - 'app/controllers/jira_connect/oauth_callbacks_controller.rb' - 'app/controllers/jira_connect/subscriptions_controller.rb' - - 'app/controllers/jira_connect/users_controller.rb' - 'app/controllers/ldap/omniauth_callbacks_controller.rb' - 'app/controllers/oauth/applications_controller.rb' - 'app/controllers/oauth/authorizations_controller.rb' @@ -121,7 +119,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/profiles/personal_access_tokens_controller.rb' - 'app/controllers/profiles/preferences_controller.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' - - 'app/controllers/profiles/u2f_registrations_controller.rb' - 'app/controllers/profiles/webauthn_registrations_controller.rb' - 'app/controllers/projects/alert_management_controller.rb' - 'app/controllers/projects/analytics/cycle_analytics/stages_controller.rb' @@ -285,7 +282,6 @@ Style/ClassAndModuleChildren: - 'app/models/packages/build_info.rb' - 'app/models/packages/conan/file_metadatum.rb' - 'app/models/packages/conan/metadatum.rb' - - 'app/models/packages/debian/file_metadatum.rb' - 'app/models/packages/debian/group_architecture.rb' - 'app/models/packages/debian/group_component.rb' - 'app/models/packages/debian/group_component_file.rb' @@ -369,7 +365,6 @@ Style/ClassAndModuleChildren: - 'ee/app/controllers/admin/push_rules_controller.rb' - 'ee/app/controllers/admin/subscriptions_controller.rb' - 'ee/app/controllers/admin/user_permission_exports_controller.rb' - - 'ee/app/controllers/concerns/registrations/verification.rb' - 'ee/app/controllers/ee/profiles/accounts_controller.rb' - 'ee/app/controllers/ee/profiles/preferences_controller.rb' - 'ee/app/controllers/ee/projects/analytics/cycle_analytics/summary_controller.rb' @@ -435,7 +430,6 @@ Style/ClassAndModuleChildren: - 'ee/app/controllers/projects/vulnerability_feedback_controller.rb' - 'ee/app/finders/ee/group_members_finder.rb' - 'ee/app/graphql/mutations/app_sec/fuzzing/coverage/corpus/create.rb' - - 'ee/app/helpers/ee/groups/analytics/cycle_analytics_helper.rb' - 'ee/app/helpers/ee/groups/group_members_helper.rb' - 'ee/app/helpers/ee/security_orchestration_helper.rb' - 'ee/app/helpers/groups/ldap_sync_helper.rb' @@ -505,15 +499,11 @@ Style/ClassAndModuleChildren: - 'ee/lib/ee/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/base_query_builder.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/records_fetcher.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'ee/lib/ee/gitlab/throttle.rb' - 'ee/lib/gitlab/path_locks_finder.rb' - 'lib/api/error_tracking/client_keys.rb' - 'lib/api/error_tracking/collector.rb' - 'lib/api/error_tracking/project_settings.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/ci/badge/base.rb' - 'lib/gitlab/ci/badge/coverage/metadata.rb' @@ -539,7 +529,6 @@ Style/ClassAndModuleChildren: - 'lib/gitlab/ci/warnings.rb' - 'lib/gitlab/config_helper.rb' - 'lib/gitlab/instrumentation/elasticsearch_transport.rb' - - 'lib/gitlab/serverless/service.rb' - 'lib/gitlab/usage_data_counters/base_counter.rb' - 'lib/gitlab/usage_data_counters/ci_template_unique_counter.rb' - 'lib/gitlab/usage_data_counters/cycle_analytics_counter.rb' diff --git a/.rubocop_todo/style/empty_else.yml b/.rubocop_todo/style/empty_else.yml index 97f974c9a19..e2074f4f2ef 100644 --- a/.rubocop_todo/style/empty_else.yml +++ b/.rubocop_todo/style/empty_else.yml @@ -2,55 +2,27 @@ # Cop supports --autocorrect. Style/EmptyElse: Exclude: - - 'app/controllers/concerns/issuable_collections_action.rb' - 'app/controllers/concerns/sends_blob.rb' - 'app/controllers/google_api/authorizations_controller.rb' - - 'app/controllers/projects_controller.rb' - 'app/finders/group_finder.rb' - - 'app/finders/merge_requests_finder/params.rb' - - 'app/finders/snippets_finder.rb' - - 'app/graphql/mutations/concerns/mutations/spam_protection.rb' - 'app/graphql/resolvers/group_milestones_resolver.rb' - 'app/graphql/types/ci/detailed_status_type.rb' - - 'app/graphql/types/packages/package_base_type.rb' - - 'app/graphql/types/packages/package_file_type.rb' - - 'app/helpers/submodule_helper.rb' - - 'app/models/commit.rb' - 'app/models/legacy_diff_discussion.rb' - - 'app/models/note.rb' - 'app/models/performance_monitoring/prometheus_dashboard.rb' - - 'app/models/repository.rb' - 'app/models/resource_state_event.rb' - 'app/models/resource_timebox_event.rb' - 'app/services/award_emojis/add_service.rb' - - 'app/services/merge_requests/update_service.rb' - 'app/workers/post_receive.rb' - 'config/initializers/doorkeeper_openid_connect.rb' - - 'ee/app/controllers/admin/audit_logs_controller.rb' - - 'ee/app/controllers/ee/groups_controller.rb' - 'ee/app/helpers/ee/kerberos_helper.rb' - - 'ee/app/helpers/ee/trial_helper.rb' - - 'ee/app/models/ee/audit_event.rb' - - 'ee/app/services/ee/users/update_service.rb' - - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/app/services/gitlab_subscriptions/check_future_renewal_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - 'ee/lib/elastic/latest/note_instance_proxy.rb' - 'ee/lib/gitlab/analytics/cycle_analytics/summary/change_failure_rate.rb' - - 'ee/lib/gitlab/geo/oauth/logout_token.rb' - - 'lib/api/subscriptions.rb' - 'lib/gitlab/auth/o_auth/provider.rb' - 'lib/gitlab/ci/variables/collection.rb' - 'lib/gitlab/database/load_balancing/sidekiq_server_middleware.rb' - 'lib/gitlab/database/sha256_attribute.rb' - - 'lib/gitlab/diff/parser.rb' - 'lib/gitlab/git.rb' - - 'lib/gitlab/git/ref.rb' - - 'lib/gitlab/git/tag.rb' - - 'lib/gitlab/pagination/keyset/paginator.rb' - 'lib/gitlab/sidekiq_daemon/monitor.rb' - - 'lib/gitlab/x509/signature.rb' - 'lib/peek/views/external_http.rb' - - 'qa/qa/support/loglinking.rb' - - 'spec/support/helpers/api_internal_base_helpers.rb' - - 'spec/support/shared_examples/requests/api/snippets_shared_examples.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index 7b0390f7d31..adf3e8ee9b2 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -4,7 +4,6 @@ Style/EmptyMethod: Exclude: - 'app/controllers/admin/application_settings/appearances_controller.rb' - 'app/controllers/admin/applications_controller.rb' - - 'app/controllers/admin/broadcast_messages_controller.rb' - 'app/controllers/admin/deploy_keys_controller.rb' - 'app/controllers/admin/identities_controller.rb' - 'app/controllers/admin/labels_controller.rb' @@ -21,7 +20,6 @@ Style/EmptyMethod: - 'app/controllers/import/bitbucket_server_controller.rb' - 'app/controllers/import/fogbugz_controller.rb' - 'app/controllers/import/manifest_controller.rb' - - 'app/controllers/import/phabricator_controller.rb' - 'app/controllers/profiles/chat_names_controller.rb' - 'app/controllers/profiles/passwords_controller.rb' - 'app/controllers/profiles/preferences_controller.rb' @@ -49,7 +47,6 @@ Style/EmptyMethod: - 'app/controllers/projects/triggers_controller.rb' - 'app/controllers/pwa_controller.rb' - 'app/controllers/search_controller.rb' - - 'app/experiments/security_actions_continuous_onboarding_experiment.rb' - 'app/graphql/resolvers/concerns/caching_array_resolver.rb' - 'app/helpers/subscribable_banner_helper.rb' - 'app/helpers/users/callouts_helper.rb' @@ -71,8 +68,6 @@ Style/EmptyMethod: - 'app/services/issuable_base_service.rb' - 'app/services/projects/transfer_service.rb' - 'app/workers/namespaces/root_statistics_worker.rb' - - 'db/migrate/20211012134316_clean_up_migrate_merge_request_diff_commit_users.rb' - - 'db/post_migrate/20211028100843_delete_issue_merge_request_taggings_records.rb' - 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb' - 'db/post_migrate/20220412143552_consume_remaining_encrypt_integration_property_jobs.rb' - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' @@ -85,7 +80,6 @@ Style/EmptyMethod: - 'ee/app/controllers/groups/analytics/cycle_analytics_controller.rb' - 'ee/app/controllers/groups/analytics/devops_adoption_controller.rb' - 'ee/app/controllers/groups/compliance_frameworks_controller.rb' - - 'ee/app/controllers/groups/feature_discovery_moments_controller.rb' - 'ee/app/controllers/groups/ldap_group_links_controller.rb' - 'ee/app/controllers/groups/settings/reporting_controller.rb' - 'ee/app/controllers/projects/analytics/code_reviews_controller.rb' @@ -102,8 +96,6 @@ Style/EmptyMethod: - 'ee/app/controllers/projects/security/sast_configuration_controller.rb' - 'ee/app/controllers/projects/settings/slacks_controller.rb' - 'ee/app/controllers/subscriptions/groups_controller.rb' - - 'ee/app/controllers/trials_controller.rb' - - 'ee/app/experiments/cart_abandonment_modal_experiment.rb' - 'ee/app/models/ee/epic.rb' - 'ee/app/services/feature_flag_issues/destroy_service.rb' - 'ee/db/geo/migrate/20170906174622_remove_duplicates_from_project_registry.rb' @@ -117,16 +109,12 @@ Style/EmptyMethod: - 'lib/gitlab/background_migration/create_security_setting.rb' - 'lib/gitlab/background_migration/delete_approval_rules_with_vulnerability.rb' - 'lib/gitlab/background_migration/delete_invalid_epic_issues.rb' - - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' - 'lib/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - 'lib/gitlab/ci/config/entry/need.rb' - 'lib/gitlab/ci/config/entry/rules/rule.rb' - 'lib/gitlab/ci/limit.rb' diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index 591c228f18a..5027e699ae7 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -6,7 +6,6 @@ Style/ExplicitBlockArgument: - 'app/controllers/admin/batched_jobs_controller.rb' - 'app/controllers/application_controller.rb' - 'app/models/application_record.rb' - - 'app/models/broadcast_message.rb' - 'app/models/ci/build.rb' - 'app/models/ci/build_trace_chunks/redis.rb' - 'app/models/ci/build_trace_chunks/redis_trace_chunks.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index 101a0b6429f..9d202dcd7fb 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -109,7 +109,6 @@ Style/FormatString: - 'app/models/project.rb' - 'app/models/resource_event.rb' - 'app/models/sent_notification.rb' - - 'app/models/serverless/domain.rb' - 'app/models/user.rb' - 'app/models/wiki.rb' - 'app/models/wiki_page.rb' @@ -145,7 +144,6 @@ Style/FormatString: - 'app/services/system_notes/design_management_service.rb' - 'app/services/timelogs/create_service.rb' - 'app/services/users/banned_user_base_service.rb' - - 'app/services/work_items/parent_links/create_service.rb' - 'app/services/work_items/widgets/hierarchy_service/base_service.rb' - 'app/validators/addressable_url_validator.rb' - 'app/validators/any_field_validator.rb' @@ -158,7 +156,6 @@ Style/FormatString: - 'danger/roulette/Dangerfile' - 'ee/app/components/billing/plan_component.rb' - 'ee/app/components/namespaces/free_user_cap/enforcement_alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/notification_alert_component.rb' - 'ee/app/components/namespaces/free_user_cap/usage_quota_alert_component.rb' - 'ee/app/components/namespaces/free_user_cap/usage_quota_trial_alert_component.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' @@ -218,7 +215,6 @@ Style/FormatString: - 'ee/app/services/timebox_report_service.rb' - 'ee/app/services/vulnerabilities/destroy_dismissal_feedback_service.rb' - 'ee/app/services/vulnerabilities/dismiss_service.rb' - - 'ee/app/services/vulnerabilities/finding_dismiss_service.rb' - 'ee/app/services/vulnerabilities/historical_statistics/adjustment_service.rb' - 'ee/app/services/vulnerabilities/statistics/adjustment_service.rb' - 'ee/app/services/vulnerability_external_issue_links/create_service.rb' @@ -269,7 +265,6 @@ Style/FormatString: - 'lib/gitlab/database/postgres_hll/batch_distinct_counter.rb' - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' - 'lib/gitlab/database_importers/instance_administrators/create_group.rb' - - 'lib/gitlab/database_importers/self_monitoring/project/create_service.rb' - 'lib/gitlab/email/message/in_product_marketing/base.rb' - 'lib/gitlab/email/message/in_product_marketing/create.rb' - 'lib/gitlab/email/message/in_product_marketing/helper.rb' @@ -307,7 +302,6 @@ Style/FormatString: - 'spec/features/admin/admin_users_spec.rb' - 'spec/features/groups/import_export/connect_instance_spec.rb' - 'spec/features/issues/form_spec.rb' - - 'spec/finders/serverless_domain_finder_spec.rb' - 'spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb' - 'spec/helpers/profiles_helper_spec.rb' - 'spec/lib/api/entities/release_spec.rb' @@ -316,7 +310,6 @@ Style/FormatString: - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' - 'spec/models/integrations/bamboo_spec.rb' - 'spec/models/integrations/datadog_spec.rb' - - 'spec/models/serverless/domain_spec.rb' - 'spec/requests/api/graphql/project/jira_projects_spec.rb' - 'spec/services/groups/import_export/export_service_spec.rb' - 'spec/services/projects/import_export/export_service_spec.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index a6461e7b177..50a823c9ee8 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -260,10 +260,6 @@ Style/GuardClause: - 'config/initializers/postgresql_cte.rb' - 'config/object_store_settings.rb' - 'danger/feature_flag/Dangerfile' - - 'db/migrate/20210830140524_add_state_to_member.rb' - - 'db/migrate/20211202094944_move_loose_fk_deleted_records_to_dynamic_schema.rb' - - 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb' - - 'db/post_migrate/20210907211557_finalize_ci_builds_bigint_conversion.rb' - 'ee/app/controllers/admin/emails_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' - 'ee/app/controllers/admin/geo/replicables_controller.rb' @@ -312,7 +308,6 @@ Style/GuardClause: - 'ee/app/models/ee/incident_management/issuable_escalation_status.rb' - 'ee/app/models/ee/issue.rb' - 'ee/app/models/ee/issue_assignee.rb' - - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/member.rb' - 'ee/app/models/ee/merge_request.rb' - 'ee/app/models/ee/namespace.rb' @@ -328,6 +323,7 @@ Style/GuardClause: - 'ee/app/models/incident_management/escalation_rule.rb' - 'ee/app/models/incident_management/oncall_rotation.rb' - 'ee/app/models/ip_restriction.rb' + - 'ee/app/models/iteration.rb' - 'ee/app/models/namespace_limit.rb' - 'ee/app/models/preloaders/environments/protected_environment_preloader.rb' - 'ee/app/models/protected_environment.rb' @@ -432,7 +428,6 @@ Style/GuardClause: - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' - 'ee/spec/support/ci/minutes_helpers.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'haml_lint/linter/documentation_links.rb' - 'lib/api/commits.rb' - 'lib/api/error_tracking/collector.rb' @@ -490,7 +485,6 @@ Style/GuardClause: - 'lib/gitlab/ci/pipeline/expression/lexeme/base.rb' - 'lib/gitlab/ci/pipeline/expression/lexeme/pattern.rb' - 'lib/gitlab/ci/reports/codequality_reports_comparer.rb' - - 'lib/gitlab/ci/reports/security/vulnerability_reports_comparer.rb' - 'lib/gitlab/ci/runner/backoff.rb' - 'lib/gitlab/ci/runner_upgrade_check.rb' - 'lib/gitlab/ci/trace.rb' @@ -534,8 +528,6 @@ Style/GuardClause: - 'lib/gitlab/github_import/importer/pull_request_importer.rb' - 'lib/gitlab/github_import/importer/pull_request_review_importer.rb' - 'lib/gitlab/github_import/object_counter.rb' - - 'lib/gitlab/gitlab_import/client.rb' - - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/graphql/query_analyzers/ast/recursion_analyzer.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb' @@ -580,7 +572,6 @@ Style/GuardClause: - 'lib/gitlab/search/abuse_validators/no_abusive_term_length_validator.rb' - 'lib/gitlab/search/params.rb' - 'lib/gitlab/serializer/pagination.rb' - - 'lib/gitlab/serverless/service.rb' - 'lib/gitlab/shell.rb' - 'lib/gitlab/sidekiq_config/cli_methods.rb' - 'lib/gitlab/sidekiq_middleware/extra_done_log_metadata.rb' diff --git a/.rubocop_todo/style/hash_as_last_array_item.yml b/.rubocop_todo/style/hash_as_last_array_item.yml index 859061d6577..d7032af8805 100644 --- a/.rubocop_todo/style/hash_as_last_array_item.yml +++ b/.rubocop_todo/style/hash_as_last_array_item.yml @@ -45,7 +45,6 @@ Style/HashAsLastArrayItem: - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' - 'lib/gitlab/database/migration_helpers.rb' - 'spec/lib/gitlab/database/migration_helpers/v2_spec.rb' - - 'spec/migrations/20210914095310_cleanup_orphan_project_access_tokens_spec.rb' - 'spec/requests/rack_attack_global_spec.rb' - 'spec/services/git/branch_hooks_service_spec.rb' - 'spec/services/metrics/dashboard/panel_preview_service_spec.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index efdb0df8341..78e27951786 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -112,7 +112,6 @@ Style/IfUnlessModifier: - 'app/models/ability.rb' - 'app/models/appearance.rb' - 'app/models/application_setting_implementation.rb' - - 'app/models/broadcast_message.rb' - 'app/models/bulk_imports/entity.rb' - 'app/models/ci/application_record.rb' - 'app/models/ci/build.rb' @@ -330,7 +329,6 @@ Style/IfUnlessModifier: - 'app/services/users/build_service.rb' - 'app/services/users/respond_to_terms_service.rb' - 'app/services/wikis/create_attachment_service.rb' - - 'app/services/work_items/parent_links/create_service.rb' - 'app/services/work_items/task_list_reference_removal_service.rb' - 'app/services/work_items/task_list_reference_replacement_service.rb' - 'app/uploaders/file_mover.rb' @@ -386,13 +384,8 @@ Style/IfUnlessModifier: - 'config/routes.rb' - 'danger/database/Dangerfile' - 'danger/pipeline/Dangerfile' - - 'danger/specs/Dangerfile' - 'danger/z_metadata/Dangerfile' - - 'db/migrate/20210909184349_add_index_package_id_id_on_package_files.rb' - 'db/migrate/20220324175325_add_key_data_to_secure_files.rb' - - 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb' - - 'db/post_migrate/20220128155814_fix_approval_rules_code_owners_rule_type_index.rb' - - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' - 'db/post_migrate/20220523171107_drop_deploy_tokens_token_column.rb' - 'ee/app/components/namespaces/storage/limit_alert_component.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' @@ -419,8 +412,6 @@ Style/IfUnlessModifier: - 'ee/app/controllers/projects/path_locks_controller.rb' - 'ee/app/controllers/projects/push_rules_controller.rb' - 'ee/app/controllers/projects/settings/slacks_controller.rb' - - 'ee/app/controllers/trials_controller.rb' - - 'ee/app/finders/merge_trains_finder.rb' - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb' - 'ee/app/finders/security/vulnerabilities_finder.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/create.rb' @@ -454,7 +445,6 @@ Style/IfUnlessModifier: - 'ee/app/models/ee/group.rb' - 'ee/app/models/ee/group_member.rb' - 'ee/app/models/ee/issue.rb' - - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/key.rb' - 'ee/app/models/ee/list.rb' - 'ee/app/models/ee/milestone_release.rb' @@ -467,6 +457,7 @@ Style/IfUnlessModifier: - 'ee/app/models/geo/tracking_base.rb' - 'ee/app/models/incident_management/escalation_rule.rb' - 'ee/app/models/ip_restriction.rb' + - 'ee/app/models/iteration.rb' - 'ee/app/models/merge_requests/external_status_check.rb' - 'ee/app/models/requirements_management/requirement.rb' - 'ee/app/models/requirements_management/test_report.rb' @@ -557,7 +548,6 @@ Style/IfUnlessModifier: - 'ee/app/services/security/security_orchestration_policies/process_policy_service.rb' - 'ee/app/services/security/security_orchestration_policies/project_create_service.rb' - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' - - 'ee/app/services/slash_commands/global_slack_handler.rb' - 'ee/app/services/start_pull_mirroring_service.rb' - 'ee/app/services/system_notes/epics_service.rb' - 'ee/app/services/timebox_report_service.rb' @@ -586,6 +576,7 @@ Style/IfUnlessModifier: - 'ee/lib/api/merge_request_approval_rules.rb' - 'ee/lib/api/protected_environments.rb' - 'ee/lib/audit/details.rb' + - 'ee/lib/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/api/entities/epic.rb' - 'ee/lib/ee/api/entities/experiment.rb' - 'ee/lib/ee/api/geo.rb' @@ -595,7 +586,6 @@ Style/IfUnlessModifier: - 'ee/lib/ee/api/internal/base.rb' - 'ee/lib/ee/api/merge_request_approvals.rb' - 'ee/lib/ee/api/settings.rb' - - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/container_registry/client.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/ee/gitlab/auth/ldap/group.rb' @@ -642,7 +632,6 @@ Style/IfUnlessModifier: - 'ee/lib/gitlab/usage/metrics/instrumentations/count_users_creating_ci_builds_metric.rb' - 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb' - 'ee/lib/omni_auth/strategies/group_saml.rb' - - 'ee/lib/sidebars/groups/menus/administration_menu.rb' - 'ee/lib/sidebars/groups/menus/analytics_menu.rb' - 'ee/lib/sidebars/groups/menus/security_compliance_menu.rb' - 'ee/lib/tasks/geo.rake' @@ -669,7 +658,6 @@ Style/IfUnlessModifier: - 'ee/spec/support/helpers/feature_approval_helper.rb' - 'ee/spec/support/helpers/search_results_helpers.rb' - 'ee/spec/support/http_io/http_io_helpers.rb' - - 'ee/spec/views/layouts/header/help_dropdown/_cross_stage_fdm.html.haml_spec.rb' - 'ee/spec/workers/elastic/migration_worker_spec.rb' - 'lib/api/api_guard.rb' - 'lib/api/boards_responses.rb' @@ -755,12 +743,8 @@ Style/IfUnlessModifier: - 'lib/gitlab/auth/ldap/authentication.rb' - 'lib/gitlab/authorized_keys.rb' - 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb' - - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'lib/gitlab/bare_repository_import/importer.rb' - - 'lib/gitlab/bare_repository_import/repository.rb' - 'lib/gitlab/bullet/exclusions.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' - 'lib/gitlab/changelog/config.rb' @@ -866,8 +850,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/github_import/client.rb' - 'lib/gitlab/github_import/importer/pull_request_review_importer.rb' - 'lib/gitlab/github_import/representation/issue.rb' - - 'lib/gitlab/gitlab_import/client.rb' - - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/golang.rb' - 'lib/gitlab/graphql/pagination/keyset/connection.rb' - 'lib/gitlab/graphql/queries.rb' @@ -882,7 +864,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/import_export/base/relation_factory.rb' - 'lib/gitlab/import_export/fast_hash_serializer.rb' - 'lib/gitlab/import_export/group/tree_restorer.rb' - - 'lib/gitlab/import_export/json/legacy_writer.rb' - 'lib/gitlab/import_export/merge_request_parser.rb' - 'lib/gitlab/import_export/project/export_task.rb' - 'lib/gitlab/import_export/project/relation_factory.rb' @@ -891,7 +872,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/jira_import.rb' - 'lib/gitlab/jira_import/base_importer.rb' - 'lib/gitlab/legacy_github_import/client.rb' - - 'lib/gitlab/legacy_github_import/importer.rb' - 'lib/gitlab/legacy_github_import/issuable_formatter.rb' - 'lib/gitlab/legacy_github_import/project_creator.rb' - 'lib/gitlab/lograge/custom_options.rb' @@ -1011,7 +991,6 @@ Style/IfUnlessModifier: - 'spec/components/previews/pajamas/alert_component_preview.rb' - 'spec/components/previews/pajamas/card_component_preview.rb' - 'spec/factories/ci/runners.rb' - - 'spec/factories/clusters/applications/helm.rb' - 'spec/factories/container_repositories.rb' - 'spec/factories/deployments.rb' - 'spec/factories/labels.rb' @@ -1028,7 +1007,6 @@ Style/IfUnlessModifier: - 'spec/features/projects/tree/create_file_spec.rb' - 'spec/graphql/mutations/releases/update_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/config/entry/validators/nested_array_helpers_spec.rb' - 'spec/lib/gitlab/conflict/file_spec.rb' - 'spec/lib/gitlab/database/load_balancing_spec.rb' @@ -1063,7 +1041,7 @@ Style/IfUnlessModifier: - 'spec/spec_helper.rb' - 'spec/support/capybara.rb' - 'spec/support/external_authorization_service_helpers.rb' - - 'spec/support/flaky_tests.rb' + - 'spec/support/fast_quarantine.rb' - 'spec/support/generate-seed-repo-rb' - 'spec/support/helpers/filter_spec_helper.rb' - 'spec/support/helpers/filtered_search_helpers.rb' @@ -1096,7 +1074,7 @@ Style/IfUnlessModifier: - 'spec/support/webmock.rb' - 'spec/views/profiles/keys/_key.html.haml_spec.rb' - 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb' - - 'tooling/danger/product_intelligence.rb' + - 'tooling/danger/analytics_instrumentation.rb' - 'tooling/lib/tooling/find_codeowners.rb' - 'tooling/lib/tooling/image.rb' - 'tooling/lib/tooling/test_map_packer.rb' diff --git a/.rubocop_todo/style/keyword_parameters_order.yml b/.rubocop_todo/style/keyword_parameters_order.yml index 3730a86221e..e4b751a92da 100644 --- a/.rubocop_todo/style/keyword_parameters_order.yml +++ b/.rubocop_todo/style/keyword_parameters_order.yml @@ -8,7 +8,6 @@ Style/KeywordParametersOrder: - 'ee/lib/gitlab/elastic/helper.rb' - 'ee/lib/gitlab/insights/executors/dora_executor.rb' - 'ee/lib/gitlab/insights/executors/issuable_executor.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/requests/api/deployments_spec.rb' - 'lib/gitlab/background_migration/batched_migration_job.rb' - 'lib/gitlab/checks/timed_logger.rb' diff --git a/.rubocop_todo/style/mutable_constant.yml b/.rubocop_todo/style/mutable_constant.yml index 2409d4f3521..8e6a0a2335b 100644 --- a/.rubocop_todo/style/mutable_constant.yml +++ b/.rubocop_todo/style/mutable_constant.yml @@ -5,7 +5,6 @@ Style/MutableConstant: Exclude: - 'app/finders/group_members_finder.rb' - 'app/graphql/mutations/container_repositories/destroy_tags.rb' - - 'app/graphql/mutations/members/groups/bulk_update.rb' - 'app/graphql/mutations/packages/bulk_destroy.rb' - 'app/helpers/blame_helper.rb' - 'app/models/ci/build_trace_chunks/redis_base.rb' diff --git a/.rubocop_todo/style/numbered_parameters.yml b/.rubocop_todo/style/numbered_parameters.yml index 3251cc0bcad..fc08515bc2f 100644 --- a/.rubocop_todo/style/numbered_parameters.yml +++ b/.rubocop_todo/style/numbered_parameters.yml @@ -25,7 +25,6 @@ Style/NumberedParameters: - 'app/services/web_hooks/log_execution_service.rb' - 'ee/app/models/ee/project.rb' - 'ee/app/models/security/finding.rb' - - 'ee/app/models/slack_integration.rb' - 'ee/app/models/vulnerabilities/feedback.rb' - 'ee/app/services/security/ingestion/tasks/hooks_execution.rb' - 'ee/app/services/security/ingestion/tasks/ingest_remediations.rb' @@ -77,7 +76,6 @@ Style/NumberedParameters: - 'spec/services/web_hook_service_spec.rb' - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/matchers/exceed_query_limit.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' - 'spec/support/shared_contexts/lib/sbom/package_url_shared_contexts.rb' - 'spec/support/shared_examples/integrations/integration_settings_form.rb' - 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb' diff --git a/.rubocop_todo/style/numeric_literal_prefix.yml b/.rubocop_todo/style/numeric_literal_prefix.yml index 44f9ab098a2..441e4389aab 100644 --- a/.rubocop_todo/style/numeric_literal_prefix.yml +++ b/.rubocop_todo/style/numeric_literal_prefix.yml @@ -6,14 +6,11 @@ Style/NumericLiteralPrefix: - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'config/initializers/01_secret_token.rb' - 'config/initializers/1_settings.rb' - - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - - 'ee/spec/migrations/schedule_trace_expiry_removal_spec.rb' - 'ee/spec/models/analytics/devops_adoption/snapshot_spec.rb' - 'ee/spec/models/ci/minutes/usage_spec.rb' - 'ee/spec/models/ee/group_spec.rb' @@ -21,7 +18,6 @@ Style/NumericLiteralPrefix: - 'ee/spec/services/incident_management/oncall_schedules/update_service_spec.rb' - 'ee/spec/workers/sync_seat_link_worker_spec.rb' - 'lib/backup/files.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - 'lib/gitlab/import_export/command_line_util.rb' - 'lib/gitlab/jwt_authenticatable.rb' - 'lib/system_check/app/uploads_path_permission_check.rb' @@ -32,7 +28,6 @@ Style/NumericLiteralPrefix: - 'qa/qa/support/ssh.rb' - 'qa/spec/support/ssh_spec.rb' - 'scripts/security-harness' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 66de6a35092..496f05c7cab 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -54,7 +54,7 @@ Style/PercentLiteralDelimiters: - 'app/models/ci/pipeline.rb' - 'app/models/clusters/platforms/kubernetes.rb' - 'app/models/commit.rb' - - 'app/models/concerns/clusters/agents/authorization_config_scopes.rb' + - 'app/models/concerns/clusters/agents/authorizations/ci_access/config_scopes.rb' - 'app/models/concerns/diff_positionable_note.rb' - 'app/models/concerns/enums/prometheus_metric.rb' - 'app/models/concerns/issuable.rb' @@ -173,16 +173,12 @@ Style/PercentLiteralDelimiters: - 'config/initializers_before_autoloader/000_inflections.rb' - 'config/object_store_settings.rb' - 'config/spring.rb' - - 'db/migrate/20210928155022_improve_index_for_error_tracking.rb' - - 'db/post_migrate/20210906130643_drop_temporary_columns_and_triggers_for_taggings.rb' - - 'db/post_migrate/20211028100843_delete_issue_merge_request_taggings_records.rb' - 'ee/app/controllers/ee/admin/application_settings_controller.rb' - 'ee/app/controllers/ee/projects/service_desk_controller.rb' - 'ee/app/controllers/ee/repositories/git_http_client_controller.rb' - 'ee/app/controllers/groups/protected_environments_controller.rb' - 'ee/app/controllers/projects/integrations/jira/issues_controller.rb' - 'ee/app/controllers/projects/protected_environments_controller.rb' - - 'ee/app/controllers/trials_controller.rb' - 'ee/app/finders/iterations_finder.rb' - 'ee/app/graphql/types/incident_management/oncall_rotation_date_input_type.rb' - 'ee/app/helpers/credentials_inventory_helper.rb' @@ -192,7 +188,6 @@ Style/PercentLiteralDelimiters: - 'ee/app/helpers/ee/issues_helper.rb' - 'ee/app/helpers/ee/labels_helper.rb' - 'ee/app/helpers/ee/nav_helper.rb' - - 'ee/app/helpers/ee/trial_helper.rb' - 'ee/app/mailers/previews/ci_minutes_usage_mailer_preview.rb' - 'ee/app/mailers/previews/emails/namespace_storage_usage_mailer_preview.rb' - 'ee/app/mailers/previews/license_mailer_preview.rb' @@ -240,7 +235,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/ee/api/search.rb' - 'ee/lib/ee/gitlab/alert_management/payload/generic.rb' - 'ee/lib/ee/gitlab/auth/ldap/adapter.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/lib/ee/gitlab/ci/parsers/security/validators/schema_validator.rb' @@ -462,7 +456,6 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/auth/ldap/adapter.rb' - 'lib/gitlab/auth/ldap/config.rb' - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' - - 'lib/gitlab/bare_repository_import/importer.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/config/entry/bridge.rb' - 'lib/gitlab/ci/reports/codequality_reports.rb' @@ -497,7 +490,6 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/jira_import/metadata_collector.rb' - 'lib/gitlab/kas.rb' - 'lib/gitlab/kroki.rb' - - 'lib/gitlab/kubernetes/helm/pod.rb' - 'lib/gitlab/kubernetes/kubectl_cmd.rb' - 'lib/gitlab/logger.rb' - 'lib/gitlab/lograge/custom_options.rb' @@ -601,7 +593,6 @@ Style/PercentLiteralDelimiters: - 'spec/experiments/ios_specific_templates_experiment_spec.rb' - 'spec/factories/ci/builds.rb' - 'spec/factories/ci/runners.rb' - - 'spec/factories/clusters/applications/helm.rb' - 'spec/factories/clusters/clusters.rb' - 'spec/factories/clusters/integrations/prometheus.rb' - 'spec/factories/clusters/providers/aws.rb' @@ -645,7 +636,6 @@ Style/PercentLiteralDelimiters: - 'spec/graphql/types/boards/board_issue_input_type_spec.rb' - 'spec/graphql/types/design_management/design_collection_copy_state_enum_spec.rb' - 'spec/graphql/types/issue_type_spec.rb' - - 'spec/haml_lint/linter/no_plain_nodes_spec.rb' - 'spec/helpers/appearances_helper_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' - 'spec/helpers/auth_helper_spec.rb' @@ -713,7 +703,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/auth/saml/user_spec.rb' - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/batch_worker_context_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/cache_spec.rb' @@ -798,7 +787,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/import_export/attribute_cleaner_spec.rb' - 'spec/lib/gitlab/import_export/attributes_permitter_spec.rb' - 'spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_writer_spec.rb' - 'spec/lib/gitlab/import_export/json/ndjson_writer_spec.rb' - 'spec/lib/gitlab/import_export/lfs_restorer_spec.rb' - 'spec/lib/gitlab/import_export/lfs_saver_spec.rb' @@ -874,7 +862,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/system_check/orphans/namespace_check_spec.rb' - 'spec/lib/system_check/orphans/repository_check_spec.rb' - 'spec/lib/system_check/sidekiq_check_spec.rb' - - 'spec/lib/tasks/gitlab/metrics_exporter_task_spec.rb' - 'spec/lib/unnested_in_filters/dsl_spec.rb' - 'spec/lib/unnested_in_filters/rewriter_spec.rb' - 'spec/metrics_server/metrics_server_spec.rb' @@ -993,7 +980,6 @@ Style/PercentLiteralDelimiters: - 'spec/requests/api/unleash_spec.rb' - 'spec/requests/api/users_spec.rb' - 'spec/requests/api/wikis_spec.rb' - - 'spec/requests/ide_controller_spec.rb' - 'spec/requests/jwt_controller_spec.rb' - 'spec/requests/lfs_locks_api_spec.rb' - 'spec/requests/users_controller_spec.rb' @@ -1121,7 +1107,6 @@ Style/PercentLiteralDelimiters: - 'spec/views/layouts/_head.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'spec/views/projects/commit/branches.html.haml_spec.rb' - - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - 'spec/workers/concerns/worker_context_spec.rb' - 'spec/workers/container_registry/migration/enqueuer_worker_spec.rb' - 'spec/workers/gitlab/github_import/advance_stage_worker_spec.rb' diff --git a/.rubocop_todo/style/redundant_begin.yml b/.rubocop_todo/style/redundant_begin.yml deleted file mode 100644 index 8f490002fd6..00000000000 --- a/.rubocop_todo/style/redundant_begin.yml +++ /dev/null @@ -1,6 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/RedundantBegin: - Exclude: - - 'app/controllers/concerns/metrics_dashboard.rb' - - 'ee/lib/gem_extensions/elasticsearch/model/adapter/multiple/records.rb' diff --git a/.rubocop_todo/style/redundant_freeze.yml b/.rubocop_todo/style/redundant_freeze.yml index 46609b0131a..b65fe11a9b7 100644 --- a/.rubocop_todo/style/redundant_freeze.yml +++ b/.rubocop_todo/style/redundant_freeze.yml @@ -42,8 +42,6 @@ Style/RedundantFreeze: - 'app/models/packages/debian/file_entry.rb' - 'app/models/personal_access_token.rb' - 'app/models/releases/link.rb' - - 'app/models/serverless/domain.rb' - - 'app/models/serverless/domain_cluster.rb' - 'app/models/snippet_repository.rb' - 'app/models/terraform/state.rb' - 'app/services/clusters/agent_tokens/track_usage_service.rb' @@ -51,7 +49,6 @@ Style/RedundantFreeze: - 'app/services/grafana/proxy_service.rb' - 'app/services/import/validate_remote_git_endpoint_service.rb' - 'app/services/issues/base_service.rb' - - 'app/services/packages/debian/process_package_file_service.rb' - 'app/services/projects/import_error_filter.rb' - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' - 'app/services/prometheus/proxy_variable_substitution_service.rb' @@ -66,10 +63,10 @@ Style/RedundantFreeze: - 'ee/app/graphql/types/incident_management/oncall_rotation_date_input_type.rb' - 'ee/app/models/allowed_email_domain.rb' - 'ee/app/models/ee/issue.rb' - - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/label.rb' - 'ee/app/models/ee/project_import_state.rb' - 'ee/app/models/ee/vulnerability.rb' + - 'ee/app/models/iteration.rb' - 'ee/app/models/status_page/project_setting.rb' - 'ee/app/serializers/analytics/cycle_analytics/value_stream_errors_serializer.rb' - 'ee/app/services/elastic/data_migration_service.rb' @@ -78,7 +75,6 @@ Style/RedundantFreeze: - 'ee/lib/ee/gitlab/path_regex.rb' - 'ee/lib/ee/gitlab/web_hooks/rate_limiter.rb' - 'ee/lib/elastic/latest/git_class_proxy.rb' - - 'ee/lib/gitlab/code_owners/file.rb' - 'ee/lib/gitlab/code_owners/reference_extractor.rb' - 'ee/lib/gitlab/status_page/filter/image_filter.rb' - 'ee/lib/system_check/geo/authorized_keys_check.rb' @@ -114,7 +110,6 @@ Style/RedundantFreeze: - 'lib/gitaly/server.rb' - 'lib/gitlab.rb' - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/changelog/generator.rb' - 'lib/gitlab/ci/build/artifacts/metadata.rb' @@ -156,7 +151,6 @@ Style/RedundantFreeze: - 'lib/gitlab/email/handler/create_merge_request_handler.rb' - 'lib/gitlab/email/handler/create_note_on_issuable_handler.rb' - 'lib/gitlab/email/handler/service_desk_handler.rb' - - 'lib/gitlab/email/hook/validate_addresses_interceptor.rb' - 'lib/gitlab/email/receiver.rb' - 'lib/gitlab/error_tracking/error_repository/open_api_strategy.rb' - 'lib/gitlab/front_matter.rb' @@ -237,7 +231,6 @@ Style/RedundantFreeze: - 'tooling/danger/config_files.rb' - 'tooling/danger/customer_success.rb' - 'tooling/danger/datateam.rb' - - 'tooling/danger/specs.rb' - 'tooling/danger/stable_branch.rb' - 'tooling/lib/tooling/kubernetes_client.rb' - 'tooling/lib/tooling/mappings/view_to_js_mappings.rb' diff --git a/.rubocop_todo/style/redundant_regexp_escape.yml b/.rubocop_todo/style/redundant_regexp_escape.yml index 9a54b73b64e..b1ab72bac61 100644 --- a/.rubocop_todo/style/redundant_regexp_escape.yml +++ b/.rubocop_todo/style/redundant_regexp_escape.yml @@ -28,8 +28,8 @@ Style/RedundantRegexpEscape: - 'config/routes/snippets.rb' - 'config/routes/uploads.rb' - 'ee/app/models/ee/epic.rb' - - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/vulnerability.rb' + - 'ee/app/models/iteration.rb' - 'ee/config/routes/admin.rb' - 'ee/lib/ee/gitlab/path_regex.rb' - 'ee/lib/elastic/latest/merge_request_class_proxy.rb' @@ -77,7 +77,6 @@ Style/RedundantRegexpEscape: - 'lib/gitlab/utils/sanitize_node_link.rb' - 'lib/gitlab/word_diff/segments/diff_hunk.rb' - 'lib/product_analytics/tracker.rb' - - 'lib/tasks/gettext.rake' - 'lib/tasks/gitlab/info.rake' - 'qa/spec/runtime/key/ecdsa_spec.rb' - 'qa/spec/runtime/key/ed25519_spec.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 9441150d6d3..3168a5d2150 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -18,7 +18,6 @@ Style/RedundantSelf: - 'app/models/ci/stage.rb' - 'app/models/ci/trigger.rb' - 'app/models/ci_platform_metric.rb' - - 'app/models/clusters/applications/crossplane.rb' - 'app/models/clusters/cluster.rb' - 'app/models/clusters/concerns/application_core.rb' - 'app/models/clusters/concerns/application_status.rb' @@ -132,7 +131,6 @@ Style/RedundantSelf: - 'app/models/remote_mirror.rb' - 'app/models/repository.rb' - 'app/models/sent_notification.rb' - - 'app/models/serverless/function.rb' - 'app/models/service_desk_setting.rb' - 'app/models/snippet.rb' - 'app/models/terraform/state.rb' @@ -169,7 +167,6 @@ Style/RedundantSelf: - 'config/initializers/active_record_keyset_pagination.rb' - 'config/initializers/forbid_sidekiq_in_transactions.rb' - 'config/initializers/mail_encoding_patch.rb' - - 'db/post_migrate/20211029102822_add_open_source_plan.rb' - 'ee/app/graphql/resolvers/geo/registries_resolver.rb' - 'ee/app/models/approval_merge_request_rule.rb' - 'ee/app/models/approval_project_rule.rb' @@ -198,7 +195,6 @@ Style/RedundantSelf: - 'ee/app/models/ee/group.rb' - 'ee/app/models/ee/group_member.rb' - 'ee/app/models/ee/issue.rb' - - 'ee/app/models/ee/iteration.rb' - 'ee/app/models/ee/member.rb' - 'ee/app/models/ee/namespace.rb' - 'ee/app/models/ee/packages/package_file.rb' @@ -217,6 +213,7 @@ Style/RedundantSelf: - 'ee/app/models/gitlab_subscription.rb' - 'ee/app/models/gitlab_subscriptions/upcoming_reconciliation.rb' - 'ee/app/models/group_wiki_repository.rb' + - 'ee/app/models/iteration.rb' - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/license.rb' - 'ee/app/models/merge_requests/external_status_check.rb' @@ -230,8 +227,6 @@ Style/RedundantSelf: - 'ee/lib/ee/gitlab/auth/ldap/sync/users.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/delete_invalid_epic_issues.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'ee/lib/ee/gitlab/database.rb' - 'ee/lib/ee/gitlab/tracking.rb' - 'ee/lib/ee/legacy_model.rb' @@ -279,10 +274,8 @@ Style/RedundantSelf: - 'lib/gitlab/auth/ldap/dn.rb' - 'lib/gitlab/auth/o_auth/provider.rb' - 'lib/gitlab/auth/result.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - 'lib/gitlab/background_migration/job_coordinator.rb' - - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/ansi2json/parser.rb' @@ -405,4 +398,3 @@ Style/RedundantSelf: - 'spec/lib/gitlab/database/load_balancing_spec.rb' - 'spec/models/integration_spec.rb' - 'spec/support/before_all_adapter.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/style/single_argument_dig.yml b/.rubocop_todo/style/single_argument_dig.yml index 8d35373a2c0..d41dc0add05 100644 --- a/.rubocop_todo/style/single_argument_dig.yml +++ b/.rubocop_todo/style/single_argument_dig.yml @@ -47,7 +47,6 @@ Style/SingleArgumentDig: - 'lib/gitlab/config/entry/simplifiable.rb' - 'lib/gitlab/config/entry/validators.rb' - 'lib/gitlab/database/transaction/observer.rb' - - 'lib/gitlab/serverless/service.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'qa/qa/vendor/mail_hog/api.rb' - 'spec/controllers/graphql_controller_spec.rb' diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index 19b4a6716dc..9403b13e1b5 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -17,7 +17,6 @@ Style/StringConcatenation: - 'app/models/pool_repository.rb' - 'app/models/project_wiki.rb' - 'app/models/repository.rb' - - 'app/models/serverless/function.rb' - 'app/models/wiki.rb' - 'app/models/wiki_page.rb' - 'app/presenters/snippet_blob_presenter.rb' @@ -91,7 +90,6 @@ Style/StringConcatenation: - 'lib/feature/definition.rb' - 'lib/gitlab/auth/ldap/dn.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - - 'lib/gitlab/bare_repository_import/importer.rb' - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb' - 'lib/gitlab/ci/status/build/retried.rb' - 'lib/gitlab/config/entry/validators.rb' @@ -121,7 +119,6 @@ Style/StringConcatenation: - 'lib/gitlab/route_map.rb' - 'lib/gitlab/sanitizers/exception_message.rb' - 'lib/gitlab/sidekiq_logging/json_formatter.rb' - - 'lib/gitlab/slug/environment.rb' - 'lib/gitlab/sql/set_operator.rb' - 'lib/gitlab/ssh_public_key.rb' - 'lib/gitlab/throttle.rb' @@ -184,8 +181,6 @@ Style/StringConcatenation: - 'spec/lib/container_registry/tag_spec.rb' - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/ci/build/artifacts/metadata_spec.rb' - 'spec/lib/gitlab/ci/config/entry/artifacts_spec.rb' - 'spec/lib/gitlab/ci/config/external/mapper_spec.rb' @@ -218,7 +213,6 @@ Style/StringConcatenation: - 'spec/lib/gitlab/themes_spec.rb' - 'spec/lib/gitlab/throttle_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - - 'spec/lib/gitlab/url_blocker_spec.rb' - 'spec/lib/gitlab/utils_spec.rb' - 'spec/lib/gitlab/visibility_level_spec.rb' - 'spec/lib/gitlab/wiki_pages/front_matter_parser_spec.rb' diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml index 7273161aef5..ceb6a922270 100644 --- a/.rubocop_todo/style/string_literals_in_interpolation.yml +++ b/.rubocop_todo/style/string_literals_in_interpolation.yml @@ -8,7 +8,6 @@ Style/StringLiteralsInInterpolation: - 'app/models/ci/namespace_mirror.rb' - 'app/models/integrations/campfire.rb' - 'app/models/integrations/jira.rb' - - 'app/models/serverless/domain.rb' - 'app/services/draft_notes/publish_service.rb' - 'app/services/projects/create_service.rb' - 'app/validators/nested_attributes_duplicates_validator.rb' @@ -53,7 +52,6 @@ Style/StringLiteralsInInterpolation: - 'spec/features/commits_spec.rb' - 'spec/features/dashboard/merge_requests_spec.rb' - 'spec/features/users/login_spec.rb' - - 'spec/finders/serverless_domain_finder_spec.rb' - 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb' - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' @@ -61,7 +59,6 @@ Style/StringLiteralsInInterpolation: - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/gitaly_client/ref_service_spec.rb' - 'spec/lib/object_storage/direct_upload_spec.rb' - - 'spec/models/serverless/domain_spec.rb' - 'spec/requests/api/keys_spec.rb' - 'spec/support/database/prevent_cross_joins.rb' - 'spec/views/notify/import_issues_csv_email.html.haml_spec.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index e3bde84c7b8..0e4602f9f31 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -66,7 +66,6 @@ Style/SymbolProc: - 'config/initializers/doorkeeper_openid_connect.rb' - 'config/initializers/mail_encoding_patch.rb' - 'config/settings.rb' - - 'db/post_migrate/20220119094503_populate_audit_event_streaming_verification_token.rb' - 'db/post_migrate/20220803042352_cleanup_mr_attention_request_todos.rb' - 'ee/app/helpers/ee/mirror_helper.rb' - 'ee/app/helpers/ee/registrations_helper.rb' @@ -96,16 +95,12 @@ Style/SymbolProc: - 'ee/lib/ee/api/entities/merge_request_approval_state.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'ee/lib/gitlab/ci/parsers/security/formatters/dependency_list.rb' - 'ee/lib/gitlab/contribution_analytics/data_collector.rb' - 'ee/lib/gitlab/custom_file_templates.rb' - 'ee/lib/gitlab/geo/oauth/logout_state.rb' - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' - 'ee/spec/factories/issues.rb' - - 'ee/spec/features/billings/extend_reactivate_trial_spec.rb' - 'ee/spec/features/billings/qrtly_reconciliation_alert_spec.rb' - 'ee/spec/helpers/ee/geo_helper_spec.rb' - 'ee/spec/helpers/ee/registrations_helper_spec.rb' @@ -133,8 +128,6 @@ Style/SymbolProc: - 'lib/container_registry/gitlab_api_client.rb' - 'lib/gitlab/analytics/cycle_analytics/stage_events.rb' - 'lib/gitlab/auth/o_auth/auth_hash.rb' - - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/blob_helper.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' @@ -174,7 +167,7 @@ Style/SymbolProc: - 'qa/qa/runtime/ip_address.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/rebase_merge_request_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/review_merge_request_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/review_merge_request_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/online_garbage_collection_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/merge_request/approval_rules_spec.rb' |