diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-04-20 15:20:09 +0000 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-04-20 15:20:09 +0000 |
| commit | da23c5d563d68bfa5271b216209a7715c7ce3073 (patch) | |
| tree | ea829aa79f715b98c440d6bf3767328b4fc4f750 /.rubocop_todo | |
| parent | 2366f969a4b3a95e052e551cc7283a2db8d5562e (diff) | |
| download | gitlab-ce-da23c5d563d68bfa5271b216209a7715c7ce3073.tar.gz | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to '.rubocop_todo')
69 files changed, 0 insertions, 750 deletions
diff --git a/.rubocop_todo/capybara/visibility_matcher.yml b/.rubocop_todo/capybara/visibility_matcher.yml index 32f8ddc0ae5..d303f0d5332 100644 --- a/.rubocop_todo/capybara/visibility_matcher.yml +++ b/.rubocop_todo/capybara/visibility_matcher.yml @@ -17,7 +17,6 @@ Capybara/VisibilityMatcher: - 'ee/spec/support/helpers/billing_plans_helpers.rb' - 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb' - 'ee/spec/support/shared_examples/views/issuable_bulk_dropdown_shared_examples.rb' - - 'ee/spec/views/layouts/_search.html.haml_spec.rb' - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' - 'spec/features/admin/admin_mode_spec.rb' - 'spec/features/dashboard/merge_requests_spec.rb' @@ -55,7 +54,6 @@ Capybara/VisibilityMatcher: - 'spec/features/search/user_searches_for_commits_spec.rb' - 'spec/features/snippets/notes_on_personal_snippets_spec.rb' - 'spec/features/task_lists_spec.rb' - - 'spec/features/u2f_spec.rb' - 'spec/features/uploads/user_uploads_file_to_note_spec.rb' - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/features/users/overview_spec.rb' @@ -69,7 +67,6 @@ Capybara/VisibilityMatcher: - 'spec/support/shared_examples/features/wiki/file_attachments_shared_examples.rb' - 'spec/views/import/gitlab_projects/new.html.haml_spec.rb' - 'spec/views/layouts/_header_search.html.haml_spec.rb' - - 'spec/views/layouts/_search.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'spec/views/profiles/preferences/show.html.haml_spec.rb' - 'spec/views/projects/merge_requests/edit.html.haml_spec.rb' diff --git a/.rubocop_todo/database/disable_referential_integrity.yml b/.rubocop_todo/database/disable_referential_integrity.yml deleted file mode 100644 index 95cfc5920d4..00000000000 --- a/.rubocop_todo/database/disable_referential_integrity.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -Database/DisableReferentialIntegrity: - Exclude: - - 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb' diff --git a/.rubocop_todo/database/rescue_query_canceled.yml b/.rubocop_todo/database/rescue_query_canceled.yml index 324ab498dd9..3fa3c8c388e 100644 --- a/.rubocop_todo/database/rescue_query_canceled.yml +++ b/.rubocop_todo/database/rescue_query_canceled.yml @@ -2,7 +2,6 @@ Database/RescueQueryCanceled: Exclude: - 'app/services/issues/relative_position_rebalancing_service.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' - 'lib/gitlab/database/batch_counter.rb' - 'lib/gitlab/issuables_count_for_state.rb' diff --git a/.rubocop_todo/fips/sha1.yml b/.rubocop_todo/fips/sha1.yml index f39ca78fd81..bfb51250295 100644 --- a/.rubocop_todo/fips/sha1.yml +++ b/.rubocop_todo/fips/sha1.yml @@ -18,18 +18,13 @@ Fips/SHA1: - 'ee/app/services/vulnerabilities/create_service_base.rb' - 'ee/app/services/vulnerabilities/manually_create_service.rb' - 'ee/app/services/vulnerabilities/starboard_vulnerability_create_service.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'ee/spec/factories/vulnerabilities/feedback.rb' - 'ee/spec/factories/vulnerabilities/finding_signatures.rb' - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/cluster_image_scanning_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/container_scanning_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/dast_spec.rb' - 'ee/spec/lib/gitlab/ci/reports/security/locations/dependency_scanning_spec.rb' - - 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/models/resource_weight_event_spec.rb' - 'ee/spec/models/vulnerabilities/finding_signature_spec.rb' - 'ee/spec/models/vulnerabilities/finding_spec.rb' @@ -76,7 +71,6 @@ Fips/SHA1: - 'spec/lib/gitlab/alert_management/payload/generic_spec.rb' - 'spec/lib/gitlab/alert_management/payload/prometheus_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_note_discussion_id_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/ci/reports/security/finding_signature_spec.rb' - 'spec/lib/gitlab/ci/reports/security/locations/sast_spec.rb' - 'spec/lib/gitlab/ci/reports/security/locations/secret_detection_spec.rb' @@ -84,9 +78,7 @@ Fips/SHA1: - 'spec/lib/gitlab/diff/position_spec.rb' - 'spec/lib/gitlab/git/branch_spec.rb' - 'spec/lib/gitlab/git/tag_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - 'spec/migrations/20220524074947_finalize_backfill_null_note_discussion_ids_spec.rb' - - 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - 'spec/models/ci/artifact_blob_spec.rb' - 'spec/models/ci/job_artifact_spec.rb' - 'spec/models/ci/pipeline_spec.rb' diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index 4f5d5ab3a80..0a80b513c6e 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -79,7 +79,6 @@ Gitlab/NamespacedClass: - 'app/finders/resource_milestone_event_finder.rb' - 'app/finders/resource_state_event_finder.rb' - 'app/finders/sentry_issue_finder.rb' - - 'app/finders/serverless_domain_finder.rb' - 'app/finders/snippets_finder.rb' - 'app/finders/starred_projects_finder.rb' - 'app/finders/tags_finder.rb' @@ -478,7 +477,6 @@ Gitlab/NamespacedClass: - 'app/serializers/build_metadata_entity.rb' - 'app/serializers/build_trace_entity.rb' - 'app/serializers/build_trace_serializer.rb' - - 'app/serializers/cluster_application_entity.rb' - 'app/serializers/cluster_entity.rb' - 'app/serializers/cluster_serializer.rb' - 'app/serializers/codequality_degradation_entity.rb' @@ -1069,7 +1067,6 @@ Gitlab/NamespacedClass: - 'ee/app/workers/sync_seat_link_request_worker.rb' - 'ee/app/workers/sync_seat_link_worker.rb' - 'ee/app/workers/update_all_mirrors_worker.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/lib/gitlab/authority_analyzer.rb' - 'ee/lib/gitlab/cidr.rb' - 'ee/lib/gitlab/custom_file_templates.rb' @@ -1270,7 +1267,6 @@ Gitlab/NamespacedClass: - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb' - 'spec/support/helpers/ci_artifact_metadata_generator.rb' - 'spec/support/helpers/fake_migration_classes.rb' - - 'spec/support/helpers/fake_u2f_device.rb' - 'spec/support/helpers/fake_webauthn_device.rb' - 'spec/support/helpers/markdown_feature.rb' - 'spec/support/helpers/redis_without_keys.rb' diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index 21b8a2c9dec..9c37e20479b 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -410,7 +410,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/services/incident_management/escalation_policies/update_service.rb' - 'ee/app/services/incident_management/pending_escalations/process_service.rb' - 'ee/app/services/iterations/create_service.rb' - - 'ee/app/services/merge_commits/export_csv_service.rb' - 'ee/app/services/merge_requests/update_blocks_service.rb' - 'ee/app/services/projects/restore_service.rb' - 'ee/app/services/protected_environments/base_service.rb' @@ -470,7 +469,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/lib/gitlab/auth/group_saml/user.rb' - 'ee/lib/gitlab/auth/saml/membership_updater.rb' - 'ee/lib/gitlab/auth/smartcard/certificate.rb' - - 'ee/lib/gitlab/ci/minutes/build_consumption.rb' - 'ee/lib/gitlab/ci/minutes/cached_quota.rb' - 'ee/lib/gitlab/ci/minutes/gitlab_contribution_cost_factor.rb' - 'ee/lib/gitlab/ci/minutes/runners_availability.rb' @@ -654,7 +652,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/import_export/fast_hash_serializer.rb' - 'lib/gitlab/import_export/group/tree_restorer.rb' - 'lib/gitlab/import_export/importer.rb' - - 'lib/gitlab/import_export/json/legacy_reader.rb' - 'lib/gitlab/import_export/lfs_restorer.rb' - 'lib/gitlab/import_export/project/sample/date_calculator.rb' - 'lib/gitlab/import_export/project/tree_restorer.rb' @@ -680,7 +677,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/relative_positioning/starting_from.rb' - 'lib/gitlab/request_context.rb' - 'lib/gitlab/search/found_blob.rb' - - 'lib/gitlab/serverless/service.rb' - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/deduplicates_when_scheduling.rb' - 'lib/gitlab/sidekiq_queue.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index b39f2181cee..178902731e6 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -568,7 +568,6 @@ Layout/ArgumentAlignment: - 'app/models/remote_mirror.rb' - 'app/models/repository.rb' - 'app/models/resource_timebox_event.rb' - - 'app/models/serverless/domain_cluster.rb' - 'app/models/service_desk_setting.rb' - 'app/models/terraform/state.rb' - 'app/models/time_tracking/timelog_category.rb' @@ -656,13 +655,6 @@ Layout/ArgumentAlignment: - 'config/initializers/rack_timeout.rb' - 'config/initializers/rest-client-hostname_override.rb' - 'config/initializers/zz_metrics.rb' - - 'db/migrate/20210901065504_add_index_on_name_and_id_to_public_groups.rb' - - 'db/migrate/20210910014741_add_dependency_proxy_ttl_group_policy_worker_capacity_to_application_settings.rb' - - 'db/migrate/20211111112639_add_fk_compliance_violations_merge_request.rb' - - 'db/migrate/20211111112713_add_fk_compliance_violations_violating_user.rb' - - 'db/migrate/20211224112937_add_packages_cleanup_package_file_worker_capacity_to_application_settings.rb' - - 'db/migrate/20220204154220_add_index_on_greatest_done_at_to_container_repositories.rb' - - 'db/migrate/20220314184009_create_protected_environment_approval_rules.rb' - 'db/migrate/20220401113123_add_check_constraint_to_vsa_aggregation_runtime_data_columns.rb' - 'db/migrate/20220405125459_add_non_migrated_index_to_container_repositories.rb' - 'db/migrate/20220408001450_add_work_item_type_name_unique_index_null_namespaces.rb' @@ -725,20 +717,6 @@ Layout/ArgumentAlignment: - 'db/migrate/20230124193917_add_index_for_protected_tag_create_access_levels.rb' - 'db/migrate/20230127151529_add_project_pointer_for_analytics_dashboard.rb' - 'db/migrate/20230127151531_change_dashboard_analytics_project_pointer_project_null.rb' - - 'db/post_migrate/20210921062820_add_image_location_index_to_vulnerability_occurrences.rb' - - 'db/post_migrate/20211007093340_remove_analytics_snapshots_segment_id_column.rb' - - 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb' - - 'db/post_migrate/20211022112202_add_cluster_id_location_index_to_vulnerability_occurrences.rb' - - 'db/post_migrate/20211027112901_drop_index_keys_on_expires_at_and_before_expiry_notification_undelivered.rb' - - 'db/post_migrate/20211102114802_update_vulnerability_occurrences_location.rb' - - 'db/post_migrate/20211118194239_drop_invalid_remediations.rb' - - 'db/post_migrate/20211213064821_add_agent_id_location_index_to_vulnerability_occurrences.rb' - - 'db/post_migrate/20211217120000_modify_kubernetes_resource_location_index_to_vulnerability_occurrences.rb' - - 'db/post_migrate/20220207080758_update_api_indexes_for_projects.rb' - - 'db/post_migrate/20220216201949_remove_package_files_limit_from_application_settings.rb' - - 'db/post_migrate/20220307192534_create_index_for_remove_duplicate_project_tag_releases.rb' - - 'db/post_migrate/20220307192645_remove_index_for_remove_duplicate_project_tag_releases.rb' - - 'db/post_migrate/20220307192725_create_unique_index_release_tag_project.rb' - 'db/post_migrate/20220415124802_remove_job_artifact_deprecated_geo_fields.rb' - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' - 'db/post_migrate/20220523164734_add_foreign_key_to_vulnerability_reads_casted_cluster_agent_id.rb' @@ -792,7 +770,6 @@ Layout/ArgumentAlignment: - 'db/post_migrate/20230130070623_add_index_on_packages_package_file_file_name.rb' - 'ee/app/components/namespaces/free_user_cap/base_alert_component.rb' - 'ee/app/components/namespaces/free_user_cap/enforcement_at_limit_alert_component.rb' - - 'ee/app/components/namespaces/free_user_cap/shared.rb' - 'ee/app/graphql/ee/mutations/alert_management/http_integration/create.rb' - 'ee/app/graphql/ee/mutations/alert_management/http_integration/update.rb' - 'ee/app/graphql/ee/mutations/boards/issues/issue_move_list.rb' @@ -1343,9 +1320,7 @@ Layout/ArgumentAlignment: - 'ee/spec/lib/ee/gitlab/background_migration/populate_approval_project_rules_with_security_orchestration_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/purge_stale_security_scans_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config/entry/bridge_spec.rb' @@ -1369,7 +1344,6 @@ Layout/ArgumentAlignment: - 'ee/spec/lib/gitlab/auth/otp/session_enforcer_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/certificate_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb' - 'ee/spec/lib/gitlab/ci/project_config_spec.rb' @@ -1731,7 +1705,6 @@ Layout/ArgumentAlignment: - 'lib/gitlab/alert_management/payload/managed_prometheus.rb' - 'lib/gitlab/alert_management/payload/prometheus.rb' - 'lib/gitlab/auth/ldap/adapter.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - 'lib/gitlab/background_migration/disable_legacy_open_source_license_for_no_issues_no_repo_projects.rb' - 'lib/gitlab/background_migration/disable_legacy_open_source_license_for_one_member_no_repo_projects.rb' @@ -1893,14 +1866,8 @@ Layout/ArgumentAlignment: - 'qa/qa/specs/features/api/3_create/repository/project_archive_compare_spec.rb' - 'qa/qa/specs/features/api/3_create/repository/tag_revision_trigger_prereceive_hook_spec.rb' - 'qa/qa/specs/features/api/4_verify/api_variable_inheritance_with_forward_pipeline_variables_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/group/group_member_access_request_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/group/transfer_group_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/group/transfer_project_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/integrations/jenkins/jenkins_build_status_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/integrations/jira/jira_basic_integration_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/dashboard_images_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/view_project_activity_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/parent_group_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/pages/new_static_page_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/project_wiki/project_based_content_creation_spec.rb' @@ -1960,7 +1927,6 @@ Layout/ArgumentAlignment: - 'qa/qa/specs/features/ee/browser_ui/15_growth/free_trial_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/group_wiki/delete_group_wiki_page_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' @@ -2092,7 +2058,6 @@ Layout/ArgumentAlignment: - 'spec/features/snippets/spam_snippets_spec.rb' - 'spec/features/snippets/user_creates_snippet_spec.rb' - 'spec/features/task_lists_spec.rb' - - 'spec/features/u2f_spec.rb' - 'spec/features/user_sees_revert_modal_spec.rb' - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/features/users/login_spec.rb' @@ -2158,8 +2123,6 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb' - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' - - 'spec/lib/gitlab/auth/u2f_webauthn_converter_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_cluster_agents_has_vulnerabilities_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_environment_tiers_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_group_features_spec.rb' @@ -2187,17 +2150,12 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_one_member_no_repo_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_projects_less_than_five_mb_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_projects_less_than_one_mb_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb' - 'spec/lib/gitlab/background_migration/expire_o_auth_tokens_spec.rb' - - 'spec/lib/gitlab/background_migration/extract_project_topics_into_separate_table_spec.rb' - 'spec/lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_shimo_confluence_integration_category_spec.rb' - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' - 'spec/lib/gitlab/background_migration/prune_stale_project_export_jobs_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'spec/lib/gitlab/background_migration/remove_backfilled_job_artifacts_expire_at_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_self_managed_wiki_notes_spec.rb' @@ -2334,7 +2292,6 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/profiler_spec.rb' - 'spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/redis/sidekiq_status_spec.rb' - 'spec/lib/gitlab/repository_cache/preloader_spec.rb' - 'spec/lib/gitlab/repository_cache_spec.rb' @@ -2460,10 +2417,6 @@ Layout/ArgumentAlignment: - 'spec/requests/api/graphql/mutations/admin/sidekiq_queues/delete_jobs_spec.rb' - 'spec/requests/api/graphql/mutations/alert_management/alerts/create_alert_issue_spec.rb' - 'spec/requests/api/graphql/mutations/boards/issues/issue_move_list_spec.rb' - - 'spec/requests/api/graphql/mutations/ci/job_cancel_spec.rb' - - 'spec/requests/api/graphql/mutations/ci/job_play_spec.rb' - - 'spec/requests/api/graphql/mutations/ci/job_retry_spec.rb' - - 'spec/requests/api/graphql/mutations/ci/job_unschedule_spec.rb' - 'spec/requests/api/graphql/mutations/ci/pipeline_retry_spec.rb' - 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb' - 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb' diff --git a/.rubocop_todo/layout/array_alignment.yml b/.rubocop_todo/layout/array_alignment.yml index 51e48bafa44..ef4e51b88da 100644 --- a/.rubocop_todo/layout/array_alignment.yml +++ b/.rubocop_todo/layout/array_alignment.yml @@ -101,7 +101,6 @@ Layout/ArrayAlignment: - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' - 'ee/spec/lib/audit/project_changes_auditor_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' - 'ee/spec/lib/gitlab/ci/config/security_orchestration_policies/processor_spec.rb' @@ -184,7 +183,6 @@ Layout/ArrayAlignment: - 'lib/gitlab/metrics/samplers/threads_sampler.rb' - 'lib/gitlab/object_hierarchy.rb' - 'lib/gitlab/project_authorizations.rb' - - 'lib/gitlab/rack_attack/instrumented_cache_store.rb' - 'lib/gitlab/reference_extractor.rb' - 'lib/gitlab/sidekiq_middleware/size_limiter/validator.rb' - 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric.rb' @@ -351,7 +349,6 @@ Layout/ArrayAlignment: - 'spec/services/spam/spam_verdict_service_spec.rb' - 'spec/support/helpers/kubernetes_helpers.rb' - 'spec/support/helpers/login_helpers.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' - 'spec/support/shared_examples/lib/email/email_shared_examples.rb' - 'spec/support/shared_examples/lib/wikis_api_examples.rb' - 'spec/support/shared_examples/models/label_note_shared_examples.rb' diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index 0f6447df6ab..95de4fabf40 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -40,7 +40,6 @@ Layout/EmptyLineAfterMagicComment: - 'app/helpers/ci/secure_files_helper.rb' - 'app/helpers/projects/google_cloud/cloudsql_helper.rb' - 'app/helpers/projects/ml/experiments_helper.rb' - - 'app/models/airflow.rb' - 'app/models/ci/job_token/allowlist.rb' - 'app/models/commit_signatures/gpg_signature.rb' - 'app/models/commit_signatures/x509_commit_signature.rb' @@ -144,11 +143,6 @@ Layout/EmptyLineAfterMagicComment: - 'danger/ce_ee_vue_templates/Dangerfile' - 'danger/feature_flag/Dangerfile' - 'danger/pajamas/Dangerfile' - - 'db/migrate/20210929121516_add_releases_author_id_id_created_at_index.rb' - - 'db/migrate/20211019153615_add_state_to_merge_request_assignees.rb' - - 'db/migrate/20211126113029_add_text_limit_for_static_objects_external_storage_auth_token.rb' - - 'db/migrate/20220204093120_create_analytics_cycle_analytics_aggregations.rb' - - 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb' - 'db/migrate/20220506154054_create_sync_namespace_details_trigger.rb' - 'db/migrate/20220524184149_create_sync_project_namespace_details_trigger.rb' - 'db/migrate/20220617141347_create_ci_secure_file_states.rb' @@ -162,8 +156,6 @@ Layout/EmptyLineAfterMagicComment: - 'db/migrate/20221219103007_add_name_to_ml_candidates.rb' - 'db/migrate/20221219122320_copy_clickhouse_connection_string_to_encrypted_var.rb' - 'db/migrate/20230111124512_remove_tmp_index_vulns_on_report_type.rb' - - 'db/post_migrate/20211209203820_add_tmp_index_on_report_type.rb' - - 'db/post_migrate/20211209203821_convert_stringified_raw_metadata_hash_to_json.rb' - 'db/post_migrate/20220412143551_add_partial_index_on_unencrypted_integrations.rb' - 'db/post_migrate/20220413011328_remove_partial_index_on_unencrypted_integrations.rb' - 'db/post_migrate/20220901071355_cleanup_attention_request_user_callouts.rb' @@ -337,7 +329,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/graphql/mutations/vulnerabilities/revert_to_detected_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' - 'ee/spec/helpers/ee/geo_helper_spec.rb' - - 'ee/spec/helpers/ee/groups/analytics/cycle_analytics_helper_spec.rb' - 'ee/spec/helpers/ee/invite_members_helper_spec.rb' - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' - 'ee/spec/helpers/ee/saml_providers_helper_spec.rb' @@ -452,11 +443,7 @@ Layout/EmptyLineAfterMagicComment: - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_project_import_level.rb' - 'lib/gitlab/background_migration/backfill_project_namespace_details.rb' - - 'lib/gitlab/background_migration/drop_invalid_security_findings.rb' - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' - - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - - 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb' - - 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb' - 'lib/gitlab/ci/secure_files/mobile_provision.rb' - 'lib/gitlab/cleanup/remote_uploads.rb' - 'lib/gitlab/database/migrations/background_migration_helpers.rb' @@ -475,7 +462,6 @@ Layout/EmptyLineAfterMagicComment: - 'lib/gitlab/import_export/recursive_merge_folders.rb' - 'lib/gitlab/import_export/shared.rb' - 'lib/gitlab/json_logger.rb' - - 'lib/gitlab/kubernetes/helm/v2/certificate.rb' - 'lib/gitlab/lfs/client.rb' - 'lib/gitlab/merge_requests/mergeability/check_result.rb' - 'lib/gitlab/merge_requests/mergeability/redis_interface.rb' @@ -550,7 +536,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/projects/jobs_controller_spec.rb' - 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb' - - 'spec/factories/airflow/dags.rb' - 'spec/factories/alert_management/alerts.rb' - 'spec/factories/draft_note.rb' - 'spec/factories/ml/candidates.rb' @@ -586,18 +571,13 @@ Layout/EmptyLineAfterMagicComment: - 'spec/graphql/types/label_type_spec.rb' - 'spec/graphql/types/users/email_type_spec.rb' - 'spec/graphql/types/users/namespace_commit_email_type_spec.rb' - - 'spec/helpers/analytics/cycle_analytics_helper_spec.rb' - 'spec/helpers/keyset_helper_spec.rb' - 'spec/helpers/sorting_helper_spec.rb' - 'spec/initializers/mail_encoding_patch_spec.rb' - 'spec/lib/constraints/admin_constrainer_spec.rb' - 'spec/lib/gitlab/analytics/date_filler_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/class_attributes_spec.rb' - 'spec/lib/gitlab/cleanup/remote_uploads_spec.rb' @@ -611,7 +591,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/lib/gitlab/database/migrations/observers/total_database_size_change_spec.rb' - 'spec/lib/gitlab/database/migrations/observers/transaction_duration_spec.rb' - 'spec/lib/gitlab/database/migrations/runner_spec.rb' - - 'spec/lib/gitlab/database/schema_validation/index_spec.rb' - 'spec/lib/gitlab/file_markdown_link_builder_spec.rb' - 'spec/lib/gitlab/file_type_detection_spec.rb' - 'spec/lib/gitlab/git/patches/collection_spec.rb' @@ -631,7 +610,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/lib/gitlab/json_cache_spec.rb' - 'spec/lib/gitlab/jwt_token_spec.rb' - 'spec/lib/gitlab/kroki_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/certificate_spec.rb' - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' - 'spec/lib/gitlab/markdown_cache/redis/extension_spec.rb' - 'spec/lib/gitlab/markdown_cache/redis/store_spec.rb' @@ -658,17 +636,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/lib/gitlab/x509/commit_spec.rb' - 'spec/lib/gitlab/x509/tag_spec.rb' - 'spec/lib/security/report_schema_version_matcher_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211110143306_add_not_null_constraint_to_security_findings_uuid_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20211207125331_remove_jobs_for_recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/migrations/20211210140629_encrypt_static_object_token_spec.rb' - - 'spec/migrations/20211217174331_mark_recalculate_finding_signatures_as_completed_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - - 'spec/migrations/20220202105733_delete_service_template_records_spec.rb' - - 'spec/migrations/20220222192524_create_not_null_constraint_releases_tag_spec.rb' - - 'spec/migrations/20220222192525_remove_null_releases_spec.rb' - - 'spec/migrations/20220309084954_remove_leftover_external_pull_request_deletions_spec.rb' - 'spec/migrations/20220322132242_update_pages_onboarding_state_spec.rb' - 'spec/migrations/20220329175119_remove_leftover_ci_job_artifact_deletions_spec.rb' - 'spec/models/analytics/cycle_analytics/aggregation_spec.rb' @@ -845,7 +812,6 @@ Layout/EmptyLineAfterMagicComment: - 'spec/support/helpers/fake_webauthn_device.rb' - 'spec/support/helpers/features/access_token_helpers.rb' - 'spec/support/helpers/features/iteration_helpers.rb' - - 'spec/support/helpers/features/list_rows_helpers.rb' - 'spec/support/helpers/features/responsive_table_helpers.rb' - 'spec/support/helpers/features/two_factor_helpers.rb' - 'spec/support/helpers/lfs_http_helpers.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index fed5e185898..a7dc68794aa 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -23,7 +23,6 @@ Layout/FirstHashElementIndentation: - 'app/helpers/tags_helper.rb' - 'app/models/application_setting.rb' - 'app/models/ci/build_metadata.rb' - - 'app/models/clusters/applications/crossplane.rb' - 'app/models/concerns/has_wiki_page_slug_attributes.rb' - 'app/models/concerns/subscribable.rb' - 'app/models/concerns/taskable.rb' @@ -199,8 +198,6 @@ Layout/FirstHashElementIndentation: - 'spec/lib/container_registry/client_spec.rb' - 'spec/lib/gitlab/application_rate_limiter_spec.rb' - 'spec/lib/gitlab/asciidoc_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_u2f_webauthn_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/ci/config_spec.rb' - 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb' diff --git a/.rubocop_todo/layout/line_continuation_spacing.yml b/.rubocop_todo/layout/line_continuation_spacing.yml index 0c256bce42b..bbb9e83ce48 100644 --- a/.rubocop_todo/layout/line_continuation_spacing.yml +++ b/.rubocop_todo/layout/line_continuation_spacing.yml @@ -16,7 +16,6 @@ Layout/LineContinuationSpacing: - 'app/models/environment.rb' - 'app/models/integrations/base_third_party_wiki.rb' - 'app/models/integrations/teamcity.rb' - - 'app/models/members/member_role.rb' - 'app/models/work_items/parent_link.rb' - 'app/services/feature_flags/update_service.rb' - 'app/services/issues/build_service.rb' @@ -151,7 +150,6 @@ Layout/LineContinuationSpacing: - 'spec/features/projects/files/user_edits_files_spec.rb' - 'spec/features/projects/files/user_replaces_files_spec.rb' - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' - - 'spec/features/u2f_spec.rb' - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb' @@ -181,7 +179,6 @@ Layout/LineContinuationSpacing: - 'spec/models/integrations/chat_message/push_message_spec.rb' - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' - 'spec/models/member_spec.rb' - - 'spec/models/members/member_role_spec.rb' - 'spec/models/operations/feature_flags_client_spec.rb' - 'spec/models/project_spec.rb' - 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index 06baecba0fd..826671ab30a 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -26,7 +26,6 @@ Layout/LineEndStringConcatenationIndentation: - 'app/models/concerns/spammable.rb' - 'app/models/environment.rb' - 'app/models/integrations/pivotaltracker.rb' - - 'app/models/members/member_role.rb' - 'app/models/merge_request_diff_commit.rb' - 'app/models/postgresql/replication_slot.rb' - 'app/presenters/packages/npm/package_presenter.rb' @@ -295,7 +294,6 @@ Layout/LineEndStringConcatenationIndentation: - 'spec/models/integrations/chat_message/push_message_spec.rb' - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' - 'spec/models/member_spec.rb' - - 'spec/models/members/member_role_spec.rb' - 'spec/models/operations/feature_flags_client_spec.rb' - 'spec/models/ssh_host_key_spec.rb' - 'spec/presenters/ci/pipeline_presenter_spec.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index ad0272376a7..01f4645f928 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -214,7 +214,6 @@ Layout/LineLength: - 'app/graphql/types/root_storage_statistics_type.rb' - 'app/graphql/types/snippets/visibility_scopes_enum.rb' - 'app/graphql/types/todo_action_enum.rb' - - 'app/helpers/analytics/cycle_analytics_helper.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/application_settings_helper.rb' - 'app/helpers/award_emoji_helper.rb' @@ -301,8 +300,6 @@ Layout/LineLength: - 'app/models/ci/runner.rb' - 'app/models/ci/unit_test.rb' - 'app/models/clusters/agent.rb' - - 'app/models/clusters/applications/knative.rb' - - 'app/models/clusters/applications/prometheus.rb' - 'app/models/clusters/cluster.rb' - 'app/models/commit_range.rb' - 'app/models/commit_status.rb' @@ -444,7 +441,6 @@ Layout/LineLength: - 'app/models/releases/link.rb' - 'app/models/remote_mirror.rb' - 'app/models/repository.rb' - - 'app/models/serverless/domain.rb' - 'app/models/service_desk_setting.rb' - 'app/models/suggestion.rb' - 'app/models/todo.rb' @@ -747,149 +743,8 @@ Layout/LineLength: - 'danger/roulette/Dangerfile' - 'danger/vue_shared_documentation/Dangerfile' - 'danger/z_metadata/Dangerfile' - - 'db/migrate/20210830085837_add_throttle_authenticated_git_lfs_columns.rb' - - 'db/migrate/20210831203408_upsert_base_work_item_types.rb' - - 'db/migrate/20210908140437_add_sidekiq_limits_to_application_settings.rb' - - 'db/migrate/20210909184349_add_index_package_id_id_on_package_files.rb' - - 'db/migrate/20210910015047_add_app_settings_dep_proxy_ttl_worker_capacity_check_constraint.rb' - - 'db/migrate/20210913224558_update_dependency_proxy_manifests_uniqueness_constraint.rb' - - 'db/migrate/20210914145810_add_throttle_deprecated_api_columns.rb' - - 'db/migrate/20210917153905_remove_pipeline_fk_from_packages_package_file_build_infos.rb' - - 'db/migrate/20210921063924_index_labels_using_varchar_pattern_ops.rb' - - 'db/migrate/20210928155022_improve_index_for_error_tracking.rb' - - 'db/migrate/20210929031049_add_unique_index_phone_on_user_details.rb' - - 'db/migrate/20210929115340_add_security_policy_configurations_management_project_id_foreign_key.rb' - - 'db/migrate/20210930081208_fix_deprecated_api_throttle_defaults.rb' - - 'db/migrate/20211005093558_add_range_partitioned_loose_fk_table.rb' - - 'db/migrate/20211006103122_change_helm_channel_length.rb' - - 'db/migrate/20211011004242_create_content_blocked_states.rb' - - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' - - 'db/migrate/20211013192749_add_states_into_approval_project_rules.rb' - - 'db/migrate/20211028132247_create_packages_npm_metadata.rb' - - 'db/migrate/20211101165656_create_upload_states.rb' - - 'db/migrate/20211110015252_add_agent_activity_events_foreign_keys.rb' - - 'db/migrate/20211111112425_create_merge_requests_compliance_violations.rb' - - 'db/migrate/20211116093739_add_foreign_key_to_incident_management_timeline_events_on_updated_by_user.rb' - - 'db/migrate/20211117174209_create_vulnerability_reads.rb' - - 'db/migrate/20211119111006_create_job_artifact_states.rb' - - 'db/migrate/20211119154221_create_pages_deployment_states.rb' - - 'db/migrate/20211126042235_add_sequence_column_to_sprints_table.rb' - - 'db/migrate/20211126115449_encrypt_static_objects_external_storage_auth_token.rb' - - 'db/migrate/20211130151724_add_foreign_key_to_incident_management_timeline_events_on_note.rb' - - 'db/migrate/20211130205719_add_uniqueness_for_evidence_occurrence_id.rb' - - 'db/migrate/20211201143042_create_lfs_object_states.rb' - - 'db/migrate/20211202094944_move_loose_fk_deleted_records_to_dynamic_schema.rb' - - 'db/migrate/20211207154413_add_ci_runners_index_on_created_at_where_active_is_false.rb' - - 'db/migrate/20211207154414_add_ci_runners_index_on_contacted_at_where_active_is_false.rb' - - 'db/migrate/20211216135651_add_index_to_cluster_agent_id.rb' - - 'db/migrate/20211217050753_remove_artifacts_archive_id_foreign_key_from_project_pages_metadata.rb' - - 'db/migrate/20220106230629_add_registry_migration_application_settings.rb' - - 'db/migrate/20220107091629_add_route_namespace_index.rb' - - 'db/migrate/20220111154951_add_index_to_ci_runners_token_expires_at.rb' - - 'db/migrate/20220112232605_add_member_namespace_index.rb' - - 'db/migrate/20220113125401_create_security_trainings.rb' - - 'db/migrate/20220118155846_add_runner_token_expiration_interval_settings_to_application_settings.rb' - - 'db/migrate/20220118155847_add_runner_token_expiration_interval_settings_to_namespace_settings.rb' - - 'db/migrate/20220119094023_add_unique_index_to_aed_verification_token.rb' - - 'db/migrate/20220120033115_create_alert_management_alert_metric_images.rb' - - 'db/migrate/20220120211831_temp_index_for_group_namespace_member_backfill.rb' - - 'db/migrate/20220125122725_add_topics_non_private_projects_count_index.rb' - - 'db/migrate/20220202115350_add_migration_indexes_to_container_repositories.rb' - - 'db/migrate/20220203091304_fix_unique_packages_index_excluding_pending_destruction_status.rb' - - 'db/migrate/20220204093120_create_analytics_cycle_analytics_aggregations.rb' - - 'db/migrate/20220207083129_add_users_get_by_id_limit_to_application_setting.rb' - - 'db/migrate/20220208171826_update_default_scan_method_of_dast_site_profile.rb' - - 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb' - - 'db/migrate/20220216110023_create_saved_replies.rb' - - 'db/migrate/20220217100008_add_container_registry_expiration_policies_caching_to_application_settings.rb' - - 'db/migrate/20220222072536_add_target_access_levels_to_broadcast_messages.rb' - - 'db/migrate/20220301003502_add_security_orchestration_policy_configuration_namespace_index.rb' - - 'db/migrate/20220301175104_change_security_orchestration_policy_configuration_project_index.rb' - - 'db/migrate/20220304062107_remove_unique_index_for_sprints_on_project_id_and_title.rb' - - 'db/migrate/20220310101118_update_holder_name_limit.rb' - 'db/migrate/20220314184209_add_group_fk_to_protected_environment_approval_rules.rb' - 'db/migrate/20220314204009_add_approval_rule_fk_to_deployment_approvals.rb' - - 'db/post_migrate/20210901184511_prepare_async_indexes_for_ci_builds.rb' - - 'db/post_migrate/20210907211557_finalize_ci_builds_bigint_conversion.rb' - - 'db/post_migrate/20210923135909_remove_delayed_project_removal_from_namespaces.rb' - - 'db/post_migrate/20210927153807_update_issues_relative_position_indexes.rb' - - 'db/post_migrate/20211007093340_remove_analytics_snapshots_segment_id_column.rb' - - 'db/post_migrate/20211012155931_remove_schedule_and_status_from_pending_alert_escalations.rb' - - 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb' - - 'db/post_migrate/20211031152417_add_indexes_to_issue_stage_events.rb' - - 'db/post_migrate/20211031154919_add_indexes_to_merge_request_stage_events.rb' - - 'db/post_migrate/20211104165220_remove_vulnerability_finding_links.rb' - - 'db/post_migrate/20211105135157_drop_ci_build_trace_sections.rb' - - 'db/post_migrate/20211112113300_remove_ci_pipeline_chat_data_fk_on_chat_names.rb' - - 'db/post_migrate/20211118194239_drop_invalid_remediations.rb' - - 'db/post_migrate/20211201101541_drop_clusters_applications_runners_ci_runners_fk.rb' - - 'db/post_migrate/20211207173510_remove_extra_finding_evidence_tables_foreign_keys.rb' - - 'db/post_migrate/20211207173511_remove_extra_finding_evidence_tables.rb' - - 'db/post_migrate/20211209103048_backfill_project_namespaces_for_group.rb' - - 'db/post_migrate/20211210140000_add_temporary_static_object_token_index.rb' - - 'db/post_migrate/20211210173137_remove_vulnerability_finding_links_again.rb' - - 'db/post_migrate/20211213102111_drop_ci_pipelines_mr_metrics_fk.rb' - - 'db/post_migrate/20211220120402_add_index_on_ci_pipelines_user_id_id_failure_reason.rb' - - 'db/post_migrate/20220104060049_remove_foreign_key_ci_group_variables_group_id.rb' - - 'db/post_migrate/20220105020514_remove_ci_minutes_additional_packs_namespace_id_foreign_key_constraint.rb' - - 'db/post_migrate/20220106231518_remove_foreign_key_ci_daily_build_group_report_results_group_id.rb' - - 'db/post_migrate/20220106233459_remove_foreign_key_ci_pending_builds_namespace_id.rb' - - 'db/post_migrate/20220106235626_remove_foreign_key_ci_runner_namespaces_namespace_id.rb' - - 'db/post_migrate/20220110224913_remove_dast_scanner_profiles_builds_ci_build_id_fk.rb' - - 'db/post_migrate/20220110231420_remove_requirements_management_test_reports_build_id_fk.rb' - - 'db/post_migrate/20220110233155_remove_dast_site_profiles_builds_ci_build_id_fk.rb' - - 'db/post_migrate/20220111002756_remove_security_scans_build_id_fk.rb' - - 'db/post_migrate/20220111221516_remove_projects_ci_pending_builds_fk.rb' - - 'db/post_migrate/20220112015940_remove_projects_ci_running_builds_fk.rb' - - 'db/post_migrate/20220112230642_remove_projects_ci_unit_tests_project_id_fk.rb' - - 'db/post_migrate/20220112232723_remove_projects_ci_daily_build_group_report_results_project_id_fk.rb' - - 'db/post_migrate/20220113013319_remove_projects_ci_freeze_periods_project_id_fk.rb' - - 'db/post_migrate/20220113014438_remove_projects_ci_resource_groups_project_id_fk.rb' - - 'db/post_migrate/20220113015830_remove_projects_ci_build_report_results_project_id_fk.rb' - - 'db/post_migrate/20220113035519_remove_users_ci_job_token_project_scope_links_added_by_id_fk.rb' - - 'db/post_migrate/20220113040447_remove_users_ci_pipeline_schedules_owner_id_fk.rb' - - 'db/post_migrate/20220113111440_schedule_fix_incorrect_max_seats_used.rb' - - 'db/post_migrate/20220119141736_remove_projects_ci_pipeline_artifacts_project_id_fk.rb' - - 'db/post_migrate/20220119143130_remove_projects_ci_sources_pipelines_source_project_id_fk.rb' - - 'db/post_migrate/20220119144458_remove_users_ci_triggers_owner_id_fk.rb' - - 'db/post_migrate/20220119151221_remove_merge_requests_ci_pipelines_merge_request_id_fk.rb' - - 'db/post_migrate/20220119153706_remove_ci_pipelines_merge_trains_pipeline_id_fk.rb' - - 'db/post_migrate/20220119154442_remove_ci_pipelines_merge_requests_head_pipeline_id_fk.rb' - - 'db/post_migrate/20220119193130_remove_ci_pipelines_dast_profiles_pipelines_ci_pipeline_id_fk.rb' - - 'db/post_migrate/20220119201340_remove_ci_pipelines_vulnerability_statistics_latest_pipeline_id_fk.rb' - - 'db/post_migrate/20220119203119_remove_ci_pipelines_vulnerability_occurrence_pipelines_pipeline_id_fk.rb' - - 'db/post_migrate/20220120123700_add_tmp_index_routes_id_for_namespaces.rb' - - 'db/post_migrate/20220121214752_remove_projects_ci_stages_project_id_fk.rb' - - 'db/post_migrate/20220121221651_remove_projects_ci_variables_project_id_fk.rb' - - 'db/post_migrate/20220124130028_dedup_runner_projects.rb' - - 'db/post_migrate/20220124145019_remove_projects_external_pull_requests_project_id_fk.rb' - - 'db/post_migrate/20220124151456_remove_projects_ci_triggers_project_id_fk.rb' - - 'db/post_migrate/20220124151949_remove_projects_ci_runner_projects_project_id_fk.rb' - - 'db/post_migrate/20220124152824_remove_projects_ci_subscriptions_projects_downstream_project_id_fk.rb' - - 'db/post_migrate/20220124153233_remove_projects_ci_job_artifacts_project_id_fk.rb' - - 'db/post_migrate/20220124180704_remove_projects_ci_builds_metadata_project_id_fk.rb' - - 'db/post_migrate/20220124184338_remove_projects_ci_subscriptions_projects_upstream_project_id_fk.rb' - - 'db/post_migrate/20220124204046_remove_projects_ci_sources_pipelines_project_id_fk.rb' - - 'db/post_migrate/20220124214131_remove_projects_ci_refs_project_id_fk.rb' - - 'db/post_migrate/20220124215857_remove_projects_ci_job_token_project_scope_links_source_project_id_fk.rb' - - 'db/post_migrate/20220124221521_remove_projects_ci_project_monthly_usages_project_id_fk.rb' - - 'db/post_migrate/20220125083520_remove_ci_pipelines_dast_site_profiles_pipelines_ci_pipeline_id_fk.rb' - - 'db/post_migrate/20220125084348_remove_ci_pipelines_vulnerability_feedback_pipeline_id_fk.rb' - - 'db/post_migrate/20220126201752_remove_projects_ci_job_token_project_scope_links_target_project_id_fk.rb' - - 'db/post_migrate/20220126202654_remove_projects_ci_sources_projects_source_project_id_fk.rb' - - 'db/post_migrate/20220126203421_remove_projects_ci_pipeline_schedules_project_id_fk.rb' - - 'db/post_migrate/20220126210021_remove_projects_ci_builds_project_id_fk.rb' - - 'db/post_migrate/20220126210657_remove_projects_ci_pipelines_project_id_fk.rb' - - 'db/post_migrate/20220128155814_fix_approval_rules_code_owners_rule_type_index.rb' - - 'db/post_migrate/20220131000000_index_job_artifacts_on_trace_type_and_expire_at.rb' - - 'db/post_migrate/20220201193033_add_unique_index_to_vulnerability_finding_links_with_truncate.rb' - - 'db/post_migrate/20220207080758_update_api_indexes_for_projects.rb' - - 'db/post_migrate/20220212120735_schedule_fix_incorrect_max_seats_used2.rb' - - 'db/post_migrate/20220224000000_async_build_trace_expire_at_index.rb' - - 'db/post_migrate/20220305223212_add_security_training_providers.rb' - - 'db/post_migrate/20220307192610_remove_duplicate_project_tag_releases.rb' - - 'db/post_migrate/20220308115219_schedule_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'db/post_migrate/20220308115502_schedule_reset_duplicate_ci_runners_token_values_on_projects.rb' - 'db/post_migrate/20220315171027_add_tmp_index_to_support_leaky_regex_cleanup.rb' - 'db/post_migrate/20220316102902_add_user_foreign_key_to_deploy_tokens.rb' - 'db/post_migrate/20220317161914_remove_ci_runners_ci_builds_runner_id_fk.rb' @@ -1026,7 +881,6 @@ Layout/LineLength: - 'ee/app/helpers/ee/button_helper.rb' - 'ee/app/helpers/ee/feature_flags_helper.rb' - 'ee/app/helpers/ee/geo_helper.rb' - - 'ee/app/helpers/ee/groups/analytics/cycle_analytics_helper.rb' - 'ee/app/helpers/ee/groups/settings_helper.rb' - 'ee/app/helpers/ee/groups_helper.rb' - 'ee/app/helpers/ee/import_helper.rb' @@ -1327,7 +1181,6 @@ Layout/LineLength: - 'ee/app/workers/repository_update_mirror_worker.rb' - 'ee/app/workers/security/orchestration_policy_rule_schedule_namespace_worker.rb' - 'ee/app/workers/security/orchestration_policy_rule_schedule_worker.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/config/routes/group.rb' - 'ee/config/routes/project.rb' - 'ee/db/fixtures/development/20_burndown.rb' @@ -1412,14 +1265,9 @@ Layout/LineLength: - 'ee/lib/ee/gitlab/auth/ldap/sync/users.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'ee/lib/ee/gitlab/background_migration/create_security_setting.rb' - - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - 'ee/lib/ee/gitlab/checks/push_rules/commit_check.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/lib/ee/gitlab/ci/config_ee.rb' @@ -1840,16 +1688,10 @@ Layout/LineLength: - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_namespace_statistics_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' @@ -1910,8 +1752,6 @@ Layout/LineLength: - 'ee/spec/lib/gitlab/auth/ldap/user_spec.rb' - 'ee/spec/lib/gitlab/auth/saml/user_spec.rb' - 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/populate_test_reports_issue_id_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/checks/diff_check_spec.rb' - 'ee/spec/lib/gitlab/ci/config/entry/job_spec.rb' - 'ee/spec/lib/gitlab/ci/config/security_orchestration_policies/processor_spec.rb' @@ -2010,14 +1850,9 @@ Layout/LineLength: - 'ee/spec/mailers/emails/requirements_spec.rb' - 'ee/spec/mailers/license_mailer_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/migrations/drop_invalid_remediations_spec.rb' - 'ee/spec/migrations/geo/migrate_ci_job_artifacts_to_separate_registry_spec.rb' - 'ee/spec/migrations/geo/migrate_lfs_objects_to_separate_registry_spec.rb' - 'ee/spec/migrations/geo/set_resync_flag_for_retried_projects_spec.rb' - - 'ee/spec/migrations/schedule_populate_test_reports_issue_id_spec.rb' - - 'ee/spec/migrations/schedule_requirements_migration_spec.rb' - - 'ee/spec/migrations/schedule_trace_expiry_removal_spec.rb' - - 'ee/spec/migrations/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/models/allowed_email_domain_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/group_level_spec.rb' - 'ee/spec/models/analytics/devops_adoption/enabled_namespace_spec.rb' @@ -2464,7 +2299,6 @@ Layout/LineLength: - 'ee/spec/services/jira/requests/issues/list_service_spec.rb' - 'ee/spec/services/ldap_group_reset_service_spec.rb' - 'ee/spec/services/members/activate_service_spec.rb' - - 'ee/spec/services/merge_commits/export_csv_service_spec.rb' - 'ee/spec/services/merge_requests/merge_service_spec.rb' - 'ee/spec/services/merge_requests/push_options_handler_service_spec.rb' - 'ee/spec/services/merge_requests/reset_approvals_service_spec.rb' @@ -2788,7 +2622,6 @@ Layout/LineLength: - 'lib/banzai/filter/markdown_post_escape_filter.rb' - 'lib/banzai/filter/references/external_issue_reference_filter.rb' - 'lib/banzai/filter/references/issue_reference_filter.rb' - - 'lib/banzai/filter/references/iteration_reference_filter.rb' - 'lib/banzai/filter/references/milestone_reference_filter.rb' - 'lib/banzai/filter/references/reference_filter.rb' - 'lib/banzai/filter/references/vulnerability_reference_filter.rb' @@ -2842,27 +2675,17 @@ Layout/LineLength: - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'lib/gitlab/background_migration/backfill_snippet_repositories.rb' - 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb' - - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - 'lib/gitlab/background_migration/create_security_setting.rb' - - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - - 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb' - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' - - 'lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature.rb' - - 'lib/gitlab/background_migration/populate_namespace_statistics.rb' - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - 'lib/gitlab/bitbucket_import/importer.rb' - 'lib/gitlab/bitbucket_server_import/importer.rb' - 'lib/gitlab/buffered_io.rb' @@ -3035,7 +2858,6 @@ Layout/LineLength: - 'lib/gitlab/import_export/file_importer.rb' - 'lib/gitlab/import_export/group/relation_tree_restorer.rb' - 'lib/gitlab/import_export/importer.rb' - - 'lib/gitlab/import_export/json/legacy_reader.rb' - 'lib/gitlab/import_export/json/streaming_serializer.rb' - 'lib/gitlab/import_export/lfs_saver.rb' - 'lib/gitlab/import_export/members_mapper.rb' @@ -3051,7 +2873,6 @@ Layout/LineLength: - 'lib/gitlab/jira_import.rb' - 'lib/gitlab/jira_import/base_importer.rb' - 'lib/gitlab/jira_import/issues_importer.rb' - - 'lib/gitlab/kubernetes/helm/pod.rb' - 'lib/gitlab/kubernetes/kubectl_cmd.rb' - 'lib/gitlab/kubernetes/pod_cmd.rb' - 'lib/gitlab/legacy_github_import/project_creator.rb' @@ -3141,7 +2962,6 @@ Layout/LineLength: - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' - 'lib/gitlab/usage_data_counters/issue_activity_unique_counter.rb' - 'lib/gitlab/usage_data_counters/jetbrains_plugin_activity_unique_counter.rb' - - 'lib/gitlab/usage_data_counters/track_unique_events.rb' - 'lib/gitlab/utils/delegator_override/error.rb' - 'lib/gitlab/utils/markdown.rb' - 'lib/gitlab/utils/override.rb' @@ -3229,7 +3049,6 @@ Layout/LineLength: - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/rate_limits_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - - 'qa/qa/specs/features/api/1_manage/users_spec.rb' - 'qa/qa/specs/features/api/3_create/merge_request/push_options_labels_spec.rb' - 'qa/qa/specs/features/api/3_create/merge_request/push_options_mwps_spec.rb' - 'qa/qa/specs/features/api/3_create/repository/default_branch_name_setting_spec.rb' @@ -3247,9 +3066,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/1_manage/login/log_into_mattermost_via_gitlab_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/maintain_log_in_mixed_env_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_badge_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb' @@ -3292,11 +3108,9 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/3_create/snippet/share_snippet_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/create_first_file_in_web_ide_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/link_to_line_in_web_ide_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/open_fork_in_web_ide_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/open_web_ide_from_diff_tab_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/review_merge_request_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/ci_variable/pipeline_with_protected_variable_spec.rb' - - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/create_and_process_pipeline_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_local_config_file_paths_with_wildcard_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_multiple_files_from_a_project_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/merge_mr_when_pipline_is_blocked_spec.rb' @@ -3330,8 +3144,6 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/share_group_with_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/burndown_chart/burndown_chart_spec.rb' @@ -3747,7 +3559,6 @@ Layout/LineLength: - 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb' - 'spec/finders/ci/runners_finder_spec.rb' - 'spec/finders/clusters/agents/authorizations/ci_access/finder_spec.rb' - - 'spec/finders/clusters/agent_authorizations_finder_spec.rb' - 'spec/finders/clusters_finder_spec.rb' - 'spec/finders/deploy_tokens/tokens_finder_spec.rb' - 'spec/finders/deployments_finder_spec.rb' @@ -3782,7 +3593,6 @@ Layout/LineLength: - 'spec/finders/projects_finder_spec.rb' - 'spec/finders/repositories/tree_finder_spec.rb' - 'spec/finders/security/security_jobs_finder_spec.rb' - - 'spec/finders/serverless_domain_finder_spec.rb' - 'spec/finders/snippets_finder_spec.rb' - 'spec/finders/tags_finder_spec.rb' - 'spec/finders/todos_finder_spec.rb' @@ -4064,32 +3874,17 @@ Layout/LineLength: - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb' - - 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/delete_orphaned_deployments_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/extract_project_topics_into_separate_table_spec.rb' - 'spec/lib/gitlab/background_migration/fix_duplicate_project_name_and_path_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_first_mentioned_in_commit_at_spec.rb' - 'spec/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata_spec.rb' - 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner_spec.rb' - - 'spec/lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature_spec.rb' - 'spec/lib/gitlab/background_migration/populate_container_repository_migration_plan_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_vulnerability_finding_links_spec.rb' - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - - 'spec/lib/gitlab/background_migration/update_timelogs_null_spent_at_spec.rb' - - 'spec/lib/gitlab/background_migration/update_timelogs_project_id_spec.rb' - - 'spec/lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group_spec.rb' - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' @@ -4334,8 +4129,6 @@ Layout/LineLength: - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kas_spec.rb' - 'spec/lib/gitlab/kubernetes/deployment_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/pod_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - 'spec/lib/gitlab/kubernetes/kubectl_cmd_spec.rb' - 'spec/lib/gitlab/kubernetes/namespace_spec.rb' @@ -4390,7 +4183,6 @@ Layout/LineLength: - 'spec/lib/gitlab/phabricator_import/user_finder_spec.rb' - 'spec/lib/gitlab/project_search_results_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/prometheus/query_variables_spec.rb' - 'spec/lib/gitlab/prometheus_client_spec.rb' @@ -4409,7 +4201,6 @@ Layout/LineLength: - 'spec/lib/gitlab/search/found_blob_spec.rb' - 'spec/lib/gitlab/search_results_spec.rb' - 'spec/lib/gitlab/serializer/pagination_spec.rb' - - 'spec/lib/gitlab/serverless/service_spec.rb' - 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb' - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' - 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb' @@ -4453,7 +4244,6 @@ Layout/LineLength: - 'spec/lib/gitlab/usage_data_counters/issue_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/jetbrains_plugin_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/merge_request_activity_unique_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/track_unique_events_spec.rb' - 'spec/lib/gitlab/usage_data_metrics_spec.rb' - 'spec/lib/gitlab/usage_data_non_sql_metrics_spec.rb' - 'spec/lib/gitlab/usage_data_queries_spec.rb' @@ -4501,38 +4291,10 @@ Layout/LineLength: - 'spec/mailers/emails/releases_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20210831203408_upsert_base_work_item_types_spec.rb' - - 'spec/migrations/20210907211557_finalize_ci_builds_bigint_conversion_spec.rb' - - 'spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211110143306_add_not_null_constraint_to_security_findings_uuid_spec.rb' - - 'spec/migrations/20211110151350_schedule_drop_invalid_security_findings_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20211117084814_migrate_remaining_u2f_registrations_spec.rb' - - 'spec/migrations/20211126204445_add_task_to_work_item_types_spec.rb' - - 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb' - - 'spec/migrations/20211203091642_add_index_to_projects_on_marked_for_deletion_at_spec.rb' - - 'spec/migrations/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4_spec.rb' - - 'spec/migrations/20211210140629_encrypt_static_object_token_spec.rb' - - 'spec/migrations/20220106111958_add_insert_or_update_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220106112043_add_update_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220106112085_add_update_vulnerability_reads_location_trigger_spec.rb' - - 'spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - - 'spec/migrations/20220222192524_create_not_null_constraint_releases_tag_spec.rb' - - 'spec/migrations/20220309084954_remove_leftover_external_pull_request_deletions_spec.rb' - 'spec/migrations/active_record/schema_spec.rb' - - 'spec/migrations/backfill_all_project_namespaces_spec.rb' - - 'spec/migrations/backfill_project_namespaces_for_group_spec.rb' - 'spec/migrations/cleanup_after_fixing_issue_when_admin_changed_primary_email_spec.rb' - 'spec/migrations/finalize_project_namespaces_backfill_spec.rb' - 'spec/migrations/fix_and_backfill_project_namespaces_for_projects_with_duplicate_name_spec.rb' - - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_features_spec.rb' - - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features_spec.rb' - - 'spec/migrations/remove_not_null_contraint_on_title_from_sprints_spec.rb' - - 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'spec/migrations/schedule_update_timelogs_null_spent_at_spec.rb' - - 'spec/migrations/update_invalid_member_states_spec.rb' - 'spec/models/active_session_spec.rb' - 'spec/models/acts_as_taggable_on/tag_spec.rb' - 'spec/models/acts_as_taggable_on/tagging_spec.rb' @@ -4563,9 +4325,6 @@ Layout/LineLength: - 'spec/models/ci/runner_spec.rb' - 'spec/models/ci/variable_spec.rb' - 'spec/models/clusters/agent_spec.rb' - - 'spec/models/clusters/applications/ingress_spec.rb' - - 'spec/models/clusters/applications/knative_spec.rb' - - 'spec/models/clusters/applications/prometheus_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - 'spec/models/clusters/platforms/kubernetes_spec.rb' - 'spec/models/commit_spec.rb' @@ -4702,7 +4461,6 @@ Layout/LineLength: - 'spec/models/resource_state_event_spec.rb' - 'spec/models/sent_notification_spec.rb' - 'spec/models/sentry_issue_spec.rb' - - 'spec/models/serverless/domain_spec.rb' - 'spec/models/service_desk_setting_spec.rb' - 'spec/models/snippet_input_action_spec.rb' - 'spec/models/snippet_repository_spec.rb' @@ -5255,7 +5013,6 @@ Layout/LineLength: - 'spec/spec_helper.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' - 'spec/support/capybara.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/database/prevent_cross_database_modification.rb' - 'spec/support/database/prevent_cross_joins.rb' - 'spec/support/db_cleaner.rb' diff --git a/.rubocop_todo/layout/parameter_alignment.yml b/.rubocop_todo/layout/parameter_alignment.yml index 4fafbab6024..56a96fb82c1 100644 --- a/.rubocop_todo/layout/parameter_alignment.yml +++ b/.rubocop_todo/layout/parameter_alignment.yml @@ -3,15 +3,9 @@ Layout/ParameterAlignment: Details: grace period Exclude: - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'lib/gitlab/cross_project_access.rb' - 'lib/gitlab/data_builder/push.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/support/helpers/content_security_policy_helpers.rb' - 'spec/support/helpers/migrations_helpers/vulnerabilities_helper.rb' - 'spec/support/helpers/repo_helpers.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index 7c914f47443..9bfa99f6591 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -20,7 +20,6 @@ Layout/SpaceInLambdaLiteral: - 'app/models/clusters/agent.rb' - 'app/models/clusters/agent_token.rb' - 'app/models/clusters/agents/activity_event.rb' - - 'app/models/clusters/applications/knative.rb' - 'app/models/clusters/cluster.rb' - 'app/models/clusters/kubernetes_namespace.rb' - 'app/models/commit_status.rb' @@ -119,7 +118,6 @@ Layout/SpaceInLambdaLiteral: - 'app/serializers/ci/job_entity.rb' - 'app/serializers/ci/pipeline_entity.rb' - 'app/serializers/ci/trigger_entity.rb' - - 'app/serializers/cluster_application_entity.rb' - 'app/serializers/concerns/user_status_tooltip.rb' - 'app/serializers/container_repository_entity.rb' - 'app/serializers/container_tag_entity.rb' @@ -277,7 +275,6 @@ Layout/SpaceInLambdaLiteral: - 'ee/app/services/groups/memberships/export_service.rb' - 'ee/app/services/groups/seat_usage_export_service.rb' - 'ee/app/services/historical_user_data/csv_service.rb' - - 'ee/app/services/merge_commits/export_csv_service.rb' - 'ee/app/services/user_permissions/export_service.rb' - 'ee/app/services/vulnerability_exports/exporters/csv_service.rb' - 'ee/app/workers/update_all_mirrors_worker.rb' @@ -351,7 +348,6 @@ Layout/SpaceInLambdaLiteral: - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'lib/gitlab/background_migration/purge_stale_security_scans.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - 'lib/gitlab/cache/helpers.rb' - 'lib/gitlab/ci/config/entry/inherit/default.rb' - 'lib/gitlab/ci/config/entry/inherit/variables.rb' diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml index 56b37ba768d..53e00f78f29 100644 --- a/.rubocop_todo/layout/space_inside_parens.yml +++ b/.rubocop_todo/layout/space_inside_parens.yml @@ -21,7 +21,6 @@ Layout/SpaceInsideParens: - 'ee/spec/lib/gitlab/search/index_curator_spec.rb' - 'ee/spec/lib/world_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/migrations/drop_invalid_remediations_spec.rb' - 'ee/spec/models/allowed_email_domain_spec.rb' - 'ee/spec/models/boards/epic_board_position_spec.rb' - 'ee/spec/models/dora/change_failure_rate_metric_spec.rb' @@ -166,7 +165,6 @@ Layout/SpaceInsideParens: - 'spec/lib/gitlab/kubernetes/rollout_status_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' - 'spec/lib/gitlab/middleware/same_site_cookies_spec.rb' - - 'spec/lib/gitlab/rack_attack/instrumented_cache_store_spec.rb' - 'spec/lib/gitlab/redis/cache_spec.rb' - 'spec/lib/gitlab/redis/queues_spec.rb' - 'spec/lib/gitlab/redis/shared_state_spec.rb' @@ -184,7 +182,6 @@ Layout/SpaceInsideParens: - 'spec/lib/security/ci_configuration/sast_iac_build_action_spec.rb' - 'spec/lib/security/ci_configuration/secret_detection_build_action_spec.rb' - 'spec/mailers/emails/profile_spec.rb' - - 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb' - 'spec/models/ci/pending_build_spec.rb' - 'spec/models/ci/running_build_spec.rb' - 'spec/models/ml/candidate_metric_spec.rb' diff --git a/.rubocop_todo/layout/trailing_whitespace.yml b/.rubocop_todo/layout/trailing_whitespace.yml index 1395fa78e35..35db371a055 100644 --- a/.rubocop_todo/layout/trailing_whitespace.yml +++ b/.rubocop_todo/layout/trailing_whitespace.yml @@ -6,7 +6,6 @@ Layout/TrailingWhitespace: - 'db/migrate/20220913082728_drop_index_cadence_create_iterations_automation.rb' - 'db/post_migrate/20220816163444_update_start_date_for_iterations_cadences.rb' - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' - - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' - 'lib/gitlab/pagination/keyset/sql_type_missing_error.rb' - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/support/helpers/x509_helpers.rb' diff --git a/.rubocop_todo/lint/ambiguous_operator_precedence.yml b/.rubocop_todo/lint/ambiguous_operator_precedence.yml index 8b6ef5db135..6b4ba8ff8d7 100644 --- a/.rubocop_todo/lint/ambiguous_operator_precedence.yml +++ b/.rubocop_todo/lint/ambiguous_operator_precedence.yml @@ -30,7 +30,6 @@ Lint/AmbiguousOperatorPrecedence: - 'app/services/issuable_links/create_service.rb' - 'app/services/issues/relative_position_rebalancing_service.rb' - 'app/services/jira/requests/base.rb' - - 'app/services/projects/blame_service.rb' - 'config/initializers/1_settings.rb' - 'config/initializers/carrierwave_patch.rb' - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' @@ -142,7 +141,6 @@ Lint/AmbiguousOperatorPrecedence: - 'spec/services/ci/pipeline_schedules/calculate_next_run_service_spec.rb' - 'spec/services/issues/relative_position_rebalancing_service_spec.rb' - 'spec/services/web_hook_service_spec.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/helpers/dependency_proxy_helpers.rb' - 'spec/support/models/ci/partitioning_testing/cascade_check.rb' - 'spec/support/shared_examples/features/sidebar_shared_examples.rb' diff --git a/.rubocop_todo/lint/ambiguous_regexp_literal.yml b/.rubocop_todo/lint/ambiguous_regexp_literal.yml index d0160d620d5..6f2b8f03f8a 100644 --- a/.rubocop_todo/lint/ambiguous_regexp_literal.yml +++ b/.rubocop_todo/lint/ambiguous_regexp_literal.yml @@ -62,8 +62,6 @@ Lint/AmbiguousRegexpLiteral: - 'spec/lib/gitlab/database/partitioning_spec.rb' - 'spec/lib/gitlab/database/query_analyzers/prevent_cross_database_modification_spec.rb' - 'spec/lib/gitlab/gitaly_client/with_feature_flag_actors_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/base_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/base_command_spec.rb' - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/array_scope_columns_spec.rb' - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb' - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' diff --git a/.rubocop_todo/lint/duplicate_branch.yml b/.rubocop_todo/lint/duplicate_branch.yml index 89d1ff7e2aa..6a171415cbc 100644 --- a/.rubocop_todo/lint/duplicate_branch.yml +++ b/.rubocop_todo/lint/duplicate_branch.yml @@ -33,4 +33,3 @@ Lint/DuplicateBranch: - 'lib/sidebars/groups/menus/settings_menu.rb' - 'qa/qa/resource/pipeline.rb' - 'scripts/rubocop-parse' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' diff --git a/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml b/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml index 813a27455a8..c0d46ba9e95 100644 --- a/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml +++ b/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml @@ -4,4 +4,3 @@ Lint/DuplicateRegexpCharacterClassElement: Details: grace period Exclude: - 'lib/gitlab/path_regex.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' diff --git a/.rubocop_todo/lint/empty_block.yml b/.rubocop_todo/lint/empty_block.yml index 43289b4bfbd..4cd66fdc30f 100644 --- a/.rubocop_todo/lint/empty_block.yml +++ b/.rubocop_todo/lint/empty_block.yml @@ -137,7 +137,6 @@ Lint/EmptyBlock: - 'spec/lib/gitlab/patch/prependable_spec.rb' - 'spec/lib/gitlab/profiler_spec.rb' - 'spec/lib/gitlab/quick_actions/extractor_spec.rb' - - 'spec/lib/gitlab/rack_attack/instrumented_cache_store_spec.rb' - 'spec/lib/gitlab/search_context/builder_spec.rb' - 'spec/lib/gitlab/session_spec.rb' - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' diff --git a/.rubocop_todo/lint/missing_cop_enable_directive.yml b/.rubocop_todo/lint/missing_cop_enable_directive.yml index 8346468e4fc..5a5d4d752d2 100644 --- a/.rubocop_todo/lint/missing_cop_enable_directive.yml +++ b/.rubocop_todo/lint/missing_cop_enable_directive.yml @@ -67,7 +67,6 @@ Lint/MissingCopEnableDirective: - 'danger/feature_flag/Dangerfile' - 'danger/pajamas/Dangerfile' - 'danger/z_metadata/Dangerfile' - - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' - 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb' - 'ee/app/controllers/ee/admin/dashboard_controller.rb' - 'ee/app/controllers/ee/admin/groups_controller.rb' @@ -137,7 +136,6 @@ Lint/MissingCopEnableDirective: - 'ee/app/services/ee/ci/queue/build_queue_service.rb' - 'ee/app/workers/ci/runners/stale_group_runners_prune_cron_worker.rb' - 'ee/app/workers/groups/export_memberships_worker.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/lib/api/ldap_group_links.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' @@ -151,27 +149,16 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/background_migration/backfill_imported_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - 'lib/gitlab/background_migration/delete_invalid_epic_issues.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb' - - 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'lib/gitlab/background_migration/purge_stale_security_scans.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - - 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb' - 'lib/gitlab/buffered_io.rb' - 'lib/gitlab/ci/reports/test_suite_summary.rb' - 'lib/gitlab/data_builder/push.rb' @@ -195,6 +182,5 @@ Lint/MissingCopEnableDirective: - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb' - 'spec/support/capybara.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/google_api/cloud_platform_helpers.rb' - 'tooling/danger/product_intelligence.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index 1ae433adc05..236e5c6a35a 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -77,13 +77,9 @@ Lint/RedundantCopDisableDirective: - 'config/initializers/wikicloth_redos_patch.rb' - 'config/initializers/wikicloth_ruby_3_patch.rb' - 'config/routes/api.rb' - - 'db/migrate/20210917134321_remove_temporary_index_for_project_topics_on_taggings.rb' - - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' - 'db/migrate/20220316022505_create_namespace_details.rb' - 'db/migrate/20220421141342_add_allowed_plans_to_ci_runners.rb' - 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb' - - 'db/post_migrate/20210906130643_drop_temporary_columns_and_triggers_for_taggings.rb' - - 'db/post_migrate/20211028100303_tmp_index_for_delete_issue_merge_request_taggings_records.rb' - 'db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb' - 'db/post_migrate/20220720090354_remove_pending_builds_covering_index_from_ci_builds.rb' @@ -151,7 +147,6 @@ Lint/RedundantCopDisableDirective: - 'ee/lib/gitlab/spdx/license.rb' - 'ee/lib/gitlab/status_page/storage/object.rb' - 'ee/spec/controllers/concerns/gitlab_subscriptions/seat_count_alert_spec.rb' - - 'ee/spec/controllers/concerns/registrations/verification_spec.rb' - 'ee/spec/controllers/concerns/routable_actions_spec.rb' - 'ee/spec/elastic/migrate/20221026082700_backfill_users_spec.rb' - 'ee/spec/features/boards/user_visits_board_spec.rb' @@ -188,12 +183,9 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'lib/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size.rb' - 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - 'lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics.rb' - 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb' - 'lib/gitlab/background_migration/re_expire_o_auth_tokens.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/bitbucket_import/importer.rb' @@ -274,7 +266,6 @@ Lint/RedundantCopDisableDirective: - 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_statistics_with_container_registry_size_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/remove_backfilled_job_artifacts_expire_at_batching_strategy_spec.rb' - - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects_spec.rb' - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' diff --git a/.rubocop_todo/lint/symbol_conversion.yml b/.rubocop_todo/lint/symbol_conversion.yml index da56c283180..450010d6c95 100644 --- a/.rubocop_todo/lint/symbol_conversion.yml +++ b/.rubocop_todo/lint/symbol_conversion.yml @@ -36,7 +36,6 @@ Lint/SymbolConversion: - 'ee/spec/helpers/ee/environments_helper_spec.rb' - 'ee/spec/helpers/subscriptions_helper_spec.rb' - 'ee/spec/lib/arkose/logger_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/params_parser_spec.rb' - 'ee/spec/lib/ee/gitlab/tracking_spec.rb' @@ -126,7 +125,6 @@ Lint/SymbolConversion: - 'spec/lib/gitlab/grape_logging/loggers/token_logger_spec.rb' - 'spec/lib/gitlab/harbor/client_spec.rb' - 'spec/lib/gitlab/harbor/query_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb' - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb' diff --git a/.rubocop_todo/lint/unused_block_argument.yml b/.rubocop_todo/lint/unused_block_argument.yml index 263cbf9e424..59e89969751 100644 --- a/.rubocop_todo/lint/unused_block_argument.yml +++ b/.rubocop_todo/lint/unused_block_argument.yml @@ -33,7 +33,6 @@ Lint/UnusedBlockArgument: - 'app/models/clusters/cluster.rb' - 'app/models/concerns/atomic_internal_id.rb' - 'app/models/concerns/avatarable.rb' - - 'app/models/concerns/enum_with_nil.rb' - 'app/models/concerns/mentionable.rb' - 'app/models/customer_relations/organization.rb' - 'app/models/integration.rb' @@ -87,7 +86,6 @@ Lint/UnusedBlockArgument: - 'config/initializers/warden.rb' - 'config/routes/project.rb' - 'config/routes/wiki.rb' - - 'db/post_migrate/20211117084814_migrate_remaining_u2f_registrations.rb' - 'ee/app/finders/security/training_providers/kontra_url_finder.rb' - 'ee/app/finders/security/training_providers/secure_code_warrior_url_finder.rb' - 'ee/app/graphql/resolvers/incident_management/escalation_policies_resolver.rb' @@ -141,7 +139,6 @@ Lint/UnusedBlockArgument: - 'ee/spec/graphql/resolvers/analytics/contribution_analytics/contributions_resolver_spec.rb' - 'ee/spec/lib/compliance_management/compliance_report/commit_loader_spec.rb' - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - 'ee/spec/lib/gitlab/insights/project_insights_config_spec.rb' - 'ee/spec/lib/gitlab/usage_data_metrics_spec.rb' @@ -333,7 +330,6 @@ Lint/UnusedBlockArgument: - 'spec/lib/feature_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/ci/parsers/terraform/tfplan_spec.rb' - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' - 'spec/lib/gitlab/ci/pipeline/logger_spec.rb' @@ -364,7 +360,6 @@ Lint/UnusedBlockArgument: - 'spec/lib/gitlab/utils/usage_data_spec.rb' - 'spec/lib/mattermost/session_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' - 'spec/models/active_session_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/concerns/ci/partitionable/switch_spec.rb' @@ -390,7 +385,6 @@ Lint/UnusedBlockArgument: - 'spec/services/snippets/update_service_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/database/prevent_cross_database_modification.rb' - 'spec/support/graphql/subscriptions/action_cable/mock_action_cable.rb' - 'spec/support/helpers/cycle_analytics_helpers.rb' diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml index 0d6f91336cb..0321c4409c6 100644 --- a/.rubocop_todo/lint/unused_method_argument.yml +++ b/.rubocop_todo/lint/unused_method_argument.yml @@ -105,7 +105,6 @@ Lint/UnusedMethodArgument: - 'app/models/ci/runner.rb' - 'app/models/concerns/bulk_insert_safe.rb' - 'app/models/concerns/cache_markdown_field.rb' - - 'app/models/concerns/ci/partitionable/partitioned_filter.rb' - 'app/models/concerns/cross_database_modification.rb' - 'app/models/concerns/issuable.rb' - 'app/models/concerns/mentionable.rb' @@ -326,7 +325,6 @@ Lint/UnusedMethodArgument: - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/api/helpers/notes_helpers_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/patch/geo_database_tasks_spec.rb' @@ -384,7 +382,6 @@ Lint/UnusedMethodArgument: - 'lib/gitlab/auth/database/authentication.rb' - 'lib/gitlab/auth/ldap/access.rb' - 'lib/gitlab/auth/ldap/adapter.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_project_settings.rb' - 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb' - 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb' @@ -599,8 +596,6 @@ Lint/UnusedMethodArgument: - 'spec/lib/banzai/reference_parser/base_parser_spec.rb' - 'spec/lib/gitlab/auth_spec.rb' - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/set_correct_vulnerability_state_spec.rb' - 'spec/lib/gitlab/background_migration/truncate_overlong_vulnerability_html_titles_spec.rb' @@ -611,9 +606,6 @@ Lint/UnusedMethodArgument: - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/worker_context/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware_spec.rb' - - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - - 'spec/migrations/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4_spec.rb' - 'spec/models/concerns/from_set_operator_spec.rb' - 'spec/models/concerns/redis_cacheable_spec.rb' - 'spec/policies/resource_state_event_policy_spec.rb' diff --git a/.rubocop_todo/metrics/cyclomatic_complexity.yml b/.rubocop_todo/metrics/cyclomatic_complexity.yml index 634ec6221f4..414f4f6243c 100644 --- a/.rubocop_todo/metrics/cyclomatic_complexity.yml +++ b/.rubocop_todo/metrics/cyclomatic_complexity.yml @@ -18,4 +18,3 @@ Metrics/CyclomaticComplexity: - 'qa/qa/runtime/browser.rb' - 'qa/qa/support/repeater.rb' - 'sidekiq_cluster/cli.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/metrics/perceived_complexity.yml b/.rubocop_todo/metrics/perceived_complexity.yml index 1eef5031e47..51ec88c1582 100644 --- a/.rubocop_todo/metrics/perceived_complexity.yml +++ b/.rubocop_todo/metrics/perceived_complexity.yml @@ -17,4 +17,3 @@ Metrics/PerceivedComplexity: - 'qa/qa/support/repeater.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' - 'sidekiq_cluster/cli.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/migration/background_migration_base_class.yml b/.rubocop_todo/migration/background_migration_base_class.yml index 6050a4d8055..6e5d34726e9 100644 --- a/.rubocop_todo/migration/background_migration_base_class.yml +++ b/.rubocop_todo/migration/background_migration_base_class.yml @@ -1,78 +1,45 @@ --- Migration/BackgroundMigrationBaseClass: Exclude: - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb' - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - - 'lib/gitlab/background_migration/backfill_integrations_type_new.rb' - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'lib/gitlab/background_migration/backfill_member_namespace_for_group_members.rb' - 'lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route.rb' - 'lib/gitlab/background_migration/backfill_namespace_id_for_project_route.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - 'lib/gitlab/background_migration/backfill_note_discussion_id.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - 'lib/gitlab/background_migration/backfill_project_settings.rb' - 'lib/gitlab/background_migration/backfill_snippet_repositories.rb' - 'lib/gitlab/background_migration/backfill_topics_title.rb' - - 'lib/gitlab/background_migration/backfill_upvotes_count_on_issues.rb' - - 'lib/gitlab/background_migration/backfill_user_namespace.rb' - 'lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb' - - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - 'lib/gitlab/background_migration/create_security_setting.rb' - - 'lib/gitlab/background_migration/delete_orphaned_deployments.rb' - - 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb' - - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - - 'lib/gitlab/background_migration/drop_invalid_security_findings.rb' - 'lib/gitlab/background_migration/encrypt_integration_properties.rb' - - 'lib/gitlab/background_migration/encrypt_static_object_token.rb' - - 'lib/gitlab/background_migration/extract_project_topics_into_separate_table.rb' - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' - 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb' - - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - - 'lib/gitlab/background_migration/fix_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/fix_projects_without_project_feature.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb' - 'lib/gitlab/background_migration/legacy_upload_mover.rb' - 'lib/gitlab/background_migration/legacy_uploads_migrator.rb' - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' - - 'lib/gitlab/background_migration/merge_topics_with_same_name.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/migrate_null_private_profile_to_false.rb' - 'lib/gitlab/background_migration/migrate_pages_to_zip_storage.rb' - 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb' - - 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb' - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' - 'lib/gitlab/background_migration/migrate_shimo_confluence_integration_category.rb' - - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - - 'lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature.rb' - 'lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds.rb' - 'lib/gitlab/background_migration/populate_container_repository_migration_plan.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'lib/gitlab/background_migration/populate_namespace_statistics.rb' - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb' - - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' - - 'lib/gitlab/background_migration/populate_topics_total_projects_count_cache.rb' - - 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'lib/gitlab/background_migration/populate_vulnerability_reads.rb' - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' - 'lib/gitlab/background_migration/project_namespaces/models/namespace.rb' - 'lib/gitlab/background_migration/project_namespaces/models/project.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - 'lib/gitlab/background_migration/remove_vulnerability_finding_links.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb' - - 'lib/gitlab/background_migration/steal_migrate_merge_request_diff_commit_users.rb' - - 'lib/gitlab/background_migration/update_timelogs_null_spent_at.rb' - - 'lib/gitlab/background_migration/update_timelogs_project_id.rb' - - 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb' - - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' diff --git a/.rubocop_todo/migration/background_migration_record.yml b/.rubocop_todo/migration/background_migration_record.yml index ec2b9fb6d6a..c803790525f 100644 --- a/.rubocop_todo/migration/background_migration_record.yml +++ b/.rubocop_todo/migration/background_migration_record.yml @@ -3,46 +3,24 @@ Migration/BackgroundMigrationRecord: Exclude: - 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'ee/lib/ee/gitlab/background_migration/create_security_setting.rb' - - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_requirements_to_work_items.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_draft_status_on_merge_requests.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - 'lib/gitlab/background_migration/backfill_topics_title.rb' - 'lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex.rb' - - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - - 'lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images.rb' - - 'lib/gitlab/background_migration/drop_invalid_security_findings.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - 'lib/gitlab/background_migration/encrypt_integration_properties.rb' - - 'lib/gitlab/background_migration/encrypt_static_object_token.rb' - - 'lib/gitlab/background_migration/extract_project_topics_into_separate_table.rb' - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' - 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb' - - 'lib/gitlab/background_migration/merge_topics_with_same_name.rb' - - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/migrate_null_private_profile_to_false.rb' - - 'lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics.rb' - - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' - - 'lib/gitlab/background_migration/populate_topics_total_projects_count_cache.rb' - 'lib/gitlab/background_migration/project_namespaces/models/namespace.rb' - 'lib/gitlab/background_migration/project_namespaces/models/project.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb' diff --git a/.rubocop_todo/migration/background_migrations.yml b/.rubocop_todo/migration/background_migrations.yml index ce2ad6da45e..fee1a7a0a6e 100644 --- a/.rubocop_todo/migration/background_migrations.yml +++ b/.rubocop_todo/migration/background_migrations.yml @@ -1,38 +1,6 @@ --- Migration/BackgroundMigrations: Exclude: - - 'db/post_migrate/20210830104800_reschedule_extract_project_topics_into_separate_table.rb' - - 'db/post_migrate/20210901153324_slice_merge_request_diff_commit_migrations.rb' - - 'db/post_migrate/20210909104800_reschedule_extract_project_topics_into_separate_table_2.rb' - - 'db/post_migrate/20211004110927_schedule_fix_first_mentioned_in_commit_at_job.rb' - - 'db/post_migrate/20211005010101_rereschedule_delete_orphaned_deployments.rb' - - 'db/post_migrate/20211005194425_schedule_requirements_migration.rb' - - 'db/post_migrate/20211006060436_schedule_populate_topics_total_projects_count_cache.rb' - - 'db/post_migrate/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3.rb' - - 'db/post_migrate/20211028155449_schedule_fix_merge_request_diff_commit_users_migration.rb' - - 'db/post_migrate/20211102114802_update_vulnerability_occurrences_location.rb' - - 'db/post_migrate/20211110151350_schedule_drop_invalid_security_findings.rb' - - 'db/post_migrate/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - - 'db/post_migrate/20211118194239_drop_invalid_remediations.rb' - - 'db/post_migrate/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4.rb' - - 'db/post_migrate/20211208171402_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'db/post_migrate/20211209203821_convert_stringified_raw_metadata_hash_to_json.rb' - - 'db/post_migrate/20211210140629_encrypt_static_object_token.rb' - - 'db/post_migrate/20211215090620_schedule_update_timelogs_null_spent_at.rb' - - 'db/post_migrate/20220107064845_populate_vulnerability_reads.rb' - - 'db/post_migrate/20220110171049_schedule_populate_test_reports_issue_id.rb' - - 'db/post_migrate/20220113111440_schedule_fix_incorrect_max_seats_used.rb' - - 'db/post_migrate/20220118204039_self_managed_reschedule_recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'db/post_migrate/20220125122640_schedule_populate_topics_non_private_projects_count.rb' - - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' - - 'db/post_migrate/20220204095121_backfill_namespace_statistics_with_dependency_proxy_size.rb' - - 'db/post_migrate/20220204194347_encrypt_integration_properties.rb' - - 'db/post_migrate/20220208115439_start_backfill_ci_queuing_tables.rb' - - 'db/post_migrate/20220212120735_schedule_fix_incorrect_max_seats_used2.rb' - - 'db/post_migrate/20220215190020_rerun_convert_stringified_raw_metadata_hash_to_json.rb' - - 'db/post_migrate/20220223124428_schedule_merge_topics_with_same_name.rb' - - 'db/post_migrate/20220308115219_schedule_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'db/post_migrate/20220308115502_schedule_reset_duplicate_ci_runners_token_values_on_projects.rb' - 'db/post_migrate/20220315171129_cleanup_draft_data_from_faulty_regex.rb' - 'db/post_migrate/20220316202640_populate_container_repositories_migration_plan.rb' - 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb' diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml index 76144801438..9b6d26a53ca 100644 --- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml +++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml @@ -8,7 +8,6 @@ Naming/HeredocDelimiterNaming: - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'app/workers/concerns/limited_capacity/job_tracker.rb' - 'config/initializers/01_secret_token.rb' - - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/db/geo/migrate/20180322062741_migrate_ci_job_artifacts_to_separate_registry.rb' - 'ee/db/geo/migrate/20191010204941_migrate_lfs_objects_to_separate_registry.rb' - 'ee/lib/api/elasticsearch_indexed_namespaces.rb' @@ -83,14 +82,6 @@ Naming/HeredocDelimiterNaming: - 'spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb' - 'spec/lib/gitlab/import_export/attributes_permitter_spec.rb' - 'spec/lib/gitlab/import_export/config_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/delete_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/init_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/install_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/patch_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/reset_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/delete_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/install_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/patch_command_spec.rb' - 'spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb' - 'spec/lib/gitlab/patch/database_config_spec.rb' - 'spec/lib/gitlab/prometheus/additional_metrics_parser_spec.rb' diff --git a/.rubocop_todo/performance/map_compact.yml b/.rubocop_todo/performance/map_compact.yml index 5f2331d6edd..21cf14275f8 100644 --- a/.rubocop_todo/performance/map_compact.yml +++ b/.rubocop_todo/performance/map_compact.yml @@ -69,7 +69,6 @@ Performance/MapCompact: - 'ee/lib/ee/api/entities/experiment.rb' - 'ee/lib/ee/gitlab/auth/ldap/person.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'ee/lib/elastic/latest/repository_instance_proxy.rb' - 'ee/lib/gitlab/alert_management/alert_payload_field_extractor.rb' - 'ee/lib/gitlab/ci/parsers/security/dast.rb' diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml index a18dec335d1..e536c22e518 100644 --- a/.rubocop_todo/rails/file_path.yml +++ b/.rubocop_todo/rails/file_path.yml @@ -78,7 +78,6 @@ Rails/FilePath: - 'spec/factories/file_uploaders.rb' - 'spec/factories/packages/debian/distribution_key.rb' - 'spec/factories/pages_domains.rb' - - 'spec/factories/serverless/domain_cluster.rb' - 'spec/features/admin/admin_appearance_spec.rb' - 'spec/features/groups/group_settings_spec.rb' - 'spec/features/groups/import_export/import_file_spec.rb' @@ -101,7 +100,6 @@ Rails/FilePath: - 'spec/helpers/blob_helper_spec.rb' - 'spec/helpers/startupjs_helper_spec.rb' - 'spec/lib/backup/database_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_first_mentioned_in_commit_at_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' - 'spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base_spec.rb' - 'spec/lib/gitlab/database/schema_migrations/context_spec.rb' diff --git a/.rubocop_todo/rails/inverse_of.yml b/.rubocop_todo/rails/inverse_of.yml index 412d28a11da..59c0e14e180 100644 --- a/.rubocop_todo/rails/inverse_of.yml +++ b/.rubocop_todo/rails/inverse_of.yml @@ -6,7 +6,6 @@ Rails/InverseOf: - 'app/models/ci/sources/pipeline.rb' - 'app/models/ci/trigger_request.rb' - 'app/models/ci/unit_test_failure.rb' - - 'app/models/clusters/applications/runner.rb' - 'app/models/clusters/cluster.rb' - 'app/models/clusters/concerns/application_core.rb' - 'app/models/clusters/integrations/prometheus.rb' diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml index 7eb70947497..b86b26b31fa 100644 --- a/.rubocop_todo/rails/pluck.yml +++ b/.rubocop_todo/rails/pluck.yml @@ -28,7 +28,6 @@ Rails/Pluck: - 'ee/lib/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/gitlab/auth/ldap/person.rb' - 'ee/lib/ee/gitlab/background_migration/delete_invalid_epic_issues.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/lib/elastic/latest/custom_language_analyzers.rb' - 'ee/lib/gitlab/search/index_curator.rb' diff --git a/.rubocop_todo/rails/redundant_foreign_key.yml b/.rubocop_todo/rails/redundant_foreign_key.yml index 9824c78a8fc..fc0f1c97fba 100644 --- a/.rubocop_todo/rails/redundant_foreign_key.yml +++ b/.rubocop_todo/rails/redundant_foreign_key.yml @@ -14,7 +14,6 @@ Rails/RedundantForeignKey: - 'app/models/ci/sources/pipeline.rb' - 'app/models/ci/stage.rb' - 'app/models/ci/unit_test_failure.rb' - - 'app/models/clusters/applications/runner.rb' - 'app/models/clusters/concerns/application_core.rb' - 'app/models/clusters/integrations/prometheus.rb' - 'app/models/commit_signatures/x509_commit_signature.rb' @@ -59,7 +58,3 @@ Rails/RedundantForeignKey: - 'ee/app/models/vulnerabilities/finding.rb' - 'ee/app/models/vulnerabilities/finding_signature.rb' - 'ee/app/models/vulnerabilities/identifier.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index ced205ff8ea..2cabb373326 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -305,8 +305,6 @@ RSpec/ContextWording: - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rule_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' @@ -424,7 +422,6 @@ RSpec/ContextWording: - 'ee/spec/lib/system_check/rake_task/geo_task_spec.rb' - 'ee/spec/mailers/ee/emails/issues_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/migrations/schedule_requirements_migration_spec.rb' - 'ee/spec/models/alert_management/alert_payload_field_spec.rb' - 'ee/spec/models/allowed_email_domain_spec.rb' - 'ee/spec/models/application_setting_spec.rb' @@ -782,7 +779,6 @@ RSpec/ContextWording: - 'ee/spec/services/jira/jql_builder_service_spec.rb' - 'ee/spec/services/ldap_group_reset_service_spec.rb' - 'ee/spec/services/members/activate_service_spec.rb' - - 'ee/spec/services/merge_commits/export_csv_service_spec.rb' - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - 'ee/spec/services/merge_requests/build_service_spec.rb' - 'ee/spec/services/merge_requests/merge_service_spec.rb' @@ -941,10 +937,8 @@ RSpec/ContextWording: - 'ee/spec/workers/requirements_management/process_requirements_reports_worker_spec.rb' - 'ee/spec/workers/security/track_secure_scans_worker_spec.rb' - 'ee/spec/workers/sync_seat_link_worker_spec.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/milestone/assign_milestone_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/testing/endpoint_coverage_spec.rb' @@ -1343,7 +1337,6 @@ RSpec/ContextWording: - 'spec/finders/ci/runners_finder_spec.rb' - 'spec/finders/cluster_ancestors_finder_spec.rb' - 'spec/finders/clusters/agents/authorizations/ci_access/finder_spec.rb' - - 'spec/finders/clusters/agent_authorizations_finder_spec.rb' - 'spec/finders/clusters/agents_finder_spec.rb' - 'spec/finders/clusters/kubernetes_namespace_finder_spec.rb' - 'spec/finders/contributed_projects_finder_spec.rb' @@ -1399,7 +1392,6 @@ RSpec/ContextWording: - 'spec/frontend/fixtures/merge_requests.rb' - 'spec/frontend/fixtures/projects.rb' - 'spec/frontend/fixtures/search.rb' - - 'spec/frontend/fixtures/u2f.rb' - 'spec/frontend/fixtures/webauthn.rb' - 'spec/graphql/mutations/alert_management/create_alert_issue_spec.rb' - 'spec/graphql/mutations/alert_management/http_integration/create_spec.rb' @@ -1660,11 +1652,9 @@ RSpec/ContextWording: - 'spec/lib/gitlab/auth_spec.rb' - 'spec/lib/gitlab/authorized_keys_spec.rb' - 'spec/lib/gitlab/avatar_cache_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/bare_repository_import/repository_spec.rb' @@ -1923,9 +1913,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb' - 'spec/lib/gitlab/import_export/importer_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/file_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/shared_example.rb' - 'spec/lib/gitlab/import_export/json/ndjson_reader_spec.rb' - 'spec/lib/gitlab/import_export/json/streaming_serializer_spec.rb' - 'spec/lib/gitlab/import_export/members_mapper_spec.rb' @@ -1951,8 +1938,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kas_spec.rb' - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/certificate_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' @@ -2007,7 +1992,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/project_authorizations_spec.rb' - 'spec/lib/gitlab/project_search_results_spec.rb' - 'spec/lib/gitlab/prometheus/adapter_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/validate_query_spec.rb' - 'spec/lib/gitlab/prometheus/query_variables_spec.rb' @@ -2089,7 +2073,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/quick_action_activity_unique_counter_spec.rb' - 'spec/lib/gitlab/usage_data_counters/search_counter_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/track_unique_events_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/lazy_attributes_spec.rb' - 'spec/lib/gitlab/utils/mime_type_spec.rb' @@ -2140,7 +2123,6 @@ RSpec/ContextWording: - 'spec/mailers/emails/releases_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/finalize_traversal_ids_background_migrations_spec.rb' - 'spec/models/ability_spec.rb' - 'spec/models/active_session_spec.rb' - 'spec/models/alert_management/alert_spec.rb' @@ -2183,13 +2165,6 @@ RSpec/ContextWording: - 'spec/models/ci/trigger_spec.rb' - 'spec/models/ci/variable_spec.rb' - 'spec/models/clusters/agent_spec.rb' - - 'spec/models/clusters/applications/crossplane_spec.rb' - - 'spec/models/clusters/applications/helm_spec.rb' - - 'spec/models/clusters/applications/ingress_spec.rb' - - 'spec/models/clusters/applications/jupyter_spec.rb' - - 'spec/models/clusters/applications/knative_spec.rb' - - 'spec/models/clusters/applications/prometheus_spec.rb' - - 'spec/models/clusters/applications/runner_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - 'spec/models/clusters/clusters_hierarchy_spec.rb' - 'spec/models/clusters/kubernetes_namespace_spec.rb' @@ -2623,7 +2598,6 @@ RSpec/ContextWording: - 'spec/scripts/pipeline_test_report_builder_spec.rb' - 'spec/serializers/analytics_build_entity_spec.rb' - 'spec/serializers/ci/pipeline_entity_spec.rb' - - 'spec/serializers/cluster_application_entity_spec.rb' - 'spec/serializers/deploy_keys/basic_deploy_key_entity_spec.rb' - 'spec/serializers/diff_file_base_entity_spec.rb' - 'spec/serializers/diffs_entity_spec.rb' @@ -2965,7 +2939,6 @@ RSpec/ContextWording: - 'spec/support/shared_contexts/features/integrations/group_integrations_shared_context.rb' - 'spec/support/shared_contexts/features/integrations/instance_and_group_integrations_shared_context.rb' - 'spec/support/shared_contexts/features/integrations/instance_integrations_shared_context.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' - 'spec/support/shared_contexts/features/integrations/project_integrations_jira_context.rb' - 'spec/support/shared_contexts/features/integrations/project_integrations_shared_context.rb' - 'spec/support/shared_contexts/finders/group_projects_finder_shared_contexts.rb' diff --git a/.rubocop_todo/rspec/described_class.yml b/.rubocop_todo/rspec/described_class.yml index 99800ab8257..aee75fe32d4 100644 --- a/.rubocop_todo/rspec/described_class.yml +++ b/.rubocop_todo/rspec/described_class.yml @@ -93,7 +93,6 @@ RSpec/DescribedClass: - 'spec/lib/gitlab/relative_positioning/range_spec.rb' - 'spec/lib/gitlab/runtime_spec.rb' - 'spec/lib/gitlab/seeder_spec.rb' - - 'spec/lib/gitlab/serverless/service_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/client_spec.rb' - 'spec/lib/gitlab/usage/metrics/aggregates/sources/redis_hll_spec.rb' - 'spec/lib/gitlab/utils/measuring_spec.rb' @@ -107,7 +106,6 @@ RSpec/DescribedClass: - 'spec/models/alert_management/alert_spec.rb' - 'spec/models/application_record_spec.rb' - 'spec/models/application_setting_spec.rb' - - 'spec/models/awareness_session_spec.rb' - 'spec/models/broadcast_message_spec.rb' - 'spec/models/chat_name_spec.rb' - 'spec/models/ci/build_runner_session_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 154a3056635..8cecf3677dc 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -17,7 +17,6 @@ RSpec/ExpectChange: - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb' - 'ee/spec/lib/ee/feature_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/delete_approval_rules_with_vulnerability_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners_spec.rb' - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/access_spec.rb' @@ -196,7 +195,6 @@ RSpec/ExpectChange: - 'ee/spec/workers/groups/create_event_worker_spec.rb' - 'ee/spec/workers/import_software_licenses_worker_spec.rb' - 'ee/spec/workers/sync_seat_link_request_worker_spec.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'ee/spec/workers/vulnerabilities/mark_dropped_as_resolved_worker_spec.rb' - 'spec/controllers/admin/groups_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' @@ -241,11 +239,7 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/auth_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_namespace_statistics_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_self_managed_wiki_notes_spec.rb' - 'spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb' @@ -257,7 +251,6 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/database/tables_truncate_spec.rb' - 'spec/lib/gitlab/diff/file_spec.rb' - 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb' - - 'spec/lib/gitlab/email/hook/validate_addresses_interceptor_spec.rb' - 'spec/lib/gitlab/github_import/importer/diff_note_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/events/changed_reviewer_spec.rb' - 'spec/lib/gitlab/github_import/importer/note_importer_spec.rb' @@ -273,7 +266,6 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/pages/cache_control_spec.rb' - 'spec/lib/gitlab/query_limiting/transaction_spec.rb' - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb' - - 'spec/migrations/20211126204445_add_task_to_work_item_types_spec.rb' - 'spec/migrations/20220321234317_remove_all_issuable_escalation_statuses_spec.rb' - 'spec/migrations/20220506154054_create_sync_namespace_details_trigger_spec.rb' - 'spec/migrations/20220512190659_remove_web_hooks_web_hook_logs_web_hook_id_fk_spec.rb' @@ -286,7 +278,6 @@ RSpec/ExpectChange: - 'spec/migrations/cleanup_mr_attention_request_todos_spec.rb' - 'spec/migrations/cleanup_vulnerability_state_transitions_with_same_from_state_to_state_spec.rb' - 'spec/migrations/delete_migrate_shared_vulnerability_scanners_spec.rb' - - 'spec/models/awareness_session_spec.rb' - 'spec/models/ci/build_metadata_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/job_artifact_spec.rb' @@ -445,6 +436,5 @@ RSpec/ExpectChange: - 'spec/services/work_items/task_list_reference_replacement_service_spec.rb' - 'spec/services/work_items/update_service_spec.rb' - 'spec/services/work_items/widgets/hierarchy_service/update_service_spec.rb' - - 'spec/services/work_items/widgets/milestone_service/update_service_spec.rb' - 'spec/services/work_items/widgets/start_and_due_date_service/update_service_spec.rb' - 'spec/services/x509_certificate_revoke_service_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index 8d36ed7520c..d156aa45035 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -247,7 +247,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/import_failure_service_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/shared_example.rb' - 'spec/lib/gitlab/import_export/json/ndjson_reader_spec.rb' - 'spec/lib/gitlab/import_export/lfs_saver_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' @@ -257,7 +256,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/import_export/snippets_repo_restorer_spec.rb' - 'spec/lib/gitlab/jira_import/labels_importer_spec.rb' - 'spec/lib/gitlab/kas/client_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - 'spec/lib/gitlab/memory/instrumentation_spec.rb' @@ -439,7 +437,6 @@ RSpec/ExpectInHook: - 'spec/services/projects/update_remote_mirror_service_spec.rb' - 'spec/services/projects/update_repository_storage_service_spec.rb' - 'spec/services/search_service_spec.rb' - - 'spec/services/serverless/associate_domain_service_spec.rb' - 'spec/services/snippets/update_repository_storage_service_spec.rb' - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/services/suggestions/create_service_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml index 752f10101b8..70046f783da 100644 --- a/.rubocop_todo/rspec/factory_bot/avoid_create.yml +++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml @@ -27,7 +27,6 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/helpers/ee/feature_flags_helper_spec.rb' - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' - 'ee/spec/helpers/ee/graph_helper_spec.rb' - - 'ee/spec/helpers/ee/groups/analytics/cycle_analytics_helper_spec.rb' - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - 'ee/spec/helpers/ee/hooks_helper_spec.rb' @@ -205,7 +204,6 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/views/groups/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/groups/settings/_remove.html.haml_spec.rb' - 'ee/spec/views/groups/settings/reporting/show.html.haml_spec.rb' - - 'ee/spec/views/layouts/_search.html.haml_spec.rb' - 'ee/spec/views/layouts/application.html.haml_spec.rb' - 'ee/spec/views/layouts/group.html.haml_spec.rb' - 'ee/spec/views/layouts/header/_current_user_dropdown.html.haml_spec.rb' @@ -249,7 +247,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/components/pajamas/avatar_component_spec.rb' - 'spec/helpers/admin/identities_helper_spec.rb' - 'spec/helpers/admin/user_actions_helper_spec.rb' - - 'spec/helpers/analytics/cycle_analytics_helper_spec.rb' - 'spec/helpers/appearances_helper_spec.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' @@ -428,7 +425,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/serializers/ci/lint/result_serializer_spec.rb' - 'spec/serializers/ci/pipeline_entity_spec.rb' - 'spec/serializers/ci/trigger_entity_spec.rb' - - 'spec/serializers/cluster_application_entity_spec.rb' - 'spec/serializers/cluster_entity_spec.rb' - 'spec/serializers/cluster_serializer_spec.rb' - 'spec/serializers/clusters/kubernetes_error_entity_spec.rb' @@ -554,7 +550,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/views/groups/edit.html.haml_spec.rb' - 'spec/views/groups/new.html.haml_spec.rb' - 'spec/views/help/instance_configuration.html.haml_spec.rb' - - 'spec/views/layouts/_search.html.haml_spec.rb' - 'spec/views/layouts/application.html.haml_spec.rb' - 'spec/views/layouts/devise.html.haml_spec.rb' - 'spec/views/layouts/fullscreen.html.haml_spec.rb' diff --git a/.rubocop_todo/rspec/file_path.yml b/.rubocop_todo/rspec/file_path.yml index 9cc2e1b5b6c..5d543055029 100644 --- a/.rubocop_todo/rspec/file_path.yml +++ b/.rubocop_todo/rspec/file_path.yml @@ -24,7 +24,6 @@ RSpec/FilePath: - 'spec/docs_screenshots/container_registry_docs.rb' - 'spec/docs_screenshots/wiki_docs.rb' - 'spec/lib/error_tracking/sentry_client/event_spec.rb' - - 'spec/lib/gitlab/import_export/import_export_equivalence_spec.rb' - 'spec/lib/gitlab/import_export/import_export_spec.rb' - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' diff --git a/.rubocop_todo/rspec/hooks_before_examples.yml b/.rubocop_todo/rspec/hooks_before_examples.yml index 24b3ef082af..66b2fc48874 100644 --- a/.rubocop_todo/rspec/hooks_before_examples.yml +++ b/.rubocop_todo/rspec/hooks_before_examples.yml @@ -26,19 +26,14 @@ RSpec/HooksBeforeExamples: - 'ee/spec/services/merge_trains/create_pipeline_service_spec.rb' - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - - 'qa/qa/specs/features/api/1_manage/user_inherited_access_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_with_2fa_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/project_access_token_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/user/user_inherited_access_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/revert/revert_commit_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide_old/open_fork_in_web_ide_spec.rb' - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_git_access_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb' - 'qa/spec/specs/runner_spec.rb' diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml index 7dc84c57434..fe632cdd57b 100644 --- a/.rubocop_todo/rspec/instance_variable.yml +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -75,7 +75,6 @@ RSpec/InstanceVariable: - 'spec/features/merge_requests/user_lists_merge_requests_spec.rb' - 'spec/features/projects/diffs/diff_show_spec.rb' - 'spec/features/triggers_spec.rb' - - 'spec/features/u2f_spec.rb' - 'spec/finders/admin/plans_finder_spec.rb' - 'spec/finders/groups_finder_spec.rb' - 'spec/frontend/fixtures/listbox.rb' @@ -83,7 +82,6 @@ RSpec/InstanceVariable: - 'spec/frontend/fixtures/sessions.rb' - 'spec/frontend/fixtures/tabs.rb' - 'spec/frontend/fixtures/timezones.rb' - - 'spec/frontend/fixtures/u2f.rb' - 'spec/frontend/fixtures/webauthn.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/award_emoji_helper_spec.rb' @@ -100,7 +98,6 @@ RSpec/InstanceVariable: - 'spec/lib/extracts_ref_spec.rb' - 'spec/lib/gitlab/auth/auth_finders_spec.rb' - 'spec/lib/gitlab/auth/ldap/person_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/chat_name_token_spec.rb' - 'spec/lib/gitlab/ci/lint_spec.rb' @@ -122,7 +119,6 @@ RSpec/InstanceVariable: - 'spec/lib/gitlab/version_info_spec.rb' - 'spec/lib/gitlab/x509/certificate_spec.rb' - 'spec/mailers/emails/issues_spec.rb' - - 'spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb' - 'spec/models/group_spec.rb' - 'spec/models/integrations/assembla_spec.rb' - 'spec/models/integrations/campfire_spec.rb' diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/missing_feature_category.yml index 56d617368af..ae2f7b7900f 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/missing_feature_category.yml @@ -69,7 +69,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' - 'ee/spec/finders/ee/autocomplete/users_finder_spec.rb' - 'ee/spec/finders/ee/ci/daily_build_group_report_results_finder_spec.rb' - - 'ee/spec/finders/ee/clusters/agent_authorizations_finder_spec.rb' - 'ee/spec/finders/ee/clusters/agents_finder_spec.rb' - 'ee/spec/finders/ee/fork_targets_finder_spec.rb' - 'ee/spec/finders/ee/group_members_finder_spec.rb' @@ -96,7 +95,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/finders/license_template_finder_spec.rb' - 'ee/spec/finders/licenses_finder_spec.rb' - 'ee/spec/finders/merge_requests_finder_spec.rb' - - 'ee/spec/finders/merge_trains_finder_spec.rb' - 'ee/spec/finders/notes_finder_spec.rb' - 'ee/spec/finders/productivity_analytics_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/by_ids_finder_spec.rb' @@ -663,8 +661,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/background_migration/create_security_setting_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/delete_approval_rules_with_vulnerability_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' @@ -672,12 +668,8 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/background_migration/populate_approval_merge_request_rules_with_security_orchestration_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_approval_project_rules_with_security_orchestration_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_namespace_statistics_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/purge_stale_security_scans_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/file_size_check_spec.rb' @@ -827,8 +819,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/auth/smartcard/session_spec.rb' - 'ee/spec/lib/gitlab/auth_spec.rb' - 'ee/spec/lib/gitlab/authority_analyzer_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/populate_test_reports_issue_id_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/bullet/exclusions_spec.rb' - 'ee/spec/lib/gitlab/cache_spec.rb' - 'ee/spec/lib/gitlab/checks/changes_access_spec.rb' @@ -1102,7 +1092,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/concerns/approver_migrate_hook_spec.rb' - 'ee/spec/models/concerns/auditable_spec.rb' - 'ee/spec/models/concerns/deprecated_approvals_before_merge_spec.rb' - - 'ee/spec/models/concerns/ee/clusters/agents/authorization_config_scopes_spec.rb' - 'ee/spec/models/concerns/ee/issuable_spec.rb' - 'ee/spec/models/concerns/ee/mentionable_spec.rb' - 'ee/spec/models/concerns/ee/milestoneable_spec.rb' @@ -1631,7 +1620,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/views/groups/security/discover/show.html.haml_spec.rb' - 'ee/spec/views/groups/settings/_remove.html.haml_spec.rb' - 'ee/spec/views/groups/settings/reporting/show.html.haml_spec.rb' - - 'ee/spec/views/layouts/_search.html.haml_spec.rb' - 'ee/spec/views/layouts/application.html.haml_spec.rb' - 'ee/spec/views/layouts/checkout.html.haml_spec.rb' - 'ee/spec/views/layouts/group.html.haml_spec.rb' @@ -1695,7 +1683,6 @@ RSpec/MissingFeatureCategory: - 'spec/bin/diagnostic_reports_uploader_spec.rb' - 'spec/bin/sidekiq_cluster_spec.rb' - 'spec/channels/application_cable/connection_spec.rb' - - 'spec/channels/awareness_channel_spec.rb' - 'spec/commands/diagnostic_reports/uploader_smoke_spec.rb' - 'spec/commands/metrics_server/metrics_server_spec.rb' - 'spec/components/diffs/overflow_warning_component_spec.rb' @@ -1971,7 +1958,6 @@ RSpec/MissingFeatureCategory: - 'spec/finders/ci/runner_jobs_finder_spec.rb' - 'spec/finders/ci/variables_finder_spec.rb' - 'spec/finders/cluster_ancestors_finder_spec.rb' - - 'spec/finders/clusters/agent_authorizations_finder_spec.rb' - 'spec/finders/clusters/agent_tokens_finder_spec.rb' - 'spec/finders/clusters/agents_finder_spec.rb' - 'spec/finders/clusters/knative_services_finder_spec.rb' @@ -2153,7 +2139,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/mutations/clusters/agents/create_spec.rb' - 'spec/graphql/mutations/clusters/agents/delete_spec.rb' - 'spec/graphql/mutations/commits/create_spec.rb' - - 'spec/graphql/mutations/concerns/mutations/finds_by_gid_spec.rb' - 'spec/graphql/mutations/concerns/mutations/resolves_group_spec.rb' - 'spec/graphql/mutations/concerns/mutations/resolves_issuable_spec.rb' - 'spec/graphql/mutations/container_expiration_policies/update_spec.rb' @@ -2828,7 +2813,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/api/entities/ci/job_request/port_spec.rb' - 'spec/lib/api/entities/ci/job_request/service_spec.rb' - 'spec/lib/api/entities/ci/pipeline_spec.rb' - - 'spec/lib/api/entities/clusters/agent_authorization_spec.rb' - 'spec/lib/api/entities/clusters/agent_spec.rb' - 'spec/lib/api/entities/deploy_key_spec.rb' - 'spec/lib/api/entities/deploy_keys_project_spec.rb' @@ -3100,19 +3084,16 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/auth/saml/origin_validator_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' - 'spec/lib/gitlab/auth/two_factor_auth_verifier_spec.rb' - - 'spec/lib/gitlab/auth/u2f_webauthn_converter_spec.rb' - 'spec/lib/gitlab/auth/unique_ips_limiter_spec.rb' - 'spec/lib/gitlab/auth/user_access_denied_reason_spec.rb' - 'spec/lib/gitlab/authorized_keys_spec.rb' - 'spec/lib/gitlab/avatar_cache_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_ci_queuing_tables_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_cluster_agents_has_vulnerabilities_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_draft_status_on_merge_requests_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_draft_status_on_merge_requests_with_corrected_regex_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_group_features_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_integrations_type_new_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_internal_on_notes_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_member_namespace_for_group_members_spec.rb' @@ -3120,8 +3101,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_namespace_id_for_project_route_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_namespace_id_of_vulnerability_reads_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_traversal_ids_children_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_note_discussion_id_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_feature_package_registry_access_level_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_import_level_spec.rb' @@ -3130,9 +3109,7 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_settings_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_topics_title_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_upvotes_count_on_issues_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_user_details_fields_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_user_namespace_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_work_item_type_id_for_issues_spec.rb' - 'spec/lib/gitlab/background_migration/base_job_spec.rb' @@ -3145,56 +3122,34 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/remove_backfilled_job_artifacts_expire_at_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' - - 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_orphaned_routes_spec.rb' - 'spec/lib/gitlab/background_migration/copy_column_using_background_migration_job_spec.rb' - - 'spec/lib/gitlab/background_migration/delete_orphaned_deployments_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphans_approval_merge_request_rules_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphans_approval_project_rules_spec.rb' - 'spec/lib/gitlab/background_migration/destroy_invalid_group_members_spec.rb' - 'spec/lib/gitlab/background_migration/destroy_invalid_members_spec.rb' - 'spec/lib/gitlab/background_migration/destroy_invalid_project_members_spec.rb' - - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_licence_for_recent_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_inactive_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_no_issues_no_repo_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_one_member_no_repo_projects_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_projects_less_than_one_mb_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_security_findings_spec.rb' - - 'spec/lib/gitlab/background_migration/drop_invalid_vulnerabilities_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_integration_properties_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/background_migration/expire_o_auth_tokens_spec.rb' - - 'spec/lib/gitlab/background_migration/extract_project_topics_into_separate_table_spec.rb' - 'spec/lib/gitlab/background_migration/fix_duplicate_project_name_and_path_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_first_mentioned_in_commit_at_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_merge_request_diff_commit_users_spec.rb' - 'spec/lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata_spec.rb' - 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - 'spec/lib/gitlab/background_migration/mailers/unconfirm_mailer_spec.rb' - - 'spec/lib/gitlab/background_migration/merge_topics_with_same_name_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_project_taggings_context_from_tags_to_topics_spec.rb' - 'spec/lib/gitlab/background_migration/migrate_shimo_confluence_integration_category_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_u2f_webauthn_spec.rb' - - 'spec/lib/gitlab/background_migration/move_container_registry_enabled_to_project_feature_spec.rb' - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' - 'spec/lib/gitlab/background_migration/populate_container_repository_migration_plan_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_namespace_statistics_spec.rb' - 'spec/lib/gitlab/background_migration/populate_operation_visibility_permissions_from_operations_spec.rb' - 'spec/lib/gitlab/background_migration/populate_projects_star_count_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_topics_non_private_projects_count_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_topics_total_projects_count_cache_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' - 'spec/lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'spec/lib/gitlab/background_migration/remove_backfilled_job_artifacts_expire_at_spec.rb' - - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/lib/gitlab/background_migration/remove_self_managed_wiki_notes_spec.rb' - 'spec/lib/gitlab/background_migration/remove_vulnerability_finding_links_spec.rb' @@ -3204,13 +3159,9 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb' - 'spec/lib/gitlab/background_migration/set_correct_vulnerability_state_spec.rb' - 'spec/lib/gitlab/background_migration/set_legacy_open_source_license_available_for_non_public_projects_spec.rb' - - 'spec/lib/gitlab/background_migration/steal_migrate_merge_request_diff_commit_users_spec.rb' - 'spec/lib/gitlab/background_migration/update_ci_pipeline_artifacts_unknown_locked_status_spec.rb' - 'spec/lib/gitlab/background_migration/update_delayed_project_removal_to_null_for_user_namespaces_spec.rb' - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - - 'spec/lib/gitlab/background_migration/update_timelogs_null_spent_at_spec.rb' - - 'spec/lib/gitlab/background_migration/update_timelogs_project_id_spec.rb' - - 'spec/lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group_spec.rb' - 'spec/lib/gitlab/background_migration_spec.rb' - 'spec/lib/gitlab/backtrace_cleaner_spec.rb' - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' @@ -3773,7 +3724,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/email/hook/delivery_metrics_observer_spec.rb' - 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb' - 'spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb' - - 'spec/lib/gitlab/email/hook/validate_addresses_interceptor_spec.rb' - 'spec/lib/gitlab/email/message/build_ios_app_guide_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/admin_verify_spec.rb' - 'spec/lib/gitlab/email/message/in_product_marketing/base_spec.rb' @@ -4075,7 +4025,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/import_export/duration_measuring_spec.rb' - 'spec/lib/gitlab/import_export/error_spec.rb' - 'spec/lib/gitlab/import_export/file_importer_spec.rb' - - 'spec/lib/gitlab/import_export/fork_spec.rb' - 'spec/lib/gitlab/import_export/group/object_builder_spec.rb' - 'spec/lib/gitlab/import_export/group/relation_factory_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' @@ -4084,8 +4033,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/import_export/import_export_spec.rb' - 'spec/lib/gitlab/import_export/import_test_coverage_spec.rb' - 'spec/lib/gitlab/import_export/importer_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/file_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb' - 'spec/lib/gitlab/import_export/json/ndjson_reader_spec.rb' - 'spec/lib/gitlab/import_export/json/ndjson_writer_spec.rb' - 'spec/lib/gitlab/import_export/legacy_relation_tree_saver_spec.rb' @@ -4119,7 +4066,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/import_sources_spec.rb' - 'spec/lib/gitlab/inactive_projects_deletion_warning_tracker_spec.rb' - 'spec/lib/gitlab/incident_management/pager_duty/incident_issue_description_spec.rb' - - 'spec/lib/gitlab/incoming_email_spec.rb' - 'spec/lib/gitlab/insecure_key_fingerprint_spec.rb' - 'spec/lib/gitlab/instrumentation/rate_limiting_gates_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_base_spec.rb' @@ -4156,19 +4102,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - 'spec/lib/gitlab/kubernetes/deployment_spec.rb' - 'spec/lib/gitlab/kubernetes/generic_secret_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/pod_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/base_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/certificate_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/delete_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/init_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/install_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/patch_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v2/reset_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/base_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/delete_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/install_command_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/v3/patch_command_spec.rb' - 'spec/lib/gitlab/kubernetes/ingress_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/entry/cluster_spec.rb' @@ -4470,7 +4403,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/seeders/ci/daily_build_group_report_result_spec.rb' - 'spec/lib/gitlab/serializer/ci/variables_spec.rb' - 'spec/lib/gitlab/serializer/pagination_spec.rb' - - 'spec/lib/gitlab/service_desk_email_spec.rb' - 'spec/lib/gitlab/service_desk_spec.rb' - 'spec/lib/gitlab/session_spec.rb' - 'spec/lib/gitlab/setup_helper/praefect_spec.rb' @@ -4852,7 +4784,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/audit_event_spec.rb' - 'spec/models/authentication_event_spec.rb' - 'spec/models/award_emoji_spec.rb' - - 'spec/models/awareness_session_spec.rb' - 'spec/models/aws/role_spec.rb' - 'spec/models/badge_spec.rb' - 'spec/models/badges/group_badge_spec.rb' @@ -4924,14 +4855,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/clusters/agent_spec.rb' - 'spec/models/clusters/agent_token_spec.rb' - 'spec/models/clusters/agents/activity_event_spec.rb' - - 'spec/models/clusters/agents/group_authorization_spec.rb' - - 'spec/models/clusters/agents/implicit_authorization_spec.rb' - - 'spec/models/clusters/agents/project_authorization_spec.rb' - - 'spec/models/clusters/applications/helm_spec.rb' - - 'spec/models/clusters/applications/ingress_spec.rb' - - 'spec/models/clusters/applications/jupyter_spec.rb' - - 'spec/models/clusters/applications/knative_spec.rb' - - 'spec/models/clusters/applications/runner_spec.rb' - 'spec/models/clusters/cluster_enabled_grant_spec.rb' - 'spec/models/clusters/clusters_hierarchy_spec.rb' - 'spec/models/clusters/group_spec.rb' @@ -4954,7 +4877,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/concerns/atomic_internal_id_spec.rb' - 'spec/models/concerns/avatarable_spec.rb' - 'spec/models/concerns/awardable_spec.rb' - - 'spec/models/concerns/awareness_spec.rb' - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb' - 'spec/models/concerns/batch_nullify_dependent_associations_spec.rb' - 'spec/models/concerns/blob_language_from_git_attributes_spec.rb' @@ -4971,7 +4893,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/concerns/ci/partitionable/switch_spec.rb' - 'spec/models/concerns/ci/partitionable_spec.rb' - 'spec/models/concerns/ci/track_environment_usage_spec.rb' - - 'spec/models/concerns/clusters/agents/authorization_config_scopes_spec.rb' - 'spec/models/concerns/commit_signature_spec.rb' - 'spec/models/concerns/counter_attribute_spec.rb' - 'spec/models/concerns/cron_schedulable_spec.rb' @@ -6080,7 +6001,6 @@ RSpec/MissingFeatureCategory: - 'spec/views/layouts/_head.html.haml_spec.rb' - 'spec/views/layouts/_header_search.html.haml_spec.rb' - 'spec/views/layouts/_published_experiments.html.haml_spec.rb' - - 'spec/views/layouts/_search.html.haml_spec.rb' - 'spec/views/layouts/application.html.haml_spec.rb' - 'spec/views/layouts/devise.html.haml_spec.rb' - 'spec/views/layouts/devise_empty.html.haml_spec.rb' diff --git a/.rubocop_todo/rspec/multiple_memoized_helpers.yml b/.rubocop_todo/rspec/multiple_memoized_helpers.yml index 708543510a2..ddb9f70c3b4 100644 --- a/.rubocop_todo/rspec/multiple_memoized_helpers.yml +++ b/.rubocop_todo/rspec/multiple_memoized_helpers.yml @@ -5,7 +5,6 @@ RSpec/MultipleMemoizedHelpers: - 'ee/spec/finders/epics_finder_spec.rb' - 'ee/spec/finders/incident_management/oncall_users_finder_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' @@ -15,7 +14,6 @@ RSpec/MultipleMemoizedHelpers: - 'spec/finders/ci/runners_finder_spec.rb' - 'spec/finders/labels_finder_spec.rb' - 'spec/finders/user_recent_events_finder_spec.rb' - - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' - 'spec/models/event_spec.rb' - 'spec/models/milestone_spec.rb' diff --git a/.rubocop_todo/rspec/repeated_example_group_description.yml b/.rubocop_todo/rspec/repeated_example_group_description.yml index e34ea087ed1..d5b3ad81d01 100644 --- a/.rubocop_todo/rspec/repeated_example_group_description.yml +++ b/.rubocop_todo/rspec/repeated_example_group_description.yml @@ -1,7 +1,6 @@ --- RSpec/RepeatedExampleGroupDescription: Exclude: - - 'ee/spec/finders/merge_trains_finder_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_grade_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerability_severities_count_resolver_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' @@ -90,7 +89,6 @@ RSpec/RepeatedExampleGroupDescription: - 'spec/services/merge_requests/refresh_service_spec.rb' - 'spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/limitable_shared_examples.rb' - 'spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb' diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml index 2b39bcbcd07..29437bcfb2b 100644 --- a/.rubocop_todo/rspec/return_from_stub.yml +++ b/.rubocop_todo/rspec/return_from_stub.yml @@ -15,7 +15,6 @@ RSpec/ReturnFromStub: - 'ee/spec/lib/ee/feature_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/branch_check_spec.rb' - 'ee/spec/lib/ee/gitlab/database_spec.rb' - - 'ee/spec/lib/gitlab/ci/minutes/build_consumption_spec.rb' - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' - 'ee/spec/lib/gitlab/geo/health_check_spec.rb' - 'ee/spec/lib/gitlab/geo/logger_spec.rb' @@ -75,7 +74,6 @@ RSpec/ReturnFromStub: - 'ee/spec/workers/geo/repository_verification/secondary/single_worker_spec.rb' - 'ee/spec/workers/post_receive_spec.rb' - 'ee/spec/workers/store_security_reports_worker_spec.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'qa/spec/specs/runner_spec.rb' - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/bin/feature_flag_spec.rb' @@ -134,7 +132,6 @@ RSpec/ReturnFromStub: - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' - 'spec/lib/gitlab/auth_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/ci/build/policy/changes_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/stage_spec.rb' diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml index 8e3a2895d04..573991418f7 100644 --- a/.rubocop_todo/rspec/scattered_let.yml +++ b/.rubocop_todo/rspec/scattered_let.yml @@ -125,7 +125,6 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_inactive_public_projects_spec.rb' - - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb' diff --git a/.rubocop_todo/rspec/shared_groups_metadata.yml b/.rubocop_todo/rspec/shared_groups_metadata.yml index b87c851d2f6..5b1ec2dbf5c 100644 --- a/.rubocop_todo/rspec/shared_groups_metadata.yml +++ b/.rubocop_todo/rspec/shared_groups_metadata.yml @@ -2,7 +2,6 @@ RSpec/SharedGroupsMetadata: Details: grace period Exclude: - - 'ee/spec/requests/ee/admin/plan_limits_controller_spec.rb' - 'spec/lib/gitlab/ci/config/entry/retry_spec.rb' - 'spec/lib/gitlab/git/merge_base_spec.rb' - 'spec/models/container_repository_spec.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 6c7653fe0c1..76a296e97fd 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -210,7 +210,6 @@ RSpec/VerifiedDoubles: - 'ee/spec/workers/ldap_group_sync_worker_spec.rb' - 'ee/spec/workers/merge_request_reset_approvals_worker_spec.rb' - 'ee/spec/workers/new_epic_worker_spec.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'qa/spec/git/repository_spec.rb' - 'qa/spec/page/base_spec.rb' - 'qa/spec/page/validator_spec.rb' @@ -376,7 +375,6 @@ RSpec/VerifiedDoubles: - 'spec/lib/gitlab/background_migration/base_job_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/base_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/job_coordinator_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - 'spec/lib/gitlab/background_migration_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_import/project_creator_spec.rb' @@ -617,7 +615,6 @@ RSpec/VerifiedDoubles: - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kubernetes/config_map_spec.rb' - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - - 'spec/lib/gitlab/kubernetes/helm/api_spec.rb' - 'spec/lib/gitlab/kubernetes/namespace_spec.rb' - 'spec/lib/gitlab/lazy_spec.rb' - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' @@ -681,7 +678,6 @@ RSpec/VerifiedDoubles: - 'spec/lib/gitlab/profiler_spec.rb' - 'spec/lib/gitlab/prometheus/adapter_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - 'spec/lib/gitlab/query_limiting/middleware_spec.rb' - 'spec/lib/gitlab/quick_actions/dsl_spec.rb' @@ -748,7 +744,6 @@ RSpec/VerifiedDoubles: - 'spec/models/ci/commit_with_pipeline_spec.rb' - 'spec/models/ci/group_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - - 'spec/models/clusters/applications/runner_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - 'spec/models/clusters/platforms/kubernetes_spec.rb' - 'spec/models/commit_spec.rb' diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml index 4485a5df956..27ceead3555 100644 --- a/.rubocop_todo/style/class_and_module_children.yml +++ b/.rubocop_todo/style/class_and_module_children.yml @@ -121,7 +121,6 @@ Style/ClassAndModuleChildren: - 'app/controllers/profiles/personal_access_tokens_controller.rb' - 'app/controllers/profiles/preferences_controller.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' - - 'app/controllers/profiles/u2f_registrations_controller.rb' - 'app/controllers/profiles/webauthn_registrations_controller.rb' - 'app/controllers/projects/alert_management_controller.rb' - 'app/controllers/projects/analytics/cycle_analytics/stages_controller.rb' @@ -368,7 +367,6 @@ Style/ClassAndModuleChildren: - 'ee/app/controllers/admin/push_rules_controller.rb' - 'ee/app/controllers/admin/subscriptions_controller.rb' - 'ee/app/controllers/admin/user_permission_exports_controller.rb' - - 'ee/app/controllers/concerns/registrations/verification.rb' - 'ee/app/controllers/ee/profiles/accounts_controller.rb' - 'ee/app/controllers/ee/profiles/preferences_controller.rb' - 'ee/app/controllers/ee/projects/analytics/cycle_analytics/summary_controller.rb' @@ -434,7 +432,6 @@ Style/ClassAndModuleChildren: - 'ee/app/controllers/projects/vulnerability_feedback_controller.rb' - 'ee/app/finders/ee/group_members_finder.rb' - 'ee/app/graphql/mutations/app_sec/fuzzing/coverage/corpus/create.rb' - - 'ee/app/helpers/ee/groups/analytics/cycle_analytics_helper.rb' - 'ee/app/helpers/ee/groups/group_members_helper.rb' - 'ee/app/helpers/ee/security_orchestration_helper.rb' - 'ee/app/helpers/groups/ldap_sync_helper.rb' @@ -504,15 +501,11 @@ Style/ClassAndModuleChildren: - 'ee/lib/ee/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/base_query_builder.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/records_fetcher.rb' - - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'ee/lib/ee/gitlab/throttle.rb' - 'ee/lib/gitlab/path_locks_finder.rb' - 'lib/api/error_tracking/client_keys.rb' - 'lib/api/error_tracking/collector.rb' - 'lib/api/error_tracking/project_settings.rb' - - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/ci/badge/base.rb' - 'lib/gitlab/ci/badge/coverage/metadata.rb' @@ -538,7 +531,6 @@ Style/ClassAndModuleChildren: - 'lib/gitlab/ci/warnings.rb' - 'lib/gitlab/config_helper.rb' - 'lib/gitlab/instrumentation/elasticsearch_transport.rb' - - 'lib/gitlab/serverless/service.rb' - 'lib/gitlab/usage_data_counters/base_counter.rb' - 'lib/gitlab/usage_data_counters/ci_template_unique_counter.rb' - 'lib/gitlab/usage_data_counters/cycle_analytics_counter.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index dd55c4f45cd..153603eed5b 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -70,8 +70,6 @@ Style/EmptyMethod: - 'app/services/issuable_base_service.rb' - 'app/services/projects/transfer_service.rb' - 'app/workers/namespaces/root_statistics_worker.rb' - - 'db/migrate/20211012134316_clean_up_migrate_merge_request_diff_commit_users.rb' - - 'db/post_migrate/20211028100843_delete_issue_merge_request_taggings_records.rb' - 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb' - 'db/post_migrate/20220412143552_consume_remaining_encrypt_integration_property_jobs.rb' - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' @@ -113,16 +111,12 @@ Style/EmptyMethod: - 'lib/gitlab/background_migration/create_security_setting.rb' - 'lib/gitlab/background_migration/delete_approval_rules_with_vulnerability.rb' - 'lib/gitlab/background_migration/delete_invalid_epic_issues.rb' - - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' - 'lib/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - 'lib/gitlab/ci/config/entry/need.rb' - 'lib/gitlab/ci/config/entry/rules/rule.rb' - 'lib/gitlab/ci/limit.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index fc74f8fe075..5763faabc39 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -109,7 +109,6 @@ Style/FormatString: - 'app/models/project.rb' - 'app/models/resource_event.rb' - 'app/models/sent_notification.rb' - - 'app/models/serverless/domain.rb' - 'app/models/user.rb' - 'app/models/wiki.rb' - 'app/models/wiki_page.rb' @@ -305,7 +304,6 @@ Style/FormatString: - 'spec/features/admin/admin_users_spec.rb' - 'spec/features/groups/import_export/connect_instance_spec.rb' - 'spec/features/issues/form_spec.rb' - - 'spec/finders/serverless_domain_finder_spec.rb' - 'spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb' - 'spec/helpers/profiles_helper_spec.rb' - 'spec/lib/api/entities/release_spec.rb' @@ -314,7 +312,6 @@ Style/FormatString: - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' - 'spec/models/integrations/bamboo_spec.rb' - 'spec/models/integrations/datadog_spec.rb' - - 'spec/models/serverless/domain_spec.rb' - 'spec/requests/api/graphql/project/jira_projects_spec.rb' - 'spec/services/groups/import_export/export_service_spec.rb' - 'spec/services/projects/import_export/export_service_spec.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 3c123b25953..09d838267d3 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -260,10 +260,6 @@ Style/GuardClause: - 'config/initializers/postgresql_cte.rb' - 'config/object_store_settings.rb' - 'danger/feature_flag/Dangerfile' - - 'db/migrate/20210830140524_add_state_to_member.rb' - - 'db/migrate/20211202094944_move_loose_fk_deleted_records_to_dynamic_schema.rb' - - 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb' - - 'db/post_migrate/20210907211557_finalize_ci_builds_bigint_conversion.rb' - 'ee/app/controllers/admin/emails_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' - 'ee/app/controllers/admin/geo/replicables_controller.rb' @@ -432,7 +428,6 @@ Style/GuardClause: - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb' - 'ee/spec/support/ci/minutes_helpers.rb' - - 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb' - 'haml_lint/linter/documentation_links.rb' - 'lib/api/commits.rb' - 'lib/api/error_tracking/collector.rb' @@ -579,7 +574,6 @@ Style/GuardClause: - 'lib/gitlab/search/abuse_validators/no_abusive_term_length_validator.rb' - 'lib/gitlab/search/params.rb' - 'lib/gitlab/serializer/pagination.rb' - - 'lib/gitlab/serverless/service.rb' - 'lib/gitlab/shell.rb' - 'lib/gitlab/sidekiq_config/cli_methods.rb' - 'lib/gitlab/sidekiq_middleware/extra_done_log_metadata.rb' diff --git a/.rubocop_todo/style/hash_as_last_array_item.yml b/.rubocop_todo/style/hash_as_last_array_item.yml index 859061d6577..d7032af8805 100644 --- a/.rubocop_todo/style/hash_as_last_array_item.yml +++ b/.rubocop_todo/style/hash_as_last_array_item.yml @@ -45,7 +45,6 @@ Style/HashAsLastArrayItem: - 'lib/gitlab/analytics/cycle_analytics/request_params.rb' - 'lib/gitlab/database/migration_helpers.rb' - 'spec/lib/gitlab/database/migration_helpers/v2_spec.rb' - - 'spec/migrations/20210914095310_cleanup_orphan_project_access_tokens_spec.rb' - 'spec/requests/rack_attack_global_spec.rb' - 'spec/services/git/branch_hooks_service_spec.rb' - 'spec/services/metrics/dashboard/panel_preview_service_spec.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index a4bd4a18854..1cf44ae494b 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -386,11 +386,7 @@ Style/IfUnlessModifier: - 'danger/database/Dangerfile' - 'danger/pipeline/Dangerfile' - 'danger/z_metadata/Dangerfile' - - 'db/migrate/20210909184349_add_index_package_id_id_on_package_files.rb' - 'db/migrate/20220324175325_add_key_data_to_secure_files.rb' - - 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb' - - 'db/post_migrate/20220128155814_fix_approval_rules_code_owners_rule_type_index.rb' - - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' - 'db/post_migrate/20220523171107_drop_deploy_tokens_token_column.rb' - 'ee/app/components/namespaces/storage/limit_alert_component.rb' - 'ee/app/controllers/admin/elasticsearch_controller.rb' @@ -749,9 +745,7 @@ Style/IfUnlessModifier: - 'lib/gitlab/auth/ldap/authentication.rb' - 'lib/gitlab/authorized_keys.rb' - 'lib/gitlab/background_migration/fix_vulnerability_occurrences_with_hashes_as_raw_metadata.rb' - - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'lib/gitlab/bare_repository_import/importer.rb' - 'lib/gitlab/bare_repository_import/repository.rb' @@ -876,7 +870,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/import_export/base/relation_factory.rb' - 'lib/gitlab/import_export/fast_hash_serializer.rb' - 'lib/gitlab/import_export/group/tree_restorer.rb' - - 'lib/gitlab/import_export/json/legacy_writer.rb' - 'lib/gitlab/import_export/merge_request_parser.rb' - 'lib/gitlab/import_export/project/export_task.rb' - 'lib/gitlab/import_export/project/relation_factory.rb' @@ -1004,7 +997,6 @@ Style/IfUnlessModifier: - 'spec/components/previews/pajamas/alert_component_preview.rb' - 'spec/components/previews/pajamas/card_component_preview.rb' - 'spec/factories/ci/runners.rb' - - 'spec/factories/clusters/applications/helm.rb' - 'spec/factories/container_repositories.rb' - 'spec/factories/deployments.rb' - 'spec/factories/labels.rb' @@ -1021,7 +1013,6 @@ Style/IfUnlessModifier: - 'spec/features/projects/tree/create_file_spec.rb' - 'spec/graphql/mutations/releases/update_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - - 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb' - 'spec/lib/gitlab/config/entry/validators/nested_array_helpers_spec.rb' - 'spec/lib/gitlab/conflict/file_spec.rb' - 'spec/lib/gitlab/database/load_balancing_spec.rb' diff --git a/.rubocop_todo/style/keyword_parameters_order.yml b/.rubocop_todo/style/keyword_parameters_order.yml index 3730a86221e..e4b751a92da 100644 --- a/.rubocop_todo/style/keyword_parameters_order.yml +++ b/.rubocop_todo/style/keyword_parameters_order.yml @@ -8,7 +8,6 @@ Style/KeywordParametersOrder: - 'ee/lib/gitlab/elastic/helper.rb' - 'ee/lib/gitlab/insights/executors/dora_executor.rb' - 'ee/lib/gitlab/insights/executors/issuable_executor.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/requests/api/deployments_spec.rb' - 'lib/gitlab/background_migration/batched_migration_job.rb' - 'lib/gitlab/checks/timed_logger.rb' diff --git a/.rubocop_todo/style/numbered_parameters.yml b/.rubocop_todo/style/numbered_parameters.yml index aa3df93ab8f..fc08515bc2f 100644 --- a/.rubocop_todo/style/numbered_parameters.yml +++ b/.rubocop_todo/style/numbered_parameters.yml @@ -76,7 +76,6 @@ Style/NumberedParameters: - 'spec/services/web_hook_service_spec.rb' - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/matchers/exceed_query_limit.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' - 'spec/support/shared_contexts/lib/sbom/package_url_shared_contexts.rb' - 'spec/support/shared_examples/integrations/integration_settings_form.rb' - 'spec/support/shared_examples/requests/api/hooks_shared_examples.rb' diff --git a/.rubocop_todo/style/numeric_literal_prefix.yml b/.rubocop_todo/style/numeric_literal_prefix.yml index 44f9ab098a2..441e4389aab 100644 --- a/.rubocop_todo/style/numeric_literal_prefix.yml +++ b/.rubocop_todo/style/numeric_literal_prefix.yml @@ -6,14 +6,11 @@ Style/NumericLiteralPrefix: - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'config/initializers/01_secret_token.rb' - 'config/initializers/1_settings.rb' - - 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/gitlab/geo/replication/blob_downloader.rb' - 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - - 'ee/spec/migrations/schedule_trace_expiry_removal_spec.rb' - 'ee/spec/models/analytics/devops_adoption/snapshot_spec.rb' - 'ee/spec/models/ci/minutes/usage_spec.rb' - 'ee/spec/models/ee/group_spec.rb' @@ -21,7 +18,6 @@ Style/NumericLiteralPrefix: - 'ee/spec/services/incident_management/oncall_schedules/update_service_spec.rb' - 'ee/spec/workers/sync_seat_link_worker_spec.rb' - 'lib/backup/files.rb' - - 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb' - 'lib/gitlab/import_export/command_line_util.rb' - 'lib/gitlab/jwt_authenticatable.rb' - 'lib/system_check/app/uploads_path_permission_check.rb' @@ -32,7 +28,6 @@ Style/NumericLiteralPrefix: - 'qa/qa/support/ssh.rb' - 'qa/spec/support/ssh_spec.rb' - 'scripts/security-harness' - - 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 31195e54f78..7cb9379cec6 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -173,9 +173,6 @@ Style/PercentLiteralDelimiters: - 'config/initializers_before_autoloader/000_inflections.rb' - 'config/object_store_settings.rb' - 'config/spring.rb' - - 'db/migrate/20210928155022_improve_index_for_error_tracking.rb' - - 'db/post_migrate/20210906130643_drop_temporary_columns_and_triggers_for_taggings.rb' - - 'db/post_migrate/20211028100843_delete_issue_merge_request_taggings_records.rb' - 'ee/app/controllers/ee/admin/application_settings_controller.rb' - 'ee/app/controllers/ee/projects/service_desk_controller.rb' - 'ee/app/controllers/ee/repositories/git_http_client_controller.rb' @@ -238,7 +235,6 @@ Style/PercentLiteralDelimiters: - 'ee/lib/ee/api/search.rb' - 'ee/lib/ee/gitlab/alert_management/payload/generic.rb' - 'ee/lib/ee/gitlab/auth/ldap/adapter.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/lib/ee/gitlab/ci/parsers/security/validators/schema_validator.rb' @@ -495,7 +491,6 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/jira_import/metadata_collector.rb' - 'lib/gitlab/kas.rb' - 'lib/gitlab/kroki.rb' - - 'lib/gitlab/kubernetes/helm/pod.rb' - 'lib/gitlab/kubernetes/kubectl_cmd.rb' - 'lib/gitlab/logger.rb' - 'lib/gitlab/lograge/custom_options.rb' @@ -599,7 +594,6 @@ Style/PercentLiteralDelimiters: - 'spec/experiments/ios_specific_templates_experiment_spec.rb' - 'spec/factories/ci/builds.rb' - 'spec/factories/ci/runners.rb' - - 'spec/factories/clusters/applications/helm.rb' - 'spec/factories/clusters/clusters.rb' - 'spec/factories/clusters/integrations/prometheus.rb' - 'spec/factories/clusters/providers/aws.rb' @@ -795,7 +789,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/import_export/attribute_cleaner_spec.rb' - 'spec/lib/gitlab/import_export/attributes_permitter_spec.rb' - 'spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_writer_spec.rb' - 'spec/lib/gitlab/import_export/json/ndjson_writer_spec.rb' - 'spec/lib/gitlab/import_export/lfs_restorer_spec.rb' - 'spec/lib/gitlab/import_export/lfs_saver_spec.rb' @@ -871,7 +864,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/system_check/orphans/namespace_check_spec.rb' - 'spec/lib/system_check/orphans/repository_check_spec.rb' - 'spec/lib/system_check/sidekiq_check_spec.rb' - - 'spec/lib/tasks/gitlab/metrics_exporter_task_spec.rb' - 'spec/lib/unnested_in_filters/dsl_spec.rb' - 'spec/lib/unnested_in_filters/rewriter_spec.rb' - 'spec/metrics_server/metrics_server_spec.rb' diff --git a/.rubocop_todo/style/redundant_freeze.yml b/.rubocop_todo/style/redundant_freeze.yml index 3a0f099fd24..b65fe11a9b7 100644 --- a/.rubocop_todo/style/redundant_freeze.yml +++ b/.rubocop_todo/style/redundant_freeze.yml @@ -42,8 +42,6 @@ Style/RedundantFreeze: - 'app/models/packages/debian/file_entry.rb' - 'app/models/personal_access_token.rb' - 'app/models/releases/link.rb' - - 'app/models/serverless/domain.rb' - - 'app/models/serverless/domain_cluster.rb' - 'app/models/snippet_repository.rb' - 'app/models/terraform/state.rb' - 'app/services/clusters/agent_tokens/track_usage_service.rb' @@ -112,7 +110,6 @@ Style/RedundantFreeze: - 'lib/gitaly/server.rb' - 'lib/gitlab.rb' - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/changelog/generator.rb' - 'lib/gitlab/ci/build/artifacts/metadata.rb' @@ -154,7 +151,6 @@ Style/RedundantFreeze: - 'lib/gitlab/email/handler/create_merge_request_handler.rb' - 'lib/gitlab/email/handler/create_note_on_issuable_handler.rb' - 'lib/gitlab/email/handler/service_desk_handler.rb' - - 'lib/gitlab/email/hook/validate_addresses_interceptor.rb' - 'lib/gitlab/email/receiver.rb' - 'lib/gitlab/error_tracking/error_repository/open_api_strategy.rb' - 'lib/gitlab/front_matter.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 5335915271d..3168a5d2150 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -18,7 +18,6 @@ Style/RedundantSelf: - 'app/models/ci/stage.rb' - 'app/models/ci/trigger.rb' - 'app/models/ci_platform_metric.rb' - - 'app/models/clusters/applications/crossplane.rb' - 'app/models/clusters/cluster.rb' - 'app/models/clusters/concerns/application_core.rb' - 'app/models/clusters/concerns/application_status.rb' @@ -132,7 +131,6 @@ Style/RedundantSelf: - 'app/models/remote_mirror.rb' - 'app/models/repository.rb' - 'app/models/sent_notification.rb' - - 'app/models/serverless/function.rb' - 'app/models/service_desk_setting.rb' - 'app/models/snippet.rb' - 'app/models/terraform/state.rb' @@ -169,7 +167,6 @@ Style/RedundantSelf: - 'config/initializers/active_record_keyset_pagination.rb' - 'config/initializers/forbid_sidekiq_in_transactions.rb' - 'config/initializers/mail_encoding_patch.rb' - - 'db/post_migrate/20211029102822_add_open_source_plan.rb' - 'ee/app/graphql/resolvers/geo/registries_resolver.rb' - 'ee/app/models/approval_merge_request_rule.rb' - 'ee/app/models/approval_project_rule.rb' @@ -230,8 +227,6 @@ Style/RedundantSelf: - 'ee/lib/ee/gitlab/auth/ldap/sync/users.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/delete_invalid_epic_issues.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'ee/lib/ee/gitlab/database.rb' - 'ee/lib/ee/gitlab/tracking.rb' - 'ee/lib/ee/legacy_model.rb' @@ -279,10 +274,8 @@ Style/RedundantSelf: - 'lib/gitlab/auth/ldap/dn.rb' - 'lib/gitlab/auth/o_auth/provider.rb' - 'lib/gitlab/auth/result.rb' - - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' - 'lib/gitlab/background_migration/backfill_project_repositories.rb' - 'lib/gitlab/background_migration/job_coordinator.rb' - - 'lib/gitlab/background_migration/migrate_merge_request_diff_commit_users.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' - 'lib/gitlab/ci/ansi2html.rb' - 'lib/gitlab/ci/ansi2json/parser.rb' @@ -405,4 +398,3 @@ Style/RedundantSelf: - 'spec/lib/gitlab/database/load_balancing_spec.rb' - 'spec/models/integration_spec.rb' - 'spec/support/before_all_adapter.rb' - - 'spec/support/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/style/single_argument_dig.yml b/.rubocop_todo/style/single_argument_dig.yml index 8d35373a2c0..d41dc0add05 100644 --- a/.rubocop_todo/style/single_argument_dig.yml +++ b/.rubocop_todo/style/single_argument_dig.yml @@ -47,7 +47,6 @@ Style/SingleArgumentDig: - 'lib/gitlab/config/entry/simplifiable.rb' - 'lib/gitlab/config/entry/validators.rb' - 'lib/gitlab/database/transaction/observer.rb' - - 'lib/gitlab/serverless/service.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'qa/qa/vendor/mail_hog/api.rb' - 'spec/controllers/graphql_controller_spec.rb' diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index 8209781e78a..4907118eedc 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -17,7 +17,6 @@ Style/StringConcatenation: - 'app/models/pool_repository.rb' - 'app/models/project_wiki.rb' - 'app/models/repository.rb' - - 'app/models/serverless/function.rb' - 'app/models/wiki.rb' - 'app/models/wiki_page.rb' - 'app/presenters/snippet_blob_presenter.rb' @@ -183,7 +182,6 @@ Style/StringConcatenation: - 'spec/lib/container_registry/tag_spec.rb' - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - 'spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_merge_request_diff_commit_users_spec.rb' - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/ci/build/artifacts/metadata_spec.rb' - 'spec/lib/gitlab/ci/config/entry/artifacts_spec.rb' diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml index 7273161aef5..ceb6a922270 100644 --- a/.rubocop_todo/style/string_literals_in_interpolation.yml +++ b/.rubocop_todo/style/string_literals_in_interpolation.yml @@ -8,7 +8,6 @@ Style/StringLiteralsInInterpolation: - 'app/models/ci/namespace_mirror.rb' - 'app/models/integrations/campfire.rb' - 'app/models/integrations/jira.rb' - - 'app/models/serverless/domain.rb' - 'app/services/draft_notes/publish_service.rb' - 'app/services/projects/create_service.rb' - 'app/validators/nested_attributes_duplicates_validator.rb' @@ -53,7 +52,6 @@ Style/StringLiteralsInInterpolation: - 'spec/features/commits_spec.rb' - 'spec/features/dashboard/merge_requests_spec.rb' - 'spec/features/users/login_spec.rb' - - 'spec/finders/serverless_domain_finder_spec.rb' - 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb' - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' @@ -61,7 +59,6 @@ Style/StringLiteralsInInterpolation: - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/gitaly_client/ref_service_spec.rb' - 'spec/lib/object_storage/direct_upload_spec.rb' - - 'spec/models/serverless/domain_spec.rb' - 'spec/requests/api/keys_spec.rb' - 'spec/support/database/prevent_cross_joins.rb' - 'spec/views/notify/import_issues_csv_email.html.haml_spec.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index b6d0de8ef5e..0e4602f9f31 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -66,7 +66,6 @@ Style/SymbolProc: - 'config/initializers/doorkeeper_openid_connect.rb' - 'config/initializers/mail_encoding_patch.rb' - 'config/settings.rb' - - 'db/post_migrate/20220119094503_populate_audit_event_streaming_verification_token.rb' - 'db/post_migrate/20220803042352_cleanup_mr_attention_request_todos.rb' - 'ee/app/helpers/ee/mirror_helper.rb' - 'ee/app/helpers/ee/registrations_helper.rb' @@ -96,9 +95,6 @@ Style/SymbolProc: - 'ee/lib/ee/api/entities/merge_request_approval_state.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - - 'ee/lib/ee/gitlab/background_migration/drop_invalid_remediations.rb' - - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'ee/lib/gitlab/ci/parsers/security/formatters/dependency_list.rb' - 'ee/lib/gitlab/contribution_analytics/data_collector.rb' - 'ee/lib/gitlab/custom_file_templates.rb' @@ -132,8 +128,6 @@ Style/SymbolProc: - 'lib/container_registry/gitlab_api_client.rb' - 'lib/gitlab/analytics/cycle_analytics/stage_events.rb' - 'lib/gitlab/auth/o_auth/auth_hash.rb' - - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/blob_helper.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' |