summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2017-09-13 16:14:06 +0000
committerJarka Kadlecova <jarka@gitlab.com>2017-09-20 13:36:37 +0200
commit109f39e29f1994340bad8b9136d77058aba6bb47 (patch)
tree5aeb84c23b0d0f4960d01c51c2489d7e65b3383b
parent5b92cd7be05aecfb8ebad7ad48d47fd6c4dd3e64 (diff)
downloadgitlab-ce-10-0-stable-prepare-rc5.tar.gz
Merge branch 'ce-backport-new-sidebar-boards' into 'master'10-0-stable-prepare-rc5
CE backport of new-sidebar-boards See merge request !14246 # Conflicts: # app/views/layouts/nav/sidebar/_project.html.haml
-rw-r--r--app/helpers/boards_helper.rb4
-rw-r--r--app/views/layouts/nav/sidebar/_project.html.haml2
-rw-r--r--spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb24
3 files changed, 23 insertions, 7 deletions
diff --git a/app/helpers/boards_helper.rb b/app/helpers/boards_helper.rb
index 4bd61aa8f86..62ac208f16a 100644
--- a/app/helpers/boards_helper.rb
+++ b/app/helpers/boards_helper.rb
@@ -77,4 +77,8 @@ module BoardsHelper
'max-select': dropdown_options[:data][:'max-select']
}
end
+
+ def boards_link_text
+ _("Board")
+ end
end
diff --git a/app/views/layouts/nav/sidebar/_project.html.haml b/app/views/layouts/nav/sidebar/_project.html.haml
index 97f3eed9324..518cabbb1a5 100644
--- a/app/views/layouts/nav/sidebar/_project.html.haml
+++ b/app/views/layouts/nav/sidebar/_project.html.haml
@@ -114,7 +114,7 @@
List
= nav_link(controller: :boards) do
- = link_to project_boards_path(@project), title: 'Board' do
+ = link_to project_boards_path(@project), title: boards_link_text do
%span
= boards_link_text
diff --git a/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb b/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb
index b17bc6692f3..c5f455b8948 100644
--- a/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb
+++ b/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb
@@ -1,16 +1,28 @@
require 'spec_helper'
describe 'layouts/nav/sidebar/_project' do
+ let(:project) { create(:project, :repository) }
+
+ before do
+ assign(:project, project)
+ assign(:repository, project.repository)
+ allow(view).to receive(:current_ref).and_return('master')
+
+ allow(view).to receive(:can?).and_return(true)
+ end
+
+ describe 'issue boards' do
+ it 'has boards tab when multiple issue boards available' do
+ render
+
+ expect(rendered).to have_css('a[title="Board"]')
+ end
+ end
+
describe 'container registry tab' do
before do
- project = create(:project, :repository)
stub_container_registry_config(enabled: true)
- assign(:project, project)
- assign(:repository, project.repository)
- allow(view).to receive(:current_ref).and_return('master')
-
- allow(view).to receive(:can?).and_return(true)
allow(controller).to receive(:controller_name)
.and_return('repositories')
allow(controller).to receive(:controller_path)