diff options
| author | Thong Kuah <tkuah@gitlab.com> | 2019-06-20 14:03:21 +1200 |
|---|---|---|
| committer | Thong Kuah <tkuah@gitlab.com> | 2019-07-04 22:22:50 +1200 |
| commit | e5c2c6e4889bdaa7e24dff4300b40bd4f721e5d4 (patch) | |
| tree | a0522f7a3659fe347b089942a163d1a02aeb6f90 | |
| parent | 5bfb7558055adc750a0892a9b99d41ab4b3ce924 (diff) | |
| download | gitlab-ce-12-0-63475-fix-n-1.tar.gz | |
Add failing test showing N+112-0-63475-fix-n-1
We have an N+1 problem where N is environments.
| -rw-r--r-- | spec/controllers/projects/merge_requests_controller_spec.rb | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/spec/controllers/projects/merge_requests_controller_spec.rb b/spec/controllers/projects/merge_requests_controller_spec.rb index 34cbf0c8723..9bf2c5c676d 100644 --- a/spec/controllers/projects/merge_requests_controller_spec.rb +++ b/spec/controllers/projects/merge_requests_controller_spec.rb @@ -878,6 +878,18 @@ describe Projects::MergeRequestsController do expect(control_count).to be <= 137 end + it 'has no N+1 issues for environments', :request_store do + # First run to insert test data from lets, which does take up some 30 queries + get_ci_environments_status + + control_count = ActiveRecord::QueryRecorder.new(skip_cached: false) { get_ci_environments_status }.count + + environment2 = create(:environment, project: forked) + create(:deployment, :succeed, environment: environment2, sha: sha, ref: 'master', deployable: build) + + expect { get_ci_environments_status }.not_to exceed_all_query_limit(control_count) + end + def get_ci_environments_status(extra_params = {}) params = { namespace_id: merge_request.project.namespace.to_param, |