summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGitLab Release Tools Bot <delivery-team+release-tools@gitlab.com>2019-12-10 18:21:30 +0000
committerGitLab Release Tools Bot <delivery-team+release-tools@gitlab.com>2019-12-10 18:21:30 +0000
commiteb797d461f53d4ff105e918ad85b59ff9d8e2e74 (patch)
treed842f5f7a973579bf0132b87211f8d3cef95a365
parente101b3064ee505a9d000c0d08d2bdf7446e30fcc (diff)
parent4fcd588b89f89c8d649c1906540c8579b580eff1 (diff)
downloadgitlab-ce-12-3-stable.tar.gz
Merge remote-tracking branch 'dev/12-3-stable' into 12-3-stable12-3-stable
-rw-r--r--CHANGELOG.md4
-rw-r--r--VERSION2
-rw-r--r--app/services/groups/transfer_service.rb17
3 files changed, 21 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index b6920e2f33e..77420db25fa 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,10 @@
documentation](doc/development/changelog.md) for instructions on adding your own
entry.
+## 12.3.9
+
+- No changes.
+
## 12.3.8
- No changes.
diff --git a/VERSION b/VERSION
index c3c90f17940..43fcd738f05 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-12.3.8-ee
+12.3.9
diff --git a/app/services/groups/transfer_service.rb b/app/services/groups/transfer_service.rb
index fe7e07ef9f0..b73ec5cb737 100644
--- a/app/services/groups/transfer_service.rb
+++ b/app/services/groups/transfer_service.rb
@@ -38,9 +38,15 @@ module Groups
ensure_ownership
end
+ post_update_hooks(@updated_project_ids)
+
true
end
+ # Overridden in EE
+ def post_update_hooks(updated_project_ids)
+ end
+
def ensure_allowed_transfer
raise_transfer_error(:group_is_already_root) if group_is_already_root?
raise_transfer_error(:same_parent_as_current) if same_parent?
@@ -90,9 +96,16 @@ module Groups
.where(id: descendants.select(:id))
.update_all(visibility_level: @new_parent_group.visibility_level)
- @group
+ projects_to_update = @group
.all_projects
.where("visibility_level > ?", @new_parent_group.visibility_level)
+
+ # Used in post_update_hooks in EE. Must use pluck (and not select)
+ # here as after we perform the update below we won't be able to find
+ # these records again.
+ @updated_project_ids = projects_to_update.pluck(:id)
+
+ projects_to_update
.update_all(visibility_level: @new_parent_group.visibility_level)
end
# rubocop: enable CodeReuse/ActiveRecord
@@ -109,3 +122,5 @@ module Groups
end
end
end
+
+Groups::TransferService.prepend_if_ee('EE::Groups::TransferService')