summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnnabel Dunstone Gray <annabel.dunstone@gmail.com>2017-06-05 12:04:11 -0500
committerAnnabel Dunstone Gray <annabel.dunstone@gmail.com>2017-06-05 12:04:11 -0500
commit8cf07bde6a2f03fedb5c133c3e4fd409cdac1663 (patch)
treed719a2ed7349dfb25f70987092fe39aa16a0b750
parent78741cc018daf573d77945eabd0f57a5f814d9c4 (diff)
downloadgitlab-ce-23643-responsive-environment-tables.tar.gz
Add aria labels to sections23643-responsive-environment-tables
-rw-r--r--app/assets/javascripts/environments/components/environment_item.vue12
-rw-r--r--app/assets/javascripts/environments/components/environments_table.vue14
2 files changed, 13 insertions, 13 deletions
diff --git a/app/assets/javascripts/environments/components/environment_item.vue b/app/assets/javascripts/environments/components/environment_item.vue
index 98b3749f7af..03eb51ba1b2 100644
--- a/app/assets/javascripts/environments/components/environment_item.vue
+++ b/app/assets/javascripts/environments/components/environment_item.vue
@@ -423,7 +423,7 @@ export default {
<template>
<div
:class="{ 'js-child-row environment-child-row': model.isChildren, 'folder-row': model.isFolder, 'gl-responsive-table-row': !model.isFolder }">
- <div class="table-section section-10">
+ <div class="table-section section-10" role="gridcell">
<div
v-if="!model.isFolder"
class="table-mobile-header">
@@ -468,7 +468,7 @@ export default {
</span>
</div>
- <div class="table-section section-10 deployment-column hidden-xs hidden-sm">
+ <div class="table-section section-10 deployment-column hidden-xs hidden-sm" role="gridcell">
<span v-if="shouldRenderDeploymentID">
{{deploymentInternalId}}
</span>
@@ -485,7 +485,7 @@ export default {
</span>
</div>
- <div class="table-section section-15 hidden-xs hidden-sm">
+ <div class="table-section section-15 hidden-xs hidden-sm" role="gridcell">
<a
v-if="shouldRenderBuildName"
class="build-link"
@@ -494,7 +494,7 @@ export default {
</a>
</div>
- <div class="table-section section-25">
+ <div class="table-section section-25" role="gridcell">
<div
v-if="!model.isFolder"
class="table-mobile-header">
@@ -518,7 +518,7 @@ export default {
</div>
</div>
- <div class="table-section section-10">
+ <div class="table-section section-10" role="gridcell">
<div
v-if="!model.isFolder"
class="table-mobile-header">
@@ -531,7 +531,7 @@ export default {
</span>
</div>
- <div class="table-section section-30 environments-actions table-button-footer">
+ <div class="table-section section-30 environments-actions table-button-footer" role="gridcell">
<div
v-if="!model.isFolder"
class="btn-group environment-action-buttons"
diff --git a/app/assets/javascripts/environments/components/environments_table.vue b/app/assets/javascripts/environments/components/environments_table.vue
index 6f12b49a09e..f9262ab85c5 100644
--- a/app/assets/javascripts/environments/components/environments_table.vue
+++ b/app/assets/javascripts/environments/components/environments_table.vue
@@ -45,21 +45,21 @@ export default {
};
</script>
<template>
- <div class="ci-table">
- <div class="gl-responsive-table-row table-row-header">
- <div class="table-section section-10 environments-name">
+ <div class="ci-table" role="grid">
+ <div class="gl-responsive-table-row table-row-header" role="row">
+ <div class="table-section section-10 environments-name" role="rowheader">
Environment
</div>
- <div class="table-section section-10 environments-deploy">
+ <div class="table-section section-10 environments-deploy" role="rowheader">
Deployment
</div>
- <div class="table-section section-15 environments-build">
+ <div class="table-section section-15 environments-build" role="rowheader">
Job
</div>
- <div class="table-section section-25 environments-commit">
+ <div class="table-section section-25 environments-commit" role="rowheader">
Commit
</div>
- <div class="table-section section-10 environments-date">
+ <div class="table-section section-10 environments-date" role="rowheader">
Updated
</div>
</div>